goddamit

CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.5)
+cmake_minimum_required(VERSION 3.0)
 # DO NOT CHANGE THIS SRB2 STRING! Some variable names depend on this string.
 # Version change is fine.
 project(SRB2

LUASTUFF.md

@@ -156,11 +156,6 @@ Add Gamepad Rumble support for things.
 To be used with Displayplayers.
 Duration is in milliseconds and is optional to set, default value is 84ms.
 
-## P_CheckSightFast(mo1, mo2)
-
-Exactly same as P_CheckSight but uses cheaper algorithm, useful for things like nametags. Doesn't work exactly
-like P_CheckSight so don't use it for anything gameplay-related.
-
 # Other changes
 
 ## P_PlayRinglossSound(source, damager)

SRB2.cbp

@@ -1726,6 +1726,11 @@ HW3SOUND for 3D hardware sound  support
 			<Option compilerVar="CC" />
 		</Unit>
 		<Unit filename="src/r_draw.h" />
+		<Unit filename="src/r_draw16.c">
+			<Option compilerVar="CC" />
+			<Option compile="0" />
+			<Option link="0" />
+		</Unit>
 		<Unit filename="src/r_draw8.c">
 			<Option compilerVar="CC" />
 			<Option compile="0" />

Srb2.dev

@@ -773,6 +773,16 @@ Priority=1000
 OverrideBuildCmd=0
 BuildCmd=
 
+[Unit79]
+FileName=src\r_draw16.c
+Folder=R_Rend
+Compile=0
+CompileCpp=0
+Link=0
+Priority=1000
+OverrideBuildCmd=0
+BuildCmd=
+
 [Unit80]
 FileName=src\r_draw8.c
 Folder=R_Rend

comptime.bat

@@ -1,32 +1,32 @@
-@echo off
-set BRA=Unknown
-set REV=illegal
-
-copy nul: /b +%1\comptime.c tmp.$$$ > nul
-move tmp.$$$ %1\comptime.c > nul
-
-if exist .git goto gitrev
-if exist ..\.git goto gitrev
-if exist .svn goto svnrev
-goto filwri
-
-:gitrev
-set GIT=%2
-if "%GIT%"=="" set GIT=git
-for /f "usebackq" %%s in (`%GIT% rev-parse --abbrev-ref HEAD`) do @set BRA=%%s
-for /f "usebackq" %%s in (`%GIT% rev-parse HEAD`) do @set REV=%%s
-set REV=%REV:~0,8%
-goto filwri
-
-:svnrev
-set BRA=Subversion
-for /f "usebackq" %%s in (`svnversion .`) do @set REV=%%s
-set REV=r%REV%
-goto filwri
-
-:filwri
-echo // Do not edit!  This file was autogenerated > %1\comptime.h
-echo // by the %0 batch file >> %1\comptime.h
-echo // >> %1\comptime.h
-echo const char* compbranch = "%BRA%"; >> %1\comptime.h
-echo const char* comprevision = "%REV%"; >> %1\comptime.h
+@echo off
+set BRA=Unknown
+set REV=illegal
+
+copy nul: /b +%1\comptime.c tmp.$$$ > nul
+move tmp.$$$ %1\comptime.c > nul
+
+if exist .git goto gitrev
+if exist ..\.git goto gitrev
+if exist .svn goto svnrev
+goto filwri
+
+:gitrev
+set GIT=%2
+if "%GIT%"=="" set GIT=git
+for /f "usebackq" %%s in (`%GIT% rev-parse --abbrev-ref HEAD`) do @set BRA=%%s
+for /f "usebackq" %%s in (`%GIT% rev-parse HEAD`) do @set REV=%%s
+set REV=%REV:~0,8%
+goto filwri
+
+:svnrev
+set BRA=Subversion
+for /f "usebackq" %%s in (`svnversion .`) do @set REV=%%s
+set REV=r%REV%
+goto filwri
+
+:filwri
+echo // Do not edit!  This file was autogenerated > %1\comptime.h
+echo // by the %0 batch file >> %1\comptime.h
+echo // >> %1\comptime.h
+echo const char* compbranch = "%BRA%"; >> %1\comptime.h
+echo const char* comprevision = "%REV%"; >> %1\comptime.h

comptime.sh

@@ -17,7 +17,7 @@ EOF
 
 versiongit() {
 	gitbranch="$(git rev-parse --abbrev-ref HEAD)"
-	gitversion="$(git show --pretty=format:'%h %s' -s HEAD | sed 's/"/\\"/g')"
+	gitversion="$(git rev-parse HEAD | cut -c -8)"
 	version "$gitbranch" "$gitversion";
 	exit 0
 }

src/.gitignore

@@ -1,4 +1,2 @@
 /cscope.out
 /srb2wii
-*.json
-*.idx

src/CMakeLists.txt

@@ -129,7 +129,6 @@ set(SRB2_CORE_RENDER_SOURCES
 	r_fps.c
 	r_main.c
 	r_patch.c
-	r_patchrotation.c
 	r_plane.c
 	r_segs.c
 	r_sky.c
@@ -144,8 +143,7 @@ set(SRB2_CORE_RENDER_SOURCES
 	r_fps.h
 	r_local.h
 	r_main.h
-	r_patch.h
-	r_patchrotation.h
+	r_patch
 	r_plane.h
 	r_segs.h
 	r_sky.h
@@ -175,7 +173,6 @@ set(SRB2_CORE_GAME_SOURCES
 	p_user.c
 	k_director.c
 	k_kart.c
-	k_stats.c
 	i_time.c
 
 	p_local.h
@@ -190,7 +187,6 @@ set(SRB2_CORE_GAME_SOURCES
 	p_tick.h
 	k_director.h
 	k_kart.h
-	k_stats.h
 )
 
 if(NOT (CMAKE_CXX_COMPILER_ID MATCHES "Clang"))

src/Makefile

@@ -81,19 +81,18 @@ ALL_SYSTEMS=\
 ifeq (,$(filter $(ALL_SYSTEMS),$(.VARIABLES)))
 ifeq ($(OS),Windows_NT) # all windows are Windows_NT...
 
- ifeq ($(shell uname -s | grep -o MINGW64),MINGW64) # 64-bit MinGW
-  $(info Detected a Windows system, compiling for 64-bit MinGW SDL2...)
-  MINGW64=1
- else # 32-bit MinGW
-  $(info Detected a Windows system, compiling for 32-bit MinGW SDL2...)
-  MINGW=1
- endif
+ $(info Detected a Windows system, compiling for 32-bit MinGW SDL2...)
 
+ # go for a 32-bit sdl mingw exe by default
+ MINGW=1
  SDL=1
  WINDOWSHELL=1
- NOOBJDUMP=1
+ NOUPX=1
 
 else # if you on the *nix
+
+ NOUPX=1
+
  system:=$(shell uname -s)
 
  ifeq ($(system),Linux)
@@ -117,7 +116,6 @@ else # if you on the *nix
 endif
 endif
 
-NOUPX=1
 
 # SRB2 data files
 D_DIR?=../bin/Resources
@@ -195,6 +193,8 @@ endif
 endif
 
 ifndef NONET
+ifndef NOSATURNSYNCH
+DOSATURNSYNCH=1
 ifndef NOSATURNJOIN
 DOSATURNJOIN=1
 endif
@@ -202,6 +202,7 @@ ifndef NOSATURNPAK
 DOSATURNPAK=1
 endif
 endif
+endif
 
 ifdef MINGW
 include win32/Makefile.cfg
@@ -296,10 +297,6 @@ ifdef X86_64
 endif
 endif
 
-# apparently MingW just completely ignores everything so just always force this shit
-# FIXME: we should port our code to c24
-CFLAGS+=-std=gnu17
-CPPFLAGS+=-std=gnu17
 
 ifndef NOPNG
 OPTS+=-DHAVE_PNG
@@ -388,6 +385,8 @@ endif
 endif
 
 ifndef NONET
+ifndef NOSATURNSYNCH
+OPTS+=-DDOSATURNSYNCH
 ifndef NOSATURNJOIN
 OPTS+=-DDOSATURNJOIN
 endif
@@ -395,6 +394,7 @@ ifndef NOSATURNPAK
 OPTS+=-DDOSATURNPAK
 endif
 endif
+endif
 
 ifdef HAVE_MINIUPNPC
 ifdef NONET
@@ -451,24 +451,7 @@ else
 	# build a normal optimised version
 	WINDRESFLAGS = -DNDEBUG
 	CFLAGS+=-O3
-	CPPFLAGS+=-O3
 endif
-
-ifndef DEBUGMODE
-ifdef USELTO
-	# compile with LTO
-	CFLAGS+=-flto=auto
-	CPPFLAGS+=-flto=auto
-endif
-endif
-
-ifdef USEASAN
-	# compile with asan
-	CFLAGS+=-fsanitize=address
-	CPPFLAGS+=-fsanitize=address
-	LDFLAGS+=-fsanitize=address
-endif
-
 	CFLAGS+=-g $(OPTS) $(ARCHOPTS) $(WINDRESFLAGS)
 
 ifdef PROFILEMODE
@@ -523,7 +506,6 @@ OBJS:=$(i_main_o) \
 		$(OBJDIR)/st_stuff.o \
 		$(OBJDIR)/k_director.o   \
 		$(OBJDIR)/k_kart.o   \
-		$(OBJDIR)/k_stats.o  \
 		$(OBJDIR)/m_aatree.o \
 		$(OBJDIR)/m_anigif.o \
 		$(OBJDIR)/m_argv.o   \
@@ -566,7 +548,6 @@ OBJS:=$(i_main_o) \
 		$(OBJDIR)/r_sky.o    \
 		$(OBJDIR)/r_splats.o \
 		$(OBJDIR)/r_patch.o  \
-		$(OBJDIR)/r_patchrotation.o  \
 		$(OBJDIR)/r_things.o \
 		$(OBJDIR)/r_portal.o \
 		$(OBJDIR)/screen.o   \
@@ -790,10 +771,30 @@ $(OBJDIR)/SRB2.res: win32/Srb2win.rc win32/afxres.h win32/resource.h
 	$(WINDRES) -i $< -O rc $(WINDRESFLAGS) --include-dir=win32 -o $@ -O coff
 
 ifdef SDL
+
 ifdef MINGW
 $(OBJDIR)/win_dbg.o: win32/win_dbg.c
 	$(CC) $(CFLAGS) $(WFLAGS) -c $< -o $@
 endif
+
+ifdef FILTERS
+$(OBJDIR)/%.o: $(INTERFACE)/filter/%.c
+	@echo $< needs deps
+	$(CC) $(CFLAGS) $(WFLAGS) -c $< -o $@
+
+$(OBJDIR)/filters.o: $(INTERFACE)/filter/filters.c $(INTERFACE)/filter/filters.c \
+ $(INTERFACE)/filter/filters.h
+	$(CC) $(CFLAGS) $(WFLAGS) -c $< -o $@
+
+$(OBJDIR)/hq2x.o: $(INTERFACE)/filter/hq2x.c $(INTERFACE)/filter/hq2x.c \
+ $(INTERFACE)/filter/filters.h
+	$(CC) $(CFLAGS) $(WFLAGS) -c $< -o $@
+
+$(OBJDIR)/lq2x.o: $(INTERFACE)/filter/lq2x.c $(INTERFACE)/filter/lq2x.c \
+ $(INTERFACE)/filter/filters.h $(INTERFACE)/filter/interp.h \
+ $(INTERFACE)/filter/hq2x.h $(INTERFACE)/filter/lq2x.h
+	$(CC) $(CFLAGS) $(WFLAGS) -c $< -o $@
+endif
 endif
 
 #############################################################

src/Makefile.cfg

@@ -12,7 +12,6 @@
 # to avoid a false positive with the version detection...
 
 SUPPORTED_GCC_VERSIONS:=\
-	151 150 15\
 	142 141 140 14\
 	132 131 130 13\
 	123 122 121 120 12\
@@ -79,18 +78,6 @@ ifeq   (,$(filter GCC%,$(.VARIABLES)))
  endif
 endif
 
-ifdef GCC151
-GCC150=1
-endif
-
-ifdef GCC15
-GCC150=1
-endif
-
-ifdef GCC150
-GCC142=1
-endif
-
 ifdef GCC142
 GCC141=1
 endif
@@ -482,6 +469,7 @@ ifdef GCC81
  WFLAGS+=-Wno-error=multistatement-macros
 endif
 
+
 #indicate platform and what interface use with
 ifndef LINUX
 ifndef FREEBSD

src/am_map.c

@@ -28,15 +28,14 @@
 #endif
 
 // For use if I do walls with outsides/insides
-static const UINT8 REDS        = (8*16);
+static const UINT8 REDS        = (2*16);
 static const UINT8 REDRANGE    = 16;
 static const UINT8 GRAYS       = (1*16);
 static const UINT8 GRAYSRANGE  = 16;
-static const UINT8 BROWNS      = (3*16);
-static const UINT8 YELLOWS     = (7*16);
-static const UINT8 GREENS      = (10*16);
-//static const UINT8 CYANS     = (13*16);
-static const UINT8 BLUES       = (14*16);
+static const UINT8 BROWNS      = (15*16);
+static const UINT8 YELLOWS     = (5*16)+8;
+static const UINT8 GREENS      = (6*16);
+static const UINT8 BLUES       = (9*16);
 static const UINT8 DBLACK      = 31;
 static const UINT8 DWHITE      = 0;
 
@@ -47,7 +46,7 @@ static const UINT8 DWHITE      = 0;
 #define THOKWALLCOLORS        REDS
 #define THOKWALLRANGE         REDRANGE
 #define TSWALLCOLORS          DWHITE
-#define TSFINISHLINE          (GREENS + 2)
+#define TSFINISHLINE          GRAYS
 #define TSFOFINFO             (BLUES + 4)
 #define FDWALLCOLORS          BROWNS
 #define CDWALLCOLORS          YELLOWS
@@ -265,6 +264,9 @@ static void AM_findMinMaxBoundaries(void)
 	max_w = minimapinfo.map_w << MAPBITS;
 	max_h = minimapinfo.map_h << MAPBITS;
 
+	max_w = (max_x >>= FRACTOMAPBITS) - (min_x >>= FRACTOMAPBITS);
+	max_h = (max_y >>= FRACTOMAPBITS) - (min_y >>= FRACTOMAPBITS);
+
 	a = FixedDiv(f_w<<FRACBITS, max_w);
 	b = FixedDiv(f_h<<FRACBITS, max_h);
 
@@ -422,7 +424,6 @@ static void AM_setWindowPanning(void)
 		m_paninc.y = -FTOM(F_PANINC);
 	else
 		m_paninc.y = 0;
-
 	// left and right
 	if (m_keydown[0]) // pan right
 		m_paninc.x = FTOM(F_PANINC);
@@ -898,74 +899,38 @@ static void AM_drawGrid(INT32 color)
 	}
 }
 
-static INT32 GetDamage(INT32 special)
-{
-	switch (special)
-	{
-		case 1: // Damage (Generic)
-			return 1;
-		case 6: // Death Pit (Camera Tilt)
-			return 6;
-		case 7: // Death Pit (No Camera Tilt)
-			return 7;
-		case 8: // Instant Kill
-			return 8;
-		default:
-			return 0;
-	}
-}
-
-static INT32 GetOffroad(INT32 special)
-{
-	switch (special)
-	{
-		case 2: // Offroad (Weak)
-			return 2;
-		case 3: // Offroad
-			return 3;
-		case 4: // Offroad (Strong)
-			return 4;
-		default:
-			return 0;
-	}
-}
-
 #define SLOPEPARAMS(slope, end1, end2, normalheight) \
-	end1 = (P_GetZAt(slope, lines[i].v1->x, lines[i].v1->y, ((normalheight + FRACUNIT/2) >> FRACBITS)) + FRACUNIT/2) >> FRACBITS; \
-	end2 = (P_GetZAt(slope, lines[i].v2->x, lines[i].v2->y, ((normalheight + FRACUNIT/2) >> FRACBITS)) + FRACUNIT/2) >> FRACBITS;
+		if (slope) { \
+			end1 = (P_GetZAt(slope, lines[i].v1->x, lines[i].v1->y) + FRACUNIT/2) >> FRACBITS; \
+			end2 = (P_GetZAt(slope, lines[i].v2->x, lines[i].v2->y) + FRACUNIT/2) >> FRACBITS; \
+		} else \
+			end1 = end2 = (normalheight + FRACUNIT/2) >> FRACBITS;
 
 static ffloor_t *AM_CompareFOFs(size_t i, ffloor_t *rover, ffloor_t *secondarystore)
 {
 	ffloor_t *secondaryrover = NULL;
-
 	for (; rover; rover = rover->next)
 	{
 		fixed_t rovt1, rovt2;
 		fixed_t rovb1, rovb2;
-
 		if (!(rover->flags & FF_EXISTS))
 			continue;
 		if (!(rover->flags & FF_BLOCKPLAYER))
 			continue;
-
 		SLOPEPARAMS(*rover->t_slope, rovt1, rovt2, *rover->topheight)
 		SLOPEPARAMS(*rover->b_slope, rovb1, rovb2, *rover->bottomheight)
-
 		for (secondaryrover = secondarystore; secondaryrover; secondaryrover = secondaryrover->next)
 		{
 			fixed_t sect1, sect2;
 			fixed_t secb1, secb2;
-
 			if (!(secondaryrover->flags & FF_EXISTS))
 				continue;
 			if (!(secondaryrover->flags & FF_BLOCKPLAYER))
 				continue;
 			if (secondaryrover->secnum == rover->secnum)
 				break;
-
 			SLOPEPARAMS(*secondaryrover->t_slope, sect1, sect2, *secondaryrover->topheight)
 			SLOPEPARAMS(*secondaryrover->b_slope, secb1, secb2, *secondaryrover->bottomheight)
-
 			if (rovt1 != sect1)
 				continue;
 			if (rovt2 != sect2)
@@ -974,27 +939,8 @@ static ffloor_t *AM_CompareFOFs(size_t i, ffloor_t *rover, ffloor_t *secondaryst
 				continue;
 			if (rovb2 != secb2)
 				continue;
-
-			// this is fucking horrible
-			INT32 damage1, damage2;
-			INT32 offroad1, offroad2;
-			INT32 special1, special2;
-			special1 = GETSECSPECIAL(sectors[rover->secnum].special, 1);
-			special2 = GETSECSPECIAL(sectors[secondaryrover->secnum].special, 1);
-
-			damage1 = GetDamage(special1);
-			damage2 = GetDamage(special2);
-			offroad1 = GetOffroad(special1);
-			offroad2 = GetOffroad(special2);
-
-			if (damage1 != damage2
-			//|| sectors[rover->secnum].friction != sectors[secondaryrover->secnum].friction
-			|| offroad1 != offroad2)
-				continue;
-
 			break;
 		}
-
 		if (secondaryrover == NULL)
 			break;
 	}
@@ -1037,10 +983,8 @@ static void AM_drawWalls(UINT8 pass)
 			}
 			continue;
 		}
-
 		SLOPEPARAMS(lines[i].backsector->f_slope, backf1,  backf2,  lines[i].backsector->floorheight)
 		SLOPEPARAMS(lines[i].backsector->c_slope, backc1,  backc2,  lines[i].backsector->ceilingheight)
-
 		if ((backf1 == backc1 && backf2 == backc2) // Back is thok barrier
 				 || (frontf1 == frontc1 && frontf2 == frontc2)) // Front is thok barrier
 		{
@@ -1059,28 +1003,29 @@ static void AM_drawWalls(UINT8 pass)
 		}
 		else
 		{
-			if (lines[i].flags & ML_IMPASSIBLE) // (ML_IMPASSABLE|ML_BLOCKPLAYERS)
+			//dont think kart even supports those idk?
+			/*if (lines[i].flags & (ML_IMPASSABLE|ML_BLOCKPLAYERS))
 			{
 				if (pass & PASS_SOLID)
 					AM_drawMline(&l, TSWALLCOLORS); // Completely solid course boundary
 			}
-			else if ((lines[i].flags & ML_EFFECT4) // ML_MIDSOLID
+			else if ((lines[i].flags & ML_MIDSOLID)
 				&& sides[lines->sidenum[0]].midtexture)
 			{
 				if (pass & PASS_SOLID)
 					AM_drawMline(&l, TSWALLCOLORS); // solid midtexture, likely a course boundary
-			}
+			}*/
 			if ((backf1 != frontf1 && abs(backf1 - frontf1) > maxstep)
 				|| (backf2 != frontf2 && abs(backf2 - frontf2) > maxstep))
 			{
 				if (pass & PASS_SOLID)
 					AM_drawMline(&l, TSWALLCOLORS); // floor-wall, likely a course boundary
 			}
-			else if (GETSECSPECIAL(lines[i].frontsector->special, 4) == 10 || GETSECSPECIAL(lines[i].backsector->special, 4) == 10)
+			/*else if (lines[i].special == 2001) // guh its a sector effect in kart idk how to make it work tbh lol
 			{
 				if (pass & PASS_SOLID)
 					AM_drawMline(&l, TSFINISHLINE); // finish line
-			}
+			}*/
 			else if (backf1 != frontf1 || backf2 != frontf2)
 			{
 				if (pass & PASS_INTANGIBLE)
@@ -1102,52 +1047,54 @@ static void AM_drawWalls(UINT8 pass)
 			}
 			else
 			{
-				ffloor_t *rover = NULL;
+				{
+					ffloor_t *rover = NULL;
 
-				if (lines[i].frontsector->ffloors || lines[i].backsector->ffloors)
-				{
-					if (lines[i].backsector->ffloors == NULL)
+					if (lines[i].frontsector->ffloors || lines[i].backsector->ffloors)
 					{
-						// Check frontside for one solid
-						for (rover = lines[i].frontsector->ffloors; rover; rover = rover->next)
+						if (lines[i].backsector->ffloors == NULL)
 						{
-							if (!(rover->flags & FF_EXISTS))
-								continue;
-							if (!(rover->flags & FF_BLOCKPLAYER))
-								continue;
-							break;
+							// Check frontside for one solid
+							for (rover = lines[i].frontsector->ffloors; rover; rover = rover->next)
+							{
+								if (!(rover->flags & FF_EXISTS))
+									continue;
+								if (!(rover->flags & FF_BLOCKPLAYER))
+									continue;
+								break;
+							}
+						}
+						else if (lines[i].frontsector->ffloors == NULL)
+						{
+							// Check backside for one solid
+							for (rover = lines[i].backsector->ffloors; rover; rover = rover->next)
+							{
+								if (!(rover->flags & FF_EXISTS))
+									continue;
+								if (!(rover->flags & FF_BLOCKPLAYER))
+									continue;
+								break;
+							}
+						}
+						else
+						{
+							// Check to see if any secnums exist in one but not the other.
+							rover = AM_CompareFOFs(i, lines[i].frontsector->ffloors, lines[i].backsector->ffloors);
+							if (rover == NULL)
+								rover = AM_CompareFOFs(i, lines[i].backsector->ffloors, lines[i].frontsector->ffloors);
 						}
 					}
-					else if (lines[i].frontsector->ffloors == NULL)
+					if (rover != NULL)
 					{
-						// Check backside for one solid
-						for (rover = lines[i].backsector->ffloors; rover; rover = rover->next)
-						{
-							if (!(rover->flags & FF_EXISTS))
-								continue;
-							if (!(rover->flags & FF_BLOCKPLAYER))
-								continue;
-							break;
-						}
+						if (pass & PASS_FOF)
+							AM_drawMline(&l, TSFOFINFO); // a FOF is here but we don't know how to distinguish them yet
 					}
-					else
+					else if (!am_minigen)
 					{
-						// Check to see if any secnums exist in one but not the other.
-						rover = AM_CompareFOFs(i, lines[i].frontsector->ffloors, lines[i].backsector->ffloors);
-						if (rover == NULL)
-							rover = AM_CompareFOFs(i, lines[i].backsector->ffloors, lines[i].frontsector->ffloors);
+						if (pass & PASS_INTANGIBLE)
+							AM_drawMline(&l, GRIDCOLORS); // likely low-relevance line
 					}
 				}
-				if (rover != NULL)
-				{
-					if (pass & PASS_FOF)
-						AM_drawMline(&l, TSFOFINFO); // a FOF is here but we don't know how to distinguish them yet
-				}
-				else if (!am_minigen)
-				{
-					if (pass & PASS_INTANGIBLE)
-						AM_drawMline(&l, GRIDCOLORS); // likely low-relevance line
-				}
 			}
 		}
 	}
@@ -1225,11 +1172,18 @@ static inline void AM_drawPlayers(void)
 	player_t *p;
 	INT32 color = GREENS;
 
+	if (!multiplayer)
+	{
+		AM_drawLineCharacter(player_arrow, NUMPLYRLINES, 16<<FRACBITS, plr->mo->angle, DWHITE, plr->mo->x, plr->mo->y);
+		return;
+	}
+
+	// multiplayer (how??)
 	for (i = 0; i < MAXPLAYERS; i++)
 	{
 		if (!playeringame[i] || players[i].spectator)
 			continue;
-
+		
 		if (!players[i].mo)
 			continue;
 
@@ -1251,36 +1205,7 @@ static inline void AM_drawThings(UINT8 colors)
 		t = sectors[i].thinglist;
 		while (t)
 		{
-			if (!t->player)
-				AM_drawLineCharacter(thintriangle_guy, NUMTHINTRIANGLEGUYLINES, 16<<FRACBITS, t->angle, colors, t->x, t->y);
-			t = t->snext;
-		}
-	}
-}
-
-static inline void AM_drawSpecialThingsOnly(UINT8 colors)
-{
-	size_t i;
-
-	for (i = 0; i < numsectors; i++)
-	{
-		mobj_t *t = NULL;
-
-		// this is fucking horrible
-		const INT32 special = GETSECSPECIAL(sectors[i].special, 1);
-
-		if (GetDamage(special) != 0
-		//|| sectors[i].friction < ORIG_FRICTION
-		|| GetOffroad(special) != 0)
-			continue;
-
-		t = sectors[i].thinglist;
-		while (t)
-		{
-			if (t->type == MT_RANDOMITEM
-			|| t->type == MT_STARPOST
-			|| (t->flags & MF_SPRING))
-				AM_drawLineCharacter(thintriangle_guy, NUMTHINTRIANGLEGUYLINES, 16<<FRACBITS, t->angle, colors, t->x, t->y);
+			AM_drawLineCharacter(thintriangle_guy, NUMTHINTRIANGLEGUYLINES, 16<<FRACBITS, t->angle, colors, t->x, t->y);
 			t = t->snext;
 		}
 	}
@@ -1295,19 +1220,16 @@ static inline void AM_drawCrosshair(UINT8 color)
 	const fixed_t scale = 4<<FRACBITS;
 	size_t i;
 	fline_t fl;
-
 	for (i = 0; i < NUMCROSSMARKLINES; i++)
 	{
 		fl.a.x = FixedMul(cross_mark[i].a.x, scale) >> FRACBITS;
 		fl.a.y = FixedMul(cross_mark[i].a.y, scale) >> FRACBITS;
 		fl.b.x = FixedMul(cross_mark[i].b.x, scale) >> FRACBITS;
 		fl.b.y = FixedMul(cross_mark[i].b.y, scale) >> FRACBITS;
-
 		fl.a.x += f_x + (f_w / 2);
 		fl.a.y += f_y + (f_h / 2);
 		fl.b.x += f_x + (f_w / 2);
 		fl.b.y += f_y + (f_h / 2);
-
 		AM_drawFline(&fl, color);
 	}
 }
@@ -1328,8 +1250,8 @@ void AM_Drawer(void)
 	AM_clearFB(BACKGROUND);
 	if (draw_grid) AM_drawGrid(GRIDCOLORS);
 	AM_drawWalls(PASS_FOF|PASS_INTANGIBLE|PASS_SOLID);
-	AM_drawThings(THINGCOLORS);
 	AM_drawPlayers();
+	AM_drawThings(THINGCOLORS);
 
 	if (!followplayer) AM_drawCrosshair(XHAIRCOLORS);
 }
@@ -1385,7 +1307,6 @@ minigen_t *AM_MinimapGenerate(INT32 mul)
 
 	//AM_clearFB(BACKGROUND);
 	memset(am_buf, 0xff, (f_w*f_h));
-	AM_drawSpecialThingsOnly(BACKGROUND);
 	AM_drawWalls(PASS_FOF);
 	AM_drawWalls(PASS_INTANGIBLE);
 	AM_drawWalls(PASS_SOLID);

src/command.c

@@ -1493,7 +1493,11 @@ static void Got_NetVar(UINT8 **p, INT32 playernum)
 
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}

src/console.c

@@ -621,11 +621,11 @@ static void CON_MoveConsole(void)
 		con_curlines -= FixedInt(fracmovement);
 		if (con_curlines < con_destlines)
 			con_curlines = con_destlines;
-
+		
 		if (con_destlines == 0) // If the console is being closed, not just moved up...
 			con_tick = 0; // ...don't show the blinking cursor
 	}
-
+	
 	fracmovement %= FRACUNIT; // Reset fracmovement's integer value, but keep the fraction
 
 	Unlock_state();
@@ -635,7 +635,7 @@ INT32 CON_ShiftChar(INT32 ch)
 {
 	if (I_UseNativeKeyboard())
 		return ch;
-
+	
 	if ((ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z'))
 	{
 		if (cv_keyboardlayout.value == 3)
@@ -827,7 +827,7 @@ boolean CON_Responder(event_t *ev)
 	// let go keyup events, don't eat them
 	if (ev->type != ev_keydown && ev->type != ev_console)
 	{
-		if (ev->data1 == gamecontrol[0][gc_console][0] || ev->data1 == gamecontrol[0][gc_console][1])
+		if (ev->data1 == gamecontrol[gc_console][0] || ev->data1 == gamecontrol[gc_console][1])
 			consdown = false;
 		return false;
 	}
@@ -845,7 +845,7 @@ boolean CON_Responder(event_t *ev)
 			INT32 i;
 			for (i = 0; i < num_gamecontrols; i++)
 			{
-				if (gamecontrol[0][i][0] == ev->data1 || gamecontrol[0][i][1] == ev->data1)
+				if (gamecontrol[i][0] == ev->data1 || gamecontrol[i][1] == ev->data1)
 					break;
 			}
 
@@ -853,7 +853,7 @@ boolean CON_Responder(event_t *ev)
 				return false;
 		}
 
-		if (key == gamecontrol[0][gc_console][0] || key == gamecontrol[0][gc_console][1])
+		if (key == gamecontrol[gc_console][0] || key == gamecontrol[gc_console][1])
 		{
 			if (consdown) // ignore repeat
 				return true;
@@ -1244,7 +1244,7 @@ void CONS_Printf(const char *fmt, ...)
 
 	if (con_started)
 		CON_Print(txt);
-
+	
 	CON_LogMessage(txt);
 
 	Lock_state();
@@ -1334,12 +1334,7 @@ void CONS_Error(const char *msg)
 
 	// dirty quick hack, but for the good cause
 	while (I_GetKey() != KEY_ENTER)
-	{
-		// Sleep so we don't take too much of cpu usage
-		I_Sleep(1.f/TICRATE*1000);
-
 		I_OsPolling();
-	}
 }
 
 //======================================================================
@@ -1479,7 +1474,7 @@ static void CON_DrawHudlines(void)
 				;//charwidth = 4 * con_scalefactor;
 			else
 			{
-				//charwidth = hu_font['A'-HU_FONTSTART]->width * con_scalefactor;
+				//charwidth = SHORT(hu_font['A'-HU_FONTSTART]->width) * con_scalefactor;
 				V_DrawCharacter(x, y, (INT32)(*p) | charflags | cv_constextsize.value | V_NOSCALESTART, !cv_allcaps.value);
 			}
 		}
@@ -1514,7 +1509,7 @@ static void CON_DrawConsole(void)
 	// draw console background
 	if (cons_backpic.value || con_forcepic)
 	{
-		patch_t *con_backpic = W_CachePatchName("KARTKREW", PU_PATCH_LOWPRIORITY);
+		patch_t *con_backpic = W_CachePatchName("KARTKREW", PU_CACHE);
 
 		// Jimita: CON_DrawBackpic just called V_DrawScaledPatch
 		V_DrawFixedPatch(0, 0, FRACUNIT/2, 0, con_backpic, NULL);
@@ -1582,11 +1577,11 @@ void CON_Drawer(void)
 	if (con_recalc)
 	{
 		CON_RecalcSize();
-
+		
 		if (con_curlines <= 0)
 			CON_ClearHUD();
 	}
-
+	
 	// console movement
 	if (con_curlines != con_destlines)
 		CON_MoveConsole();

src/d_clisrv.c

@@ -94,7 +94,7 @@ UINT8 playernode[MAXPLAYERS];
 // The actual timeout will be longer depending on the savegame length
 tic_t jointimeout = (3*TICRATE);
 static boolean sendingsavegame[MAXNETNODES]; // Are we sending the savegame?
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static boolean resendingsavegame[MAXNETNODES]; // Are we resending the savegame?
 static tic_t savegameresendcooldown[MAXNETNODES]; // How long before we can resend again?
 #endif
@@ -114,10 +114,10 @@ boolean server_lagless;
 static void Lagless_OnChange(void)
 {
 	/* don't back out of dishonesty, or go lagless after playing honestly */
-	if (!cv_gentlemens.value && gamestate == GS_LEVEL)
+	if (cv_lagless.value && gamestate == GS_LEVEL)
 		server_lagless = true;
 
-	/*if (!cv_gentlemens.value)
+	/*if (cv_lagless.value)
 		HU_AddChatText(M_GetText("\x82*Gentlemans Delay has been disabled for Serverplayer."), false);
 	else
 		HU_AddChatText(M_GetText("\x82*Gentlemans Delay will be enabled for Serverplayer."), false);*/
@@ -125,7 +125,7 @@ static void Lagless_OnChange(void)
 
 static CV_PossibleValue_t mindelay_cons_t[] = {{0, "MIN"}, {30, "MAX"}, {0, NULL}};
 consvar_t cv_mindelay = {"mindelay", "0", CV_SAVE, mindelay_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL};
-consvar_t cv_gentlemens = {"gentlemensdelay", "Off", CV_SAVE|CV_CALL|CV_NOINIT, CV_OnOff, Lagless_OnChange, 0, NULL, NULL, 0, 0, NULL}; // this should be a netvar Zzz...
+consvar_t cv_lagless = {"serverlagless", "On", CV_SAVE|CV_CALL|CV_NOINIT, CV_OnOff, Lagless_OnChange, 0, NULL, NULL, 0, 0, NULL}; // this should be a netvar Zzz...
 
 SINT8 nodetoplayer[MAXNETNODES];
 SINT8 nodetoplayer2[MAXNETNODES]; // say the numplayer for this node if any (splitscreen)
@@ -151,10 +151,12 @@ static UINT32 resynch_status[MAXNETNODES]; // 0 bit means synched for that playe
 static UINT8 resynch_sent[MAXNETNODES][MAXPLAYERS]; // what synch packets have we attempted to send to the player
 static UINT8 resynch_inprogress[MAXNETNODES];
 static UINT8 resynch_local_inprogress = false; // WE are desynched and getting packets to fix it.
+static UINT8 player_joining = false;
 UINT8 hu_resynching = 0;
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 UINT8 hu_redownloadinggamestate = 0;
+static boolean can_receive_gamestate[MAXNETNODES];
 static UINT8 gamestate_resend_counter[MAXNETNODES];
 #endif
 
@@ -167,8 +169,11 @@ static boolean cl_packetmissed;
 // here it is for the secondary local player (splitscreen)
 static UINT8 mynode; // my address pointofview server
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static boolean cl_redownloadinggamestate = false;
+#endif
+
+#ifdef SATURNPAK
 boolean is_client_saturn[MAXNETNODES];
 #endif
 
@@ -230,14 +235,6 @@ consvar_t cv_httpsource = {"http_source", "", CV_SAVE, NULL, NULL, 0, NULL, NULL
 
 consvar_t cv_kicktime = {"kicktime", "10", CV_SAVE, CV_Unsigned, NULL, 0, NULL, NULL, 0, 0, NULL};
 
-static boolean UseLocalDelay(void)
-{
-	if (dedicated || (server && server_lagless && !cv_mindelay.value) || modeattacking == ATTACKING_RECORD)
-		return false;
-
-	return (cv_mindelay.value || (server && !server_lagless));
-}
-
 static inline void *G_DcpyTiccmd(void* dest, const ticcmd_t* src, const size_t n)
 {
 	const size_t d = n / sizeof(ticcmd_t);
@@ -492,7 +489,11 @@ static void ExtraDataTicker(void)
 					{
 						if (server)
 						{
-							SendKick(i, KICK_MSG_CON_FAIL);
+							UINT8 buf[3];
+
+							buf[0] = (UINT8)i;
+							buf[1] = KICK_MSG_CON_FAIL;
+							SendNetXCmd(XD_KICK, &buf, 2);
 							DEBFILE(va("player %d kicked [gametic=%u] reason as follows:\n", i, gametic));
 						}
 						CONS_Alert(CONS_WARNING, M_GetText("Got unknown net command [%s]=%d (max %d)\n"), sizeu1(curpos - bufferstart), *curpos, bufferstart[0]);
@@ -539,15 +540,6 @@ void D_ResetTiccmds(void)
 			D_Clearticcmd(textcmds[i]->tic);
 }
 
-void SendKick(UINT8 playernum, UINT8 msg)
-{
-	UINT8 buf[2];
-
-	buf[0] = playernum;
-	buf[1] = msg;
-	SendNetXCmd(XD_KICK, &buf, 2);
-}
-
 // -----------------------------------------------------------------
 // end of extra data function
 // -----------------------------------------------------------------
@@ -1121,7 +1113,10 @@ static void SV_SendResynch(INT32 node)
 
 	if (resynch_score[node] > (unsigned)cv_resynchattempts.value*250)
 	{
-		SendKick(nodetoplayer[node], KICK_MSG_CON_FAIL);
+		UINT8 buf[2];
+		buf[0] = (UINT8)nodetoplayer[node];
+		buf[1] = KICK_MSG_CON_FAIL;
+		SendNetXCmd(XD_KICK, &buf, 2);
 		resynch_score[node] = 0;
 	}
 }
@@ -1184,6 +1179,11 @@ typedef enum
 static void GetPackets(void);
 
 static cl_mode_t cl_mode = CL_SEARCHING;
+
+#ifdef HAVE_CURL
+char http_source[MAX_MIRROR_LENGTH+1];
+#endif
+
 static UINT16 cl_lastcheckedfilecount = 0;	// used for full file list
 
 // Player name send/load
@@ -1257,10 +1257,10 @@ static inline void CL_DrawConnectionStatus(void)
 		{
 #ifdef JOININGAME
 			case CL_DOWNLOADSAVEGAME:
-				if (filedownload.current != -1)
+				if (lastfilenum != -1)
 				{
-					UINT32 currentsize = fileneeded[filedownload.current].currentsize;
-					UINT32 totalsize = fileneeded[filedownload.current].totalsize;
+					UINT32 currentsize = fileneeded[lastfilenum].currentsize;
+					UINT32 totalsize = fileneeded[lastfilenum].totalsize;
 					INT32 dldlength;
 
 					cltext = M_GetText("Downloading game state...");
@@ -1355,13 +1355,13 @@ static inline void CL_DrawConnectionStatus(void)
 			V_DrawCenteredString(BASEVIDWIDTH/2, BASEVIDHEIGHT-24, V_20TRANS|V_MONOSPACE|MENUCAPS,
 				va(" %2u/%2u Files",loadcompletednum,fileneedednum));
 		}
-		else if (filedownload.current != -1)
+		else if (lastfilenum != -1)
 		{
 			INT32 dldlength;
 			INT32 totalfileslength;
 			UINT32 totaldldsize;
 			static char tempname[28];
-			fileneeded_t *file = &fileneeded[filedownload.current];
+			fileneeded_t *file = &fileneeded[lastfilenum];
 			char *filename = file->filename;
 
 			// Draw the bottom box.
@@ -1400,32 +1400,32 @@ static inline void CL_DrawConnectionStatus(void)
 			V_DrawCenteredString(BASEVIDWIDTH/2, BASEVIDHEIGHT-58-22, V_YELLOWMAP|MENUCAPS,
 				va(M_GetText("\"%s\""), tempname));
 			V_DrawString(BASEVIDWIDTH/2-128, BASEVIDHEIGHT-58, V_20TRANS|V_MONOSPACE|MENUCAPS,
-				va(" %4uK/%4uK",file->currentsize>>10,file->totalsize>>10));
+				va(" %4uK/%4uK",fileneeded[lastfilenum].currentsize>>10,file->totalsize>>10));
 			V_DrawRightAlignedString(BASEVIDWIDTH/2+128, BASEVIDHEIGHT-58, V_20TRANS|V_MONOSPACE|MENUCAPS,
 				va("%3.1fK/s ", ((double)getbps)/1024));
 
 			// Download progress
 
-			if (file->currentsize != file->totalsize)
-				totaldldsize = filedownload.completedsize+file->currentsize; //Add in single file progress download if applicable
+			if (fileneeded[lastfilenum].currentsize != fileneeded[lastfilenum].totalsize)
+				totaldldsize = downloadcompletedsize+fileneeded[lastfilenum].currentsize; //Add in single file progress download if applicable
 			else
-				totaldldsize = filedownload.completedsize;
+				totaldldsize = downloadcompletedsize;
 
 			V_DrawCenteredString(BASEVIDWIDTH/2, BASEVIDHEIGHT-24-14, V_YELLOWMAP|MENUCAPS, "Overall Download Progress");
-			totalfileslength = (INT32)((totaldldsize/(double)filedownload.totalsize) * 256);
+			totalfileslength = (INT32)((totaldldsize/(double)totalfilesrequestedsize) * 256);
 			M_DrawTextBox(BASEVIDWIDTH/2-128-8, BASEVIDHEIGHT-24-8, 32, 1);
 			V_DrawFill(BASEVIDWIDTH/2-128, BASEVIDHEIGHT-24, 256, 8, 175);
 			V_DrawFill(BASEVIDWIDTH/2-128, BASEVIDHEIGHT-24, totalfileslength, 8, 160);
 
-			if (filedownload.totalsize>>20 >= 10) //display in MB if over 10MB
+			if (totalfilesrequestedsize>>20 >= 10) //display in MB if over 10MB
 				V_DrawString(BASEVIDWIDTH/2-128, BASEVIDHEIGHT-24, V_20TRANS|V_MONOSPACE|MENUCAPS,
-					va(" %4uM/%4uM",totaldldsize>>20,filedownload.totalsize>>20));
+					va(" %4uM/%4uM",totaldldsize>>20,totalfilesrequestedsize>>20));
 			else
 				V_DrawString(BASEVIDWIDTH/2-128, BASEVIDHEIGHT-24, V_20TRANS|V_MONOSPACE|MENUCAPS,
-					va(" %4uK/%4uK",totaldldsize>>10,filedownload.totalsize>>10));
+					va(" %4uK/%4uK",totaldldsize>>10,totalfilesrequestedsize>>10));
 
 			V_DrawRightAlignedString(BASEVIDWIDTH/2+128, BASEVIDHEIGHT-24, V_20TRANS|V_MONOSPACE|MENUCAPS,
-					va("%2u/%2u Files ", filedownload.completednum, filedownload.totalnum));
+					va("%2u/%2u Files ",downloadcompletednum,totalfilesrequestednum));
 		}
 		else
 		{
@@ -1822,7 +1822,7 @@ static boolean SV_SendServerConfig(INT32 node)
 #ifdef JOININGAME
 #define SAVEGAMESIZE (768*1024)
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static boolean SV_ResendingSavegameToAnyone(void)
 {
 	INT32 i;
@@ -2009,7 +2009,7 @@ static void CL_LoadReceivedSavegame(boolean reloading)
 	consistancy[gametic%TICQUEUE] = Consistancy();
 	CON_ToggleOff();
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	// Tell the server we have received and reloaded the gamestate
 	// so they know they can resume the game
 	if (reloading)
@@ -2020,7 +2020,7 @@ static void CL_LoadReceivedSavegame(boolean reloading)
 #endif
 }
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static void CL_ReloadReceivedSavegame(void)
 {
 	INT32 i;
@@ -2186,7 +2186,7 @@ void CL_QueryServerList (msg_server_t *server_list)
 		{
 			INT32 node = I_NetMakeNodewPort(server_list[i].ip, server_list[i].port);
 			if (node == -1)
-				continue; // no more node free, or resolution failure
+				break; // no more node free
 			SendAskInfo(node);
 			resendserverlistnode[node] = true;
 			// Leave this node open. It'll be closed if the
@@ -2231,10 +2231,10 @@ void CL_TimeoutServerList(void)
 
 static void CL_ConfirmConnect(void)
 {
-	if (filedownload.totalnum > 0)
+	if (totalfilesrequestednum > 0)
 	{
 #ifdef HAVE_CURL
-		if (filedownload.http_source[0] == '\0' || filedownload.http_failed)
+		if (http_source[0] == '\0' || curl_failedwebdownload)
 #endif
 		{
 			if (CL_SendRequestFile())
@@ -2261,13 +2261,13 @@ static void M_ConfirmConnect(event_t *ev)
 #ifndef NONET
 	if (ev->type == ev_keydown)
 	{
-		if (ev->data1 == ' ' || ev->data1 == 'y' || ev->data1 == KEY_ENTER || ev->data1 == gamecontrol[0][gc_accelerate][0] || ev->data1 == gamecontrol[0][gc_accelerate][1])
+		if (ev->data1 == ' ' || ev->data1 == 'y' || ev->data1 == KEY_ENTER || ev->data1 == gamecontrol[gc_accelerate][0] || ev->data1 == gamecontrol[gc_accelerate][1])
 		{
 			CL_ConfirmConnect();
 
 			M_ClearMenus(true);
 		}
-		else if (ev->data1 == 'n' || ev->data1 == KEY_ESCAPE|| ev->data1 == gamecontrol[0][gc_brake][0] || ev->data1 == gamecontrol[0][gc_brake][1])
+		else if (ev->data1 == 'n' || ev->data1 == KEY_ESCAPE|| ev->data1 == gamecontrol[gc_brake][0] || ev->data1 == gamecontrol[gc_brake][1])
 		{
 			cl_mode = CL_ABORTED;
 			M_ClearMenus(true);
@@ -2347,7 +2347,7 @@ static boolean CL_FinishedFileList(void)
 		// must download something
 		// can we, though?
 #ifdef HAVE_CURL
-		if (filedownload.http_source[0] == '\0' || filedownload.http_failed)
+		if (http_source[0] == '\0' || curl_failedwebdownload)
 #endif
 		{
 			if (!CL_CheckDownloadable()) // nope!
@@ -2367,31 +2367,30 @@ static boolean CL_FinishedFileList(void)
 		}
 
 #ifdef HAVE_CURL
-		if (!filedownload.http_failed)
+		if (!curl_failedwebdownload)
 #endif
 		{
 #ifndef NONET
-			filedownload.completednum = 0;
-			filedownload.completedsize = 0;
-
-			filedownload.totalnum = 0;
-			filedownload.totalsize = 0;
+			downloadcompletednum = 0;
+			downloadcompletedsize = 0;
+			totalfilesrequestednum = 0;
+			totalfilesrequestedsize = 0;
 #endif
 
 			for (i = 0; i < fileneedednum; i++)
 				if (fileneeded[i].status == FS_NOTFOUND || fileneeded[i].status == FS_MD5SUMBAD)
 				{
 #ifndef NONET
-					filedownload.totalnum++;
-					filedownload.totalsize += fileneeded[i].totalsize;
+					totalfilesrequestednum++;
+					totalfilesrequestedsize += fileneeded[i].totalsize;
 #endif
 				}
 
 #ifndef NONET
-			if (filedownload.totalsize>>20 >= 10)
-				downloadsize = Z_StrDup(va("%uM",filedownload.totalsize>>20));
+			if (totalfilesrequestedsize>>20 >= 10)
+				downloadsize = Z_StrDup(va("%uM",totalfilesrequestedsize>>20));
 			else
-				downloadsize = Z_StrDup(va("%uK",filedownload.totalsize>>10));
+				downloadsize = Z_StrDup(va("%uK",totalfilesrequestedsize>>10));
 #endif
 
 			if (cv_showdownloadprompt.value)
@@ -2476,9 +2475,9 @@ static boolean CL_ServerConnectionSearchTicker(tic_t *asksent)
 		{
 #ifdef HAVE_CURL
 			if (serverlist[i].info.httpsource[0])
-				strncpy(filedownload.http_source, serverlist[i].info.httpsource, MAX_MIRROR_LENGTH);
+				strncpy(http_source, serverlist[i].info.httpsource, MAX_MIRROR_LENGTH);
 			else
-				filedownload.http_source[0] = '\0';
+				http_source[0] = '\0';
 #else
 			if (serverlist[i].info.httpsource[0])
 				CONS_Printf("We received a http url from the server, however it will not be used as this build lacks curl support (%s)\n", serverlist[i].info.httpsource);
@@ -2561,12 +2560,12 @@ static boolean CL_ServerConnectionTicker(const char *tmpsave, tic_t *oldtic, tic
 			break;
 #ifdef HAVE_CURL
 		case CL_PREPAREHTTPFILES:
-			if (filedownload.http_source[0])
+			if (http_source[0])
 			{
 				for (i = 0; i < fileneedednum; i++)
 					if (fileneeded[i].status == FS_NOTFOUND || fileneeded[i].status == FS_MD5SUMBAD)
 					{
-						filedownload.remaining++;
+						curl_transfers++;
 					}
 
 				cl_mode = CL_DOWNLOADHTTPFILES;
@@ -2578,8 +2577,8 @@ static boolean CL_ServerConnectionTicker(const char *tmpsave, tic_t *oldtic, tic
 			for (i = 0; i < fileneedednum; i++)
 				if (fileneeded[i].status == FS_NOTFOUND || fileneeded[i].status == FS_MD5SUMBAD)
 				{
-					if (!filedownload.http_running)
-						CURLPrepareFile(filedownload.http_source, i);
+					if (!curl_running)
+						CURLPrepareFile(http_source, i);
 					waitmore = true;
 					break;
 				}
@@ -2587,14 +2586,14 @@ static boolean CL_ServerConnectionTicker(const char *tmpsave, tic_t *oldtic, tic
 			if (waitmore)
 				break; // exit the case
 
-			if (filedownload.http_failed && !filedownload.remaining)
+			if (curl_failedwebdownload && !curl_transfers)
 			{
 				CONS_Printf("One or more files failed to download, falling back to internal downloader\n");
 				cl_mode = CL_CHECKFILES;
 				break;
 			}
 
-			if (!filedownload.remaining)
+			if (!curl_transfers)
 				cl_mode = CL_LOADFILES;
 
 			break;
@@ -2771,7 +2770,7 @@ static void CL_ConnectToServer(void)
 #endif
 
 #ifdef CLIENT_LOADINGSCREEN
-	filedownload.current = -1;
+	lastfilenum = -1;
 #endif
 
 	cl_mode = CL_SEARCHING;
@@ -3156,14 +3155,12 @@ static void Command_connect(void)
 		return;
 	}
 
-	if (Playing() || demo.title || demo.playback)
+	M_ClearMenus(true);
+
+	if (Playing() || demo.title)
 	{
-		if (demo.title || demo.playback)
-		{
+		if (demo.title)
 			G_CheckDemoStatus();
-			if (multiplayer && !demo.title) // dumb hack: G_CheckDemoStatus doesent call G_StopDemo for multiplayer demos
-				G_StopDemo();
-		}
 
 		if (netgame)
 		{
@@ -3173,8 +3170,6 @@ static void Command_connect(void)
 
 		D_StartTitle();
 	}
-	else
-		M_ClearMenus(true); // close the menus
 
 	// modified game check: no longer handled
 	// we don't request a restart unless the filelist differs
@@ -3263,7 +3258,6 @@ void CL_ClearPlayer(INT32 playernum)
 			P_RemoveMobj(players[playernum].mo->tracer);
 		P_RemoveMobj(players[playernum].mo);
 	}
-
 	memset(&players[playernum], 0, sizeof (player_t));
 }
 
@@ -3343,7 +3337,7 @@ void CL_RemovePlayer(INT32 playernum, INT32 reason)
 	// remove avatar of player
 	playeringame[playernum] = false;
 	playernode[playernum] = UINT8_MAX;
-	while ((doomcom->numslots > 1) && !playeringame[doomcom->numslots-1])
+	while (!playeringame[doomcom->numslots-1] && doomcom->numslots > 1)
 		doomcom->numslots--;
 
 	// Reset the name
@@ -3413,18 +3407,18 @@ void CL_Reset(void)
 	memset(packetstat, 0, sizeof(packetstat));
 
 #ifndef NONET
-	filedownload.totalnum = 0;
-	filedownload.totalsize = 0;
+	totalfilesrequestednum = 0;
+	totalfilesrequestedsize = 0;
 #endif
 	firstconnectattempttime = 0;
 	serverisfull = false;
 	connectiontimeout = (tic_t)cv_nettimeout.value; //reset this temporary hack
 
 #ifdef HAVE_CURL
-	filedownload.remaining = 0;
-	filedownload.http_failed = false;
-	filedownload.http_running = false;
-	filedownload.http_source[0] = '\0';
+	curl_failedwebdownload = false;
+	curl_transfers = 0;
+	curl_running = false;
+	http_source[0] = '\0';
 #endif
 	G_ResetAllDeviceRumbles();
 
@@ -4089,7 +4083,7 @@ static void Command_list_http_logins (void)
 }
 #endif/*HAVE_CURL*/
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static void Command_ResendGamestate(void)
 {
 	SINT8 playernum;
@@ -4146,7 +4140,7 @@ consvar_t cv_discordinvites = {"discordinvites", "Everyone", CV_SAVE|CV_CALL, di
 static CV_PossibleValue_t resynchattempts_cons_t[] = {{0, "MIN"}, {20, "MAX"}, {0, NULL}};
 consvar_t cv_resynchattempts = {"resynchattempts", "2", CV_SAVE, resynchattempts_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL};
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static CV_PossibleValue_t gamestateattempts_cons_t[] = {{0, "MIN"}, {30, "MAX"}, {0, NULL}};
 consvar_t cv_gamestateattempts = {"gamestateresendattempts", "10", CV_SAVE, gamestateattempts_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL};
 
@@ -4210,7 +4204,7 @@ void D_ClientServerInit(void)
 	COM_AddCommand("reloadbans", Command_ReloadBan);
 	COM_AddCommand("connect", Command_connect);
 	COM_AddCommand("nodes", Command_Nodes);
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	COM_AddCommand("resendgamestate", Command_ResendGamestate);
 #endif
 	COM_AddCommand("listplayers", Command_Listplayers);
@@ -4270,7 +4264,11 @@ static void ResetNode(INT32 node)
 	// SATURN
 #ifdef SATURNPAK
 	is_client_saturn[node] = false;
+#endif
+
+#ifdef SATURNSYNCH
 	resendingsavegame[node] = false;
+	can_receive_gamestate[node] = false;
 	savegameresendcooldown[node] = 0;
 	gamestate_resend_counter[node] = 0;
 #endif
@@ -4316,7 +4314,7 @@ void SV_ResetServer(void)
 
 	mynode = 0;
 	cl_packetmissed = false;
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	cl_redownloadinggamestate = false;
 #endif
 
@@ -4391,9 +4389,6 @@ void D_QuitNetGame(void)
 		HSendPacket(servernode, true, 0, 0);
 	}
 
-#ifdef SEENAMES
-	seenplayer = NULL;
-#endif
 	D_CloseConnection();
 	ClearAdminPlayers();
 
@@ -4433,7 +4428,11 @@ static void Got_AddPlayer(UINT8 **p, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal add player command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -4517,7 +4516,11 @@ static void Got_RemovePlayer(UINT8 **p, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal remove player command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -4624,10 +4627,14 @@ void CL_AddSplitscreenPlayer(void)
 
 void CL_RemoveSplitscreenPlayer(UINT8 p)
 {
+	UINT8 buf[2];
+
 	if (cl_mode != CL_CONNECTED)
 		return;
 
-	SendKick(p, KICK_MSG_PLAYER_QUIT);
+	buf[0] = p;
+	buf[1] = KICK_MSG_PLAYER_QUIT;
+	SendNetXCmd(XD_KICK, &buf, 2);
 }
 
 // is there a game running
@@ -4870,6 +4877,7 @@ static void HandleConnect(SINT8 node)
 				DEBFILE("send savegame\n");
 			}
 			SV_AddWaitingPlayers();
+			player_joining = true;
 		}
 #else
 #ifndef NONET
@@ -4937,7 +4945,7 @@ static void HandleServerInfo(SINT8 node)
 }
 #endif
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 static void PT_WillResendGamestate(void)
 {
 	char tmpsave[264];
@@ -5252,8 +5260,13 @@ static boolean CheckForSpeedHacks(UINT8 p)
 		|| netcmds[maketic%TICQUEUE][p].sidemove > MAXPLMOVE || netcmds[maketic%TICQUEUE][p].sidemove < -MAXPLMOVE
 		|| netcmds[maketic%TICQUEUE][p].driftturn > KART_FULLTURN || netcmds[maketic%TICQUEUE][p].driftturn < -KART_FULLTURN)
 	{
+		char buf[2];
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal movement value received from node %d\n"), playernode[p]);
-		SendKick(p, KICK_MSG_CON_FAIL);
+		//D_Clearticcmd(k);
+
+		buf[0] = (char)p;
+		buf[1] = KICK_MSG_CON_FAIL;
+		SendNetXCmd(XD_KICK, &buf, 2);
 		return true;
 	}
 
@@ -5404,7 +5417,7 @@ static void HandlePacketFromPlayer(SINT8 node)
 				break;
 			}
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 			// this decreases by one point at twice the cooldown time (ex cooldown of 2 seconds means, this counter decreases by one every 4 seconds), pretty much there to prevent a resynch loop
 			if ((gamestate_resend_counter[node] != 0) && (I_GetTime() % ((max(cv_resynchcooldown.value, 1) * TICRATE) *2) == 0))
 			{
@@ -5416,16 +5429,27 @@ static void HandlePacketFromPlayer(SINT8 node)
 			if (gamestate == GS_LEVEL
 				&& (realstart > gametic - TICQUEUE+1 && realstart <= gametic)
 				&& consistancy[realstart%TICQUEUE] != SHORT(netbuffer->u.clientpak.consistancy)
-				&& (!is_client_saturn[node] || (!resendingsavegame[node] && savegameresendcooldown[node] <= I_GetTime() && !SV_ResendingSavegameToAnyone())))
+				&& (!can_receive_gamestate[node] || (!resendingsavegame[node] && savegameresendcooldown[node] <= I_GetTime() && !SV_ResendingSavegameToAnyone())))
 			{
-				// Check if a client is saturn before sending ANYTHING!
-				// this way we only send stuff to clients we know can use the gamestate resend
-				// and dont have to wait for a response from clients that never would send a response back
-				if (is_client_saturn[node])
+//#ifndef SATURNPAK  // lug: keep this behaviour for v7.1 atleast
+				// we need to send this so the client can tell us if it can receive the savegame
+				netbuffer->packettype = PT_WILLRESENDGAMESTATE;
+				HSendPacket(node, true, 0, 0);
+
+				if (can_receive_gamestate[node])
+					resendingsavegame[node] = true;
+				else
+				{
+					SV_RequireResynch(node);
+					resendingsavegame[node] = false;
+				}
+/*#else
+				if (can_receive_gamestate[node])
 				{
 					// Tell the client we are about to resend them the gamestate
 					netbuffer->packettype = PT_WILLRESENDGAMESTATE;
 					HSendPacket(node, true, 0, 0);
+
 					resendingsavegame[node] = true;
 				}
 				else
@@ -5433,10 +5457,11 @@ static void HandlePacketFromPlayer(SINT8 node)
 					SV_RequireResynch(node);
 					resendingsavegame[node] = false;
 				}
+#endif*/
 
-				if ((!is_client_saturn[node] && (cv_resynchattempts.value && resynch_score[node] <= (unsigned)cv_resynchattempts.value*250)) || (is_client_saturn[node] && (gamestate_resend_counter[node] < cv_gamestateattempts.value)))
+				if ((!can_receive_gamestate[node] && (cv_resynchattempts.value && resynch_score[node] <= (unsigned)cv_resynchattempts.value*250)) || (can_receive_gamestate[node] && (gamestate_resend_counter[node] < cv_gamestateattempts.value)))
 				{
-					if (is_client_saturn[node] && resendingsavegame[node])
+					if (can_receive_gamestate[node] && resendingsavegame[node])
 					{
 						gamestate_resend_counter[node]++;
 						DEBFILE(va("gamestate counter %d for node %d\n", gamestate_resend_counter[node], netconsole));
@@ -5454,7 +5479,11 @@ static void HandlePacketFromPlayer(SINT8 node)
 				}
 				else
 				{
-					SendKick(netconsole, KICK_MSG_CON_FAIL);
+					UINT8 buf[3];
+
+					buf[0] = (UINT8)netconsole;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 					DEBFILE(va("player %d kicked (synch failure) [%u] %d!=%d\n",
 						netconsole, realstart, consistancy[realstart%TICQUEUE],
 						SHORT(netbuffer->u.clientpak.consistancy)));
@@ -5485,7 +5514,11 @@ static void HandlePacketFromPlayer(SINT8 node)
 				}
 				else
 				{
-					SendKick(netconsole, KICK_MSG_CON_FAIL);
+					UINT8 buf[3];
+
+					buf[0] = (UINT8)netconsole;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 					DEBFILE(va("player %d kicked (synch failure) [%u] %d!=%d\n",
 						netconsole, realstart, consistancy[realstart%TICQUEUE],
 						SHORT(netbuffer->u.clientpak.consistancy)));
@@ -5596,7 +5629,13 @@ static void HandlePacketFromPlayer(SINT8 node)
 			nodewaiting[node] = 0;
 			if (netconsole != -1 && playeringame[netconsole])
 			{
-				SendKick(netconsole, (netbuffer->packettype == PT_NODETIMEOUT) ? KICK_MSG_TIMEOUT : KICK_MSG_PLAYER_QUIT);
+				UINT8 buf[2];
+				buf[0] = (UINT8)netconsole;
+				if (netbuffer->packettype == PT_NODETIMEOUT)
+					buf[1] = KICK_MSG_TIMEOUT;
+				else
+					buf[1] = KICK_MSG_PLAYER_QUIT;
+				SendNetXCmd(XD_KICK, &buf, 2);
 			}
 			Net_CloseConnection(node);
 			nodeingame[node] = false;
@@ -5610,7 +5649,10 @@ static void HandlePacketFromPlayer(SINT8 node)
 
 				if (server)
 				{
-					SendKick(node, KICK_MSG_CON_FAIL);
+					UINT8 buf[2];
+					buf[0] = (UINT8)node;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 				}
 
 				break;
@@ -5632,7 +5674,10 @@ static void HandlePacketFromPlayer(SINT8 node)
 
 				if (server)
 				{
-					SendKick(node, KICK_MSG_CON_FAIL);
+					UINT8 buf[2];
+					buf[0] = (UINT8)node;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 				}
 
 				break;
@@ -5696,7 +5741,10 @@ static void HandlePacketFromPlayer(SINT8 node)
 
 				if (server)
 				{
-					SendKick(node, KICK_MSG_CON_FAIL);
+					char buf[2];
+					buf[0] = (char)node;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 				}
 
 				break;
@@ -5712,7 +5760,10 @@ static void HandlePacketFromPlayer(SINT8 node)
 
 				if (server)
 				{
-					SendKick(node, KICK_MSG_CON_FAIL);
+					char buf[2];
+					buf[0] = (char)node;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 				}
 
 				break;
@@ -5740,7 +5791,10 @@ static void HandlePacketFromPlayer(SINT8 node)
 
 				if (server)
 				{
-					SendKick(node, KICK_MSG_CON_FAIL);
+					UINT8 buf[2];
+					buf[0] = (UINT8)node;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 				}
 
 				break;
@@ -5748,8 +5802,9 @@ static void HandlePacketFromPlayer(SINT8 node)
 			if (client)
 				Got_Filetxpak();
 			break;
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 		case PT_CANRECEIVEGAMESTATE:
+			can_receive_gamestate[node] = true;
 			PT_CanReceiveGamestate(node);
 			break;
 		case PT_RECEIVEDGAMESTATE:
@@ -5760,9 +5815,12 @@ static void HandlePacketFromPlayer(SINT8 node)
 		case PT_WILLRESENDGAMESTATE:
 			PT_WillResendGamestate();
 			break;
+#endif
+#ifdef SATURNPAK
 		case PT_ISSATURN:
 			DEBFILE(va("hi im on saturn! node = %d\n", node));
 			is_client_saturn[node] = true;
+			can_receive_gamestate[node] = true;
 			break;
 #endif
 		default:
@@ -5780,6 +5838,8 @@ static void GetPackets(void)
 {
 	SINT8 node; // The packet sender
 
+	player_joining = false;
+
 	while (HGetPacket())
 	{
 		node = (SINT8)doomcom->remotenode;
@@ -6041,7 +6101,7 @@ static void CL_SendClientCmd(void)
 	{
 		UINT8 lagDelay = 0;
 
-		if (UseLocalDelay() && (lowest_lag > 0))
+		if (lowest_lag > 0)
 		{
 			// Gentlemens' ping.
 			lagDelay = min(lowest_lag, MAXGENTLEMENDELAY);
@@ -6288,12 +6348,9 @@ static inline void CreateNewLocalCMD(UINT8 p, INT32 realtics)
 {
 	INT32 i;
 
-	if (UseLocalDelay())
+	for (i = MAXGENTLEMENDELAY-1; i > 0; i--)
 	{
-		for (i = MAXGENTLEMENDELAY-1; i > 0; i--)
-		{
-			G_MoveTiccmd(&localcmds[p][i], &localcmds[p][i-1], 1);
-		}
+		G_MoveTiccmd(&localcmds[p][i], &localcmds[p][i-1], 1);
 	}
 
 	G_BuildTiccmd(&localcmds[p][0], realtics, p+1);
@@ -6308,8 +6365,7 @@ static void Local_Maketic(INT32 realtics)
 	D_ProcessEvents(); // menu responder, cons responder,
 	                   // game responder calls HU_Responder, AM_Responder, F_Responder,
 	                   // and G_MapEventsToControls
-	if (!dedicated)
-		rendergametic = gametic;
+	if (!dedicated) rendergametic = gametic;
 
 	// translate inputs (keyboard/mouse/joystick) into game controls
 	for (i = 0; i <= splitscreen; i++)
@@ -6431,12 +6487,21 @@ boolean TryRunTics(tic_t realtics)
 	}
 #endif
 
+	if (neededtic > gametic)
+	{
+		hu_stopped = false;
+	}
+
+	if (player_joining)
+	{
+		hu_stopped = true;
+		return false;
+	}
+
 	ticking = neededtic > gametic;
 
 	if (ticking)
 	{
-		hu_stopped = false;
-
 		// run the count * tics
 		while (neededtic > gametic)
 		{
@@ -6465,7 +6530,8 @@ boolean TryRunTics(tic_t realtics)
 	}
 	else
 	{
-		hu_stopped = true;
+		if (realtics)
+			hu_stopped = true;
 	}
 
 	return ticking;
@@ -6491,7 +6557,6 @@ static inline void PingUpdate(void)
 	INT32 i;
 	UINT8 pingkick[MAXPLAYERS];
 	UINT8 nonlaggers = 0;
-
 	memset(pingkick, 0, sizeof(pingkick));
 
 	netbuffer->packettype = PT_PING;
@@ -6538,6 +6603,8 @@ static inline void PingUpdate(void)
 			UINT8 minimumkicklevel = (nonlaggers > 0) ? PINGKICK_LIMIT : PINGKICK_TICQUEUE;
 			for (i = 0; i < MAXPLAYERS; i++)
 			{
+				char buf[2];
+
 				if (!playeringame[i] || pingkick[i] < minimumkicklevel)
 					continue;
 
@@ -6549,7 +6616,10 @@ static inline void PingUpdate(void)
 				}
 
 				pingtimeout[i] = 0;
-				SendKick(i, KICK_MSG_PING_HIGH);
+
+				buf[0] = (char)i;
+				buf[1] = KICK_MSG_PING_HIGH;
+				SendNetXCmd(XD_KICK, &buf, 2);
 			}
 		}
 	}
@@ -6591,8 +6661,7 @@ static void UpdatePingTable(void)
 
 	if (server)
 	{
-		//if (Playing() && !(gametime % 8)) // Value chosen based on _my vibes man_ << dont do this for v8 atleast, this is placeboeing ppl to hell and back
-		if (Playing() && !(gametime % 35))	// update once per second.
+		if (Playing() && !(gametime % 8)) // Value chosen based on _my vibes man_
 			PingUpdate();
 
 		fastest = 0;
@@ -6604,7 +6673,7 @@ static void UpdatePingTable(void)
 			{
 				realpingtable[i] += GetLag(playernode[i]);
 
-				if (UseLocalDelay() && !server_lagless && !players[i].spectator)
+				if (!server_lagless && !players[i].spectator)
 				{
 					lag = playerpingtable[i];
 					if (! fastest || lag < fastest)
@@ -6613,40 +6682,30 @@ static void UpdatePingTable(void)
 			}
 		}
 
-		if (UseLocalDelay())
-		{
-			if (server_lagless)
-				lowest_lag = 0;
-			else
-				lowest_lag = fastest;
-
-			// Don't gentleman below your mindelay
-			if (lowest_lag < (tic_t)cv_mindelay.value)
-				lowest_lag = (tic_t)cv_mindelay.value;
-
-			simulated_lag = lowest_lag;
-		}
+		if (server_lagless)
+			lowest_lag = 0;
 		else
-			lowest_lag = simulated_lag = 0;
+			lowest_lag = fastest;
+
+		// Don't gentleman below your mindelay
+		if (lowest_lag < (tic_t)cv_mindelay.value)
+			lowest_lag = (tic_t)cv_mindelay.value;
+
+		simulated_lag = lowest_lag;
 
 		pingmeasurecount++;
 	}
 	else // We're a client, handle mindelay on the way out.
 	{
-		if (UseLocalDelay())
-		{
-			// Previously (neededtic - gametic) - WRONG VALUE!
-			// Pretty sure that's measuring jitter, not RTT.
-			// Stable connections would be punished by adding their mindelay to network delay!
-			tic_t mydelay = playerpingtable[consoleplayer];
+		// Previously (neededtic - gametic) - WRONG VALUE!
+		// Pretty sure that's measuring jitter, not RTT.
+		// Stable connections would be punished by adding their mindelay to network delay!
+		tic_t mydelay = playerpingtable[consoleplayer];
 
-			if (mydelay < (tic_t)cv_mindelay.value)
-			{
-				lowest_lag = ((tic_t)cv_mindelay.value - mydelay);
-				simulated_lag = (tic_t)cv_mindelay.value;
-			}
-			else
-				lowest_lag = simulated_lag = 0;
+		if (mydelay < (tic_t)cv_mindelay.value)
+		{
+			lowest_lag = ((tic_t)cv_mindelay.value - mydelay);
+			simulated_lag = (tic_t)cv_mindelay.value;
 		}
 		else
 			lowest_lag = simulated_lag = 0;
@@ -6831,7 +6890,7 @@ void NetUpdate(void)
 
 	if (client)
 	{
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 		// If the client just finished redownloading the game state, load it
 		if (cl_redownloadinggamestate && fileneeded[0].status == FS_FOUND)
 			CL_ReloadReceivedSavegame();
@@ -6840,7 +6899,7 @@ void NetUpdate(void)
 			CL_SendClientCmd(); // Send tic cmd
 
 		hu_resynching = resynch_local_inprogress;
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 		hu_redownloadinggamestate = cl_redownloadinggamestate;
 #endif
 	}
@@ -6851,22 +6910,17 @@ void NetUpdate(void)
 			INT32 counts;
 
 			hu_resynching = false;
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 			hu_redownloadinggamestate = false;
 #endif
-			// Don't erase tics not acknowledged
-			counts = realtics;
 
 			firstticstosend = gametic;
 			for (i = 0; i < MAXNETNODES; i++)
-			{
-				if (!nodeingame[i])
-					continue;
-				if (nettics[i] < firstticstosend)
+				if (nodeingame[i] && nettics[i] < firstticstosend)
 					firstticstosend = nettics[i];
-				if (maketic + counts >= nettics[i] + (TICQUEUE - TICRATE))
-					Net_ConnectionTimeout(i);
-			}
+
+			// Don't erase tics not acknowledged
+			counts = realtics;
 
 			for (i = 0; i < MAXNETNODES; ++i)
 				if (resynch_inprogress[i])

src/d_clisrv.h

@@ -108,11 +108,12 @@ typedef enum
 
 	PT_PING,          // Packet sent to tell clients the other client's latency to server.
 
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	PT_WILLRESENDGAMESTATE, // Hey Client, I am about to resend you the gamestate!
 	PT_CANRECEIVEGAMESTATE, // Okay Server, I'm ready to receive it, you can go ahead.
 	PT_RECEIVEDGAMESTATE,   // Thank you Server, I am ready to play again!
 
+	// we will reserve this for now even if unused, so order wont get mangled
 	PT_ISSATURN, 			// Saturn specific identifier packet
 #endif
 
@@ -393,7 +394,6 @@ typedef struct
 #define MAXSERVERNAME 32
 #define MAXFILENEEDED 915
 #define MAX_MIRROR_LENGTH 256
-
 // This packet is too large
 typedef struct
 {
@@ -588,7 +588,7 @@ extern tic_t servermaxping;
 extern boolean server_lagless;
 extern tic_t simulated_lag;
 extern tic_t lowest_lag;
-extern consvar_t cv_mindelay, cv_gentlemens;
+extern consvar_t cv_mindelay, cv_lagless;
 
 extern consvar_t
 #ifdef VANILLAJOINNEXTROUND
@@ -599,7 +599,7 @@ extern consvar_t
 	cv_allownewsaturnplayer,
 #endif
 	cv_joinrefusemessage, cv_maxplayers, cv_resynchattempts,
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	cv_resynchcooldown, cv_gamestateattempts,
 #endif
 	cv_blamecfail, cv_maxsend, cv_noticedownload, cv_downloadspeed;
@@ -616,7 +616,6 @@ void D_ClientServerInit(void);
 void RegisterNetXCmd(netxcmd_t id, void (*cmd_f)(UINT8 **p, INT32 playernum));
 void SendNetXCmdForPlayer(UINT8 playerid, netxcmd_t id, const void *param, size_t nparam);
 #define SendNetXCmd(id, param, nparam) SendNetXCmdForPlayer(0, id, param, nparam) // Shortcut for P1
-void SendKick(UINT8 playernum, UINT8 msg);
 
 // Create any new ticcmds and broadcast to other players.
 void NetKeepAlive(void);
@@ -667,7 +666,7 @@ tic_t GetLag(INT32 node);
 //UINT8 GetFreeXCmdSize(UINT8 playerid);
 
 extern UINT8 hu_resynching;
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 extern UINT8 hu_redownloadinggamestate;
 #endif
 extern boolean hu_stopped; // kart, true when the game is stopped for players due to a disconnecting or connecting player

src/d_main.c

@@ -147,7 +147,7 @@ INT32 eventhead, eventtail;
 
 boolean dedicated = false;
 
-boolean loaded_config = false; // true once config.cfg loaded AND executed
+boolean loaded_config = false;
 
 //
 // D_PostEvent
@@ -166,56 +166,48 @@ UINT8 ctrldown = 0; // 0x1 left, 0x2 right
 UINT8 altdown = 0; // 0x1 left, 0x2 right
 boolean capslock = 0;	// gee i wonder what this does.
 
-static void D_PadMenuScrollInput(UINT8 input)
+static void D_PadMenuScrollInput(int input)
 {
-	event_t dpadev;
-	memset(&dpadev, 0, sizeof(event_t));
-	dpadev.type = ev_keydown;
-
-	switch (input)
-	{
-		case DPAD_UP:
-			dpadev.data1 = KEY_UPARROW;
-			break;
-		case DPAD_DOWN:
-			dpadev.data1 = KEY_DOWNARROW;
-			break;
-		case DPAD_LEFT:
-			dpadev.data1 = KEY_LEFTARROW;
-			break;
-		case DPAD_RIGHT:
-			dpadev.data1 = KEY_RIGHTARROW;
-			break;
-	}
-
-	D_PostEvent(&dpadev); // put into eventlist
+	event_t myev = {0, 0, 0, 0};
+	myev.type = ev_keydown;
+	myev.data1 = input;
+	D_PostEvent(&myev); // put into eventlist
 }
 
-#define SCROLLDELAY 19
+#define SCROLLDELAY 19 // TICRATE * ( (k+2) (1 - [wz + h + j - q]^2 - [(gk + 2g + k + 1)(h + j) + h - z]^2 - [16(k + 1)^3(k + 2)(n + 1)^2 + 1 - f^2]^2 calculated by my butt
 
-// Check if any dpad button is held
-// and pass it to the eventlist
+// this is absolutely awful and i hate it lmao
+// but le hAx0r to make dpad also be able to scroll in the menu
 static void D_GamePadMenuScrollTicker(void)
 {
-	static UINT8 menuInputDelayTimer = 0;
+	static SINT8 menuInputDelayTimer = 0;
+	int key = 0; // butt-on output
 
 	if (dedicated)
 		return;
 
-	for (UINT8 i = 0; i < 4; i++)
+	// wish i had a switch ono
+	if (DPADUPSCROLL)
+		key = KEY_UPARROW;
+	else if (DPADDOWNSCROLL)
+		key = KEY_DOWNARROW;
+	else if (DPADLEFTSCROLL)
+		key = KEY_LEFTARROW;
+	else if (DPADRIGHTSCROLL)
+		key = KEY_RIGHTARROW;
+
+	if (key)
 	{
-		if (dpadscrollstate[i])
-		{
-			if (menuInputDelayTimer < SCROLLDELAY)
-				menuInputDelayTimer++;
-			else if (menuInputDelayTimer == SCROLLDELAY)
-				D_PadMenuScrollInput(i);
+		if (menuInputDelayTimer < SCROLLDELAY)
+			menuInputDelayTimer++;
 
-			return;
-		}
+		if (menuInputDelayTimer == SCROLLDELAY)
+			D_PadMenuScrollInput(key);
+	}
+	else
+	{
+		menuInputDelayTimer = 0;
 	}
-
-	menuInputDelayTimer = 0;
 }
 #undef SCROLLDELAY
 
@@ -611,8 +603,8 @@ static boolean D_Display(void)
 			py = 4;
 		else
 			py = viewwindowy + 4;
-		patch = W_CachePatchName("M_PAUSE", PU_PATCH);
-		V_DrawScaledPatch(viewwindowx + (BASEVIDWIDTH - patch->width)/2, py, V_SNAPTOTOP, patch);
+		patch = W_CachePatchName("M_PAUSE", PU_CACHE);
+		V_DrawScaledPatch(viewwindowx + (BASEVIDWIDTH - SHORT(patch->width))/2, py, V_SNAPTOTOP, patch);
 	}
 
 	if (rendermode == render_soft && demo.rewinding)
@@ -649,8 +641,6 @@ static boolean D_Display(void)
 		}
 	}
 
-	NetUpdate(); // send out any new accumulation
-
 	// It's safe to end the game now.
 	if (G_GetExitGameFlag())
 	{
@@ -741,7 +731,7 @@ void D_SRB2Loop(void)
 	COM_ImmedExecute("cls;version");
 
 	if (rendermode == render_soft)
-		V_DrawFixedPatch(0, 0, FRACUNIT/2, 0, W_CachePatchNum(W_GetNumForName("KARTKREW"), PU_PATCH_LOWPRIORITY), NULL);
+		V_DrawFixedPatch(0, 0, FRACUNIT/2, 0, (patch_t *)W_CacheLumpNum(W_GetNumForName("KARTKREW"), PU_CACHE), NULL);
 	I_FinishUpdate(); // page flip or blit buffer
 
 	for (;;)
@@ -833,12 +823,7 @@ void D_SRB2Loop(void)
 
 		if (interp)
 		{
-			renderdeltatics = FloatToFixed(deltatics);
-
-			// I looked at the possibility of putting in a float drawer for
-			// perfstats and it's very complicated, so we'll just do this instead...
-			ps_interp_frac.value.p = (precise_t)((FIXED_TO_FLOAT(g_time.timefrac)) * 1000.0f);
-			ps_interp_lag.value.p = (precise_t)((deltasecs) * 1000.0f);
+			renderdeltatics = FLOAT_TO_FIXED(deltatics);
 
 			if (!(paused || P_AutoPause()) && deltatics < 1.0 && !hu_stopped)
 			{
@@ -882,7 +867,7 @@ void D_SRB2Loop(void)
 		LUA_Step();
 
 #ifdef HAVE_DISCORDRPC
-		if (!dedicated && renderisnewtic)
+		if (!dedicated)
 		{
 			Discord_RunCallbacks();
 		}
@@ -942,7 +927,6 @@ void D_SRB2Loop(void)
 void D_StartTitle(void)
 {
 	INT32 i;
-
 	if (netgame)
 	{
 		if (gametype == GT_RACE) // SRB2kart
@@ -964,8 +948,6 @@ void D_StartTitle(void)
 		return;
 	}
 
-	M_ClearMenus(true);
-
 	// okay, stop now
 	// (otherwise the game still thinks we're playing!)
 	SV_StopServer();
@@ -1078,21 +1060,18 @@ static void D_AutoloadFile(const char *file, char **filearray)
 		COM_BufAddText(va("exec %s\n", newfile));
 }
 
-static char *strremove(char *str, const char *sub)
-{
-	char *p, *q, *r;
-	if (*sub && (q = r = strstr(str, sub)) != NULL)
-	{
-		size_t len = strlen(sub);
-		while ((r = strstr(p = r + len, sub)) != NULL)
-		{
-			while (p < r)
-				*q++ = *p++;
-		}
-		while ((*q++ = *p++) != '\0')
-			continue;
-	}
-	return str;
+static char *strremove(char *str, const char *sub) {
+    char *p, *q, *r;
+    if (*sub && (q = r = strstr(str, sub)) != NULL) {
+        size_t len = strlen(sub);
+        while ((r = strstr(p = r + len, sub)) != NULL) {
+            while (p < r)
+                *q++ = *p++;
+        }
+        while ((*q++ = *p++) != '\0')
+            continue;
+    }
+    return str;
 }
 
 // FIND THEM
@@ -1200,49 +1179,47 @@ void D_CleanFile(char **filearray)
 
 static boolean AddIWAD(void)
 {
-	char * path = va(pandf, srb2path, "srb2.srb");
+	char * path = va(pandf,srb2path,"srb2.srb");
 
 	if (FIL_ReadFileOK(path))
 	{
 		D_AddFile(path, startupwadfiles);
 		return true;
 	}
-
-	return false;
+	else
+	{
+		return false;
+	}
 }
 
 // extra graphic patches for saturn specific thingies
-boolean found_extra_kart = false;
-boolean found_extra2_kart = false;
-boolean found_extra3_kart = false;
+boolean found_extra_kart;
+boolean found_extra2_kart;
+boolean found_extra3_kart;
 
-boolean xtra_speedo = false;       // extra speedometer check
-boolean xtra_speedo_clr = false;   // extra speedometer colour check
-boolean xtra_speedo3 = false;      // 80x 11 extra speedometer check
-boolean xtra_speedo_clr3 = false;  // 80x 11 extra speedometer colour check
-boolean achi_speedo = false;       // achiiro speedometer check
-boolean achi_speedo_clr = false;   // extra speedometer colour check
-boolean dial_speedo = false;       // dial speedometer check
-boolean dial_speedo_clr = false;   // dial speedometer colour check
-boolean kartz_speedo = false;      // kartZ speedo
-boolean kartz_speedo_smol = false; // kartZ speedo but smol
+boolean xtra_speedo;       // extra speedometer check
+boolean xtra_speedo_clr;   // extra speedometer colour check
+boolean xtra_speedo3;      // 80x 11 extra speedometer check
+boolean xtra_speedo_clr3;  // 80x 11 extra speedometer colour check
+boolean achi_speedo;       // achiiro speedometer check
+boolean achi_speedo_clr;   // extra speedometer colour check
+boolean kartz_speedo;       // kartZ speedo
 
-boolean clr_hud = false;           // colour hud check
-boolean driftgaugegfx_clr = false; // driftgauge colour check
-boolean big_lap = false;           // bigger lap counter
-boolean big_lap_color = false;     // bigger lap counter but colour
-boolean statdp = false;            // stat display for extended player setup
-boolean nametaggfx = false;        // Nametag stuffs
-boolean driftgaugegfx = false;     // Driftgauge stuffs
-boolean multiitem_icon = false;    // Extra icons for Sneakers, Banana and Jawz
-boolean joystickicon = false;      // Extra icons for the joystick input display
-boolean minidoticon = false;        // Dot graphic for minimap player angle display
-boolean minilighticon = false;     // mkwii-style minimap headlight
+boolean clr_hud;           // colour hud check
+boolean big_lap;           // bigger lap counter
+boolean big_lap_color;     // bigger lap counter but colour
+boolean statdp;            // stat display for extended player setup
+boolean nametaggfx;        // Nametag stuffs
+boolean driftgaugegfx;     // Driftgauge stuffs
+boolean multiitem_icon;    // Extra icons for Sneakers, Banana and Jawz
 //
 
 static void IdentifyVersion(void)
 {
 	const char *srb2waddir = NULL;
+	found_extra_kart = false;
+	found_extra2_kart = false;
+	found_extra3_kart = false;
 
 #if defined (__unix__) || defined (UNIXCOMMON) || defined (HAVE_SDL)
 	// change to the directory where 'srb2.srb' is found
@@ -1252,11 +1229,11 @@ static void IdentifyVersion(void)
 	// get the current directory (possible problem on NT with "." as current dir)
 	if (srb2waddir)
 	{
-		strlcpy(srb2path, srb2waddir, sizeof(srb2path));
+		strlcpy(srb2path,srb2waddir,sizeof (srb2path));
 	}
 	else
 	{
-		if (getcwd(srb2path, sizeof(srb2path)))
+		if (getcwd(srb2path, 256) != NULL)
 			srb2waddir = srb2path;
 		else
 		{
@@ -1265,7 +1242,7 @@ static void IdentifyVersion(void)
 	}
 
 	// Load the IWAD
-	if (!AddIWAD())
+	if (! AddIWAD())
 	{
 		I_Error("SRB2.SRB not found! Expected in %s\n", srb2waddir);
 	}
@@ -1290,21 +1267,18 @@ static void IdentifyVersion(void)
 	D_AddFile(va(pandf,srb2waddir,"patch.kart"), startupwadfiles);
 #endif
 	// completely optional
-	if (FIL_ReadFileOK(va(pandf,srb2waddir,"extra.kart")))
-	{
+	if (FIL_ReadFileOK(va(pandf,srb2waddir,"extra.kart"))) {
 		D_AddFile(va(pandf,srb2waddir,"extra.kart"), startupwadfiles);
 		found_extra_kart = true;
 	}
 
 	// completely optional 2: Back with a vengence
-	if (FIL_ReadFileOK(va(pandf,srb2waddir,"extra2.kart")))
-	{
+	if (FIL_ReadFileOK(va(pandf,srb2waddir,"extra2.kart"))) {
 		D_AddFile(va(pandf,srb2waddir,"extra2.kart"), startupwadfiles);
 		found_extra2_kart = true;
 	}
 
-	if (FIL_ReadFileOK(va(pandf,srb2waddir,"extra3.kart")))
-	{
+	if (FIL_ReadFileOK(va(pandf,srb2waddir,"extra3.kart"))) {
 		D_AddFile(va(pandf,srb2waddir,"extra3.kart"), startupwadfiles);
 		found_extra3_kart = true;
 	}
@@ -1352,197 +1326,6 @@ static inline void D_MakeTitleString(char *s)
 	strcpy(s, temp);
 }
 
-static void D_CheckSaturnExtraFiles(void)
-{
-	// Possible value that changes depending on whether required files for speedometer are found or not
-	CV_PossibleValue_t speedo_cons_temp[NUMSPEEDOSTUFF] = {{1, "Default"}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}};
-	CV_PossibleValue_t driftgaugestyle_cons_temp[NUMDGAUGESTUFF] = {{1, "Default"}, {2, "Small"}, {3, "Big Numbers"}, {4, "Numbers Only"}, {0, NULL}, {0, NULL}};
-	CV_PossibleValue_t inputdisplay_cons_temp[NUMINPUTDISPLAYSTUFF] = {{0, "Off"}, {1, "Wheel"}, {2, "Stick"}, {0, NULL}, {0, NULL}};
-	CV_PossibleValue_t minimapdot_cons_temp[NUMMINIMAPDOTSTUFF] = {{0, "Off"}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}};
-
-	unsigned last_speedo_i = 0;
-	unsigned last_driftgauge_i = 3;
-	unsigned last_inputdisplay_i = 2;
-	unsigned last_minimapdot_i = 0;
-#define PUSHCONS(cons, i, id, name) { ++i; cons[i].value = id; cons[i].strvalue = name; }
-
-	// found the funny, add it in!
-	if (found_extra_kart)
-	{
-		mainwads++;
-
-		// now check for extra speedometer stuff
-		if (W_CheckMultipleLumps("SP_SMSTC", "K_TRNULL", "SP_MKMH", "SP_MMPH", "SP_MFRAC", "SP_MPERC", NULL))
-		{
-			xtra_speedo = true;
-			PUSHCONS(speedo_cons_temp, last_speedo_i, 2, "Small");
-		}
-
-		// now check for achii speedometer stuff
-		if (W_CheckMultipleLumps("SP_AMSTC", "K_TRNULL", "SP_AKMH", "SP_AMPH", "SP_AFRAC", "SP_APERC", NULL))
-		{
-			achi_speedo = true;
-			PUSHCONS(speedo_cons_temp, last_speedo_i, 3, "Achii");
-		}
-
-		// now check for dial speedometer stuff
-		if (W_CheckMultipleLumps("K_DSPBS1", "K_DSPBS2", "K_DSDIAL",
-			"K_TRNULL", "SP_DKMH", "SP_DMPH", "SP_DFRAC", "SP_DPERC",
-			"K_DSPNM0", "K_DSPNM1", "K_DSPNM2", "K_DSPNM3", "K_DSPNM4",
-			"K_DSPNM5", "K_DSPNM6", "K_DSPNM7", "K_DSPNM8", "K_DSPNM9",
-			"RANKFIN", NULL))
-		{
-			dial_speedo = true;
-			PUSHCONS(speedo_cons_temp, last_speedo_i, 4, "Dial");
-		}
-
-		// check for bigger lap count
-		if (W_CheckMultipleLumps("K_STLAPB", "K_STLA2B", NULL))
-		{
-			big_lap = true;
-		}
-
-		// kartzspeedo
-		if (W_CheckMultipleLumps("K_KZSP1", "K_KZSP2", "K_KZSP3", "K_KZSP4", "K_KZSP5",
-			"K_KZSP6", "K_KZSP7", "K_KZSP8", "K_KZSP9", "K_KZSP10", "K_KZSP11", "K_KZSP12",
-			"K_KZSP13", "K_KZSP14", "K_KZSP15", "K_KZSP16", "K_KZSP17", "K_KZSP18", "K_KZSP19",
-			"K_KZSP20", "K_KZSP21", "K_KZSP22", "K_KZSP23", "K_KZSP24", "K_KZSP25", NULL))
-		{
-			kartz_speedo = true;
-			PUSHCONS(speedo_cons_temp, last_speedo_i, 5, "P-Meter");
-		}
-
-		if (W_CheckMultipleLumps("K_KZSS1", "K_KZSS2", "K_KZSS3", "K_KZSS4", "K_KZSS5",
-			"K_KZSS6", "K_KZSS7", "K_KZSS8", "K_KZSS9", "K_KZSS10", "K_KZSS11", "K_KZSS12",
-			"K_KZSS13", "K_KZSS14", "K_KZSS15", "K_KZSS16", "K_KZSS17", "K_KZSS18", "K_KZSS19",
-			"K_KZSS20", "K_KZSS21", "K_KZSS22", "K_KZSS23", "K_KZSS24", "K_KZSS25", NULL))
-		{
-			kartz_speedo_smol = true;
-			PUSHCONS(speedo_cons_temp, last_speedo_i, 6, "P-Meter Small");
-		}
-
-		// stat display for extended player setup
-		if (W_CheckMultipleLumps("K_STATNB", "K_STATN1", "K_STATN2",
-			"K_STATN3", "K_STATN4", "K_STATN5", "K_STATN6", NULL))
-		{
-			statdp = true;
-		}
-
-		// Nametag stuffs
-		if (W_CheckMultipleLumps("NTLINE", "NTLINEV", "NTSP", "NTWH", NULL))
-		{
-			nametaggfx = true;
-		}
-
-		// driftgauge
-		if (W_CheckMultipleLumps("K_DGAU","K_DGSU", NULL))
-		{
-			driftgaugegfx = true;
-		}
-
-		// extra item icons
-		if (W_CheckMultipleLumps("K_ITSHO2", "K_ITSHO3", "K_ITBAN2", "K_ITBAN3", "K_ITBAN4", "K_ITJAW2", NULL))
-		{
-			multiitem_icon = true;
-		}
-
-		// extra round joystick inputdisplay sprites
-		if (W_CheckMultipleLumps("JOYBCK","JOYKNB","JOYSHD", NULL))
-		{
-			joystickicon = true;
-			PUSHCONS(inputdisplay_cons_temp, last_inputdisplay_i, 3, "StickGFX");
-		}
-
-		if (W_LumpExists("MMAPDOT"))
-		{
-			minidoticon = true;
-			PUSHCONS(minimapdot_cons_temp, last_minimapdot_i, 1, "Dot");
-		}
-
-		if (W_LumpExists("MMAPHDLT"))
-		{
-			minilighticon = true;
-			PUSHCONS(minimapdot_cons_temp, last_minimapdot_i, 2, "Headlight");
-		}
-	}
-
-	// now check for colour hud stuff
-	if (found_extra2_kart)
-	{
-		mainwads++;
-
-		// kart vanilla hud patches but colourizable
-		if (W_CheckMultipleLumps("K_SCTIME", "K_SCTIMW", "K_SCLAPS", "K_SCLAPW","K_SCBALN", "K_SCBALW",
-			"K_SCKARM", "K_SCTOUT", "K_ISMULC", "K_ITMULC", "K_ITBC", "K_ITBCD", "K_ISBC", "K_ISBCD", NULL))
-		{
-			clr_hud = true;
-		}
-
-		// extra speedo but colour
-		if (W_LumpExists("SC_SMSTC"))
-		{
-			xtra_speedo_clr = true;
-		}
-
-		// achii speedo but colour
-		if (W_CheckMultipleLumps("SC_AMSTC", "K_TRNULL", "SC_AKMH", "SC_AMPH", "SC_AFRAC", "SC_APERC", NULL))
-		{
-			achi_speedo_clr = true;
-		}
-
-		// dial speedo but colour
-		if (W_CheckMultipleLumps("K_DSPBC1", "K_DSPBC2", "K_DSDIAL",
-			"K_TRNULL", "SC_DKMH", "SC_DMPH", "SC_DFRAC", "SC_DPERC",
-			"K_DSPNC0", "K_DSPNC1", "K_DSPNC2", "K_DSPNC3", "K_DSPNC4",
-			"K_DSPNC5", "K_DSPNC6", "K_DSPNC7", "K_DSPNC8", "K_DSPNC9",
-			"RANKFIN", NULL))
-		{
-			dial_speedo_clr = true;
-		}
-
-		// driftgauge but colour
-		if (W_CheckMultipleLumps("K_DCAU","K_DCSU", NULL))
-		{
-			driftgaugegfx_clr = true;
-		}
-
-		// check for bigger lap count but color** its color bitch
-		if (W_CheckMultipleLumps("K_SCLAPB", "K_SCLA2B", NULL))
-		{
-			big_lap_color = true;
-		}
-	}
-
-	// can be used for custom hud stuff
-	// currently used for the v1 beta hud
-	if (found_extra3_kart)
-	{
-		mainwads++;
-
-		// 80x11 speedometer crap
-		if (W_LumpExists("SP_SM3TC"))
-		{
-			xtra_speedo3 = true;
-			PUSHCONS(speedo_cons_temp, last_speedo_i, 7, "Extra");
-			PUSHCONS(driftgaugestyle_cons_temp, last_driftgauge_i, 5, "Extra");
-		}
-
-		// 80x11 speedometer crap but colour
-		if (W_LumpExists("SC_SM3TC"))
-		{
-			xtra_speedo_clr3 = true;
-		}
-	}
-
-#undef PUSHCONS
-	memcpy(speedo_cons_t, speedo_cons_temp, sizeof(speedo_cons_t));
-	memcpy(driftgaugestyle_cons_t, driftgaugestyle_cons_temp, sizeof(driftgaugestyle_cons_t));
-	memcpy(inputdisplay_cons_t, inputdisplay_cons_temp, sizeof(inputdisplay_cons_t));
-	memcpy(minimapdot_cons_t, minimapdot_cons_temp, sizeof(minimapdot_cons_t));
-}
-
-#include <locale.h>
-
 //
 // D_SRB2Main
 //
@@ -1740,7 +1523,6 @@ void D_SRB2Main(void)
 
 	CONS_Printf("I_InitializeTime()...\n");
 	I_InitializeTime();
-	setlocale(LC_TIME, "");
 
 	// Make backups of some SOCcable tables.
 	P_BackupTables();
@@ -1792,7 +1574,100 @@ void D_SRB2Main(void)
 
 #endif //ifndef DEVELOP
 
-	D_CheckSaturnExtraFiles(); // check all the saturn stuff :3
+	// Possible value that changes depending on whether required files for speedometer are found or not
+	CV_PossibleValue_t speedo_cons_temp[NUMSPEEDOSTUFF] = {{1, "Default"}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}, {0, NULL}};
+	CV_PossibleValue_t driftgaugestyle_cons_temp[NUMSPEEDOSTUFF] = {{1, "Default"}, {2, "Small"}, {3, "Big Numbers"}, {4, "Numbers Only"}, {0, NULL}, {0, NULL}}; // ugh i dont want this but bleh
+	unsigned last_speedo_i = 0;
+	unsigned last_driftgauge_i = 0;
+#define PUSHCONS(cons, i, id, name) { ++i; cons[i].value = id; cons[i].strvalue = name; }
+
+	if (found_extra_kart || found_extra2_kart || found_extra3_kart) // found the funny, add it in!
+	{
+		// HAYA: These are seperated for a reason lmao
+		if (found_extra_kart)
+			mainwads++;
+		if (found_extra2_kart)
+			mainwads++;
+		if (found_extra3_kart)
+			mainwads++;
+
+		// now check for extra speedometer stuff
+		if (W_CheckMultipleLumps("SP_SMSTC", "K_TRNULL", "SP_MKMH", "SP_MMPH", "SP_MFRAC", "SP_MPERC", NULL))
+		{
+			xtra_speedo = true;
+			PUSHCONS(speedo_cons_temp, last_speedo_i, 2, "Small");
+		}
+
+		if (W_LumpExists("SC_SMSTC"))
+			xtra_speedo_clr = true;
+
+		// now check for achii speedometer stuff
+		if (W_CheckMultipleLumps("SP_AMSTC", "K_TRNULL", "SP_AKMH", "SP_AMPH", "SP_AFRAC", "SP_APERC", NULL))
+		{
+			achi_speedo = true;
+			PUSHCONS(speedo_cons_temp, last_speedo_i, 3, "Achii");
+		}
+
+		if (W_CheckMultipleLumps("SC_AMSTC", "K_TRNULL", "SC_AKMH", "SC_AMPH", "SC_AFRAC", "SC_APERC", NULL))
+			achi_speedo_clr = true;
+
+		// check for bigger lap count
+		if (W_CheckMultipleLumps("K_STLAPB", "K_STLA2B", NULL))
+			big_lap = true;
+
+		// now check for colour hud stuff
+		if (W_CheckMultipleLumps("K_SCTIME", "K_SCTIMW", "K_SCLAPS", "K_SCLAPW", \
+			"K_SCBALN", "K_SCBALW", "K_SCKARM", "K_SCTOUT", "K_ISMULC", "K_ITMULC", "K_ITBC", "K_ITBCD", "K_ISBC", "K_ISBCD", NULL))
+			clr_hud = true;
+
+		// check for bigger lap count but color** its color bitch
+		if (W_CheckMultipleLumps("K_SCLAPB", "K_SCLA2B", NULL))
+			big_lap_color = true;
+
+		// kartzspeedo
+		if (W_CheckMultipleLumps("K_KZSP1", "K_KZSP2", "K_KZSP3", "K_KZSP4", "K_KZSP5", \
+			"K_KZSP6", "K_KZSP7", "K_KZSP8", "K_KZSP9", "K_KZSP10", "K_KZSP11", "K_KZSP12", \
+			"K_KZSP13", "K_KZSP14", "K_KZSP15", "K_KZSP16", "K_KZSP17", "K_KZSP18", "K_KZSP19", \
+			"K_KZSP20", "K_KZSP21", "K_KZSP22", "K_KZSP23", "K_KZSP24", "K_KZSP25", NULL))
+		{
+			kartz_speedo = true;
+			PUSHCONS(speedo_cons_temp, last_speedo_i, 4, "P-Meter");
+		}
+
+		// stat display for extended player setup
+		if (W_CheckMultipleLumps("K_STATNB", "K_STATN1", "K_STATN2", "K_STATN3", "K_STATN4", \
+			"K_STATN5", "K_STATN6", NULL))
+			statdp = true;
+
+		// Nametag stuffs
+		if (W_CheckMultipleLumps("NTLINE", "NTLINEV", "NTSP", "NTWH", NULL))
+			nametaggfx = true;
+
+		if (W_CheckMultipleLumps("K_DGAU","K_DCAU","K_DGSU","K_DCSU", NULL))
+			driftgaugegfx = true;
+
+		// extra item icons
+		if (W_CheckMultipleLumps("K_ITSHO2", "K_ITSHO3", "K_ITBAN2", "K_ITBAN3", "K_ITBAN4", "K_ITJAW2", NULL))
+			multiitem_icon = true;
+
+		if (found_extra3_kart)
+		{
+			// 80x11 speedometer crap
+			if (W_LumpExists("SP_SM3TC"))
+			{
+				xtra_speedo3 = true;
+				PUSHCONS(speedo_cons_temp, last_speedo_i, 5, "Extra");
+				PUSHCONS(driftgaugestyle_cons_temp, last_driftgauge_i, 5, "Extra");
+			}
+
+			if (W_LumpExists("SC_SM3TC"))
+				xtra_speedo_clr3 = true;
+		}
+	}
+
+#undef PUSHCONS
+	memcpy(speedo_cons_t, speedo_cons_temp, sizeof(speedo_cons_t));
+	memcpy(driftgaugestyle_cons_t, driftgaugestyle_cons_temp, sizeof(driftgaugestyle_cons_t));
 
 	// Do it before P_InitMapData because PNG patch
 	// conversion sometimes needs the palette
@@ -1907,9 +1782,7 @@ void D_SRB2Main(void)
 
 	savedata.lives = 0; // flag this as not-used
 
-	// make sure I_Quit() will write back the correct config
-	// (do not write back the config if it crash before)
-	loaded_config = true; // so palettechange doesent get called 500 times at startup lol
+	loaded_config = true; // so pallettechange doesent get called 500 times at startup lol
 
 	//------------------------------------------------ COMMAND LINE PARAMS
 

src/d_main.h

@@ -17,9 +17,9 @@
 #include "d_event.h"
 #include "w_wad.h"   // for MAX_WADFILES
 
+// make sure not to write back the config until it's been correctly loaded
 extern tic_t rendergametic;
 
-// make sure not to write back the config until it's been correctly loaded
 extern boolean loaded_config;
 
 extern char srb2home[256]; //Alam: My Home
@@ -38,22 +38,15 @@ extern boolean xtra_speedo3;      // 80x11 extra speedometer check
 extern boolean xtra_speedo_clr3;  // 80x11 extra speedometer colour check
 extern boolean achi_speedo;       // achiiro speedometer check
 extern boolean achi_speedo_clr;   // extra speedometer colour check
-extern boolean dial_speedo;       // dial speedometer check
-extern boolean dial_speedo_clr;   // dial speedometer colour check
-extern boolean kartz_speedo;      // kartZ speedo
-extern boolean kartz_speedo_smol; // kartZ speedo but smol
+extern boolean kartz_speedo;       // kartZ speedo
 
 extern boolean clr_hud;           // colour hud check
-extern boolean driftgaugegfx_clr; // driftgauge colour check
 extern boolean big_lap;           // bigger lap counter
 extern boolean big_lap_color;     // bigger lap counter but colour
 extern boolean statdp;            // stat display for extended player setup
 extern boolean nametaggfx;        // Nametag stuffs
 extern boolean driftgaugegfx;     // Driftgauge stuffs
 extern boolean multiitem_icon;    // Extra icons for Sneakers, Banana and Jawz
-extern boolean joystickicon;      // Extra icons for the joystick input display
-extern boolean minidoticon;       // Dot icon for minimap player angle display
-extern boolean minilighticon;     // mkwii-style minimap headlight
 //
 
 // autoload stuff

src/d_net.c

@@ -109,24 +109,20 @@ boolean Net_GetNetStat(void)
 {
 	const tic_t t = I_GetTime();
 	static INT64 oldsendbyte = 0;
-
 	if (statstarttic+STATLENGTH <= t)
 	{
 		const tic_t df = t-statstarttic;
 		const INT64 newsendbyte = sendbytes - oldsendbyte;
 		sendbps = (INT32)(newsendbyte*TICRATE)/df;
 		getbps = (getbytes*TICRATE)/df;
-
 		if (sendackpacket)
 			lostpercent = 100.0f*(float)retransmit/(float)sendackpacket;
 		else
 			lostpercent = 0.0f;
-
 		if (getackpacket)
 			duppercent = 100.0f*(float)duppacket/(float)getackpacket;
 		else
 			duppercent = 0.0f;
-
 		if (ticruned)
 			gamelostpercent = 100.0f*(float)ticmiss/(float)ticruned;
 		else
@@ -224,7 +220,7 @@ FUNCMATH static INT32 cmpack(UINT8 a, UINT8 b)
   * \param lowtimer ???
   * \return True if a free acknum was found
   */
-static boolean GetFreeAcknum(UINT8 *freeack)
+static boolean GetFreeAcknum(UINT8 *freeack, boolean lowtimer)
 {
 	node_t *node = &nodes[doomcom->remotenode];
 	INT32 i, numfreeslot = 0;
@@ -236,7 +232,6 @@ static boolean GetFreeAcknum(UINT8 *freeack)
 	}
 
 	for (i = 0; i < MAXACKPACKETS; i++)
-	{
 		if (!ackpak[i].acknum)
 		{
 			// For low priority packets, make sure to let freeslots so urgent packets can be sent
@@ -254,8 +249,17 @@ static boolean GetFreeAcknum(UINT8 *freeack)
 				node->nextacknum++;
 			ackpak[i].destinationnode = (UINT8)(node - nodes);
 			ackpak[i].length = doomcom->datalength;
-			ackpak[i].senttime = I_GetTime();
-			ackpak[i].resentnum = 0;
+			if (lowtimer)
+			{
+				// Lowtime means can't be sent now so try it as soon as possible
+				ackpak[i].senttime = 0;
+				ackpak[i].resentnum = 1;
+			}
+			else
+			{
+				ackpak[i].senttime = I_GetTime();
+				ackpak[i].resentnum = 0;
+			}
 			M_Memcpy(ackpak[i].pak.raw, netbuffer, ackpak[i].length);
 
 			*freeack = ackpak[i].acknum;
@@ -264,17 +268,46 @@ static boolean GetFreeAcknum(UINT8 *freeack)
 
 			return true;
 		}
-	}
-
 #ifdef PARANOIA
 	CONS_Debug(DBG_NETPLAY, "No more free ackpacket\n");
 #endif
 	if (netbuffer->packettype < PT_CANFAIL)
 		I_Error("Connection lost\n");
-
 	return false;
 }
 
+/** Counts how many acks are free
+  *
+  * \param urgent True if the type of the packet meant to
+  *               use an ack is lower than PT_CANFAIL
+  *               If for some reason you don't want use it
+  *               for any packet type in particular,
+  *               just set to false
+  * \return The number of free acks
+  *
+  */
+INT32 Net_GetFreeAcks(boolean urgent)
+{
+	INT32 i, numfreeslot = 0;
+	INT32 n = 0; // Number of free acks found
+
+	for (i = 0; i < MAXACKPACKETS; i++)
+		if (!ackpak[i].acknum)
+		{
+			// For low priority packets, make sure to let freeslots so urgent packets can be sent
+			if (!urgent)
+			{
+				numfreeslot++;
+				if (numfreeslot <= URGENTFREESLOTNUM)
+					continue;
+			}
+
+			n++;
+		}
+
+	return n;
+}
+
 // Get a ack to send in the queue of this node
 static UINT8 GetAcktosend(INT32 node)
 {
@@ -287,7 +320,6 @@ static void RemoveAck(INT32 i)
 	INT32 node = ackpak[i].destinationnode;
 	DEBFILE(va("Remove ack %d\n",ackpak[i].acknum));
 	ackpak[i].acknum = 0;
-
 	if (nodes[node].flags & NF_CLOSE)
 		Net_CloseConnection(node);
 }
@@ -303,16 +335,13 @@ static boolean Processackpak(void)
 	if (netbuffer->ackreturn && cmpack(node->remotefirstack, netbuffer->ackreturn) < 0)
 	{
 		node->remotefirstack = netbuffer->ackreturn;
-
 		// Search the ackbuffer and free it
 		for (i = 0; i < MAXACKPACKETS; i++)
-		{
 			if (ackpak[i].acknum && ackpak[i].destinationnode == node - nodes
 				&& cmpack(ackpak[i].acknum, netbuffer->ackreturn) <= 0)
 			{
 				RemoveAck(i);
 			}
-		}
 	}
 
 	// Received a packet with ack, queue it to send the ack back
@@ -320,7 +349,6 @@ static boolean Processackpak(void)
 	{
 		UINT8 ack = netbuffer->ack;
 		getackpacket++;
-
 		if (cmpack(ack, node->firstacktosend) <= 0)
 		{
 			DEBFILE(va("Discard(1) ack %d (duplicated)\n", ack));
@@ -331,7 +359,6 @@ static boolean Processackpak(void)
 		{
 			// Check if it is not already in the queue
 			for (i = node->acktosend_tail; i != node->acktosend_head; i = (i+1) % MAXACKTOSEND)
-			{
 				if (node->acktosend[i] == ack)
 				{
 					DEBFILE(va("Discard(2) ack %d (duplicated)\n", ack));
@@ -339,14 +366,11 @@ static boolean Processackpak(void)
 					goodpacket = false; // Discard packet (duplicate)
 					break;
 				}
-			}
-
 			if (goodpacket)
 			{
 				// Is a good packet so increment the acknowledge number,
 				// Then search for a "hole" in the queue
 				UINT8 nextfirstack = (UINT8)(node->firstacktosend + 1);
-
 				if (!nextfirstack)
 					nextfirstack = 1;
 
@@ -359,11 +383,9 @@ static boolean Processackpak(void)
 					if (!nextfirstack)
 						nextfirstack = 1;
 					hm1 = (UINT8)((node->acktosend_head-1+MAXACKTOSEND) % MAXACKTOSEND);
-
 					while (change)
 					{
 						change = false;
-
 						for (i = node->acktosend_tail; i != node->acktosend_head;
 							i = (i+1) % MAXACKTOSEND)
 						{
@@ -376,7 +398,6 @@ static boolean Processackpak(void)
 										nextfirstack = 1;
 									change = true;
 								}
-
 								if (i == node->acktosend_tail)
 								{
 									node->acktosend[node->acktosend_tail] = 0;
@@ -398,7 +419,6 @@ static boolean Processackpak(void)
 					// Will be incremented when the nextfirstack comes (code above)
 					UINT8 newhead = (UINT8)((node->acktosend_head+1) % MAXACKTOSEND);
 					DEBFILE(va("out of order packet (%d expected)\n", nextfirstack));
-
 					if (newhead != node->acktosend_tail)
 					{
 						node->acktosend[node->acktosend_head] = ack;
@@ -435,11 +455,8 @@ static void GotAcks(void)
 	INT32 i, j;
 
 	for (j = 0; j < MAXACKTOSEND; j++)
-	{
 		if (netbuffer->u.textcmd[j])
-		{
 			for (i = 0; i < MAXACKPACKETS; i++)
-			{
 				if (ackpak[i].acknum && ackpak[i].destinationnode == doomcom->remotenode)
 				{
 					if (ackpak[i].acknum == netbuffer->u.textcmd[j])
@@ -454,9 +471,6 @@ static void GotAcks(void)
 							ackpak[i].senttime--; // hurry up
 						}
 				}
-			}
-		}
-	}
 }
 #endif
 
@@ -491,7 +505,6 @@ void Net_AckTicker(void)
 	{
 		const INT32 nodei = ackpak[i].destinationnode;
 		node_t *node = &nodes[nodei];
-
 		if (ackpak[i].acknum && ackpak[i].senttime + NODETIMEOUT < I_GetTime())
 		{
 			if (ackpak[i].resentnum > 10 && (node->flags & NF_CLOSE))
@@ -544,10 +557,8 @@ void Net_UnAcknowledgePacket(INT32 node)
 #else
 	INT32 hm1 = (nodes[node].acktosend_head-1+MAXACKTOSEND) % MAXACKTOSEND;
 	DEBFILE(va("UnAcknowledge node %d\n", node));
-
 	if (!node)
 		return;
-
 	if (nodes[node].acktosend[hm1] == netbuffer->ack)
 	{
 		nodes[node].acktosend[hm1] = 0;
@@ -571,7 +582,6 @@ void Net_UnAcknowledgePacket(INT32 node)
 			if (!nodes[node].firstacktosend)
 				nodes[node].firstacktosend = UINT8_MAX;
 		}
-
 		nodes[node].firstacktosend++;
 		if (!nodes[node].firstacktosend)
 			nodes[node].firstacktosend = 1;
@@ -590,10 +600,8 @@ static boolean Net_AllAcksReceived(void)
 	INT32 i;
 
 	for (i = 0; i < MAXACKPACKETS; i++)
-	{
 		if (ackpak[i].acknum)
 			return false;
-	}
 
 	return true;
 }
@@ -613,7 +621,6 @@ void Net_WaitAllAckReceived(UINT32 timeout)
 	timeout = tictac + timeout*NEWTICRATE;
 
 	HGetPacket();
-
 	while (timeout > I_GetTime() && !Net_AllAcksReceived())
 	{
 		while (tictac == I_GetTime())
@@ -621,7 +628,6 @@ void Net_WaitAllAckReceived(UINT32 timeout)
 			I_Sleep(cv_sleep.value);
 			I_UpdateTime(cv_timescale.value);
 		}
-
 		tictac = I_GetTime();
 		HGetPacket();
 		Net_AckTicker();
@@ -662,14 +668,13 @@ void Net_AbortPacketType(UINT8 packettype)
 #ifdef NONET
 	(void)packettype;
 #else
-	for (INT32 i = 0; i < MAXACKPACKETS; i++)
-	{
+	INT32 i;
+	for (i = 0; i < MAXACKPACKETS; i++)
 		if (ackpak[i].acknum && (ackpak[i].pak.data.packettype == packettype
 			|| packettype == UINT8_MAX))
 		{
 			ackpak[i].acknum = 0;
 		}
-	}
 #endif
 }
 
@@ -714,7 +719,6 @@ void Net_CloseConnection(INT32 node)
 
 	// check if we are waiting for an ack from this node
 	for (i = 0; i < MAXACKPACKETS; i++)
-	{
 		if (ackpak[i].acknum && ackpak[i].destinationnode == node)
 		{
 			if (!forceclose)
@@ -722,7 +726,6 @@ void Net_CloseConnection(INT32 node)
 			else
 				ackpak[i].acknum = 0;
 		}
-	}
 
 	InitNode(&nodes[node]);
 	SV_AbortSendFiles(node);
@@ -739,8 +742,9 @@ static UINT32 NetbufferChecksum(void)
 	UINT32 c = 0x1234567;
 	const INT32 l = doomcom->datalength - 4;
 	const UINT8 *buf = (UINT8 *)netbuffer + 4;
+	INT32 i;
 
-	for (INT32 i = 0; i < l; i++, buf++)
+	for (i = 0; i < l; i++, buf++)
 		c += (*buf) * (i+1);
 
 	return LONG(c);
@@ -755,7 +759,6 @@ static void fprintfstring(char *s, size_t len)
 	size_t i;
 
 	for (i = 0; i < len; i++)
-	{
 		if (s[i] < 32)
 		{
 			if (!mode)
@@ -775,8 +778,6 @@ static void fprintfstring(char *s, size_t len)
 			}
 			fprintf(debugfile, "%c", s[i]);
 		}
-	}
-
 	if (mode)
 		fprintf(debugfile, "]");
 }
@@ -831,14 +832,15 @@ const char *packettypename[NUMPACKETTYPE] =
 	"MOREFILESNEEDED",
 
 	"PING"
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	,
 
 	"WILLRESENDGAMESTATE",
 	"CANRECEIVEGAMESTATE",
 	"RECEIVEDGAMESTATE",
 
-	"ISSATURN" // special packet to identify saturn clients
+	// we will reserve this for now even if unused, so order wont get mangled
+	"ISSATURN"
 #endif
 };
 
@@ -1033,7 +1035,6 @@ static boolean ShouldDropPacket(void)
 boolean HSendPacket(INT32 node, boolean reliable, UINT8 acknum, size_t packetlength)
 {
 	doomcom->datalength = (INT16)(packetlength + BASEPACKETSIZE);
-
 	if (node == 0) // Packet is to go back to us
 	{
 		if ((rebound_head+1) % MAXREBOUND == rebound_tail)
@@ -1069,7 +1070,6 @@ boolean HSendPacket(INT32 node, boolean reliable, UINT8 acknum, size_t packetlen
 	// do this before GetFreeAcknum because this function backups
 	// the current packet
 	doomcom->remotenode = (INT16)node;
-
 	if (doomcom->datalength <= 0)
 	{
 		DEBFILE("HSendPacket: nothing to send\n");
@@ -1084,10 +1084,9 @@ boolean HSendPacket(INT32 node, boolean reliable, UINT8 acknum, size_t packetlen
 		netbuffer->ackreturn = GetAcktosend(node);
 	else
 		netbuffer->ackreturn = 0;
-
 	if (reliable)
 	{
-		if (!GetFreeAcknum(&netbuffer->ack))
+		if (!GetFreeAcknum(&netbuffer->ack, false))
 			return false;
 	}
 	else
@@ -1159,6 +1158,7 @@ boolean HGetPacket(void)
 
 	while(true)
 	{
+		//nodejustjoined = I_NetGet();
 		I_NetGet();
 
 		if (doomcom->remotenode == -1) // No packet received
@@ -1187,6 +1187,21 @@ boolean HGetPacket(void)
 			DebugPrintpacket("GET");
 #endif
 
+		/*// If a new node sends an unexpected packet, just ignore it
+		if (nodejustjoined && server
+			&& !(netbuffer->packettype == PT_ASKINFO
+				|| netbuffer->packettype == PT_SERVERINFO
+				|| netbuffer->packettype == PT_PLAYERINFO
+				|| netbuffer->packettype == PT_REQUESTFILE
+				|| netbuffer->packettype == PT_ASKINFOVIAMS
+				|| netbuffer->packettype == PT_CLIENTJOIN))
+		{
+			DEBFILE(va("New node sent an unexpected %s packet\n", packettypename[netbuffer->packettype]));
+			//CONS_Alert(CONS_NOTICE, "New node sent an unexpected %s packet\n", packettypename[netbuffer->packettype]);
+			Net_CloseConnection(doomcom->remotenode | FORCECLOSE);
+			continue;
+		}*/
+
 		// Proceed the ack and ackreturn field
 		if (!Processackpak())
 			continue; // discarded (duplicated)
@@ -1223,7 +1238,6 @@ static void Internal_FreeNodenum(INT32 nodenum)
 SINT8 I_NetMakeNode(const char *hostname)
 {
 	SINT8 newnode = -1;
-
 	if (I_NetMakeNodewPort)
 	{
 		char *localhostname = strdup(hostname);
@@ -1250,10 +1264,7 @@ void D_SetDoomcom(void)
 {
 	if (doomcom) return;
 	doomcom = Z_Calloc(sizeof (doomcom_t), PU_STATIC, NULL);
-	doomcom->id = DOOMCOM_ID;
 	doomcom->numslots = doomcom->numnodes = 1;
-	doomcom->gametype = 0;
-	doomcom->consoleplayer = 0;
 	doomcom->extratics = 0;
 }
 
@@ -1277,7 +1288,6 @@ boolean D_CheckNetGame(void)
 	I_NetMakeNodewPort = NULL;
 
 	hardware_MAXPACKETLENGTH = MAXPACKETLENGTH;
-
 	// I_InitNetwork sets doomcom and netgame
 	// check and initialize the network driver
 	multiplayer = false;
@@ -1297,7 +1307,6 @@ boolean D_CheckNetGame(void)
 	server = true; // WTF? server always true???
 		// no! The deault mode is server. Client is set elsewhere
 		// when the client executes connect command.
-	doomcom->ticdup = 1;
 
 	if (M_CheckParm("-extratic"))
 	{
@@ -1327,8 +1336,6 @@ boolean D_CheckNetGame(void)
 	if (netgame)
 		multiplayer = true;
 
-	if (doomcom->id != DOOMCOM_ID)
-		I_Error("Doomcom buffer invalid!");
 	if (doomcom->numnodes > MAXNETNODES)
 		I_Error("Too many nodes (%d), max:%d", doomcom->numnodes, MAXNETNODES);
 
@@ -1341,7 +1348,7 @@ boolean D_CheckNetGame(void)
 	if (M_CheckParm("-debugfile"))
 	{
 		char filename[21];
-		INT32 k = doomcom->consoleplayer - 1;
+		INT32 k = consoleplayer - 1;
 		if (M_IsNextParm())
 			k = atoi(M_GetNextParm()) - 1;
 		while (!debugfile && k < MAXPLAYERS)
@@ -1397,7 +1404,6 @@ void Command_Ping_f(void)
 	INT32 i;
 
 	pingc = 0;
-
 	for (i = 1; i < MAXPLAYERS; ++i)
 	{
 		if (playeringame[i])

src/d_net.h

@@ -45,10 +45,12 @@ extern boolean nodeingame[MAXNETNODES]; // Set false as nodes leave game
 
 extern boolean serverrunning;
 
+INT32 Net_GetFreeAcks(boolean urgent);
 void Net_AckTicker(void);
 
 // If reliable return true if packet sent, 0 else
-boolean HSendPacket(INT32 node, boolean reliable, UINT8 acknum, size_t packetlength);
+boolean HSendPacket(INT32 node, boolean reliable, UINT8 acknum,
+	size_t packetlength);
 boolean HGetPacket(void);
 void D_SetDoomcom(void);
 #ifndef NONET

src/d_netcmd.c

@@ -39,7 +39,6 @@
 #include "d_main.h"
 #include "m_random.h"
 #include "f_finale.h"
-#include "v_video.h"
 #include "filesrch.h"
 #include "mserv.h"
 #include "md5.h"
@@ -291,27 +290,15 @@ consvar_t cv_skipmapcheck = {"skipmapcheck", "Off", CV_SAVE, CV_OnOff, NULL, 0,
 
 INT32 cv_debug;
 
-static void UseMouse_OnChange(void);
-consvar_t cv_usemouse = {"use_mouse", "Off", CV_SAVE|CV_CALL,usemouse_cons_t, UseMouse_OnChange, 0, NULL, NULL, 0, 0, NULL};
-
-static void UseMouse_OnChange(void)
-{
-	GameFocus_menu_Onchange();
-	I_StartupMouse();
-}
+consvar_t cv_usemouse = {"use_mouse", "Off", CV_SAVE|CV_CALL,usemouse_cons_t, I_StartupMouse, 0, NULL, NULL, 0, 0, NULL};
 
 //WTF
 consvar_t cv_mouseturn = {"mouseturn", "Off", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
 
 // Lagless camera! Yay!
-consvar_t cv_laglesscam = {"lagless_camera", "Off", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
+consvar_t cv_laglesscam = {"laglesscamera", "Off", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
 
-consvar_t cv_verticallook[MAXSPLITSCREENPLAYERS] = {
-	{"verticallook", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"verticallook2", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"verticallook3", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"verticallook4", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL}
-};
+consvar_t cv_verticallook = {"verticallook", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
 
 #if defined(HAVE_SDL) || defined(_WINDOWS) //joystick 1 and 2
 consvar_t cv_usejoystick[MAXSPLITSCREENPLAYERS] = {
@@ -665,6 +652,7 @@ void D_RegisterServerCommands(void)
 	COM_AddCommand("addfilelocal", Command_Addfilelocal);
 	COM_AddCommand("addfile", Command_Addfile);
 	COM_AddCommand("addskins", Command_Addskins);
+	COM_AddCommand("localskin", Command_GLocalSkin);
 	COM_AddCommand("listwad", Command_ListWADS_f);
 	COM_AddCommand("listmapthings", Command_ListDoomednums_f);
 	COM_AddCommand("listunusedsprites", Command_ListUnusedSprites_f);
@@ -729,7 +717,7 @@ void D_RegisterServerCommands(void)
 	CV_RegisterVar(&cv_competitionboxes);
 	CV_RegisterVar(&cv_matchboxes);
 
-	K_RegisterServerKartStuff(); // SRB2kart
+	K_RegisterKartStuff(); // SRB2kart
 
 	CV_RegisterVar(&cv_ringslinger);
 
@@ -753,14 +741,9 @@ void D_RegisterServerCommands(void)
 	CV_RegisterVar(&cv_killingdead);
 
 	// d_clisrv
-#ifndef NONET
-#ifdef SATURNJOIN
-	CV_RegisterVar(&cv_allownewsaturnplayer); // need to register it before cv_maxplayers && cv_allownewplayer
-#endif
-#endif
 	CV_RegisterVar(&cv_maxplayers);
 	CV_RegisterVar(&cv_resynchattempts);
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 	CV_RegisterVar(&cv_gamestateattempts);
 	CV_RegisterVar(&cv_resynchcooldown);
 #endif
@@ -771,7 +754,9 @@ void D_RegisterServerCommands(void)
 	CV_RegisterVar(&cv_httpsource);
 #ifndef NONET
 	CV_RegisterVar(&cv_allownewplayer);
-
+#ifdef SATURNJOIN
+	CV_RegisterVar(&cv_allownewsaturnplayer);
+#endif
 	CV_RegisterVar(&cv_joinrefusemessage);
 	CV_RegisterVar(&cv_chatlogsize);
 #ifdef VANILLAJOINNEXTROUND
@@ -810,6 +795,8 @@ void D_RegisterServerCommands(void)
 	CV_RegisterVar(&cv_netdemosyncquality);
 	CV_RegisterVar(&cv_maxdemosize);
 	CV_RegisterVar(&cv_demochangemap);
+
+	CV_RegisterVar(&cv_keyboardlayout);
 }
 
 // =========================================================================
@@ -868,10 +855,6 @@ void D_RegisterClientCommands(void)
 	COM_AddCommand("stopmovie", Command_StopMovie_f);
 	COM_AddCommand("minigen", M_MinimapGenerate);
 
-	COM_AddCommand("localskin", Command_GLocalSkin);
-
-	K_RegisterClientKartStuff(); // SRB2kart
-
 	CV_RegisterVar(&cv_screenshot_option);
 	CV_RegisterVar(&cv_screenshot_folder);
 	CV_RegisterVar(&cv_moviemode);
@@ -922,13 +905,11 @@ void D_RegisterClientCommands(void)
 #ifdef SEENAMES
 	CV_RegisterVar(&cv_seenames);
 #endif
-
 	CV_RegisterVar(&cv_rollingdemos);
-
 	CV_RegisterVar(&cv_netstat);
 	CV_RegisterVar(&cv_netticbuffer);
 	CV_RegisterVar(&cv_mindelay);
-	CV_RegisterVar(&cv_gentlemens);
+	CV_RegisterVar(&cv_lagless);
 
 #ifdef NETGAME_DEVMODE
 	CV_RegisterVar(&cv_fishcake);
@@ -943,8 +924,6 @@ void D_RegisterClientCommands(void)
 
 	CV_RegisterVar(&cv_cechotoggle);
 
-	CV_RegisterVar(&cv_keyboardlayout);
-
 	// time attack ghost options are also saved to config
 	CV_RegisterVar(&cv_ghost_besttime);
 	CV_RegisterVar(&cv_ghost_bestlap);
@@ -954,10 +933,7 @@ void D_RegisterClientCommands(void)
 
 	COM_AddCommand("displayplayer", Command_Displayplayer_f);
 
-	CV_RegisterVar(&cv_audbuffersize);
-
-	CV_RegisterVar(&cv_palette);
-	CV_RegisterVar(&cv_palettenum);
+	CV_RegisterVar(&cv_audbuffersize); 
 
 	// m_menu.c
 	CV_RegisterVar(&cv_chatheight);
@@ -968,10 +944,10 @@ void D_RegisterClientCommands(void)
 	CV_RegisterVar(&cv_chatnotifications);
 	CV_RegisterVar(&cv_chatbacktint);
 	CV_RegisterVar(&cv_songcredits);
-	CV_RegisterVar(&cv_showfreeplay);
+	CV_RegisterVar(&cv_showfreeplay);	
 	CV_RegisterVar(&cv_skinselectspin);
 	CV_RegisterVar(&cv_showallmaps);
-
+	
 	CV_RegisterVar(&cv_growmusic);
 	CV_RegisterVar(&cv_supermusic);
 
@@ -1057,7 +1033,7 @@ void D_RegisterClientCommands(void)
 	CV_RegisterVar(&cv_midimusicvolume);
 #endif
 	CV_RegisterVar(&cv_numChannels);
-
+	
 #ifdef HAVE_OPENMPT
 	CV_RegisterVar(&cv_modfilter);
 	CV_RegisterVar(&cv_stereosep);
@@ -1072,6 +1048,7 @@ void D_RegisterClientCommands(void)
 	CV_RegisterVar(&cv_renderview);
 	CV_RegisterVar(&cv_vhseffect);
 	CV_RegisterVar(&cv_shittyscreen);
+	CV_RegisterVar(&cv_scr_depth);
 	CV_RegisterVar(&cv_scr_width);
 	CV_RegisterVar(&cv_scr_height);
 
@@ -1091,12 +1068,7 @@ void D_RegisterClientCommands(void)
 
 	CV_RegisterVar(&cv_laglesscam);
 
-	for (i = 0; i < MAXSPLITSCREENPLAYERS; i++)
-	{
-		CV_RegisterVar(&cv_verticallook[i]);
-	}
-
-	CV_RegisterVar(&cv_demodateformat);
+	CV_RegisterVar(&cv_verticallook);
 
 	// ingame object placing
 	COM_AddCommand("objectplace", Command_ObjectPlace_f);
@@ -1443,7 +1415,11 @@ static void SetPlayerName(INT32 playernum, char *newname)
 		CONS_Printf(M_GetText("Player %d sent a bad name change\n"), playernum+1);
 		if (server && netgame)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 	}
 }
@@ -2037,8 +2013,12 @@ static void Got_NameAndColor(UINT8 **cp, INT32 playernum)
 
 		if (kick)
 		{
+			UINT8 buf[2];
 			CONS_Alert(CONS_WARNING, M_GetText("Illegal color change received from %s (team: %d), color: %d)\n"), player_names[playernum], p->ctfteam, p->skincolor);
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 			return;
 		}
 	}
@@ -2244,16 +2224,13 @@ static void Command_View_f(void)
 	if (COM_Argc() > 1)/* switch to player */
 	{
 		playerparam = COM_Argv(1);
-
 		if (playerparam[0] == '#')/* search by placement */
 		{
 			placenum = atoi(&playerparam[1]);
 			playernum = FindPlayerByPlace(placenum);
-
 			if (playernum == -1 || !G_CouldView(playernum))
 			{
 				GetViewablePlayerPlaceRange(&firstplace, &lastplace);
-
 				if (playernum == -1)
 				{
 					CONS_Alert(CONS_WARNING, "There is no player in that place! ");
@@ -2265,7 +2242,6 @@ static void Command_View_f(void)
 							"The first player that you can view is \x82#%d\x80; ",
 							firstplace);
 				}
-
 				CONS_Printf("Last place is \x82#%d\x80.\n", lastplace);
 				return;
 			}
@@ -2620,7 +2596,6 @@ void D_PickVote(void)
 	{
 		if (!playeringame[i] || players[i].spectator)
 			continue;
-
 		if (votes[i] != -1)
 		{
 			temppicks[numvotes] = i;
@@ -2696,8 +2671,7 @@ static tic_t last_map_cmd = 0;
 //
 static void Command_Map_f(void)
 {
-	if (I_GetTime() - last_map_cmd < 20)
-	{
+	if (I_GetTime() - last_map_cmd < 20) {
 		CONS_Alert(CONS_WARNING, "Map command is used too frequently!\n");
 		return;
 	}
@@ -2755,7 +2729,8 @@ static void Command_Map_f(void)
 	{
 		if (!multiplayer)
 		{
-			CONS_Printf(M_GetText("You can't switch gametypes in single player!\n"));
+			CONS_Printf(M_GetText(
+						"You can't switch gametypes in single player!\n"));
 			return;
 		}
 		else if (COM_Argc() < option_gametype + 2)/* no argument after? */
@@ -2924,7 +2899,11 @@ static void Got_Mapcmd(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal map change received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -2965,6 +2944,9 @@ static void Got_Mapcmd(UINT8 **cp, INT32 playernum)
 		CON_LogMessage(M_GetText("Speeding off to level...\n"));
 	}
 
+	if (demo.playback && !demo.timing)
+		precache = false;
+
 	if (resetplayer)
 	{
 		if (!FLS || (netgame || multiplayer))
@@ -2980,7 +2962,8 @@ static void Got_Mapcmd(UINT8 **cp, INT32 playernum)
 	demo.savemode = (cv_recordmultiplayerdemos.value == 2) ? DSM_WILLAUTOSAVE : DSM_NOTSAVING;
 	demo.savebutton = 0;
 	G_InitNew(pencoremode, mapname, resetplayer, skipprecutscene);
-
+	if (demo.playback && !demo.timing)
+		precache = true;
 	if (demo.timing)
 		G_DoneLevelLoad();
 
@@ -3039,7 +3022,11 @@ static void Got_Pause(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal pause command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -3084,25 +3071,18 @@ static void Command_ReplayMarker(void)
 		CONS_Printf(M_GetText("You must be in a level to use this.\n"));
 		return;
 	}
-	if (demo.savemode == DSM_WILLAUTOSAVE)
-	{
+	if (demo.savemode == DSM_WILLAUTOSAVE) {
 		demo.savemode = DSM_NOTSAVING;
 		CONS_Printf("Replay unmarked.\n");
-	}
-	else
-	{
-		demo.savemode = DSM_WILLAUTOSAVE;
-
+	} else {
 		int adjustedleveltime = leveltime - starttime;
-
+		demo.savemode = DSM_WILLAUTOSAVE;
 		if (adjustedleveltime < 0)
 			adjustedleveltime = 0;
-
 		char *title = G_BuildMapTitle(gamemap);
 		snprintf(demo.titlename, 64, "%s [%i:%02d/%.5s]", title, G_TicsToMinutes(adjustedleveltime, false), G_TicsToSeconds(adjustedleveltime), modeattacking ? "Record Attack" : connectedservername);
 		if (title)
 			Z_Free(title);
-
 		CONS_Printf("Replay will be saved!\n");
 	}
 }
@@ -3160,7 +3140,11 @@ static void Got_Respawn(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal respawn command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -3230,7 +3214,11 @@ static void Got_Clearscores(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal clear scores command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -3749,7 +3737,11 @@ static void Got_Teamchange(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal team change received from player %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 	}
 
@@ -3760,7 +3752,11 @@ static void Got_Teamchange(UINT8 **cp, INT32 playernum)
 			CONS_Alert(CONS_WARNING, M_GetText("Illegal team change received from player %s\n"), player_names[playernum]);
 			if (server)
 			{
-				SendKick(playernum, KICK_MSG_CON_FAIL);
+				UINT8 buf[2];
+
+				buf[0] = (UINT8)playernum;
+				buf[1] = KICK_MSG_CON_FAIL;
+				SendNetXCmd(XD_KICK, &buf, 2);
 			}
 			return;
 		}
@@ -3794,7 +3790,11 @@ static void Got_Teamchange(UINT8 **cp, INT32 playernum)
 			CONS_Alert(CONS_WARNING, M_GetText("Illegal team change received from player %s\n"), player_names[playernum]);
 			if (server)
 			{
-				SendKick(playernum, KICK_MSG_CON_FAIL);
+				UINT8 buf[2];
+
+				buf[0] = (UINT8)playernum;
+				buf[1] = KICK_MSG_CON_FAIL;
+				SendNetXCmd(XD_KICK, &buf, 2);
 			}
 		}
 		return;
@@ -3843,8 +3843,12 @@ static void Got_Teamchange(UINT8 **cp, INT32 playernum)
 
 	if (server && ((NetPacket.packet.newteam < 0 || NetPacket.packet.newteam > 3) || error))
 	{
+		UINT8 buf[2];
+
+		buf[0] = (UINT8)playernum;
+		buf[1] = KICK_MSG_CON_FAIL;
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal team change received from player %s\n"), player_names[playernum]);
-		SendKick(playernum, KICK_MSG_CON_FAIL);
+		SendNetXCmd(XD_KICK, &buf, 2);
 	}
 
 	//Safety first!
@@ -4213,7 +4217,11 @@ static void Got_Verification(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal verification received from %s (serverplayer is %s)\n"), player_names[playernum], player_names[serverplayer]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -4265,7 +4273,11 @@ static void Got_Removal(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal demotion received from %s (serverplayer is %s)\n"), player_names[playernum], player_names[serverplayer]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -4341,7 +4353,11 @@ static void Got_MotD_f(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal motd change received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 
 		Z_Free(mymotd);
@@ -4400,7 +4416,11 @@ static void Got_RunSOCcmd(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal runsoc command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -4454,7 +4474,7 @@ static void Command_Addfilelocal(void)
 	// Add any wad file, ignoring checks for if it contains complex things like
 	// lua. Great for complex but client-side customizations, like different
 	// level cards or anything like that.
-	P_AddWadFile(fn, true);
+	P_AddWadFileLocal(fn);
 }
 
 
@@ -4549,9 +4569,38 @@ static void Command_Addfile(void)
 
 /** Adds something at runtime.
   */
-static void Command_Addskins(void)
+static void
+Command_Addskins (void)
 {
-	CONS_Printf("addskins has been deprecated\nuse addfilelocal instead!\n");
+	if (COM_Argc() > 3)
+	{
+		CONS_Printf(
+				"addskins <file>: Load a skin file.\n");
+		return;
+	}
+	// no forcing?
+	/*
+	if (fasticmp(COM_Argv(2), "-force") || fasticmp(COM_Argv(2), "-f")) {
+		CONS_Alert(CONS_NOTICE, M_GetText("Adding file %s. May or may not be a skin.\n"), COM_Argv(1));
+		P_AddWadFile(COM_Argv(1), 0, true);	
+	} else {
+		if (DumbStartsWith("KC_", COM_Argv(1))) {
+			P_AddWadFile(COM_Argv(1), 0, true);
+		} else if (DumbStartsWith("KCL_", COM_Argv(1))) {
+			if (!demo.playback) {
+				CONS_Alert(CONS_ERROR, M_GetText("Cannot add file %s as it is a skin with lua. Include -force or -f to force it to load.\n"), COM_Argv(1));
+				return;
+			} else {
+	*/
+				P_AddWadFile(COM_Argv(1), true);
+	/*
+			}
+		} else {
+			CONS_Alert(CONS_ERROR, M_GetText("Cannot add file %s as it is not a skin.\n"), COM_Argv(1));
+			return;
+		}
+	}
+	*/
 }
 
 static void Command_GLocalSkin (void)
@@ -4567,7 +4616,7 @@ static void Command_GLocalSkin (void)
 
 	char* fuck; // local skin name
 
-	if (!(first_option = COM_FirstOption()))
+	if (!( first_option = COM_FirstOption() ))
 		first_option = COM_Argc();
 
 	if (first_option < 2)
@@ -4575,14 +4624,14 @@ static void Command_GLocalSkin (void)
 		/* holy fucking shit */
 		CONS_Printf("localskin <name> [-player <name>] [-display <number>] [-all]:\n");
 		CONS_Printf(M_GetText("Set a localskin via its internal name (usually printed on the console).\n\n\
-		* Using \"-player\" will set a localskin to a specified player.\n\
-		Defaults to yourself.\n\
-		* Using \"-display\" will set a localskin to the displayed player.\n\
-		Defaults to 0, which is the first player displayed.\n\
-		Can go up to 3 for splitscreen.\n\
-		* Using \"-all\" will set a localskin to ALL players.\n\
-		* \"localskin none\" removes the localskin, just like how\n\
-		\"forceskin none\" does.\n"));
+* Using \"-player\" will set a localskin to a specified player.\n\
+  Defaults to yourself.\n\
+* Using \"-display\" will set a localskin to the displayed player.\n\
+  Defaults to 0, which is the first player displayed.\n\
+  Can go up to 3 for splitscreen.\n\
+* Using \"-all\" will set a localskin to ALL players.\n\
+* \"localskin none\" removes the localskin, just like how\n\
+  \"forceskin none\" does.\n"));
 		return;
 	}
 
@@ -4613,7 +4662,7 @@ static void Command_GLocalSkin (void)
 	{
 		int i;
 
-		for (i = 0; i < MAXPLAYERS; ++i)
+		for (i = 0; i < MAXPLAYERS; ++i) 
 		{
 			if (!playeringame[i])
 				continue;
@@ -4680,8 +4729,13 @@ static void Got_RequestAddfilecmd(UINT8 **cp, INT32 playernum)
 
 	if ((playernum != serverplayer && !IsPlayerAdmin(playernum)) || kick)
 	{
+		UINT8 buf[2];
+
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal addfile command received from %s\n"), player_names[playernum]);
-		SendKick(playernum, KICK_MSG_CON_FAIL);
+
+		buf[0] = (UINT8)playernum;
+		buf[1] = KICK_MSG_CON_FAIL;
+		SendNetXCmd(XD_KICK, &buf, 2);
 		return;
 	}
 
@@ -4730,7 +4784,11 @@ static void Got_Addfilecmd(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal addfile command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -5540,7 +5598,11 @@ static void Got_ExitLevelcmd(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal exitlevel command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -5558,7 +5620,11 @@ static void Got_SetupVotecmd(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal vote setup received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -5619,7 +5685,11 @@ static void Got_PickVotecmd(UINT8 **cp, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal vote setup received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}
@@ -5662,7 +5732,6 @@ void Command_ExitGame_f(void)
 	botskin = 0;
 	cv_debug = 0;
 	emeralds = 0;
-	automapactive = false;
 
 	if (dirmenu)
 		closefilemenu(true);
@@ -5709,8 +5778,12 @@ static void Fishcake_OnChange(void)
   */
 static void Command_Isgamemodified_f(void)
 {
-	if (majormods || modifiedgame)
-		CONS_Printf("The game has been modified, Record Attack data will be saved to a seperate savegame.\n");
+	if (majormods)
+		CONS_Printf("The game has been modified with major addons, so you cannot play Record Attack.\n");
+	else if (savemoddata)
+		CONS_Printf("The game has been modified with an addon with its own save data, so you can play Record Attack and earn medals.\n");
+	else if (modifiedgame)
+		CONS_Printf("The game has been modified with only minor addons. You can play Record Attack, earn medals and unlock extras.\n");
 	else
 		CONS_Printf("The game has not been modified. You can play Record Attack, earn medals and unlock extras.\n");
 }
@@ -6000,7 +6073,7 @@ static void Command_ListSkins(void)
 }
 
 static void Command_SkinSearch(void)
-{
+{	
 	size_t i;
 	UINT16 s;
 	UINT16 ic = 0;
@@ -6010,7 +6083,7 @@ static void Command_SkinSearch(void)
 		{
 			skin_t *skininput = &skins[s];
 			if (strcasestr(skininput->realname,COM_Argv(i)))
-			{
+			{	
 				ic++;
 				CONS_Printf("%d. %s%s:\x80 %s\n", ic,HU_SkinColorToConsoleColor(skininput->prefcolor),skininput->realname,skininput->name);
 			}
@@ -6255,7 +6328,11 @@ void Got_DiscordInfo(UINT8 **p, INT32 playernum)
 		CONS_Alert(CONS_WARNING, M_GetText("Illegal Discord info command received from %s\n"), player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
+			UINT8 buf[2];
+
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
 		}
 		return;
 	}

src/d_netcmd.h

@@ -149,9 +149,8 @@ extern consvar_t cv_pingstyle;
 //extern consvar_t cv_smallpos;
 extern consvar_t cv_showminimapnames;
 extern consvar_t cv_minihead;
-extern consvar_t cv_showminimapangle;
 
-extern consvar_t cv_showlapemblem;
+extern consvar_t cv_showlapemblem; 
 
 extern consvar_t cv_showviewpointtext;
 extern consvar_t cv_showdownloadprompt;
@@ -199,6 +198,8 @@ extern consvar_t cv_betainterscreen;
 
 extern consvar_t cv_laglesscam;
 
+extern consvar_t cv_verticallook;
+
 typedef enum
 {
 	SKINMENUTYPE_SCROLL = 0,

src/d_netfil.c

@@ -64,11 +64,11 @@ static boolean SV_SendFile(INT32 node, const char *filename, UINT8 fileid);
 
 #ifdef HAVE_CURL
 size_t curlwrite_data(void *ptr, size_t size, size_t nmemb, FILE *stream);
-#if (LIBCURL_VERSION_MAJOR <= 7) && (LIBCURL_VERSION_MINOR < 35)
-static int curlprogress_callback(void *clientp, double dltotal, double dlnow, double ultotal, double ulnow);
-#else
+#if defined(CURL_AT_LEAST_VERSION) && CURL_AT_LEAST_VERSION(7, 35, 0)
 static int curlprogress_callbackx(void *clientp, curl_off_t dltotal, curl_off_t dlnow, curl_off_t ultotal, curl_off_t ulnow);
 #define XFERINFOFUNCTION
+#else
+static int curlprogress_callback(void *clientp, double dltotal, double dlnow, double ultotal, double ulnow);
 #endif
 #endif
 
@@ -114,14 +114,24 @@ fileneeded_t fileneeded[MAX_WADFILES]; // List of needed files
 static I_mutex downloadmutex;
 char downloaddir[512] = "DOWNLOAD";
 
-file_download_t filedownload;
+#ifdef CLIENT_LOADINGSCREEN
+// for cl loading screen
+INT32 lastfilenum = -1;
+INT32 downloadcompletednum = 0;
+UINT32 downloadcompletedsize = 0;
+INT32 totalfilesrequestednum = 0;
+UINT32 totalfilesrequestedsize = 0;
+#endif
 
 #ifdef HAVE_CURL
 static CURL *http_handle;
 static CURLM *multi_handle;
-static UINT32 curl_dlnow;
-static UINT32 curl_dltotal;
+boolean curl_running = false;
+boolean curl_failedwebdownload = false;
+static double curl_dlnow;
+static double curl_dltotal;
 static time_t curl_starttime;
+INT32 curl_transfers = 0;
 static int curl_runninghandles = 0;
 static UINT32 curl_origfilesize;
 static UINT32 curl_origtotalfilesize;
@@ -212,7 +222,6 @@ void D_ParseFileneeded(INT32 fileneedednum_parm, UINT8 *fileneededstr, UINT16 fi
 	for (i = firstfile; i < fileneedednum; i++)
 	{
 		fileneeded[i].status = FS_NOTCHECKED; // We haven't even started looking for the file yet
-		fileneeded[i].justdownloaded = false;
 		filestatus = READUINT8(p); // The first byte is the file status
 		fileneeded[i].willsend = (UINT8)(filestatus >> 4);
 		fileneeded[i].totalsize = READUINT32(p); // The four next bytes are the file size
@@ -225,11 +234,10 @@ void D_ParseFileneeded(INT32 fileneedednum_parm, UINT8 *fileneededstr, UINT16 fi
 void CL_PrepareDownloadSaveGame(const char *tmpsave)
 {
 #ifdef CLIENT_LOADINGSCREEN
-	filedownload.current = -1;
+	lastfilenum = -1;
 #endif
 	fileneedednum = 1;
 	fileneeded[0].status = FS_REQUESTED;
-	fileneeded[0].justdownloaded = false;
 	fileneeded[0].totalsize = UINT32_MAX;
 	fileneeded[0].file = NULL;
 	memset(fileneeded[0].md5sum, 0, 16);
@@ -544,13 +552,13 @@ INT32 CL_CheckFiles(void)
 	{
 		if (fileneeded[i].status == FS_NOTFOUND || fileneeded[i].status == FS_MD5SUMBAD || fileneeded[i].status == FS_FALLBACK)
 			downloadrequired = true;
-
+		
 		if (fileneeded[i].status != FS_OPEN)
 			filestoload++;
 
 		if (fileneeded[i].status != FS_NOTCHECKED) //since we're running this over multiple tics now, its possible for us to come across files checked in previous tics
 			continue;
-
+		
 		CONS_Debug(DBG_NETPLAY, "searching for '%s' ", fileneeded[i].filename);
 
 		// Check in already loaded files
@@ -654,10 +662,13 @@ static boolean SV_SendFile(INT32 node, const char *filename, UINT8 fileid)
 		q = &((*q)->next);
 
 	// Allocate a file request and append it to the file list
-	p = *q = (filetx_t *)calloc(1, sizeof(filetx_t)); // Initialise with zeros
+	p = *q = (filetx_t *)malloc(sizeof (filetx_t));
 	if (!p)
 		I_Error("SV_SendFile: No more memory\n");
 
+	// Initialise with zeros
+	memset(p, 0, sizeof (filetx_t));
+
 	// Allocate the file name
 	p->id.filename = (char *)malloc(MAX_WADPATH);
 	if (!p->id.filename)
@@ -736,10 +747,13 @@ void SV_SendRam(INT32 node, void *data, size_t size, freemethod_t freemethod, UI
 		q = &((*q)->next);
 
 	// Allocate a file request and append it to the file list
-	p = *q = (filetx_t *)calloc(1, sizeof(filetx_t)); // Initialise with zeros
+	p = *q = (filetx_t *)malloc(sizeof (filetx_t));
 	if (!p)
 		I_Error("SV_SendRam: No more memory\n");
 
+	// Initialise with zeros
+	memset(p, 0, sizeof (filetx_t));
+
 	p->ram = freemethod; // Remember how to free the memory block for when we're done sending it
 	p->id.ram = data;
 	p->size = (UINT32)size;
@@ -823,7 +837,6 @@ void SV_FileSendTicker(void)
 
 	netbuffer->packettype = PT_FILEFRAGMENT;
 
-	// (((sendbytes-nowsentbyte)*TICRATE)/(I_GetTime()-starttime)<(UINT32)net_bandwidth)
 	while (packetsent-- && filestosend != 0)
 	{
 		for (i = currentnode, j = 0; j < MAXNETNODES;
@@ -854,12 +867,8 @@ void SV_FileSendTicker(void)
 
 					if (!transferFiles[f->fileid].file)
 					{
-						CONS_Alert(CONS_ERROR, "Can't open file %s: %s\n",
+						I_Error("Can't open file %s: %s",
 							f->id.filename, strerror(errno));
-
-						SV_EndFileSend(i);
-						HSendPacket(i, true, 0, PT_SERVERREFUSE);
-						break;
 					}
 				}
 
@@ -964,7 +973,7 @@ void Got_Filetxpak(void)
 
 	if (filenum >= fileneedednum)
 	{
-		DEBFILE(va("filefragment not needed %d>%d\n", filenum, fileneedednum));
+		DEBFILE(va("fileframent not needed %d>%d\n", filenum, fileneedednum));
 		//I_Error("Received an unneeded file fragment (file id received: %d, file id needed: %d)\n", filenum, fileneedednum);
 		return;
 	}
@@ -985,7 +994,6 @@ void Got_Filetxpak(void)
 	{
 		UINT32 pos = LONG(netbuffer->u.filetxpak.position);
 		UINT16 size = SHORT(netbuffer->u.filetxpak.size);
-
 		// Use a special trick to know when the file is complete (not always used)
 		// WARNING: file fragments can arrive out of order so don't stop yet!
 		if (pos & 0x80000000)
@@ -1005,16 +1013,15 @@ void Got_Filetxpak(void)
 			fclose(file->file);
 			file->file = NULL;
 			file->status = FS_FOUND;
-			file->justdownloaded = true;
 			CONS_Printf(M_GetText("Downloading %s...(done)\n"),
 				filename);
 #ifndef NONET
-			filedownload.completednum++;
-			filedownload.completedsize += file->totalsize;
+			downloadcompletednum++;
+			downloadcompletedsize += file->totalsize;
 #endif
 		}
 	}
-	else if (!file->justdownloaded)
+	else
 	{
 		const char *s;
 		switch(file->status)
@@ -1037,7 +1044,6 @@ void Got_Filetxpak(void)
 		}
 		I_Error("Received a file not requested (file id: %d, file status: %s)\n", filenum, s);
 	}
-
 	// Send ack back quickly
 	if (++filetime == 3)
 	{
@@ -1046,7 +1052,7 @@ void Got_Filetxpak(void)
 	}
 
 #ifdef CLIENT_LOADINGSCREEN
-	filedownload.current = filenum;
+	lastfilenum = filenum;
 #endif
 }
 
@@ -1195,7 +1201,9 @@ filestatus_t findfile(char *filename, const UINT8 *wantedmd5sum, boolean complet
 #ifdef HAVE_CURL
 size_t curlwrite_data(void *ptr, size_t size, size_t nmemb, FILE *stream)
 {
-   return fwrite(ptr, size, nmemb, stream);
+    size_t written;
+    written = fwrite(ptr, size, nmemb, stream);
+    return written;
 }
 
 #ifdef XFERINFOFUNCTION
@@ -1209,12 +1217,12 @@ static int curlprogress_callbackx(void *clientp, curl_off_t dltotal, curl_off_t
 
 	curtime = time(NULL);
 
-	curl_dlnow = (UINT32)dlnow;
-	curl_dltotal = (UINT32)dltotal;
+	curl_dlnow = dlnow;
+	curl_dltotal = dltotal;
 
 	if (curtime > curl_starttime)
 	{
-		getbytes = ((double)dlnow) / (curtime - curl_starttime); // To-do: Make this more accurate???
+		getbytes = curl_dlnow / (curtime - curl_starttime); // To-do: Make this more accurate???
 	}
 	else
 	{
@@ -1234,12 +1242,12 @@ static int curlprogress_callback(void *clientp, double dltotal, double dlnow, do
 
 	curtime = time(NULL);
 
-	curl_dlnow = (UINT32)dlnow;
-	curl_dltotal = (UINT32)dltotal;
+	curl_dlnow = dlnow;
+	curl_dltotal = dltotal;
 
 	if (curtime > curl_starttime)
 	{
-		getbytes = ((double)dlnow) / (curtime - curl_starttime); // To-do: Make this more accurate???
+		getbytes = curl_dlnow / (curtime - curl_starttime); // To-do: Make this more accurate???
 	}
 	else
 	{
@@ -1281,10 +1289,10 @@ void CURLPrepareFile(const char* url, int dfilenum)
 		curl_easy_setopt(http_handle, CURLOPT_URL, va("%s/%s", url, curl_realname));
 
 		// Only allow HTTP and HTTPS
-#if (LIBCURL_VERSION_MAJOR <= 7) && (LIBCURL_VERSION_MINOR < 85)
-		curl_easy_setopt(http_handle, CURLOPT_PROTOCOLS, CURLPROTO_HTTP|CURLPROTO_HTTPS);
-#else
+#if defined(CURL_AT_LEAST_VERSION) && CURL_AT_LEAST_VERSION(7, 85, 0)
 		curl_easy_setopt(http_handle, CURLOPT_PROTOCOLS_STR, "http,https");
+#else
+		curl_easy_setopt(http_handle, CURLOPT_PROTOCOLS, CURLPROTO_HTTP|CURLPROTO_HTTPS);
 #endif
 
 		curl_easy_setopt(http_handle, CURLOPT_USERAGENT, va("SRB2Kart/v%d.%d", VERSION, SUBVERSION)); // Set user agent as some servers won't accept invalid user agents.
@@ -1316,25 +1324,23 @@ void CURLPrepareFile(const char* url, int dfilenum)
 #endif
 
 		curl_curfile->status = FS_DOWNLOADING;
+		lastfilenum = dfilenum;
 		curl_multi_add_handle(multi_handle, http_handle);
 
 		curl_multi_perform(multi_handle, &curl_runninghandles);
 		curl_starttime = time(NULL);
 
-		filedownload.current = dfilenum;
-		filedownload.http_running = true;
+		curl_running = true;
 
 #ifdef HAVE_THREADS
 		I_spawn_thread("http-download", (I_thread_fn)CURLGetFile, NULL);
 #endif
 	}
-	else
-		filedownload.http_running = false;
 }
 
 void CURLAbortFile(void)
 {
-	filedownload.http_running = false;
+	curl_running = false;
 
 	// lock and unlock to wait for the download thread to exit
 	I_lock_mutex(&downloadmutex);
@@ -1351,8 +1357,10 @@ void CURLGetFile(void)
 	int msgs_left; /* how many messages are left */
 	const char *easy_handle_error;
 	boolean running = true;
+	long response_code = 0;
+	static char *filename;
 
-	while (running && filedownload.http_running)
+	while (running && curl_running)
     {
     	if (curl_runninghandles)
 		{
@@ -1379,13 +1387,11 @@ void CURLGetFile(void)
 				e = m->easy_handle;
 				easyres = m->data.result;
 
-				char *filename = Z_StrDup(curl_realname);
+				filename = Z_StrDup(curl_realname);
 				nameonly(filename);
 
 				if (easyres != CURLE_OK)
 				{
-					long response_code = 0;
-
 					if (easyres == CURLE_HTTP_RETURNED_ERROR)
 						curl_easy_getinfo(e, CURLINFO_RESPONSE_CODE, &response_code);
 
@@ -1393,7 +1399,7 @@ void CURLGetFile(void)
 					curl_curfile->status = FS_FALLBACK;
 					curl_curfile->currentsize = curl_origfilesize;
 					curl_curfile->totalsize = curl_origtotalfilesize;
-					filedownload.http_failed = true;
+					curl_failedwebdownload = true;
 					fclose(curl_curfile->file);
 					remove(curl_curfile->filename);
 					CONS_Printf(M_GetText("Failed to download %s (%s)\n"), filename, easy_handle_error);
@@ -1406,37 +1412,36 @@ void CURLGetFile(void)
 					{
 						CONS_Alert(CONS_ERROR, M_GetText("HTTP Download of %s finished but is corrupt or has been modified\n"), filename);
 						curl_curfile->status = FS_FALLBACK;
-						filedownload.http_failed = true;
+						curl_failedwebdownload = true;
 					}
 					else
 					{
 						CONS_Printf(M_GetText("Finished HTTP download of %s\n"), filename);
-						filedownload.completednum++;
-						filedownload.completedsize += curl_curfile->totalsize;
+						downloadcompletednum++;
+						downloadcompletedsize += curl_curfile->totalsize;
 						curl_curfile->status = FS_FOUND;
 					}
 				}
 
 				Z_Free(filename);
 				curl_curfile->file = NULL;
-				filedownload.remaining--;
+				curl_transfers--;
 				curl_multi_remove_handle(multi_handle, e);
 				curl_easy_cleanup(e);
 
-				if (!filedownload.remaining)
+				if (!curl_transfers)
 					break;
 			}
 		}
 	}
 
-    if (!filedownload.remaining || !filedownload.http_running)
+    if (!curl_transfers || !curl_running)
     {
 		curl_multi_cleanup(multi_handle);
 		curl_global_cleanup();
 		multi_handle = NULL;
     }
-
-	filedownload.http_running = false;
+	curl_running = false;
 	I_unlock_mutex(downloadmutex);
 }
 

src/d_netfil.h

@@ -13,7 +13,6 @@
 #ifndef __D_NETFIL__
 #define __D_NETFIL__
 
-#include "d_clisrv.h"
 #include "w_wad.h"
 
 typedef enum
@@ -46,35 +45,24 @@ typedef struct
 	UINT32 currentsize;
 	UINT32 totalsize;
 	filestatus_t status; // The value returned by recsearch
-	boolean justdownloaded; // To prevent late fragments from causing an I_Error
 } fileneeded_t;
 
 extern INT32 fileneedednum;
 extern fileneeded_t fileneeded[MAX_WADFILES];
 extern char downloaddir[512];
 
-typedef struct
-{
 #ifdef CLIENT_LOADINGSCREEN
-	INT32 current;
-	INT32 completednum;
-	UINT32 completedsize;
-	INT32 totalnum;
-	UINT32 totalsize;
+extern INT32 lastfilenum;
+extern INT32 downloadcompletednum;
+extern UINT32 downloadcompletedsize;
+extern INT32 totalfilesrequestednum;
+extern UINT32 totalfilesrequestedsize;
 #endif
 
 #ifdef HAVE_CURL
-	INT32 remaining;
-	boolean http_failed;
-	boolean http_running;
-
-	char http_source[MAX_MIRROR_LENGTH+1];
-#endif
-} file_download_t;
-
-extern file_download_t filedownload;
-
-#ifdef HAVE_CURL
+extern boolean curl_failedwebdownload;
+extern boolean curl_running;
+extern INT32 curl_transfers;
 
 typedef struct HTTP_login HTTP_login;
 

src/d_player.h

@@ -356,16 +356,6 @@ typedef enum
 	LAP__MAX
 } laptime_e;
 
-// yes i made a whole struct for this :chonkbuncle:
-typedef struct squishdance_s
-{
-	tic_t   countdown; // hold "custom 3" for 2 seconds to engange le dance
-	tic_t   time;
-	fixed_t work;
-	fixed_t ang;
-	fixed_t bounce;    // hehe squishy
-} squishdance_t;
-
 // ========================================================================
 //                          PLAYER STRUCTURE
 // ========================================================================
@@ -412,7 +402,7 @@ typedef struct player_s
 	INT32 kartstuff[NUMKARTSTUFF];
 	angle_t frameangle; // for the player add the ability to have the sprite only face other angles
 	angle_t old_frameangle, old_frameangle2;
-
+	
 	// SRB2Kart CEP: Sliptide rolling
 	angle_t sliproll;
 
@@ -565,8 +555,6 @@ typedef struct player_s
 
 	fixed_t spinoutrot; // When a player spins out, this value increments modulus 360.
 
-	squishdance_t squishdance;
-
 	fixed_t fovadd; // adjust FOV for hw rendering
 } player_t;
 

src/d_think.h

@@ -17,8 +17,6 @@
 #ifndef __D_THINK__
 #define __D_THINK__
 
-#include "doomdef.h"
-
 #ifdef __GNUG__
 #pragma interface
 #endif
@@ -52,10 +50,6 @@ typedef struct thinker_s
 	// this one using pointers. Used for garbage collection.
 	INT32 references;
 	boolean cachable;
-#ifdef PARANOIA
-	INT32 debug_mobjtype;
-	tic_t debug_time;
-#endif
 } thinker_t;
 
 #endif

src/dehacked.c

@@ -28,7 +28,7 @@
 #include "p_local.h" // for var1 and var2, and some constants
 #include "p_setup.h"
 #include "r_data.h"
-#include "r_fps.h"
+#include "r_patch.h"
 #include "r_sky.h"
 #include "r_draw.h" // translation colormap consts (for lua)
 #include "fastcmp.h"
@@ -1799,7 +1799,7 @@ static void readsound(MYFILE *f, INT32 num, const char *savesfxnames[])
  * \sa readmaincfg()
  * \author Graue <graue@oceanbase.org>
  */
-/*static boolean GoodDataFileName(const char *s)
+static boolean GoodDataFileName(const char *s)
 {
 	const char *p;
 	const char *tail = ".dat";
@@ -1819,7 +1819,7 @@ static void readsound(MYFILE *f, INT32 num, const char *savesfxnames[])
 	if (fasticmp(s, "online.dat")) return false; // SRB2Kart online replay folder
 
 	return true;
-}*/
+}
 
 static void reademblemdata(MYFILE *f, INT32 num)
 {
@@ -2597,10 +2597,10 @@ static void readmaincfg(MYFILE *f)
 			{
 				maxXtraLife = (UINT8)get_number(word2);
 			}
+
 			else if (fastcmp(word, "GAMEDATA"))
 			{
-				// just ignore it but dont throw a warning
-				/*size_t filenamelen;
+				size_t filenamelen;
 
 				// Check the data filename so that mods
 				// can't write arbitrary files.
@@ -2624,7 +2624,7 @@ static void readmaincfg(MYFILE *f)
 				// can't use sprintf since there is %u in savegamename
 				strcatbf(savegamename, srb2home, PATHSEP);
 
-				refreshdirmenu |= REFRESHDIR_GAMEDATA;*/
+				refreshdirmenu |= REFRESHDIR_GAMEDATA;
 			}
 			else if (fastcmp(word, "RESETDATA"))
 			{

src/doomdef.h

@@ -113,8 +113,8 @@ extern char  logfilename[1024];
 #else
 #define VERSION    1 // Game version
 #define SUBVERSION 6 // more precise version number
-#define VERSIONSTRING "Saturn v8"
-#define VERSIONSTRINGW L"Saturn v8"
+#define VERSIONSTRING "Saturn v7.2"
+#define VERSIONSTRINGW L"Saturn v7.2"
 // Hey! If you change this, add 1 to the MODVERSION below! Otherwise we can't force updates!
 // And change CMakeLists.txt (not src/, but in root), for CMake users!
 // AND appveyor.yml, for the build bots!
@@ -547,19 +547,6 @@ UINT32 quickncasehash (const char *p, size_t n)
 #define DBL_EPSILON 2.2204460492503131e-16l
 #endif
 
-#if defined(__GNUC__) || defined(__clang__)
-#ifndef LIKELY
-#define LIKELY(x)   __builtin_expect(!!(x), 1)
-#endif
-
-#ifndef UNLIKELY
-#define UNLIKELY(x) __builtin_expect(!!(x), 0)
-#endif
-#else
-#define LIKELY(x)       (x)
-#define UNLIKELY(x)     (x)
-#endif
-
 // An assert-type mechanism.
 #ifdef PARANOIA
 #define I_Assert(e) ((e) ? (void)0 : I_Error("assert failed: %s, file %s, line %d", #e, __FILE__, __LINE__))
@@ -584,15 +571,21 @@ extern const char *compdate, *comptime, *comprevision, *compbranch;
 
 #ifndef NONET
 //-- SATURN __
+/// Enable gamestate resynching between Saturn servers and clients
+/// Like SRB2 and RR does
+/// Still highly experimental
+#ifdef DOSATURNSYNCH
+#define SATURNSYNCH
+
 /// Detect if a client is on Saturn in the clientconfig.
 /// To seperately allow them to join or block joining from vanilla clients.
 #ifdef DOSATURNJOIN
 #define SATURNJOIN
 #endif
+#endif
 
 /// Server detection for if a connecting client is on Saturn.
-/// This also enables gamestate resynching between Saturn servers and clients
-/// Like SRB2 and RR does
+/// For stuff like extra synching, etc.
 #ifdef DOSATURNPAK
 #define SATURNPAK
 #endif

src/doomstat.h

@@ -244,7 +244,7 @@ typedef struct
 	INT16 nextlevel;       ///< Map number of next level, or 1100-1102 to end.
 	char musname[7];       ///< Music track to play. "" for no music.
 	UINT16 mustrack;       ///< Subsong to play. Only really relevant for music modules and specific formats supported by GME. 0 to ignore.
-	UINT32 muspos;         ///< Music position to jump to.
+	UINT32 muspos;    ///< Music position to jump to.
 	char forcecharacter[17];  ///< (SKINNAMESIZE+1) Skin to switch to or "" to disable.
 	UINT8 weather;         ///< 0 = sunny day, 1 = storm, 2 = snow, 3 = rain, 4 = blank, 5 = thunder w/o rain, 6 = rain w/o lightning, 7 = heat wave.
 	INT16 skynum;          ///< Sky number to use.
@@ -276,7 +276,7 @@ typedef struct
 
 	// SRB2kart
 	//boolean automap;    ///< Displays a level's white map outline in modified games
-	fixed_t mobj_scale;   ///< Replacement for TOL_ERZ3
+	fixed_t mobj_scale; ///< Replacement for TOL_ERZ3
 
 	mapheader_lighting_t lighting;			///< Wall and sprite lighting
 	mapheader_lighting_t lighting_encore;	///< Alternative lighting for Encore mode
@@ -361,6 +361,9 @@ enum GameType // SRB2Kart
 // String names for gametypes
 extern const char *Gametype_Names[NUMGAMETYPES];
 
+extern tic_t totalplaytime;
+extern UINT32 matchesplayed;
+
 extern UINT8 stagefailed;
 
 // Emeralds stored as bits to throw savegame hackers off.
@@ -536,6 +539,18 @@ extern mapthing_t *playerstarts[MAXPLAYERS]; // Cooperative
 extern mapthing_t *bluectfstarts[MAXPLAYERS]; // CTF
 extern mapthing_t *redctfstarts[MAXPLAYERS]; // CTF
 
+#define WAYPOINTSEQUENCESIZE 256
+#define NUMWAYPOINTSEQUENCES 256
+extern mobj_t *waypoints[NUMWAYPOINTSEQUENCES][WAYPOINTSEQUENCESIZE];
+extern UINT16 numwaypoints[NUMWAYPOINTSEQUENCES];
+
+void P_AddWaypoint(UINT8 sequence, UINT8 id, mobj_t *waypoint);
+mobj_t *P_GetFirstWaypoint(UINT8 sequence);
+mobj_t *P_GetLastWaypoint(UINT8 sequence);
+mobj_t *P_GetPreviousWaypoint(mobj_t *current, boolean wrap);
+mobj_t *P_GetNextWaypoint(mobj_t *current, boolean wrap);
+mobj_t *P_GetClosestWaypoint(UINT8 sequence, mobj_t *mo);
+
 // =====================================
 // Internal parameters, used for engine.
 // =====================================
@@ -556,6 +571,9 @@ extern FILE *debugfile;
 extern INT32 debugload;
 #endif
 
+// if true, load all graphics at level load
+extern boolean precache;
+
 // wipegamestate can be set to -1
 //  to force a wipe on the next draw
 extern gamestate_t wipegamestate;

src/f_finale.c

@@ -149,7 +149,7 @@ static UINT8 F_WriteText(void)
 static void F_NewCutscene(const char *basetext)
 {
 	cutscene_basetext = basetext;
-	memset(cutscene_disptext, 0, sizeof(cutscene_disptext));
+	memset(cutscene_disptext,0,sizeof(cutscene_disptext));
 	cutscene_writeptr = cutscene_baseptr = 0;
 	cutscene_textspeed = 9;
 	cutscene_textcount = TICRATE/2;
@@ -164,14 +164,14 @@ static void F_SkyScroll(INT32 scrollspeed)
 	patch_t *pat, *pat2;
 	INT32 anim2 = 0;
 
-	pat = W_CachePatchName("TITLEBG1", PU_PATCH_LOWPRIORITY);
-	pat2 = W_CachePatchName("TITLEBG2", PU_PATCH_LOWPRIORITY);
+	pat = W_CachePatchName("TITLEBG1", PU_CACHE);
+	pat2 = W_CachePatchName("TITLEBG2", PU_CACHE);
 
 	w = (vid.width / vid.dupx)<<FRACBITS;
 
 	// The scroll offset MUST be clamped before shifting by FRACBITS, or else it'll overflow in about 3 minutes
-	animtimer = ((((finalecount * scrollspeed) % (pat->width*16))<<FRACBITS) + (R_GetMenuUncap() * scrollspeed))/16;
-	anim2 = (pat2->width<<FRACBITS) - ((((finalecount * scrollspeed) % (pat2->width*16))<<FRACBITS) + (R_GetMenuUncap() * scrollspeed))/16;
+	animtimer = ((((finalecount * scrollspeed) % (SHORT(pat->width)*16))<<FRACBITS) + (R_GetMenuUncap() * scrollspeed))/16;
+	anim2 = (SHORT(pat2->width)<<FRACBITS) - ((((finalecount * scrollspeed) % (SHORT(pat2->width)*16))<<FRACBITS) + (R_GetMenuUncap() * scrollspeed))/16;
 
 	// SRB2Kart: F_DrawPatchCol is over-engineered; recoded to be less shitty and error-prone
 	if (rendermode != render_none)
@@ -183,15 +183,15 @@ static void F_SkyScroll(INT32 scrollspeed)
 		while (x < w)
 		{
 			V_DrawFixedPatch(x, y, FRACUNIT, V_SNAPTOTOP|V_SNAPTOLEFT, pat, NULL);
-			x += pat->width<<FRACBITS;
+			x += SHORT(pat->width)<<FRACBITS;
 		}
 
 		x = -anim2;
-		y = (BASEVIDHEIGHT - pat2->height)<<FRACBITS;
+		y = (BASEVIDHEIGHT - SHORT(pat2->height))<<FRACBITS;
 		while (x < w)
 		{
 			V_DrawFixedPatch(x, y, FRACUNIT, V_SNAPTOBOTTOM|V_SNAPTOLEFT, pat2, NULL);
-			x += pat2->width<<FRACBITS;
+			x += SHORT(pat2->width)<<FRACBITS;
 		}
 	}
 
@@ -263,7 +263,7 @@ void F_IntroDrawer(void)
 	// DRAW A FULL PIC INSTEAD OF FLAT!
 	if (intro_scenenum == 0)
 	{
-		background = W_CachePatchName("KARTKREW", PU_PATCH_LOWPRIORITY);
+		background = W_CachePatchName("KARTKREW", PU_CACHE);
 		highres = true;
 	}
 
@@ -534,15 +534,8 @@ static const char *credits[] = {
 	"\"Sunflower\" aka \"AnimeSonic\"",
 	"\"Yuz\" aka \"Yuzler\"",
 	"\"Democrab\"",
-	"\"EXpand\"",
+	"\"Expand\" aka \"Maver\"",
 	"\"Nexit\"",
-	"\"Spee\"",
-	"\"Jin\"",
-	"\"riomccloud\"",
-	"\"chromaticpipe\"",
-	"\"Achii\"",
-	"\"Anonimus\"",
-	"\"scizor300\"",
 	"",
 	"\1Special Thanks",
 	"SEGA",
@@ -630,10 +623,10 @@ void F_CreditDrawer(void)
 	V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31);
 
 	// Draw background
-	V_DrawSciencePatch(0, 0 - FixedMul(32<<FRACBITS, FixedDiv(credbgtimer%TICRATE, TICRATE)), V_SNAPTOTOP, W_CachePatchName("CREDTILE", PU_PATCH_LOWPRIORITY), FRACUNIT);
+	V_DrawSciencePatch(0, 0 - FixedMul(32<<FRACBITS, FixedDiv(credbgtimer%TICRATE, TICRATE)), V_SNAPTOTOP, W_CachePatchName("CREDTILE", PU_CACHE), FRACUNIT);
 
-	V_DrawSciencePatch(0, 0 - FixedMul(40<<FRACBITS, FixedDiv(credbgtimer%(TICRATE/2), (TICRATE/2))), V_SNAPTOTOP, W_CachePatchName("CREDZIGZ", PU_PATCH_LOWPRIORITY), FRACUNIT);
-	V_DrawSciencePatch(320<<FRACBITS, 0 - FixedMul(40<<FRACBITS, FixedDiv(credbgtimer%(TICRATE/2), (TICRATE/2))), V_SNAPTOTOP|V_FLIP, W_CachePatchName("CREDZIGZ", PU_PATCH_LOWPRIORITY), FRACUNIT);
+	V_DrawSciencePatch(0, 0 - FixedMul(40<<FRACBITS, FixedDiv(credbgtimer%(TICRATE/2), (TICRATE/2))), V_SNAPTOTOP, W_CachePatchName("CREDZIGZ", PU_CACHE), FRACUNIT);
+	V_DrawSciencePatch(320<<FRACBITS, 0 - FixedMul(40<<FRACBITS, FixedDiv(credbgtimer%(TICRATE/2), (TICRATE/2))), V_SNAPTOTOP|V_FLIP, W_CachePatchName("CREDZIGZ", PU_CACHE), FRACUNIT);
 
 	// Draw pictures
 	for (i = 0; credits_pics[i].patch; i++)
@@ -647,7 +640,7 @@ void F_CreditDrawer(void)
 			sc = FRACUNIT; // quick hack so I don't have to add another field to credits_pics
 		}
 
-		V_DrawFixedPatch(credits_pics[i].x<<FRACBITS, (credits_pics[i].y<<FRACBITS) - 4*(animtimer<<FRACBITS)/5, sc, 0, W_CachePatchName(credits_pics[i].patch, PU_PATCH), colormap);
+		V_DrawFixedPatch(credits_pics[i].x<<FRACBITS, (credits_pics[i].y<<FRACBITS) - 4*(animtimer<<FRACBITS)/5, sc, 0, W_CachePatchName(credits_pics[i].patch, PU_CACHE), colormap);
 	}
 
 	// Dim the background
@@ -846,9 +839,9 @@ void F_GameEvaluationDrawer(void)
 
 		patchname[4] = 'A'+(char)i;
 		if (emeralds & (1<<i))
-			V_DrawScaledPatch(x, y, 0, W_CachePatchName(patchname, PU_PATCH_LOWPRIORITY));
+			V_DrawScaledPatch(x, y, 0, W_CachePatchName(patchname, PU_CACHE));
 		else
-			V_DrawTranslucentPatch(x, y, TRANSLEVEL, W_CachePatchName(patchname, PU_PATCH_LOWPRIORITY));
+			V_DrawTranslucentPatch(x, y, TRANSLEVEL, W_CachePatchName(patchname, PU_CACHE));
 
 		eemeralds_cur += INTERVAL;
 	}
@@ -864,6 +857,9 @@ void F_GameEvaluationDrawer(void)
 			if (ALL7EMERALDS(emeralds))
 				++timesBeatenWithEmeralds;
 
+			/*if (ultimatemode)
+				++timesBeatenUltimate;*/
+
 			if (M_UpdateUnlockablesAndExtraEmblems(false))
 				S_StartSound(NULL, sfx_ncitem);
 
@@ -874,10 +870,10 @@ void F_GameEvaluationDrawer(void)
 	if (finalecount >= 5*TICRATE)
 	{
 		if (drawemblem)
-			V_DrawScaledPatch(120, 192, 0, W_CachePatchName("NWNGA0", PU_PATCH_LOWPRIORITY));
+			V_DrawScaledPatch(120, 192, 0, W_CachePatchName("NWNGA0", PU_CACHE));
 
 		if (drawchaosemblem)
-			V_DrawScaledPatch(200, 192, 0, W_CachePatchName("NWNGA0", PU_PATCH_LOWPRIORITY));
+			V_DrawScaledPatch(200, 192, 0, W_CachePatchName("NWNGA0", PU_CACHE));
 
 		V_DrawString(8, 16, V_YELLOWMAP, "Unlocked:");
 
@@ -972,10 +968,10 @@ void F_StartTitleScreen(void)
 	demoDelayLeft = demoDelayTime;
 	demoIdleLeft = demoIdleTime;
 
-	ttbanner = W_CachePatchName("TTKBANNR", PU_PATCH_LOWPRIORITY);
-	ttkart = W_CachePatchName("TTKART", PU_PATCH_LOWPRIORITY);
-	ttcheckers = W_CachePatchName("TTCHECK", PU_PATCH_LOWPRIORITY);
-	ttkflash = W_CachePatchName("TTKFLASH", PU_PATCH_LOWPRIORITY);
+	ttbanner = W_CachePatchName("TTKBANNR", PU_LEVEL);
+	ttkart = W_CachePatchName("TTKART", PU_LEVEL);
+	ttcheckers = W_CachePatchName("TTCHECK", PU_LEVEL);
+	ttkflash = W_CachePatchName("TTKFLASH", PU_LEVEL);
 }
 
 // (no longer) De-Demo'd Title Screen
@@ -1010,7 +1006,7 @@ void F_TitleScreenDrawer(void)
 	else
 	{
 		INT32 transval = 0;
-
+		
 		if (finalecount <= (50+(9<<1)))
 			transval = (finalecount - 50)>>1;
 
@@ -1057,8 +1053,8 @@ void F_TitleScreenTicker(boolean run)
 		return;
 
 	// are demos disabled?
-	if (!cv_rollingdemos.value || modifiedgame) // occasionally mappacks supply invalid replays which means the game crashes almost always when you idle on the titlescreen too long
-		return;									// we check for all addons since added luas/socs and stuff like that makes them desynch like crazy so why would you even watch them?
+	if (!cv_rollingdemos.value)
+		return;
 
 	// Wait for a while (for the music to finish, preferably)
 	// before starting demos
@@ -1190,7 +1186,7 @@ void F_StartWaitingPlayers(void)
 	for (i = 0; i < 2; i++)
 	{
 		sprframe = &skins[randskin].spritedef.spriteframes[(6+(i*3)) & FF_FRAMEMASK];
-		driver[i] = W_CachePatchNum(sprframe->lumppat[1], PU_CACHE);
+		driver[i] = W_CachePatchNum(sprframe->lumppat[1], PU_LEVEL);
 	}
 }
 
@@ -1259,15 +1255,15 @@ void F_ContinueDrawer(void)
 		ncontinues = 20;
 
 	if (imcontinuing)
-		contsonic = W_CachePatchName("CONT2", PU_PATCH_LOWPRIORITY);
+		contsonic = W_CachePatchName("CONT2", PU_CACHE);
 	else
-		contsonic = W_CachePatchName("CONT1", PU_PATCH_LOWPRIORITY);
+		contsonic = W_CachePatchName("CONT1", PU_CACHE);
 
 	V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31);
 	V_DrawCenteredString(BASEVIDWIDTH/2, 100, 0, "CONTINUE?");
 
 	// Draw a Sonic!
-	V_DrawScaledPatch((BASEVIDWIDTH - contsonic->width)/2, 32, 0, contsonic);
+	V_DrawScaledPatch((BASEVIDWIDTH - SHORT(contsonic->width))/2, 32, 0, contsonic);
 
 	// Draw the continue markers! Show continues minus one.
 	x -= ncontinues * 6;
@@ -1486,10 +1482,10 @@ void F_CutsceneDrawer(void)
 	{
 		if (cutscenes[cutnum]->scene[scenenum].pichires[picnum])
 			V_DrawSmallScaledPatch(picxpos, picypos, 0,
-				W_CachePatchName(cutscenes[cutnum]->scene[scenenum].picname[picnum], PU_PATCH_LOWPRIORITY));
+				W_CachePatchName(cutscenes[cutnum]->scene[scenenum].picname[picnum], PU_CACHE));
 		else
 			V_DrawScaledPatch(picxpos,picypos, 0,
-				W_CachePatchName(cutscenes[cutnum]->scene[scenenum].picname[picnum], PU_PATCH_LOWPRIORITY));
+				W_CachePatchName(cutscenes[cutnum]->scene[scenenum].picname[picnum], PU_CACHE));
 	}
 
 	if (dofadenow && rendermode != render_none)

src/filesrch.c

@@ -661,10 +661,6 @@ boolean preparefilemenu(boolean samedepth, boolean replayhut)
 		return false;
 	}
 
-	if (dirmenu != coredirmenu)
-		Z_Free(dirmenu);
-	dirmenu = NULL;
-
 	for (; sizecoredirmenu > 0; sizecoredirmenu--) // clear out existing items
 	{
 		Z_Free(coredirmenu[sizecoredirmenu-1]);

src/g_game.h

@@ -42,7 +42,6 @@ extern savebuffer_t demobuf;
 
 // demoplaying back and demo recording
 extern consvar_t cv_recordmultiplayerdemos, cv_netdemosyncquality, cv_maxdemosize, cv_demochangemap;
-extern consvar_t cv_demodateformat;
 
 // Publicly-accessible demo vars
 struct demovars_s {
@@ -84,8 +83,6 @@ typedef struct menudemo_s {
 	menudemotype_e type;
 
 	char title[65]; // Null-terminated for string prints
-	char date[11]; // date when replay was recorded
-	char version[12]; // combined version and subversion
 	UINT16 map;
 	UINT8 addonstatus; // What do we need to do addon-wise to play this demo?
 	UINT8 gametype;
@@ -173,10 +170,8 @@ extern consvar_t cv_smallposnum;
 extern consvar_t cv_newspeedometer;
 
 extern consvar_t cv_saltyhop;
-extern consvar_t cv_saltyheight;
 extern consvar_t cv_saltyhopsfx;
 extern consvar_t cv_saltysquish;
-extern consvar_t cv_saltyroll;
 
 extern consvar_t cv_driftsparkpulse;
 extern consvar_t cv_gravstretch;
@@ -187,10 +182,6 @@ extern consvar_t cv_sloperolldist;
 extern consvar_t cv_sparkroll;
 extern consvar_t cv_spinoutroll;
 
-extern consvar_t cv_squishdance, cv_squishdancespeed;
-
-extern consvar_t cv_playerblendeffects;
-
 extern consvar_t cv_cechotoggle;
 
 #ifndef NONET

src/g_input.c

@@ -20,8 +20,6 @@
 #include "d_net.h"
 #include "console.h"
 
-#include "m_menu.h"
-
 #include "i_system.h"
 #include "i_video.h"
 #include "r_draw.h"
@@ -133,7 +131,10 @@ joy3xmove[JOYAXISSET], joy3ymove[JOYAXISSET], joy4xmove[JOYAXISSET], joy4ymove[J
 UINT8 gamekeydown[NUMINPUTS];
 
 // two key codes (or virtual key) per game control
-INT32 gamecontrol[MAXSPLITSCREENPLAYERS][num_gamecontrols][2];
+INT32 gamecontrol[num_gamecontrols][2];
+INT32 gamecontrolbis[num_gamecontrols][2]; // secondary splitscreen player
+INT32 gamecontrol3[num_gamecontrols][2]; // tertiary splitscreen player
+INT32 gamecontrol4[num_gamecontrols][2]; // quarternary splitscreen player
 
 typedef struct
 {
@@ -263,26 +264,6 @@ void G_MapEventsToControls(event_t *ev)
 	}
 }
 
-void G_ResetControls(void)
-{
-	memset(gamekeydown, 0, NUMINPUTS);
-
-	memset(joyxmove, 0, sizeof(joyxmove));
-	memset(joyymove, 0, sizeof(joyymove));
-
-	memset(joy2xmove, 0, sizeof(joy2xmove));
-	memset(joy2ymove, 0, sizeof(joy2ymove));
-
-	memset(joy3xmove, 0, sizeof(joy3xmove));
-	memset(joy3ymove, 0, sizeof(joy3ymove));
-
-	memset(joy4xmove, 0, sizeof(joy4xmove));
-	memset(joy4ymove, 0, sizeof(joy4ymove));
-
-	// reset those just in case the game missed the keyup event
-	memset(dpadscrollstate, false, sizeof(dpadscrollstate));
-}
-
 //
 // General double-click detection routine for any kind of input.
 //
@@ -996,14 +977,13 @@ void G_ClearControlKeys(INT32 (*setupcontrols)[2], INT32 control)
 
 void G_ClearAllControlKeys(void)
 {
-	INT32 i, k;
-
-	for (k = 0; k < MAXSPLITSCREENPLAYERS; k++)
+	INT32 i;
+	for (i = 0; i < num_gamecontrols; i++)
 	{
-		for (i = 0; i < num_gamecontrols; i++)
-		{
-			G_ClearControlKeys(gamecontrol[k], i);
-		}
+		G_ClearControlKeys(gamecontrol, i);
+		G_ClearControlKeys(gamecontrolbis, i);
+		G_ClearControlKeys(gamecontrol3, i);
+		G_ClearControlKeys(gamecontrol4, i);
 	}
 }
 
@@ -1042,7 +1022,7 @@ INT32 G_KeyStringtoNum(const char *keystr)
 	if (!keystr[0])
 		return 0;
 
-	if (!keystr[0] || (!keystr[1] && keystr[0] > ' ' && keystr[0] <= 'z'))
+	if (!keystr[1] && keystr[0] > ' ' && keystr[0] <= 'z')
 		return keystr[0];
 
 	if (!strncmp(keystr, "KEY", 3) && keystr[3] >= '0' && keystr[3] <= '9')
@@ -1061,131 +1041,158 @@ void G_Controldefault(UINT8 player)
 	if (player == 0 || player == 1)
 	{
 		// Main controls
-		gamecontrol[0][gc_aimforward ][0] = KEY_UPARROW;
-		gamecontrol[0][gc_aimbackward][0] = KEY_DOWNARROW;
-		gamecontrol[0][gc_turnleft   ][0] = KEY_LEFTARROW;
-		gamecontrol[0][gc_turnright  ][0] = KEY_RIGHTARROW;
-		gamecontrol[0][gc_accelerate ][0] = 'a';
-		gamecontrol[0][gc_drift      ][0] = 's';
-		gamecontrol[0][gc_brake      ][0] = 'd';
-		gamecontrol[0][gc_fire       ][0] = KEY_SPACE;
-		gamecontrol[0][gc_lookback   ][0] = KEY_LSHIFT;
+		gamecontrol[gc_aimforward ][0] = KEY_UPARROW;
+		gamecontrol[gc_aimbackward][0] = KEY_DOWNARROW;
+		gamecontrol[gc_turnleft   ][0] = KEY_LEFTARROW;
+		gamecontrol[gc_turnright  ][0] = KEY_RIGHTARROW;
+		gamecontrol[gc_accelerate ][0] = 'a';
+		gamecontrol[gc_drift      ][0] = 's';
+		gamecontrol[gc_brake      ][0] = 'd';
+		gamecontrol[gc_fire       ][0] = KEY_SPACE;
+		gamecontrol[gc_lookback   ][0] = KEY_LSHIFT;
 
-		gamecontrol[0][gc_accelerate ][1] = KEY_JOY1+0; // A
-		gamecontrol[0][gc_lookback   ][1] = KEY_JOY1+2; // X
-		gamecontrol[0][gc_brake      ][1] = KEY_JOY1+1; // B
-		gamecontrol[0][gc_fire       ][1] = KEY_JOY1+9; // LB
-		gamecontrol[0][gc_drift      ][1] = KEY_JOY1+10; // RB
+		gamecontrol[gc_accelerate ][1] = KEY_JOY1+0; // A
+		gamecontrol[gc_lookback   ][1] = KEY_JOY1+2; // X
+		gamecontrol[gc_brake      ][1] = KEY_JOY1+1; // B
+		gamecontrol[gc_fire       ][1] = KEY_JOY1+9; // LB
+		gamecontrol[gc_drift      ][1] = KEY_JOY1+10; // RB
 
 		// Extra controls
-		gamecontrol[0][gc_pause      ][0] = KEY_PAUSE;
-		gamecontrol[0][gc_console    ][0] = KEY_CONSOLE;
-		gamecontrol[0][gc_screenshot ][0] = KEY_F8;
-		gamecontrol[0][gc_recordgif  ][0] = KEY_F9;
-		gamecontrol[0][gc_viewpoint  ][0] = KEY_F12;
-		gamecontrol[0][gc_talkkey    ][0] = 't';
+		gamecontrol[gc_pause      ][0] = KEY_PAUSE;
+		gamecontrol[gc_console    ][0] = KEY_CONSOLE;
+		gamecontrol[gc_screenshot ][0] = KEY_F8;
+		gamecontrol[gc_recordgif  ][0] = KEY_F9;
+		gamecontrol[gc_viewpoint  ][0] = KEY_F12;
+		gamecontrol[gc_talkkey    ][0] = 't';
 		//gamecontrol[gc_teamkey    ][0] = 'y';
-		gamecontrol[0][gc_scores     ][0] = KEY_TAB;
-		gamecontrol[0][gc_spectate   ][0] = '\'';
-		gamecontrol[0][gc_lookup     ][0] = KEY_PGUP;
-		gamecontrol[0][gc_lookdown   ][0] = KEY_PGDN;
-		gamecontrol[0][gc_centerview ][0] = KEY_END;
-		gamecontrol[0][gc_camreset   ][0] = KEY_HOME;
-		gamecontrol[0][gc_camtoggle  ][0] = KEY_BACKSPACE;
+		gamecontrol[gc_scores     ][0] = KEY_TAB;
+		gamecontrol[gc_spectate   ][0] = '\'';
+		gamecontrol[gc_lookup     ][0] = KEY_PGUP;
+		gamecontrol[gc_lookdown   ][0] = KEY_PGDN;
+		gamecontrol[gc_centerview ][0] = KEY_END;
+		gamecontrol[gc_camreset   ][0] = KEY_HOME;
+		gamecontrol[gc_camtoggle  ][0] = KEY_BACKSPACE;
 
-		gamecontrol[0][gc_viewpoint  ][1] = KEY_JOY1+3; // Y
-		gamecontrol[0][gc_pause      ][1] = KEY_JOY1+4; // Back
-		gamecontrol[0][gc_systemmenu ][0] = KEY_JOY1+6; // Start
-		//gamecontrol[0][gc_camtoggle  ][1] = KEY_HAT1+0; // D-Pad Up
-		//gamecontrol[0][gc_screenshot ][1] = KEY_HAT1+1; // D-Pad Down // absolutely fucking NOT
-		gamecontrol[0][gc_talkkey    ][1] = KEY_HAT1+1; // D-Pad Down
-		gamecontrol[0][gc_scores     ][1] = KEY_HAT1+0; // D-Pad Up
+		gamecontrol[gc_viewpoint  ][1] = KEY_JOY1+3; // Y
+		gamecontrol[gc_pause      ][1] = KEY_JOY1+4; // Back
+		gamecontrol[gc_systemmenu ][0] = KEY_JOY1+6; // Start
+		//gamecontrol[gc_camtoggle  ][1] = KEY_HAT1+0; // D-Pad Up
+		//gamecontrol[gc_screenshot ][1] = KEY_HAT1+1; // D-Pad Down // absolutely fucking NOT
+		gamecontrol[gc_talkkey    ][1] = KEY_HAT1+1; // D-Pad Down
+		gamecontrol[gc_scores     ][1] = KEY_HAT1+0; // D-Pad Up
 	}
 
 	if (player == 0 || player == 2)
 	{
 		// Player 2 controls
-		gamecontrol[1][gc_accelerate ][0] = KEY_2JOY1+0; // A
-		gamecontrol[1][gc_lookback   ][0] = KEY_2JOY1+2; // X
-		gamecontrol[1][gc_brake      ][0] = KEY_2JOY1+1; // B
-		gamecontrol[1][gc_fire       ][0] = KEY_2JOY1+9; // LB
-		gamecontrol[1][gc_drift      ][0] = KEY_2JOY1+10; // RB
+		gamecontrolbis[gc_accelerate ][0] = KEY_2JOY1+0; // A
+		gamecontrolbis[gc_lookback   ][0] = KEY_2JOY1+2; // X
+		gamecontrolbis[gc_brake      ][0] = KEY_2JOY1+1; // B
+		gamecontrolbis[gc_fire       ][0] = KEY_2JOY1+9; // LB
+		gamecontrolbis[gc_drift      ][0] = KEY_2JOY1+10; // RB
 	}
 
 	if (player == 0 || player == 3)
 	{
 		// Player 3 controls
-		gamecontrol[2][gc_accelerate ][0] = KEY_3JOY1+0; // A
-		gamecontrol[2][gc_lookback   ][0] = KEY_3JOY1+2; // X
-		gamecontrol[2][gc_brake      ][0] = KEY_3JOY1+1; // B
-		gamecontrol[2][gc_fire       ][0] = KEY_3JOY1+9; // LB
-		gamecontrol[2][gc_drift      ][0] = KEY_3JOY1+10; // RB
+		gamecontrol3[gc_accelerate ][0] = KEY_3JOY1+0; // A
+		gamecontrol3[gc_lookback   ][0] = KEY_3JOY1+2; // X
+		gamecontrol3[gc_brake      ][0] = KEY_3JOY1+1; // B
+		gamecontrol3[gc_fire       ][0] = KEY_3JOY1+9; // LB
+		gamecontrol3[gc_drift      ][0] = KEY_3JOY1+10; // RB
 	}
 
 	if (player == 0 || player == 4)
 	{
 		// Player 4 controls
-		gamecontrol[3][gc_accelerate ][0] = KEY_4JOY1+0; // A
-		gamecontrol[3][gc_lookback   ][0] = KEY_4JOY1+2; // X
-		gamecontrol[3][gc_brake      ][0] = KEY_4JOY1+1; // B
-		gamecontrol[3][gc_fire       ][0] = KEY_4JOY1+9; // LB
-		gamecontrol[3][gc_drift      ][0] = KEY_4JOY1+10; // RB
+		gamecontrol4[gc_accelerate ][0] = KEY_4JOY1+0; // A
+		gamecontrol4[gc_lookback   ][0] = KEY_4JOY1+2; // X
+		gamecontrol4[gc_brake      ][0] = KEY_4JOY1+1; // B
+		gamecontrol4[gc_fire       ][0] = KEY_4JOY1+9; // LB
+		gamecontrol4[gc_drift      ][0] = KEY_4JOY1+10; // RB
 	}
 }
 
 void G_SaveKeySetting(FILE *f)
 {
-	INT32 i, k;
+	INT32 i;
 
-	static const char *controltext[MAXSPLITSCREENPLAYERS] = {
-		"setcontrol",
-		"setcontrol2",
-		"setcontrol3",
-		"setcontrol4"
-	};
-
-	for (k = 0; k < MAXSPLITSCREENPLAYERS; k++)
+	for (i = 1; i < num_gamecontrols; i++)
 	{
-		for (i = 1; i < num_gamecontrols; i++)
-		{
-			fprintf(f, "%s \"%s\" \"%s\"", controltext[k], gamecontrolname[i],
-					G_KeynumToString(gamecontrol[k][i][0]));
+		fprintf(f, "setcontrol \"%s\" \"%s\"", gamecontrolname[i],
+			G_KeynumToString(gamecontrol[i][0]));
 
-			if (gamecontrol[k][i][1])
-				fprintf(f, " \"%s\"\n", G_KeynumToString(gamecontrol[k][i][1]));
-			else
-				fprintf(f, "\n");
-		}
+		if (gamecontrol[i][1])
+			fprintf(f, " \"%s\"\n", G_KeynumToString(gamecontrol[i][1]));
+		else
+			fprintf(f, "\n");
+	}
+
+	for (i = 1; i < num_gamecontrols; i++)
+	{
+		fprintf(f, "setcontrol2 \"%s\" \"%s\"", gamecontrolname[i],
+			G_KeynumToString(gamecontrolbis[i][0]));
+
+		if (gamecontrolbis[i][1])
+			fprintf(f, " \"%s\"\n", G_KeynumToString(gamecontrolbis[i][1]));
+		else
+			fprintf(f, "\n");
+	}
+
+	for (i = 1; i < num_gamecontrols; i++)
+	{
+		fprintf(f, "setcontrol3 \"%s\" \"%s\"", gamecontrolname[i],
+			G_KeynumToString(gamecontrol3[i][0]));
+
+		if (gamecontrol3[i][1])
+			fprintf(f, " \"%s\"\n", G_KeynumToString(gamecontrol3[i][1]));
+		else
+			fprintf(f, "\n");
+	}
+
+	for (i = 1; i < num_gamecontrols; i++)
+	{
+		fprintf(f, "setcontrol4 \"%s\" \"%s\"", gamecontrolname[i],
+			G_KeynumToString(gamecontrol4[i][0]));
+
+		if (gamecontrol4[i][1])
+			fprintf(f, " \"%s\"\n", G_KeynumToString(gamecontrol4[i][1]));
+		else
+			fprintf(f, "\n");
 	}
 }
 
 INT32 G_CheckDoubleUsage(INT32 keynum, boolean modify)
 {
 	INT32 result = gc_null;
-
 	if (cv_controlperkey.value == 1)
 	{
-		INT32 i, j, k;
-
-		for (k = 0; k < MAXSPLITSCREENPLAYERS; k++)
+		INT32 i, j;
+		for (i = 0; i < num_gamecontrols; i++)
 		{
-			for (i = 0; i < num_gamecontrols; i++)
+			for (j = 0; j < 2; j++)
 			{
-				for (j = 0; j < 2; j++)
-				{
-					if (gamecontrol[k][i][j] == keynum)
-					{
-						result = i;
-						if (modify) gamecontrol[k][i][j] = KEY_NULL;
-					}
-
-					if (result && !modify)
-						return result;
+				if (gamecontrol[i][j] == keynum) {
+					result = i;
+					if (modify) gamecontrol[i][j] = KEY_NULL;
 				}
+				if (gamecontrolbis[i][j] == keynum) {
+					result = i;
+					if (modify) gamecontrolbis[i][j] = KEY_NULL;
+				}
+				if (gamecontrol3[i][j] == keynum) {
+					result = i;
+					if (modify) gamecontrol3[i][j] = KEY_NULL;
+				}
+				if (gamecontrol4[i][j] == keynum) {
+					result = i;
+					if (modify) gamecontrol4[i][j] = KEY_NULL;
+				}
+				if (result && !modify)
+					return result;
 			}
 		}
 	}
-
 	return result;
 }
 
@@ -1339,11 +1346,11 @@ static void setcontrol(INT32 (*gc)[2])
 	INT32 player;
 	boolean nestedoverride = false;
 
-	if ((void*)gc == (void*)&gamecontrol[3])
+	if ((void*)gc == (void*)&gamecontrol4)
 		player = 3;
-	else if ((void*)gc == (void*)&gamecontrol[2])
+	else if ((void*)gc == (void*)&gamecontrol3)
 		player = 2;
-	else if ((void*)gc == (void*)&gamecontrol[1])
+	else if ((void*)gc == (void*)&gamecontrolbis)
 		player = 1;
 	else
 		player = 0;
@@ -1406,7 +1413,7 @@ void Command_Setcontrol_f(void)
 		return;
 	}
 
-	setcontrol(gamecontrol[0]);
+	setcontrol(gamecontrol);
 }
 
 void Command_Setcontrol2_f(void)
@@ -1421,7 +1428,7 @@ void Command_Setcontrol2_f(void)
 		return;
 	}
 
-	setcontrol(gamecontrol[1]);
+	setcontrol(gamecontrolbis);
 }
 
 void Command_Setcontrol3_f(void)
@@ -1436,7 +1443,7 @@ void Command_Setcontrol3_f(void)
 		return;
 	}
 
-	setcontrol(gamecontrol[2]);
+	setcontrol(gamecontrol3);
 }
 
 void Command_Setcontrol4_f(void)
@@ -1451,5 +1458,5 @@ void Command_Setcontrol4_f(void)
 		return;
 	}
 
-	setcontrol(gamecontrol[3]);
+	setcontrol(gamecontrol4);
 }

src/g_input.h

@@ -121,12 +121,14 @@ extern INT32 joyxmove[JOYAXISSET], joyymove[JOYAXISSET], joy2xmove[JOYAXISSET],
 extern UINT8 gamekeydown[NUMINPUTS];
 
 // two key codes (or virtual key) per game control
-extern INT32 gamecontrol[MAXSPLITSCREENPLAYERS][num_gamecontrols][2];
-
-#define PLAYER1INPUTDOWN(gc) (gamekeydown[gamecontrol[0][gc][0]] || gamekeydown[gamecontrol[0][gc][1]])
-#define PLAYER2INPUTDOWN(gc) (gamekeydown[gamecontrol[1][gc][0]] || gamekeydown[gamecontrol[1][gc][1]])
-#define PLAYER3INPUTDOWN(gc) (gamekeydown[gamecontrol[2][gc][0]] || gamekeydown[gamecontrol[2][gc][1]])
-#define PLAYER4INPUTDOWN(gc) (gamekeydown[gamecontrol[3][gc][0]] || gamekeydown[gamecontrol[3][gc][1]])
+extern INT32 gamecontrol[num_gamecontrols][2];
+extern INT32 gamecontrolbis[num_gamecontrols][2]; // secondary splitscreen player
+extern INT32 gamecontrol3[num_gamecontrols][2];
+extern INT32 gamecontrol4[num_gamecontrols][2];
+#define PLAYER1INPUTDOWN(gc) (gamekeydown[gamecontrol[gc][0]] || gamekeydown[gamecontrol[gc][1]])
+#define PLAYER2INPUTDOWN(gc) (gamekeydown[gamecontrolbis[gc][0]] || gamekeydown[gamecontrolbis[gc][1]])
+#define PLAYER3INPUTDOWN(gc) (gamekeydown[gamecontrol3[gc][0]] || gamekeydown[gamecontrol3[gc][1]])
+#define PLAYER4INPUTDOWN(gc) (gamekeydown[gamecontrol4[gc][0]] || gamekeydown[gamecontrol4[gc][1]])
 
 // peace to my little coder fingers!
 // check a gamecontrol being active or not
@@ -138,7 +140,6 @@ void G_PlayerDeviceRumble(INT32 playernum, UINT16 low_strength, UINT16 high_stre
 
 // remaps the input event to a game control.
 void G_MapEventsToControls(event_t *ev);
-void G_ResetControls(void);
 
 // returns the name of a key
 const char *G_KeynumToString(INT32 keynum);

src/hardware/hw_bsp.c

@@ -369,7 +369,7 @@ static poly_t *CutOutSubsecPoly(seg_t *lseg, INT32 count, poly_t *poly)
 	{
 		//x,y,dx,dy (like a divline)
 		line_t *line = lseg->linedef;
-
+		
 		// portal check
 		if (!gl_maphasportals && line->special == 40 && lseg->side == 0)
 		{
@@ -380,7 +380,7 @@ static poly_t *CutOutSubsecPoly(seg_t *lseg, INT32 count, poly_t *poly)
 			if (line2 >= 0) // found it!
 				gl_maphasportals = 1;
 		}
-
+		
 		p1.x = FIXED_TO_FLOAT(lseg->side ? line->v2->x : line->v1->x);
 		p1.y = FIXED_TO_FLOAT(lseg->side ? line->v2->y : line->v1->y);
 		p2.x = FIXED_TO_FLOAT(lseg->side ? line->v1->x : line->v2->x);
@@ -523,7 +523,7 @@ static void loading_status(void)
 	x = BASEVIDWIDTH/2;
 	y = BASEVIDHEIGHT/2;
 	V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31); // Black background to match fade in effect
-	//V_DrawPatchFill(W_CachePatchName("SRB2BACK", PU_PATCH)); // SRB2 background, ehhh too bright.
+	//V_DrawPatchFill(W_CachePatchName("SRB2BACK",PU_CACHE)); // SRB2 background, ehhh too bright.
 	M_DrawTextBox(x-58, y-8, 13, 1);
 	V_DrawString(x-50, y, V_YELLOWMAP, "Loading...");
 	V_DrawRightAlignedString(x+50, y, V_YELLOWMAP, s);

src/hardware/hw_cache.c

@@ -28,10 +28,7 @@
 #include "../v_video.h"
 #include "../r_draw.h"
 #include "../r_main.h"
-#include "../r_patch.h"
-#include "../p_setup.h" // levelflats
-#include "../p_spec.h" // anim_t
-#include "../r_sky.h"
+#include "../r_patch.h"    // patch rotation
 
 INT32 patchformat = GL_TEXFMT_AP_88; // use alpha for holes
 INT32 textureformat = GL_TEXFMT_P_8; // use chromakey for hole
@@ -77,6 +74,9 @@ static void HWR_DrawColumnInCache(const column_t *patchcol, UINT8 *block, GLMipm
 
 	(void)patchheight; // This parameter is unused
 
+	if (!mipmap)
+		return;
+
 	if (originPatch) // originPatch can be NULL here, unlike in the software version
 		originy = originPatch->originy;
 
@@ -98,7 +98,10 @@ static void HWR_DrawColumnInCache(const column_t *patchcol, UINT8 *block, GLMipm
 			position = 0;
 		}
 
-		position = max(((position * scale_y) + (FRACUNIT/2)) >> FRACBITS, 0);
+		position = ((position * scale_y) + (FRACUNIT/2)) >> FRACBITS;
+
+		if (position < 0)
+			position = 0;
 
 		if (position + count >= pblockheight)
 			count = pblockheight - position;
@@ -112,12 +115,12 @@ static void HWR_DrawColumnInCache(const column_t *patchcol, UINT8 *block, GLMipm
 			alpha = 0xFF;
 
 			// Make pixel transparent if chroma keyed
-			if ((mipmap->flags & TF_CHROMAKEYED) && (texel == HWR_PATCHES_CHROMAKEY_COLORINDEX))
+			if ((mipmap && mipmap->flags & TF_CHROMAKEYED) && (texel == HWR_PATCHES_CHROMAKEY_COLORINDEX))
 				alpha = 0x00;
 
 			//Hurdler: 25/04/2000: now support colormap in hardware mode
-			if (mipmap->colormap)
-				texel = mipmap->colormap->data[texel];
+			if (mipmap && mipmap->colormap)
+				texel = mipmap->colormap[texel];
 
 			// hope compiler will get this switch out of the loops (dreams...)
 			// gcc do it ! but vcc not ! (why don't use cygwin gcc for win32 ?)
@@ -191,7 +194,7 @@ static void HWR_DrawPatchInCache(GLMipmap_t *mipmap,
 	// Draw each column to the block cache
 	for (; ncols--; block += bpp, xfrac += xfracstep)
 	{
-		patchcol = (const column_t *)((const UINT8 *)realpatch->columns + (realpatch->columnofs[xfrac>>FRACBITS]));
+		patchcol = (const column_t *)((const UINT8 *)realpatch + LONG(realpatch->columnofs[xfrac>>FRACBITS]));
 
 		HWR_DrawColumnInCache(patchcol, block, mipmap,
 								pblockheight, blockmodulo,
@@ -205,7 +208,7 @@ static void HWR_DrawPatchInCache(GLMipmap_t *mipmap,
 static void HWR_DrawTexturePatchInCache(GLMipmap_t *mipmap,
 	INT32 pblockwidth, INT32 pblockheight,
 	texture_t *texture, texpatch_t *patch,
-	const softwarepatch_t *realpatch)
+	const patch_t *realpatch)
 {
 	INT32 x, x1, x2;
 	INT32 col, ncols;
@@ -313,50 +316,52 @@ static void HWR_GenerateTexture(INT32 texnum, GLMapTexture_t *gltex, boolean noe
 	UINT8 *block;
 	texture_t *texture;
 	texpatch_t *patch;
-	softwarepatch_t *realpatch;
-	UINT8 *pdata;
+	patch_t *realpatch;
 	INT32 blockwidth, blockheight, blocksize;
 
-	UINT8 *colormap = colormaps;
-
 	INT32 i, idx;
-	boolean skyspecial = false; // poor hack for Legacy large skies..
+	boolean skyspecial = false; //poor hack for Legacy large skies..
 
 	RGBA_t *palette;
 	palette = HWR_GetTexturePalette();
 
 	texture = textures[texnum];
 
-	gltex->mipmap.flags = TF_CHROMAKEYED | TF_WRAPXY;
-	gltex->mipmap.format = textureformat;
-
 	// hack the Legacy skies..
-	if (UNLIKELY(strncmp(texture->name, "SKY", 3) == 0 &&
-		(texture->name[4] == 0 || texture->name[5] == 0)))
+	if (texture->name[0] == 'S' &&
+	    texture->name[1] == 'K' &&
+	    texture->name[2] == 'Y' &&
+	    (texture->name[4] == 0 ||
+	     texture->name[5] == 0)
+	   )
 	{
 		skyspecial = true;
-		gltex->mipmap.flags &= ~TF_CHROMAKEYED; // don't use the chromakey for sky
-		gltex->mipmap.format = GL_TEXFMT_RGBA; // that skyspecial code below assumes this format ...
+		gltex->mipmap.flags = TF_WRAPXY; // don't use the chromakey for sky
 	}
+	else
+		gltex->mipmap.flags = TF_CHROMAKEYED | TF_WRAPXY;
 
 	gltex->mipmap.width = (UINT16)(texture->width);
 	gltex->mipmap.height = (UINT16)(texture->height);
 
+	if (skyspecial)
+		gltex->mipmap.format = GL_TEXFMT_RGBA; // that skyspecial code below assumes this format ...
+	else
+		gltex->mipmap.format = textureformat;
+
+	gltex->mipmap.colormap = colormaps;
+
 #ifdef GLENCORE
 	if (encoremap && !noencore)
-		colormap += COLORMAP_REMAPOFFSET;
+		gltex->mipmap.colormap += COLORMAP_REMAPOFFSET;
 #endif
 
-	gltex->mipmap.colormap = Z_Calloc(sizeof(*gltex->mipmap.colormap), PU_HWRPATCHCOLMIPMAP, NULL);
-	gltex->mipmap.colormap->source = colormap;
-	M_Memcpy(gltex->mipmap.colormap->data, colormap, 256 * sizeof(UINT8));
-
 	blockwidth = texture->width;
 	blockheight = texture->height;
 	blocksize = (blockwidth * blockheight);
 	block = MakeBlock(&gltex->mipmap);
 
-	if (UNLIKELY(skyspecial)) // Hurdler: not efficient, but better than holes in the sky (and it's done only at level loading)
+	if (skyspecial) //Hurdler: not efficient, but better than holes in the sky (and it's done only at level loading)
 	{
 		INT32 j;
 		RGBA_t col;
@@ -378,10 +383,12 @@ static void HWR_GenerateTexture(INT32 texnum, GLMapTexture_t *gltex, boolean noe
 	// Composite the columns together.
 	for (i = 0, patch = texture->patches; i < texture->patchcount; i++, patch++)
 	{
-		pdata = W_CacheLumpNumPwad(patch->wad, patch->lump, PU_LEVEL);
-		realpatch = (softwarepatch_t *)pdata;
-
-		HWR_DrawTexturePatchInCache(&gltex->mipmap, blockwidth, blockheight, texture, patch, realpatch);
+		realpatch = W_CacheLumpNumPwad(patch->wad, patch->lump, PU_CACHE);
+		if (realpatch != NULL)
+		{
+			HWR_DrawTexturePatchInCache(&gltex->mipmap, blockwidth, blockheight, texture, patch, realpatch);
+			Z_ChangeTag(realpatch, PU_HWRCACHE_UNLOCKED);
+		}
 	}
 
 	//Hurdler: not efficient at all but I don't remember exactly how HWR_DrawPatchInCache works :(
@@ -402,13 +409,32 @@ static void HWR_GenerateTexture(INT32 texnum, GLMapTexture_t *gltex, boolean noe
 }
 
 // patch may be NULL if glMipmap has been initialised already and makebitmap is false
-void HWR_MakePatch(const patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipmap, boolean makebitmap)
+void HWR_MakePatch (patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipmap, boolean makebitmap)
 {
+	if (glMipmap == NULL)
+		return;
+
+	if (patch == NULL || glPatch == NULL)
+	{
+		Z_Free(glMipmap->data);
+		glMipmap->data = NULL;
+		return;
+	}
+
+	// don't do it twice (like a cache)
 	if (glMipmap->width == 0)
 	{
+		// save the original patch header so that the GLPatch can be casted
+		// into a standard patch_t struct and the existing code can get the
+		// orginal patch dimensions and offsets.
+		glPatch->width = SHORT(patch->width);
+		glPatch->height = SHORT(patch->height);
+		glPatch->leftoffset = SHORT(patch->leftoffset);
+		glPatch->topoffset = SHORT(patch->topoffset);
+
 		glMipmap->width = glMipmap->height = 1;
-		while (glMipmap->width < patch->width) glMipmap->width <<= 1;
-		while (glMipmap->height < patch->height) glMipmap->height <<= 1;
+		while (glMipmap->width < glPatch->width) glMipmap->width <<= 1;
+		while (glMipmap->height < glPatch->height) glMipmap->height <<= 1;
 
 		// no wrap around, no chroma key
 		glMipmap->flags = 0;
@@ -416,8 +442,9 @@ void HWR_MakePatch(const patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipma
 		// setup the texture info
 		glMipmap->format = patchformat;
 
-		glPatch->max_s = (float)patch->width / (float)glMipmap->width;
-		glPatch->max_t = (float)patch->height / (float)glMipmap->height;
+		//glPatch->max_s = glPatch->max_t = 1.0f;
+		glPatch->max_s = (float)glPatch->width / (float)glMipmap->width;
+		glPatch->max_t = (float)glPatch->height / (float)glMipmap->height;
 	}
 
 	Z_Free(glMipmap->data);
@@ -429,7 +456,7 @@ void HWR_MakePatch(const patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipma
 
 		HWR_DrawPatchInCache(glMipmap,
 			glMipmap->width, glMipmap->height,
-			patch->width, patch->height,
+			glPatch->width, glPatch->height,
 			patch);
 	}
 }
@@ -438,57 +465,22 @@ void HWR_MakePatch(const patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipma
 //             CACHING HANDLING
 // =================================================
 
-static size_t gl_numtextures = 0; // Texture count
+static size_t gl_numtextures;
 static GLMapTexture_t *gl_textures; // For all textures
 
-void HWR_FreeTextureData(patch_t *patch)
+void HWR_InitTextureCache(void)
 {
-	GLPatch_t *glPatch;
-
-	if (!patch || !patch->hardware)
-		return;
-
-	glPatch = patch->hardware;
-
-	if (vid.glstate == VID_GL_LIBRARY_LOADED)
-		GL_DeleteTexture(glPatch->mipmap);
-	if (glPatch->mipmap->data)
-		Z_Free(glPatch->mipmap->data);
+	gl_numtextures = 0;
+	gl_textures = NULL;
 }
 
-void HWR_FreeTexture(patch_t *patch)
+// Callback function for HWR_FreeTextureCache.
+static void FreeMipmapColormap(INT32 patchnum, void *patch)
 {
-	if (!patch)
-		return;
-
-	if (patch->hardware)
-	{
-		GLPatch_t *glPatch = patch->hardware;
-
-		HWR_FreeTextureColormaps(patch);
-
-		if (glPatch->mipmap)
-		{
-			HWR_FreeTextureData(patch);
-			Z_Free(glPatch->mipmap);
-		}
-
-		Z_Free(patch->hardware);
-	}
-
-	patch->hardware = NULL;
-}
-
-// Called by HWR_FreePatchCache.
-void HWR_FreeTextureColormaps(patch_t *patch)
-{
-	GLPatch_t *pat;
+	GLPatch_t* const pat = patch;
+	(void)patchnum; //unused
 
 	// The patch must be valid, obviously
-	if (!patch)
-		return;
-
-	pat = patch->hardware;
 	if (!pat)
 		return;
 
@@ -510,15 +502,15 @@ void HWR_FreeTextureColormaps(patch_t *patch)
 
 		// Set the first colormap to the one that comes after it.
 		next = pat->mipmap->nextcolormap;
+		if (!next)
+			break;
+
 		pat->mipmap->nextcolormap = next->nextcolormap;
 
 		// Free image data from memory.
 		if (next->data)
 			Z_Free(next->data);
-		if (next->colormap)
-			Z_Free(next->colormap);
 		next->data = NULL;
-		next->colormap = NULL;
 		GL_DeleteTexture(next);
 
 		// Free the old colormap mipmap from memory.
@@ -526,70 +518,28 @@ void HWR_FreeTextureColormaps(patch_t *patch)
 	}
 }
 
-static boolean FreeTextureCallback(void *mem)
-{
-	patch_t *patch = (patch_t *)mem;
-	HWR_FreeTexture(patch);
-	return false;
-}
-
-static boolean FreeColormapsCallback(void *mem)
-{
-	patch_t *patch = (patch_t *)mem;
-	HWR_FreeTextureColormaps(patch);
-	return false;
-}
-
-static void HWR_FreePatchCache(boolean freeall)
-{
-	boolean (*callback)(void *mem) = FreeTextureCallback;
-
-	if (!freeall)
-		callback = FreeColormapsCallback;
-
-	//Z_IterateTags(PU_PATCH, PU_PATCH_ROTATED, callback);
-	Z_IterateTags(PU_PATCH, PU_PATCH, callback);
-	Z_IterateTags(PU_SPRITE, PU_HUDGFX, callback);
-}
-
-// free all textures after each level
-void HWR_ClearAllTextures(void)
+void HWR_FreeMipmapCache(void)
 {
+	INT32 i;
 	// free references to the textures
 	GL_ClearMipMapCache();
-	HWR_FreePatchCache(true);
+
+	// free all hardware-converted graphics cached in the heap
+	// our gool is only the textures since user of the texture is the texture cache
+	Z_FreeTags(PU_HWRCACHE, PU_HWRCACHE);
+	Z_FreeTags(PU_HWRCACHE_UNLOCKED, PU_HWRCACHE_UNLOCKED);
+
+	// Alam: free the Z_Blocks before freeing it's users
+
+	// free all patch colormaps after each level: must be done after ClearMipMapCache!
+	for (i = 0; i < numwadfiles; i++)
+		M_AATreeIterate(wadfiles[i]->hwrcache, FreeMipmapColormap);
 }
 
-void HWR_FreeColormapCache(void)
+void HWR_FreeTextureCache(void)
 {
-	HWR_FreePatchCache(false);
-}
-
-void HWR_InitMapTextures(void)
-{
-	gl_textures = NULL;
-}
-
-static void FreeMapTexture(GLMapTexture_t *tex)
-{
-	GL_DeleteTexture(&tex->mipmap);
-	if (tex->mipmap.data)
-		Z_Free(tex->mipmap.data);
-	tex->mipmap.data = NULL;
-}
-
-void HWR_FreeMapTextures(void)
-{
-	size_t i;
-
-#ifdef GLENCORE
-	for (i = 0; i < gl_numtextures*2; i++)
-#else
-	for (i = 0; i < gl_numtextures; i++)
-#endif
-	{
-		FreeMapTexture(&gl_textures[i]);
-	}
+	// free references to the textures
+	HWR_FreeMipmapCache();
 
 	// now the heap don't have any 'user' pointing to our
 	// texturecache info, we can free it
@@ -599,273 +549,19 @@ void HWR_FreeMapTextures(void)
 	gl_numtextures = 0;
 }
 
-static void HWR_PrecacheLevelFlats(void)
+void HWR_LoadTextures(size_t pnumtextures)
 {
-	levelflat_t levelflat;
-	lumpnum_t lump;
-	size_t i, j;
-	INT32 k;
-
-	// special case for encore
-#ifdef GLENCORE
-	if (encoremode)
-	{
-		// go through all sectors to determine if it should be remapped for encore
-		for (i = 0; i < numsectors; i++)
-		{
-			sector_t *sec = &sectors[i];
-
-			// sector checked already?
-			if (sec->validcount == validcount)
-				continue;
-
-			sec->validcount = validcount;
-
-			// gotta check sector floor and ceiling
-			for (j = 0; j < 2; j++)
-			{
-				const boolean ceiling = (j == 0);
-				INT32 pic = ceiling ? sec->ceilingpic : sec->floorpic;
-
-				levelflat = levelflats[pic];
-
-				lump = levelflat.lumpnum;
-				HWR_GetFlat(lump, R_NoEncore(sec, ceiling));
-
-				if (levelflat.speed) // it is an animated flat
-				{
-					for (k = 1; k < levelflat.numpics; k++)
-					{
-						lump = levelflat.baselumpnum + k;
-						HWR_GetFlat(lump, R_NoEncore(sec, ceiling));
-					}
-				}
-			}
-		}
-	}
-	else
-#endif
-	{
-		// on non encore we have it simple
-		// just load every flat in the level
-		for (i = 0; i < numlevelflats; i++)
-		{
-			levelflat = levelflats[i];
-			lump = levelflat.lumpnum;
-
-			HWR_GetFlat(lump, false);
-
-			if (levelflat.speed) // it is an animated flat
-			{
-				for (k = 1; k < levelflat.numpics; k++)
-				{
-					lump = levelflat.baselumpnum + k;
-					HWR_GetFlat(lump, false);
-				}
-			}
-		}
-	}
-}
-
-static void HWR_PrecacheLevelTextures(void)
-{
-	char *texturepresent;
-	anim_t *anim;
-	size_t i, j;
-	INT32 h;
-
-	texturepresent = calloc(numtextures, sizeof (*texturepresent));
-	if (texturepresent == NULL) I_Error("%s: Out of memory looking up textures", "HWR_PrecacheLevel");
-
-	for (i = 0; i < numlines; i++)
-	{
-		line_t *line = &lines[i];
-#ifdef GLENCORE
-		const int noencoremap = ((line->flags & ML_TFERLINE) ? 2 : 1);
-#else
-		const int noencoremap = 1;
-#endif
-
-		// line checked already?
-		if (line->validcount == validcount)
-			continue;
-
-		line->validcount = validcount;
-
-		// two sides
-		for (j = 0; j < 2; j++)
-		{
-			side_t *side = &sides[line->sidenum[j]];
-
-			// Single-side linedef
-			if (line->sidenum[j] == 0xffff)
-				continue;
-
-			if (side->toptexture >= 0 && side->toptexture < numtextures)
-			{
-				texturepresent[side->toptexture] = 1|noencoremap;
-			}
-			if (side->midtexture >= 0 && side->midtexture < numtextures)
-			{
-				texturepresent[side->midtexture] = 1|noencoremap;
-			}
-			if (side->bottomtexture >= 0 && side->bottomtexture < numtextures)
-			{
-				texturepresent[side->bottomtexture] = 1|noencoremap;
-			}
-		}
-	}
-
-	// check for animated textures
-	for (anim = anims; anim < lastanim; anim++)
-	{
-		if (!anim->istexture)
-			continue;
-
-		const char texpresent = texturepresent[anim->basepic];
-
-		if (!texpresent)
-			continue;
-
-		if (texpresent & 1)
-		{
-			for (h = 1; h < anim->numpics; h++)
-			{
-				HWR_GetTexture(anim->basepic+h, false);
-			}
-		}
-#ifdef GLENCORE
-		if (texpresent & 2)
-		{
-			for (h = 1; h < anim->numpics; h++)
-			{
-				HWR_GetTexture(anim->basepic+h, true);
-			}
-		}
-#endif
-	}
-
-	// Sky texture is always present.
-	// Note that F_SKY1 is the name used to indicate a sky floor/ceiling as a flat,
-	// while the sky texture is stored like a wall texture, with a skynum dependent name.
-	texturepresent[skytexture] = 1;
-
-	for (i = 0; i < (unsigned)numtextures; i++)
-	{
-		const char texpresent = texturepresent[i];
-
-		if (!texpresent)
-			continue;
-
-		if (texpresent & 1)
-		{
-			HWR_GetTexture(i, false);
-		}
-#ifdef GLENCORE
-		if (texpresent & 2)
-		{
-			HWR_GetTexture(i, true);
-		}
-#endif
-	}
-	free(texturepresent);
-}
-
-static void HWR_PrecacheLevelSprites(void)
-{
-	patch_t *spritepatch;
-	char *spritepresent;
-	size_t i, j, k;
-	lumpnum_t lump;
-
-	thinker_t *th;
-	mobj_t *mo;
-	spriteframe_t *sf;
-
-	spritepresent = calloc(numsprites, sizeof (*spritepresent));
-	if (spritepresent == NULL) I_Error("%s: Out of memory looking up sprites", "HWR_PrecacheLevel");
-
-	for (th = thinkercap.next; th != &thinkercap; th = th->next)
-	{
-		if (th->function.acp1 != (actionf_p1)P_MobjThinker)
-			continue;
-
-		mo = (mobj_t *)th;
-
-		// ogl is weird
-		// for some reason it does not want to preload sprites with colormaps
-		// so just save us the work
-		if (mo->color || mo->colorized)
-			continue;
-
-		spritepresent[mo->sprite] = 1;
-	}
-
-	for (i = 0; i < numsprites; i++)
-	{
-		if (!spritepresent[i])
-			continue;
-
-		for (j = 0; j < sprites[i].numframes; j++)
-		{
-			sf = &sprites[i].spriteframes[j];
-
-#define cacheang(a) {\
-				lump = sf->lumppat[a];\
-				spritepatch = (patch_t *)W_CachePatchNum(lump, PU_SPRITE);\
-				if (spritepatch != NULL)\
-					HWR_GetPatch(spritepatch);\
-			}
-			// see R_InitSprites for more about lumppat,lumpid
-			switch (sf->rotate)
-			{
-				case SRF_SINGLE:
-					cacheang(0);
-					break;
-				case SRF_2D:
-					cacheang(2);
-					cacheang(6);
-					break;
-				default:
-					k = 8;
-					while (k--)
-						cacheang(k);
-					break;
-			}
-#undef cacheang
-		}
-	}
-	free(spritepresent);
-}
-
-void HWR_PrecacheLevel(void)
-{
-	if (rendermode != render_opengl)
-		return;
-
-	// Precache flats.
-	HWR_PrecacheLevelFlats();
-
-	// Precache textures.
-	HWR_PrecacheLevelTextures();
-
-	// Precache sprites.
-	HWR_PrecacheLevelSprites();
-}
-
-void HWR_LoadMapTextures(size_t pnumtextures)
-{
-	// we must free it since numtextures may have changed
-	HWR_FreeMapTextures();
+	// we must free it since numtextures changed
+	HWR_FreeTextureCache();
 
 	gl_numtextures = pnumtextures;
 #ifdef GLENCORE
-	gl_textures = calloc(gl_numtextures, sizeof (*gl_textures)*2); // *2 - 1 for encore-remapped texture and another for noencore texture (unused when not in encore)
+	gl_textures = calloc(pnumtextures, sizeof (*gl_textures)*2); // *2 - 1 for encore-remapped texture and another for noencore texture (unused when not in encore)
 #else
-	gl_textures = calloc(gl_numtextures, sizeof (*gl_textures));
+	gl_textures = calloc(pnumtextures, sizeof (*gl_textures));
 #endif
 	if (gl_textures == NULL)
-		I_Error("HWR_LoadMapTextures: ran out of memory for OpenGL textures. Sad!");
+		I_Error("HWR_LoadTextures: ran out of memory for OpenGL textures. Sad!");
 }
 
 // --------------------------------------------------------------------------
@@ -883,20 +579,15 @@ GLMapTexture_t *HWR_GetTexture(INT32 tex, boolean noencore)
 		tex = 0;
 #endif
 	}
-
-	// Every texture in memory, stored in the
-	// hardware renderer's bit depth format. Wow!
 #ifdef GLENCORE
 	gltex = &gl_textures[tex*2 + (encoremap && !noencore ? 0 : 1)];
 #else
 	gltex = &gl_textures[tex];
 #endif
-
-	// Generate texture if missing from the cache
 	if (!gltex->mipmap.data && !gltex->mipmap.downloaded)
 		HWR_GenerateTexture(tex, gltex, noencore);
 
-	// If hardware does not have the texture, then call GL_SetTexture to upload it
+	// If hardware does not have the texture, then call pfnSetTexture to upload it
 	if (!gltex->mipmap.downloaded)
 		GL_SetTexture(&gltex->mipmap);
 	HWR_SetCurrentTexture(&gltex->mipmap);
@@ -945,7 +636,6 @@ static void HWR_CacheFlat(GLMipmap_t *glMipmap, lumpnum_t flatlumpnum)
 			pflatsize = 64;
 			break;
 	}
-
 	glMipmap->width  = (UINT16)pflatsize;
 	glMipmap->height = (UINT16)pflatsize;
 
@@ -959,7 +649,7 @@ static void HWR_CacheFlat(GLMipmap_t *glMipmap, lumpnum_t flatlumpnum)
 		if (flat[steppy] == HWR_PATCHES_CHROMAKEY_COLORINDEX)
 			continue;
 
-		flat[steppy] = glMipmap->colormap->source[flat[steppy]];
+		flat[steppy] = glMipmap->colormap[flat[steppy]];
 	}
 #endif
 }
@@ -968,30 +658,23 @@ static void HWR_CacheFlat(GLMipmap_t *glMipmap, lumpnum_t flatlumpnum)
 void HWR_GetFlat(lumpnum_t flatlumpnum, boolean noencoremap)
 {
 	GLMipmap_t *glMipmap;
-	patch_t *patch;
-	UINT8 *colormap = colormaps;
 
 	if (flatlumpnum == LUMPERROR)
 		return;
 
-	patch = HWR_GetCachedGLPatch(flatlumpnum);
-	glMipmap = ((GLPatch_t *)Patch_AllocateHardwarePatch(patch))->mipmap;
+	glMipmap = HWR_GetCachedGLPatch(flatlumpnum)->mipmap;
+
+	glMipmap->colormap = colormaps;
 
-	if (!glMipmap->colormap)
-	{
 #ifdef GLENCORE
-		if (!noencoremap && encoremap)
-			colormap += COLORMAP_REMAPOFFSET;
+	if (!noencoremap && encoremap)
+		glMipmap->colormap += COLORMAP_REMAPOFFSET;
 #endif
-		glMipmap->colormap = Z_Calloc(sizeof(*glMipmap->colormap), PU_HWRPATCHCOLMIPMAP, NULL);
-		glMipmap->colormap->source = colormap;
-		M_Memcpy(glMipmap->colormap->data, colormap, 256 * sizeof(UINT8));
-	}
 
 	if (!glMipmap->downloaded && !glMipmap->data)
 		HWR_CacheFlat(glMipmap, flatlumpnum);
 
-	// If hardware does not have the texture, then call GL_SetTexture to upload it
+	// If hardware does not have the texture, then call pfnSetTexture to upload it
 	if (!glMipmap->downloaded)
 		GL_SetTexture(glMipmap);
 	HWR_SetCurrentTexture(glMipmap);
@@ -1000,17 +683,27 @@ void HWR_GetFlat(lumpnum_t flatlumpnum, boolean noencoremap)
 	Z_ChangeTag(glMipmap->data, PU_HWRCACHE_UNLOCKED);
 }
 
-// --------------------+
-// HWR_LoadPatchMipmap : Generates a patch into a mipmap, usually the mipmap inside the patch itself
-// --------------------+
-static void HWR_LoadPatchMipmap(patch_t *patch, GLMipmap_t *glMipmap)
+//
+// HWR_LoadMappedPatch(): replace the skin color of the sprite in cache
+//                          : load it first in doom cache if not already
+//
+static void HWR_LoadMappedPatch(GLMipmap_t *glMipmap, GLPatch_t *glPatch)
 {
-	GLPatch_t *glPatch = patch->hardware;
-
 	if (!glMipmap->downloaded && !glMipmap->data)
+	{
+		patch_t *patch = glPatch->rawpatch;
+		if (!patch)
+			patch = W_CacheLumpNumPwad(glPatch->wadnum, glPatch->lumpnum, PU_STATIC);
 		HWR_MakePatch(patch, glPatch, glMipmap, true);
 
-	// If hardware does not have the texture, then call GL_SetTexture to upload it
+		// You can't free rawpatch for some reason?
+		// (Obviously I can't, sprite rotation needs that...)
+
+		if (!glPatch->rawpatch)
+			Z_Free(patch);
+	}
+
+	// If hardware does not have the texture, then call pfnSetTexture to upload it
 	if (!glMipmap->downloaded)
 		GL_SetTexture(glMipmap);
 	HWR_SetCurrentTexture(glMipmap);
@@ -1019,92 +712,78 @@ static void HWR_LoadPatchMipmap(patch_t *patch, GLMipmap_t *glMipmap)
 	Z_ChangeTag(glMipmap->data, PU_HWRCACHE_UNLOCKED);
 }
 
-// ----------------------+
-// HWR_UpdatePatchMipmap : Updates a mipmap.
-// ----------------------+
-static void HWR_UpdatePatchMipmap(patch_t *patch, GLMipmap_t *glMipmap)
-{
-	GLPatch_t *grPatch = patch->hardware;
-	HWR_MakePatch(patch, grPatch, glMipmap, true);
-
-	// If hardware does not have the texture, then call GL_SetTexture to upload it
-	// If it does have the texture, then call GL_UpdateTexture to update it
-	if (!glMipmap->downloaded)
-		GL_SetTexture(glMipmap);
-	else
-		GL_UpdateTexture(glMipmap);
-	HWR_SetCurrentTexture(glMipmap);
-
-	// The system-memory data can be purged now.
-	Z_ChangeTag(glMipmap->data, PU_HWRCACHE_UNLOCKED);
-}
-
 // -----------------+
 // HWR_GetPatch     : Downloads a patch to the hardware cache and make it ready for use
 // -----------------+
-void HWR_GetPatch(patch_t *patch)
+void HWR_GetPatch(GLPatch_t *glPatch)
 {
-	if (!patch->hardware)
-		Patch_CreateGL(patch);
-	HWR_LoadPatchMipmap(patch, ((GLPatch_t *)patch->hardware)->mipmap);
+	// is it in hardware cache
+	if (!glPatch->mipmap->downloaded && !glPatch->mipmap->data)
+	{
+		// load the software patch, PU_STATIC or the Z_Malloc for hardware patch will
+		// flush the software patch before the conversion! oh yeah I suffered
+		patch_t *ptr = glPatch->rawpatch;
+		if (!ptr)
+			ptr = W_CacheLumpNumPwad(glPatch->wadnum, glPatch->lumpnum, PU_STATIC);
+		HWR_MakePatch(ptr, glPatch, glPatch->mipmap, true);
+
+		// this is inefficient.. but the hardware patch in heap is purgeable so it should
+		// not fragment memory, and besides the REAL cache here is the hardware memory
+		if (!glPatch->rawpatch)
+			Z_Free(ptr);
+	}
+
+	// If hardware does not have the texture, then call pfnSetTexture to upload it
+	if (!glPatch->mipmap->downloaded)
+		GL_SetTexture(glPatch->mipmap);
+	HWR_SetCurrentTexture(glPatch->mipmap);
+
+	// The system-memory patch data can be purged now.
+	Z_ChangeTag(glPatch->mipmap->data, PU_HWRCACHE_UNLOCKED);
 }
 
+
 // -------------------+
 // HWR_GetMappedPatch : Same as HWR_GetPatch for sprite color
 // -------------------+
-void HWR_GetMappedPatch(patch_t *patch, const UINT8 *colormap)
+void HWR_GetMappedPatch(GLPatch_t *glPatch, const UINT8 *colormap)
 {
-	GLPatch_t *glPatch;
 	GLMipmap_t *glMipmap, *newMipmap;
 
-	if (!patch->hardware)
-		Patch_CreateGL(patch);
-	glPatch = patch->hardware;
-
 	// Blatant hack for encore colormapping aside...
 	if (colormap == colormaps || colormap == NULL || colormap == (const UINT8*)(COLORMAP_REMAPOFFSET))
 	{
-		// Load the default (green) color in hardware cache
-		HWR_GetPatch(patch);
+		// Load the default (green) color in doom cache (temporary?) AND hardware cache
+		HWR_GetPatch(glPatch);
 		return;
 	}
 
 	// search for the mipmap
 	// skip the first (no colormap translated)
-	for (glMipmap = glPatch->mipmap; LIKELY(glMipmap->nextcolormap);)
+	for (glMipmap = glPatch->mipmap; glMipmap->nextcolormap; )
 	{
 		glMipmap = glMipmap->nextcolormap;
 
-		if (UNLIKELY(glMipmap->colormap && glMipmap->colormap->source == colormap))
-		{
-			if (memcmp(glMipmap->colormap->data, colormap, 256 * sizeof(UINT8)))
-			{
-				M_Memcpy(glMipmap->colormap->data, colormap, 256 * sizeof(UINT8));
-				HWR_UpdatePatchMipmap(patch, glMipmap);
-			}
-			else
-				HWR_LoadPatchMipmap(patch, glMipmap);
+		if (glMipmap->colormap != colormap)
+			continue;
 
-			return;
-		}
+		HWR_LoadMappedPatch(glMipmap, glPatch);
+		return;
 	}
 	// not found, create it!
 	// If we are here, the sprite with the current colormap is not already in hardware memory
 
 	//BP: WARNING: don't free it manually without clearing the cache of harware renderer
 	//              (it have a liste of mipmap)
-	//    this malloc is cleared in HWR_FreeColormapCache
+	//    this malloc is cleared in HWR_FreeTextureCache
 	//    (...) unfortunately z_malloc fragment alot the memory :(so malloc is better
 	newMipmap = calloc(1, sizeof (*newMipmap));
 	if (newMipmap == NULL)
 		I_Error("%s: Out of memory", "HWR_GetMappedPatch");
 	glMipmap->nextcolormap = newMipmap;
 
-	newMipmap->colormap = Z_Calloc(sizeof(*newMipmap->colormap), PU_HWRPATCHCOLMIPMAP, NULL);
-	newMipmap->colormap->source = colormap;
-	M_Memcpy(newMipmap->colormap->data, colormap, 256 * sizeof(UINT8));
-
-	HWR_LoadPatchMipmap(patch, newMipmap);
+	newMipmap->colormap = colormap;
+	HWR_LoadMappedPatch(newMipmap, glPatch);
 }
 
 void HWR_UnlockCachedPatch(GLPatch_t *glPatch)
@@ -1115,21 +794,24 @@ void HWR_UnlockCachedPatch(GLPatch_t *glPatch)
 	Z_ChangeTag(glPatch->mipmap->data, PU_HWRCACHE_UNLOCKED);
 }
 
-patch_t *HWR_GetCachedGLPatchPwad(UINT16 wadnum, UINT16 lumpnum)
+GLPatch_t *HWR_GetCachedGLPatchPwad(UINT16 wadnum, UINT16 lumpnum)
 {
-	lumpcache_t *lumpcache = wadfiles[wadnum]->patchcache;
+	aatree_t *hwrcache = wadfiles[wadnum]->hwrcache;
+	GLPatch_t *glPatch;
 
-	if (!lumpcache[lumpnum])
+	if (!(glPatch = M_AATreeGet(hwrcache, lumpnum)))
 	{
-		void *ptr = Z_Calloc(sizeof(patch_t), PU_PATCH, &lumpcache[lumpnum]);
-		Patch_Create(NULL, 0, ptr);
-		Patch_AllocateHardwarePatch(ptr);
+		glPatch = Z_Calloc(sizeof(GLPatch_t), PU_HWRPATCHINFO, NULL);
+		glPatch->wadnum = wadnum;
+		glPatch->lumpnum = lumpnum;
+		glPatch->mipmap = Z_Calloc(sizeof(GLMipmap_t), PU_HWRPATCHINFO, NULL);
+		M_AATreeSet(hwrcache, lumpnum, glPatch);
 	}
 
-	return (patch_t *)(lumpcache[lumpnum]);
+	return glPatch;
 }
 
-patch_t *HWR_GetCachedGLPatch(lumpnum_t lumpnum)
+GLPatch_t *HWR_GetCachedGLPatch(lumpnum_t lumpnum)
 {
 	return HWR_GetCachedGLPatchPwad(WADFILENUM(lumpnum),LUMPNUM(lumpnum));
 }
@@ -1150,15 +832,15 @@ static void HWR_DrawFadeMaskInCache(GLMipmap_t *mipmap, INT32 pblockwidth, INT32
 	W_ReadLump(fademasklumpnum, Z_Malloc(W_LumpLength(fademasklumpnum),
 		PU_HWRCACHE, &flat));
 
-	stepy = ((INT32)fmheight<<FRACBITS)/pblockheight;
-	stepx = ((INT32)fmwidth<<FRACBITS)/pblockwidth;
+	stepy = ((INT32)SHORT(fmheight)<<FRACBITS)/pblockheight;
+	stepx = ((INT32)SHORT(fmwidth)<<FRACBITS)/pblockwidth;
 	posy = 0;
 
 	for (j = 0; j < pblockheight; j++)
 	{
 		posx = 0;
 		dest = &block[j*(mipmap->width)]; // 1bpp
-		src = &flat[(posy>>FRACBITS)*fmwidth];
+		src = &flat[(posy>>FRACBITS)*SHORT(fmwidth)];
 		for (i = 0; i < pblockwidth;i++)
 		{
 			// fademask bpp is always 1, and is used just for alpha
@@ -1223,10 +905,8 @@ static void HWR_CacheFadeMask(GLMipmap_t *glMipmap, lumpnum_t fademasklumpnum)
 void HWR_GetFadeMask(lumpnum_t fademasklumpnum)
 {
 	GLMipmap_t *glMipmap;
-	patch_t *patch;
 
-	patch = HWR_GetCachedGLPatch(fademasklumpnum);
-	glMipmap = ((GLPatch_t *)Patch_AllocateHardwarePatch(patch))->mipmap;
+	glMipmap = HWR_GetCachedGLPatch(fademasklumpnum)->mipmap;
 
 	if (!glMipmap->downloaded && !glMipmap->data)
 		HWR_CacheFadeMask(glMipmap, fademasklumpnum);
@@ -1391,7 +1071,6 @@ UINT32 HWR_CreateLightTable(UINT8 *lighttable)
 UINT32 HWR_GetLightTableID(extracolormap_t *colormap)
 {
 	boolean default_colormap = false;
-
 	if (!colormap)
 	{
 		colormap = &extra_colormaps[num_extra_colormaps]; // a place to store the hw lighttable id
@@ -1408,7 +1087,6 @@ UINT32 HWR_GetLightTableID(extracolormap_t *colormap)
 			colormap_pointer = colormaps; // don't actually use the data from the "default colormap"
 		else
 			colormap_pointer = colormap->colormap;
-
 		colormap->gl_lighttable_id = HWR_CreateLightTable(colormap_pointer);
 	}
 

src/hardware/hw_clip.c

@@ -314,6 +314,8 @@ void gld_clipper_Clear(void)
 	cliphead = NULL;
 }
 
+#define RMUL (1.6f/1.333333f)
+
 angle_t gld_FrustumAngle(angle_t tiltangle)
 {
 	double clipfov;

src/hardware/hw_data.h

@@ -23,39 +23,31 @@
 
 typedef enum GLTextureFormat_e
 {
-	GL_TEXFMT_P_8					= 0x01, /* 8-bit palette */
-	GL_TEXFMT_AP_88					= 0x02, /* 8-bit alpha, 8-bit palette */
+	GL_TEXFMT_P_8                 = 0x01, /* 8-bit palette */
+	GL_TEXFMT_AP_88               = 0x02, /* 8-bit alpha, 8-bit palette */
 
-	GL_TEXFMT_RGBA					= 0x10, /* 32 bit RGBA! */
+	GL_TEXFMT_RGBA                = 0x10, /* 32 bit RGBA! */
 
-	GL_TEXFMT_ALPHA_8				= 0x20, /* (0..0xFF) alpha     */
-	GL_TEXFMT_INTENSITY_8			= 0x21, /* (0..0xFF) intensity */
-	GL_TEXFMT_ALPHA_INTENSITY_88	= 0x22,
+	GL_TEXFMT_ALPHA_8             = 0x20, /* (0..0xFF) alpha     */
+	GL_TEXFMT_INTENSITY_8         = 0x21, /* (0..0xFF) intensity */
+	GL_TEXFMT_ALPHA_INTENSITY_88  = 0x22,
 } GLTextureFormat_t;
 
-// Colormap structure for mipmaps.
-struct GLColormap_s
-{
-	const UINT8 *source;
-	UINT8 data[256];
-};
-typedef struct GLColormap_s GLColormap_t;
-
 // Texture information (misleadingly named "mipmap" all over the code.)
 // The *data pointer holds the address of the graphics data cached in heap memory.
 // NULL if the texture is not in SRB2's heap cache.
 struct GLMipmap_s
 {
 	// for UpdateTexture
-	GLTextureFormat_t		format;
-	void					*data;
+	GLTextureFormat_t 		format;
+	void              		*data;
 
-	UINT32					flags;
-	UINT16					width, height;
+	UINT32          		flags;
+	UINT16 					width, height;
 	UINT32					downloaded; // The GPU has this texture.
 
-	struct	GLMipmap_s		*nextcolormap;
-	struct GLColormap_s		*colormap;
+	struct	GLMipmap_s 		*nextcolormap;
+	const 	UINT8 			*colormap;
 };
 typedef struct GLMipmap_s GLMipmap_t;
 
@@ -70,11 +62,24 @@ struct GLMapTexture_s
 };
 typedef struct GLMapTexture_s GLMapTexture_t;
 
-// Patch information for the hardware renderer.
+// a cached patch as converted to hardware format, holding the original patch_t
+// header so that the existing code can retrieve ->width, ->height as usual
+// This is returned by W_CachePatchNum()/W_CachePatchName(), when rendermode
+// is 'render_opengl'. Else it returns the normal patch_t data.
 struct GLPatch_s
 {
-	GLMipmap_t			*mipmap;
+	// the 4 first fields come right away from the original patch_t
+	INT16				width;
+	INT16				height;
+	INT16				leftoffset;     // pixels to the left of origin
+	INT16				topoffset;      // pixels below the origin
+	//
 	float				max_s,max_t;
+	UINT16				wadnum;      // the software patch lump num for when the hardware patch
+	UINT16              lumpnum;     // was flushed, and we need to re-create it
+	void                *rawpatch;   // :^)
+	GLMipmap_t			*mipmap;
+
 	boolean				notfound; // if the texture file was not found, mark it here (used in model texture loading)
 };
 typedef struct GLPatch_s GLPatch_t;

src/hardware/hw_defs.h

@@ -128,6 +128,7 @@ typedef struct
 {
 	FLOAT       x,y,z;           // position
 	FLOAT       anglex, angley, anglez;   // aimingangle / viewangle
+	FLOAT       anglex2, anglez2;        // secondaries
 	FLOAT       scalex, scaley, scalez;
 	FLOAT       fovangle;
 	UINT8       splitscreen;
@@ -255,8 +256,7 @@ enum EPolyFlags
 	PF_RemoveYWrap      = 0x00010000,   // Force clamp texture on Y
 	PF_ForceWrapX       = 0x00020000,   // Force repeat texture on X
 	PF_ForceWrapY       = 0x00040000,   // Forces repeat texture on Y
-	PF_Ripple           = 0x00100000,   // Water ripple effect. The current backend doesn't use it for anything.
-	PF_Skydecal         = 0x20000000    // Enables smaller polygon offset, to be used for skywalls only
+	PF_Ripple           = 0x00100000    // Water ripple effect. The current backend doesn't use it for anything.
 	//                    0x20000000
 	//                    0x40000000
 	//                    0x80000000
@@ -311,7 +311,7 @@ enum hwdsetspecialstate
 
 	HWD_SET_TEXTUREFILTERMODE,
 	HWD_SET_TEXTUREANISOTROPICMODE,
-
+	
 	HWD_SET_MSAA,
 
 	HWD_SET_SCREEN_TEXTURES,
@@ -319,8 +319,6 @@ enum hwdsetspecialstate
 	HWD_SET_PORTAL_MODE,// new portal thing
 	HWD_SET_STENCIL_LEVEL,
 
-	HWD_SET_TEXTURE_FORMAT,
-
 	HWD_NUMSTATE
 };
 typedef enum hwdsetspecialstate hwdspecialstate_t;

src/hardware/hw_draw.c

@@ -71,11 +71,10 @@ static const float FLOATBASEVIDHEIGHT = (float)BASEVIDHEIGHT;
 // Notes            : x,y : positions relative to the original Doom resolution
 //                  : textes(console+score) + menus + status bar
 // -----------------+
-void HWR_DrawPatch(patch_t *gpatch, INT32 x, INT32 y, INT32 option)
+void HWR_DrawPatch(GLPatch_t *gpatch, INT32 x, INT32 y, INT32 option)
 {
 	FOutVector v[4];
 	FBITFIELD flags;
-	GLPatch_t *hwrPatch;
 
 //  3--2
 //  | /|
@@ -88,7 +87,6 @@ void HWR_DrawPatch(patch_t *gpatch, INT32 x, INT32 y, INT32 option)
 
 	// make patch ready in hardware cache
 	HWR_GetPatch(gpatch);
-	hwrPatch = ((GLPatch_t *)gpatch->hardware);
 
 	switch (option & V_SCALEPATCHMASK)
 	{
@@ -108,17 +106,17 @@ void HWR_DrawPatch(patch_t *gpatch, INT32 x, INT32 y, INT32 option)
 	if (option & V_NOSCALESTART)
 		sdupx = sdupy = 2.0f;
 
-	v[0].x = v[3].x = (x*sdupx-gpatch->leftoffset*pdupx)/vid.width - 1;
-	v[2].x = v[1].x = (x*sdupx+(gpatch->width - gpatch->leftoffset)*pdupx)/vid.width - 1;
-	v[0].y = v[1].y = 1-(y*sdupy-gpatch->topoffset*pdupy)/vid.height;
-	v[2].y = v[3].y = 1-(y*sdupy+(gpatch->height - gpatch->topoffset)*pdupy)/vid.height;
+	v[0].x = v[3].x = (x*sdupx-SHORT(gpatch->leftoffset)*pdupx)/vid.width - 1;
+	v[2].x = v[1].x = (x*sdupx+(SHORT(gpatch->width)-SHORT(gpatch->leftoffset))*pdupx)/vid.width - 1;
+	v[0].y = v[1].y = 1-(y*sdupy-SHORT(gpatch->topoffset)*pdupy)/vid.height;
+	v[2].y = v[3].y = 1-(y*sdupy+(SHORT(gpatch->height)-SHORT(gpatch->topoffset))*pdupy)/vid.height;
 
 	v[0].z = v[1].z = v[2].z = v[3].z = 1.0f;
 
 	v[0].s = v[3].s = 0.0f;
-	v[2].s = v[1].s = hwrPatch->max_s;
+	v[2].s = v[1].s = gpatch->max_s;
 	v[0].t = v[1].t = 0.0f;
-	v[2].t = v[3].t = hwrPatch->max_t;
+	v[2].t = v[3].t = gpatch->max_t;
 
 	flags = PF_Translucent|PF_NoDepthTest;
 
@@ -131,7 +129,7 @@ void HWR_DrawPatch(patch_t *gpatch, INT32 x, INT32 y, INT32 option)
 	GL_DrawPolygon(NULL, v, 4, flags);
 }
 
-void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, fixed_t vscale, INT32 option, const UINT8 *colormap, INT32 bflags)
+void HWR_DrawStretchyFixedPatch(GLPatch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, fixed_t vscale, INT32 option, const UINT8 *colormap, INT32 bflags)
 {
 	FOutVector v[4];
 	FBITFIELD flags;
@@ -139,7 +137,6 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 	float cy = FIXED_TO_FLOAT(y);
 	UINT8 alphalevel = ((option & V_ALPHAMASK) >> V_ALPHASHIFT);
 	UINT8 blendmode = ((bflags & V_BLENDMASK) >> V_BLENDSHIFT);
-	GLPatch_t *hwrPatch;
 
 //  3--2
 //  | /|
@@ -159,8 +156,6 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 	else
 		HWR_GetMappedPatch(gpatch, colormap);
 
-	hwrPatch = ((GLPatch_t *)gpatch->hardware);
-
 	dupx = (float)vid.dupx;
 	dupy = (float)vid.dupy;
 
@@ -191,13 +186,13 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 
 		// left offset
 		if (option & V_FLIP)
-			offsetx = (float)(gpatch->width - gpatch->leftoffset) * fscalew;
+			offsetx = (float)(SHORT(gpatch->width) - SHORT(gpatch->leftoffset)) * fscalew;
 		else
-			offsetx = (float)(gpatch->leftoffset) * fscalew;
+			offsetx = (float)SHORT(gpatch->leftoffset) * fscalew;
 
 		// top offset
 		// TODO: make some kind of vertical version of V_FLIP, maybe by deprecating V_OFFSET in future?!?
-		offsety = (float)(gpatch->topoffset) * fscaleh;
+		offsety = (float)SHORT(gpatch->topoffset) * fscaleh;
 
 		if ((option & (V_NOSCALESTART|V_OFFSET)) == (V_NOSCALESTART|V_OFFSET)) // Multiply by dupx/dupy for crosshairs
 		{
@@ -225,15 +220,17 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 			// if it's meant to cover the whole screen, black out the rest
 			// cx and cy are possibly *slightly* off from float maths
 			// This is done before here compared to software because we directly alter cx and cy to centre
-			if (cx >= -0.1f && cx <= 0.1f && gpatch->width == BASEVIDWIDTH && cy >= -0.1f && cy <= 0.1f && gpatch->height == BASEVIDHEIGHT)
+			if (cx >= -0.1f && cx <= 0.1f && SHORT(gpatch->width) == BASEVIDWIDTH && cy >= -0.1f && cy <= 0.1f && SHORT(gpatch->height) == BASEVIDHEIGHT)
 			{
-				const column_t *column = (const column_t *)((const UINT8 *)(gpatch->columns) + (gpatch->columnofs[0]));
-
+				// Need to temporarily cache the real patch to get the colour of the top left pixel
+				patch_t *realpatch = W_CacheLumpNumPwad(gpatch->wadnum, gpatch->lumpnum, PU_STATIC);
+				const column_t *column = (const column_t *)((const UINT8 *)(realpatch) + LONG((realpatch)->columnofs[0]));
 				if (!column->topdelta)
 				{
 					const UINT8 *source = (const UINT8 *)(column) + 3;
 					HWR_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, (column->topdelta == 0xff ? 31 : source[0]));
 				}
+				Z_Free(realpatch);
 			}
 			// centre screen
 			if (fabsf(fvw - FLOATBASEVIDWIDTH * dupx) > 1.0E-36f)
@@ -255,12 +252,20 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 		}
 	}
 
-	fwidth = (float)(gpatch->width) * fscalew * dupx;
-	fheight = (float)(gpatch->height) * fscaleh * dupy;
+	if (pscale != FRACUNIT)
+	{
+		fwidth = (float)SHORT(gpatch->width) * fscalew * dupx;
+		fheight = (float)SHORT(gpatch->height) * fscaleh * dupy;
+	}
+	else
+	{
+		fwidth = (float)SHORT(gpatch->width) * dupx;
+		fheight = (float)SHORT(gpatch->height) * dupy;
+	}
 
 	// positions of the cx, cy, are between 0 and vid.width/vid.height now, we need them to be between -1 and 1
-	cx = -1.0f + (cx / (fvw / 2.0f));
-	cy = 1.0f - (cy / (fvh / 2.0f));
+	cx = -1.0f + (cx / (vid.width / 2.0f));
+	cy = 1.0f - (cy / (vid.height / 2.0f));
 
 	// fwidth and fheight are similar
 	fwidth /= fvw / 2.0f;
@@ -277,19 +282,19 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 
 	if (option & V_FLIP)
 	{
-		v[0].s = v[3].s = hwrPatch->max_s;
+		v[0].s = v[3].s = gpatch->max_s;
 		v[2].s = v[1].s = 0.0f;
 	}
 	else
 	{
 		v[0].s = v[3].s = 0.0f;
-		v[2].s = v[1].s = hwrPatch->max_s;
+		v[2].s = v[1].s = gpatch->max_s;
 	}
 
 	v[0].t = v[1].t = 0.0f;
-	v[2].t = v[3].t = hwrPatch->max_t;
+	v[2].t = v[3].t = gpatch->max_t;
 
-	// clip it since it is used for bunny scroll in doom I
+	// whoops
 	if (blendmode)
 		flags = HWR_GetBlendModeFlag(blendmode+1)|PF_NoDepthTest;
 	else
@@ -300,11 +305,13 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 	if (option & V_WRAPY)
 		flags |= PF_ForceWrapY;
 
+	// clip it since it is used for bunny scroll in doom I
+
 	if (alphalevel)
 	{
 		FSurfaceInfo Surf;
 		Surf.PolyColor.s.red = Surf.PolyColor.s.green = Surf.PolyColor.s.blue = 0xff;
-
+		
 		if (alphalevel == 13) Surf.PolyColor.s.alpha = softwaretranstogl_lo[hudtrans];
 		else if (alphalevel == 14) Surf.PolyColor.s.alpha = softwaretranstogl[hudtrans];
 		else if (alphalevel == 15) Surf.PolyColor.s.alpha = softwaretranstogl_hi[hudtrans];
@@ -317,14 +324,13 @@ void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t p
 		GL_DrawPolygon(NULL, v, 4, flags);
 }
 
-void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, INT32 option, fixed_t sx, fixed_t sy, fixed_t w, fixed_t h)
+void HWR_DrawCroppedPatch(GLPatch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, INT32 option, fixed_t sx, fixed_t sy, fixed_t w, fixed_t h)
 {
 	FOutVector v[4];
 	FBITFIELD flags;
 	float cx = FIXED_TO_FLOAT(x);
 	float cy = FIXED_TO_FLOAT(y);
 	UINT8 alphalevel = ((option & V_ALPHAMASK) >> V_ALPHASHIFT);
-	GLPatch_t *hwrPatch;
 
 //  3--2
 //  | /|
@@ -340,7 +346,6 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 
 	// make patch ready in hardware cache
 	HWR_GetPatch(gpatch);
-	hwrPatch = ((GLPatch_t *)gpatch->hardware);
 
 	dupx = (float)vid.dupx;
 	dupy = (float)vid.dupy;
@@ -363,8 +368,8 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 	dupx = dupy = (dupx < dupy ? dupx : dupy);
 	fscale = FIXED_TO_FLOAT(pscale);
 
-	cy -= (float)(gpatch->topoffset) * fscale;
-	cx -= (float)(gpatch->leftoffset) * fscale;
+	cy -= (float)SHORT(gpatch->topoffset) * fscale;
+	cx -= (float)SHORT(gpatch->leftoffset) * fscale;
 
 	if (!(option & V_NOSCALESTART))
 	{
@@ -376,15 +381,17 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 			// if it's meant to cover the whole screen, black out the rest
 			// cx and cy are possibly *slightly* off from float maths
 			// This is done before here compared to software because we directly alter cx and cy to centre
-			if (cx >= -0.1f && cx <= 0.1f && gpatch->width == BASEVIDWIDTH && cy >= -0.1f && cy <= 0.1f && gpatch->height == BASEVIDHEIGHT)
+			if (cx >= -0.1f && cx <= 0.1f && SHORT(gpatch->width) == BASEVIDWIDTH && cy >= -0.1f && cy <= 0.1f && SHORT(gpatch->height) == BASEVIDHEIGHT)
 			{
-				const column_t *column = (const column_t *)((const UINT8 *)(gpatch->columns) + (gpatch->columnofs[0]));
-
+				// Need to temporarily cache the real patch to get the colour of the top left pixel
+				patch_t *realpatch = W_CacheLumpNumPwad(gpatch->wadnum, gpatch->lumpnum, PU_STATIC);
+				const column_t *column = (const column_t *)((const UINT8 *)(realpatch) + LONG((realpatch)->columnofs[0]));
 				if (!column->topdelta)
 				{
 					const UINT8 *source = (const UINT8 *)(column) + 3;
 					HWR_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, (column->topdelta == 0xff ? 31 : source[0]));
 				}
+				Z_Free(realpatch);
 			}
 			// centre screen
 			if (fabsf(fvw - FLOATBASEVIDWIDTH * dupx) > 1.0E-36f)
@@ -415,11 +422,11 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 	if (fheight > h - sy)
 		fheight = h - sy;
 
-	if (fwidth > gpatch->width)
-		fwidth = gpatch->width;
+	if (fwidth > SHORT(gpatch->width))
+		fwidth = SHORT(gpatch->width);
 
-	if (fheight > gpatch->height)
-		fheight = gpatch->height;
+	if (fheight > SHORT(gpatch->height))
+		fheight = SHORT(gpatch->height);
 
 	if (pscale != FRACUNIT)
 	{
@@ -433,8 +440,8 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 	}
 
 	// positions of the cx, cy, are between 0 and vid.width/vid.height now, we need them to be between -1 and 1
-	cx = -1.0f + (cx / (fvw / 2.0f));
-	cy = 1.0f - (cy / (fvh / 2.0f));
+	cx = -1.0f + (cx / (vid.width / 2.0f));
+	cy = 1.0f - (cy / (vid.height / 2.0f));
 
 	// fwidth and fheight are similar
 	fwidth /= fvw / 2.0f;
@@ -449,10 +456,10 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 
 	v[0].z = v[1].z = v[2].z = v[3].z = 1.0f;
 
-	v[0].s = v[3].s = ((sx)/(float)(gpatch->width) )*hwrPatch->max_s;
-	v[2].s = v[1].s = ((w )/(float)(gpatch->width) )*hwrPatch->max_s;
-	v[0].t = v[1].t = ((sy)/(float)(gpatch->height))*hwrPatch->max_t;
-	v[2].t = v[3].t = ((h )/(float)(gpatch->height))*hwrPatch->max_t;
+	v[0].s = v[3].s = ((sx)/(float)SHORT(gpatch->width) )*gpatch->max_s;
+	v[2].s = v[1].s = ((w )/(float)SHORT(gpatch->width) )*gpatch->max_s;
+	v[0].t = v[1].t = ((sy)/(float)SHORT(gpatch->height))*gpatch->max_t;
+	v[2].t = v[3].t = ((h )/(float)SHORT(gpatch->height))*gpatch->max_t;
 
 	flags = PF_Translucent|PF_NoDepthTest;
 
@@ -471,7 +478,7 @@ void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale,
 		else if (alphalevel == 14) Surf.PolyColor.s.alpha = softwaretranstogl[cv_translucenthud.value];
 		else if (alphalevel == 15) Surf.PolyColor.s.alpha = softwaretranstogl_hi[cv_translucenthud.value];
 		else Surf.PolyColor.s.alpha = softwaretranstogl[10-alphalevel];
-
+		
 		flags |= PF_Modulated;
 		GL_DrawPolygon(&Surf, v, 4, flags);
 	}
@@ -607,7 +614,7 @@ void HWR_FadeScreenMenuBack(UINT16 color, UINT8 strength)
 		RGBA_t *palette = HWR_GetTexturePalette();
 		Surf.PolyColor.rgba = palette[color&0xFF].rgba;
 
-		if (HWR_ShouldUsePaletteRendering())
+        if (HWR_ShouldUsePaletteRendering())
 			Surf.PolyColor.s.alpha = softwaretranstogl[strength];
 		else
 			Surf.PolyColor.s.alpha = (UINT8)(strength*25.5f);
@@ -663,7 +670,7 @@ void HWR_DrawViewBorder(INT32 clearlines)
 	INT32 top, side;
 	INT32 baseviewwidth, baseviewheight;
 	INT32 basewindowx, basewindowy;
-	patch_t *patch;
+	GLPatch_t *patch;
 
 //    if (gl_viewwidth == vid.width)
 //        return;
@@ -712,7 +719,7 @@ void HWR_DrawViewBorder(INT32 clearlines)
 	// top edge
 	if (clearlines > basewindowy - 8)
 	{
-		patch = W_CachePatchNum(viewborderlump[BRDR_T], PU_PATCH);
+		patch = W_CachePatchNum(viewborderlump[BRDR_T], PU_CACHE);
 		for (x = 0; x < baseviewwidth; x += 8)
 			HWR_DrawPatch(patch, basewindowx + x, basewindowy - 8,
 				0);
@@ -721,7 +728,7 @@ void HWR_DrawViewBorder(INT32 clearlines)
 	// bottom edge
 	if (clearlines > basewindowy + baseviewheight)
 	{
-		patch = W_CachePatchNum(viewborderlump[BRDR_B], PU_PATCH);
+		patch = W_CachePatchNum(viewborderlump[BRDR_B], PU_CACHE);
 		for (x = 0; x < baseviewwidth; x += 8)
 			HWR_DrawPatch(patch, basewindowx + x,
 				basewindowy + baseviewheight, 0);
@@ -730,7 +737,7 @@ void HWR_DrawViewBorder(INT32 clearlines)
 	// left edge
 	if (clearlines > basewindowy)
 	{
-		patch = W_CachePatchNum(viewborderlump[BRDR_L], PU_PATCH);
+		patch = W_CachePatchNum(viewborderlump[BRDR_L], PU_CACHE);
 		for (y = 0; y < baseviewheight && basewindowy + y < clearlines;
 			y += 8)
 		{
@@ -742,7 +749,7 @@ void HWR_DrawViewBorder(INT32 clearlines)
 	// right edge
 	if (clearlines > basewindowy)
 	{
-		patch = W_CachePatchNum(viewborderlump[BRDR_R], PU_PATCH);
+		patch = W_CachePatchNum(viewborderlump[BRDR_R], PU_CACHE);
 		for (y = 0; y < baseviewheight && basewindowy+y < clearlines;
 			y += 8)
 		{
@@ -754,22 +761,22 @@ void HWR_DrawViewBorder(INT32 clearlines)
 	// Draw beveled corners.
 	if (clearlines > basewindowy - 8)
 		HWR_DrawPatch(W_CachePatchNum(viewborderlump[BRDR_TL],
-				PU_PATCH),
+				PU_CACHE),
 			basewindowx - 8, basewindowy - 8, 0);
 
 	if (clearlines > basewindowy - 8)
 		HWR_DrawPatch(W_CachePatchNum(viewborderlump[BRDR_TR],
-				PU_PATCH),
+				PU_CACHE),
 			basewindowx + baseviewwidth, basewindowy - 8, 0);
 
 	if (clearlines > basewindowy+baseviewheight)
 		HWR_DrawPatch(W_CachePatchNum(viewborderlump[BRDR_BL],
-				PU_PATCH),
+				PU_CACHE),
 			basewindowx - 8, basewindowy + baseviewheight, 0);
 
 	if (clearlines > basewindowy + baseviewheight)
 		HWR_DrawPatch(W_CachePatchNum(viewborderlump[BRDR_BR],
-				PU_PATCH),
+				PU_CACHE),
 			basewindowx + baseviewwidth,
 			basewindowy + baseviewheight, 0);
 }
@@ -875,8 +882,8 @@ void HWR_DrawDiag(INT32 x, INT32 y, INT32 wh, INT32 color)
 	if (fy + fh > vid.height)
 		fh = fvh - fy;
 
-	fx = -1.0f + fx / (fvw / 2.0f);
-	fy = 1.0f - fy / (fvh / 2.0f);
+	fx = -1.0f + fx / (vid.width / 2.0f);
+	fy = 1.0f - fy / (vid.height / 2.0f);
 	fw = fw / (fvw / 2.0f);
 	fh = fh / (fvh / 2.0f);
 
@@ -988,8 +995,8 @@ void HWR_DrawConsoleFill(INT32 x, INT32 y, INT32 w, INT32 h, UINT32 color, INT32
 	if (fy + fh > vid.height)
 		fh = fvh - fy;
 
-	fx = -1.0f + fx / (fvw / 2.0f);
-	fy = 1.0f - fy / (fvh / 2.0f);
+	fx = -1.0f + fx / (vid.width / 2.0f);
+	fy = 1.0f - fy / (vid.height / 2.0f);
 	fw = fw / (fvw / 2.0f);
 	fh = fh / (fvh / 2.0f);
 
@@ -1101,8 +1108,8 @@ void HWR_DrawFill(INT32 x, INT32 y, INT32 w, INT32 h, INT32 color)
 	if (fy + fh > vid.height)
 		fh = fvh - fy;
 
-	fx = -1.0f + fx / (fvw / 2.0f);
-	fy = 1.0f - fy / (fvh / 2.0f);
+	fx = -1.0f + fx / (vid.width / 2.0f);
+	fy = 1.0f - fy / (vid.height / 2.0f);
 	fw = fw / (fvw / 2.0f);
 	fh = fh / (fvh / 2.0f);
 

src/hardware/hw_gl.h

@@ -22,6 +22,7 @@
 #define SCREENVERTS 10
 
 boolean GL_Init(void);
+void GL_FinishUpdate(INT32 waitvbl);
 void SetupGLInfo(void);
 
 void GL_SetSpecialState(hwdspecialstate_t IdState, INT32 Value);
@@ -39,7 +40,6 @@ void GL_DrawModelEx(model_t *model, INT32 frameIndex, float duration, float tics
 
 void GL_RenderSkyDome(gl_sky_t *sky);
 
-void GL_UpdateTexture(GLMipmap_t *pTexInfo);
 void GL_SetTexture(GLMipmap_t *pTexInfo);
 void GL_DeleteTexture(GLMipmap_t *pTexInfo);
 

src/hardware/hw_glob.h

@@ -32,7 +32,7 @@ typedef struct gl_vissprite_s
 	float scale;
 	float spritexscale, spriteyscale;
 	float spritexoffset, spriteyoffset;
-	patch_t *gpatch;
+	GLPatch_t *gpatch;
 	boolean flip;
 	UINT8 translucency;       //alpha level 0-255
 	mobj_t *mobj;
@@ -51,43 +51,31 @@ void HWR_ObjectLightLevelPost(gl_vissprite_t *spr, const sector_t *sector, INT32
 extern extrasubsector_t *extrasubsectors;
 extern size_t addsubsector;
 
-void HWR_FreeExtraSubsectors(void);
-
 // --------
 // hw_cache.c
 // --------
-void HWR_InitMapTextures(void);
-void HWR_LoadMapTextures(size_t pnumtextures);
-void HWR_FreeMapTextures(void);
+void HWR_InitTextureCache(void);
+void HWR_FreeTextureCache(void);
+void HWR_FreeMipmapCache(void);
+void HWR_FreeExtraSubsectors(void);
 
-patch_t *HWR_GetCachedGLPatchPwad(UINT16 wad, UINT16 lump);
-patch_t *HWR_GetCachedGLPatch(lumpnum_t lumpnum);
-
-void HWR_GetPatch(patch_t *gpatch);
-void HWR_GetMappedPatch(patch_t *gpatch, const UINT8 *colormap);
-void HWR_MakePatch(const patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipmap, boolean makebitmap);
-void HWR_GetFadeMask(lumpnum_t fademasklumpnum);
-
-void HWR_PrecacheLevel(void);
-
-GLMapTexture_t *HWR_GetTexture(INT32 tex, boolean noencore);
 void HWR_GetFlat(lumpnum_t flatlumpnum, boolean noencoremap);
 // ^ some flats must NOT be remapped to encore, since we remap them as we cache them for ease, adding a toggle here seems wise.
 
-void HWR_FreeTexture(patch_t *patch);
-void HWR_FreeTextureData(patch_t *patch);
-void HWR_FreeTextureColormaps(patch_t *patch);
-void HWR_ClearAllTextures(void);
-void HWR_FreeColormapCache(void);
+GLMapTexture_t *HWR_GetTexture(INT32 tex, boolean noencore);
+void HWR_GetPatch(GLPatch_t *gpatch);
+void HWR_GetMappedPatch(GLPatch_t *gpatch, const UINT8 *colormap);
+void HWR_MakePatch(patch_t *patch, GLPatch_t *glPatch, GLMipmap_t *glMipmap, boolean makebitmap);
 void HWR_UnlockCachedPatch(GLPatch_t *gpatch);
-
-RGBA_t *HWR_GetTexturePalette(void);
 void HWR_SetPalette(RGBA_t *palette);
+
 void HWR_SetMapPalette(void);
 UINT32 HWR_CreateLightTable(UINT8 *lighttable);
 UINT32 HWR_GetLightTableID(extracolormap_t *colormap);
 void HWR_ClearLightTables(void);
-
+GLPatch_t *HWR_GetCachedGLPatchPwad(UINT16 wad, UINT16 lump);
+GLPatch_t *HWR_GetCachedGLPatch(lumpnum_t lumpnum);
+void HWR_GetFadeMask(lumpnum_t fademasklumpnum);
 
 // --------
 // hw_draw.c

src/hardware/hw_main.h

@@ -85,9 +85,9 @@ extern ps_metric_t ps_hw_batchdrawtime;
 extern boolean gl_shadersavailable;
 
 // hw_draw.c
-void HWR_DrawPatch(patch_t *gpatch, INT32 x, INT32 y, INT32 option);
-void HWR_DrawStretchyFixedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, fixed_t vscale, INT32 option, const UINT8 *colormap, INT32 bflags);
-void HWR_DrawCroppedPatch(patch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, INT32 option, fixed_t sx, fixed_t sy, fixed_t w, fixed_t h);
+void HWR_DrawPatch(GLPatch_t *gpatch, INT32 x, INT32 y, INT32 option);
+void HWR_DrawStretchyFixedPatch(GLPatch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, fixed_t vscale, INT32 option, const UINT8 *colormap, INT32 bflags);
+void HWR_DrawCroppedPatch(GLPatch_t *gpatch, fixed_t x, fixed_t y, fixed_t pscale, INT32 option, fixed_t sx, fixed_t sy, fixed_t w, fixed_t h);
 void HWR_DrawFill(INT32 x, INT32 y, INT32 w, INT32 h, INT32 color);
 void HWR_DrawConsoleFill(INT32 x, INT32 y, INT32 w, INT32 h, UINT32 color, INT32 options);	// Lat: separate flags from color since color needs to be an uint to work right.
 void HWR_DrawDiag(INT32 x, INT32 y, INT32 wh, INT32 color);
@@ -171,11 +171,13 @@ void HWR_ProcessSeg(void); // Sort of like GLWall::Process in GZDoom
 void HWR_CreatePlanePolygons(INT32 bspnum);
 extern boolean gl_maphasportals;
 
+// hw_cache.c
+void HWR_LoadTextures(size_t pnumtextures);
+RGBA_t *HWR_GetTexturePalette(void);
+
 // Console variables
 extern CV_PossibleValue_t glanisotropicmode_cons_t[];
 
-extern consvar_t cv_gltexturedepth;
-
 extern consvar_t cv_glscreentextures;
 #ifdef USE_FBO_OGL
 extern consvar_t cv_glframebuffer;

src/hardware/hw_md2.c

@@ -244,7 +244,7 @@ static GLTextureFormat_t PNG_Load(const char *filename, int *w, int *h, GLPatch_
 
 	{
 		png_uint_32 i, pitch = png_get_rowbytes(png_ptr, png_info_ptr);
-		png_bytep PNG_image = Z_Malloc(pitch*height, PU_HWRMODELTEXTURE, &glpatch->mipmap->data);
+		png_bytep PNG_image = Z_Malloc(pitch*height, PU_HWRCACHE, &glpatch->mipmap->data);
 		png_bytepp row_pointers = png_malloc(png_ptr, height * sizeof (png_bytep));
 		for (i = 0; i < height; i++)
 			row_pointers[i] = PNG_image + i*pitch;
@@ -324,7 +324,7 @@ static GLTextureFormat_t PCX_Load(const char *filename, int *w, int *h,
 
 	pw = *w = header.xmax - header.xmin + 1;
 	ph = *h = header.ymax - header.ymin + 1;
-	image = Z_Malloc(pw*ph*4, PU_HWRMODELTEXTURE, &glpatch->mipmap->data);
+	image = Z_Malloc(pw*ph*4, PU_HWRCACHE, &glpatch->mipmap->data);
 
 	if (fread(palette, sizeof (UINT8), PALSIZE, file) != PALSIZE)
 	{
@@ -366,56 +366,51 @@ static GLTextureFormat_t PCX_Load(const char *filename, int *w, int *h,
 // -----------------+
 static void md2_loadTexture(md2_t *model)
 {
-	patch_t *patch;
-	GLPatch_t *glPatch = NULL;
+	GLPatch_t *glpatch;
 	const char *filename = model->filename;
 
 	if (model->glpatch)
 	{
-		patch = model->glpatch;
-		glPatch = (GLPatch_t *)(patch->hardware);
-		if (glPatch)
-			Z_Free(glPatch->mipmap->data);
+		glpatch = model->glpatch;
+		Z_Free(glpatch->mipmap->data);
 	}
 	else
-		model->glpatch = patch = Patch_Create(NULL, 0, NULL);
+	{
+		glpatch = Z_Calloc(sizeof *glpatch, PU_HWRPATCHINFO,
+		                   &(model->glpatch));
+		glpatch->mipmap = Z_Calloc(sizeof (GLMipmap_t), PU_HWRPATCHINFO, NULL);
+	}
 
-	if (!patch->hardware)
-		Patch_AllocateHardwarePatch(patch);
-
-	if (glPatch == NULL)
-		glPatch = (GLPatch_t *)(patch->hardware);
-
-	if (!glPatch->mipmap->downloaded && !glPatch->mipmap->data)
+	if (!glpatch->mipmap->downloaded && !glpatch->mipmap->data)
 	{
 		int w = 0, h = 0;
 
 #ifdef HAVE_PNG
-		glPatch->mipmap->format = PNG_Load(filename, &w, &h, glPatch);
-		if (glPatch->mipmap->format == 0)
+		glpatch->mipmap->format = PNG_Load(filename, &w, &h, glpatch);
+		if (glpatch->mipmap->format == 0)
 #endif
-		glPatch->mipmap->format = PCX_Load(filename, &w, &h, glPatch);
-		if (glPatch->mipmap->format == 0)
+		glpatch->mipmap->format = PCX_Load(filename, &w, &h, glpatch);
+		if (glpatch->mipmap->format == 0)
 		{
-			glPatch->notfound = true;// mark it so its not searched for again repeatedly
+			glpatch->notfound = true;// mark it so its not searched for again repeatedly
 			return;
 		}
 
-		glPatch->mipmap->downloaded = 0;
-		glPatch->mipmap->flags = 0;
-
-		patch->width = (INT16)w;
-		patch->height = (INT16)h;
-		glPatch->mipmap->width = (UINT16)w;
-		glPatch->mipmap->height = (UINT16)h;
+		glpatch->mipmap->downloaded = 0;
+		glpatch->mipmap->flags = 0;
 
+		glpatch->width = (INT16)w;
+		glpatch->height = (INT16)h;
+		glpatch->mipmap->width = (UINT16)w;
+		glpatch->mipmap->height = (UINT16)h;
+		
 		// for palette rendering, color cube is applied in post-processing instead of here
 		if (!HWR_ShouldUsePaletteRendering())
 		{
 			UINT32 size;
 			RGBA_t *image;
 			// Lactozilla: Apply colour cube
-			image = glPatch->mipmap->data;
+			image = glpatch->mipmap->data;
 			size = w*h;
 			while (size--)
 			{
@@ -424,8 +419,8 @@ static void md2_loadTexture(md2_t *model)
 			}
 		}
 	}
-	GL_SetTexture(glPatch->mipmap);
-	HWR_UnlockCachedPatch(glPatch);
+	GL_SetTexture(glpatch->mipmap);
+	HWR_UnlockCachedPatch(glpatch);
 }
 
 // -----------------+
@@ -433,56 +428,49 @@ static void md2_loadTexture(md2_t *model)
 // -----------------+
 static void md2_loadBlendTexture(md2_t *model)
 {
-	patch_t *patch;
-	GLPatch_t *glPatch = NULL;
-
+	GLPatch_t *glpatch;
 	char *filename = Z_Malloc(strlen(model->filename)+7, PU_STATIC, NULL);
-
 	strcpy(filename, model->filename);
 
 	FIL_ForceExtension(filename, "_blend.png");
 
 	if (model->blendglpatch)
 	{
-		patch = model->blendglpatch;
-		glPatch = (GLPatch_t *)(patch->hardware);
-		if (glPatch)
-			Z_Free(glPatch->mipmap->data);
+		glpatch = model->blendglpatch;
+		Z_Free(glpatch->mipmap->data);
 	}
 	else
-		model->blendglpatch = patch = Patch_Create(NULL, 0, NULL);
+	{
+		glpatch = Z_Calloc(sizeof *glpatch, PU_HWRPATCHINFO,
+		                   &(model->blendglpatch));
+		glpatch->mipmap = Z_Calloc(sizeof (GLMipmap_t), PU_HWRPATCHINFO, NULL);
+	}
 
-	if (!patch->hardware)
-		Patch_AllocateHardwarePatch(patch);
-
-	if (glPatch == NULL)
-		glPatch = (GLPatch_t *)(patch->hardware);
-
-	if (!glPatch->mipmap->downloaded && !glPatch->mipmap->data)
+	if (!glpatch->mipmap->downloaded && !glpatch->mipmap->data)
 	{
 		int w = 0, h = 0;
 #ifdef HAVE_PNG
-		glPatch->mipmap->format = PNG_Load(filename, &w, &h, glPatch);
-		if (glPatch->mipmap->format == 0)
+		glpatch->mipmap->format = PNG_Load(filename, &w, &h, glpatch);
+		if (glpatch->mipmap->format == 0)
 #endif
-		glPatch->mipmap->format = PCX_Load(filename, &w, &h, glPatch);
-		if (glPatch->mipmap->format == 0)
+		glpatch->mipmap->format = PCX_Load(filename, &w, &h, glpatch);
+		if (glpatch->mipmap->format == 0)
 		{
-			glPatch->notfound = true;// mark it so its not searched for again repeatedly
+			glpatch->notfound = true;// mark it so its not searched for again repeatedly
 			Z_Free(filename);
 			return;
 		}
 
-		glPatch->mipmap->downloaded = 0;
-		glPatch->mipmap->flags = 0;
+		glpatch->mipmap->downloaded = 0;
+		glpatch->mipmap->flags = 0;
 
-		patch->width = (INT16)w;
-		patch->height = (INT16)h;
-		glPatch->mipmap->width = (UINT16)w;
-		glPatch->mipmap->height = (UINT16)h;
+		glpatch->width = (INT16)w;
+		glpatch->height = (INT16)h;
+		glpatch->mipmap->width = (UINT16)w;
+		glpatch->mipmap->height = (UINT16)h;
 	}
-	GL_SetTexture(glPatch->mipmap); // We do need to do this so that it can be cleared and knows to recreate it when necessary
-	HWR_UnlockCachedPatch(glPatch);
+	GL_SetTexture(glpatch->mipmap); // We do need to do this so that it can be cleared and knows to recreate it when necessary
+	HWR_UnlockCachedPatch(glpatch);
 
 	Z_Free(filename);
 }
@@ -619,7 +607,7 @@ void HWR_AddPlayerMD2(int skin, boolean local) // For MD2's that were added afte
 	// Check for any MD2s that match the names of player skins!
 	while (fscanf(f, "%19s %31s %f %f", name, filename, &scale, &offset) == 4)
 	{
-		if (stricmp(name, K_GetSkinArray(local)[skin].name) == 0)
+		if (stricmp(name, ( (local) ? localskins : skins )[skin].name) == 0)
 		{
 			md2s[skin].skin = skin;
 			md2s[skin].scale = scale;
@@ -694,10 +682,8 @@ spritemd2found:
 #define SETBRIGHTNESS(brightness,r,g,b) \
 	brightness = (UINT8)(((1063*(UINT32)(r))/5000) + ((3576*(UINT32)(g))/5000) + ((361*(UINT32)(b))/5000))
 
-static void HWR_CreateBlendedTexture(patch_t *gpatch, patch_t *blendgpatch, GLMipmap_t *glMipmap, INT32 skinnum, skincolors_t color)
+static void HWR_CreateBlendedTexture(GLPatch_t *gpatch, GLPatch_t *blendgpatch, GLMipmap_t *glMipmap, INT32 skinnum, skincolors_t color)
 {
-	GLPatch_t *hwrPatch = gpatch->hardware;
-	GLPatch_t *hwrBlendPatch = blendgpatch->hardware;
 	UINT16 w = gpatch->width, h = gpatch->height;
 	UINT32 size = w*h;
 	RGBA_t *image, *blendimage, *cur, blendcolor;
@@ -729,11 +715,11 @@ static void HWR_CreateBlendedTexture(patch_t *gpatch, patch_t *blendgpatch, GLMi
 		glMipmap->data = NULL;
 	}
 
-	cur = Z_Malloc(size*4, PU_HWRMODELTEXTURE, &glMipmap->data);
+	cur = Z_Malloc(size*4, PU_HWRCACHE, &glMipmap->data);
 	memset(cur, 0x00, size*4);
 
-	image = hwrPatch->mipmap->data;
-	blendimage = hwrBlendPatch->mipmap->data;
+	image = gpatch->mipmap->data;
+	blendimage = blendgpatch->mipmap->data;
 
 	// TC_METALSONIC includes an actual skincolor translation, on top of its flashing.
 	if (skinnum == TC_METALSONIC)
@@ -1056,51 +1042,32 @@ skippixel:
 
 #undef SETBRIGHTNESS
 
-static void HWR_GetBlendedTexture(patch_t *patch, patch_t *blendgpatch, INT32 skinnum, const UINT8 *colormap, skincolors_t color)
+static void HWR_GetBlendedTexture(GLPatch_t *gpatch, GLPatch_t *blendgpatch, INT32 skinnum, const UINT8 *colormap, skincolors_t color)
 {
 	// mostly copied from HWR_GetMappedPatch, hence the similarities and comment
-	GLPatch_t *glPatch = patch->hardware;
-	GLPatch_t *glBlendPatch = NULL;
 	GLMipmap_t *glMipmap, *newMipmap;
 
-
-	if (blendgpatch == NULL || colormap == colormaps || colormap == NULL)
+	if (colormap == colormaps || colormap == NULL)
 	{
 		// Don't do any blending
-		GL_SetTexture(glPatch->mipmap);
-		return;
-	}
-
-	if ((blendgpatch && (glBlendPatch = blendgpatch->hardware) && glBlendPatch->mipmap->format)
-		&& (patch->width != blendgpatch->width || patch->height != blendgpatch->height))
-	{
-		// Blend image exists, but it's bad.
-		GL_SetTexture(glPatch->mipmap);
+		GL_SetTexture(gpatch->mipmap);
 		return;
 	}
 
 	// search for the Mipmap
 	// skip the first (no colormap translated)
-	for (glMipmap = glPatch->mipmap; glMipmap->nextcolormap; )
+	for (glMipmap = gpatch->mipmap; glMipmap->nextcolormap; )
 	{
 		glMipmap = glMipmap->nextcolormap;
 
-		if (glMipmap->colormap && glMipmap->colormap->source == colormap)
-		{
-			if (glMipmap->downloaded && glMipmap->data)
-			{
-				if (memcmp(glMipmap->colormap->data, colormap, 256 * sizeof(UINT8)))
-				{
-					M_Memcpy(glMipmap->colormap->data, colormap, 256 * sizeof(UINT8));
-					HWR_CreateBlendedTexture(patch, blendgpatch, glMipmap, skinnum, color);
-					GL_UpdateTexture(glMipmap);
-				}
-				else
-					GL_SetTexture(glMipmap); // found the colormap, set it to the correct texture
+		if (glMipmap->colormap != colormap)
+			continue;
 
-				Z_ChangeTag(glMipmap->data, PU_HWRMODELTEXTURE_UNLOCKED);
-				return;
-			}
+		if (glMipmap->downloaded && glMipmap->data)
+		{
+			GL_SetTexture(glMipmap); // found the colormap, set it to the correct texture
+			Z_ChangeTag(glMipmap->data, PU_HWRCACHE_UNLOCKED);
+			return;
 		}
 	}
 
@@ -1113,17 +1080,14 @@ static void HWR_GetBlendedTexture(patch_t *patch, patch_t *blendgpatch, INT32 sk
 	//    (...) unfortunately z_malloc fragment alot the memory :(so malloc is better
 	newMipmap = calloc(1, sizeof (*newMipmap));
 	if (newMipmap == NULL)
-		I_Error("%s: Out of memory", "HWR_GetBlendedTexture");
+		I_Error("%s: Out of memory", "HWR_GetMappedPatch");
 	glMipmap->nextcolormap = newMipmap;
+	newMipmap->colormap = colormap;
 
-	newMipmap->colormap = Z_Calloc(sizeof(*newMipmap->colormap), PU_HWRPATCHCOLMIPMAP, NULL);
-	newMipmap->colormap->source = colormap;
-	M_Memcpy(newMipmap->colormap->data, colormap, 256 * sizeof(UINT8));
-
-	HWR_CreateBlendedTexture(patch, blendgpatch, newMipmap, skinnum, color);
+	HWR_CreateBlendedTexture(gpatch, blendgpatch, newMipmap, skinnum, color);
 
 	GL_SetTexture(newMipmap);
-	Z_ChangeTag(newMipmap->data, PU_HWRMODELTEXTURE_UNLOCKED);
+	Z_ChangeTag(newMipmap->data, PU_HWRCACHE_UNLOCKED);
 }
 
 // -----------------+
@@ -1190,8 +1154,7 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 
 	// Look at HWR_ProjectSprite for more
 	{
-		patch_t *gpatch, *blendgpatch;
-		GLPatch_t *hwrPatch = NULL, *hwrBlendPatch = NULL;
+		GLPatch_t *gpatch;
 		INT32 durs = spr->mobj->state->tics;
 		INT32 tics = spr->mobj->tics;
 		//mdlframe_t *next = NULL;
@@ -1216,13 +1179,13 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 		// Apparently people don't like jump frames like that, so back it goes
 		//if (tics > durs)
 			//durs = tics;
-
+		
 		INT32 blendmode;
 		if (spr->mobj->frame & FF_BLENDMASK)
 			blendmode = ((spr->mobj->frame & FF_BLENDMASK) >> FF_BLENDSHIFT) + 1;
 		else
 			blendmode = spr->mobj->blendmode;
-
+		
 		blendmode = min(AST_MODULATE, blendmode);
 
 		if (spr->mobj->flags2 & MF2_SHADOW)
@@ -1244,7 +1207,7 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 
 		// dont forget to enabled the depth test because we can't do this like
 		// before: polygons models are not sorted
-
+		
 		/* fuck you */
 		if (spr->mobj->localskin)
 		{
@@ -1301,36 +1264,21 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 		}
 		//Hurdler: arf, I don't like that implementation at all... too much crappy
 		gpatch = md2->glpatch;
-		if (gpatch)
-			hwrPatch = ((GLPatch_t *)gpatch->hardware);
-
-		if (!gpatch || !hwrPatch
-		|| ((!hwrPatch->mipmap->format || !hwrPatch->mipmap->downloaded) && !hwrPatch->notfound))
+		if (!gpatch || ((!gpatch->mipmap->format || !gpatch->mipmap->downloaded) && !gpatch->notfound))
 			md2_loadTexture(md2);
+		gpatch = md2->glpatch; // Load it again, because it isn't being loaded into gpatch after md2_loadtexture...
 
-		// Load it again, because it isn't being loaded into gpatch after md2_loadtexture...
-		gpatch = md2->glpatch;
-		if (gpatch)
-			hwrPatch = ((GLPatch_t *)gpatch->hardware);
-
-		// Load blend texture
-		blendgpatch = md2->blendglpatch;
-		if (blendgpatch)
-			hwrBlendPatch = ((GLPatch_t *)blendgpatch->hardware);
-
-		if ((gpatch && hwrPatch && hwrPatch->mipmap->format) // don't load the blend texture if the base texture isn't available
-			&& (!blendgpatch || !hwrBlendPatch
-			|| ((!hwrBlendPatch->mipmap->format || !hwrBlendPatch->mipmap->downloaded) && !hwrPatch->notfound)))
+		if ((gpatch && gpatch->mipmap->format) // don't load the blend texture if the base texture isn't available
+			&& (!md2->blendglpatch
+			|| ((!((GLPatch_t *)md2->blendglpatch)->mipmap->format || !((GLPatch_t *)md2->blendglpatch)->mipmap->downloaded)
+			&& !((GLPatch_t *)md2->blendglpatch)->notfound)))
 			md2_loadBlendTexture(md2);
 
-		// Load it again, because it isn't being loaded into blendgpatch after md2_loadblendtexture...
-		blendgpatch = md2->blendglpatch;
-		if (blendgpatch)
-			hwrBlendPatch = ((GLPatch_t *)blendgpatch->hardware);
-
-		if (gpatch && hwrPatch && hwrPatch->mipmap->format) // else if meant that if a texture couldn't be loaded, it would just end up using something else's texture
+		if (gpatch && gpatch->mipmap->format) // else if meant that if a texture couldn't be loaded, it would just end up using something else's texture
 		{
-			if ((skincolors_t)spr->mobj->color != SKINCOLOR_NONE)
+			if ((skincolors_t)spr->mobj->color != SKINCOLOR_NONE &&
+				md2->blendglpatch && ((GLPatch_t *)md2->blendglpatch)->mipmap->format
+				&& gpatch->width == ((GLPatch_t *)md2->blendglpatch)->width && gpatch->height == ((GLPatch_t *)md2->blendglpatch)->height)
 			{
 				INT32 tcskinnum = TC_DEFAULT;
 				if ((spr->mobj->flags & MF_BOSS) && (spr->mobj->flags2 & MF2_FRET) && (leveltime & 1)) // Bosses "flash"
@@ -1350,24 +1298,24 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 							tcskinnum = TC_RAINBOW;
 						else
 						{
-							tcskinnum = (INT32)(K_GetMobjSkinNum(K_GetMobjSkin(spr->mobj), spr->mobj->skinlocal));
+							tcskinnum = (INT32)((skin_t*)( (spr->mobj->localskin) ? spr->mobj->localskin : spr->mobj->skin ) - ( (spr->mobj->skinlocal) ? localskins : skins ));
 						}
 					}
 					else tcskinnum = TC_DEFAULT;
 				}
-
-				HWR_GetBlendedTexture(gpatch, blendgpatch, tcskinnum, spr->colormap, (skincolors_t)spr->mobj->color);
+				HWR_GetBlendedTexture(gpatch, (GLPatch_t *)md2->blendglpatch, tcskinnum, spr->colormap, (skincolors_t)spr->mobj->color);
 			}
 			else
 			{
 				// This is safe, since we know the texture has been downloaded
-				GL_SetTexture(hwrPatch->mipmap);
+				GL_SetTexture(gpatch->mipmap);
 			}
 		}
 		else
 		{
 			// Sprite
-			HWR_GetMappedPatch(spr->gpatch, spr->colormap);
+			gpatch = spr->gpatch; //gpatch = W_CachePatchNum(spr->patchlumpnum, PU_CACHE);
+			HWR_GetMappedPatch(gpatch, spr->colormap);
 		}
 
 		if (spr->mobj->frame & FF_ANIMATE)
@@ -1416,8 +1364,8 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 		else
 			p.z = FIXED_TO_FLOAT(interp.z);
 
-		if ((spr->mobj->skin || spr->mobj->localskin) && spr->mobj->sprite == SPR_PLAY)
-			sprdef = &K_GetMobjSkin(spr->mobj)->spritedef;
+		if (spr->mobj->skin && spr->mobj->sprite == SPR_PLAY)
+			sprdef = &((skin_t *)( (spr->mobj->localskin) ? spr->mobj->localskin : spr->mobj->skin ))->spritedef;
 		else
 			sprdef = &sprites[spr->mobj->sprite];
 

src/hardware/r_opengl/r_opengl.c

@@ -99,14 +99,14 @@ static GLuint screenPaletteTex = 0; // 1D texture containing the screen palette
 static GLuint paletteLookupTex = 0; // 3D texture containing RGB -> palette index lookup table
 RGBA_t  myPaletteData[256]; // the palette for converting textures to RGBA
 
-static GLint gltexformat = GL_RGB5_A1;
-GLint   screen_width     = 0;               // used by Draw2DLine()
-GLint   screen_height    = 0;
-GLbyte  screen_depth     = 0;
-GLint maximumAnisotropy  = 0;
-static GLboolean MipMap  = GL_FALSE;
-static GLint min_filter  = GL_LINEAR;
-static GLint mag_filter  = GL_LINEAR;
+GLint   screen_width    = 0;               // used by Draw2DLine()
+GLint   screen_height   = 0;
+GLbyte  screen_depth    = 0;
+GLint   textureformatGL = 0;
+GLint maximumAnisotropy = 0;
+static GLboolean MipMap = GL_FALSE;
+static GLint min_filter = GL_LINEAR;
+static GLint mag_filter = GL_LINEAR;
 static GLint anisotropic_filter = 0;
 boolean supportMipMap = false;
 
@@ -191,7 +191,7 @@ FUNCPRINTF void GL_DBG_Printf(const char *format, ...)
 
 	if (!gllogstream)
 		gllogstream = fopen("ogllog.txt", "w");
-
+	
 	va_start(arglist, format);
 	vsnprintf(str, 4096, format, arglist);
 	va_end(arglist);
@@ -673,7 +673,7 @@ typedef enum
 	gluniform_light_dir,
 	gluniform_light_contrast,
 	gluniform_light_backlight,
-
+	
 	// palette rendering
 	gluniform_palette_tex, // 1d texture containing a palette
 	gluniform_palette_lookup_tex, // 3d texture containing the rgb->index lookup table
@@ -743,7 +743,7 @@ void SetupGLFunc4(void)
 	pglMultiTexCoord2f = GetGLFunc("glMultiTexCoord2f");
 	pglClientActiveTexture = GetGLFunc("glClientActiveTexture");
 	pglMultiTexCoord2fv = GetGLFunc("glMultiTexCoord2fv");
-
+	
 	/* 1.5 funcs */
 	pglGenBuffers = GetGLFunc("glGenBuffers");
 	pglBindBuffer = GetGLFunc("glBindBuffer");
@@ -753,7 +753,7 @@ void SetupGLFunc4(void)
 
 	/* 2.0 funcs */
 	pglBlendEquation = GetGLFunc("glBlendEquation");
-
+	
 	pglStencilFuncSeparate = GetGLFunc("glStencilFuncSeparate");
 	pglStencilOpSeparate = GetGLFunc("glStencilOpSeparate");
 
@@ -809,7 +809,7 @@ boolean GL_InitShaders(void)
 {
 	if (!pglUseProgram)
 		return false;
-
+	
 	gl_fallback_shader.vertex_shader = Z_StrDup(GLSL_FALLBACK_VERTEX_SHADER);
 	gl_fallback_shader.fragment_shader = Z_StrDup(GLSL_FALLBACK_FRAGMENT_SHADER);
 
@@ -1529,7 +1529,7 @@ void GL_SetBlend(FBITFIELD PolyFlags)
 {
 	const FBITFIELD Xor = CurrentPolyFlags^PolyFlags;;
 
-	if (Xor & (PF_Blending|PF_RemoveYWrap|PF_ForceWrapX|PF_ForceWrapY|PF_Occlude|PF_NoTexture|PF_Modulated|PF_NoDepthTest|PF_Decal|PF_Skydecal|PF_Invisible))
+	if (Xor & (PF_Blending|PF_RemoveYWrap|PF_ForceWrapX|PF_ForceWrapY|PF_Occlude|PF_NoTexture|PF_Modulated|PF_NoDepthTest|PF_Decal|PF_Invisible))
 	{
 		if (Xor & PF_Blending) // if blending mode must be changed
 			GL_SetBlendMode(PolyFlags & PF_Blending);
@@ -1545,21 +1545,7 @@ void GL_SetBlend(FBITFIELD PolyFlags)
 		if (Xor & PF_Decal)
 		{
 			if (PolyFlags & PF_Decal)
-			{
-				pglPolygonOffset(-1.0f, -1.0f);
 				pglEnable(GL_POLYGON_OFFSET_FILL);
-			}
-			else
-				pglDisable(GL_POLYGON_OFFSET_FILL);
-		}
-
-		if (Xor & PF_Skydecal)
-		{
-			if (PolyFlags & PF_Skydecal)
-			{
-				pglPolygonOffset(0.45f, 0.45f);
-				pglEnable(GL_POLYGON_OFFSET_FILL);
-			}
 			else
 				pglDisable(GL_POLYGON_OFFSET_FILL);
 		}
@@ -1657,7 +1643,7 @@ static void GL_AllocTextureBuffer(GLMipmap_t *pTexInfo)
 // -----------------+
 // UpdateTexture    : Updates texture data.
 // -----------------+
-void GL_UpdateTexture(GLMipmap_t *pTexInfo)
+static void GL_UpdateTexture(GLMipmap_t *pTexInfo)
 {
 	// Upload a texture
 	GLuint num = pTexInfo->downloaded;
@@ -1683,10 +1669,9 @@ void GL_UpdateTexture(GLMipmap_t *pTexInfo)
 
 	//GL_DBG_Printf("UpdateTexture %d %x\n", (INT32)num, pImgData);
 
-	texformat = gltexformat;
-	const GLTextureFormat_t texinfoformat = pTexInfo->format;
+	texformat = textureformatGL;
 
-	switch (texinfoformat)
+	switch (pTexInfo->format)
 	{
 		case GL_TEXFMT_P_8:
 		case GL_TEXFMT_AP_88:
@@ -1711,7 +1696,7 @@ void GL_UpdateTexture(GLMipmap_t *pTexInfo)
 
 					pImgData++;
 
-					if (texinfoformat != GL_TEXFMT_AP_88)
+					if (pTexInfo->format != GL_TEXFMT_AP_88)
 						continue;
 					if (chromakeyed)
 						continue;
@@ -1759,7 +1744,7 @@ void GL_UpdateTexture(GLMipmap_t *pTexInfo)
 			}
 			break;
 		default:
-			GL_MSG_Warning("UpdateTexture: bad format %d\n", texinfoformat);
+			GL_MSG_Warning("UpdateTexture: bad format %d\n", pTexInfo->format);
 			break;
 	}
 
@@ -1782,8 +1767,6 @@ void GL_UpdateTexture(GLMipmap_t *pTexInfo)
 
 	if (MipMap && !transparent) // No mipmaps on transparent stuff
 	{
-		int maxlod = (texformat == GL_LUMINANCE_ALPHA || texformat == GL_ALPHA) ? 4 : 5;
-
 		pglTexParameteri(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, GL_TRUE);
 
 		if (update)
@@ -1793,7 +1776,7 @@ void GL_UpdateTexture(GLMipmap_t *pTexInfo)
 
 		// Control the mipmap level of detail
 		pglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_LOD, 0);
-		pglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAX_LOD, maxlod);
+		pglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAX_LOD, 4);
 	}
 	else
 	{
@@ -2038,7 +2021,7 @@ static boolean GL_Shader_CompileProgram(gl_shader_t *shader, GLint i)
 		pglDeleteShader(gl_vertShader);
 	if (frag_shader)
 		pglDeleteShader(gl_fragShader);
-
+	
 	// couldn't link?
 	if (result != GL_TRUE)
 	{
@@ -2322,12 +2305,7 @@ void GL_SetSpecialState(hwdspecialstate_t IdState, INT32 Value)
 
 			GL_Flush(); //??? if we want to change filter mode by texture, remove this
 			break;
-
-		case HWD_SET_TEXTURE_FORMAT:
-			gltexformat = (Value == 32) ? GL_RGBA : GL_RGB5_A1;
-			GL_Flush();
-			break;
-
+			
 		case HWD_SET_MSAA:
 			if (Value)
 			{
@@ -2637,7 +2615,7 @@ void GL_DrawModelEx(model_t *model, INT32 frameIndex, float duration, float tics
 	scalex = hscale;
 	scaley = vscale;
 	scalez = hscale;
-
+	
 	if (duration > 0.0 && tics >= 0.0) // don't interpolate if instantaneous or infinite in length
 	{
 		float newtime = (duration - tics); // + 1;
@@ -2706,7 +2684,7 @@ void GL_DrawModelEx(model_t *model, INT32 frameIndex, float duration, float tics
 	pglRotatef(pos->anglez, 0.0f, 0.0f, -1.0f);
 	pglRotatef(pos->anglex, 1.0f, 0.0f, 0.0f);
 	pglRotatef(pos->angley, 0.0f, -1.0f, 0.0f);
-
+	
 	if (pos->roll)
 	{
 		pglTranslatef(pos->centerx, pos->centery, 0);
@@ -2909,7 +2887,7 @@ INT32 GL_GetTextureUsed(void)
 		res += tmp->height*tmp->width*bpp;
 		tmp = tmp->next;
 	}
-
+	
 	return res;
 }
 
@@ -2927,8 +2905,8 @@ void GL_PostImgRedraw(float points[SCREENVERTS][SCREENVERTS][2])
 		16.0f, 16.0f, 6.0f,
 		16.0f, -16.0f, 6.0f
 	};
-
-	if (gl_enable_screen_textures != 2)
+	
+	if (gl_enable_screen_textures != 2) 
 		return;
 
 	// look for power of two that is large enough for the screen
@@ -2944,7 +2922,6 @@ void GL_PostImgRedraw(float points[SCREENVERTS][SCREENVERTS][2])
 
 	pglDisable(GL_DEPTH_TEST);
 	pglDisable(GL_BLEND);
-	pglDisableClientState(GL_TEXTURE_COORD_ARRAY);
 
 	// Draw a black square behind the screen texture,
 	// so nothing shows through the edges
@@ -2952,8 +2929,8 @@ void GL_PostImgRedraw(float points[SCREENVERTS][SCREENVERTS][2])
 
 	pglVertexPointer(3, GL_FLOAT, 0, blackBack);
 	pglDrawArrays(GL_TRIANGLE_FAN, 0, 4);
-	pglEnableClientState(GL_TEXTURE_COORD_ARRAY);
 
+	pglEnableClientState(GL_TEXTURE_COORD_ARRAY);
 	for(x = 0; x < SCREENVERTS-1;x ++)
 	{
 		for(y = 0; y < SCREENVERTS-1; y++)
@@ -3025,8 +3002,8 @@ void GL_DrawScreenTexture(int tex, FSurfaceInfo *surf, FBITFIELD polyflags)
 	};
 
 	float fix[8];
-
-	if (gl_enable_screen_textures != 2)
+	
+	if (gl_enable_screen_textures != 2) 
 		return;
 
 	// look for power of two that is large enough for the screen
@@ -3054,7 +3031,7 @@ void GL_DrawScreenTexture(int tex, FSurfaceInfo *surf, FBITFIELD polyflags)
 	pglClear(GL_COLOR_BUFFER_BIT|GL_DEPTH_BUFFER_BIT);
 
 	pglBindTexture(GL_TEXTURE_2D, screenTextures[tex]);
-
+	
 	GL_PreparePolygon(surf, surf ? polyflags : (PF_NoDepthTest));
 	if (!surf)
 		pglColor4ubv(white);
@@ -3093,7 +3070,7 @@ void GL_DoScreenWipe(int wipeStart, int wipeEnd)
 		1.0f, 1.0f
 	};
 
-	if (!gl_enable_screen_textures)
+	if (!gl_enable_screen_textures) 
 		return;
 
 	// look for power of two that is large enough for the screen
@@ -3144,6 +3121,8 @@ void GL_DoScreenWipe(int wipeStart, int wipeEnd)
 
 	pglTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE);
 
+	// const float defaultST[8]
+
 	pglClientActiveTexture(GL_TEXTURE0);
 	pglTexCoordPointer(2, GL_FLOAT, 0, fix);
 	pglVertexPointer(3, GL_FLOAT, 0, screenVerts);
@@ -3177,7 +3156,7 @@ void GL_RenderVhsEffect(fixed_t upbary, fixed_t downbary, UINT8 updistort, UINT8
 		1.0f, -1.0f, 1.0f
 	};
 
-	if (gl_enable_screen_textures != 2)
+	if (gl_enable_screen_textures != 2) 
 		return;
 
 	// look for power of two that is large enough for the screen
@@ -3274,7 +3253,7 @@ void GL_MakeScreenTexture(int tex)
 {
 	INT32 texsizew = 512, texsizey = 512;
 	boolean firstTime = (screenTextures[tex] == 0);
-
+	
 	if (!gl_enable_screen_textures)
 		return;
 
@@ -3314,7 +3293,7 @@ void GL_DrawScreenFinalTexture(int tex, INT32 width, INT32 height, boolean usesh
 
 	float off[12];
 	float fix[8];
-
+	
 	if (gl_enable_screen_textures != 2)
 		return;
 
@@ -3405,7 +3384,7 @@ void GL_SetPaletteLookup(UINT8 *lut)
 	{
 		internalFormat = GL_R8;
 	}
-
+	
 	if (!paletteLookupTex)
 		pglGenTextures(1, &paletteLookupTex);
 	pglActiveTexture(GL_TEXTURE1);
@@ -3454,7 +3433,7 @@ void GL_ClearLightTables(void)
 	}
 
 	LightTablesTail = NULL;
-
+	
 	// we no longer have a bound light table (if we had one), we just deleted it!
 	lt_downloaded = 0;
 }

src/hardware/r_opengl/r_opengl.h

@@ -136,6 +136,7 @@ extern boolean 			supportMipMap;
 /**	\brief OpenGL flags for video driver
 */
 extern INT32            oglflags;
+extern GLint            textureformatGL;
 
 extern GLfloat projMatrix[16];
 

src/hu_stuff.c

@@ -169,7 +169,7 @@ char french_shiftxform[] =
 	31,
 	' ','$', //shift-!
 	'3', //shift-"
-	'#', '$', '%',
+	'#', '$', '%', 
 	'1', //shift-&
 	'4', // shift-'
 	'5', // shift-(
@@ -179,7 +179,7 @@ char french_shiftxform[] =
 	'6', // shift--
 	'.', '/',
 	'0', '1', '2', '3', '4', '5',
-	'6', '7', '8', '9',
+	'6', '7', '8', '9', 
 	'/', // shitf-:
 	'.', // shift-;
 	'>', // shift-<
@@ -222,7 +222,7 @@ char french_altgrxform[] =
 	'|', //altg--
 	'.', '/',
 	'0', '1', '2', '3', '4', '5',
-	'6', '7', '8', '9',
+	'6', '7', '8', '9', 
 	':', ';', '<',
 	'}', //altgr-=
 	'>', '?', '@',
@@ -914,9 +914,12 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
 			player_names[playernum]);
 		if (server)
 		{
-			SendKick(playernum, KICK_MSG_CON_FAIL);
-		}
+			UINT8 buf[2];
 
+			buf[0] = (UINT8)playernum;
+			buf[1] = KICK_MSG_CON_FAIL;
+			SendNetXCmd(XD_KICK, &buf, 2);
+		}
 		return;
 	}
 
@@ -931,7 +934,11 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
 				CONS_Alert(CONS_WARNING, M_GetText("Illegal say command received from %s containing invalid characters\n"), player_names[playernum]);
 				if (server)
 				{
-					SendKick(playernum, KICK_MSG_CON_FAIL);
+					char buf[2];
+
+					buf[0] = (char)playernum;
+					buf[1] = KICK_MSG_CON_FAIL;
+					SendNetXCmd(XD_KICK, &buf, 2);
 				}
 				return;
 			}
@@ -1140,10 +1147,10 @@ void HU_Ticker(void)
 	}
 
 	if (cechotimer > 0) --cechotimer;
-
+	
 	// Animate the desynch dots
 	if (hu_resynching
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 		|| hu_redownloadinggamestate
 #endif
 		)
@@ -1315,7 +1322,7 @@ boolean HU_Responder(event_t *ev)
 		INT32 i;
 		for (i = 0; i < num_gamecontrols; i++)
 		{
-			if (gamecontrol[0][i][0] == ev->data1 || gamecontrol[0][i][1] == ev->data1)
+			if (gamecontrol[i][0] == ev->data1 || gamecontrol[i][1] == ev->data1)
 				break;
 		}
 
@@ -1327,7 +1334,7 @@ boolean HU_Responder(event_t *ev)
 	if (!chat_on)
 	{
 		// enter chat mode
-		if ((ev->data1 == gamecontrol[0][gc_talkkey][0] || ev->data1 == gamecontrol[0][gc_talkkey][1])
+		if ((ev->data1 == gamecontrol[gc_talkkey][0] || ev->data1 == gamecontrol[gc_talkkey][1])
 			&& netgame && !OLD_MUTE) // check for old chat mute, still let the players open the chat incase they want to scroll otherwise.
 		{
 			chat_on = true;
@@ -1338,7 +1345,7 @@ boolean HU_Responder(event_t *ev)
 			typelines = 1;
 			return true;
 		}
-		if ((ev->data1 == gamecontrol[0][gc_teamkey][0] || ev->data1 == gamecontrol[0][gc_teamkey][1])
+		if ((ev->data1 == gamecontrol[gc_teamkey][0] || ev->data1 == gamecontrol[gc_teamkey][1])
 			&& netgame && !OLD_MUTE)
 		{
 			chat_on = true;
@@ -1364,8 +1371,8 @@ boolean HU_Responder(event_t *ev)
 
 		// Ignore non-keyboard keys, except when the talk key is bound
 		if (ev->data1 >= KEY_MOUSE1
-		&& (ev->data1 != gamecontrol[0][gc_talkkey][0]
-		&& ev->data1 != gamecontrol[0][gc_talkkey][1]))
+		&& (ev->data1 != gamecontrol[gc_talkkey][0]
+		&& ev->data1 != gamecontrol[gc_talkkey][1]))
 			return false;
 
 		M_TextInputHandle(&w_chat, c);
@@ -1377,8 +1384,8 @@ boolean HU_Responder(event_t *ev)
 			HU_SendChatMessage();
 		}
 		else if (c == KEY_ESCAPE
-			|| ((c == gamecontrol[0][gc_talkkey][0] || c == gamecontrol[0][gc_talkkey][1]
-			|| c == gamecontrol[0][gc_teamkey][0] || c == gamecontrol[0][gc_teamkey][1])
+			|| ((c == gamecontrol[gc_talkkey][0] || c == gamecontrol[gc_talkkey][1]
+			|| c == gamecontrol[gc_teamkey][0] || c == gamecontrol[gc_teamkey][1])
 			&& c >= KEY_MOUSE1)) // If it's not a keyboard key, then the chat button is used as a toggle.
 		{
 			chat_on = false;
@@ -1861,8 +1868,7 @@ static void HU_DrawChat(void)
 	if (strnicmp(w_chat_buf, "/pm", 3) == 0 && vid.width >= 400 && !teamtalk) // 320x200 unsupported kthxbai
 	{
 		INT32 count = 0;
-		INT32 p_dispy = chaty - charheight - 1;
-		size_t longest_name_length = 0;
+		INT32 p_dispy = chaty - charheight -1;
 #ifdef NETSPLITSCREEN
 		if (splitscreen)
 		{
@@ -1874,33 +1880,27 @@ static void HU_DrawChat(void)
 #endif
 			p_dispy -= (cv_kartspeedometer.value ? 16 : 0);
 
-		// Find longest player name, for drawing background for /pm list later
-		for (i = 0; i < MAXPLAYERS; i++)
+		i = 0;
+		for(i=0; (i<MAXPLAYERS); i++)
 		{
-			if (!playeringame[i]) continue;
-
-			longest_name_length = max(longest_name_length, strlen(player_names[i]));
-		}
-
-		for(i = 0; i < MAXPLAYERS; i++)
-		{
-			if (!playeringame[i])
-				continue;
 
 			// filter: (code needs optimization pls help I'm bad with C)
 			if (w_chat_buf[3])
 			{
-				char nodenum[3];
+				char *nodenum;
 				UINT32 n;
 				// right, that's half important: (w_chat_buf[4] may be a space since /pm0 msg is perfectly acceptable!)
-				if (!isdigit(w_chat_buf[3]) || !(isdigit(w_chat_buf[4]) || (w_chat_buf[4] == ' ') || (w_chat_buf[4] == 0)))
+				if ( ( ((w_chat_buf[3] != 0) && ((w_chat_buf[3] < '0') || (w_chat_buf[3] > '9'))) || ((w_chat_buf[4] != 0) && (((w_chat_buf[4] < '0') || (w_chat_buf[4] > '9'))))) && (w_chat_buf[4] != ' '))
 					break;
 
+
+				nodenum = (char*) malloc(3);
 				memcpy(nodenum, w_chat_buf+3, 2);
 				nodenum[2] = '\0';
-				n = atoi(nodenum); // turn that into a number
-
+				n = atoi((const char*) nodenum); // turn that into a number
+				free(nodenum);
 				// special cases:
+
 				if ((n == 0) && !(w_chat_buf[4] == '0'))
 				{
 					if (!(i<10))
@@ -1928,20 +1928,23 @@ static void HU_DrawChat(void)
 				}
 			}
 
-			// fill it like the chat so the text doesn't become hard to read because of the hud.
-			V_DrawFillConsoleMap(chatx + boxw + 2, p_dispy - (6*count), (longest_name_length+4)*4, 6, 239 | V_SNAPTOBOTTOM | V_SNAPTOLEFT);
-
-			V_DrawSmallString(chatx + boxw + 4, p_dispy - (6*count), V_SNAPTOBOTTOM|V_SNAPTOLEFT|V_ALLOWLOWERCASE, va("\x82%d\x80 - %s", i, player_names[i]));
-			count++;
+			if (playeringame[i])
+			{
+				char name[MAXPLAYERNAME+1];
+				strlcpy(name, player_names[i], 7); // shorten name to 7 characters.
+				V_DrawFillConsoleMap(chatx+ boxw + 2, p_dispy- (6*count), 48, 6, 239 | V_SNAPTOBOTTOM | V_SNAPTOLEFT); // fill it like the chat so the text doesn't become hard to read because of the hud.
+				V_DrawSmallString(chatx+ boxw + 4, p_dispy- (6*count), V_SNAPTOBOTTOM|V_SNAPTOLEFT|V_ALLOWLOWERCASE, va("\x82%d\x80 - %s", i, name));
+				count++;
+			}
 		}
 		if (count == 0) // no results.
 		{
-			V_DrawFillConsoleMap(chatx + boxw + 2, p_dispy - (6*count), 48, 6, 239 | V_SNAPTOBOTTOM | V_SNAPTOLEFT); // fill it like the chat so the text doesn't become hard to read because of the hud.
-			V_DrawSmallString(chatx + boxw + 4, p_dispy - (6*count), V_SNAPTOBOTTOM|V_SNAPTOLEFT|V_ALLOWLOWERCASE, "NO RESULT.");
+			V_DrawFillConsoleMap(chatx+boxw+2, p_dispy- (6*count), 48, 6, 239 | V_SNAPTOBOTTOM | V_SNAPTOLEFT); // fill it like the chat so the text doesn't become hard to read because of the hud.
+			V_DrawSmallString(chatx+boxw+4, p_dispy- (6*count), V_SNAPTOBOTTOM|V_SNAPTOLEFT|V_ALLOWLOWERCASE, "NO RESULT.");
 		}
 	}
 
-	HU_drawChatLog(typelines - 1); // typelines is the # of lines we're typing. If there's more than 1 then the log should scroll up to give us more space.
+	HU_drawChatLog(typelines-1); // typelines is the # of lines we're typing. If there's more than 1 then the log should scroll up to give us more space.
 }
 
 
@@ -1953,11 +1956,17 @@ static void HU_DrawChat_Old(void)
 	const char *ntalk = "Say: ", *ttalk = "Say-Team: ";
 	const char *talk = ntalk;
 	size_t select_start = 0, select_end = 0;
-	INT32 charwidth = 8 * con_scalefactor; //hu_font['A'-HU_FONTSTART]->width * con_scalefactor;
-	INT32 charheight = 8 * con_scalefactor; //hu_font['A'-HU_FONTSTART]->height * con_scalefactor;
+	INT32 charwidth = 8 * con_scalefactor; //SHORT(hu_font['A'-HU_FONTSTART]->width) * con_scalefactor;
+	INT32 charheight = 8 * con_scalefactor; //SHORT(hu_font['A'-HU_FONTSTART]->height) * con_scalefactor;
 	if (teamtalk)
 	{
 		talk = ttalk;
+#if 0
+		if (players[consoleplayer].ctfteam == 1)
+			t = 0x500;  // Red
+		else if (players[consoleplayer].ctfteam == 2)
+			t = 0x400; // Blue
+#endif
 	}
 
 	while (talk[i])
@@ -1969,7 +1978,7 @@ static void HU_DrawChat_Old(void)
 		}
 		else
 		{
-			//charwidth = hu_font[talk[i]-HU_FONTSTART]->width * con_scalefactor;
+			//charwidth = SHORT(hu_font[talk[i]-HU_FONTSTART]->width) * con_scalefactor;
 			V_DrawCharacter(HU_INPUTX + c, y, talk[i++] | cv_constextsize.value | V_NOSCALESTART, !cv_allcaps.value);
 		}
 		c += charwidth;
@@ -1997,7 +2006,7 @@ static void HU_DrawChat_Old(void)
 		//Hurdler: isn't it better like that?
 		if (w_chat_buf[i] >= HU_FONTSTART)
 		{
-			//charwidth = hu_font[w_chat[i]-HU_FONTSTART]->width * con_scalefactor;
+			//charwidth = SHORT(hu_font[w_chat[i]-HU_FONTSTART]->width) * con_scalefactor;
 			V_DrawCharacter(HU_INPUTX + c, y, w_chat_buf[i] | cv_constextsize.value | V_NOSCALESTART | t, !cv_allcaps.value);
 		}
 
@@ -2242,7 +2251,7 @@ void HU_Drawer(void)
 
 	// draw desynch text
 	if (hu_resynching
-#ifdef SATURNPAK
+#ifdef SATURNSYNCH
 		|| hu_redownloadinggamestate
 #endif
 		)
@@ -2348,7 +2357,7 @@ Ping_gfx_num (int lag)
 }
 
 static int
-Ping_gfx_color (UINT32 lag)
+Ping_gfx_color (int lag)
 {
 	if (lag < 2)
 		return SKINCOLOR_JAWZ;
@@ -2358,17 +2367,8 @@ Ping_gfx_color (UINT32 lag)
 		return SKINCOLOR_GOLD;
 	else if (lag < 10)
 		return SKINCOLOR_RED;
-	else if (lag < servermaxping)
-	{
-		if (hu_tick & 2)
-			return SKINCOLOR_GREEN;
-		else if (hu_tick & 4)
-			return SKINCOLOR_YELLOW;
-		else
-			return SKINCOLOR_BLUEBERRY;
-	}
 	else
-		return SKINCOLOR_WHITE; // to make the flashing work
+		return SKINCOLOR_WHITE; // SKINCOLOR_MAGENTA
 }
 
 static const UINT8 *
@@ -2432,7 +2432,7 @@ void HU_drawPlayerPing(INT32 x, INT32 y, INT32 pnum, INT32 flags)
 
 		if (measureid == 1)
 			V_DrawScaledPatch(x+11 - pingmeasure[measureid]->width, y+9, flags, pingmeasure[measureid]);
-
+		
 		if (cv_pingicon.value)
 			V_DrawScaledPatch(x+2, y, flags, pinggfx[gfxnum]);
 
@@ -2561,19 +2561,24 @@ static inline void HU_DrawSpectatorTicker(void)
 
 			if (cv_showspecstuff.value)
 			{
-				player_t *player;
-				player = &players[i];
-
-				if (player->mo && player->mo->color)
+				if (players[i].mo)
 				{
-					const UINT8 *colormap = R_GetTranslationColormap(player->skin, player->mo->color, GTC_CACHE);
-					if (player->mo->colorized)
-						colormap = R_GetTranslationColormap(TC_RAINBOW, player->mo->color, GTC_CACHE);
+					player_t *p;
+					p = &players[i];
 
-					if (K_UseHighResPortraits())
-						V_DrawSmallMappedPatch((templength - duptweak), height+10, V_TRANSLUCENT, R_GetSkinFaceWant(player), colormap);
-					else
-						V_DrawMappedPatch((templength - duptweak), height+10, V_TRANSLUCENT, R_GetSkinFaceRank(player), colormap);
+					if (players[i].mo->color)
+					{
+						const UINT8 *colormap;
+						if (players[i].mo->colorized)
+							colormap = R_GetTranslationColormap(TC_RAINBOW, players[i].mo->color, GTC_CACHE);
+						else
+							colormap = R_GetTranslationColormap(players[i].skin, players[i].mo->color, GTC_CACHE);
+
+						if (cv_highresportrait.value)
+							V_DrawSmallMappedPatch((templength - duptweak), height+10, V_TRANSLUCENT, R_GetSkinFaceWant(p), colormap);
+						else	
+							V_DrawMappedPatch((templength - duptweak), height+10, V_TRANSLUCENT, R_GetSkinFaceRank(p), colormap);
+					}
 				}
 
 				if ((netgame && i != serverplayer) || (cv_mindelay.value && P_IsLocalPlayer(&players[i])))
@@ -2588,6 +2593,7 @@ static inline void HU_DrawSpectatorTicker(void)
 	}
 }
 
+
 //
 // HU_DrawRankings
 //
@@ -2597,6 +2603,7 @@ static void HU_DrawRankings(void)
 	playersort_t tab[MAXPLAYERS];
 	INT32 i, j, scorelines, hilicol, numplayersingame = 0;
 	boolean completed[MAXPLAYERS];
+	UINT32 whiteplayer = MAXPLAYERS;
 
 	if (!automapactive)
 		V_DrawFadeScreen(0xFF00, 16); // A little more readable, and prevents cheating the fades under other circumstances.
@@ -2608,25 +2615,20 @@ static void HU_DrawRankings(void)
 	else
 		hilicol = ((gametype == GT_RACE) ? V_SKYMAP : V_REDMAP);
 
-	if (!demo.playback)
-	{
-		// draw the current map in the lower right
-		char *maptitle = G_BuildMapTitle(gamemap);
-
-		if (maptitle)
-		{
-			V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, maptitle);
-			Z_Free(maptitle);
-		}
-		else
-		{
-			V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, "UNKNOWN");
-		}
-	}
+	// draw the current gametype in the lower right
+	//if (modeattacking)
+		//V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, "Record Attack");
+	//else
+		//V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, gametype_cons_t[gametype].strvalue);
+	
+	// draw the current map in the lower right if theres none just say its unknown
+	char *maptitle = G_BuildMapTitle(gamemap);
+	if (!maptitle)
+		V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, "UNKNOWN");
 	else
 	{
-		// draw the current gametype in the lower right
-		V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, (modeattacking) ? "Record Attack" : gametype_cons_t[gametype].strvalue);
+		V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, maptitle);
+		Z_Free(maptitle);
 	}
 
 	if (G_GametypeHasTeams())
@@ -2636,7 +2638,7 @@ static void HU_DrawRankings(void)
 		else
 			p = bmatcico;
 
-		V_DrawSmallScaledPatch(128 - p->width/4, 4, 0, p);
+		V_DrawSmallScaledPatch(128 - SHORT(p->width)/4, 4, 0, p);
 		V_DrawCenteredString(128, 16, 0, va("%u", bluescore));
 
 		if (gametype == GT_CTF)
@@ -2644,7 +2646,7 @@ static void HU_DrawRankings(void)
 		else
 			p = rmatcico;
 
-		V_DrawSmallScaledPatch(192 - p->width/4, 4, 0, p);
+		V_DrawSmallScaledPatch(192 - SHORT(p->width)/4, 4, 0, p);
 		V_DrawCenteredString(192, 16, 0, va("%u", redscore));
 	}
 
@@ -2689,6 +2691,11 @@ static void HU_DrawRankings(void)
 		V_DrawCenteredString(256, 16, hilicol, cv_kartspeed.string);
 	}
 
+	// When you play, you quickly see your score because your name is displayed in white.
+	// When playing back a demo, you quickly see who's the view.
+	if (!splitscreen)
+		whiteplayer = demo.playback ? displayplayers[0] : consoleplayer;
+
 	scorelines = 0;
 	memset(completed, 0, sizeof (completed));
 	memset(tab, 0, sizeof (playersort_t)*MAXPLAYERS);
@@ -2744,7 +2751,7 @@ static void HU_DrawRankings(void)
 #endif
 	}
 
-	HU_DrawTabRankings(((scorelines > 8) ? 32 : 40), 33, tab, scorelines, hilicol);
+	HU_DrawTabRankings(((scorelines > 8) ? 32 : 40), 33, tab, scorelines, whiteplayer, hilicol);
 
 	// draw spectators in a ticker across the bottom
 	if (netgame && G_GametypeHasSpectators())
@@ -2771,31 +2778,16 @@ void HU_SetCEchoFlags(INT32 flags)
 
 void HU_DoCEcho(const char *msg)
 {
+	if (!cv_cechotoggle.value)
+		return
+	
+	I_OutputMsg("%s\n", msg); // print to log
+
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wstringop-truncation" // This is fine, we set null byte later
 	strncpy(cechotext, msg, sizeof(cechotext));
 #pragma GCC diagnostic pop
 	strncat(cechotext, "\\", sizeof(cechotext) - strlen(cechotext) - 1);
 	cechotext[sizeof(cechotext) - 1] = '\0';
-
-	// just print it to console
-	if (cv_cechotoggle.value == 2)
-	{
-		char temp[1024];
-		strncpy(temp, cechotext, sizeof(temp));
-
-		for (char *p = temp; *p != '\0'; ++p)
-			if (*p == '\\')
-				*p = '\n';
-
-		CONS_Printf("%s\n", temp);
-		return;
-	}
-
-	I_OutputMsg("%s\n", msg); // print to log
-
-	if (!cv_cechotoggle.value)
-		return;
-
 	cechotimer = cechoduration;
 }

src/hu_stuff.h

@@ -122,7 +122,7 @@ void HU_clearChatChars(void);
 void HU_drawPlayerPing(INT32 x, INT32 y, INT32 pnum, INT32 flags);	// Lat': Ping drawer for scoreboard.
 //void HU_DrawTeamTabRankings(playersort_t *tab, INT32 whiteplayer);
 //void HU_DrawDualTabRankings(INT32 x, INT32 y, playersort_t *tab, INT32 scorelines, INT32 whiteplayer);
-void HU_DrawTabRankings(INT32 x, INT32 y, playersort_t *tab, INT32 scorelines, INT32 hilicol);
+void HU_DrawTabRankings(INT32 x, INT32 y, playersort_t *tab, INT32 scorelines, INT32 whiteplayer, INT32 hilicol);
 void HU_DrawEmeralds(INT32 x, INT32 y, INT32 pemeralds);
 const char *HU_SkinColorToConsoleColor(skincolors_t color);
 

src/i_net.h

@@ -41,36 +41,17 @@ extern INT16 hardware_MAXPACKETLENGTH;
 
 typedef struct
 {
-	/// Supposed to be DOOMCOM_ID
-	INT32 id;
-
-	/// SRB2 executes an INT32 to execute commands.
-	INT16 intnum;
-	/// Communication between SRB2 and the driver.
-	/// Is CMD_SEND or CMD_GET.
-	INT16 command;
 	/// Is dest for send, set by get (-1 = no packet).
 	INT16 remotenode;
-
 	/// Number of bytes in doomdata to be sent
 	INT16 datalength;
 
 	/// Info common to all nodes.
 	/// Console is always node 0.
 	INT16 numnodes;
-	/// Flag: 1 = no duplication, 2-5 = dup for slow nets.
-	INT16 ticdup;
 	/// Flag: 1 = send a backup tic in every packet.
 	INT16 extratics;
-	/// kind of game
-	INT16 gametype;
-	/// Flag: -1 = new game, 0-5 = load savegame
-	INT16 savegame;
-	/// currect map
-	INT16 map;
 
-	/// Info specific to this node.
-	INT16 consoleplayer;
 	/// Number of "slots": the highest player number in use plus one.
 	INT16 numslots;
 

src/i_tcp.c

@@ -24,7 +24,7 @@
 #endif // __OS2__
 
 #ifndef NO_IPV6
-//#define HAVE_IPV6
+#define HAVE_IPV6
 #endif
 
 #ifdef _WIN32
@@ -49,28 +49,34 @@
 #ifdef NONET
 #undef HAVE_MINIUPNPC
 #else
-#include <time.h>
 #ifdef USE_WINSOCK1
-	#include <winsock.h>
-#else
-	#ifndef USE_WINSOCK
-		#include <arpa/inet.h>
-		#ifdef __APPLE_CC__
-			#ifndef _BSD_SOCKLEN_T_
-				#define _BSD_SOCKLEN_T_
-			#endif //_BSD_SOCKLEN_T_
-		#endif //__APPLE_CC__
-		#include <sys/socket.h>
-		#include <netinet/in.h>
-		#include <netdb.h>
-		#include <sys/ioctl.h>
-	#endif //normal BSD API
+#include <winsock.h>
+#elif !defined (SCOUW2) && !defined (SCOUW7) && !defined (__OS2__)
+#ifndef USE_WINSOCK
+#include <arpa/inet.h>
+#endif //normal BSD API
 
-	#include <errno.h>
+#ifndef USE_WINSOCK
+#ifdef __APPLE_CC__
+#ifndef _BSD_SOCKLEN_T_
+#define _BSD_SOCKLEN_T_
+#endif //_BSD_SOCKLEN_T_
+#endif //__APPLE_CC__
+#include <sys/socket.h>
+#include <netinet/in.h>
+#endif //normal BSD API
 
-	#if defined (__unix__) || defined (__APPLE__) || defined (UNIXCOMMON)
-		#include <sys/time.h>
-	#endif // UNIXCOMMON
+#ifndef USE_WINSOCK
+#include <netdb.h>
+#include <sys/ioctl.h>
+#endif //normal BSD API
+
+#include <errno.h>
+#include <time.h>
+
+#if defined (__unix__) || defined (__APPLE__) || defined (UNIXCOMMON)
+	#include <sys/time.h>
+#endif // UNIXCOMMON
 #endif // !NONET
 
 #ifdef USE_WINSOCK
@@ -117,7 +123,7 @@
 	#ifndef STATUS_INVALID_PARAMETER
 	#define STATUS_INVALID_PARAMETER 0xC000000D
 	#endif
-#endif // USE_WINSOCK
+#endif
 
 typedef union
 {
@@ -162,6 +168,7 @@ static UINT8 UPNP_support = TRUE;
 #endif
 
 #include "i_addrinfo.h"
+
 #define DEFAULTPORT "5029"
 
 #if defined (USE_WINSOCK) && !defined (NONET)
@@ -176,8 +183,6 @@ typedef unsigned long SOCKET_TYPE;
 #define ERRSOCKET (-1)
 #endif
 
-#define IPV6_MULTICAST_ADDRESS "ff15::57e1:1a12"
-
 #ifdef USE_WINSOCK1
 typedef int socklen_t;
 #endif
@@ -374,7 +379,6 @@ static const char *SOCK_AddrToStr(mysockaddr_t *sk)
 	static char s[64]; // 255.255.255.255:65535 or IPv6:65535
 #ifdef HAVE_NTOP
 	void *addr;
-	int e = 0; // save error code so it can't be modified later code and avoid calling WSAGetLastError() more then once
 
 	if(sk->any.sa_family == AF_INET)
 		addr = &sk->ip4.sin_addr;
@@ -388,10 +392,7 @@ static const char *SOCK_AddrToStr(mysockaddr_t *sk)
 	if(addr == NULL)
 		sprintf(s, "No address");
 	else if(inet_ntop(sk->any.sa_family, addr, s, sizeof (s)) == NULL)
-	{
-		e = errno;
-		sprintf(s, "Unknown family type, error #%u: %s", e, strerror(e));
-	}
+		sprintf(s, "Unknown family type, error #%u", errno);
 #ifdef HAVE_IPV6
 	else if(sk->any.sa_family == AF_INET6 && sk->ip6.sin6_port != 0)
 		strcat(s, va(":%d", ntohs(sk->ip6.sin6_port)));
@@ -592,7 +593,6 @@ void Command_Numnodes(void)
 #endif
 
 #ifndef NONET
-#ifdef HOLEPUNCH
 /* not one of the reserved "local" addresses */
 static boolean
 is_external_address (UINT32 p)
@@ -618,6 +618,7 @@ is_external_address (UINT32 p)
 	}
 }
 
+#ifdef HOLEPUNCH
 static boolean hole_punch(ssize_t c)
 {
 
@@ -643,7 +644,7 @@ static boolean hole_punch(ssize_t c)
 	}
 
 }
-#endif //ifdef HOLEPUNCH
+#endif
 
 // Returns true if a packet was received from a new node, false in all other cases
 static boolean SOCK_Get(void)
@@ -769,12 +770,11 @@ static inline ssize_t SOCK_SendToAddr(SOCKET_TYPE socket, mysockaddr_t *sockaddr
 	return sendto(socket, (char *)&doomcom->data, doomcom->datalength, 0, &sockaddr->any, d);
 }
 
-#define ALLOWEDERROR(x) ((x) == ECONNREFUSED || (x) == EWOULDBLOCK || (x) == EHOSTUNREACH || (x) == ENETUNREACH || (x) == EADDRNOTAVAIL)
+#define ALLOWEDERROR(x) ((x) == ECONNREFUSED || (x) == EWOULDBLOCK || (x) == EHOSTUNREACH || (x) == ENETUNREACH)
 
 static void SOCK_Send(void)
 {
 	ssize_t c = ERRSOCKET;
-	int e = 0; // save error code so it can't be modified later code and avoid calling WSAGetLastError() more then once
 	size_t i, j;
 
 	if (!nodeconnected[doomcom->remotenode])
@@ -789,15 +789,12 @@ static void SOCK_Send(void)
 				if (myfamily[i] == broadcastaddress[j].any.sa_family)
 				{
 					c = SOCK_SendToAddr(mysockets[i], &broadcastaddress[j]);
-					if (c == ERRSOCKET)
-					{
-						e = errno;
-						if (!ALLOWEDERROR(e))
-							break;
-					}
+					if (c == ERRSOCKET && !ALLOWEDERROR(errno))
+						break;
 				}
 			}
 		}
+		return;
 	}
 	else if (nodesocket[doomcom->remotenode] == (SOCKET_TYPE)ERRSOCKET)
 	{
@@ -806,28 +803,22 @@ static void SOCK_Send(void)
 			if (myfamily[i] == clientaddress[doomcom->remotenode].any.sa_family)
 			{
 				c = SOCK_SendToAddr(mysockets[i], &clientaddress[doomcom->remotenode]);
-				if (c == ERRSOCKET)
-				{
-					e = errno;
-					if (!ALLOWEDERROR(e))
-						break;
-				}
+				if (c == ERRSOCKET && !ALLOWEDERROR(errno))
+					break;
 			}
 		}
+		return;
 	}
 	else
 	{
 		c = SOCK_SendToAddr(nodesocket[doomcom->remotenode], &clientaddress[doomcom->remotenode]);
-		if (c == ERRSOCKET)
-		{
-			e = errno;
-		}
 	}
 
-	if (c == ERRSOCKET && e != 0) // 0 means no socket for the address family was found
+	if (c == ERRSOCKET)
 	{
+		int e = errno; // save error code so it can't be modified later
 		if (!ALLOWEDERROR(e))
-			I_Error("SOCK_Send, error sending to node %d (%s) #%u, %s", doomcom->remotenode,
+			I_Error("SOCK_Send, error sending to node %d (%s) #%u: %s", doomcom->remotenode,
 				SOCK_GetNodeAddress(doomcom->remotenode), e, strerror(e));
 	}
 }
@@ -861,8 +852,6 @@ static SOCKET_TYPE UDP_Bind(int family, struct sockaddr *addr, socklen_t addrlen
 {
 	SOCKET_TYPE s = socket(family, SOCK_DGRAM, IPPROTO_UDP);
 	int opt;
-	int rc;
-	int e = 0; // save error code so it can't be modified later code and avoid calling WSAGetLastError() more then once
 	socklen_t opts;
 #ifdef FIONBIO
 	unsigned long trueval = true;
@@ -878,17 +867,12 @@ static SOCKET_TYPE UDP_Bind(int family, struct sockaddr *addr, socklen_t addrlen
 #ifdef USE_WINSOCK2
 		DWORD dwBytesReturned = 0;
 		BOOL bfalse = FALSE;
-		rc = WSAIoctl(s, SIO_UDP_CONNRESET, &bfalse, sizeof(bfalse),
+		WSAIoctl(s, SIO_UDP_CONNRESET, &bfalse, sizeof(bfalse),
 		         NULL, 0, &dwBytesReturned, NULL, NULL);
 #else
 		unsigned long falseval = false;
-		rc = ioctl(s, SIO_UDP_CONNRESET, &falseval);
+		ioctl(s, SIO_UDP_CONNRESET, &falseval);
 #endif
-		if (rc == -1)
-		{
-			e = errno;
-			I_OutputMsg("SIO_UDP_CONNRESET failed: #%u, %s\n", e, strerror(e));
-		}
 	}
 #endif
 
@@ -903,22 +887,14 @@ static SOCKET_TYPE UDP_Bind(int family, struct sockaddr *addr, socklen_t addrlen
 		{
 			opt = true;
 			opts = (socklen_t)sizeof(opt);
-			rc = setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (char *)&opt, opts);
-			if (rc <= -1)
-			{
-				e = errno;
-				I_OutputMsg("setting SO_REUSEADDR failed: #%u, %s\n", e, strerror(e));
-			}
+			setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (char *)&opt, opts);
 		}
 		// make it broadcastable
 		opt = true;
 		opts = (socklen_t)sizeof(opt);
-		rc = setsockopt(s, SOL_SOCKET, SO_BROADCAST, (char *)&opt, opts);
-		if (rc <= -1)
+		if (setsockopt(s, SOL_SOCKET, SO_BROADCAST, (char *)&opt, opts))
 		{
-			e = errno;
 			CONS_Alert(CONS_WARNING, M_GetText("Could not get broadcast rights\n")); // I do not care anymore
-			I_OutputMsg("setting SO_BROADCAST failed: #%u, %s\n", e, strerror(e));
 		}
 	}
 #ifdef HAVE_IPV6
@@ -928,117 +904,56 @@ static SOCKET_TYPE UDP_Bind(int family, struct sockaddr *addr, socklen_t addrlen
 		{
 			opt = true;
 			opts = (socklen_t)sizeof(opt);
-			rc = setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (char *)&opt, opts);
-			if (rc <= -1)
-			{
-				e = errno;
-				I_OutputMsg("setting SO_REUSEADDR failed: #%u, %s\n", e, strerror(e));
-			}
+			setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (char *)&opt, opts);
 		}
 #ifdef IPV6_V6ONLY
 		// make it IPv6 ony
 		opt = true;
 		opts = (socklen_t)sizeof(opt);
-		rc = setsockopt(s, SOL_SOCKET, IPV6_V6ONLY, (char *)&opt, opts);
-		if (rc <= -1)
+		if (setsockopt(s, SOL_SOCKET, IPV6_V6ONLY, (char *)&opt, opts))
 		{
-			e = errno;
 			CONS_Alert(CONS_WARNING, M_GetText("Could not limit IPv6 bind\n")); // I do not care anymore
-			I_OutputMsg("setting IPV6_V6ONLY failed: #%u, %s\n", e, strerror(e));
 		}
 #endif
 	}
 #endif
 
-	rc = bind(s, addr, addrlen);
-	if (rc == ERRSOCKET)
+	if (bind(s, addr, addrlen) == ERRSOCKET)
 	{
-		e = errno;
 		close(s);
-		I_OutputMsg("Binding failed: #%u, %s\n", e, strerror(e));
+		I_OutputMsg("Binding failed\n");
 		return (SOCKET_TYPE)ERRSOCKET;
 	}
 
-#ifdef HAVE_IPV6
-	if (family == AF_INET6)
-	{
-		// we need to set all of this *after* binding to an address!
-		if (memcmp(&straddr.ip6.sin6_addr, &in6addr_any, sizeof(in6addr_any)) == 0) //IN6_ARE_ADDR_EQUAL
-		{
-			struct ipv6_mreq maddr;
-
-			inet_pton(AF_INET6, IPV6_MULTICAST_ADDRESS, &maddr.ipv6mr_multiaddr);
-			maddr.ipv6mr_interface = 0;
-			rc = setsockopt(s, SOL_SOCKET, IPV6_JOIN_GROUP, (const char *)&maddr, sizeof(maddr));
-			if (rc <= -1)
-			{
-				e = errno;
-				CONS_Alert(CONS_WARNING, M_GetText("Could not register multicast address\n"));
-				if (e == ENODEV)
-				{
-					close(s);
-					I_OutputMsg("Binding failed: no IPv6 device\n");
-					return (SOCKET_TYPE)ERRSOCKET;
-				}
-				I_OutputMsg("setting IPV6_JOIN_GROUP failed: #%u, %s \n", e, strerror(e));
-			}
-		}
-	}
-#endif
-
 #ifdef FIONBIO
 	// make it non blocking
-	rc = ioctl(s, FIONBIO, &trueval);
-	if (rc == -1)
+	opt = true;
+	if (ioctl(s, FIONBIO, &trueval) != 0)
 	{
-		e = errno;
 		close(s);
-		I_OutputMsg("FIOBIO failed: #%u, %s\n", e, strerror(e));
+		I_OutputMsg("Seting FIOBIO on failed\n");
 		return (SOCKET_TYPE)ERRSOCKET;
 	}
 #endif
 
-	opt = 0;
 	opts = (socklen_t)sizeof(opt);
-	rc = getsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, &opts);
-	if (rc <= -1)
-	{
-		e = errno;
-		I_OutputMsg("getting SO_RCVBUF failed: #%u, %s\n", e, strerror(e));
-	}
+	getsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, &opts);
 	CONS_Printf(M_GetText("Network system buffer: %dKb\n"), opt>>10);
 
 	if (opt < 64<<10) // 64k
 	{
 		opt = 64<<10;
 		opts = (socklen_t)sizeof(opt);
-		rc = setsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, opts);
-		if (rc <= -1)
-		{
-			e = errno;
-			I_OutputMsg("setting SO_RCVBUF failed: #%u, %s\n", e, strerror(e));
-		}
-		opt = 0;
-		rc = getsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, &opts);
-		if (rc <= -1)
-		{
-			e = errno;
-			I_OutputMsg("getting SO_RCVBUF failed: #%u, %s\n", e, strerror(e));
-		}
-
+		setsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, opts);
+		getsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, &opts);
 		if (opt < 64<<10)
 			CONS_Alert(CONS_WARNING, M_GetText("Can't set buffer length to 64k, file transfer will be bad\n"));
 		else
 			CONS_Printf(M_GetText("Network system buffer set to: %dKb\n"), opt>>10);
 	}
 
-	rc = getsockname(s, (struct sockaddr *)&sin, &len);
-	if (rc != 0)
-	{
-		e = errno;
+	if (getsockname(s, (struct sockaddr *)&sin, &len) == -1)
 		CONS_Alert(CONS_WARNING, M_GetText("Failed to get port number\n"));
-		I_OutputMsg("getsockname failed: #%u, %s\n", e, strerror(e));
-	}
 	else
 		current_port = (UINT16)ntohs(sin.sin_port);
 
@@ -1178,28 +1093,65 @@ static boolean UDP_Socket(void)
 	// ip + udp
 	packetheaderlength = 20 + 8; // for stats
 
-	clientaddress[s].any.sa_family = AF_INET;
-	clientaddress[s].ip4.sin_port = htons(0);
-	clientaddress[s].ip4.sin_addr.s_addr = htonl(INADDR_LOOPBACK); //GetLocalAddress(); // my own ip
-	s++;
+	hints.ai_family = AF_INET;
+	gaie = I_getaddrinfo("127.0.0.1", "0", &hints, &ai);
+	if (gaie == 0)
+	{
+		runp = ai;
+		while (runp != NULL && s < MAXNETNODES+1)
+		{
+			memcpy(&clientaddress[s], runp->ai_addr, runp->ai_addrlen);
+			s++;
+			runp = runp->ai_next;
+		}
+		I_freeaddrinfo(ai);
+	}
+	else
+	{
+		clientaddress[s].any.sa_family = AF_INET;
+		clientaddress[s].ip4.sin_port = htons(0);
+		clientaddress[s].ip4.sin_addr.s_addr = htonl(INADDR_LOOPBACK); //GetLocalAddress(); // my own ip
+		s++;
+	}
 
 	s = 0;
 
 	// setup broadcast adress to BROADCASTADDR entry
-	broadcastaddress[s].any.sa_family = AF_INET;
-	broadcastaddress[s].ip4.sin_port = htons(atoi(DEFAULTPORT));
-	broadcastaddress[s].ip4.sin_addr.s_addr = htonl(INADDR_BROADCAST);
-	s++;
-
+	gaie = I_getaddrinfo("255.255.255.255", "0", &hints, &ai);
+	if (gaie == 0)
+	{
+		runp = ai;
+		while (runp != NULL && s < MAXNETNODES+1)
+		{
+			memcpy(&broadcastaddress[s], runp->ai_addr, runp->ai_addrlen);
+			s++;
+			runp = runp->ai_next;
+		}
+		I_freeaddrinfo(ai);
+	}
+	else
+	{
+		broadcastaddress[s].any.sa_family = AF_INET;
+		broadcastaddress[s].ip4.sin_port = htons(0);
+		broadcastaddress[s].ip4.sin_addr.s_addr = htonl(INADDR_BROADCAST);
+		s++;
+	}
 #ifdef HAVE_IPV6
 	if (b_ipv6)
 	{
-		broadcastaddress[s].any.sa_family = AF_INET6;
-		broadcastaddress[s].ip6.sin6_port = htons(atoi(DEFAULTPORT));
-		broadcastaddress[s].ip6.sin6_flowinfo = 0;
-		inet_pton(AF_INET6, IPV6_MULTICAST_ADDRESS, &broadcastaddress[s].ip6.sin6_addr);
-		broadcastaddress[s].ip6.sin6_scope_id = 0;
-		s++;
+		hints.ai_family = AF_INET6;
+		gaie = I_getaddrinfo("ff02::1", "0", &hints, &ai);
+		if (gaie == 0)
+		{
+			runp = ai;
+			while (runp != NULL && s < MAXNETNODES+1)
+			{
+				memcpy(&broadcastaddress[s], runp->ai_addr, runp->ai_addrlen);
+				s++;
+				runp = runp->ai_next;
+			}
+			I_freeaddrinfo(ai);
+		}
 	}
 #endif
 
@@ -1690,8 +1642,6 @@ boolean I_InitTcpNetwork(void)
 		// FIXME: for dedicated server, numnodes needs to be set to 0 upon start
 		if (dedicated)
 			doomcom->numnodes = 0;
-/*		else if (M_IsNextParm())
-			doomcom->numnodes = (INT16)atoi(M_GetNextParm());*/
 		else
 			doomcom->numnodes = 1;
 

src/i_time.c

@@ -58,7 +58,7 @@ void I_UpdateTime(fixed_t timescale)
 	tic_t realtics;
 
 	// get real tics
-	ticratescaled = (double)TICRATE * FixedToFloat(timescale);
+	ticratescaled = (double)TICRATE * FIXED_TO_FLOAT(timescale);
 
 	enterprecise = I_GetPreciseTime();
 	elapsedseconds = (double)((INT64)enterprecise - oldenterprecise) / I_GetPrecisePrecision();
@@ -77,6 +77,6 @@ void I_UpdateTime(fixed_t timescale)
 	{
 		double fractional, integral;
 		fractional = modf(tictimer * ticratescaled, &integral);
-		g_time.timefrac = FloatToFixed(fractional);
+		g_time.timefrac = FLOAT_TO_FIXED(fractional);
 	}
 }

src/k_director.c

@@ -14,15 +14,12 @@
 #include "doomdef.h"
 #include "doomstat.h"
 #include "g_game.h"
-#include "m_random.h"
 #include "v_video.h"
 #include "k_director.h"
 #include "d_netcmd.h"
 #include "p_local.h"
 #include "st_stuff.h"
 
-#include "r_fps.h"
-
 #define SWITCHTIME TICRATE * 5		// cooldown between unforced switches
 #define BOREDOMTIME 3 * TICRATE / 2 // how long until players considered far apart?
 #define TRANSFERTIME TICRATE		// how long to delay reaction shots?
@@ -34,7 +31,6 @@ struct directorinfo
 {
 	player_t* viewplayer;
 	tic_t cooldown; // how long has it been since we last switched?
-	tic_t chaosleep;// how long did we watch the same player?
 	tic_t freeze;   // when nonzero, fixed switch pending, freeze logic!
 	INT32 attacker; // who to switch to when freeze delay elapses
 	INT32 maxdist;  // how far is the closest player from finishing?
@@ -44,19 +40,6 @@ struct directorinfo
 	INT32 boredom[MAXPLAYERS];       // how long has a given position had no credible attackers?
 } directorinfo;
 
-static INT32 K_PlayersPlaying(void)
-{
-	INT32 num = 0, i;
-	for (i = 0; i < MAXPLAYERS; i++)
-	{
-		if (!playeringame[i] || players[i].spectator || !players[i].mo)
-			continue;
-
-		num++;
-	}
-	return num;
-}
-
 static inline boolean race_rules(void)
 {
 	return gametype == GT_RACE;
@@ -69,9 +52,9 @@ static fixed_t ScaleFromMap(fixed_t n, fixed_t scale)
 
 boolean K_DirectorIsAvailable(void)
 {
-	if (splitscreen || dedicated || (demo.playback && demo.title) || modeattacking)
+	if (splitscreen || (demo.playback && demo.title) || modeattacking)
 		return false;
-	return ((gamestate == GS_LEVEL) && ((demo.playback && !camera[0].freecam) || (players[consoleplayer].spectator && (K_PlayersPlaying() > 1))));
+	return ((gamestate == GS_LEVEL) && ((demo.playback && !camera[0].freecam) || (players[consoleplayer].spectator && (D_NumPlayers() > 1))));
 }
 
 static boolean K_DirectorIsEnabled(void)
@@ -79,48 +62,6 @@ static boolean K_DirectorIsEnabled(void)
 	return (cv_director.value && K_DirectorIsAvailable());
 }
 
-static mobj_t *finishmo = NULL;
-
-// scan for the waypoint on the finish line
-// used to get a very approximate distance from player to finishline
-// we probably should like, do some maths to find the middle point between multiplayer
-// waypoints with the same values, but idk if its really worth it
-static void K_SetupFinishMo(void)
-{
-	INT16 maxMoveCount = -1;
-	INT16 maxAngle = -1;
-
-	finishmo = NULL;
-
-	if (!(mapheaderinfo[gamemap - 1]->levelflags & LF_SECTIONRACE)) // not a sprint map
-	{
-		// waypoint with angle 0 should always be at the finish line
-		for (finishmo = waypointcap; finishmo != NULL; finishmo = finishmo->tracer)
-		{
-			if (finishmo->spawnpoint->angle == 0)
-				break;
-		}
-	}
-	else // crappy optimization weeeee
-	{
-		// sprint maps finishline waypoint is the one with highest movecount AND angle
-		for (finishmo = waypointcap; finishmo != NULL; finishmo = finishmo->tracer)
-		{
-			if (finishmo->movecount > maxMoveCount)
-				maxMoveCount = finishmo->movecount;
-			if (finishmo->spawnpoint->angle > maxAngle)
-				maxAngle = finishmo->spawnpoint->angle;
-		}
-
-		// now actually get the one
-		for (finishmo = waypointcap; finishmo != NULL; finishmo = finishmo->tracer)
-		{
-			if (finishmo->movecount == maxMoveCount && finishmo->spawnpoint->angle == maxAngle)
-				break; // found it
-		}
-	}
-}
-
 void K_InitDirector(void)
 {
 	INT32 playernum;
@@ -130,7 +71,6 @@ void K_InitDirector(void)
 	directorinfo.attacker = 0;
 	directorinfo.maxdist = 0;
 	directorinfo.viewplayer = NULL;
-	directorinfo.chaosleep = 0;
 
 	for (playernum = 0; playernum < MAXPLAYERS; playernum++)
 	{
@@ -138,18 +78,50 @@ void K_InitDirector(void)
 		directorinfo.gap[playernum] = INT32_MAX;
 		directorinfo.boredom[playernum] = 0;
 	}
-
-	K_SetupFinishMo();
 }
 
 static fixed_t K_GetDistanceToFinish(player_t player)
 {
-	if (P_MobjWasRemoved(finishmo))
-		return 0;
+	mobj_t *mo;
+	fixed_t dist = 0;
+	INT16 maxMoveCount = -1;
+	INT16 maxAngle = -1;
 
-	return P_AproxDistance(P_AproxDistance(finishmo->x - player.mo->x,
-										   finishmo->y - player.mo->y),
-										   finishmo->z - player.mo->z) / FRACUNIT;
+	if (!(mapheaderinfo[gamemap - 1]->levelflags & LF_SECTIONRACE))
+	{
+		for (mo = waypointcap; mo != NULL; mo = mo->tracer)
+		{
+			if (mo->spawnpoint->angle != 0)
+				continue;
+
+			dist = P_AproxDistance(P_AproxDistance(mo->x - player.mo->x,
+												   mo->y - player.mo->y),
+												   mo->z - player.mo->z) / FRACUNIT;
+
+			break;
+		}
+	}
+	else // crappy optimization weeeee
+	{
+		for (mo = waypointcap; mo != NULL; mo = mo->tracer)
+		{
+			if (mo->movecount > maxMoveCount)
+				maxMoveCount = mo->movecount;
+			if (mo->spawnpoint->angle > maxAngle)
+				maxAngle = mo->spawnpoint->angle;
+
+			if (!(mo->movecount == maxMoveCount && mo->spawnpoint->angle == maxAngle)) // sprint maps finishline waypoint is the one with highest movecount AND angle
+				continue;
+
+			dist = P_AproxDistance(P_AproxDistance(mo->x - player.mo->x,
+												   mo->y - player.mo->y),
+												   mo->z - player.mo->z) / FRACUNIT;
+
+			break;
+		}
+	}
+
+	return dist;
 }
 
 static fixed_t K_GetFinishGap(INT32 leader, INT32 follower)
@@ -173,10 +145,10 @@ static void K_UpdateDirectorPositions(void)
 	INT32 position;
 	player_t* target;
 
+	memset(directorinfo.sortedplayers, -1, sizeof(directorinfo.sortedplayers));
+
 	for (playernum = 0; playernum < MAXPLAYERS; playernum++)
 	{
-		directorinfo.sortedplayers[playernum] = -1;
-
 		target = &players[playernum];
 
 		if (playeringame[playernum] && !target->spectator && target->kartstuff[k_position] > 0)
@@ -244,7 +216,6 @@ static void K_DirectorSwitch(INT32 player, boolean force)
 
 	G_ResetView(1, player, true);
 	directorinfo.cooldown = SWITCHTIME;
-	directorinfo.chaosleep = 0;
 }
 
 static void K_DirectorForceSwitch(INT32 player, INT32 time)
@@ -256,26 +227,6 @@ static void K_DirectorForceSwitch(INT32 player, INT32 time)
 
 	directorinfo.attacker = player;
 	directorinfo.freeze = time;
-	directorinfo.chaosleep = 0;
-}
-
-static void K_DirectorSwitchRandom(void)
-{
-	INT32 randomplayer = -1;
-
-	// kinda dumb but just check if the random player is existing lmao
-	for (INT32 h = 0; h < MAXPLAYERS; h++)
-	{
-		randomplayer = directorinfo.sortedplayers[M_RandomRange(0, K_PlayersPlaying()-1)]; // switch to someone random
-
-		if (randomplayer != -1 && randomplayer != displayplayers[0]) // dont switch to ourselves Zzz...
-		{
-			break;
-		}
-	}
-
-	if (randomplayer != -1)
-		K_DirectorSwitch(randomplayer, true);
 }
 
 void K_DirectorFollowAttack(player_t *player, mobj_t *inflictor, mobj_t *source)
@@ -318,7 +269,6 @@ void K_DrawDirectorDebugger(void)
 	V_DrawThinString(120, 0, V_70TRANS, va("BORED"));
 	V_DrawThinString(150, 0, V_70TRANS, va("COOLDOWN: %d", directorinfo.cooldown));
 	V_DrawThinString(230, 0, V_70TRANS, va("MAXDIST: %d", directorinfo.maxdist));
-	V_DrawThinString(310, 0, V_70TRANS, va("SLEEPTIME: %d", directorinfo.chaosleep));
 
 	for (position = 0; position < MAXPLAYERS - 1; position++)
 	{
@@ -365,8 +315,7 @@ void K_UpdateDirector(void)
 
 	K_UpdateDirectorPositions();
 
-	if (directorinfo.cooldown > 0)
-	{
+	if (directorinfo.cooldown > 0) {
 		directorinfo.cooldown--;
 	}
 
@@ -388,27 +337,6 @@ void K_UpdateDirector(void)
 		return;
 	}
 
-	// insta switch if the player were watching finishes
-	if (players[displayplayers[0]].exiting)
-	{
-		K_DirectorSwitchRandom();
-		return;
-	}
-
-	// begin counting when cooldown wore off
-	if (!directorinfo.cooldown)
-	{
-		directorinfo.chaosleep++;
-	}
-
-	// force switch 10 seconds after the cooldown has ended
-	// otherwise i fall asleeb zzz...
-	if (directorinfo.chaosleep > TICRATE*10)
-	{
-		K_DirectorSwitchRandom();
-		return;
-	}
-
 	// aaight, time to walk through the standings to find the first interesting pair
 	// NB: targetposition/sortedplayers is 0-indexed, aiming at the "back half" of a given pair by default.
 	// we adjust for this when comparing to player->position or when looking at the leading player, Don't Freak Out

src/k_kart.h

@@ -20,10 +20,8 @@ void K_GenerateKartColormap(UINT8 *dest_colormap, INT32 skinnum, UINT8 color, bo
 UINT8 K_GetKartColorByName(const char *name);
 UINT8 K_GetHudColor(void);
 boolean K_UseColorHud(void);
-boolean K_UseHighResPortraits(void);
 
-void K_RegisterServerKartStuff(void);
-void K_RegisterClientKartStuff(void);
+void K_RegisterKartStuff(void);
 
 extern consvar_t cv_coloredspeedlines, cv_coloredsneakertrail;
 extern consvar_t cv_bananajitter;
@@ -41,15 +39,9 @@ extern consvar_t cv_battlespeedo;
 extern consvar_t cv_multiitemicon;
 extern consvar_t cv_huditemamount;
 
-#define NUMSPEEDOSTUFF 8
+#define NUMSPEEDOSTUFF 6
 extern CV_PossibleValue_t speedo_cons_t[NUMSPEEDOSTUFF];
-#define NUMDGAUGESTUFF 6
-extern CV_PossibleValue_t driftgaugestyle_cons_t[NUMDGAUGESTUFF];
-#define NUMINPUTDISPLAYSTUFF 5
-extern CV_PossibleValue_t inputdisplay_cons_t[NUMINPUTDISPLAYSTUFF];
-#define NUMMINIMAPDOTSTUFF 5
-extern CV_PossibleValue_t minimapdot_cons_t[NUMMINIMAPDOTSTUFF];
-
+extern CV_PossibleValue_t driftgaugestyle_cons_t[NUMSPEEDOSTUFF];
 
 boolean K_IsPlayerLosing(player_t *player);
 boolean K_IsPlayerWanted(player_t *player);
@@ -69,8 +61,6 @@ void K_ExplodePlayer(player_t *player, mobj_t *source, mobj_t *inflictor);
 void K_StealBumper(player_t *player, player_t *victim, boolean force);
 void K_SpawnKartExplosion(fixed_t x, fixed_t y, fixed_t z, fixed_t radius, INT32 number, mobjtype_t type, angle_t rotangle, boolean spawncenter, boolean ghostit, mobj_t *source);
 void K_SpawnMineExplosion(mobj_t *source, UINT8 color);
-boolean K_CheckSlopeRollDist(mobj_t *mobj);
-boolean K_ShouldSlopeRoll(mobj_t *mobj);
 void K_RollMobjBySlopes(mobj_t *mo, pslope_t *slope);
 void K_SpawnBoostTrail(player_t *player);
 void K_SpawnSparkleTrail(mobj_t *mo);
@@ -128,7 +118,6 @@ typedef struct
 patch_t *K_getItemBoxPatch(boolean small, boolean dark);
 patch_t *K_getItemMulPatch(boolean small);
 void K_getItemBoxDrawinfo(drawinfo_t *out);
-INT32 K_getMinimapTrans(void);
 void K_getLapsDrawinfo(drawinfo_t *out);
 void K_getMinimapDrawinfo(drawinfo_t *out);
 

src/k_stats.c

@@ -1,214 +0,0 @@
-#include "k_stats.h"
-#include "doomstat.h"
-#include "g_game.h"
-#include "byteptr.h"
-#include "z_zone.h"
-
-kartstats_t kartstats = {0};
-
-void K_StatTicker(void)
-{
-	if (demo.playback)
-		return;
-
-	kartstats.totalplaytime++;
-
-	if (netgame)
-		kartstats.onlineplaytime++;
-	else if (modeattacking)
-		kartstats.raplaytime++;
-
-	if (G_RaceGametype())
-		kartstats.raceplaytime++;
-	else
-		kartstats.battleplaytime++;
-
-	// Should this also track splitscreen players?
-	if (!players[consoleplayer].spectator)
-	{
-		player_t *p = &players[consoleplayer];
-
-		if (p->kartstuff[k_position] == spbplace)
-			kartstats.spbtargettime++;
-
-		if (max(p->kartstuff[k_spinouttimer], p->kartstuff[k_wipeoutslow]) > 0)
-			kartstats.spinouttime++;
-	}
-}
-
-void K_StatPlayerHit(player_t *victim, player_t *source)
-{
-	if (demo.playback)
-		return;
-
-	if (victim == &players[consoleplayer])
-	{
-		if (victim == source)
-			kartstats.selfhits++;
-	}
-	else if (source == &players[consoleplayer])
-		kartstats.hits++;
-}
-
-void K_StatPlayerSink(player_t *victim, player_t *source)
-{
-	if (demo.playback)
-		return;
-
-	if (victim == &players[consoleplayer])
-		kartstats.sinked++;
-	else if (source == &players[consoleplayer])
-		kartstats.sinks++;
-}
-
-void K_StatRound(void)
-{
-	if (demo.playback)
-		return;
-
-	int numplayers = 0;
-
-	for (int i = 0; i < MAXPLAYERS; ++i)
-	{
-		if (playeringame[i] && !players[i].spectator)
-			++numplayers;
-	}
-
-	if (numplayers > 1 && !players[consoleplayer].spectator)
-	{
-		if (players[consoleplayer].kartstuff[k_position] == 1)
-			kartstats.totalwins++;
-		else if (players[consoleplayer].kartstuff[k_position] <= 3) // Should this check if there are more than 3 players in game?
-			kartstats.totalpodium++;
-	}
-}
-
-void K_EraseStats(void)
-{
-	// The only field we want to remember
-	boolean vanilla = kartstats.vanilla;
-
-	if (kartstats.copy)
-		Z_Free(kartstats.copy);
-
-	memset(&kartstats, 0, sizeof(kartstats_t));
-
-	kartstats.vanilla = vanilla;
-}
-
-static void K_ReadStatsCustom(savebuffer_t *save)
-{
-	kartstats.size = READUINT32(save->p);
-	kartstats.version = READUINT32(save->p);
-
-	// So many similar-looking read's... scary...
-	kartstats.raplaytime = READUINT32(save->p);
-	kartstats.onlineplaytime = READUINT32(save->p);
-	kartstats.raceplaytime = READUINT32(save->p);
-	kartstats.battleplaytime = READUINT32(save->p);
-	kartstats.spbtargettime = READUINT32(save->p);
-	kartstats.spinouttime = READUINT32(save->p);
-	kartstats.totalwins = READUINT32(save->p);
-	kartstats.totalpodium = READUINT32(save->p);
-	kartstats.hits = READUINT32(save->p);
-	kartstats.selfhits = READUINT32(save->p);
-	kartstats.sinks = READUINT32(save->p);
-	kartstats.sinked = READUINT32(save->p);
-	kartstats.respawns = READUINT32(save->p);
-
-	// If kartstats gets updated, uncomment this and read next fields after this early return. Do same on next updates,
-	// this way even data is read on different versions, it doesn't get corrupted (as long as fields aren't removed, which shouldn't happen)
-	//if (kartstats.version < 2)
-	//	return;
-	//
-	//kartstats.somenewfield = READUINT32(save->p);
-}
-
-void K_ReadStats(savebuffer_t *save, boolean vanilla)
-{
-	// Basically, free old kartstats.copy if needed and memset kartstats with zeros
-	K_EraseStats();
-
-	kartstats.vanilla = vanilla;
-
-	kartstats.totalplaytime = READUINT32(save->p);
-	kartstats.matchesplayed = READUINT32(save->p);
-
-	// Vanilla only has those 2
-	if (vanilla)
-		return;
-
-	// Save where block of custom stats starts
-	UINT8 *customblockstart = save->p;
-
-	K_ReadStatsCustom(save);
-
-	// Make a copy of entire custom stats block, so unread values will still be written back
-	kartstats.copy = Z_Malloc(kartstats.size, PU_STATIC, NULL);
-	memcpy(kartstats.copy, customblockstart, kartstats.size);
-
-	// If there were extra fields we couldn't read, skip them
-	save->p = customblockstart + kartstats.size;
-}
-
-static void K_WriteStatsCustom(savebuffer_t *save)
-{
-	// Update, if needed
-	kartstats.version = max(kartstats.version, KARTSTATSVERSION);
-
-	WRITEUINT32(save->p, kartstats.size); // Note: if we will end up writing more that stored in there, this field in save file would be updated
-	WRITEUINT32(save->p, kartstats.version);
-
-	// Version 1
-	WRITEUINT32(save->p, kartstats.raplaytime);
-	WRITEUINT32(save->p, kartstats.onlineplaytime);
-	WRITEUINT32(save->p, kartstats.raceplaytime);
-	WRITEUINT32(save->p, kartstats.battleplaytime);
-	WRITEUINT32(save->p, kartstats.spbtargettime);
-	WRITEUINT32(save->p, kartstats.spinouttime);
-	WRITEUINT32(save->p, kartstats.totalwins);
-	WRITEUINT32(save->p, kartstats.totalpodium);
-	WRITEUINT32(save->p, kartstats.hits);
-	WRITEUINT32(save->p, kartstats.selfhits);
-	WRITEUINT32(save->p, kartstats.sinks);
-	WRITEUINT32(save->p, kartstats.sinked);
-	WRITEUINT32(save->p, kartstats.respawns);
-
-	// No need for early returns, but please mark each new block of write's with version it corresponds to :3
-
-	// Version 2
-	//WRITEUINT32(save->p, kartstats.somenewfield);
-}
-
-void K_WriteStats(savebuffer_t *save, boolean vanilla)
-{
-	WRITEUINT32(save->p, kartstats.totalplaytime);
-	WRITEUINT32(save->p, kartstats.matchesplayed);
-
-	// Vanilla only has those 2
-	if (vanilla)
-		return;
-
-	// Now need to be careful... We save start of custom stats block
-	UINT8 *customblockstart = save->p;
-
-	// Write everything we know how to write
-	K_WriteStatsCustom(save);
-
-	// Calculate size of data that we wrote
-	UINT32 size = (UINT32)(save->p - customblockstart);
-
-	// Now, if we wrote less data than save originally had, that means our copy that we kept in K_ReadStats
-	// has stats from newer version that we need to append
-	if (size < kartstats.size)
-	{
-		I_Assert(kartstats.copy != NULL); // If kartstats.copy is null, kartstats.size **always** should be 0, this can only happen if we create new save
-		WRITEMEM(save->p, kartstats.copy + size, kartstats.size - size);
-	}
-	else if (size > kartstats.size) // No need to do anything if we wrote exactly same amount...
-	{
-		// ...but, if we wrote more, we need to update size field in header. **It's always located at start of block**
-		// So we can just:
-		WRITEUINT32(customblockstart, size);
-	}
-}

src/k_stats.h

@@ -1,66 +0,0 @@
-#ifndef __K_STATS__
-#define __K_STATS__
-
-#include "doomtype.h"
-#include "d_player.h"
-#include "p_saveg.h"
-
-#define KARTSTATSVERSION 1
-
-typedef struct kartstats_s {
-	// Remember if stats we loaded are vanilla ones or not
-	boolean vanilla;
-
-	// Vanilla
-	tic_t totalplaytime;
-	UINT32 matchesplayed;
-
-	// Custom data, fields go in same order as they are written into game save
-
-	// IMPORTANT: size **must be first**, so K_WriteStats can overwrite it (not that we're gonna change order, but just in case)
-	UINT32 size; // Size required for our stats. If older version reads save from newer one, it will just skip unread fields, avoiding reading corrupted values
-	UINT32 version; // Version, so we know which fields we actually can read
-
-	tic_t raplaytime;
-	tic_t onlineplaytime;
-	tic_t raceplaytime;
-	tic_t battleplaytime;
-	tic_t spbtargettime;
-	tic_t spinouttime;
-	UINT32 totalwins; // 1st place
-	UINT32 totalpodium; // 2nd and 3rd place, *but not 1st*
-	UINT32 hits;
-	UINT32 selfhits;
-	UINT32 sinks; // Times hitting *others* by kitchen sink
-	UINT32 sinked; // Times *being hit* by kitchen sink
-	UINT32 respawns;
-
-	UINT8 *copy; // Copy of stats block that has been read from file. In case we're older version that reads newer save, we will keep values that we couldn't read
-} kartstats_t;
-
-extern kartstats_t kartstats;
-
-// Note: All stat-tracking functions check for demo.playback and early return if its true
-
-// Update global stats such as total play time, etc
-void K_StatTicker(void);
-
-// Update hit-related stats (PlayerSpin, PlayerSquish, PlayerExplode)
-void K_StatPlayerHit(player_t *victim, player_t *source);
-
-// Separate from stuff above
-void K_StatPlayerSink(player_t *victim, player_t *source);
-
-// Update round-related stats (such as matchesplayed, totalwins, etc)
-void K_StatRound(void);
-
-void K_EraseStats(void);
-
-// If vanilla is true, only read vanilla-supported fields. Everything else is initialized to 0
-void K_ReadStats(savebuffer_t *save, boolean vanilla);
-
-// Same as above, except it just doesn't write non-vanilla fields if vanilla is true
-void K_WriteStats(savebuffer_t *save, boolean vanilla);
-
-
-#endif

src/lua_baselib.c

@@ -25,7 +25,6 @@
 #include "console.h"
 #include "k_kart.h" // SRB2Kart
 #include "d_netcmd.h" // IsPlayerAdmin
-#include "d_main.h"
 
 #include "lua_script.h"
 #include "lua_libs.h"
@@ -240,7 +239,6 @@ static int lib_pAproxDistance(lua_State *L)
 	fixed_t dy = luaL_checkfixed(L, 2);
 	//HUDSAFE
 	//LUA_Deprecated(L, "P_AproxDistance", "FixedHypot");
-	LUA_LogDeprecated(L, "P_AproxDistance", "FixedHypot");
 	lua_pushfixed(L, FixedHypot(dx, dy));
 	return 1;
 }
@@ -1041,7 +1039,6 @@ static int lib_pTeleportMove(lua_State *L)
 	if (!thing)
 		return LUA_ErrInvalid(L, "mobj_t");
 	//LUA_Deprecated(L, "P_TeleportMove", "P_SetOrigin\" or \"P_MoveOrigin");
-	LUA_LogDeprecated(L, "P_TeleportMove", "P_SetOrigin\" or \"P_MoveOrigin");
 	lua_pushboolean(L, P_MoveOrigin(thing, x, y, z));
 	LUA_PushUserdata(L, tmthing, META_MOBJ);
 	P_SetTarget(&tmthing, ptmthing);
@@ -1652,7 +1649,7 @@ static int lib_pGetZAt(lua_State *L)
 	if (!slope)
 		return LUA_ErrInvalid(L, "pslope_t");
 
-	lua_pushfixed(L, P_GetSlopeZAt(slope, x, y));
+	lua_pushfixed(L, P_GetZAt(slope, x, y));
 	return 1;
 }
 

src/lua_consolelib.c

@@ -94,7 +94,11 @@ deny:
 	CONS_Alert(CONS_WARNING, M_GetText("Illegal lua command received from %s\n"), player_names[playernum]);
 	if (server)
 	{
-		SendKick(playernum, KICK_MSG_CON_FAIL);
+		UINT8 bufn[2];
+
+		bufn[0] = (UINT8)playernum;
+		bufn[1] = KICK_MSG_CON_FAIL;
+		SendNetXCmd(XD_KICK, &bufn, 2);
 	}
 }
 
@@ -454,10 +458,13 @@ static int lib_cvRegisterVar(lua_State *L)
 
 	if (!(((cvar->flags & CV_HIDEN)) || (cvar->flags & CV_NOSHOWHELP)) && (cvar->PossibleValue || !(cvar->value == 0 && stricmp(cvar->string, "0"))))
 	{
+		char *temp = NULL;
+
 		if (!category)
 		{
-			char *temp = wadfiles[numwadfiles - 1]->filename;
-			temp += strlen(temp) - nameonlylength(temp);
+			temp = strdup(wadfiles[numwadfiles - 1]->filename);
+			nameonly(temp);
+
 			category = temp;
 		}
 
@@ -465,6 +472,8 @@ static int lib_cvRegisterVar(lua_State *L)
 			M_SlotCvarIntoModMenu(cvar, category, menu_name);
 		else
 			M_SlotCvarIntoModMenu(cvar, category, cvar->name);
+
+		free (temp);
 	}
 
 	// return cvar userdata

src/lua_glib.c

@@ -8,7 +8,7 @@
     #define GLIB_DATABASE_MTABLE  "metatable"   /* Metatable.*/
     #define GLIB_DATABASE_PROXY   "proxy"       /* Proxy table for the library that isn't the global table. */
 
-FUNCINLINE static ATTRINLINE void lua_glib_push_db(lua_State *L)
+static inline void lua_glib_push_db(lua_State *L)
 {
     lua_pushliteral(L, GLIB_DATABASE_GUID);
     lua_gettable(L, LUA_REGISTRYINDEX);

src/lua_hooklib.c

@@ -935,7 +935,40 @@ int LUA_HookHurtMsg(player_t *player, mobj_t *inflictor, mobj_t *source)
 	return hook.status;
 }
 
-void LUA_HookNetArchive(lua_CFunction archFunc, savebuffer_t *save)
+#if 0
+void LUA_HookNetArchive(lua_CFunction archFunc)
+{
+	const hook_t * map = &hookIds[HOOK(NetVars)];
+	Hook_State hook;
+	hook.force_mobj = false;
+	/* this is a remarkable case where the stack isn't reset */
+	if (map->numHooks > 0)
+	{
+		// stack: tables
+		I_Assert(lua_gettop(gL) > 0);
+		I_Assert(lua_istable(gL, -1));
+
+		push_error_handler();
+		lua_insert(gL, EINDEX);
+
+		begin_hook_values(&hook);
+
+		// tables becomes an upvalue of archFunc
+		lua_pushvalue(gL, -1);
+		lua_pushcclosure(gL, archFunc, 1);
+		// stack: tables, archFunc
+
+		init_hook_call(&hook, 0, res_none);
+		call_mapped(&hook, map);
+
+		lua_pop(gL, 1); // pop archFunc
+		lua_remove(gL, EINDEX); // pop error handler
+		// stack: tables
+	}
+}
+#endif
+
+void LUA_HookNetArchive(lua_CFunction archFunc, savebuffer_t *save) //
 {
 	const hook_t * map = &hookIds[HOOK(NetVars)];
 	Hook_State hook;

src/lua_hud.h

@@ -32,7 +32,6 @@ enum hud {
 	hud_wanted,
 	hud_speedometer,
 	hud_statdisplay,
-	hud_inputdisplay,
 	hud_nametags,
 	hud_driftgauge,
 	hud_freeplay,

src/lua_hudlib.c

@@ -30,10 +30,6 @@
 #include "lua_hud.h"
 #include "lua_hook.h"
 
-#ifdef ROTSPRITE
-#include "r_patchrotation.h"
-#endif
-
 #define HUDONLY if (!hud_running) return luaL_error(L, "HUD rendering code should not be called outside of rendering hooks!");
 
 boolean hud_running = false;
@@ -65,7 +61,6 @@ static const char *const hud_disable_options[] = {
 	"wanted",
 	"speedometer",
 	"statdisplay",
-	"inputdisplay",
 	"nametags",
 	"driftgauge",
 	"freeplay",
@@ -192,8 +187,7 @@ enum hudoffsets {
 	hudoffsets_check,
 	hudoffsets_minimap,
 	hudoffsets_wanted,
-	hudoffsets_statdisplay,
-	hudoffsets_inputdisplay,
+	hudoffsets_statdisplay
 };
 
 static const char *const hud_offsets_options[] = {
@@ -209,7 +203,6 @@ static const char *const hud_offsets_options[] = {
 	"minimap",
 	"wanted",
 	"statdisplay",
-	"inputdisplay",
 	NULL};
 
 enum huddrawinfo {
@@ -297,13 +290,9 @@ static int patch_get(lua_State *L)
 	patch_t *patch = *((patch_t **)luaL_checkudata(L, 1, META_PATCH));
 	enum patch field = Lua_optoption(L, 2, -1, patch_fields_ref);
 
-	if (!patch) {
-		if (field == patch_valid) {
-			lua_pushboolean(L, 0);
-			return 1;
-		}
-		return LUA_ErrInvalid(L, "patch_t");
-	}
+	// patches are CURRENTLY always valid, expected to be cached with PU_STATIC
+	// this may change in the future, so patch.valid still exists
+	I_Assert(patch != NULL);
 
 	switch (field)
 	{
@@ -311,16 +300,16 @@ static int patch_get(lua_State *L)
 		lua_pushboolean(L, patch != NULL);
 		break;
 	case patch_width:
-		lua_pushinteger(L, patch->width);
+		lua_pushinteger(L, SHORT(patch->width));
 		break;
 	case patch_height:
-		lua_pushinteger(L, patch->height);
+		lua_pushinteger(L, SHORT(patch->height));
 		break;
 	case patch_leftoffset:
-		lua_pushinteger(L, patch->leftoffset);
+		lua_pushinteger(L, SHORT(patch->leftoffset));
 		break;
 	case patch_topoffset:
-		lua_pushinteger(L, patch->topoffset);
+		lua_pushinteger(L, SHORT(patch->topoffset));
 		break;
 	}
 	return 1;
@@ -404,7 +393,7 @@ static int libd_patchExists(lua_State *L)
 static int libd_cachePatch(lua_State *L)
 {
 	HUDONLY
-	LUA_PushUserdata(L, W_CachePatchName(luaL_checkstring(L, 1), PU_PATCH), META_PATCH);
+	LUA_PushUserdata(L, W_CachePatchName(luaL_checkstring(L, 1), PU_STATIC), META_PATCH);
 	return 1;
 }
 
@@ -414,7 +403,7 @@ static int libd_cachePatchRotated(lua_State *L)
 	HUDONLY
 	angle_t rollangle = luaL_checkangle(L, 2);
 	INT32 rot = R_GetRollAngle(rollangle);
-	LUA_PushUserdata(L, W_CachePatchNameRotated(luaL_checkstring(L, 1), rot, PU_PATCH), META_PATCH);
+	LUA_PushUserdata(L, W_CachePatchNameRotated(luaL_checkstring(L, 1), rot, PU_STATIC), META_PATCH);
 
 	return 1;
 }
@@ -524,7 +513,7 @@ static int libd_getSpritePatch(lua_State *L)
 
 		if (rot)
 		{
-			patch_t *rotsprite = Patch_GetRotatedSprite(sprframe, frame, angle, sprframe->flip & (1<<angle), sprinfo, rot);
+			patch_t *rotsprite = Patch_GetRotatedSprite(sprframe, frame, angle, sprframe->flip & (1<<angle), false, sprinfo, rot);
 			LUA_PushUserdata(L, rotsprite, META_PATCH);
 			lua_pushboolean(L, false);
 			lua_pushboolean(L, true);
@@ -534,7 +523,7 @@ static int libd_getSpritePatch(lua_State *L)
 #endif
 
 	// push both the patch and its "flip" value
-	LUA_PushUserdata(L, W_CachePatchNum(sprframe->lumppat[angle], PU_SPRITE), META_PATCH);
+	LUA_PushUserdata(L, W_CachePatchNum(sprframe->lumppat[angle], PU_STATIC), META_PATCH);
 	lua_pushboolean(L, (sprframe->flip & (1<<angle)) != 0);
 	return 2;
 }
@@ -550,8 +539,6 @@ static int libd_draw(lua_State *L)
 	x = luaL_checkinteger(L, 1);
 	y = luaL_checkinteger(L, 2);
 	patch = *((patch_t **)luaL_checkudata(L, 3, META_PATCH));
-	if (!patch)
-		return LUA_ErrInvalid(L, "patch_t");
 	flags = luaL_optinteger(L, 4, 0);
 	if (!lua_isnoneornil(L, 5))
 		colormap = *((UINT8 **)luaL_checkudata(L, 5, META_COLORMAP));
@@ -585,8 +572,6 @@ static int libd_drawScaled(lua_State *L)
 	if (scale < 0)
 		return luaL_error(L, "negative scale");
 	patch = *((patch_t **)luaL_checkudata(L, 4, META_PATCH));
-	if (!patch)
-		return LUA_ErrInvalid(L, "patch_t");
 	flags = luaL_optinteger(L, 5, 0);
 	if (!lua_isnoneornil(L, 6))
 		colormap = *((UINT8 **)luaL_checkudata(L, 6, META_COLORMAP));
@@ -614,16 +599,71 @@ static int libd_drawOnMinimap(lua_State *L)
 	boolean centered;	// the patch is centered and doesn't need readjusting on x/y coordinates.
 	huddrawlist_h list;
 	patch_t *AutomapPic = NULL;
-	drawinfo_t info;
+
+	// base position of the minimap which also takes splits into account:
+	INT32 MM_X, MM_Y;
 
 	// variables used for actually drawing the icon:
 	INT32 splitflags, minimaptrans;
 	fixed_t amnumxpos, amnumypos;
 	fixed_t amxpos, amypos;
 	INT32 mm_x, mm_y;
-	fixed_t patchw = 0, patchh = 0;
+	fixed_t patchw, patchh;
 
-	HUDONLY // only run this function in hud hooks
+	HUDONLY	// only run this function in hud hooks
+	x = luaL_checkinteger(L, 1);
+	y = luaL_checkinteger(L, 2);
+	scale = luaL_checkinteger(L, 3);
+	patch = *((patch_t **)luaL_checkudata(L, 4, META_PATCH));
+	if (!lua_isnoneornil(L, 5))
+		colormap = *((UINT8 **)luaL_checkudata(L, 5, META_COLORMAP));
+	centered = lua_optboolean(L, 6);
+
+	// first, check what position the mmap is supposed to be in (pasted from k_kart.c):
+	MM_X = BASEVIDWIDTH - 50 + cv_mini_xoffset.value;		// 270
+	MM_Y = (BASEVIDHEIGHT/2)-16 + cv_mini_yoffset.value; //  84
+	if (splitscreen)
+	{
+		MM_Y = (BASEVIDHEIGHT/2) + cv_mini_yoffset.value;
+		if (splitscreen > 1)	// 3P : bottom right
+		{
+			MM_X = (3*BASEVIDWIDTH/4) + cv_mini_xoffset.value;
+			MM_Y = (3*BASEVIDHEIGHT/4) + cv_mini_yoffset.value;
+
+			if (splitscreen > 2) // 4P: centered
+			{
+				MM_X = (BASEVIDWIDTH/2) + cv_mini_xoffset.value;
+				MM_Y = (BASEVIDHEIGHT/2) + cv_mini_yoffset.value;
+			}
+		}
+	}
+
+	// splitscreen flags
+	splitflags = (splitscreen == 3 ? 0 : V_SNAPTORIGHT);	// flags should only be 0 when it's centered (4p split)
+
+	// translucency:
+	if (timeinmap > 105)
+	{
+		minimaptrans = cv_kartminimap.value;
+		if (timeinmap <= 113)
+			minimaptrans = ((((INT32)timeinmap) - 105)*minimaptrans)/(113-105);
+		if (!minimaptrans)
+			return 0;
+	}
+	else
+		return 0;
+
+	minimaptrans = ((10-minimaptrans)<<FF_TRANSSHIFT);
+	splitflags |= minimaptrans;
+
+	if (!(splitscreen == 2))
+	{
+		splitflags &= ~minimaptrans;
+		splitflags |= V_HUDTRANSHALF;
+	}
+
+	splitflags &= ~V_HUDTRANSHALF;
+	splitflags |= V_HUDTRANS;
 
 	// Draw the HUD only when playing in a level.
 	// hu_stuff needs this, unlike st_stuff.
@@ -640,58 +680,29 @@ static int libd_drawOnMinimap(lua_State *L)
 		return 0; // no pic, just get outta here
 	}
 
-	minimaptrans = K_getMinimapTrans();
-
-	// Exit early if it wouldn't draw anyway.
-	if (minimaptrans == -1)
-		return 0;
-
-	x = luaL_checkinteger(L, 1);
-	y = luaL_checkinteger(L, 2);
-	scale = luaL_checkinteger(L, 3);
-	patch = *((patch_t **)luaL_checkudata(L, 4, META_PATCH));
-	if (!patch)
-		return LUA_ErrInvalid(L, "patch_t");
-	if (!lua_isnoneornil(L, 5))
-		colormap = *((UINT8 **)luaL_checkudata(L, 5, META_COLORMAP));
-	centered = lua_optboolean(L, 6);
-
-	K_getMinimapDrawinfo(&info);
-
-	splitflags = info.flags;
-	splitflags |= minimaptrans;
-
-	if (!(splitscreen == 2))
-	{
-		splitflags &= ~minimaptrans;
-		splitflags |= V_HUDTRANSHALF;
-	}
-
-	splitflags &= ~V_HUDTRANSHALF;
-	splitflags |= V_HUDTRANS;
-
 	// Handle offsets and stuff.
-	mm_x = info.x - (AutomapPic->width/2);
-	mm_y = info.y - (AutomapPic->height/2);
+	mm_x = MM_X - (SHORT(AutomapPic->width)/2);
+	mm_y = MM_Y - (SHORT(AutomapPic->height)/2);
 
 	// let offsets transfer to the heads, too!
 	if (encoremode)
 	{
-		mm_x += AutomapPic->leftoffset;
+		mm_x += SHORT(AutomapPic->leftoffset);
 	}
 	else
 	{
-		mm_x -= AutomapPic->leftoffset;
+		mm_x -= SHORT(AutomapPic->leftoffset);
 	}
 
-	mm_y -= AutomapPic->topoffset;
+	mm_y -= SHORT(AutomapPic->topoffset);
 
-	// patch is supposedly already centered, don't butt in.
-	if (!centered)
+	// scale patch coords
+	patchw = (SHORT(patch->width) * scale / 2);
+	patchh = (SHORT(patch->height) * scale / 2);
+
+	if (centered)
 	{
-		// scale patch coords
-		patchw = (patch->width * scale / 2);
-		patchh = (patch->height * scale / 2);
+		patchw = patchh = 0;	// patch is supposedly already centered, don't butt in.
 	}
 
 	amnumxpos = (FixedMul(x, minimapinfo.zoom) - minimapinfo.offs_x);
@@ -702,8 +713,13 @@ static int libd_drawOnMinimap(lua_State *L)
 		amnumxpos = -amnumxpos;
 	}
 
-	amxpos = amnumxpos + ((mm_x + AutomapPic->width / 2)<<FRACBITS) - patchw;
-	amypos = amnumypos + ((mm_y + AutomapPic->height / 2)<<FRACBITS) - patchh;
+	amxpos = amnumxpos + ((mm_x + SHORT(AutomapPic->width) / 2)<<FRACBITS) - patchw;
+	amypos = amnumypos + ((mm_y + SHORT(AutomapPic->height) / 2)<<FRACBITS) - patchh;
+
+	// and NOW we can FINALLY DRAW OUR GOD DAMN PATCH :V
+	lua_getfield(L, LUA_REGISTRYINDEX, "HUD_DRAW_LIST");
+	list = (huddrawlist_h) lua_touserdata(L, -1);
+	lua_pop(L, 1);
 
 	if (cv_minihead.value)
 	{
@@ -712,11 +728,6 @@ static int libd_drawOnMinimap(lua_State *L)
 		scale /= 2;
 	}
 
-	// and NOW we can FINALLY DRAW OUR GOD DAMN PATCH :V
-	lua_getfield(L, LUA_REGISTRYINDEX, "HUD_DRAW_LIST");
-	list = (huddrawlist_h) lua_touserdata(L, -1);
-	lua_pop(L, 1);
-
 	if (LUA_HUD_IsDrawListValid(list))
 	{
 		LUA_HUD_AddDrawScaled(list, amxpos, amypos, scale, patch, splitflags, colormap, 0);
@@ -747,8 +758,6 @@ static int libd_drawStretched(lua_State *L)
 	if (vscale < 0)
 		return luaL_error(L, "negative vertical scale");
 	patch = *((patch_t **)luaL_checkudata(L, 5, META_PATCH));
-	if (!patch)
-		return LUA_ErrInvalid(L, "patch_t");
 	flags = luaL_optinteger(L, 6, 0);
 	if (!lua_isnoneornil(L, 7))
 		colormap = *((UINT8 **)luaL_checkudata(L, 7, META_COLORMAP));
@@ -922,37 +931,35 @@ static int libd_drawString(lua_State *L)
 	if (LUA_HUD_IsDrawListValid(list))
 		LUA_HUD_AddDrawString(list, x, y, str, flags, align);
 	else
+	switch(align)
 	{
-		switch(align)
-		{
-			// hu_font
-			case align_left:
-				V_DrawString(x, y, flags, str);
-				break;
-			case align_center:
-				V_DrawCenteredString(x, y, flags, str);
-				break;
-			case align_right:
-				V_DrawRightAlignedString(x, y, flags, str);
-				break;
-			case align_fixed:
-				V_DrawStringAtFixed(x, y, flags, str);
-				break;
-			// hu_font, 0.5x scale
-			case align_small:
-				V_DrawSmallString(x, y, flags, str);
-				break;
-			case align_smallright:
-				V_DrawRightAlignedSmallString(x, y, flags, str);
-				break;
-			// tny_font
-			case align_thin:
-				V_DrawThinString(x, y, flags, str);
-				break;
-			case align_thinright:
-				V_DrawRightAlignedThinString(x, y, flags, str);
-				break;
-		}
+	// hu_font
+	case align_left:
+		V_DrawString(x, y, flags, str);
+		break;
+	case align_center:
+		V_DrawCenteredString(x, y, flags, str);
+		break;
+	case align_right:
+		V_DrawRightAlignedString(x, y, flags, str);
+		break;
+	case align_fixed:
+		V_DrawStringAtFixed(x, y, flags, str);
+		break;
+	// hu_font, 0.5x scale
+	case align_small:
+		V_DrawSmallString(x, y, flags, str);
+		break;
+	case align_smallright:
+		V_DrawRightAlignedSmallString(x, y, flags, str);
+		break;
+	// tny_font
+	case align_thin:
+		V_DrawThinString(x, y, flags, str);
+		break;
+	case align_thinright:
+		V_DrawRightAlignedThinString(x, y, flags, str);
+		break;
 	}
 	return 0;
 }
@@ -1039,8 +1046,7 @@ static int libd_getColorHudPatch(lua_State *L)
 	UINT8 *colormap = R_GetTranslationColormap(TC_DEFAULT, K_GetHudColor(), GTC_CACHE);
 	boolean small, dark;
 
-	switch (option)
-	{
+	switch (option) {
 		case hudpatch_item:
 			small = lua_optboolean(L, 2);
 			dark = lua_optboolean(L, 3);
@@ -1312,7 +1318,6 @@ static int lib_hudgetoffsets(lua_State *L)
 		case hudoffsets_minimap:        OFS(mini)
 		case hudoffsets_wanted:         OFS(want)
 		case hudoffsets_statdisplay:    OFS(stat)
-		case hudoffsets_inputdisplay:   OFS(wheel)
 		default:
 			return 0; // unreachable
 	}

src/lua_hudlib_drawlist.c

@@ -299,7 +299,6 @@ static void CalcFillCoords(drawitem_t *item)
 			else if (!(c & V_SNAPTOLEFT))
 				x += (vid.width - (BASEVIDWIDTH * dupx)) / 2;
 		}
-
 		if (vid.height != BASEVIDHEIGHT * dupy)
 		{
 			// same thing here
@@ -308,7 +307,6 @@ static void CalcFillCoords(drawitem_t *item)
 			else if (!(c & V_SNAPTOTOP))
 				y += (vid.height - (BASEVIDHEIGHT * dupy)) / 2;
 		}
-
 		if (c & V_SPLITSCREEN)
 			y += (BASEVIDHEIGHT * dupy)/2;
 		if (c & V_HORZSCREEN)
@@ -336,7 +334,6 @@ static UINT64 GetItemId(void)
 		id |= INTERP_LATCH;
 		hud_interplatch = false;
 	}
-
 	if (hud_interpstring)
 		id |= INTERP_STRING;
 
@@ -642,12 +639,18 @@ void LUA_HUD_DrawList(huddrawlist_h list)
 		switch (item->type)
 		{
 			case DI_Draw:
+				if (!item->patch || item->patch == NULL)
+					return;
 				V_DrawBlendingFixedPatch(LERPS(x), LERPS(y), FRACUNIT, item->flags, item->patch, item->colormap, item->blend);
 				break;
 			case DI_DrawScaled:
+				if (!item->patch || item->patch == NULL)
+					return;
 				V_DrawBlendingFixedPatch(LERPS(x), LERPS(y), LERP(scale), item->flags, item->patch, item->colormap, item->blend);
 				break;
 			case DI_DrawStretched:
+				if (!item->patch || item->patch == NULL)
+					return;
 				V_DrawStretchyFixedPatch(LERPS(x), LERPS(y), LERP(hscale), LERP(vscale), item->flags, item->patch, item->colormap, item->blend);
 				break;
 			case DI_DrawNum:

src/lua_infolib.c

@@ -154,7 +154,7 @@ static int lib_setState(lua_State *L)
 		return luaL_error(L, "Do not alter states in BuildCMD code!");
 
 	// clear the state to start with, in case of missing table elements
-	memset(state, 0, sizeof(state_t));
+	memset(state,0,sizeof(state_t));
 	state->tics = -1;
 
 	lua_pushnil(L);
@@ -262,8 +262,8 @@ boolean LUA_CallAction(enum actionnum actionnum, mobj_t *actor)
 		return false; // action not called.
 
 	if (superstack && fasticmp(actionpointers[actionnum].name, superactions[superstack-1])) // the action is calling itself,
-		return false; // let it call the hardcoded function
-
+		return false; // let it call the hardcoded function 
+		
 	lua_pushcfunction(gL, LUA_GetErrorMessage);
 
 	// grab function by uppercase name.
@@ -514,7 +514,7 @@ static int lib_setMobjInfo(lua_State *L)
 		return luaL_error(L, "Do not alter mobjinfo in BuildCMD code!");
 
 	// clear the mobjinfo to start with, in case of missing table elements
-	memset(info, 0, sizeof(mobjinfo_t));
+	memset(info,0,sizeof(mobjinfo_t));
 	info->doomednum = -1; // default to no editor value
 	info->spawnhealth = 1; // avoid 'dead' noclip behaviors
 

src/lua_mobjlib.c

@@ -392,16 +392,16 @@ int mobj_skin_getter(lua_State *L)
     mobj_t *mo = GETMO();
 
     if (!mo->skin)
-        return 0;
-
-    // HUD ONLY!!!!!!!!!!
-    if (hud_running && cv_luaimmersion.value)
-    {
-        lua_pushstring(L, K_GetMobjSkin(mo)->name);
-    }
-    else
-        lua_pushstring(L, ((skin_t *)mo->skin)->name);
+		return 0;
 
+	if (hud_running && cv_luaimmersion.value) {
+			if (mo->localskin) // HUD ONLY!!!!!!!!!!
+				lua_pushstring(L, ((skin_t *)mo->localskin)->name);
+			else
+				lua_pushstring(L, ((skin_t *)mo->skin)->name);
+		} else {
+			lua_pushstring(L, ((skin_t *)mo->skin)->name);
+		}
     return 1;
 }
 
@@ -452,7 +452,7 @@ int mobj_localskin_setter(lua_State *L)
 		strlcpy(skin, luaL_optstring(L, 2, "none"), sizeof skin);
 		strlwr(skin); // all skin names are lowercase
 
-		if (stricmp(skin, "none"))
+		if (strcasecmp(skin, "none"))
 		{
 			// Try localskins
 			for (i = 0; i < numlocalskins; i++)
@@ -468,7 +468,7 @@ int mobj_localskin_setter(lua_State *L)
 			// Try other skins
 			for (i = 0; i < numskins; i++)
 			{
-				if (stricmp(skins[i].name, skin) == 0)
+				if (fastcmp(skins[i].name, skin))
 				{
 					mo->localskin = &skins[i];
 					mo->skinlocal = false;
@@ -483,6 +483,7 @@ int mobj_localskin_setter(lua_State *L)
 		}
 	}
 
+
 	return 0;
 }
 
@@ -501,12 +502,12 @@ int mobj_color_setter(lua_State *L)
 int mobj_blendmode_setter(lua_State *L)
 {
     mobj_t *mo = GETMO();
-
+    
 	INT32 blendmode = (INT32)luaL_checkinteger(L, 2);
 	if (blendmode < 0 || blendmode > AST_OVERLAY)
 		return luaL_error(L, "mobj.blendmode %d out of range (0 - %d).", blendmode, AST_OVERLAY);
 	mo->blendmode = blendmode;
-
+	
     return 0;
 }
 

src/lua_playerlib.c

@@ -295,7 +295,7 @@ int player_localskin_getter(lua_State *L)
 	player_t *plr = GETPLAYER();
 
 	if (plr->localskin)
-		lua_pushstring(L, K_GetPlayerSkin(plr)->name);
+		lua_pushstring(L, (plr->skinlocal ? localskins : skins)[plr->localskin - 1].name);
 	else
 		lua_pushnil(L);
 
@@ -485,7 +485,6 @@ static int lib_iterateDisplayplayers(lua_State *L)
 
 		if (!players[displayplayers[i]].mo)
 			continue;
-
 		LUA_PushUserdata(L, &players[displayplayers[i]], META_PLAYER);
 		lua_pushinteger(L, i);	// push this to recall what number we were on for the next function call. I suppose this also means you can retrieve the splitscreen player number with 'for p, n in displayplayers.iterate'!
 		return 2;

src/lua_script.c

@@ -696,7 +696,6 @@ static UINT8 ArchiveValue(UINT8 **p, int TABLESINDEX, int myindex)
 			}
 			lua_pop(gL, 1);
 		}
-
 		if (!found)
 		{
 			t++;
@@ -861,8 +860,7 @@ static void ArchiveExtVars(UINT8 **p, void *pointer, const char *ptype)
 	int TABLESINDEX;
 	UINT16 i;
 
-	if (!gL)
-	{
+	if (!gL) {
 		if (fastcmp(ptype,"player")) // players must always be included, even if no vars
 			WRITEUINT16(*p, 0);
 		return;
@@ -899,10 +897,8 @@ static void ArchiveExtVars(UINT8 **p, void *pointer, const char *ptype)
 
 	if (fastcmp(ptype,"mobj")) // mobjs must write their mobjnum as a header
 		WRITEUINT32(*p, ((mobj_t *)pointer)->mobjnum);
-
 	WRITEUINT16(*p, i);
 	lua_pushnil(gL);
-
 	while (lua_next(gL, -2))
 	{
 		I_Assert(lua_type(gL, -2) == LUA_TSTRING);
@@ -1235,6 +1231,7 @@ void LUA_Archive(savebuffer_t *save, boolean network)
 		WRITEUINT32(save->p, UINT32_MAX); // end of mobjs marker, replaces mobjnum.
 
 		LUA_HookNetArchive(NetArchive, save); // call the NetArchive hook in archive mode
+		//LUA_HookNetArchive(NetArchive); // call the NetArchive hook in archive mode
 	}
 
 	ArchiveTables(&save->p);
@@ -1275,6 +1272,7 @@ void LUA_UnArchive(savebuffer_t *save, boolean network)
 		} while(mobjnum != UINT32_MAX); // repeat until end of mobjs marker.
 
 		LUA_HookNetArchive(NetUnArchive, save); // call the NetArchive hook in unarchive mode
+		//LUA_HookNetArchive(NetUnArchive); // call the NetArchive hook in unarchive mode
 	}
 
 	UnArchiveTables(&save->p, network);

src/lua_script.h

@@ -64,6 +64,7 @@ void LUA_CVarChanged(const char *name); // lua_consolelib.c
 int Lua_optoption(lua_State *L, int narg, int def, int list_ref);
 int Lua_CreateFieldTable(lua_State *L, const char *const lst[]);
 void LUA_HookNetArchive(lua_CFunction archFunc, savebuffer_t *save);
+//void LUA_HookNetArchive(lua_CFunction archFunc);
 
 // Console wrapper
 void COM_Lua_f(void);
@@ -81,15 +82,6 @@ void COM_Lua_f(void);
 	}\
 }
 
-#define LUA_LogDeprecated(L,this_func,use_instead)\
-{\
-	static UINT8 seen = 0;\
-	if (!seen) {\
-		seen = 1;\
-		CON_LogMessage(va("\"%s\" is deprecated and will be removed.\nUse \"%s\" instead.\n", this_func, use_instead));\
-	}\
-}
-
 // Warnings about incorrect function usage.
 // Shows once, then never again, like deprecation
 #define LUA_UsageWarning(L, warningmsg)\

src/lzf.c

@@ -37,8 +37,9 @@
 /*
  * Sacrifice very little compression quality in favour of compression speed.
  * This gives almost the same compression as the default code, and is
- * (very roughly) 15% faster. This is the preferred mode of operation.
+ * (very roughly) 15% faster. This is the preferable mode of operation.
  */
+
 #ifndef VERY_FAST
 # define VERY_FAST 1
 #endif
@@ -47,7 +48,7 @@
  * Sacrifice some more compression quality in favour of compression speed.
  * (roughly 1-2% worse compression for large blocks and
  * 9-10% for small, redundant, blocks and >>20% better speed in both cases)
- * In short: when in need for speed, enable this for binary data,
+ * In INT16: when in need for speed, enable this for binary data,
  * possibly disable this for text data.
  */
 #ifndef ULTRA_FAST
@@ -79,8 +80,7 @@
 
 /*
  * You may choose to pre-set the hash table (might be faster on some
- * modern cpus and large (>>64k) blocks, and also makes compression
- * deterministic/repeatable when the configuration otherwise is the same).
+ * modern cpus and large (>>64k) blocks)
  */
 #ifndef INIT_HTAB
 # define INIT_HTAB 1
@@ -88,15 +88,15 @@
 
 /*
  * Avoid assigning values to errno variable? for some embedding purposes
- * (linux kernel for example), this is necessary. NOTE: this breaks
- * the documentation in lzf.h. Avoiding errno has no speed impact.
+ * (linux kernel for example), this is neccessary. NOTE: this breaks
+ * the documentation in lzf.h.
  */
 #ifndef AVOID_ERRNO
 # define AVOID_ERRNO 0
 #endif
 
 /*
- * Whether to pass the LZF_STATE variable as argument, or allocate it
+ * Wether to pass the LZF_STATE variable as argument, or allocate it
  * on the stack. For small-stack environments, define this to 1.
  * NOTE: this breaks the prototype in lzf.h.
  */
@@ -105,11 +105,11 @@
 #endif
 
 /*
- * Whether to add extra checks for input validity in lzf_decompress
+ * Wether to add extra checks for input validity in lzf_decompress
  * and return EINVAL if the input stream has been corrupted. This
  * only shields against overflowing the input buffer and will not
  * detect most corrupted streams.
- * This check is not normally noticeable on modern hardware
+ * This check is not normally noticable on modern hardware
  * (<1% slowdown), but might slow down older cpus considerably.
  */
 #ifndef CHECK_INPUT

src/m_aatree.c

@@ -98,6 +98,7 @@ static aatree_node_t *M_AATreeSet_Node(aatree_node_t *node, UINT32 flags, INT32
 	if (!node)
 	{
 		// Nothing here, so just add where we are
+
 		node = Z_Malloc(sizeof (aatree_node_t), PU_STATIC, NULL);
 		node->level = 1;
 		node->key = key;
@@ -133,11 +134,11 @@ void M_AATreeSet(aatree_t *aatree, INT32 key, void* value)
 // and nodes with value == NULL.
 static void *M_AATreeGet_Node(aatree_node_t *node, INT32 key)
 {
-	if (LIKELY(node))
+	if (node)
 	{
-		if (UNLIKELY(node->key == key))
+		if (node->key == key)
 			return node->value;
-		else if (node->key < key)
+		else if(node->key < key)
 			return M_AATreeGet_Node(node->right, key);
 		else
 			return M_AATreeGet_Node(node->left, key);
@@ -151,6 +152,7 @@ void *M_AATreeGet(aatree_t *aatree, INT32 key)
 	return M_AATreeGet_Node(aatree->root, key);
 }
 
+
 static void M_AATreeIterate_Node(aatree_node_t *node, aatree_iter_t callback)
 {
 	if (node->left) M_AATreeIterate_Node(node->left, callback);

src/m_cheat.c

@@ -864,7 +864,7 @@ static boolean OP_HeightOkay(player_t *player, UINT8 ceiling)
 	{
 		// Truncate position to match where mapthing would be when spawned
 		// (this applies to every further P_GetZAt call as well)
-		fixed_t cheight = P_GetSectorCeilingZAt(sec, (player->mo->x & 0xFFFF0000), (player->mo->y & 0xFFFF0000));
+		fixed_t cheight = sec->c_slope ? P_GetZAt(sec->c_slope, player->mo->x & 0xFFFF0000, player->mo->y & 0xFFFF0000) : sec->ceilingheight;
 
 		if (((cheight - player->mo->z - player->mo->height)>>FRACBITS) >= (1 << (16-ZSHIFT)))
 		{
@@ -875,8 +875,7 @@ static boolean OP_HeightOkay(player_t *player, UINT8 ceiling)
 	}
 	else
 	{
-		fixed_t fheight = P_GetSectorFloorZAt(sec, (player->mo->x & 0xFFFF0000), (player->mo->y & 0xFFFF0000));
-
+		fixed_t fheight = sec->f_slope ? P_GetZAt(sec->f_slope, player->mo->x & 0xFFFF0000, player->mo->y & 0xFFFF0000) : sec->floorheight;
 		if (((player->mo->z - fheight)>>FRACBITS) >= (1 << (16-ZSHIFT)))
 		{
 			CONS_Printf(M_GetText("Sorry, you're too %s to place this object (max: %d %s).\n"), M_GetText("high"),
@@ -923,12 +922,12 @@ static mapthing_t *OP_CreateNewMapThing(player_t *player, UINT16 type, boolean c
 	mt->y = (INT16)(player->mo->y>>FRACBITS);
 	if (ceiling)
 	{
-		fixed_t cheight = P_GetSectorCeilingZAt(sec, (mt->x << FRACBITS), (mt->y << FRACBITS));
+		fixed_t cheight = sec->c_slope ? P_GetZAt(sec->c_slope, mt->x << FRACBITS, mt->y << FRACBITS) : sec->ceilingheight;
 		mt->options = (UINT16)((cheight - player->mo->z - player->mo->height)>>FRACBITS);
 	}
 	else
 	{
-		fixed_t fheight = P_GetSectorFloorZAt(sec, (mt->x << FRACBITS), (mt->y << FRACBITS));
+		fixed_t fheight = sec->f_slope ? P_GetZAt(sec->f_slope, mt->x << FRACBITS, mt->y << FRACBITS) : sec->floorheight;
 		mt->options = (UINT16)((player->mo->z - fheight)>>FRACBITS);
 	}
 	mt->options <<= ZSHIFT;
@@ -985,7 +984,8 @@ void OP_NightsObjectplace(player_t *player)
 		UINT16 angle = (UINT16)(player->anotherflyangle % 360);
 		INT16 temp = (INT16)FixedInt(AngleFixed(player->mo->angle)); // Traditional 2D Angle
 		sector_t *sec = player->mo->subsector->sector;
-		fixed_t fheight = P_GetSectorFloorZAt(sec, (player->mo->x & 0xFFFF0000), (player->mo->y & 0xFFFF0000));
+		fixed_t fheight = sec->f_slope ? P_GetZAt(sec->f_slope, player->mo->x & 0xFFFF0000, player->mo->y & 0xFFFF0000) : sec->floorheight;
+
 
 		player->pflags |= PF_ATTACKDOWN;
 
@@ -1141,12 +1141,12 @@ void OP_ObjectplaceMovement(player_t *player)
 
 		if (!!(mobjinfo[op_currentthing].flags & MF_SPAWNCEILING) ^ !!(cv_opflags.value & MTF_OBJECTFLIP))
 		{
-			fixed_t cheight = P_GetSectorCeilingZAt(sec, (player->mo->x & 0xFFFF0000), (player->mo->y & 0xFFFF0000));
+			fixed_t cheight = sec->c_slope ? P_GetZAt(sec->c_slope, player->mo->x & 0xFFFF0000, player->mo->y & 0xFFFF0000) : sec->ceilingheight;
 			op_displayflags = (UINT16)((cheight - player->mo->z - mobjinfo[op_currentthing].height)>>FRACBITS);
 		}
 		else
 		{
-			fixed_t fheight = P_GetSectorFloorZAt(sec, (player->mo->x & 0xFFFF0000), (player->mo->y & 0xFFFF0000));
+			fixed_t fheight = sec->f_slope ? P_GetZAt(sec->f_slope, player->mo->x & 0xFFFF0000, player->mo->y & 0xFFFF0000) : sec->floorheight;
 			op_displayflags = (UINT16)((player->mo->z - fheight)>>FRACBITS);
 		}
 		op_displayflags <<= ZSHIFT;

src/m_cond.c

@@ -21,7 +21,6 @@
 #include "r_things.h" // numskins
 //#include "r_draw.h" // R_GetColorByName
 #include "k_kart.h" // K_GetKartColorByName
-#include "k_stats.h"
 
 // Map triggers for linedef executors
 // 32 triggers, one bit each
@@ -287,9 +286,9 @@ UINT8 M_CheckCondition(condition_t *cn)
 	switch (cn->type)
 	{
 		case UC_PLAYTIME: // Requires total playing time >= x
-			return (kartstats.totalplaytime >= (unsigned)cn->requirement);
+			return (totalplaytime >= (unsigned)cn->requirement);
 		case UC_MATCHESPLAYED: // Requires any level completed >= x times
-			return (kartstats.matchesplayed >= (unsigned)cn->requirement);
+			return (matchesplayed >= (unsigned)cn->requirement);
 		case UC_GAMECLEAR: // Requires game beaten >= x times
 			return (timesBeaten >= (unsigned)cn->requirement);
 		case UC_ALLEMERALDS: // Requires game beaten with all 7 emeralds >= x times
@@ -385,7 +384,9 @@ UINT8 M_UpdateUnlockablesAndExtraEmblems(boolean force)
 	INT32 i;
 	char cechoText[992] = "";
 	UINT8 cechoLines = 0;
-	(void)force;
+
+	if (majormods && !force) // SRB2Kart: for enabling unlocks online in modified servers
+		return false;
 
 	M_CheckUnlockConditions();
 

src/m_menu.h

@@ -33,16 +33,6 @@ extern boolean forceshowhud;
 // Does all the real work of the menu interaction.
 boolean M_Responder(event_t *ev);
 
-// for scrolling through menus with controllers
-extern boolean dpadscrollstate[4];
-enum
-{
-	DPAD_UP,
-	DPAD_DOWN,
-	DPAD_LEFT,
-	DPAD_RIGHT
-};
-
 // Called by main loop, runs for demo playback. If this returns true, nullify any further user input.
 boolean M_DemoResponder(event_t *ev);
 
@@ -308,8 +298,6 @@ void Bird_menu_Onchange(void);
 // Saturn Hud menu updating
 void SaturnHud_menu_Onchange(void);
 
-void GameFocus_menu_Onchange (void);
-
 #ifdef HWRENDER
 void M_UpdateOGLMenu(void);
 #endif

src/m_misc.c

@@ -443,6 +443,7 @@ char configfile[MAX_WADPATH];
 // ==========================================================================
 //                          CONFIGURATION
 // ==========================================================================
+static boolean gameconfig_loaded = false; // true once config.cfg loaded AND executed
 
 /** Saves a player's config, possibly to a particular file.
   *
@@ -547,6 +548,10 @@ void M_FirstLoadConfig(void)
 	// don't filter anymore vars and don't let this convsvar be changed
 	COM_BufInsertText(va("%s \"%d\"\n", cv_execversion.name, EXECVERSION));
 	CV_ToggleExecVersion(false);
+
+	// make sure I_Quit() will write back the correct config
+	// (do not write back the config if it crash before)
+	gameconfig_loaded = true;
 }
 
 /** Saves the game configuration.
@@ -560,7 +565,7 @@ void M_SaveConfig(const char *filename)
 	char backupfile[MAX_WADPATH+4];
 
 	// make sure not to write back the config until it's been correctly loaded
-	if (!loaded_config)
+	if (!gameconfig_loaded)
 		return;
 
 	// Create backup of the config file
@@ -1577,9 +1582,9 @@ boolean M_ScreenshotResponder(event_t *ev)
 	if (ch >= KEY_MOUSE1 && menuactive) // If it's not a keyboard key, then don't allow it in the menus!
 		return false;
 
-	if (ch == KEY_F8 || ch == gamecontrol[0][gc_screenshot][0] || ch == gamecontrol[0][gc_screenshot][1]) // remappable F8
+	if (ch == KEY_F8 || ch == gamecontrol[gc_screenshot][0] || ch == gamecontrol[gc_screenshot][1]) // remappable F8
 		M_ScreenShot();
-	else if (ch == KEY_F9 || ch == gamecontrol[0][gc_recordgif][0] || ch == gamecontrol[0][gc_recordgif][1]) // remappable F9
+	else if (ch == KEY_F9 || ch == gamecontrol[gc_recordgif][0] || ch == gamecontrol[gc_recordgif][1]) // remappable F9
 		((moviemode) ? M_StopMovie : M_StartMovie)();
 	else
 		return false;
@@ -1663,6 +1668,7 @@ failure:
 #endif //#ifdef USE_PNG
 }
 
+
 // ==========================================================================
 //                       TRANSLATION FUNCTIONS
 // ==========================================================================

src/m_perfstats.c

@@ -126,11 +126,11 @@ perfstatrow_t commoncounter_rows[] = {
 	{0}
 };
 
-perfstatrow_t interpolation_rows[] = {
-	{"intpfrc", "Interp frac: ", &ps_interp_frac, 0},
-	{"intplag", "Interp lag:  ", &ps_interp_lag, 0},
+/*perfstatrow_t interpolation_rows[] = {
+	{"intpfrc", "Interp frac: ", &ps_interp_frac, PS_TIME},
+	{"intplag", "Interp lag:  ", &ps_interp_lag, PS_TIME},
 	{0}
-};
+};*/
 
 #ifdef HWRENDER
 perfstatrow_t batchcount_rows[] = {
@@ -214,7 +214,6 @@ void PS_SetPreThinkFrameHookInfo(int index, precise_t time_taken, char* short_sr
 		// array needs to be initialized
 		prethinkframe_hooks = Z_Calloc(sizeof(ps_hookinfo_t) * prethinkframe_hooks_capacity, PU_STATIC, NULL);
 	}
-
 	if (index >= prethinkframe_hooks_capacity)
 	{
 		// array needs more space, realloc with double size
@@ -226,7 +225,6 @@ void PS_SetPreThinkFrameHookInfo(int index, precise_t time_taken, char* short_sr
 			sizeof(ps_hookinfo_t) * prethinkframe_hooks_capacity);
 		prethinkframe_hooks_capacity = new_capacity;
 	}
-
 	prethinkframe_hooks[index].time_taken.value.p = time_taken;
 	memcpy(prethinkframe_hooks[index].short_src, short_src, LUA_IDSIZE * sizeof(char));
 	// since the values are set sequentially from begin to end, the last call should leave
@@ -241,7 +239,6 @@ void PS_SetThinkFrameHookInfo(int index, precise_t time_taken, char* short_src)
 		// array needs to be initialized
 		thinkframe_hooks = Z_Calloc(sizeof(ps_hookinfo_t) * thinkframe_hooks_capacity, PU_STATIC, NULL);
 	}
-
 	if (index >= thinkframe_hooks_capacity)
 	{
 		// array needs more space, realloc with double size
@@ -253,7 +250,6 @@ void PS_SetThinkFrameHookInfo(int index, precise_t time_taken, char* short_src)
 			sizeof(ps_hookinfo_t) * thinkframe_hooks_capacity);
 		thinkframe_hooks_capacity = new_capacity;
 	}
-
 	thinkframe_hooks[index].time_taken.value.p = time_taken;
 	memcpy(thinkframe_hooks[index].short_src, short_src, LUA_IDSIZE * sizeof(char));
 	// since the values are set sequentially from begin to end, the last call should leave
@@ -268,7 +264,6 @@ void PS_SetPostThinkFrameHookInfo(int index, precise_t time_taken, char* short_s
 		// array needs to be initialized
 		postthinkframe_hooks = Z_Calloc(sizeof(ps_hookinfo_t) * postthinkframe_hooks_capacity, PU_STATIC, NULL);
 	}
-
 	if (index >= postthinkframe_hooks_capacity)
 	{
 		// array needs more space, realloc with double size
@@ -280,7 +275,6 @@ void PS_SetPostThinkFrameHookInfo(int index, precise_t time_taken, char* short_s
 			sizeof(ps_hookinfo_t) * postthinkframe_hooks_capacity);
 		postthinkframe_hooks_capacity = new_capacity;
 	}
-
 	postthinkframe_hooks[index].time_taken.value.p = time_taken;
 	memcpy(postthinkframe_hooks[index].short_src, short_src, LUA_IDSIZE * sizeof(char));
 	// since the values are set sequentially from begin to end, the last call should leave
@@ -288,6 +282,8 @@ void PS_SetPostThinkFrameHookInfo(int index, precise_t time_taken, char* short_s
 	postthinkframe_hooks_length = index + 1;
 }
 
+
+
 static boolean PS_HighResolution(void)
 {
 	return (vid.width >= 640 && vid.height >= 400);
@@ -353,7 +349,6 @@ static INT32 PS_GetMetricMinOrMax(ps_metric_t *metric, boolean time_metric, bool
 	for (i = 0; i < cv_ps_samplesize.value; i++)
 	{
 		INT32 value;
-
 		if (time_metric)
 			value = (*((precise_t*)history_read_pos)) / (I_GetPrecisePrecision() / 1000000);
 		else
@@ -364,7 +359,6 @@ static INT32 PS_GetMetricMinOrMax(ps_metric_t *metric, boolean time_metric, bool
 		{
 			found_value = value;
 		}
-
 		history_read_pos += value_size;
 	}
 
@@ -383,7 +377,6 @@ static INT32 PS_GetMetricSD(ps_metric_t *metric, boolean time_metric)
 	for (i = 0; i < cv_ps_samplesize.value; i++)
 	{
 		INT64 value;
-
 		if (time_metric)
 			value = (*((precise_t*)history_read_pos)) / (I_GetPrecisePrecision() / 1000000);
 		else
@@ -403,17 +396,14 @@ static INT32 PS_GetMetricScreenValue(ps_metric_t *metric, boolean time_metric)
 {
 	if (cv_ps_samplesize.value > 1 && metric->history)
 	{
-		switch (cv_ps_descriptor.value)
-		{
-			case 1:
-				return PS_GetMetricAverage(metric, time_metric);
-			case 2:
-				return PS_GetMetricSD(metric, time_metric);
-			case 3:
-				return PS_GetMetricMinOrMax(metric, time_metric, false);
-			default:
-				return PS_GetMetricMinOrMax(metric, time_metric, true);
-		}
+		if (cv_ps_descriptor.value == 1)
+			return PS_GetMetricAverage(metric, time_metric);
+		else if (cv_ps_descriptor.value == 2)
+			return PS_GetMetricSD(metric, time_metric);
+		else if (cv_ps_descriptor.value == 3)
+			return PS_GetMetricMinOrMax(metric, time_metric, false);
+		else
+			return PS_GetMetricMinOrMax(metric, time_metric, true);
 	}
 	else
 	{
@@ -553,8 +543,8 @@ static void PS_UpdateFrameStats(void)
 		if (PS_IsLevelActive())
 			PS_UpdateRowHistories(commoncounter_rows, true);
 
-		if (R_UsingFrameInterpolation())
-			PS_UpdateRowHistories(interpolation_rows, true);
+		/*if (R_UsingFrameInterpolation())
+			PS_UpdateRowHistories(interpolation_rows, true);*/
 
 #ifdef HWRENDER
 		if (rendermode == render_opengl && cv_glbatching.value)
@@ -585,7 +575,6 @@ static void PS_CountThinkers(void)
 	ps_precipcount.value.i = 0;
 	ps_otherthcount.value.i = 0;
 	ps_removecount.value.i = 0;
-
 	for (thinker = thinkercap.next; thinker != &thinkercap; thinker = thinker->next)
 	{
 		ps_thinkercount.value.i++;
@@ -655,7 +644,6 @@ void PS_UpdateTickStats(void)
 	{
 		PS_UpdateRowHistories(gamelogicbrief_row, false);
 	}
-
 	if (cv_perfstats.value == 2)
 	{
 		if (PS_IsLevelActive())
@@ -668,6 +656,8 @@ void PS_UpdateTickStats(void)
 				ps_lua_thinkframe_time.value.p -
 				ps_lua_postthinkframe_time.value.p;
 
+
+
 			PS_CountThinkers();
 		}
 
@@ -678,47 +668,37 @@ void PS_UpdateTickStats(void)
 			PS_UpdateRowHistories(misc_calls_rows, false);
 		}
 	}
-
 	if (cv_ps_samplesize.value > 1)
 	{
-		if (cv_perfstats.value >= 3 && PS_IsLevelActive())
+		if(cv_perfstats.value >= 3 && PS_IsLevelActive())
 		{
-			int i;
-
-			switch (cv_perfstats.value)
+						int i;
+			if (cv_perfstats.value == 3)
 			{
-				case 3:
-					for (i = 0; i < thinkframe_hooks_length; i++)
-					{
-						PS_UpdateMetricHistory(&thinkframe_hooks[i].time_taken, true, false);
-					}
-					break;
-				case 4:
-					for (i = 0; i < prethinkframe_hooks_length; i++)
-					{
-						PS_UpdateMetricHistory(&prethinkframe_hooks[i].time_taken, true, false);
-					}
-					break;
-				case 5:
-					for (i = 0; i < postthinkframe_hooks_length; i++)
-					{
-						PS_UpdateMetricHistory(&postthinkframe_hooks[i].time_taken, true, false);
-					}
-					break;
-				default:
-					break;
+				for (i = 0; i < thinkframe_hooks_length; i++)
+					PS_UpdateMetricHistory(&thinkframe_hooks[i].time_taken, true, false);
+			}
+			else if (cv_perfstats.value == 4)
+			{
+				for (i = 0; i < prethinkframe_hooks_length; i++)
+					PS_UpdateMetricHistory(&prethinkframe_hooks[i].time_taken, true, false);
+			}
+			else if (cv_perfstats.value == 5)
+			{
+				for (i = 0; i < postthinkframe_hooks_length; i++)
+					PS_UpdateMetricHistory(&postthinkframe_hooks[i].time_taken, true, false);
 			}
 		}
 		if (cv_perfstats.value)
 		{
 			ps_tick_index++;
-
 			if (ps_tick_index >= cv_ps_samplesize.value)
 				ps_tick_index = 0;
-
 			if (ps_tick_samples_left)
 				ps_tick_samples_left--;
+
 		}
+
 	}
 }
 
@@ -732,7 +712,6 @@ static void PS_DrawDescriptorHeader(void)
 			"minimum",
 			"maximum"
 		};
-
 		const boolean hires = PS_HighResolution();
 		char* str;
 		INT32 flags = V_MONOSPACE | V_ALLOWLOWERCASE;
@@ -773,7 +752,7 @@ static void PS_DrawRenderStats(void)
 {
 	const boolean hires = PS_HighResolution();
 	const int half_row = hires ? 5 : 4;
-	int x, y, cy = 10;
+	int x, y = 10; //, cy = 10;
 
 	PS_DrawDescriptorHeader();
 
@@ -784,7 +763,7 @@ static void PS_DrawRenderStats(void)
 	if (PS_IsLevelActive())
 	{
 		x = hires ? 115 : 90;
-		cy = PS_DrawPerfRows(x, 10, V_BLUEMAP, commoncounter_rows) + half_row;
+		/*cy = */PS_DrawPerfRows(x, 10, V_BLUEMAP, commoncounter_rows);// + half_row;
 
 #ifdef HWRENDER
 		if (rendermode == render_opengl && cv_glbatching.value)
@@ -799,11 +778,11 @@ static void PS_DrawRenderStats(void)
 #endif
 	}
 
-	if (R_UsingFrameInterpolation())
+	/*if (R_UsingFrameInterpolation())
 	{
 		x = hires ? 115 : 90;
-		PS_DrawPerfRows(x, cy, V_PEACHMAP, interpolation_rows);
-	}
+		PS_DrawPerfRows(x, cy, V_ROSYMAP, interpolation_rows);
+	}*/
 }
 
 static void PS_DrawGameLogicStats(void)
@@ -840,12 +819,12 @@ static void PS_DrawGameLogicStats(void)
 
 static void draw_think_frame_stats(int hook_length, ps_hookinfo_t *hook)
 {
-	char s[100];
+    char s[100];
 	int i;
 	int maxpage = 0;
-	int page = 0;
-	int pagestart = 0;
-	int pageend = 0;
+    int page = 0;
+    int pagestart = 0;
+    int pageend = 0;
 	// text writing position
 	int x = START_X;
 	int y = START_Y;
@@ -853,69 +832,57 @@ static void draw_think_frame_stats(int hook_length, ps_hookinfo_t *hook)
 	char tempbuffer[LUA_IDSIZE];
 	char last_mod_name[LUA_IDSIZE];
 	last_mod_name[0] = '\0';
-	INT32 total = 0;
+    INT32 total = 0;
 
 	//Decide page length based and drawn text on choosen thinker type
-	switch (cv_perfstats.value)
-	{
-		case 3:
-			{
-				maxpage = thinkframe_hooks_length/PAGE_ENTRIES + 1;
-				page = max(1, min(cv_ps_thinkframe_page.value, maxpage));
-				pagestart = min((page - 1)*PAGE_ENTRIES, thinkframe_hooks_length);
-				pageend   = min(pagestart + PAGE_ENTRIES, thinkframe_hooks_length);
-
-				V_DrawSmallString(MAX_X-50, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, "ThinkFrame");
-			}
-			break;
-		case 4:
-			{
-				maxpage = prethinkframe_hooks_length/PAGE_ENTRIES + 1;
-				page = max(1, min(cv_ps_thinkframe_page.value, maxpage));
-				pagestart = min((page - 1)*PAGE_ENTRIES, prethinkframe_hooks_length);
-				pageend   = min(pagestart + PAGE_ENTRIES, prethinkframe_hooks_length);
-				V_DrawSmallString(MAX_X-60, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, "PreThinkFrame");
-			}
-			break;
-		case 5:
-			{
-				maxpage = postthinkframe_hooks_length/PAGE_ENTRIES + 1;
-				page = max(1, min(cv_ps_thinkframe_page.value, maxpage));
-				pagestart = min((page - 1)*PAGE_ENTRIES, postthinkframe_hooks_length);
-				pageend   = min(pagestart + PAGE_ENTRIES, postthinkframe_hooks_length);
-				V_DrawSmallString(MAX_X-65, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, "PostThinkFrame");
-			}
-			break;
-		default:
-			break;
+	if (cv_perfstats.value == 3){
+    	maxpage = thinkframe_hooks_length/PAGE_ENTRIES + 1;
+		page = max(1, min(cv_ps_thinkframe_page.value, maxpage));
+    	pagestart = min((page - 1)*PAGE_ENTRIES, thinkframe_hooks_length);
+    	pageend   = min(pagestart + PAGE_ENTRIES, thinkframe_hooks_length);
+		
+		V_DrawSmallString(MAX_X-50, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, "ThinkFrame");
 	}
+	else if (cv_perfstats.value == 4){
+		maxpage = prethinkframe_hooks_length/PAGE_ENTRIES + 1;
+		page = max(1, min(cv_ps_thinkframe_page.value, maxpage));
+    	pagestart = min((page - 1)*PAGE_ENTRIES, prethinkframe_hooks_length);
+    	pageend   = min(pagestart + PAGE_ENTRIES, prethinkframe_hooks_length);
+		V_DrawSmallString(MAX_X-60, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, "PreThinkFrame");
+	}
+	else if (cv_perfstats.value == 5){
+		maxpage = postthinkframe_hooks_length/PAGE_ENTRIES + 1;
+		page = max(1, min(cv_ps_thinkframe_page.value, maxpage));
+    	pagestart = min((page - 1)*PAGE_ENTRIES, postthinkframe_hooks_length);
+    	pageend   = min(pagestart + PAGE_ENTRIES, postthinkframe_hooks_length);
+		V_DrawSmallString(MAX_X-65, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, "PostThinkFrame");
 
+	}
+	
 	PS_DrawDescriptorHeader();
 
 	for (i = 0; i < hook_length; i++)	
 	{
+
 #define NEXT_ROW() y += HEIGHT;
 
-		INT32 value = PS_GetMetricScreenValue(&hook[i].time_taken, true);
-		total += value;
+        INT32 value = PS_GetMetricScreenValue(&hook[i].time_taken, true);
+        total += value;
 
-		if (i < pagestart || i >= pageend) continue;
+        if (i < pagestart || i >= pageend) continue;
 
 		char* str = hook[i].short_src;
 		char* tempstr = tempbuffer;
 		int len = (int)strlen(str);
 		char* str_ptr;
-
 		if (strcmp(".lua", str + len - 4) == 0)
 		{
 			str[len-4] = '\0'; // remove .lua at end
 			len -= 4;
 		}
-
 		// Print wad name first.
 		strcpy(tempstr, str);
 		str_ptr = strrchr(tempstr, '|');
-
 		if (str_ptr)
 		{
 			*str_ptr = '\0';
@@ -924,12 +891,12 @@ static void draw_think_frame_stats(int hook_length, ps_hookinfo_t *hook)
 			if (str_ptr)
 				tempstr = str_ptr + 1;
 			// tempstr should now point to the mod name, (wad/pk3) possibly truncated
-			strcpy(last_mod_name, tempstr);
-			len = (int)strlen(tempstr);
-			if (len > 30)
-				tempstr += len - 30;
-			snprintf(s, sizeof s - 1, "%s", tempstr);
-			V_DrawSmallString(x, y, V_MONOSPACE | V_ALLOWLOWERCASE | V_GRAYMAP, s);
+            strcpy(last_mod_name, tempstr);
+            len = (int)strlen(tempstr);
+            if (len > 30)
+                tempstr += len - 30;
+            snprintf(s, sizeof s - 1, "%s", tempstr);
+            V_DrawSmallString(x, y, V_MONOSPACE | V_ALLOWLOWERCASE | V_GRAYMAP, s);
 			text_color = V_YELLOWMAP;
 		}
 		else
@@ -941,35 +908,35 @@ static void draw_think_frame_stats(int hook_length, ps_hookinfo_t *hook)
 				str = str_ptr + 1;
 			text_color = 0; // white
 		}
-
 		len = (int)strlen(str);
-
 		if (len > 40)
 			str += len - 40;
-
 		snprintf(s, sizeof s - 1, "%40s: %d", str, value);
 		V_DrawSmallString(x + WIDTH, y, V_MONOSPACE | V_ALLOWLOWERCASE | text_color, s);
 		NEXT_ROW()
 
 #undef NEXT_ROW
+
 	}
 
-	snprintf(s, sizeof s - 1, "TOTAL %d", total);
-	V_DrawSmallString(MAX_X, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, s);
+    snprintf(s, sizeof s - 1, "TOTAL %d", total);
+    V_DrawSmallString(MAX_X, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, s);
 
-	if (maxpage > 1)
-	{
-		snprintf(s, sizeof s - 1, "PAGE %d", page);
-		V_DrawSmallString(START_X, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, s);
-	}
+    if (maxpage > 1) {
+        snprintf(s, sizeof s - 1, "PAGE %d", page);
+        V_DrawSmallString(START_X, MAX_Y+2*HEIGHT, V_MONOSPACE | V_GREENMAP, s);
+    }
+	
+	
 }
 
 void PS_ThinkFrame_Page_OnChange(void)
 {
-	int maxpage = thinkframe_hooks_length/PAGE_ENTRIES + 1;
+    int maxpage = thinkframe_hooks_length/PAGE_ENTRIES + 1;
 
-	if (cv_ps_thinkframe_page.value > maxpage)
-		CV_StealthSetValue(&cv_ps_thinkframe_page, maxpage);
+    if (cv_ps_thinkframe_page.value > maxpage) {
+        CV_StealthSetValue(&cv_ps_thinkframe_page, maxpage);
+    }
 }
 
 #undef WIDTH
@@ -981,6 +948,8 @@ void PS_ThinkFrame_Page_OnChange(void)
 
 #undef PAGE_ENTRIES
 
+
+
 static void PS_DrawPreThinkFrameStats(void)
 {
 	draw_think_frame_stats(prethinkframe_hooks_length, prethinkframe_hooks);
@@ -1014,7 +983,6 @@ void M_DrawPerfStats(void)
 	{
 		if (!PS_IsLevelActive())
 			return;
-
 		if (!PS_HighResolution())
 		{
 			// Low resolutions can't really use V_DrawSmallString that is used by thinkframe stats.
@@ -1024,21 +992,19 @@ void M_DrawPerfStats(void)
 			V_DrawThinString(80, 100, V_MONOSPACE | V_ALLOWLOWERCASE | V_YELLOWMAP, "for resolutions below 640x400.");
 			return;
 		}
-
-		switch (cv_perfstats.value)
+		if (cv_perfstats.value == 3)
 		{
-			case 3:
-				PS_DrawThinkFrameStats();
-				break;
-			case 4:
-				PS_DrawPreThinkFrameStats();
-				break;
-			case 5:
-				PS_DrawPostThinkFrameStats();
-				break;
-			default:
-				break;
+			PS_DrawThinkFrameStats();
 		}
+		else if (cv_perfstats.value == 4)
+		{
+			PS_DrawPreThinkFrameStats();
+		}
+		else if (cv_perfstats.value == 5)
+		{
+			PS_DrawPostThinkFrameStats();
+		}
+
 	}
 }
 
@@ -1048,18 +1014,15 @@ static void PS_ClearHistory(void)
 	int i;
 
 	Z_FreeTags(PU_PERFSTATS, PU_PERFSTATS);
-
 	// thinkframe hook metric history pointers need to be cleared manually
 	for (i = 0; i < prethinkframe_hooks_length; i++)
 	{
 		prethinkframe_hooks[i].time_taken.history = NULL;
 	}
-
 	for (i = 0; i < thinkframe_hooks_length; i++)
 	{
 		thinkframe_hooks[i].time_taken.history = NULL;
 	}
-
 	for (i = 0; i < postthinkframe_hooks_length; i++)
 	{
 		postthinkframe_hooks[i].time_taken.history = NULL;

src/m_perfstats.h

@@ -55,6 +55,7 @@ void PS_SetPreThinkFrameHookInfo(int index, precise_t time_taken, char* short_sr
 void PS_SetThinkFrameHookInfo(int index, precise_t time_taken, char* short_src);
 void PS_SetPostThinkFrameHookInfo(int index, precise_t time_taken, char* short_src);
 
+
 void PS_UpdateTickStats(void);
 
 void M_DrawPerfStats(void);

src/m_random.c

@@ -14,11 +14,13 @@
 
 #include "doomdef.h"
 #include "doomtype.h"
-#include "k_stats.h" // kartstats.totalplaytime
+#include "doomstat.h" // totalplaytime
 
 #include "m_random.h"
 #include "m_fixed.h"
 
+
+
 // ---------------------------
 // RNG functions (not synched)
 // ---------------------------
@@ -250,5 +252,5 @@ void P_SetRandSeedD(const char *rfile, INT32 rline, UINT32 seed)
   */
 UINT32 M_RandomizedSeed(void)
 {
-	return ((kartstats.totalplaytime & 0xFFFF) << 16)|M_RandomFixed();
+	return ((totalplaytime & 0xFFFF) << 16)|M_RandomFixed();
 }

src/p_enemy.c

@@ -3996,7 +3996,10 @@ void A_SignPlayer(mobj_t *actor)
 	if (LUA_CallAction(A_SIGNPLAYER, actor))
 		return;
 
-	if (!actor->target || !actor->target->player)
+	if (!actor->target)
+		return;
+
+	if (!actor->target->player)
 		return;
 
 	// Set the sign to be an appropriate background color for this player's skincolor.
@@ -4008,13 +4011,18 @@ void A_SignPlayer(mobj_t *actor)
 	P_SetTarget(&ov->target, actor);
 	ov->color = actor->target->player->skincolor;
 	ov->skin = &skins[actor->target->player->skin];
-
-	// needs - 1 or else it pukes an error out
-	// same thing happens on p_mobj.c
-	ov->skinlocal = actor->target->skinlocal;
-	if (ov->skinlocal || actor->target->player->localskin)
-		ov->localskin = &K_GetSkinArray(ov->skinlocal)[actor->target->player->localskin - 1];
-
+	if (actor->target->skinlocal) {
+		// needs - 1 or else it pukes an error out
+		// same thing happens on p_mobj.c
+		ov->localskin = &localskins[actor->target->player->localskin - 1];
+		ov->skinlocal = actor->target->skinlocal;
+	} else {
+		// needs - 1 or else it pukes an error out
+		// same thing happens on p_mobj.c
+		if (actor->target->player->localskin)
+			ov->localskin = &skins[actor->target->player->localskin - 1];
+		ov->skinlocal = actor->target->skinlocal;
+	}
 	P_SetMobjState(ov, actor->info->seestate); // S_PLAY_SIGN
 }
 
@@ -9247,7 +9255,7 @@ void A_Custom3DRotate(mobj_t *actor)
 		P_RemoveMobj(actor);
 		return;
 	}
-
+	
 	if (hspeed==0 && vspeed==0)
 	{
 		if (cv_debug)

src/p_floor.c

@@ -2923,7 +2923,6 @@ void EV_CrumbleChain(sector_t *sec, ffloor_t *rover)
 
 	// soundorg z height never gets set normally, so MEH.
 	sec->soundorg.z = sec->floorheight;
-	//sec->soundorg.z = (rover->master->frontsector->floorheight + rover->master->frontsector->ceilingheight)/2; // actual accurate z but well smth smth synchsafe
 	S_StartSound(&sec->soundorg, sfx_crumbl);
 
 	// Find the outermost vertexes in the subsector

src/p_local.h

@@ -158,9 +158,7 @@ extern consvar_t cv_tiltsmoothing;
 
 extern consvar_t cv_actionmovie;
 
-extern consvar_t cv_lookbackmom[MAXSPLITSCREENPLAYERS];
-
-extern consvar_t cv_verticallook[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_lookbackmom;
 
 extern fixed_t t_cam_rotate[MAXSPLITSCREENPLAYERS];
 
@@ -237,6 +235,7 @@ void P_PlayRinglossSound(mobj_t *source, mobj_t *damager);
 void P_PlayDeathSound(mobj_t *source);
 void P_PlayVictorySound(mobj_t *source);
 
+
 //
 // P_MOBJ
 //

src/p_map.c

@@ -26,7 +26,6 @@
 #include "s_sound.h"
 #include "w_wad.h"
 #include "k_kart.h" // SRB2kart 011617
-#include "k_stats.h"
 
 #include "hu_stuff.h" // SRB2kart
 #include "i_system.h" // SRB2kart
@@ -708,8 +707,6 @@ static boolean PIT_CheckThing(mobj_t *thing)
 
 		if (thing->type == MT_PLAYER)
 		{
-			K_StatPlayerSink(thing->player, P_MobjWasRemoved(tmthing->target) ? NULL : tmthing->target->player);
-
 			S_StartSound(NULL, sfx_bsnipe); //let all players hear it.
 			HU_SetCEchoFlags(0);
 			HU_SetCEchoDuration(5);
@@ -977,8 +974,6 @@ static boolean PIT_CheckThing(mobj_t *thing)
 			if ((thing->target == tmthing) && (thing->threshold > 0))
 				return true;
 
-			K_StatPlayerSink(tmthing->player, P_MobjWasRemoved(thing->target) ? NULL : thing->target->player);
-
 			S_StartSound(NULL, sfx_cgot); //let all players hear it.
 			HU_SetCEchoFlags(0);
 			HU_SetCEchoDuration(5);
@@ -1699,7 +1694,7 @@ boolean P_CheckPosition(mobj_t *thing, fixed_t x, fixed_t y)
 	INT32 xl, xh, yl, yh, bx, by;
 	subsector_t *newsubsec;
 	boolean blockval = true;
-
+	
 	ps_checkposition_calls.value.i++;
 
 	I_Assert(thing != NULL);
@@ -4102,7 +4097,10 @@ void P_MapEnd(void)
 fixed_t P_FloorzAtPos(fixed_t x, fixed_t y, fixed_t z, fixed_t height)
 {
 	sector_t *sec = R_PointInSubsector(x, y)->sector;
-	fixed_t floorz = P_GetSectorFloorZAt(sec, x, y);
+	fixed_t floorz = sec->floorheight;
+
+	if (sec->f_slope)
+		floorz = P_GetZAt(sec->f_slope, x, y);
 
 	// Intercept the stupid 'fall through 3dfloors' bug Tails 03-17-2002
 	if (sec->ffloors)
@@ -4113,15 +4111,19 @@ fixed_t P_FloorzAtPos(fixed_t x, fixed_t y, fixed_t z, fixed_t height)
 		for (rover = sec->ffloors; rover; rover = rover->next)
 		{
 			fixed_t topheight, bottomheight;
-
 			if (!(rover->flags & FF_EXISTS))
 				continue;
 
 			if ((!(rover->flags & FF_SOLID || rover->flags & FF_QUICKSAND) || (rover->flags & FF_SWIMMABLE)))
 				continue;
 
-			topheight    = P_GetFFloorTopZAt   (rover, x, y);
-			bottomheight = P_GetFFloorBottomZAt(rover, x, y);
+			topheight = *rover->topheight;
+			bottomheight = *rover->bottomheight;
+
+			if (*rover->t_slope)
+				topheight = P_GetZAt(*rover->t_slope, x, y);
+			if (*rover->b_slope)
+				bottomheight = P_GetZAt(*rover->b_slope, x, y);
 
 			if (rover->flags & FF_QUICKSAND)
 			{
@@ -4135,7 +4137,6 @@ fixed_t P_FloorzAtPos(fixed_t x, fixed_t y, fixed_t z, fixed_t height)
 
 			delta1 = z - (bottomheight + ((topheight - bottomheight)/2));
 			delta2 = thingtop - (bottomheight + ((topheight - bottomheight)/2));
-
 			if (topheight > floorz && abs(delta1) < abs(delta2))
 				floorz = topheight;
 		}

src/p_maputl.c

@@ -294,34 +294,50 @@ void P_CameraLineOpening(line_t *linedef)
 	// If you can see through it, why not move the camera through it too?
 	if (front->camsec >= 0)
 	{
-		frontfloor   = P_GetSectorFloorZAt  (&sectors[front->camsec], camera[0].x, camera[0].y);
-		frontceiling = P_GetSectorCeilingZAt(&sectors[front->camsec], camera[0].x, camera[0].y);
+		frontfloor = sectors[front->camsec].floorheight;
+		frontceiling = sectors[front->camsec].ceilingheight;
+		if (sectors[front->camsec].f_slope)
+			frontfloor = P_GetZAt(sectors[front->camsec].f_slope, camera[0].x, camera[0].y);
+		if (sectors[front->camsec].c_slope)
+			frontceiling = P_GetZAt(sectors[front->camsec].c_slope, camera[0].x, camera[0].y);
 
 	}
 	else if (front->heightsec >= 0)
 	{
-		frontfloor   = P_GetSectorFloorZAt  (&sectors[front->heightsec], camera[0].x, camera[0].y);
-		frontceiling = P_GetSectorCeilingZAt(&sectors[front->heightsec], camera[0].x, camera[0].y);
+		frontfloor = sectors[front->heightsec].floorheight;
+		frontceiling = sectors[front->heightsec].ceilingheight;
+		if (sectors[front->heightsec].f_slope)
+			frontfloor = P_GetZAt(sectors[front->heightsec].f_slope, camera[0].x, camera[0].y);
+		if (sectors[front->heightsec].c_slope)
+			frontceiling = P_GetZAt(sectors[front->heightsec].c_slope, camera[0].x, camera[0].y);
 	}
 	else
 	{
-		frontfloor   = P_CameraGetFloorZ  (mapcampointer, front, tmx, tmy, linedef);
+		frontfloor = P_CameraGetFloorZ(mapcampointer, front, tmx, tmy, linedef);
 		frontceiling = P_CameraGetCeilingZ(mapcampointer, front, tmx, tmy, linedef);
 	}
 
 	if (back->camsec >= 0)
 	{
-		backfloor   = P_GetSectorFloorZAt  (&sectors[back->camsec], camera[0].x, camera[0].y);
-		backceiling = P_GetSectorCeilingZAt(&sectors[back->camsec], camera[0].x, camera[0].y);
+		backfloor = sectors[back->camsec].floorheight;
+		backceiling = sectors[back->camsec].ceilingheight;
+		if (sectors[back->camsec].f_slope)
+			frontfloor = P_GetZAt(sectors[back->camsec].f_slope, camera[0].x, camera[0].y);
+		if (sectors[back->camsec].c_slope)
+			frontceiling = P_GetZAt(sectors[back->camsec].c_slope, camera[0].x, camera[0].y);
 	}
 	else if (back->heightsec >= 0)
 	{
-		backfloor   = P_GetSectorFloorZAt  (&sectors[back->heightsec], camera[0].x, camera[0].y);
-		backceiling = P_GetSectorCeilingZAt(&sectors[back->heightsec], camera[0].x, camera[0].y);
+		backfloor = sectors[back->heightsec].floorheight;
+		backceiling = sectors[back->heightsec].ceilingheight;
+		if (sectors[back->heightsec].f_slope)
+			frontfloor = P_GetZAt(sectors[back->heightsec].f_slope, camera[0].x, camera[0].y);
+		if (sectors[back->heightsec].c_slope)
+			frontceiling = P_GetZAt(sectors[back->heightsec].c_slope, camera[0].x, camera[0].y);
 	}
 	else
 	{
-		backfloor   = P_CameraGetFloorZ(mapcampointer, back, tmx, tmy, linedef);
+		backfloor = P_CameraGetFloorZ(mapcampointer, back, tmx, tmy, linedef);
 		backceiling = P_CameraGetCeilingZ(mapcampointer, back, tmx, tmy, linedef);
 	}
 

src/p_mobj.c

@@ -172,28 +172,20 @@ boolean P_SetPlayerMobjState(mobj_t *mobj, statenum_t state)
 	{
 		// Start flashing, since you've landed.
 		player->powers[pw_flashing] = K_GetKartFlashing(player)-1;
+		//P_DoPityCheck(player);
 	}
 
 	// Set animation state
 	// The pflags version of this was just as convoluted.
 	// Rewriten for SRB2kart ... though I don't know what this is.
-	switch(state)
-	{
-		case S_KART_STND1...S_KART_STND2_R:
-		case S_KART_SQUISH:
-		case S_KART_SPIN:
-			player->panim = PA_IDLE;
-			break;
-		case S_KART_WALK1...S_KART_WALK2_R:
-			player->panim = PA_WALK;
-			break;
-		case S_KART_RUN1...S_KART_DRIFT2_R:
-			player->panim = PA_RUN;
-			break;
-		default:
-			player->panim = PA_ETC;
-			break;
-	}
+	if ((state >= S_KART_STND1 && state <= S_KART_STND2_R) || state == S_KART_SQUISH || state == S_KART_SPIN)
+		player->panim = PA_IDLE;
+	else if (state >= S_KART_WALK1 && state <= S_KART_WALK2_R)
+		player->panim = PA_WALK;
+	else if (state >= S_KART_RUN1 && state <= S_KART_DRIFT2_R)
+		player->panim = PA_RUN;
+	else
+		player->panim = PA_ETC;
 
 	if (recursion++) // if recursion detected,
 		memset(seenstate = tempstate, 0, sizeof tempstate); // clear state table
@@ -502,12 +494,12 @@ static fixed_t HighestOnLine(fixed_t radius, fixed_t x, fixed_t y, line_t *line,
 	/*CONS_Printf("BEFORE: v1 = %f %f %f\n",
 				FIXED_TO_FLOAT(v1.x),
 				FIXED_TO_FLOAT(v1.y),
-				FIXED_TO_FLOAT(P_GetSlopeZAt(slope, v1.x, v1.y))
+				FIXED_TO_FLOAT(P_GetZAt(slope, v1.x, v1.y))
 				);
 	CONS_Printf("        v2 = %f %f %f\n",
 				FIXED_TO_FLOAT(v2.x),
 				FIXED_TO_FLOAT(v2.y),
-				FIXED_TO_FLOAT(P_GetSlopeZAt(slope, v2.x, v2.y))
+				FIXED_TO_FLOAT(P_GetZAt(slope, v2.x, v2.y))
 				);*/
 
 	if (abs(v1.x-x) > radius) {
@@ -565,24 +557,24 @@ static fixed_t HighestOnLine(fixed_t radius, fixed_t x, fixed_t y, line_t *line,
 	/*CONS_Printf("AFTER:  v1 = %f %f %f\n",
 				FIXED_TO_FLOAT(v1.x),
 				FIXED_TO_FLOAT(v1.y),
-				FIXED_TO_FLOAT(P_GetSlopeZAt(slope, v1.x, v1.y))
+				FIXED_TO_FLOAT(P_GetZAt(slope, v1.x, v1.y))
 				);
 	CONS_Printf("        v2 = %f %f %f\n",
 				FIXED_TO_FLOAT(v2.x),
 				FIXED_TO_FLOAT(v2.y),
-				FIXED_TO_FLOAT(P_GetSlopeZAt(slope, v2.x, v2.y))
+				FIXED_TO_FLOAT(P_GetZAt(slope, v2.x, v2.y))
 				);*/
 
 	// Return the higher of the two points
 	if (actuallylowest)
 		return min(
-			P_GetSlopeZAt(slope, v1.x, v1.y),
-			P_GetSlopeZAt(slope, v2.x, v2.y)
+			P_GetZAt(slope, v1.x, v1.y),
+			P_GetZAt(slope, v2.x, v2.y)
 		);
 	else
 		return max(
-			P_GetSlopeZAt(slope, v1.x, v1.y),
-			P_GetSlopeZAt(slope, v2.x, v2.y)
+			P_GetZAt(slope, v1.x, v1.y),
+			P_GetZAt(slope, v2.x, v2.y)
 		);
 }
 
@@ -590,7 +582,6 @@ fixed_t P_MobjFloorZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed_t
 {
 	I_Assert(mobj != NULL);
 	I_Assert(sector != NULL);
-
 	if (sector->f_slope)
 	{
 		fixed_t testx, testy;
@@ -618,7 +609,7 @@ fixed_t P_MobjFloorZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed_t
 
 		// If the highest point is in the sector, then we have it easy! Just get the Z at that point
 		if (R_PointInSubsector(testx, testy)->sector == (boundsec ? boundsec : sector))
-			return P_GetSlopeZAt(slope, testx, testy);
+			return P_GetZAt(slope, testx, testy);
 
 		// If boundsec is set, we're looking for specials. In that case, iterate over every line in this sector to find the TRUE highest/lowest point
 		if (perfect)
@@ -657,11 +648,10 @@ fixed_t P_MobjFloorZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed_t
 		// If we're just testing for base sector location (no collision line), just go for the center's spot...
 		// It'll get fixed when we test for collision anyway, and the final result can't be lower than this
 		if (line == NULL)
-			return P_GetSlopeZAt(slope, x, y);
+			return P_GetZAt(slope, x, y);
 
 		return HighestOnLine(mobj->radius, x, y, line, slope, lowest);
-	}
-	else // Well, that makes it easy. Just get the floor height
+	} else // Well, that makes it easy. Just get the floor height
 		return sector->floorheight;
 }
 
@@ -669,7 +659,6 @@ fixed_t P_MobjCeilingZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed
 {
 	I_Assert(mobj != NULL);
 	I_Assert(sector != NULL);
-
 	if (sector->c_slope)
 	{
 		fixed_t testx, testy;
@@ -697,7 +686,7 @@ fixed_t P_MobjCeilingZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed
 
 		// If the highest point is in the sector, then we have it easy! Just get the Z at that point
 		if (R_PointInSubsector(testx, testy)->sector == (boundsec ? boundsec : sector))
-			return P_GetSlopeZAt(slope, testx, testy);
+			return P_GetZAt(slope, testx, testy);
 
 		// If boundsec is set, we're looking for specials. In that case, iterate over every line in this sector to find the TRUE highest/lowest point
 		if (perfect)
@@ -736,11 +725,10 @@ fixed_t P_MobjCeilingZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed
 		// If we're just testing for base sector location (no collision line), just go for the center's spot...
 		// It'll get fixed when we test for collision anyway, and the final result can't be lower than this
 		if (line == NULL)
-			return P_GetSlopeZAt(slope, x, y);
+			return P_GetZAt(slope, x, y);
 
 		return HighestOnLine(mobj->radius, x, y, line, slope, lowest);
-	}
-	else // Well, that makes it easy. Just get the ceiling height
+	} else // Well, that makes it easy. Just get the ceiling height
 		return sector->ceilingheight;
 }
 
@@ -777,7 +765,7 @@ fixed_t P_CameraFloorZ(camera_t *mobj, sector_t *sector, sector_t *boundsec, fix
 
 		// If the highest point is in the sector, then we have it easy! Just get the Z at that point
 		if (R_PointInSubsector(testx, testy)->sector == (boundsec ? boundsec : sector))
-			return P_GetSlopeZAt(slope, testx, testy);
+			return P_GetZAt(slope, testx, testy);
 
 		// If boundsec is set, we're looking for specials. In that case, iterate over every line in this sector to find the TRUE highest/lowest point
 		if (perfect)
@@ -816,11 +804,10 @@ fixed_t P_CameraFloorZ(camera_t *mobj, sector_t *sector, sector_t *boundsec, fix
 		// If we're just testing for base sector location (no collision line), just go for the center's spot...
 		// It'll get fixed when we test for collision anyway, and the final result can't be lower than this
 		if (line == NULL)
-			return P_GetSlopeZAt(slope, x, y);
+			return P_GetZAt(slope, x, y);
 
 		return HighestOnLine(mobj->radius, x, y, line, slope, lowest);
-	}
-	else // Well, that makes it easy. Just get the floor height
+	} else // Well, that makes it easy. Just get the floor height
 		return sector->floorheight;
 }
 
@@ -856,7 +843,7 @@ fixed_t P_CameraCeilingZ(camera_t *mobj, sector_t *sector, sector_t *boundsec, f
 
 		// If the highest point is in the sector, then we have it easy! Just get the Z at that point
 		if (R_PointInSubsector(testx, testy)->sector == (boundsec ? boundsec : sector))
-			return P_GetSlopeZAt(slope, testx, testy);
+			return P_GetZAt(slope, testx, testy);
 
 		// If boundsec is set, we're looking for specials. In that case, iterate over every line in this sector to find the TRUE highest/lowest point
 		if (perfect)
@@ -895,11 +882,10 @@ fixed_t P_CameraCeilingZ(camera_t *mobj, sector_t *sector, sector_t *boundsec, f
 		// If we're just testing for base sector location (no collision line), just go for the center's spot...
 		// It'll get fixed when we test for collision anyway, and the final result can't be lower than this
 		if (line == NULL)
-			return P_GetSlopeZAt(slope, x, y);
+			return P_GetZAt(slope, x, y);
 
 		return HighestOnLine(mobj->radius, x, y, line, slope, lowest);
-	}
-	else // Well, that makes it easy. Just get the ceiling height
+	} else // Well, that makes it easy. Just get the ceiling height
 		return sector->ceilingheight;
 }
 static void P_PlayerFlip(mobj_t *mo)
@@ -1918,7 +1904,9 @@ boolean P_CheckSolidLava(mobj_t *mo, ffloor_t *rover)
 	I_Assert(mo != NULL);
 	I_Assert(!P_MobjWasRemoved(mo));
 
-	fixed_t topheight = P_GetFFloorTopZAt(rover, mo->x, mo->y);
+	fixed_t topheight =
+		*rover->t_slope ? P_GetZAt(*rover->t_slope, mo->x, mo->y) :
+		*rover->topheight;
 
 	if (rover->flags & FF_SWIMMABLE && GETSECSPECIAL(rover->master->frontsector->special, 1) == 3
 		&& !(rover->master->flags & ML_BLOCKMONSTERS)
@@ -2412,6 +2400,9 @@ static void P_PlayerZMovement(mobj_t *mo)
 			mo->player->viewheight -= (mo->z+mo->height) - mo->ceilingz;
 		else
 			mo->player->viewheight -= mo->floorz - mo->z;
+
+		/*mo->player->deltaviewheight =
+			(FixedMul(cv_viewheight.value<<FRACBITS, mo->scale) - mo->player->viewheight)>>3;*/
 	}
 
 	// adjust height
@@ -2477,6 +2468,11 @@ static void P_PlayerZMovement(mobj_t *mo)
 		{
 			mo->pmomz = 0; // We're on a new floor, don't keep doing platform movement.
 
+			// Squat down. Decrease viewheight for a moment after hitting the ground (hard),
+			/*if (P_MobjFlip(mo)*mo->momz < -FixedMul(8*FRACUNIT, mo->scale))
+				mo->player->deltaviewheight = (P_MobjFlip(mo)*mo->momz)>>3; // make sure momz is negative
+			*/
+
 			if (!tmfloorthing || tmfloorthing->flags & (MF_PUSHABLE|MF_MONITOR)
 				|| tmfloorthing->flags2 & MF2_STANDONME || tmfloorthing->type == MT_PLAYER) // Spin Attack
 			{
@@ -2584,6 +2580,7 @@ static void P_PlayerZMovement(mobj_t *mo)
 					if (!(mo->player->pflags & PF_GLIDING))
 						mo->player->pflags &= ~PF_JUMPED;
 					mo->player->pflags &= ~PF_THOKKED;
+					//mo->player->pflags &= ~PF_GLIDING;
 					mo->player->jumping = 0;
 					mo->player->secondjump = 0;
 					mo->player->glidetime = 0;
@@ -2885,8 +2882,14 @@ void P_MobjCheckWater(mobj_t *mobj)
 		 || ((rover->flags & FF_BLOCKOTHERS) && !mobj->player)))
 			continue;
 
-		topheight    = P_GetFFloorTopZAt(rover, mobj->x, mobj->y);
-		bottomheight = P_GetFFloorBottomZAt(rover, mobj->x, mobj->y);
+		topheight = *rover->topheight;
+		bottomheight = *rover->bottomheight;
+
+		if (*rover->t_slope)
+			topheight = P_GetZAt(*rover->t_slope, mobj->x, mobj->y);
+
+		if (*rover->b_slope)
+			bottomheight = P_GetZAt(*rover->b_slope, mobj->x, mobj->y);
 
 		if (mobj->eflags & MFE_VERTICALFLIP)
 		{
@@ -3104,8 +3107,14 @@ static void P_SceneryCheckWater(mobj_t *mobj)
 			if (!(rover->flags & FF_EXISTS) || !(rover->flags & FF_SWIMMABLE) || rover->flags & FF_BLOCKOTHERS)
 				continue;
 
-			topheight    = P_GetFFloorTopZAt(rover, mobj->x, mobj->y);
-			bottomheight = P_GetFFloorBottomZAt(rover, mobj->x, mobj->y);
+			topheight = *rover->topheight;
+			bottomheight = *rover->bottomheight;
+
+			if (*rover->t_slope)
+				topheight = P_GetZAt(*rover->t_slope, mobj->x, mobj->y);
+
+			if (*rover->b_slope)
+				bottomheight = P_GetZAt(*rover->b_slope, mobj->x, mobj->y);
 
 			if (topheight <= mobj->z
 				|| bottomheight > (mobj->z + FixedMul(mobj->info->height >> 1, mobj->scale)))
@@ -6024,6 +6033,20 @@ static void P_KoopaThinker(mobj_t *koopa)
 //
 void P_RollPitchMobj(mobj_t* mobj)
 {
+	// we dont need this in dedi do we?
+	if (rendermode == render_none)
+		return;
+
+	if (P_MobjWasRemoved(mobj))
+		return;
+
+	if (cv_sloperoll.value != 2)
+	{
+		mobj->sloperoll = 0;
+		mobj->slopepitch = 0;
+		return;
+	}
+
 	K_RollMobjBySlopes(mobj, mobj->standingslope);
 }
 
@@ -6035,6 +6058,9 @@ angle_t P_MobjPitchAndRoll(mobj_t *mobj)
 	angle_t camang = 0;
 	angle_t return_angle = 0;
 
+	if (!cv_sloperoll.value)
+		return 0;
+
 	if (P_MobjWasRemoved(mobj))
 		return 0;
 
@@ -6074,9 +6100,9 @@ angle_t P_MobjPitchAndRoll(mobj_t *mobj)
 	}
 
 	return_angle = FixedMul(FINECOSINE((ang) >> ANGLETOFINESHIFT), mobj->roll)
-				+ FixedMul(FINESINE((ang) >> ANGLETOFINESHIFT), mobj->pitch)
-				+ FixedMul(FINECOSINE((camang) >> ANGLETOFINESHIFT), mobj->sloperoll)
-				+ FixedMul(FINESINE((camang) >> ANGLETOFINESHIFT), mobj->slopepitch);
+			        + FixedMul(FINESINE((ang) >> ANGLETOFINESHIFT), mobj->pitch)
+					+ FixedMul(FINECOSINE((camang) >> ANGLETOFINESHIFT), mobj->sloperoll)
+					+ FixedMul(FINESINE((camang) >> ANGLETOFINESHIFT), mobj->slopepitch);
 
 	return return_angle;
 }
@@ -6238,8 +6264,11 @@ void P_MobjThinker(mobj_t *mobj)
 					return;
 				}
 
-				K_RollMobjBySlopes(mobj, mobj->target->standingslope);
-
+				if (cv_sloperoll.value == 2 && mobj->state == &states[S_SHADOW])
+				{
+					mobj->slopepitch = mobj->target->slopepitch;
+					mobj->sloperoll = mobj->target->sloperoll;
+				}
 				P_AddShadow(mobj);
 				break;
 			//{ SRB2kart mobs
@@ -7030,14 +7059,15 @@ void P_MobjThinker(mobj_t *mobj)
 			break;
 		//{ SRB2kart Items - Death States
 		case MT_BANANA:
-			if (cv_bananthrowroll.value)
+			if (cv_sloperoll.value == 2 && cv_bananthrowroll.value)
 			{
+				angle_t spin = FixedMul(FixedDiv(abs(mobj->momz), 8 * mobj->scale), ANGLE_67h);
 				//mobj->angle -= spin;
 
-				if (cv_bananthrowroll.value == 1 && K_CheckSlopeRollDist(mobj))
-					mobj->sloperoll += (angle_t)FixedMul(FixedDiv(abs(mobj->momz), 8 * mobj->scale), ANGLE_67h); // im lazy but this makes sure the banan goes back to upright when it lands lmao
+				if (cv_bananthrowroll.value == 1)
+					mobj->sloperoll += spin; // im lazy but this makes sure the banan goes back to upright when it lands lmao
 				else if (cv_bananthrowroll.value == 2)
-					mobj->rollangle += (angle_t)FixedMul(FixedDiv(abs(mobj->momz), 8 * mobj->scale), ANGLE_67h);
+					mobj->rollangle += spin;
 
 				//if (P_IsObjectOnGround(mobj) && mobj->momz * P_MobjFlip(mobj) <= 0)
 			}
@@ -7784,15 +7814,16 @@ void P_MobjThinker(mobj_t *mobj)
 		}
 		case MT_BANANA:
 		case MT_EGGMANITEM:
-			if (cv_bananthrowroll.value && !P_IsObjectOnGround(mobj))
+			if (cv_sloperoll.value == 2 && cv_bananthrowroll.value && !P_IsObjectOnGround(mobj))
 			{
 				// tilt n tumble
+				angle_t spin = FixedMul(FixedDiv(mobj->momz, 8 * mobj->scale), ANGLE_67h);
 				//mobj->angle += spin;
 
-				if (cv_bananthrowroll.value == 1 && K_CheckSlopeRollDist(mobj))
-					mobj->sloperoll -= (angle_t)FixedMul(FixedDiv(mobj->momz, 8 * mobj->scale), ANGLE_67h); // im lazy but this makes sure the banan goes back to upright when it lands lmao
+				if (cv_bananthrowroll.value == 1)
+					mobj->sloperoll -= spin; // im lazy but this makes sure the banan goes back to upright when it lands lmao
 				else if (cv_bananthrowroll.value == 2)
-					mobj->rollangle -= (angle_t)FixedMul(FixedDiv(mobj->momz, 8 * mobj->scale), ANGLE_67h);
+					mobj->rollangle -= spin;
 			}
 
 			mobj->friction = ORIG_FRICTION/4;
@@ -9372,8 +9403,13 @@ void P_SceneryThinker(mobj_t *mobj)
 // GAME SPAWN FUNCTIONS
 //
 
-FUNCINLINE static ATTRINLINE mobj_t *P_AllocMobj(void)
+//
+// P_SpawnMobj
+//
+mobj_t *P_SpawnMobj(fixed_t x, fixed_t y, fixed_t z, mobjtype_t type)
 {
+	const mobjinfo_t *info = &mobjinfo[type];
+	state_t *st;
 	mobj_t *mobj;
 
 	if (mobjcache != NULL)
@@ -9387,20 +9423,6 @@ FUNCINLINE static ATTRINLINE mobj_t *P_AllocMobj(void)
 		mobj = Z_Calloc(sizeof (*mobj), PU_LEVEL, NULL);
 	}
 
-	return mobj;
-}
-
-//
-// P_SpawnMobj
-//
-mobj_t *P_SpawnMobj(fixed_t x, fixed_t y, fixed_t z, mobjtype_t type)
-{
-	const mobjinfo_t *info = &mobjinfo[type];
-	state_t *st;
-	mobj_t *mobj;
-
-	mobj = P_AllocMobj();
-
 	// this is officially a mobj, declared as soon as possible.
 	mobj->thinker.function.acp1 = (actionf_p1)P_MobjThinker;
 	mobj->type = type;
@@ -9412,6 +9434,11 @@ mobj_t *P_SpawnMobj(fixed_t x, fixed_t y, fixed_t z, mobjtype_t type)
 	mobj->radius = info->radius;
 	mobj->height = info->height;
 	mobj->flags = info->flags;
+	mobj->sloperoll = 0;
+	mobj->slopepitch = 0;
+
+	mobj->pitch_sprite = 0;
+	mobj->roll_sprite = 0;
 
 	mobj->health = info->spawnhealth;
 
@@ -9449,6 +9476,12 @@ mobj_t *P_SpawnMobj(fixed_t x, fixed_t y, fixed_t z, mobjtype_t type)
 	mobj->realxscale = mobj->realyscale = mobj->scale;
 	mobj->spritexscale = mobj->realxscale;
 	mobj->spriteyscale = mobj->realyscale;
+	mobj->realxoffset = mobj->realyoffset = 0;
+	mobj->spritexoffset = mobj->realxoffset;
+	mobj->spriteyoffset = mobj->realyoffset;
+
+	// Funni slam sound when landing
+	mobj->slamsoundtimer = 0;
 
 	// set subsector and/or block links
 	P_SetThingPosition(mobj);
@@ -9457,8 +9490,12 @@ mobj_t *P_SpawnMobj(fixed_t x, fixed_t y, fixed_t z, mobjtype_t type)
 	// Make sure scale matches destscale immediately when spawned
 	P_SetScale(mobj, mobj->destscale);
 
-	mobj->floorz   = P_GetSectorFloorZAt(mobj->subsector->sector, x, y);
-	mobj->ceilingz = P_GetSectorCeilingZAt(mobj->subsector->sector, x, y);
+	mobj->floorz =
+				mobj->subsector->sector->f_slope ? P_GetZAt(mobj->subsector->sector->f_slope, x, y) :
+				mobj->subsector->sector->floorheight;
+	mobj->ceilingz =
+				mobj->subsector->sector->c_slope ? P_GetZAt(mobj->subsector->sector->c_slope, x, y) :
+				mobj->subsector->sector->ceilingheight;
 
 	// Tells MobjCheckWater that the water height was not set.
 	mobj->watertop = INT32_MAX;
@@ -9850,7 +9887,16 @@ mobj_t *P_SpawnShadowMobj(mobj_t * caster)
 	state_t *st;
 	mobj_t *mobj;
 
-	mobj = P_AllocMobj();
+	if (mobjcache != NULL)
+	{
+		mobj = mobjcache;
+		mobjcache = mobjcache->hnext;
+		memset(mobj, 0, sizeof(*mobj));
+	}
+	else
+	{
+		mobj = Z_Calloc(sizeof (*mobj), PU_LEVEL, NULL);
+	}
 
 	// this is officially a mobj, declared as soon as possible.
 	mobj->thinker.function.acp1 = (actionf_p1)P_MobjThinker;
@@ -9900,6 +9946,7 @@ mobj_t *P_SpawnShadowMobj(mobj_t * caster)
 
 	// Sprite rendering
 	mobj->spritexscale = mobj->spriteyscale = mobj->scale;
+	mobj->spritexoffset = mobj->spriteyoffset = 0;
 
 	// set subsector and/or block links
 	P_SetThingPosition(mobj);
@@ -10132,10 +10179,6 @@ void P_RemoveMobj(mobj_t *mobj)
 		{ // Add thinker just to delay removing it until refrences are gone.
 			mobj->flags &= ~MF_NOTHINK;
 			P_AddThinker((thinker_t *)mobj);
-#ifdef PARANOIA
-			// Saved to avoid being scrambled like below...
-			mobj->thinker.debug_mobjtype = mobj->type;
-#endif
 #ifdef SCRAMBLE_REMOVED
 			// Invalidate mobj_t data to cause crashes if accessed!
 			memset((UINT8 *)mobj + sizeof(thinker_t), 0xff, sizeof(mobj_t) - sizeof(thinker_t));
@@ -10145,10 +10188,6 @@ void P_RemoveMobj(mobj_t *mobj)
 	}
 	else
 	{
-#ifdef PARANOIA
-		// Saved to avoid being scrambled like below...
-		mobj->thinker.debug_mobjtype = mobj->type;
-#endif
 #ifdef SCRAMBLE_REMOVED
 		// Invalidate mobj_t data to cause crashes if accessed!
 		memset((UINT8 *)mobj + sizeof(thinker_t), 0xff, sizeof(mobj_t) - sizeof(thinker_t));
@@ -10171,29 +10210,31 @@ void P_FreePrecipMobj(precipmobj_t *mobj)
 // Clearing out stuff for savegames
 void P_RemoveSavegameMobj(mobj_t *mobj)
 {
-	thinker_t *th = (thinker_t*)mobj;
-
 	// unlink from sector and block lists
-	P_UnsetThingPosition(mobj);
-
-	// Remove touching_sectorlist from mobj.
-	if (sector_list)
+	if (((thinker_t *)mobj)->function.acp1 == (actionf_p1)P_NullPrecipThinker)
 	{
-		P_DelSeclist(sector_list);
-		sector_list = NULL;
+		P_UnsetPrecipThingPosition((precipmobj_t *)mobj);
+	}
+	else
+	{
+		// unlink from sector and block lists
+		P_UnsetThingPosition(mobj);
+
+		// Remove touching_sectorlist from mobj.
+		if (sector_list)
+		{
+			P_DelSeclist(sector_list);
+			sector_list = NULL;
+		}
 	}
 
 	// stop any playing sound
 	S_StopSound(mobj);
 	R_RemoveMobjInterpolator(mobj);
 
-	// just set its reference count to 0 to not trigger the assert in P_UnlinkThinker
-	if (th->references != 0)
-		th->references = 0;
-
 	// free block
 	// Here we use the same code as R_RemoveThinkerDelayed, but without reference counting (we're removing everything so it shouldn't matter) and without touching currentthinker since we aren't in P_RunThinkers
-	P_UnlinkThinker(th);
+	P_UnlinkThinker((thinker_t*)mobj);
 }
 
 static CV_PossibleValue_t respawnitemtime_cons_t[] = {{1, "MIN"}, {300, "MAX"}, {0, NULL}};
@@ -10244,7 +10285,7 @@ void P_SpawnPrecipitation(void)
 				continue;
 
 			// Exists, but is too small for reasonable precipitation.
-			if (FixedDiv(precipsector->sector->ceilingheight - precipsector->sector->floorheight, mapobjectscale) < 64<<FRACBITS)
+			if (!(precipsector->sector->floorheight <= precipsector->sector->ceilingheight - (32<<FRACBITS)))
 				continue;
 
 			// Don't set z properly yet...
@@ -10530,8 +10571,9 @@ void P_RespawnSpecials(void)
 
 		if (mthing->options & MTF_OBJECTFLIP)
 		{
-			z = P_GetSectorCeilingZAt(ss->sector, x, y) - (mthing->options >> ZSHIFT) * FRACUNIT;
-
+			z = (
+			ss->sector->c_slope ? P_GetZAt(ss->sector->c_slope, x, y) :
+			ss->sector->ceilingheight) - (mthing->options >> ZSHIFT) * FRACUNIT;
 			if (mthing->options & MTF_AMBUSH
 			&& (i == MT_RING || i == MT_REDTEAMRING || i == MT_BLUETEAMRING || i == MT_COIN || P_WeaponOrPanel(i)))
 				z -= 24*FRACUNIT;
@@ -10539,8 +10581,9 @@ void P_RespawnSpecials(void)
 		}
 		else
 		{
-			z = P_GetSectorFloorZAt(ss->sector, x, y) + (mthing->options >> ZSHIFT) * FRACUNIT;
-
+			z = (
+			ss->sector->f_slope ? P_GetZAt(ss->sector->f_slope, x, y) :
+			ss->sector->floorheight) + (mthing->options >> ZSHIFT) * FRACUNIT;
 			if (mthing->options & MTF_AMBUSH
 			&& (i == MT_RING || i == MT_REDTEAMRING || i == MT_BLUETEAMRING || i == MT_COIN || P_WeaponOrPanel(i)))
 				z += 24*FRACUNIT;
@@ -10659,7 +10702,7 @@ void P_SpawnPlayer(INT32 playernum)
 	// the dead body mobj retains the skin through the 'spritedef' override).
 	mobj->skin = &skins[p->skin];
 
-	mobj->localskin = (p->localskin ? K_GetPlayerSkin(p) : 0);
+	mobj->localskin = ((p->localskin > 0) ? (p->skinlocal ? &localskins[p->localskin - 1] : &skins[p->localskin - 1]) : 0);
 	mobj->skinlocal = p->skinlocal;
 
 	mobj->health = p->health;
@@ -10839,9 +10882,14 @@ void P_MovePlayerToSpawn(INT32 playernum, mapthing_t *mthing)
 	//spawn at the origin as a desperation move if there is no mapthing
 
 	// set Z height
-	sector  = R_PointInSubsector(x, y)->sector;
-	floor   = P_GetSectorFloorZAt(sector, x, y);
-	ceiling = P_GetSectorCeilingZAt(sector, x, y);
+	sector = R_PointInSubsector(x, y)->sector;
+
+	floor =
+	sector->f_slope ? P_GetZAt(sector->f_slope, x, y) :
+	sector->floorheight;
+	ceiling =
+	sector->c_slope ? P_GetZAt(sector->c_slope, x, y) :
+	sector->ceilingheight;
 
 	if (mthing)
 	{
@@ -10909,11 +10957,14 @@ void P_MovePlayerToStarpost(INT32 playernum)
 	mobj->x = p->starpostx << FRACBITS;
 	mobj->y = p->starposty << FRACBITS;
 	P_SetThingPosition(mobj);
+	sector = R_PointInSubsector(mobj->x, mobj->y)->sector;
 
-	// set Z height
-	sector  = R_PointInSubsector(mobj->x, mobj->y)->sector;
-	floor   = P_GetSectorFloorZAt(sector, mobj->x, mobj->y);
-	ceiling = P_GetSectorCeilingZAt(sector, mobj->x, mobj->y);
+	floor =
+	sector->f_slope ? P_GetZAt(sector->f_slope, mobj->x, mobj->y) :
+	sector->floorheight;
+	ceiling =
+	sector->c_slope ? P_GetZAt(sector->c_slope, mobj->x, mobj->y) :
+	sector->ceilingheight;
 
 	if (mobj->player->kartstuff[k_starpostflip])
 		z = (p->starpostz<<FRACBITS) - FixedMul(128<<FRACBITS, mapobjectscale) - mobj->height;
@@ -11085,8 +11136,10 @@ void P_SpawnMapThing(mapthing_t *mthing)
 		if (gametype != GT_COOP)
 			return;
 
-		ss = R_PointInSubsector((mthing->x << FRACBITS), (mthing->y << FRACBITS));
-		mthing->z = (INT16)((P_GetSectorFloorZAt(ss->sector, (mthing->x << FRACBITS), (mthing->y << FRACBITS)) >> FRACBITS) + (mthing->options >> ZSHIFT));
+		ss = R_PointInSubsector(mthing->x << FRACBITS, mthing->y << FRACBITS);
+		mthing->z = (INT16)(((
+								ss->sector->f_slope ? P_GetZAt(ss->sector->f_slope, mthing->x << FRACBITS, mthing->y << FRACBITS) :
+								ss->sector->floorheight)>>FRACBITS) + (mthing->options >> ZSHIFT));
 
 		if (numhuntemeralds < MAXHUNTEMERALDS)
 			huntemeralds[numhuntemeralds++] = mthing;
@@ -11200,14 +11253,18 @@ void P_SpawnMapThing(mapthing_t *mthing)
 	ss = R_PointInSubsector(x, y);
 
 	if (i == MT_NIGHTSBUMPER)
-		z = P_GetSectorFloorZAt(ss->sector, x, y) + ((mthing->options >> ZSHIFT) << FRACBITS);
+		z = (
+			ss->sector->f_slope ? P_GetZAt(ss->sector->f_slope, x, y) :
+			ss->sector->floorheight) + ((mthing->options >> ZSHIFT) << FRACBITS);
 	else if (i == MT_AXIS || i == MT_AXISTRANSFER || i == MT_AXISTRANSFERLINE)
 		z = ONFLOORZ;
 	else if (i == MT_SPECIALSPIKEBALL || P_WeaponOrPanel(i) || i == MT_EMERALDSPAWN || i == MT_EMMY)
 	{
 		if (mthing->options & MTF_OBJECTFLIP)
 		{
-			z = P_GetSectorCeilingZAt(ss->sector, x, y);
+			z = (
+			ss->sector->c_slope ? P_GetZAt(ss->sector->c_slope, x, y) :
+			ss->sector->ceilingheight);
 
 			if (mthing->options & MTF_AMBUSH) // Special flag for rings
 				z -= 24*FRACUNIT;
@@ -11218,7 +11275,9 @@ void P_SpawnMapThing(mapthing_t *mthing)
 		}
 		else
 		{
-			z = P_GetSectorFloorZAt(ss->sector, x, y);
+			z = (
+			ss->sector->f_slope ? P_GetZAt(ss->sector->f_slope, x, y) :
+			ss->sector->floorheight);
 
 			if (mthing->options & MTF_AMBUSH) // Special flag for rings
 				z += 24*FRACUNIT;
@@ -11238,9 +11297,13 @@ void P_SpawnMapThing(mapthing_t *mthing)
 
 		// base positions
 		if (flip)
-			z = P_GetSectorCeilingZAt(ss->sector, x, y) - mobjinfo[i].height;
+			z = (
+			ss->sector->c_slope ? P_GetZAt(ss->sector->c_slope, x, y) :
+			ss->sector->ceilingheight) - mobjinfo[i].height;
 		else
-			z = P_GetSectorFloorZAt(ss->sector, x, y);
+			z = (
+			ss->sector->f_slope ? P_GetZAt(ss->sector->f_slope, x, y) :
+			ss->sector->floorheight);
 
 		// offsetting
 		if (mthing->options >> ZSHIFT)
@@ -11466,9 +11529,14 @@ ML_NOCLIMB : Direction not controllable
 		mobj->threshold = min(mthing->extrainfo, 7);
 		break;
 	case MT_TUBEWAYPOINT:
-		mobj->health = mthing->angle & 255;
-		mobj->threshold = mthing->angle >> 8;
+	{
+		UINT8 sequence = mthing->angle >> 8;
+		UINT8 id = mthing->angle & 255;
+		mobj->health = id;
+		mobj->threshold = sequence;
+		P_AddWaypoint(sequence, id, mobj);
 		break;
+	}
 	case MT_NIGHTSDRONE:
 		if (mthing->angle > 0)
 			mobj->health = mthing->angle;
@@ -11808,7 +11876,9 @@ void P_SpawnHoopsAndRings(mapthing_t *mthing)
 		hoopcenter = P_SpawnMobj(x, y, z, MT_HOOPCENTER);
 		hoopcenter->spawnpoint = mthing;
 
-		z += P_GetSectorFloorZAt(sec, x, y);
+		z +=
+			sec->f_slope ? P_GetZAt(sec->f_slope, x, y) :
+			sec->floorheight;
 
 		hoopcenter->z = z - hoopcenter->height/2;
 
@@ -11939,7 +12009,9 @@ void P_SpawnHoopsAndRings(mapthing_t *mthing)
 		hoopcenter = P_SpawnMobj(x, y, z, MT_HOOPCENTER);
 		hoopcenter->spawnpoint = mthing;
 
-		z += P_GetSectorFloorZAt(sec, x, y);
+		z +=
+			sec->f_slope ? P_GetZAt(sec->f_slope, x, y) :
+			sec->floorheight;
 		hoopcenter->z = z - hoopcenter->height/2;
 
 		P_UnsetThingPosition(hoopcenter);

src/p_mobj.h

@@ -293,9 +293,7 @@ typedef struct mobj_s
 	fixed_t spritexscale, spriteyscale;
 	fixed_t spritexoffset, spriteyoffset;
 	fixed_t old_spritexscale, old_spriteyscale;
-	fixed_t old_spritexscale2, old_spriteyscale2;
 	fixed_t old_spritexoffset, old_spriteyoffset;
-	fixed_t old_spritexoffset2, old_spriteyoffset2;
 	INT16 lightlevel; // Add to sector lightlevel, -255 - 255
 
 	fixed_t realxscale, realyscale; // funn-E streeetch
@@ -399,7 +397,7 @@ typedef struct mobj_s
 	boolean colorized; // Whether the mobj uses the rainbow colormap
 	boolean mirrored; // The object's rotations will be mirrored left to right, e.g., see frame AL from the right and AR from the left
 
-	tic_t slamsoundtimer; // Funni slam sound when landing
+	tic_t slamsoundtimer;
 
 	// saltyhop! hardcode edition
 	boolean salty_ready;
@@ -449,9 +447,7 @@ typedef struct precipmobj_s
 	fixed_t spritexscale, spriteyscale;
 	fixed_t spritexoffset, spriteyoffset;
 	fixed_t old_spritexscale, old_spriteyscale;
-	fixed_t old_spritexscale2, old_spriteyscale2;
 	fixed_t old_spritexoffset, old_spriteyoffset;
-	fixed_t old_spritexoffset2, old_spriteyoffset2;
 	INT16 lightlevel; // Add to sector lightlevel, -255 - 255
 
 	fixed_t realxscale, realyscale; // funn-E streeetch

src/p_polyobj.c

@@ -156,9 +156,6 @@ FUNCINLINE static ATTRINLINE void PolyObj_AddThinker(thinker_t *th)
 
 	th->references = 0;
 	th->cachable = false; // not initialising this made the mobjcache die thx!
-#ifdef PARANOIA
-	th->debug_mobjtype = MT_NULL;
-#endif
 }
 
 static void FreeSideLists(void)
@@ -851,7 +848,8 @@ static polymaplink_t *Polyobj_getLink(void)
 	}
 	else
 	{
-		l = Z_Calloc(sizeof(*l), PU_LEVEL, NULL);
+		l = Z_Malloc(sizeof(*l), PU_LEVEL, NULL);
+		memset(l, 0, sizeof(*l));
 	}
 
 	return l;
@@ -1567,7 +1565,8 @@ void Polyobj_InitLevel(void)
 		{
 			++numPolyObjects;
 
-			qitem = calloc(1, sizeof(mobjqitem_t));
+			qitem = malloc(sizeof(mobjqitem_t));
+			memset(qitem, 0, sizeof(mobjqitem_t));
 			qitem->mo = mo;
 			M_QueueInsert(&(qitem->mqitem), &spawnqueue);
 		}
@@ -1575,7 +1574,8 @@ void Polyobj_InitLevel(void)
 		{
 			++numAnchors;
 
-			qitem = calloc(1, sizeof(mobjqitem_t));
+			qitem = malloc(sizeof(mobjqitem_t));
+			memset(qitem, 0, sizeof(mobjqitem_t));
 			qitem->mo = mo;
 			M_QueueInsert(&(qitem->mqitem), &anchorqueue);
 		}
@@ -1803,12 +1803,12 @@ void T_PolyObjMove(polymove_t *th)
 //
 void T_PolyObjWaypoint(polywaypoint_t *th)
 {
-	mobj_t *mo2;
 	mobj_t *target = NULL;
 	mobj_t *waypoint = NULL;
-	thinker_t *wp;
+	mobj_t *mo2;
 	fixed_t adjustx, adjusty, adjustz;
 	fixed_t momx, momy, momz, dist;
+	thinker_t *wp;
 	INT32 start;
 	polyobj_t *po = Polyobj_GetForNum(th->polyObjNum);
 	polyobj_t *oldpo = po;
@@ -1825,7 +1825,7 @@ void T_PolyObjWaypoint(polywaypoint_t *th)
 #endif
 
 	// check for displacement due to override and reattach when possible
-	if (po->thinker == NULL)
+	if (!po->thinker)
 		po->thinker = &th->thinker;
 
 	// Find out target first.
@@ -1913,37 +1913,7 @@ void T_PolyObjWaypoint(polywaypoint_t *th)
 		{
 			CONS_Debug(DBG_POLYOBJ, "Looking for next waypoint...\n");
 
-			// Find next waypoint
-			for (wp = thinkercap.next; wp != &thinkercap; wp = wp->next)
-			{
-				if (wp->function.acp1 != (actionf_p1)P_MobjThinker) // Not a mobj thinker
-					continue;
-
-				mo2 = (mobj_t *)wp;
-
-				if (mo2->type != MT_TUBEWAYPOINT)
-					continue;
-
-				if (mo2->threshold != th->sequence)
-					continue;
-
-				if (th->direction == -1)
-				{
-					if (mo2->health == target->health - 1)
-					{
-						waypoint = mo2;
-						break;
-					}
-				}
-				else
-				{
-					if (mo2->health == target->health + 1)
-					{
-						waypoint = mo2;
-						break;
-					}
-				}
-			}
+			waypoint = (th->direction == -1) ? P_GetPreviousWaypoint(target, false) : P_GetNextWaypoint(target, false);
 
 			if (!waypoint && th->wrap) // If specified, wrap waypoints
 			{
@@ -1953,35 +1923,7 @@ void T_PolyObjWaypoint(polywaypoint_t *th)
 					th->stophere = true;
 				}
 
-				for (wp = thinkercap.next; wp != &thinkercap; wp = wp->next)
-				{
-					if (wp->function.acp1 != (actionf_p1)P_MobjThinker) // Not a mobj thinker
-						continue;
-
-					mo2 = (mobj_t *)wp;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-
-					if (mo2->threshold != th->sequence)
-						continue;
-
-					if (th->direction == -1)
-					{
-						if (waypoint == NULL)
-							waypoint = mo2;
-						else if (mo2->health > waypoint->health)
-							waypoint = mo2;
-					}
-					else
-					{
-						if (mo2->health == 0)
-						{
-							waypoint = mo2;
-							break;
-						}
-					}
-				}
+				waypoint = (th->direction == -1) ? P_GetLastWaypoint(th->sequence) : P_GetFirstWaypoint(th->sequence);
 			}
 			else if (!waypoint && th->comeback) // Come back to the start
 			{
@@ -1990,36 +1932,7 @@ void T_PolyObjWaypoint(polywaypoint_t *th)
 				if (!th->continuous)
 					th->comeback = false;
 
-				for (wp = thinkercap.next; wp != &thinkercap; wp = wp->next)
-				{
-					if (wp->function.acp1 != (actionf_p1)P_MobjThinker) // Not a mobj thinker
-						continue;
-
-					mo2 = (mobj_t *)wp;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-
-					if (mo2->threshold != th->sequence)
-						continue;
-
-					if (th->direction == -1)
-					{
-						if (mo2->health == target->health - 1)
-						{
-							waypoint = mo2;
-							break;
-						}
-					}
-					else
-					{
-						if (mo2->health == target->health + 1)
-						{
-							waypoint = mo2;
-							break;
-						}
-					}
-				}
+				waypoint = (th->direction == -1) ? P_GetPreviousWaypoint(target, false) : P_GetNextWaypoint(target, false);
 			}
 		}
 
@@ -2469,11 +2382,9 @@ INT32 EV_DoPolyObjWaypoint(polywaypointdata_t *pwdata)
 	polyobj_t *po;
 	polyobj_t *oldpo;
 	polywaypoint_t *th;
-	mobj_t *mo2;
 	mobj_t *first = NULL;
 	mobj_t *last = NULL;
 	mobj_t *target = NULL;
-	thinker_t *wp;
 	INT32 start;
 
 	if (!(po = Polyobj_GetForNum(pwdata->polyObjNum)))
@@ -2499,10 +2410,7 @@ INT32 EV_DoPolyObjWaypoint(polywaypointdata_t *pwdata)
 	th->polyObjNum = pwdata->polyObjNum;
 	th->speed = pwdata->speed;
 	th->sequence = pwdata->sequence; // Used to specify sequence #
-	if (pwdata->reverse)
-		th->direction = -1;
-	else
-		th->direction = 1;
+	th->direction = pwdata->reverse ? -1 : 1;
 
 	th->comeback = pwdata->comeback;
 	th->continuous = pwdata->continuous;
@@ -2510,44 +2418,8 @@ INT32 EV_DoPolyObjWaypoint(polywaypointdata_t *pwdata)
 	th->stophere = false;
 
 	// Find the first waypoint we need to use
-	for (wp = thinkercap.next; wp != &thinkercap; wp = wp->next)
-	{
-		if (wp->function.acp1 != (actionf_p1)P_MobjThinker) // Not a mobj thinker
-			continue;
-
-		mo2 = (mobj_t *)wp;
-
-		if (mo2->type != MT_TUBEWAYPOINT)
-			continue;
-
-		if (mo2->threshold != th->sequence)
-			continue;
-
-		if (th->direction == -1) // highest waypoint #
-		{
-			if (mo2->health == 0)
-				last = mo2;
-			else
-			{
-				if (first == NULL)
-					first = mo2;
-				else if (mo2->health > first->health)
-					first = mo2;
-			}
-		}
-		else // waypoint 0
-		{
-			if (mo2->health == 0)
-				first = mo2;
-			else
-			{
-				if (last == NULL)
-					last = mo2;
-				else if (mo2->health > last->health)
-					last = mo2;
-			}
-		}
-	}
+	first = (th->direction == -1) ? P_GetLastWaypoint(th->sequence) : P_GetFirstWaypoint(th->sequence);
+	last = (th->direction == -1) ? P_GetFirstWaypoint(th->sequence) : P_GetLastWaypoint(th->sequence);
 
 	if (!first)
 	{
@@ -2594,7 +2466,7 @@ INT32 EV_DoPolyObjWaypoint(polywaypointdata_t *pwdata)
 	R_CreateInterpolator_Polyobj(&th->thinker, po);
 	// T_PolyObjWaypoint is the only polyobject movement
 	// that can adjust z, so we add these ones too.
-	R_CreateInterpolator_SectorPlane(&th->thinker, po->lines[0]->backsector, false);
+	R_CreateInterpolator_SectorPlane(&th->thinker, po->lines[0]->backsector, false); 
 	R_CreateInterpolator_SectorPlane(&th->thinker, po->lines[0]->backsector, true);
 
 	// Most other polyobject functions handle children by recursively

src/p_pspr.h

@@ -77,9 +77,6 @@
 /// \brief Frame flags: frame appears between sector bright and full bright
 #define FF_SEMIBRIGHT	(FF_FULLBRIGHT|FF_FULLDARK)
 
-/// \brief mobj_t.lightlevel is absolute instead of relative
-#define FF_ABSOLUTELIGHTLEVEL 0x00400000
-
 /// \brief Frame flags: Simple stateless animation
 #define FF_ANIMATE 0x10000000
 

src/p_saveg.c

@@ -1009,13 +1009,13 @@ static inline UINT32 SaveMobjnum(const mobj_t *mobj)
 	return 0;
 }
 
-static inline UINT32 SaveSector(const sector_t *sector)
+static UINT32 SaveSector(const sector_t *sector)
 {
 	if (sector) return (UINT32)(sector - sectors);
 	return 0xFFFFFFFF;
 }
 
-static inline UINT32 SaveLine(const line_t *line)
+static UINT32 SaveLine(const line_t *line)
 {
 	if (line) return (UINT32)(line - lines);
 	return 0xFFFFFFFF;
@@ -1040,7 +1040,11 @@ static void SaveMobjThinker(savebuffer_t *save, const thinker_t *th, const UINT8
 	UINT16 diff2;
 
 	// Ignore stationary hoops - these will be respawned from mapthings.
-	if (mobj->type == MT_HOOP || mobj->type == MT_HOOPCOLLIDE) // These are NEVER saved.
+	if (mobj->type == MT_HOOP)
+		return;
+
+	// These are NEVER saved.
+	if (mobj->type == MT_HOOPCOLLIDE)
 		return;
 
 	// This hoop has already been collected.
@@ -1676,10 +1680,8 @@ static void P_NetArchiveThinkers(savebuffer_t *save)
 	// save off the current thinkers
 	for (th = thinkercap.next; th != &thinkercap; th = th->next)
 	{
-		if (th->function.acp1 == (actionf_p1)P_RemoveThinkerDelayed)
-			continue;
-
-		numsaved++;
+		if (th->function.acp1 != (actionf_p1)P_RemoveThinkerDelayed)
+			numsaved++;
 
 		if (th->function.acp1 == (actionf_p1)P_MobjThinker)
 		{
@@ -1862,7 +1864,7 @@ static void P_NetArchiveThinkers(savebuffer_t *save)
 			continue;
 		}
 #ifdef PARANOIA
-		else if (th->function.acp1 != (actionf_p1)P_RemoveThinkerDelayed) // wait garbage collection
+		else if (th->function.acp1 != P_RemoveThinkerDelayed) // wait garbage collection
 			I_Error("unknown thinker type %p", th->function.acp1);
 #endif
 	}
@@ -1891,7 +1893,7 @@ mobj_t *P_FindNewPosition(UINT32 oldposition)
 		if (mobj->mobjnum == oldposition)
 			return mobj;
 	}
-	CONS_Debug(DBG_GAMELOGIC, "mobj %d not found\n", oldposition);
+	CONS_Debug(DBG_GAMELOGIC, "mobj not found\n");
 	return NULL;
 }
 
@@ -1901,13 +1903,13 @@ static inline mobj_t *LoadMobj(UINT32 mobjnum)
 	return (mobj_t *)(size_t)mobjnum;
 }
 
-static inline sector_t *LoadSector(UINT32 sector)
+static sector_t *LoadSector(UINT32 sector)
 {
 	if (sector >= numsectors) return NULL;
 	return &sectors[sector];
 }
 
-static inline line_t *LoadLine(UINT32 line)
+static line_t *LoadLine(UINT32 line)
 {
 	if (line >= numlines) return NULL;
 	return &lines[line];
@@ -1924,25 +1926,6 @@ static inline player_t *LoadPlayer(UINT32 player)
 //
 // Loads a mobj_t from a save game
 //
-
-FUNCINLINE static ATTRINLINE mobj_t *AllocMobj(void)
-{
-	mobj_t *mobj;
-
-	if (mobjcache != NULL)
-	{
-		mobj = mobjcache;
-		mobjcache = mobjcache->hnext;
-		memset(mobj, 0, sizeof(*mobj));
-	}
-	else
-	{
-		mobj = Z_Calloc(sizeof (*mobj), PU_LEVEL, NULL);
-	}
-
-	return mobj;
-}
-
 static void LoadMobjThinker(savebuffer_t *save, actionf_p1 thinker)
 {
 	thinker_t *next;
@@ -1974,12 +1957,13 @@ static void LoadMobjThinker(savebuffer_t *save, actionf_p1 thinker)
 			return;
 		}
 
-		mobj = AllocMobj();
+		mobj = Z_Calloc(sizeof (*mobj), PU_LEVEL, NULL);
+
 		mobj->spawnpoint = &mapthings[spawnpointnum];
 		mapthings[spawnpointnum].mobj = mobj;
 	}
 	else
-		mobj = AllocMobj();
+		mobj = Z_Calloc(sizeof (*mobj), PU_LEVEL, NULL);
 
 	// declare this as a valid mobj as soon as possible.
 	mobj->thinker.function.acp1 = thinker;
@@ -2005,9 +1989,7 @@ static void LoadMobjThinker(savebuffer_t *save, actionf_p1 thinker)
 		}
 		mobj->type = i;
 	}
-
 	mobj->info = &mobjinfo[mobj->type];
-
 	if (diff & MD_POS)
 	{
 		mobj->x = READFIXED(save->p);
@@ -2020,7 +2002,6 @@ static void LoadMobjThinker(savebuffer_t *save, actionf_p1 thinker)
 		mobj->y = mobj->spawnpoint->y << FRACBITS;
 		mobj->angle = FixedAngle(mobj->spawnpoint->angle*FRACUNIT);
 	}
-
 	if (diff & MD_MOM)
 	{
 		mobj->momx = READFIXED(save->p);
@@ -2152,10 +2133,33 @@ static void LoadMobjThinker(savebuffer_t *save, actionf_p1 thinker)
 		mobj->colorized = READUINT8(save->p);
 
 	//{ Saturn stuff, needs to be set, but shouldnt be synched
+
+	// Sprite Rotation
+	mobj->rollangle = 0;
+	mobj->pitch = 0;
+	mobj->roll = 0;
+	mobj->sloperoll = 0;
+	mobj->slopepitch = 0;
+	mobj->pitch_sprite = 0;
+	mobj->roll_sprite = 0;
+
+	// Horizontal flip
+	mobj->mirrored = 0;
+
 	// Sprite Rendering stuff
 	mobj->blendmode = AST_TRANSLUCENT;
+	mobj->spritexoffset = mobj->realxoffset = 0;
+	mobj->spriteyoffset = mobj->realxoffset = 0;
 	mobj->spritexscale = mobj->realxscale = FRACUNIT;
 	mobj->spriteyscale = mobj->realyscale = FRACUNIT;
+	mobj->stretchslam = 0;
+
+	// Timer for slam sound effect
+	mobj->slamsoundtimer = 0;
+
+	// extra mobjlightlevel
+	mobj->lightlevel = 0;
+
 	//}
 
 	if (diff & MD_REDFLAG)
@@ -2665,6 +2669,8 @@ static void P_NetUnArchiveThinkers(savebuffer_t *save)
 {
 	thinker_t *currentthinker;
 	thinker_t *next;
+	thinker_t *currentprecipthinker;
+	thinker_t *nextprecip;
 	UINT8 tclass;
 	UINT8 restoreNum = false;
 	UINT32 i;
@@ -2690,7 +2696,22 @@ static void P_NetUnArchiveThinkers(savebuffer_t *save)
 	}
 
 	// remove all the current precip thinkers
-	P_PurgePrecipitation();
+	currentprecipthinker = precipcap.next;
+	for (currentprecipthinker = precipcap.next; currentprecipthinker != &precipcap; currentprecipthinker = nextprecip)
+	{
+		nextprecip = currentprecipthinker->next;
+
+#ifdef PARANOIA
+		if (currentprecipthinker->function.acp1 != (actionf_p1)P_NullPrecipThinker)
+		{
+			(next->prev = currentprecipthinker->prev)->next = nextprecip;
+			R_DestroyLevelInterpolators(currentprecipthinker);
+			Z_Free(currentprecipthinker);
+		}
+		else
+#endif
+			P_RemoveSavegameMobj((mobj_t *)currentprecipthinker); // item isn't saved, don't remove it
+	}
 
 	// we don't want the removed mobjs to come back
 	iquetail = iquehead = 0;
@@ -3007,7 +3028,6 @@ static void P_RelinkPointers(void)
 {
 	thinker_t *currentthinker;
 	mobj_t *mobj;
-	player_t *player;
 
 	// use info field (value = oldposition) to relink mobjs
 	for (currentthinker = thinkercap.next; currentthinker != &thinkercap;
@@ -3018,27 +3038,49 @@ static void P_RelinkPointers(void)
 
 		mobj = (mobj_t *)currentthinker;
 
-		if (UNLIKELY(mobj->type == MT_HOOP || mobj->type == MT_HOOPCOLLIDE || mobj->type == MT_HOOPCENTER))
+		if (mobj->type == MT_HOOP || mobj->type == MT_HOOPCOLLIDE || mobj->type == MT_HOOPCENTER)
 			continue;
 
-#define RELINK(obj, name) if ((obj) && !RelinkMobj(&(obj))) \
-		CONS_Debug(DBG_GAMELOGIC, name " not found on %d\n", obj->type);
-
-		RELINK(mobj->tracer, "tracer");
-		RELINK(mobj->target, "target");
-		RELINK(mobj->hnext, "hnext");
-		RELINK(mobj->hprev, "hprev");
-
-		player = mobj->player;
-
-		if (player)
+		if (mobj->tracer)
 		{
-			RELINK(player->capsule, "capsule");
-			RELINK(player->axis1, "axis1");
-			RELINK(player->axis2, "axis2");
-			RELINK(player->awayviewmobj, "awayviewmobj");
+			if (!RelinkMobj(&mobj->tracer))
+				CONS_Debug(DBG_GAMELOGIC, "tracer not found on %d\n", mobj->type);
+		}
+		if (mobj->target)
+		{
+			if (!RelinkMobj(&mobj->target))
+				CONS_Debug(DBG_GAMELOGIC, "target not found on %d\n", mobj->type);
+		}
+		if (mobj->hnext)
+		{
+			if (!RelinkMobj(&mobj->hnext))
+				CONS_Debug(DBG_GAMELOGIC, "hnext not found on %d\n", mobj->type);
+		}
+		if (mobj->hprev)
+		{
+			if (!RelinkMobj(&mobj->hprev))
+				CONS_Debug(DBG_GAMELOGIC, "hprev not found on %d\n", mobj->type);
+		}
+		if (mobj->player && mobj->player->capsule)
+		{
+			if (!RelinkMobj(&mobj->player->capsule))
+				CONS_Debug(DBG_GAMELOGIC, "capsule not found on %d\n", mobj->type);
+		}
+		if (mobj->player && mobj->player->axis1)
+		{
+			if (!RelinkMobj(&mobj->player->axis1))
+				CONS_Debug(DBG_GAMELOGIC, "axis1 not found on %d\n", mobj->type);
+		}
+		if (mobj->player && mobj->player->axis2)
+		{
+			if (!RelinkMobj(&mobj->player->axis2))
+				CONS_Debug(DBG_GAMELOGIC, "axis2 not found on %d\n", mobj->type);
+		}
+		if (mobj->player && mobj->player->awayviewmobj)
+		{
+			if (!RelinkMobj(&mobj->player->awayviewmobj))
+				CONS_Debug(DBG_GAMELOGIC, "awayviewmobj not found on %d\n", mobj->type);
 		}
-#undef RELINK
 	}
 }
 
@@ -3159,7 +3201,7 @@ static inline void P_UnArchiveSPGame(savebuffer_t *save, INT16 mapoverride)
 
 	// gamemap changed; we assume that its map header is always valid,
 	// so make it so
-	if (!mapheaderinfo[gamemap-1])
+	if(!mapheaderinfo[gamemap-1])
 		P_AllocMapHeader(gamemap-1);
 
 	lastmapsaved = gamemap;
@@ -3420,7 +3462,7 @@ void P_SaveNetGame(savebuffer_t *save, boolean resending)
 {
 	thinker_t *th;
 	mobj_t *mobj;
-	UINT32 i = 1; // don't start from 0, it'd be confused with a blank pointer otherwise
+	INT32 i = 1; // don't start from 0, it'd be confused with a blank pointer otherwise
 
 	CV_SaveNetVars(&save->p, false);
 	P_NetArchiveMisc(save, resending);
@@ -3435,7 +3477,7 @@ void P_SaveNetGame(savebuffer_t *save, boolean resending)
 
 			mobj = (mobj_t *)th;
 
-			if (UNLIKELY(mobj->type == MT_HOOP || mobj->type == MT_HOOPCOLLIDE || mobj->type == MT_HOOPCENTER))
+			if (mobj->type == MT_HOOP || mobj->type == MT_HOOPCOLLIDE || mobj->type == MT_HOOPCENTER)
 				continue;
 
 			mobj->mobjnum = i++;

src/p_setup.h

@@ -60,13 +60,13 @@ extern size_t nummapthings;
 extern mapthing_t *mapthings;
 
 void P_SetupLevelSky(INT32 skynum, boolean global);
+void P_LoadThingsOnly(void);
 boolean P_SetupLevel(boolean fromnetsave, boolean reloadinggamestate);
-
 #ifdef HWRENDER
-void HWR_LoadLevel(boolean reloadinggamestate);
+void HWR_LoadLevel(void);
 #endif
-
 boolean P_AddWadFile(const char *wadfilename, boolean local);
+boolean P_AddWadFileLocal(const char *wadfilename);
 
 extern boolean wideracereplaced;
 extern boolean racereplaced;

src/p_sight.c

@@ -33,9 +33,6 @@ typedef struct {
 
 static INT32 sightcounts[2];
 
-typedef INT32 (*divlinefunc)(fixed_t x, fixed_t y, const divline_t *node);
-typedef INT32 (*divlinecrossfunc)(fixed_t x1, fixed_t y1, fixed_t x2, fixed_t y2, const divline_t *node);
-
 //
 // P_DivlineSide
 //
@@ -54,25 +51,11 @@ static INT32 P_DivlineSide(fixed_t x, fixed_t y, const divline_t *node)
 		right == left ? 2 : 1);
 }
 
-static inline INT32 P_DivlineSideFast(fixed_t x, fixed_t y, const divline_t *node)
-{
-	INT64 v = ((INT64)y - node->y) * node->dx - ((INT64)x - node->x) * node->dy;
-
-	if (v == 0)
-		return 2;
-	return v > 0;
-}
-
 static inline INT32 P_DivlineCrossed(fixed_t x1, fixed_t y1, fixed_t x2, fixed_t y2, const divline_t *node)
 {
 	return (P_DivlineSide(x1, y1, node) == P_DivlineSide(x2, y2, node));
 }
 
-static inline INT32 P_DivlineCrossedFast(fixed_t x1, fixed_t y1, fixed_t x2, fixed_t y2, const divline_t *node)
-{
-	return (P_DivlineSideFast(x1, y1, node) == P_DivlineSideFast(x2, y2, node));
-}
-
 static boolean P_CrossSubsecPolyObj(polyobj_t *po, register los_t *los)
 {
 	size_t i;
@@ -136,7 +119,7 @@ static boolean P_CrossSubsecPolyObj(polyobj_t *po, register los_t *los)
 //
 // Returns true if strace crosses the given subsector successfully.
 //
-static boolean P_CrossSubsector(size_t num, register los_t *los, boolean fast)
+static boolean P_CrossSubsector(size_t num, register los_t *los)
 {
 	seg_t *seg;
 	INT32 count;
@@ -165,8 +148,6 @@ static boolean P_CrossSubsector(size_t num, register los_t *los, boolean fast)
 		}
 	}
 
-	const divlinecrossfunc divlinecrossFunc = fast ? P_DivlineCrossedFast : P_DivlineCrossed;
-
 	for (count = subsectors[num].numlines; --count >= 0; seg++)  // check lines
 	{
 		line_t *line = seg->linedef;
@@ -195,14 +176,14 @@ static boolean P_CrossSubsector(size_t num, register los_t *los, boolean fast)
 		v2 = line->v2;
 
 		// line isn't crossed?
-		if (divlinecrossFunc(v1->x, v1->y, v2->x, v2->y, &los->strace))
+		if (P_DivlineCrossed(v1->x, v1->y, v2->x, v2->y, &los->strace))
 			continue;
 
 		divl.dx = v2->x - (divl.x = v1->x);
 		divl.dy = v2->y - (divl.y = v1->y);
 
 		// line isn't crossed?
-		if (divlinecrossFunc(los->strace.x, los->strace.y, los->t2x, los->t2y, &divl))
+		if (P_DivlineCrossed(los->strace.x, los->strace.y, los->t2x, los->t2y, &divl))
 			continue;
 
 		// stop because it is not two sided anyway
@@ -311,19 +292,16 @@ static boolean P_CrossSubsector(size_t num, register los_t *los, boolean fast)
 // killough 4/20/98: rewritten to remove tail recursion, clean up, and optimize
 static boolean P_CrossBSPNode(INT32 bspnum, register los_t *los, boolean fast)
 {
-	const divlinefunc divlineFunc = fast ? P_DivlineSideFast : P_DivlineSide;
-
 	while (!(bspnum & NF_SUBSECTOR))
 	{
 		register node_t *bsp = nodes + bspnum;
 
-		INT32 side = divlineFunc(los->strace.x, los->strace.y, (divline_t *)bsp) & 1;
-		INT32 side2 = divlineFunc(los->t2x, los->t2y, (divline_t *) bsp);
+		INT32 side = (fast ? R_PointOnSideFast(los->strace.x, los->strace.y, bsp) : (P_DivlineSide(los->strace.x, los->strace.y, (divline_t *)bsp) & 1));
+		INT32 side2 = (fast ? R_PointOnSideFast(los->t2x, los->t2y, bsp) : P_DivlineSide(los->t2x, los->t2y, (divline_t *) bsp));
 
 		if (side == side2)
 		{
-			// doesn't touch the other side
-			bspnum = bsp->children[side];
+			bspnum = bsp->children[side]; // doesn't touch the other side
 		}
 		else // the partition plane is crossed here
 		{
@@ -334,7 +312,7 @@ static boolean P_CrossBSPNode(INT32 bspnum, register los_t *los, boolean fast)
 		}
 	}
 
-	return P_CrossSubsector((bspnum == -1 ? 0 : bspnum & ~NF_SUBSECTOR), los, fast);
+	return P_CrossSubsector((bspnum == -1 ? 0 : bspnum & ~NF_SUBSECTOR), los);
 }
 
 //

src/p_slopes.c

@@ -181,60 +181,54 @@ void P_RunDynamicSlopes(void)
 {
 	pslope_t *slope;
 
-	for (slope = slopelist; slope; slope = slope->next)
-	{
+	for (slope = slopelist; slope; slope = slope->next) {
 		fixed_t zdelta;
 
 		if (slope->flags & SL_NODYNAMIC)
 			continue;
 
-		switch (slope->refpos)
-		{
-			case 1: // front floor
-				zdelta = slope->sourceline->backsector->floorheight - slope->sourceline->frontsector->floorheight;
-				slope->o.z = slope->sourceline->frontsector->floorheight;
-				break;
-			case 2: // front ceiling
-				zdelta = slope->sourceline->backsector->ceilingheight - slope->sourceline->frontsector->ceilingheight;
-				slope->o.z = slope->sourceline->frontsector->ceilingheight;
-				break;
-			case 3: // back floor
-				zdelta = slope->sourceline->frontsector->floorheight - slope->sourceline->backsector->floorheight;
-				slope->o.z = slope->sourceline->backsector->floorheight;
-				break;
-			case 4: // back ceiling
-				zdelta = slope->sourceline->frontsector->ceilingheight - slope->sourceline->backsector->ceilingheight;
-				slope->o.z = slope->sourceline->backsector->ceilingheight;
-				break;
-			case 5: // vertices
-				{
-					mapthing_t *mt;
-					size_t i;
-					INT32 l;
-					line_t *line;
+		switch(slope->refpos) {
+		case 1: // front floor
+			zdelta = slope->sourceline->backsector->floorheight - slope->sourceline->frontsector->floorheight;
+			slope->o.z = slope->sourceline->frontsector->floorheight;
+			break;
+		case 2: // front ceiling
+			zdelta = slope->sourceline->backsector->ceilingheight - slope->sourceline->frontsector->ceilingheight;
+			slope->o.z = slope->sourceline->frontsector->ceilingheight;
+			break;
+		case 3: // back floor
+			zdelta = slope->sourceline->frontsector->floorheight - slope->sourceline->backsector->floorheight;
+			slope->o.z = slope->sourceline->backsector->floorheight;
+			break;
+		case 4: // back ceiling
+			zdelta = slope->sourceline->frontsector->ceilingheight - slope->sourceline->backsector->ceilingheight;
+			slope->o.z = slope->sourceline->backsector->ceilingheight;
+			break;
+		case 5: // vertices
+			{
+				mapthing_t *mt;
+				size_t i;
+				INT32 l;
+				line_t *line;
 
-					for (i = 0; i < 3; i++)
-					{
-						mt = slope->vertices[i];
-						l = P_FindSpecialLineFromTag(799, mt->angle, -1);
-
-						if (l != -1)
-						{
-							line = &lines[l];
-							mt->z = line->frontsector->floorheight >> FRACBITS;
-						}
+				for (i = 0; i < 3; i++) {
+					mt = slope->vertices[i];
+					l = P_FindSpecialLineFromTag(799, mt->angle, -1);
+					if (l != -1) {
+						line = &lines[l];
+						mt->z = line->frontsector->floorheight >> FRACBITS;
 					}
-
-					P_ReconfigureVertexSlope(slope);
 				}
-				continue; // TODO
 
-			default:
-				I_Error("P_RunDynamicSlopes: slope has invalid type!");
+				P_ReconfigureVertexSlope(slope);
+			}
+			continue; // TODO
+
+		default:
+			I_Error("P_RunDynamicSlopes: slope has invalid type!");
 		}
 
-		if (slope->zdelta != FixedDiv(zdelta, slope->extent))
-		{
+		if (slope->zdelta != FixedDiv(zdelta, slope->extent)) {
 			slope->zdelta = FixedDiv(zdelta, slope->extent);
 			slope->zangle = R_PointToAngle2(0, 0, slope->extent, -zdelta);
 			slope->real_zangle = slope->zangle;
@@ -251,7 +245,8 @@ void P_RunDynamicSlopes(void)
 static pslope_t *P_MakeSlope(const vector3_t *o, const vector2_t *d,
                              const fixed_t zdelta, UINT8 flags)
 {
-	pslope_t *ret = Z_Calloc(sizeof(pslope_t), PU_LEVEL, NULL);
+	pslope_t *ret = Z_Malloc(sizeof(pslope_t), PU_LEVEL, NULL);
+	memset(ret, 0, sizeof(*ret));
 
 	ret->o.x = o->x;
 	ret->o.y = o->y;
@@ -345,13 +340,13 @@ void P_SpawnSlope_Line(int linenum)
 	if (line->flags & ML_NOKNUX)
 		flags |= SL_ANCHORVERTEX;
 
-	if (!frontfloor && !backfloor && !frontceil && !backceil)
+	if(!frontfloor && !backfloor && !frontceil && !backceil)
 	{
 		CONS_Printf("P_SpawnSlope_Line called with non-slope line special.\n");
 		return;
 	}
 
-	if (!line->frontsector || !line->backsector)
+	if(!line->frontsector || !line->backsector)
 	{
 		CONS_Debug(DBG_SETUP, "P_SpawnSlope_Line used on a line without two sides. (line number %i)\n", linenum);
 		return;
@@ -417,7 +412,7 @@ void P_SpawnSlope_Line(int linenum)
 			fslope->sourceline = line;
 
 			// To find the real highz/lowz of a slope, you need to check all the vertexes
-			// in the slope's sector with P_GetSlopeZAt to get the REAL lowz & highz
+			// in the slope's sector with P_GetZAt to get the REAL lowz & highz
 			// Although these slopes are set by floorheights the ANGLE is what a slope is,
 			// so technically any slope can extend on forever (they are just bound by sectors)
 			// *You can use sourceline as a reference to see if two slopes really are the same
@@ -431,7 +426,7 @@ void P_SpawnSlope_Line(int linenum)
 
 			for (l = 0; l < line->frontsector->linecount; l++)
 			{
-				fixed_t height = P_GetSlopeZAt(line->frontsector->f_slope, line->frontsector->lines[l]->v1->x, line->frontsector->lines[l]->v1->y);
+				fixed_t height = P_GetZAt(line->frontsector->f_slope, line->frontsector->lines[l]->v1->x, line->frontsector->lines[l]->v1->y);
 
 				if (height > highest)
 					highest = height;
@@ -478,7 +473,7 @@ void P_SpawnSlope_Line(int linenum)
 
 			for (l = 0; l < line->frontsector->linecount; l++)
 			{
-				fixed_t height = P_GetSlopeZAt(line->frontsector->c_slope, line->frontsector->lines[l]->v1->x, line->frontsector->lines[l]->v1->y);
+				fixed_t height = P_GetZAt(line->frontsector->c_slope, line->frontsector->lines[l]->v1->x, line->frontsector->lines[l]->v1->y);
 
 				if (height > highest)
 					highest = height;
@@ -500,7 +495,6 @@ void P_SpawnSlope_Line(int linenum)
 			P_CalculateSlopeNormal(cslope);
 		}
 	}
-
 	if (backfloor || backceil)
 	{
 		line->backsector->hasslope = true; // Tell the software renderer that we're sloped
@@ -512,7 +506,7 @@ void P_SpawnSlope_Line(int linenum)
 
 		extent = P_GetExtent(line->backsector, line);
 
-		if (extent < 0)
+		if(extent < 0)
 		{
 			CONS_Printf("P_SpawnSlope_Line failed to get backsector extent on line number %i\n", linenum);
 			return;
@@ -548,7 +542,7 @@ void P_SpawnSlope_Line(int linenum)
 
 			for (l = 0; l < line->backsector->linecount; l++)
 			{
-				fixed_t height = P_GetSlopeZAt(line->backsector->f_slope, line->backsector->lines[l]->v1->x, line->backsector->lines[l]->v1->y);
+				fixed_t height = P_GetZAt(line->backsector->f_slope, line->backsector->lines[l]->v1->x, line->backsector->lines[l]->v1->y);
 
 				if (height > highest)
 					highest = height;
@@ -595,7 +589,7 @@ void P_SpawnSlope_Line(int linenum)
 
 			for (l = 0; l < line->backsector->linecount; l++)
 			{
-				fixed_t height = P_GetSlopeZAt(line->backsector->c_slope, line->backsector->lines[l]->v1->x, line->backsector->lines[l]->v1->y);
+				fixed_t height = P_GetZAt(line->backsector->c_slope, line->backsector->lines[l]->v1->x, line->backsector->lines[l]->v1->y);
 
 				if (height > highest)
 					highest = height;
@@ -632,13 +626,15 @@ static pslope_t *P_NewVertexSlope(INT16 tag1, INT16 tag2, INT16 tag3, UINT8 flag
 	size_t i;
 	mapthing_t *mt = mapthings;
 
-	pslope_t *ret = Z_Calloc(sizeof(pslope_t), PU_LEVEL, NULL);
+	pslope_t *ret = Z_Malloc(sizeof(pslope_t), PU_LEVEL, NULL);
+	memset(ret, 0, sizeof(*ret));
 
 	// Start by setting flags
 	ret->flags = flags;
 
 	// Now set up the vertex list
-	ret->vertices = Z_Calloc(3*sizeof(mapthing_t), PU_LEVEL, NULL);
+	ret->vertices = Z_Malloc(3*sizeof(mapthing_t), PU_LEVEL, NULL);
+	memset(ret->vertices, 0, 3*sizeof(mapthing_t));
 
 	// And... look for the vertices in question.
 	for (i = 0; i < nummapthings; i++, mt++)
@@ -679,6 +675,8 @@ static pslope_t *P_NewVertexSlope(INT16 tag1, INT16 tag2, INT16 tag3, UINT8 flag
 	return ret;
 }
 
+
+
 //
 // P_CopySectorSlope
 //
@@ -690,7 +688,7 @@ void P_CopySectorSlope(line_t *line)
 	int i, special = line->special;
 
 	// Check for copy linedefs
-	for (i = -1; (i = P_FindSectorFromLineTag(line, i)) >= 0;)
+	for(i = -1; (i = P_FindSectorFromLineTag(line, i)) >= 0;)
 	{
 		sector_t *srcsec = sectors + i;
 
@@ -901,14 +899,11 @@ void P_HandleSlopeLanding(mobj_t *thing, pslope_t *slope)
 {
 	vector3_t mom; // Ditto.
 
-	if (slope->flags & SL_NOPHYSICS) // No physics, no need to make anything complicated.
-	{
-		if (P_MobjFlip(thing)*(thing->momz) < 0) // falling, land on slope
-		{
+	if (slope->flags & SL_NOPHYSICS) { // No physics, no need to make anything complicated.
+		if (P_MobjFlip(thing)*(thing->momz) < 0) { // falling, land on slope
 			thing->momz = -P_MobjFlip(thing);
 			thing->standingslope = slope;
 		}
-
 		return;
 	}
 
@@ -918,11 +913,11 @@ void P_HandleSlopeLanding(mobj_t *thing, pslope_t *slope)
 
 	P_ReverseQuantizeMomentumToSlope(&mom, slope);
 
-	if (P_MobjFlip(thing)*mom.z < 0) // falling, land on slope
-	{
+	if (P_MobjFlip(thing)*mom.z < 0) { // falling, land on slope
 		thing->momx = mom.x;
 		thing->momy = mom.y;
 		thing->momz = -P_MobjFlip(thing);
+
 		thing->standingslope = slope;
 	}
 }
@@ -942,8 +937,7 @@ void P_ButteredSlope(mobj_t *mo)
 	if (mo->flags & (MF_NOCLIPHEIGHT|MF_NOGRAVITY))
 		return; // don't slide down slopes if you can't touch them or you're not affected by gravity
 
-	if (mo->player)
-	{
+	if (mo->player) {
 		if (abs(mo->standingslope->zdelta) < FRACUNIT/4 && !(mo->player->pflags & PF_SPINNING))
 			return; // Don't slide on non-steep slopes unless spinning
 
@@ -953,12 +947,9 @@ void P_ButteredSlope(mobj_t *mo)
 
 	thrust = FINESINE(mo->standingslope->zangle>>ANGLETOFINESHIFT) * 15 / 16 * (mo->eflags & MFE_VERTICALFLIP ? 1 : -1);
 
-	if (mo->player && (mo->player->pflags & PF_SPINNING))
-	{
+	if (mo->player && (mo->player->pflags & PF_SPINNING)) {
 		fixed_t mult = 0;
-
-		if (mo->momx || mo->momy)
-		{
+		if (mo->momx || mo->momy) {
 			angle_t angle = R_PointToAngle2(0, 0, mo->momx, mo->momy) - mo->standingslope->xydirection;
 
 			if (P_MobjFlip(mo) * mo->standingslope->zdelta < 0)

src/p_slopes.h

@@ -40,44 +40,39 @@ extern pslope_t *slopelist;
 //
 
 // Returns the height of the sloped plane at (x, y) as a fixed_t
-FUNCINLINE static ATTRINLINE fixed_t P_GetSlopeZAt(const pslope_t *z_slope, fixed_t x, fixed_t y)
+FUNCINLINE static ATTRINLINE fixed_t P_GetZAt(pslope_t *z_slope, fixed_t x, fixed_t y)
 {
 	return z_slope->o.z + FixedMul((FixedMul(x - z_slope->o.x, z_slope->d.x) + FixedMul(y - z_slope->o.y, z_slope->d.y)), z_slope->zdelta);
 }
 
-// Like P_GetSlopeZAt but falls back to z if slope is NULL
-FUNCINLINE static ATTRINLINE fixed_t P_GetZAt(const pslope_t *slope, fixed_t x, fixed_t y, fixed_t z)
-{
-	return slope ? P_GetSlopeZAt(slope, x, y) : z;
-}
 // Returns the height of the sector floor at (x, y)
 FUNCINLINE static ATTRINLINE fixed_t P_GetSectorFloorZAt(const sector_t *z_sector, fixed_t x, fixed_t y)
 {
-	return z_sector->f_slope ? P_GetSlopeZAt(z_sector->f_slope, x, y) : z_sector->floorheight;
+	return z_sector->f_slope ? P_GetZAt(z_sector->f_slope, x, y) : z_sector->floorheight;
 }
 
 // Returns the height of the sector ceiling at (x, y)
 FUNCINLINE static ATTRINLINE fixed_t P_GetSectorCeilingZAt(const sector_t *z_sector, fixed_t x, fixed_t y)
 {
-	return z_sector->c_slope ? P_GetSlopeZAt(z_sector->c_slope, x, y) : z_sector->ceilingheight;
+	return z_sector->c_slope ? P_GetZAt(z_sector->c_slope, x, y) : z_sector->ceilingheight;
 }
 
 // Returns the height of the FOF top at (x, y)
 FUNCINLINE static ATTRINLINE fixed_t P_GetFFloorTopZAt(const ffloor_t *z_ffloor, fixed_t x, fixed_t y)
 {
-	return *z_ffloor->t_slope ? P_GetSlopeZAt(*z_ffloor->t_slope, x, y) : *z_ffloor->topheight;
+	return *z_ffloor->t_slope ? P_GetZAt(*z_ffloor->t_slope, x, y) : *z_ffloor->topheight;
 }
 
 // Returns the height of the FOF bottom  at (x, y)
 FUNCINLINE static ATTRINLINE fixed_t P_GetFFloorBottomZAt(const ffloor_t *z_ffloor, fixed_t x, fixed_t y)
 {
-	return *z_ffloor->b_slope ? P_GetSlopeZAt(*z_ffloor->b_slope, x, y) : *z_ffloor->bottomheight;
+	return *z_ffloor->b_slope ? P_GetZAt(*z_ffloor->b_slope, x, y) : *z_ffloor->bottomheight;
 }
 
 // Returns the height of the light list at (x, y)
 FUNCINLINE static ATTRINLINE fixed_t P_GetLightZAt(const lightlist_t *z_light, fixed_t x, fixed_t y)
 {
-	return z_light->slope ? P_GetSlopeZAt(z_light->slope, x, y) : z_light->height;
+	return z_light->slope ? P_GetZAt(z_light->slope, x, y) : z_light->height;
 }
 
 // Lots of physics-based bullshit

src/p_spec.c

@@ -51,6 +51,19 @@ mobj_t *skyboxmo[2];
 // This must be updated whenever we up the max flat size - quicker to assume rather than figuring out the sqrt of the specific flat's filesize.
 #define MAXFLATSIZE (2048<<FRACBITS)
 
+/** Animated texture descriptor
+  * This keeps track of an animated texture or an animated flat.
+  * \sa P_UpdateSpecials, P_InitPicAnims, animdef_t
+  */
+typedef struct
+{
+	SINT8 istexture; ///< ::true for a texture, ::false for a flat
+	INT32 picnum;    ///< The end flat number
+	INT32 basepic;   ///< The start flat number
+	INT32 numpics;   ///< Number of frames in the animation
+	tic_t speed;     ///< Number of tics for which each frame is shown
+} anim_t;
+
 #if defined(_MSC_VER)
 #pragma pack(1)
 #endif
@@ -100,8 +113,8 @@ static void P_AddSpikeThinker(sector_t *sec, INT32 referrer);
 
 
 //SoM: 3/7/2000: New sturcture without limits.
-anim_t *lastanim;
-anim_t *anims = NULL; /// \todo free leak
+static anim_t *lastanim;
+static anim_t *anims = NULL; /// \todo free leak
 static size_t maxanims;
 
 //
@@ -1721,19 +1734,6 @@ static boolean is_rain_type (INT32 weathernum)
 	}
 }
 
-void P_PurgePrecipitation(void)
-{
-	thinker_t *think;
-	thinker_t *next;
-
-	for (think = precipcap.next; think != NULL && think != &precipcap;)
-	{
-		next = think->next;
-		P_FreePrecipMobj((precipmobj_t *)think);
-		think = next;
-	}
-}
-
 //
 // P_SwitchWeather
 //
@@ -1742,7 +1742,6 @@ void P_PurgePrecipitation(void)
 void P_SwitchWeather(INT32 weathernum)
 {
 	boolean purge = true;
-	boolean spawnprecip = false;
 
 	if (weathernum == curWeather)
 		return;
@@ -1753,7 +1752,22 @@ void P_SwitchWeather(INT32 weathernum)
 
 	if (purge)
 	{
-		P_PurgePrecipitation();
+		thinker_t *think;
+		thinker_t *next;
+		precipmobj_t *precipmobj;
+
+		for (think = precipcap.next; think != &precipcap; think = next)
+		{
+			next = think->next;
+
+#ifdef PARANOIA
+			if (think->function.acp1 != (actionf_p1)P_NullPrecipThinker)
+				continue; // not a precipmobj thinker
+#endif
+
+			precipmobj = (precipmobj_t *)think;
+			P_FreePrecipMobj(precipmobj);
+		}
 	}
 	else // Rather than respawn all that crap, reuse it!
 	{
@@ -1763,6 +1777,11 @@ void P_SwitchWeather(INT32 weathernum)
 
 		for (think = precipcap.next; think != &precipcap; think = think->next)
 		{
+#ifdef PARANOIA
+			if (think->function.acp1 != (actionf_p1)P_NullPrecipThinker)
+				continue; // not a precipmobj thinker
+#endif
+
 			precipmobj = (precipmobj_t *)think;
 
 			INT32 z = 0;
@@ -1807,6 +1826,8 @@ void P_SwitchWeather(INT32 weathernum)
 		}
 	}
 
+	boolean spawnprecip = false;
+
 	switch (weathernum)
 	{
 		case PRECIP_SNOW: // snow
@@ -1814,17 +1835,23 @@ void P_SwitchWeather(INT32 weathernum)
 			spawnprecip = true;
 		break;
 		case PRECIP_RAIN: // rain
+		{
 			curWeather = PRECIP_RAIN;
 			spawnprecip = true;
 			break;
+		}
 		case PRECIP_STORM: // storm
+		{
 			curWeather = PRECIP_STORM;
 			spawnprecip = true;
 			break;
+		}
 		case PRECIP_STORM_NOSTRIKES: // storm w/o lightning
+		{
 			curWeather = PRECIP_STORM_NOSTRIKES;
 			spawnprecip = true;
 			break;
+		}
 		case PRECIP_STORM_NORAIN: // storm w/o rain
 			curWeather = PRECIP_STORM_NORAIN;
 			break;
@@ -3273,10 +3300,9 @@ void P_ProcessSpecialSector(player_t *player, sector_t *sector, sector_t *rovers
 			if (roversector || P_MobjReadyToTrigger(player->mo, sector))
 				P_DamageMobj(player->mo, NULL, NULL, 1);
 			break;
-		// SRB2kart - These three damage types are now offroad sectors
-		case 2: // Offroad (Weak)
-		case 3: // Offroad
-		case 4: // Offroad (Strong)
+		case 2: // Damage (Water) // SRB2kart - These three damage types are now offroad sectors
+		case 3: // Damage (Fire)
+		case 4: // Damage (Electrical)
 			break;
 		case 5: // Spikes
 			// Don't do anything. In Soviet Russia, spikes find you.
@@ -3737,9 +3763,7 @@ DoneSection2:
 				INT32 sequence;
 				fixed_t speed;
 				INT32 lineindex;
-				thinker_t *th;
 				mobj_t *waypoint = NULL;
-				mobj_t *mo2;
 				angle_t an;
 
 				if (player->mo->tracer && player->mo->tracer->type == MT_TUBEWAYPOINT)
@@ -3758,25 +3782,7 @@ DoneSection2:
 				speed = abs(lines[lineindex].dx)/8;
 				sequence = abs(lines[lineindex].dy)>>FRACBITS;
 
-				// scan the thinkers
-				// to find the first waypoint
-				for (th = thinkercap.next; th != &thinkercap; th = th->next)
-				{
-					if (th->function.acp1 != (actionf_p1)P_MobjThinker)
-						continue;
-
-					mo2 = (mobj_t *)th;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-					if (mo2->threshold != sequence)
-						continue;
-					if (mo2->health != 0)
-						continue;
-
-					waypoint = mo2;
-					break;
-				}
+				waypoint = P_GetFirstWaypoint(sequence);
 
 				if (!waypoint)
 				{
@@ -3816,9 +3822,7 @@ DoneSection2:
 				INT32 sequence;
 				fixed_t speed;
 				INT32 lineindex;
-				thinker_t *th;
 				mobj_t *waypoint = NULL;
-				mobj_t *mo2;
 				angle_t an;
 
 				if (player->mo->tracer && player->mo->tracer->type == MT_TUBEWAYPOINT)
@@ -3837,25 +3841,7 @@ DoneSection2:
 				speed = -(abs(lines[lineindex].dx)/8); // Negative means reverse
 				sequence = abs(lines[lineindex].dy)>>FRACBITS;
 
-				// scan the thinkers
-				// to find the last waypoint
-				for (th = thinkercap.next; th != &thinkercap; th = th->next)
-				{
-					if (th->function.acp1 != (actionf_p1)P_MobjThinker)
-						continue;
-
-					mo2 = (mobj_t *)th;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-					if (mo2->threshold != sequence)
-						continue;
-
-					if (!waypoint)
-						waypoint = mo2;
-					else if (mo2->health > waypoint->health)
-						waypoint = mo2;
-				}
+				waypoint = P_GetLastWaypoint(sequence);
 
 				if (!waypoint)
 				{
@@ -4006,15 +3992,12 @@ DoneSection2:
 				INT32 sequence;
 				fixed_t speed;
 				INT32 lineindex;
-				thinker_t *th;
 				mobj_t *waypointmid = NULL;
 				mobj_t *waypointhigh = NULL;
 				mobj_t *waypointlow = NULL;
-				mobj_t *mo2;
 				mobj_t *closest = NULL;
 				line_t junk;
 				vertex_t v1, v2, resulthigh, resultlow;
-				mobj_t *highest = NULL;
 
 				if (player->mo->tracer && player->mo->tracer->type == MT_TUBEWAYPOINT)
 					break;
@@ -4054,98 +4037,16 @@ DoneSection2:
 				// Determine the closest spot on the line between the three waypoints
 				// Put player at that location.
 
-				// scan the thinkers
-				// to find the first waypoint
-				for (th = thinkercap.next; th != &thinkercap; th = th->next)
-				{
-					if (th->function.acp1 != (actionf_p1)P_MobjThinker)
-						continue;
+				waypointmid = P_GetClosestWaypoint(sequence, player->mo);
 
-					mo2 = (mobj_t *)th;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-
-					if (mo2->threshold != sequence)
-						continue;
-
-					if (!highest)
-						highest = mo2;
-					else if (mo2->health > highest->health) // Find the highest waypoint # in case we wrap
-						highest = mo2;
-
-					if (closest && P_AproxDistance(P_AproxDistance(player->mo->x-mo2->x, player->mo->y-mo2->y),
-						player->mo->z-mo2->z) > P_AproxDistance(P_AproxDistance(player->mo->x-closest->x,
-						player->mo->y-closest->y), player->mo->z-closest->z))
-						continue;
-
-					// Found a target
-					closest = mo2;
-				}
-
-				waypointmid = closest;
-
-				closest = NULL;
-
-				if (waypointmid == NULL)
+				if (!waypointmid)
 				{
 					CONS_Debug(DBG_GAMELOGIC, "ERROR: WAYPOINT(S) IN SEQUENCE %d NOT FOUND.\n", sequence);
 					break;
 				}
 
-				// Find waypoint before this one (waypointlow)
-				for (th = thinkercap.next; th != &thinkercap; th = th->next)
-				{
-					if (th->function.acp1 != (actionf_p1)P_MobjThinker)
-						continue;
-
-					mo2 = (mobj_t *)th;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-
-					if (mo2->threshold != sequence)
-						continue;
-
-					if (waypointmid->health == 0)
-					{
-						if (mo2->health != highest->health)
-							continue;
-					}
-					else if (mo2->health != waypointmid->health - 1)
-						continue;
-
-					// Found a target
-					waypointlow = mo2;
-					break;
-				}
-
-				// Find waypoint after this one (waypointhigh)
-				for (th = thinkercap.next; th != &thinkercap; th = th->next)
-				{
-					if (th->function.acp1 != (actionf_p1)P_MobjThinker)
-						continue;
-
-					mo2 = (mobj_t *)th;
-
-					if (mo2->type != MT_TUBEWAYPOINT)
-						continue;
-
-					if (mo2->threshold != sequence)
-						continue;
-
-					if (waypointmid->health == highest->health)
-					{
-						if (mo2->health != 0)
-							continue;
-					}
-					else if (mo2->health != waypointmid->health + 1)
-						continue;
-
-					// Found a target
-					waypointhigh = mo2;
-					break;
-				}
+				waypointlow = P_GetPreviousWaypoint(waypointmid, true);
+				waypointhigh = P_GetNextWaypoint(waypointmid, true);
 
 				CONS_Debug(DBG_GAMELOGIC, "WaypointMid: %d; WaypointLow: %d; WaypointHigh: %d\n",
 								waypointmid->health, waypointlow ? waypointlow->health : -1, waypointhigh ? waypointhigh->health : -1);
@@ -4196,6 +4097,7 @@ DoneSection2:
 
 				if (lines[lineindex].flags & ML_EFFECT1) // Don't wrap
 				{
+					mobj_t *highest = P_GetLastWaypoint(sequence);
 					highest->flags |= MF_SLIDEME;
 				}
 
@@ -4207,7 +4109,7 @@ DoneSection2:
 					player->mo->y = resulthigh.y;
 					player->mo->z = resulthigh.z - P_GetPlayerHeight(player);
 				}
-				else if ((lines[lineindex].flags & ML_EFFECT1) && waypointmid->health == highest->health)
+				else if ((lines[lineindex].flags & ML_EFFECT1) && waypointmid->health == numwaypoints[sequence] - 1)
 				{
 					closest = waypointmid;
 					player->mo->x = resultlow.x;
@@ -5235,10 +5137,11 @@ void T_LaserFlash(laserthink_t *flash)
 
 	sourcesec = ffloor->master->frontsector; // Less to type!
 
-	top    = P_GetFFloorTopZAt   (ffloor, sector->soundorg.x, sector->soundorg.y);
-	bottom = P_GetFFloorBottomZAt(ffloor, sector->soundorg.x, sector->soundorg.y);
+	top = (*ffloor->t_slope) ? P_GetZAt(*ffloor->t_slope, sector->soundorg.x, sector->soundorg.y)
+			: *ffloor->topheight;
+	bottom = (*ffloor->b_slope) ? P_GetZAt(*ffloor->b_slope, sector->soundorg.x, sector->soundorg.y)
+			: *ffloor->bottomheight;
 	sector->soundorg.z = (top + bottom)/2;
-
 	S_StartSound(&sector->soundorg, sfx_laser);
 
 	// Seek out objects to DESTROY! MUAHAHHAHAHAA!!!*cough*
@@ -6874,7 +6777,10 @@ void T_Disappear(disappear_t *d)
 
 					if (!(lines[d->sourceline].flags & ML_NOCLIMB))
 					{
-						sectors[s].soundorg.z = P_GetFFloorTopZAt(rover, sectors[s].soundorg.x, sectors[s].soundorg.y);
+						if (*rover->t_slope)
+							sectors[s].soundorg.z = P_GetZAt(*rover->t_slope, sectors[s].soundorg.x, sectors[s].soundorg.y);
+						else
+							sectors[s].soundorg.z = *rover->topheight;
 						S_StartSound(&sectors[s].soundorg, sfx_appear);
 					}
 				}

src/p_spec.h

@@ -25,22 +25,6 @@ extern mobj_t *skyboxmo[2];
 //
 #define GETSECSPECIAL(i,j) ((i >> ((j-1)*4))&15)
 
-/** Animated texture descriptor
- * This keeps track of an animated texture or an animated flat.
- * \sa P_UpdateSpecials, P_InitPicAnims, animdef_t
- */
-typedef struct
-{
-	SINT8 istexture; ///< ::true for a texture, ::false for a flat
-	INT32 picnum;    ///< The end flat number
-	INT32 basepic;   ///< The start flat number
-	INT32 numpics;   ///< Number of frames in the animation
-	tic_t speed;     ///< Number of tics for which each frame is shown
-} anim_t;
-
-extern anim_t *lastanim;
-extern anim_t *anims;
-
 // at game start
 void P_InitPicAnims(void);
 
@@ -74,7 +58,6 @@ INT32 P_FindMinSurroundingLight(sector_t *sector, INT32 max);
 void P_SetupSignExit(player_t *player);
 boolean P_IsFlagAtBase(mobjtype_t flag);
 
-void P_PurgePrecipitation(void);
 void P_SwitchWeather(INT32 weathernum);
 
 boolean P_RunTriggerLinedef(line_t *triggerline, mobj_t *actor, sector_t *caller);

src/p_tick.c

@@ -11,10 +11,6 @@
 /// \file  p_tick.c
 /// \brief Archiving: SaveGame I/O, Thinker, Ticker
 
-#ifdef PARANOIA
-#include "dehacked.h" // MOBJTYPE_LIST
-#endif
-
 #include "doomstat.h"
 #include "g_game.h"
 #include "g_input.h"
@@ -29,7 +25,6 @@
 #include "lua_hook.h"
 #include "k_director.h"
 #include "k_kart.h"
-#include "k_stats.h"
 #include "i_system.h"
 #include "r_main.h"
 #include "r_fps.h"
@@ -208,9 +203,6 @@ void P_AddThinker(thinker_t *thinker)
 	thinker->references = 0;    // killough 11/98: init reference counter to 0
 
 	thinker->cachable = (thinker->function.acp1 == (actionf_p1)P_MobjThinker);
-#ifdef PARANOIA
-	thinker->debug_mobjtype = MT_NULL;
-#endif
 }
 
 //
@@ -227,48 +219,8 @@ void P_AddPrecipThinker(thinker_t *thinker)
 	thinker->references = 0;    // killough 11/98: init reference counter to 0
 
 	thinker->cachable = false;
-#ifdef PARANOIA
-	thinker->debug_mobjtype = MT_NULL;
-#endif
 }
 
-#ifdef PARANOIA
-static const char *MobjTypeName(const mobj_t *mobj)
-{
-	actionf_p1 p1 = mobj->thinker.function.acp1;
-
-	if (p1 == (actionf_p1)P_MobjThinker)
-	{
-		return MOBJTYPE_LIST[mobj->type];
-	}
-	else if (p1 == (actionf_p1)P_RemoveThinkerDelayed)
-	{
-		if (mobj->thinker.debug_mobjtype != MT_NULL)
-		{
-			return MOBJTYPE_LIST[mobj->thinker.debug_mobjtype];
-		}
-	}
-
-	return "<Not a mobj>";
-}
-
-static const char *MobjThinkerName(const mobj_t *mobj)
-{
-	actionf_p1 p1 = mobj->thinker.function.acp1;
-
-	if (p1 == (actionf_p1)P_MobjThinker)
-	{
-		return "P_MobjThinker";
-	}
-	else if (p1 == (actionf_p1)P_RemoveThinkerDelayed)
-	{
-		return "P_RemoveThinkerDelayed";
-	}
-
-	return "<Unknown Thinker>";
-}
-#endif
-
 //
 // killough 11/98:
 //
@@ -289,46 +241,34 @@ static thinker_t *currentthinker;
 //
 void P_RemoveThinkerDelayed(thinker_t *thinker)
 {
-	if (thinker->references != 0)
-	{
 #ifdef PARANOIA
-		// Removed mobjs can be the target of another mobj. In
-		// that case, the other mobj will manage its reference
-		// to the removed mobj in P_MobjThinker. However, if
-		// the removed mobj is removed after the other object
-		// thinks, the reference management is delayed by one
-		// tic (or two?)
-		const UINT8 delay = 2;
-
-		if (thinker->debug_time > leveltime)
-		{
-			thinker->debug_time = leveltime + delay + 1; // do not print errors again
-		}
-		else if ((thinker->debug_time + delay) <= leveltime)
-		{
-			CONS_Printf(
-					"PARANOIA/P_RemoveThinkerDelayed: %p %s references=%d\n",
-					(void*)thinker,
-					MobjTypeName((mobj_t*)thinker),
-					thinker->references
-			);
-
-			thinker->debug_time = leveltime + delay + 1; // do not print this error again
-		}
+	if (thinker->next)
+		thinker->next = NULL;
+	else if (thinker->references) // Usually gets cleared up in one frame; what's going on here, then?
+		CONS_Printf("Number of potentially faulty references: %d\n", thinker->references);
 #endif
+	if (thinker->references)
 		return;
-	}
-
-	R_DestroyLevelInterpolators(thinker);
 
+	/* Remove from main thinker list */
+	thinker_t *next = thinker->next;
 	/* Note that currentthinker is guaranteed to point to us,
 	* and since we're freeing our memory, we had better change that. So
 	* point it to thinker->prev, so the iterator will correctly move on to
 	* thinker->prev->next = thinker->next */
-	currentthinker = thinker->prev;
+	(next->prev = currentthinker = thinker->prev)->next = next;
+	R_DestroyLevelInterpolators(thinker);
 
-	/* Remove from main thinker list */
-	P_UnlinkThinker(thinker);
+	if (thinker->cachable == true)
+	{
+		// put cachable thinkers in the mobj cache, so we can avoid allocations
+		((mobj_t *)thinker)->hnext = mobjcache;
+		mobjcache = (mobj_t *)thinker;
+	}
+	else
+	{
+		Z_Free(thinker);
+	}
 }
 
 //
@@ -356,6 +296,7 @@ void P_UnlinkThinker(thinker_t *thinker)
 	}
 }
 
+
 //
 // P_RemoveThinker
 //
@@ -386,45 +327,12 @@ void P_RemoveThinker(thinker_t *thinker)
  * references, and delay removal until the count is 0.
  */
 
-mobj_t *P_SetTarget2(mobj_t **mop, mobj_t *targ
-#ifdef PARANOIA
-		, const char *source_file, int source_line
-#endif
-)
+mobj_t *P_SetTarget(mobj_t **mop, mobj_t *targ)
 {
-	if (*mop) // If there was a target already, decrease its refcount
-	{
+	if (*mop)              // If there was a target already, decrease its refcount
 		(*mop)->thinker.references--;
-
-#ifdef PARANOIA
-		if ((*mop)->thinker.references < 0)
-		{
-			CONS_Printf(
-					"PARANOIA/P_SetTarget: %p %s %s references=%d, references go negative! (%s:%d)\n",
-					(void*)*mop,
-					MobjTypeName(*mop),
-					MobjThinkerName(*mop),
-					(*mop)->thinker.references,
-					source_file,
-					source_line
-			);
-		}
-
-		(*mop)->thinker.debug_time = leveltime;
-#endif
-	}
-
-	if (targ != NULL) // Set new target and if non-NULL, increase its counter
-	{
+	if ((*mop = targ) != NULL) // Set new target and if non-NULL, increase its counter
 		targ->thinker.references++;
-
-#ifdef PARANOIA
-		targ->thinker.debug_time = leveltime;
-#endif
-	}
-
-	*mop = targ;
-
 	return targ;
 }
 
@@ -455,7 +363,7 @@ static inline void P_RunThinkers(void)
 	for (currentthinker = thinkercap.next; currentthinker != &thinkercap; currentthinker = currentthinker->next)
 	{
 #ifdef PARANOIA
-		I_Assert(currentthinker->function.acp1 != NULL);
+		I_Assert(currentthinker->function.acp1 != NULL)
 #endif
 		currentthinker->function.acp1(currentthinker);
 	}
@@ -556,10 +464,10 @@ void P_RunChaseCameras(void)
 			player_t *p = &players[displayplayers[i]];
 			camera_t *cam = &camera[i];
 
-			if (cv_verticallook[i].value && leveltime > starttime && p->mo && p->kartstuff[k_respawn] == 0 && p->kartstuff[k_throwdir] != 0)
+			if (cv_verticallook.value && leveltime > starttime && p->mo && p->kartstuff[k_respawn] == 0 && p->kartstuff[k_throwdir] != 0)
 			{
 				if (p->speed < 6 * p->mo->scale && abs(cam->dpad_y_held) < 2*TICRATE)
-					cam->dpad_y_held += p->kartstuff[k_throwdir];
+					cam->dpad_y_held += intsign(p->kartstuff[k_throwdir]);
 			}
 			else
 				cam->dpad_y_held = 0;
@@ -615,7 +523,7 @@ static inline void P_ResetSpriteStuff(void)
 
 		mo = (mobj_t *)th;
 
-		if (!mo || (mo->sprite == SPR_NULL) || (mo->flags2 & MF2_DONTDRAW) || (mo->type == MT_SHADOW))
+		if (mo->sprite == SPR_NULL || mo->flags2 & MF2_DONTDRAW || mo->type == MT_SHADOW)
 			continue;
 
 		mo->spritexscale = mo->realxscale;
@@ -721,7 +629,7 @@ void P_Ticker(boolean run)
 			}
 #endif
 		}
-
+		
 		ps_lua_mobjhooks.value.i = 0;
 		ps_checkposition_calls.value.i = 0;
 
@@ -739,7 +647,8 @@ void P_Ticker(boolean run)
 	}
 
 	// Keep track of how long they've been playing!
-	K_StatTicker();
+	if (!demo.playback) // Don't increment if a demo is playing.
+		totalplaytime++;
 
 	if (run)
 	{
@@ -927,7 +836,6 @@ void P_PreTicker(INT32 frames)
 		LUA_HOOK(PreThinkFrame);
 
 		for (i = 0; i < MAXPLAYERS; i++)
-		{
 			if (playeringame[i] && players[i].mo && !P_MobjWasRemoved(players[i].mo))
 			{
 				// stupid fucking cmd hack
@@ -942,7 +850,6 @@ void P_PreTicker(INT32 frames)
 
 				memcpy(&players[i].cmd, &temptic, sizeof(ticcmd_t));
 			}
-		}
 
 		// Dynamic slopeness
 		if (midgamejoin)

src/p_tick.h

@@ -14,8 +14,6 @@
 #ifndef __P_TICK__
 #define __P_TICK__
 
-#include "doomdef.h"
-
 #ifdef __GNUG__
 #pragma interface
 #endif
@@ -31,16 +29,6 @@ void P_Ticker(boolean run);
 void P_PreTicker(INT32 frames);
 void P_DoTeamscrambling(void);
 void P_RemoveThinkerDelayed(thinker_t *thinker);
+mobj_t *P_SetTarget(mobj_t **mo, mobj_t *target);   // killough 11/98
 
-mobj_t *P_SetTarget2(mobj_t **mo, mobj_t *target
-#ifdef PARANOIA
-, const char *source_file, int source_line
-#endif
-);
-
-#ifdef PARANOIA
-#define P_SetTarget(...) P_SetTarget2(__VA_ARGS__, __FILE__, __LINE__)
-#else
-#define P_SetTarget P_SetTarget2
-#endif
 #endif

src/p_user.c

@@ -557,9 +557,14 @@ void P_PlayRinglossSound(mobj_t *source, mobj_t *damager)
 		{
 			sfxenum_t sfx = sfx_khurt1 + key;
 
+			INT32 skinnum = -1;
+
 			// I HATE LOCALSKINS! I HATE LOCALSKINS! :AAAAAAAAAA:
 			if (source->player)
-				sfx = K_GetPlayerSkin(source->player)->soundsid[SKSKPAN1 + key];
+				skinnum = source->player->skinlocal ? (source->player->localskin - 1) : source->player->skin;
+
+			if (skinnum >= 0)
+				sfx = (source->player->skinlocal ? localskins : skins)[skinnum].soundsid[SKSKPAN1 + key];
 
 			S_StartSound(NULL, sfx);
 		}
@@ -1190,9 +1195,9 @@ mobj_t *P_SpawnGhostMobj(mobj_t *mobj)
 	ghost->tics = -1;
 	ghost->frame &= ~FF_TRANSMASK;
 	ghost->frame |= tr_trans50<<FF_TRANSSHIFT;
-	ghost->slopepitch = mobj->slopepitch;
+	ghost->slopepitch = mobj->slopepitch; 
 	ghost->sloperoll = mobj->sloperoll;
-
+	
 	ghost->fuse = ghost->info->damage;
 	ghost->skin = mobj->skin;
 	ghost->localskin = mobj->localskin;
@@ -1219,10 +1224,6 @@ mobj_t *P_SpawnGhostMobj(mobj_t *mobj)
 	ghost->old_sloperoll = mobj->old_sloperoll2;
 	ghost->old_slopepitch = mobj->old_slopepitch2;
 	ghost->old_scale = mobj->old_scale2;
-	ghost->old_spritexscale = mobj->old_spritexscale2;
-	ghost->old_spriteyscale = mobj->old_spriteyscale2;
-	ghost->old_spritexoffset = mobj->old_spritexoffset2;
-	ghost->old_spriteyoffset = mobj->old_spriteyoffset2;
 
 	return ghost;
 }
@@ -1247,24 +1248,42 @@ void P_DoPlayerExit(player_t *player)
 		player->exiting = raceexittime+2;
 		K_KartUpdatePosition(player);
 
-		if (cv_kartvoices.value && !P_MobjWasRemoved(player->mo))
+		if (!P_MobjWasRemoved(player->mo) && cv_kartvoices.value)
 		{
-			const int soundid = K_IsPlayerLosing(player) ? sfx_klose: sfx_kwin; // fix godjjsa win sounds
-
 			if (P_IsLocalPlayer(player))
 			{
-				sfxenum_t sfx_id = K_GetMobjSkin(player->mo)->soundsid[S_sfx[soundid].skinsound];
+				sfxenum_t sfx_id;
+				// fix godjjsa win sounds
+				if (K_IsPlayerLosing(player)) {
+					if (player->mo->localskin)
+						sfx_id = ((skin_t *)player->mo->localskin)->soundsid[S_sfx[sfx_klose].skinsound];
+					else
+						sfx_id = ((skin_t *)player->mo->skin)->soundsid[S_sfx[sfx_klose].skinsound];
+				}
+				else {
+					if (player->mo->localskin)
+						sfx_id = ((skin_t *)player->mo->localskin)->soundsid[S_sfx[sfx_kwin].skinsound];
+					else
+						sfx_id = ((skin_t *)player->mo->skin)->soundsid[S_sfx[sfx_kwin].skinsound];
+				}
 				S_StartSound(NULL, sfx_id);
 			}
 			else
 			{
-				S_StartSound(player->mo, soundid);
+				if (K_IsPlayerLosing(player))
+					S_StartSound(player->mo, sfx_klose);
+				else
+					S_StartSound(player->mo, sfx_kwin);
 			}
 		}
 
 		if (cv_inttime.value > 0)
 			P_EndingMusic(player);
 
+		// SRB2kart 120217
+		//if (!exitcountdown)
+			//exitcountdown = racecountdown + 8*TICRATE;
+
 		if (P_CheckRacers())
 			player->exiting = raceexittime+1;
 	}
@@ -1307,9 +1326,8 @@ boolean P_InSpaceSector(mobj_t *mo) // Returns true if you are in space
 
 			if (GETSECSPECIAL(rover->master->frontsector->special, 1) != SPACESPECIAL)
 				continue;
-
-			topheight    = P_GetFFloorTopZAt(rover, mo->x, mo->y);
-			bottomheight = P_GetFFloorBottomZAt(rover, mo->x, mo->y);
+			topheight = *rover->t_slope ? P_GetZAt(*rover->t_slope, mo->x, mo->y) : *rover->topheight;
+			bottomheight = *rover->b_slope ? P_GetZAt(*rover->b_slope, mo->x, mo->y) : *rover->bottomheight;
 
 			if (mo->z + (mo->height/2) > topheight)
 				continue;
@@ -1343,8 +1361,8 @@ boolean P_InQuicksand(mobj_t *mo) // Returns true if you are in quicksand
 			if (!(rover->flags & FF_QUICKSAND))
 				continue;
 
-			topheight    = P_GetFFloorTopZAt(rover, mo->x, mo->y);
-			bottomheight = P_GetFFloorBottomZAt(rover, mo->x, mo->y);
+			topheight = *rover->t_slope ? P_GetZAt(*rover->t_slope, mo->x, mo->y) : *rover->topheight;
+			bottomheight = *rover->b_slope ? P_GetZAt(*rover->b_slope, mo->x, mo->y) : *rover->bottomheight;
 
 			if (mo->z + flipoffset > topheight)
 				continue;
@@ -1635,8 +1653,8 @@ static void P_CheckQuicksand(player_t *player)
 		if (!(rover->flags & FF_QUICKSAND))
 			continue;
 
-		topheight    = P_GetFFloorTopZAt(rover, player->mo->x, player->mo->y);
-		bottomheight = P_GetFFloorBottomZAt(rover, player->mo->x, player->mo->y);
+		topheight = *rover->t_slope ? P_GetZAt(*rover->t_slope, player->mo->x, player->mo->y) : *rover->topheight;
+		bottomheight = *rover->b_slope ? P_GetZAt(*rover->b_slope, player->mo->x, player->mo->y) : *rover->bottomheight;
 
 		if (topheight >= player->mo->z && bottomheight < player->mo->z + player->mo->height)
 		{
@@ -2124,16 +2142,12 @@ static void P_SpectatorMovement(player_t *player)
 void P_BlackOw(player_t *player)
 {
 	INT32 i;
-	S_StartSound(player->mo, sfx_bkpoof); // Sound the BANG!
+	S_StartSound (player->mo, sfx_bkpoof); // Sound the BANG!
 
 	for (i = 0; i < MAXPLAYERS; i++)
-	{
-		if (!playeringame[i])
-			continue;
-
-		if (P_AproxDistance(player->mo->x - players[i].mo->x, player->mo->y - players[i].mo->y) < 1536*FRACUNIT)
+		if (playeringame[i] && P_AproxDistance(player->mo->x - players[i].mo->x,
+			player->mo->y - players[i].mo->y) < 1536*FRACUNIT)
 			P_FlashPal(&players[i], PAL_NUKE, 10);
-	}
 
 	P_NukeEnemies(player->mo, player->mo, 1536*FRACUNIT); // Search for all nearby enemies and nuke their pants off!
 	player->powers[pw_shield] = player->powers[pw_shield] & SH_STACK;
@@ -2163,15 +2177,12 @@ void P_ElementalFireTrail(player_t *player)
 	{
 		newx = player->mo->x + P_ReturnThrustX(player->mo, travelangle + ((i&1) ? -1 : 1)*ANGLE_135, FixedMul(24*FRACUNIT, player->mo->scale));
 		newy = player->mo->y + P_ReturnThrustY(player->mo, travelangle + ((i&1) ? -1 : 1)*ANGLE_135, FixedMul(24*FRACUNIT, player->mo->scale));
-
 		if (player->mo->standingslope)
 		{
-			ground = P_GetSlopeZAt(player->mo->standingslope, newx, newy);
-
+			ground = P_GetZAt(player->mo->standingslope, newx, newy);
 			if (player->mo->eflags & MFE_VERTICALFLIP)
 				ground -= FixedMul(mobjinfo[MT_SPINFIRE].height, player->mo->scale);
 		}
-
 		flame = P_SpawnMobj(newx, newy, ground, MT_SPINFIRE);
 		P_SetTarget(&flame->target, player->mo);
 		flame->angle = travelangle;
@@ -2182,7 +2193,6 @@ void P_ElementalFireTrail(player_t *player)
 
 		flame->momx = 8;
 		P_XYMovement(flame);
-
 		if (P_MobjWasRemoved(flame))
 			continue;
 
@@ -2528,10 +2538,7 @@ static void P_MovePlayer(player_t *player)
 
 static void P_DoZoomTube(player_t *player)
 {
-	INT32 sequence;
 	fixed_t speed;
-	thinker_t *th;
-	mobj_t *mo2;
 	mobj_t *waypoint = NULL;
 	fixed_t dist;
 	boolean reverse;
@@ -2547,8 +2554,6 @@ static void P_DoZoomTube(player_t *player)
 
 	speed = abs(player->speed);
 
-	sequence = player->mo->tracer->threshold;
-
 	// change slope
 	dist = P_AproxDistance(P_AproxDistance(player->mo->tracer->x - player->mo->x, player->mo->tracer->y - player->mo->y), player->mo->tracer->z - player->mo->z);
 
@@ -2580,28 +2585,7 @@ static void P_DoZoomTube(player_t *player)
 		CONS_Debug(DBG_GAMELOGIC, "Looking for next waypoint...\n");
 
 		// Find next waypoint
-		for (th = thinkercap.next; th != &thinkercap; th = th->next)
-		{
-			if (th->function.acp1 != (actionf_p1)P_MobjThinker) // Not a mobj thinker
-				continue;
-
-			mo2 = (mobj_t *)th;
-
-			if (mo2->type != MT_TUBEWAYPOINT)
-				continue;
-
-			if (mo2->threshold != sequence)
-				continue;
-
-			if (reverse && mo2->health != player->mo->tracer->health - 1)
-				continue;
-
-			if (!reverse && mo2->health != player->mo->tracer->health + 1)
-				continue;
-
-			waypoint = mo2;
-			break;
-		}
+		waypoint = reverse ? P_GetPreviousWaypoint(player->mo->tracer, false) : P_GetNextWaypoint(player->mo->tracer, false);
 
 		if (waypoint)
 		{
@@ -3111,7 +3095,7 @@ consvar_t cv_cam_timeover[MAXSPLITSCREENPLAYERS] = {
 	{"cam_timeover", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"cam2_timeover", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"cam3_timeover", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"cam4_timeover", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL}
+	{"cam4_timeover", "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},
 };
 
 static CV_PossibleValue_t freecam_speed_cons_t[] = {{0, "MIN"}, {10, "MAX"}, {0, NULL}};
@@ -3119,7 +3103,7 @@ consvar_t cv_freecam_speed[MAXSPLITSCREENPLAYERS] = {
 	{"freecam_speed", "1", CV_SAVE, freecam_speed_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"freecam2_speed", "1", CV_SAVE, freecam_speed_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"freecam3_speed", "1", CV_SAVE, freecam_speed_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"freecam4_speed", "1", CV_SAVE, freecam_speed_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL}
+	{"freecam4_speed", "1", CV_SAVE, freecam_speed_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
 };
 
 consvar_t cv_tilting = {"tilting", "Off", CV_SAVE|CV_CALL, CV_OnOff, Bird_menu_Onchange, 0, NULL, NULL, 0, 0, NULL};
@@ -3129,13 +3113,7 @@ consvar_t cv_tiltsmoothing = {"tiltsmoothing", "32", CV_SAVE, CV_Natural, NULL,
 consvar_t cv_actionmovie = {"actionmovie", "Off", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
 
 static CV_PossibleValue_t lookbackmom_cons_t[] = {{0, "Off"}, {1, "On"}, {2, "Double"}, {0, NULL}};
-
-consvar_t cv_lookbackmom[MAXSPLITSCREENPLAYERS] = {
-	{"cameralookbackmom", "Off", CV_SAVE, lookbackmom_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"cameralookbackmom2", "Off", CV_SAVE, lookbackmom_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"cameralookbackmom3", "Off", CV_SAVE, lookbackmom_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
-	{"cameralookbackmom4", "Off", CV_SAVE, lookbackmom_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL}
-};
+consvar_t cv_lookbackmom = {"cameralookbackmom", "Off", CV_SAVE, lookbackmom_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL};
 
 fixed_t t_cam_rotate[MAXSPLITSCREENPLAYERS] = {-42, -42, -42, -42};
 
@@ -4022,10 +4000,10 @@ boolean P_MoveChaseCamera(player_t *player, camera_t *thiscam, boolean resetcall
 		// when looking back, camera's momentum
 		// should inherit the momentum of the player
 		// if value is 2, add extra
-		if (cv_lookbackmom[num].value && lookback && lookbackdelay[num])
+		if (cv_lookbackmom.value && lookback && lookbackdelay[num])
 		{
-			thiscam->momx += cv_lookbackmom[num].value*mo->momx;
-			thiscam->momy += cv_lookbackmom[num].value*mo->momy;
+			thiscam->momx += cv_lookbackmom.value*mo->momx;
+			thiscam->momy += cv_lookbackmom.value*mo->momy;
 		}
 
 		thiscam->momz = FixedMul(z - thiscam->z, camspeed/2);
@@ -4452,36 +4430,6 @@ DoABarrelRoll (player_t *player)
 		player->tilt = slope;
 }
 
-// mhhm this is definitely not mostly copy pasted code from SRB2s music test (:
-// TODO: make this sane lmao
-static void P_DoFunnyDance(player_t *player)
-{
-	fixed_t bpm; // 140bpm ish
-
-	if (player->spectator || !player->mo || player->kartstuff[k_respawn] || player->mo->salty_jump) // this looks jank as hell during hop
-		return;
-
-	player->squishdance.bounce = 0;
-
-	// bpm = FixedDiv((60*TICRATE)<<FRACBITS, FLOAT_TO_FIXED(mapmusic.bpm)); << maybe can get the tempo and beat detection lib to work for bpm autodetection
-	bpm = FixedDiv((60*TICRATE)<<FRACBITS, FLOAT_TO_FIXED((float)cv_squishdancespeed.value));
-
-	player->squishdance.work = (player->squishdance.time << FRACBITS) % bpm;
-
-	if (player->squishdance.time >= (FRACUNIT >> 1)) // prevent overflow jump - takes about 15 minutes
-		player->squishdance.time = (player->squishdance.work >> FRACBITS);
-
-	player->squishdance.work = FixedDiv(player->squishdance.work*180, bpm);
-
-	player->squishdance.ang = ((FixedAngle(player->squishdance.work) >> ANGLETOFINESHIFT) & FINEMASK);
-	player->squishdance.bounce = ((FINESINE(player->squishdance.ang) - FRACUNIT/2) / 2);
-
-	player->mo->spritexscale -= player->squishdance.bounce;
-	player->mo->spriteyscale += player->squishdance.bounce;
-
-	player->squishdance.time++;
-}
-
 #define SPINOUTROTSPEED (24 * FRACUNIT)
 #define MAXSPINROT (360 * FRACUNIT)
 
@@ -4761,7 +4709,7 @@ void P_PlayerThink(player_t *player)
 				continue;
 			break;
 		}
-
+		
 		if (i < MAXPLAYERS && !player->spectator && !player->exiting && !(player->pflags & PF_TIMEOVER))
 		{
 			const tic_t griefval = cv_antigrief.value * TICRATE;
@@ -4782,7 +4730,11 @@ void P_PlayerThink(player_t *player)
 							&& !P_IsLocalPlayer(player)) // P_IsMachineLocalPlayer for DRRR
 						{
 							// Send kick
-							SendKick(n, KICK_MSG_GRIEF);
+							UINT8 buf[2];
+
+							buf[0] = n;
+							buf[1] = KICK_MSG_GRIEF;
+							SendNetXCmd(XD_KICK, &buf, 2);
 						}
 						else
 						{
@@ -5022,19 +4974,6 @@ void P_PlayerThink(player_t *player)
 	if (player->losstime && !player->powers[pw_flashing])
 		player->losstime--;
 
-	if (cv_squishdance.value && (cmd->buttons & BT_CUSTOM3))
-	{
-		player->squishdance.countdown++;
-
-		if (player->squishdance.countdown > TICRATE*2)
-			P_DoFunnyDance(player);
-	}
-	else
-	{
-		player->squishdance.countdown = 0;
-		player->squishdance.time = 0;
-	}
-
 	// Flash player after being hit.
 	if (!(player->kartstuff[k_hyudorotimer] // SRB2kart - fixes Hyudoro not flashing when it should.
 		|| player->kartstuff[k_growshrinktimer] > 0 // Grow doesn't flash either.

src/r_bsp.c

@@ -13,13 +13,12 @@
 
 #include "doomdef.h"
 #include "g_game.h"
-
-#include "r_fps.h"
 #include "r_local.h"
 #include "r_state.h"
 #include "r_portal.h" // Add seg portals
-#include "r_splats.h"
 
+
+#include "r_splats.h"
 #include "p_local.h" // camera
 #include "p_slopes.h"
 #include "z_zone.h" // Check R_Prep3DFloors
@@ -373,11 +372,30 @@ sector_t *R_FakeFlat(sector_t *sec, sector_t *tempsec, INT32 *floorlightlevel,
 	return sec;
 }
 
-boolean R_IsEmptyLine(seg_t *line, const sector_t *front, const sector_t *back)
+boolean R_IsEmptyLine(seg_t *line, sector_t *front, sector_t *back)
 {
-	return (!line->sidedef->midtexture && !line->polyseg
-	&& ((!front->ffloors && !back->ffloors) || front->tag == back->tag)
-	&& (memcmp(front, back, (offsetof(sector_t, extra_colormap) + sizeof(extracolormap_t *))) == 0));
+	return (
+		!line->polyseg &&
+		back->ceilingpic == front->ceilingpic
+		&& back->floorpic == front->floorpic
+		&& back->f_slope == front->f_slope
+		&& back->c_slope == front->c_slope
+		&& back->lightlevel == front->lightlevel
+		&& !line->sidedef->midtexture
+		// Check offsets too!
+		&& back->floor_xoffs == front->floor_xoffs
+		&& back->floor_yoffs == front->floor_yoffs
+		&& back->floorpic_angle == front->floorpic_angle
+		&& back->ceiling_xoffs == front->ceiling_xoffs
+		&& back->ceiling_yoffs == front->ceiling_yoffs
+		&& back->ceilingpic_angle == front->ceilingpic_angle
+		// Consider altered lighting.
+		&& back->floorlightsec == front->floorlightsec
+		&& back->ceilinglightsec == front->ceilinglightsec
+		// Consider colormaps
+		&& back->extra_colormap == front->extra_colormap
+		&& ((!front->ffloors && !back->ffloors)
+		|| front->tag == back->tag));
 }
 
 //
@@ -483,8 +501,11 @@ static void R_AddLine(seg_t *line)
 	if (frontsector->f_slope || frontsector->c_slope || backsector->f_slope || backsector->c_slope)
 	{
 #define SLOPEPARAMS(slope, end1, end2, normalheight) \
-	end1 = P_GetZAt(slope, line->v1->x, line->v1->y, normalheight); \
-	end2 = P_GetZAt(slope, line->v2->x, line->v2->y, normalheight);
+		if (slope) { \
+			end1 = P_GetZAt(slope, line->v1->x, line->v1->y); \
+			end2 = P_GetZAt(slope, line->v2->x, line->v2->y); \
+		} else \
+			end1 = end2 = normalheight;
 
 		SLOPEPARAMS(frontsector->f_slope, frontf1, frontf2, frontsector->floorheight)
 		SLOPEPARAMS(frontsector->c_slope, frontc1, frontc2, frontsector->ceilingheight)
@@ -792,7 +813,7 @@ static void R_AddPolyObjects(subsector_t *sub)
 		++numpolys;
 		po = (polyobj_t *)(po->link.next);
 	}
-
+	
 	// for render stats
 	ps_numpolyobjects.value.i += numpolys;
 
@@ -847,8 +868,13 @@ static void R_Subsector(size_t num)
 
 	floorcolormap = ceilingcolormap = frontsector->extra_colormap;
 
-	floorcenterz   = P_GetSectorFloorZAt(frontsector, frontsector->soundorg.x, frontsector->soundorg.y);
-	ceilingcenterz = P_GetSectorCeilingZAt(frontsector, frontsector->soundorg.x, frontsector->soundorg.y);
+	floorcenterz =
+		frontsector->f_slope ? P_GetZAt(frontsector->f_slope, frontsector->soundorg.x, frontsector->soundorg.y) :
+		frontsector->floorheight;
+
+	ceilingcenterz =
+		frontsector->c_slope ? P_GetZAt(frontsector->c_slope, frontsector->soundorg.x, frontsector->soundorg.y) :
+		frontsector->ceilingheight;
 
 	// Check and prep all 3D floors. Set the sector floor/ceiling light levels and colormaps.
 	if (frontsector->ffloors)
@@ -893,7 +919,9 @@ static void R_Subsector(size_t num)
 
 	sub->sector->extra_colormap = frontsector->extra_colormap;
 
-	if ((P_GetSectorFloorZAt(frontsector, viewx, viewy) < viewz || (frontsector->heightsec != -1
+	if (((
+			frontsector->f_slope ? P_GetZAt(frontsector->f_slope, viewx, viewy) :
+		frontsector->floorheight) < viewz || (frontsector->heightsec != -1
 		&& sectors[frontsector->heightsec].ceilingpic == skyflatnum)))
 	{
 		floorplane = R_FindPlane(frontsector->floorheight, frontsector->floorpic, floorlightlevel,
@@ -905,7 +933,9 @@ static void R_Subsector(size_t num)
 	else
 		floorplane = NULL;
 
-	if ((P_GetSectorCeilingZAt(frontsector, viewx, viewy) > viewz || frontsector->ceilingpic == skyflatnum
+	if (((
+			frontsector->c_slope ? P_GetZAt(frontsector->c_slope, viewx, viewy) :
+		frontsector->ceilingheight) > viewz || frontsector->ceilingpic == skyflatnum
 		|| (frontsector->heightsec != -1
 		&& sectors[frontsector->heightsec].floorpic == skyflatnum)))
 	{
@@ -923,14 +953,13 @@ static void R_Subsector(size_t num)
 	ffloor[numffloors].slope = NULL;
 	ffloor[numffloors].plane = NULL;
 	ffloor[numffloors].polyobj = NULL;
-
 	if (frontsector->ffloors)
 	{
 		fixed_t heightcheck, planecenterz;
 
 		for (rover = frontsector->ffloors; rover && numffloors < MAXFFLOORS; rover = rover->next)
 		{
-			if (!(rover->flags & FF_EXISTS) || !(rover->flags & FF_RENDERPLANES) || !(rover->flags & FF_RENDERALL))
+			if (!(rover->flags & FF_EXISTS) || !(rover->flags & FF_RENDERPLANES))
 				continue;
 
 			if (frontsector->cullheight)
@@ -945,9 +974,13 @@ static void R_Subsector(size_t num)
 			ffloor[numffloors].plane = NULL;
 			ffloor[numffloors].polyobj = NULL;
 
-			heightcheck  = P_GetFFloorBottomZAt(rover, viewx, viewy);
-			planecenterz = P_GetFFloorBottomZAt(rover, frontsector->soundorg.x, frontsector->soundorg.y);
+			heightcheck =
+				*rover->b_slope ? P_GetZAt(*rover->b_slope, viewx, viewy) :
+				*rover->bottomheight;
 
+			planecenterz =
+				*rover->b_slope ? P_GetZAt(*rover->b_slope, frontsector->soundorg.x, frontsector->soundorg.y) :
+				*rover->bottomheight;
 			if (planecenterz <= ceilingcenterz
 				&& planecenterz >= floorcenterz
 				&& ((viewz < heightcheck && !(rover->flags & FF_INVERTPLANES))
@@ -973,16 +1006,18 @@ static void R_Subsector(size_t num)
 				ffloor[numffloors].ffloor = rover;
 				numffloors++;
 			}
-
 			if (numffloors >= MAXFFLOORS)
 				break;
-
 			ffloor[numffloors].plane = NULL;
 			ffloor[numffloors].polyobj = NULL;
 
-			heightcheck  = P_GetFFloorTopZAt(rover, viewx, viewy);
-			planecenterz = P_GetFFloorTopZAt(rover, frontsector->soundorg.x, frontsector->soundorg.y);
+			heightcheck =
+				*rover->t_slope ? P_GetZAt(*rover->t_slope, viewx, viewy) :
+				*rover->topheight;
 
+			planecenterz =
+				*rover->t_slope ? P_GetZAt(*rover->t_slope, frontsector->soundorg.x, frontsector->soundorg.y) :
+				*rover->topheight;
 			if (planecenterz >= floorcenterz
 				&& planecenterz <= ceilingcenterz
 				&& ((viewz > heightcheck && !(rover->flags & FF_INVERTPLANES))
@@ -1150,7 +1185,7 @@ void R_Prep3DFloors(sector_t *sector)
 	else
 		memset(sector->lightlist, 0, sizeof (lightlist_t) * count);
 
-	heighttest = P_GetSectorCeilingZAt(sector, sector->soundorg.x, sector->soundorg.y);
+	heighttest = sector->c_slope ? P_GetZAt(sector->c_slope, sector->soundorg.x, sector->soundorg.y) : sector->ceilingheight;
 
 	sector->lightlist[0].height = heighttest + 1;
 	sector->lightlist[0].slope = sector->c_slope;
@@ -1171,7 +1206,7 @@ void R_Prep3DFloors(sector_t *sector)
 				&& !(rover->flags & FF_CUTLEVEL) && !(rover->flags & FF_CUTSPRITES)))
 				continue;
 
-			heighttest = P_GetFFloorTopZAt(rover, sector->soundorg.x, sector->soundorg.y);
+			heighttest = *rover->t_slope ? P_GetZAt(*rover->t_slope, sector->soundorg.x, sector->soundorg.y) : *rover->topheight;
 
 			if (heighttest > bestheight && heighttest < maxheight)
 			{
@@ -1180,9 +1215,8 @@ void R_Prep3DFloors(sector_t *sector)
 				bestslope = *rover->t_slope;
 				continue;
 			}
-			if (rover->flags & FF_DOUBLESHADOW)
-			{
-				heighttest = P_GetFFloorBottomZAt(rover, sector->soundorg.x, sector->soundorg.y);
+			if (rover->flags & FF_DOUBLESHADOW) {
+				heighttest = *rover->b_slope ? P_GetZAt(*rover->b_slope, sector->soundorg.x, sector->soundorg.y) : *rover->bottomheight;
 
 				if (heighttest > bestheight
 					&& heighttest < maxheight)
@@ -1206,7 +1240,6 @@ void R_Prep3DFloors(sector_t *sector)
 		sector->lightlist[i].slope = bestslope;
 		sec = &sectors[best->secnum];
 		mapnum = sec->midmap;
-
 		if (mapnum >= 0 && (size_t)mapnum < num_extra_colormaps)
 			sec->extra_colormap = &extra_colormaps[mapnum];
 		else
@@ -1230,8 +1263,7 @@ void R_Prep3DFloors(sector_t *sector)
 
 		if (best->flags & FF_DOUBLESHADOW)
 		{
-			heighttest = P_GetFFloorBottomZAt(best, sector->soundorg.x, sector->soundorg.y);
-
+			heighttest = *best->b_slope ? P_GetZAt(*best->b_slope, sector->soundorg.x, sector->soundorg.y) : *best->bottomheight;
 			if (bestheight == heighttest) ///TODO: do this in a more efficient way -Red
 			{
 				sector->lightlist[i].lightlevel = sector->lightlist[best->lastlight].lightlevel;