saturn/SRB2Kart-Saturn
2
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 23 Wiki Activity

Borderless window toggle #193

Merged
chromaticpipe merged 2 commits from borderlesswindowtoggle into Saturn-Next 2025-07-26 22:42:50 +02:00
Conversation 5 Commits 2 Files Changed 4
+20 -2
chromaticpipe commented 2025-07-26 19:02:19 +02:00 (Migrated from github.com)
Copy link
Copy source

Backport of https://codeberg.org/srb2classic/srb2classic/pulls/67

https://github.com/user-attachments/assets/42c6a0ba-1126-47d1-a715-58ced4dfb42c

Backport of https://codeberg.org/srb2classic/srb2classic/pulls/67 https://github.com/user-attachments/assets/42c6a0ba-1126-47d1-a715-58ced4dfb42c
alufolie91 commented 2025-07-26 20:41:57 +02:00 (Migrated from github.com)
Copy link
Copy source

pretty neat, thisll prob really helps with the weird fullscreen quirks on windows so people can use this instead
though personally id prefer this being a new value for cv_fullscreen, but that may be wonky to implement there, gonna wait on what @Indev450 thinks
thanks for contribution c:

pretty neat, thisll prob really helps with the weird fullscreen quirks on windows so people can use this instead though _personally_ id prefer this being a new value for cv_fullscreen, but that may be wonky to implement there, gonna wait on what @Indev450 thinks thanks for contribution c:
Indev450 commented 2025-07-26 21:50:32 +02:00 (Migrated from github.com)
Copy link
Copy source

Agree with lug, would be nice having it be part of cv_fullscreen, can probably be implemented with adding something like I_SetBorderlessWindow in i_video.h and sdl/i_video.c and using it from SCR_ChangeFullscreen (tho also will need to change USE_FULLSCREEN macro in sdl/i_video.c to check for cv_fullscreen.value to be equal 1 specifically)

Agree with lug, would be nice having it be part of cv_fullscreen, can probably be implemented with adding something like `I_SetBorderlessWindow` in i_video.h and sdl/i_video.c and using it from SCR_ChangeFullscreen (tho also will need to change `USE_FULLSCREEN` macro in sdl/i_video.c to check for cv_fullscreen.value to be equal 1 specifically)
chromaticpipe commented 2025-07-26 22:19:13 +02:00 (Migrated from github.com)
Copy link
Copy source

Ok, I just did and i'm praying I didn't break anything...

Ok, I just did and i'm praying I didn't break anything...
👍 2
alufolie91 commented 2025-07-26 22:26:56 +02:00 (Migrated from github.com)
Copy link
Copy source

works good for me both on x11 and wayland (minus the usual wayland quirks lul)
will check on windows in a bit just in case
so this is good to go for me c:

works good for me both on x11 and wayland (minus the usual wayland quirks lul) will check on windows in a bit just in case so this is good to go for me c:
alufolie91 commented 2025-07-26 22:42:46 +02:00 (Migrated from github.com)
Copy link
Copy source

alr all fine!
much thanks c:

alr all fine! much thanks c:
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
alufolie91 indev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saturn/SRB2Kart-Saturn#193