fix issues with interpolation when spawning mobjs

fixes them seemingly coming really fast out of nowhere
needs testing as this may break some things from addons

src/CMakeLists.txt

@@ -275,7 +275,6 @@ if(${SRB2_CONFIG_HAVE_BLUA})
 		lua_hooklib.c
 		lua_hudlib.c
 		lua_hudlib_drawlist.c
-		lua_profile.cpp
 		lua_infolib.c
 		lua_maplib.c
 		lua_mathlib.c
@@ -291,7 +290,6 @@ if(${SRB2_CONFIG_HAVE_BLUA})
 		lua_hook.h
 		lua_hud.h
 		lua_hudlib_drawlist.h
-		lua_profile.h
 		lua_libs.h
 		lua_script.h
 		lua_udatalib.h

src/Makefile.d/platform.mk

@@ -42,8 +42,6 @@ include Makefile.d/haiku.mk
 else ifdef SOLARIS # FIXME: UNTESTED
 UNIX=1
 platform=solaris
-else ifdef CYGWIN32 # FIXME: UNTESTED
-platform=cygwin
 else ifdef MINGW
 ifdef MINGW64
 NONX86=1

src/Makefile.d/sdl.mk

@@ -15,16 +15,6 @@ sources+=$(call List,sdl/Sourcefile)
 
 NOUPNP=1
 
-# FIXME: UNTESTED
-#ifdef PANDORA
-#include sdl/SRB2Pandora/Makefile.cfg
-#endif #ifdef PANDORA
-
-# FIXME: UNTESTED
-#ifdef CYGWIN32
-#include sdl/MakeCYG.cfg
-#endif #ifdef CYGWIN32
-
 ifndef NOHW
 sources+=sdl/ogl_sdl.c
 endif

src/Sourcefile

@@ -99,4 +99,3 @@ lua_skinlib.c
 lua_thinkerlib.c
 lua_udatalib.c
 lua_glib.c
-lua_profile.cpp

src/android/i_system.c

@@ -34,8 +34,8 @@ size_t I_GetFreeMem(size_t *total)
   /* return si.freeram; */
   char buf[1024];
   char *memTag;
-  UINT32 freeKBytes;
-  UINT32 totalKBytes;
+  size_t freeKBytes;
+  size_t totalKBytes;
   INT32 n;
   INT32 meminfo_fd = -1;
 
@@ -46,7 +46,7 @@ size_t I_GetFreeMem(size_t *total)
   if (n < 0)
     {
       // Error
-      *total = 0L;
+      *total = 0;
       return 0;
     }
 
@@ -54,7 +54,7 @@ size_t I_GetFreeMem(size_t *total)
   if (NULL == (memTag = strstr(buf, MEMTOTAL)))
     {
       // Error
-      *total = 0L;
+      *total = 0;
       return 0;
     }
 
@@ -64,7 +64,7 @@ size_t I_GetFreeMem(size_t *total)
   if (NULL == (memTag = strstr(buf, MEMFREE)))
     {
       // Error
-      *total = 0L;
+      *total = 0;
       return 0;
     }
 

src/core/memory.cpp

@@ -114,6 +114,7 @@ void* PoolAllocator::allocate()
 
 	FreeBlock* ret = head_;
 	head_ = head_->next;
+	allocated_blocks_++;
 	return ret;
 }
 
@@ -125,6 +126,7 @@ void PoolAllocator::deallocate(void* p)
 	FreeBlock* block = reinterpret_cast<FreeBlock*>(p);
 	block->next = head_;
 	head_ = block;
+	allocated_blocks_--;
 }
 
 void PoolAllocator::release()
@@ -144,6 +146,7 @@ void PoolAllocator::release()
 
 	first_chunk_ = nullptr;
 	head_ = nullptr;
+	allocated_blocks_ = 0;
 }
 
 static LinearMemory g_frame_memory {4 * 1024 * 1024};

src/core/memory.h

@@ -37,6 +37,7 @@ class PoolAllocator final
 	FreeBlock* head_;
 	size_t block_size_;
 	size_t blocks_;
+	size_t allocated_blocks_;
 	int32_t tag_;
 
 	ChunkFooter* allocate_chunk();
@@ -47,6 +48,7 @@ public:
 		, head_(nullptr)
 		, block_size_(block_size)
 		, blocks_(blocks)
+		, allocated_blocks_(0)
 		, tag_(tag)
 	{}
 	PoolAllocator(const PoolAllocator&) = delete;
@@ -59,6 +61,8 @@ public:
 	void* allocate();
 	void deallocate(void* p);
 	constexpr size_t block_size() const noexcept { return block_size_; };
+	constexpr size_t allocated_blocks() const noexcept { return allocated_blocks_; };
+	constexpr size_t allocated_bytes() const noexcept { return allocated_blocks_ * block_size_; };
 
 	void release();
 };

src/d_clisrv.c

@@ -110,7 +110,7 @@ SINT8 joinnode = 0; // used for CL_VIEWSERVER
 boolean player_muted[MAXPLAYERS] = {};
 
 // Server specific vars
-UINT8 playernode[MAXPLAYERS] = {};
+UINT8 playernode[MAXPLAYERS] = {UINT8_MAX};
 
 // Minimum timeout for sending the savegame
 // The actual timeout will be longer depending on the savegame length
@@ -3449,7 +3449,7 @@ void CL_ClearPlayer(INT32 playernum)
 	if (players[playernum].mo)
 	{
 		// Don't leave a NiGHTS ghost!
-		if (UNLIKELY((players[playernum].pflags & PF_NIGHTSMODE) && players[playernum].mo->tracer))
+		if (nightsplayer(&players[playernum]) && players[playernum].mo->tracer)
 			P_RemoveMobj(players[playernum].mo->tracer);
 		P_RemoveMobj(players[playernum].mo);
 	}
@@ -3767,6 +3767,10 @@ static void Command_Ban(void)
 		if (pn == -1 || pn == 0)
 			return;
 
+		// player does not exist
+		if (!playeringame[pn])
+			return;
+
 		WRITEUINT8(p, pn);
 
 		if (COM_Argc() == 2)
@@ -3884,6 +3888,10 @@ static void Command_Kick(void)
 		if (pn == -1 || pn == 0)
 			return;
 
+		// player does not exist
+		if (!playeringame[pn])
+			return;
+
 		// Special case if we are trying to kick a player who is downloading the game state:
 		// trigger a timeout instead of kicking them, because a kick would only
 		// take effect after they have finished downloading
@@ -3933,6 +3941,13 @@ static void Got_KickCmd(const UINT8 **p, INT32 playernum)
 	pnum = READUINT8(*p);
 	msg = READUINT8(*p);
 
+	if (pnum >= MAXPLAYERS)
+	{
+		CONS_Alert(CONS_WARNING, M_GetText("Illegal kick command received from %s for player %d\n"), player_names[playernum], pnum);
+		return;
+	}
+
+	// FIXME: this does not work at all on dedi, servernode == 0 which is prevented from kick/ban command
 	if (pnum == serverplayer && IsPlayerAdmin(playernum))
 	{
 		CONS_Printf(M_GetText("Server is being shut down remotely. Goodbye!\n"));
@@ -3987,6 +4002,16 @@ static void Got_KickCmd(const UINT8 **p, INT32 playernum)
 		msg = KICK_MSG_CON_FAIL;
 	}
 
+	// without this the server will remove itself and thus self destruct on dedicated
+	if (server && (playernode[pnum] == UINT8_MAX || !playeringame[pnum]))
+	{
+		CONS_Alert(CONS_WARNING, M_GetText("Attempting to kick player %d which is not in game received from %s\n"), pnum, player_names[playernum]);
+		return;
+	}
+
+	// make sure we dont read garbage anywhere
+	memset(reason, 0, sizeof(buf));
+
 	if (msg == KICK_MSG_CUSTOM_BAN || msg == KICK_MSG_CUSTOM_KICK)
 	{
 		READSTRINGN(*p, reason, MAX_REASONLENGTH+1);
@@ -6848,10 +6873,7 @@ boolean TryRunTics(tic_t realtics)
 			DEBFILE(va("============ Running tic %d (local %d)\n", gametic, leveltime));
 
 			if (update_stats)
-			{
-				ps_prevtictime = ps_tictime;
 				PS_START_TIMING(ps_tictime);
-			}
 
 			G_Ticker((gametic % NEWTICRATERATIO) == 0);
 			ExtraDataTicker();

src/d_main.c

@@ -79,7 +79,6 @@
 #include "core/memory.h"
 
 #include "lua_script.h"
-#include "lua_profile.h"
 
 /* Manually defined asset hashes for non-CMake builds
  * Last updated 2015 / 05 / 03 - SRB2 v2.1.15 - srb2.srb
@@ -276,20 +275,6 @@ static void D_Renderview(void)
 
 	R_ApplyLevelInterpolators(R_GetTimeFrac(RTF_LEVEL));
 
-	if (rendermode == render_soft && cv_homremoval.value)
-	{
-		if (cv_homremoval.value == 1)
-		{
-			// Clear the software screen buffer to remove HOM
-			memset(vid.screens[0], 31, vid.width * vid.height);
-		}
-		else if (cv_homremoval.value == 2)
-		{
-			//'development' HOM removal -- makes it blindingly obvious if HOM is spotted.
-			memset(vid.screens[0], 32+(timeinmap&15), vid.width * vid.height);
-		}
-	}
-
 	for (i = 0; i <= splitscreen; i++)
 	{
 		if (!P_MobjWasRemoved(players[displayplayers[i]].mo) || players[displayplayers[i]].playerstate == PST_DEAD)
@@ -659,11 +644,6 @@ static boolean D_Display(void)
 
 	    CON_Drawer(); // Ha, i LIED!
 
-		if (cv_lua_profile.value > 0)
-		{
-			LUA_RenderTimers();
-		}
-
 		PS_START_TIMING(ps_swaptime);
 		I_FinishUpdate(); // page flip or blit buffer
 		PS_STOP_TIMING(ps_swaptime);

src/d_netcmd.c

@@ -47,7 +47,6 @@
 #include "z_zone.h"
 #include "lua_script.h"
 #include "lua_hook.h"
-#include "lua_profile.h"
 #include "m_cond.h"
 #include "m_anigif.h"
 #include "k_kart.h" // SRB2kart
@@ -507,9 +506,6 @@ static CV_PossibleValue_t ps_descriptor_cons_t[] = {
 	{1, "Average"}, {2, "SD"}, {3, "Minimum"}, {4, "Maximum"}, {0, NULL}};
 consvar_t cv_ps_descriptor = {"ps_descriptor", "Average", 0, ps_descriptor_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL};
 
-//consvar_t cv_lua_profile = {"lua_profile", "0").values(CV_Unsigned).onchange(lua_profile_OnChange).description("Show hook timings over an average of N tics");
-consvar_t cv_lua_profile = {"lua_profile", "0", CV_CALL, CV_Unsigned, lua_profile_OnChange, 0, NULL, NULL, 0, 0, NULL};
-
 // only there to better keep track of it globally
 consvar_t cv_director = {"director", "Off", CV_HIDEN, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
 
@@ -570,6 +566,7 @@ const char *netxcmdnames[MAXNETXCMD - 1] =
 	"MODIFYVOTE",
 	"PICKVOTE",
 	"REMOVEPLAYER",
+	"DISCORD",
 	"LUACMD",
 	"LUAVAR"
 };
@@ -937,8 +934,6 @@ void D_RegisterClientCommands(void)
 	CV_RegisterVar(&cv_palette);
 	CV_RegisterVar(&cv_palettenum);
 
-	CV_RegisterVar(&cv_lua_profile);
-
 	// m_menu.c
 	CV_RegisterVar(&cv_chatheight);
 	CV_RegisterVar(&cv_chatwidth);
@@ -1014,9 +1009,17 @@ void D_RegisterClientCommands(void)
 
 		CV_RegisterVar(&cv_usejoystick[i]);
 		CV_RegisterVar(&cv_joyscale[i]);
-		CV_RegisterVar(&cv_rumble[i]);
-		CV_RegisterVar(&cv_rumblestrength[i]);
 		CV_RegisterVar(&cv_gamepadled[i]);
+
+		CV_RegisterVar(&cv_rumble[i]);
+		CV_RegisterVar(&cv_rumble_strength[i]);
+		CV_RegisterVar(&cv_rumble_spinout[i]);
+		CV_RegisterVar(&cv_rumble_sneakerboost[i]);
+		CV_RegisterVar(&cv_rumble_offroad[i]);
+		CV_RegisterVar(&cv_rumble_bananadrag[i]);
+		CV_RegisterVar(&cv_rumble_stairjank[i]);
+		CV_RegisterVar(&cv_rumble_brakedrift[i]);
+		CV_RegisterVar(&cv_rumble_driftcharge[i]);
 	}
 
 	CV_RegisterVar(&cv_gamepadifunfocused);
@@ -1803,7 +1806,7 @@ INT32 D_LookupPlayer(const char *s)
 
 	if ((playernum = atoi(s)))
 	{
-		playernum = max(min(playernum, MAXPLAYERS-1), 0);/* not out of range */
+		playernum = max(min(playernum, MAXPLAYERS-1), 0); /* not out of range */
 		return playernum;
 	}
 
@@ -5688,19 +5691,22 @@ static void Command_SkinSearch(void)
 	size_t i;
 	UINT16 s;
 	UINT16 ic = 0;
-	//skin_t *skininput = &skins[s];
-	for (i = 1; i < COM_Argc(); i++){
-		for( s = 0 ; s <  numallskins ; s++ )
+
+	for (i = 1; i < COM_Argc(); i++)
+	{
+		for (s = 0; s < numskins; s++)
 		{
 			skin_t *skininput = &skins[s];
-			if (strcasestr(skininput->realname,COM_Argv(i)))
+
+			if (strcasestr(skininput->realname, COM_Argv(i)))
 			{
 				ic++;
-				CONS_Printf("%d. %s%s:\x80 %s\n", ic,HU_SkinColorToConsoleColor(skininput->prefcolor),skininput->realname,skininput->name);
+				CONS_Printf("%d. %s%s:\x80 %s\n", ic, HU_SkinColorToConsoleColor(skininput->prefcolor), skininput->realname, skininput->name);
 			}
 		}
 	}
-				CONS_Printf("Total %d skins.\n", ic);
+
+	CONS_Printf("Total %d skins.\n", ic);
 }
 
 /** Sends a color change for the console player, unless that player is moving.

src/d_netcmd.h

@@ -189,8 +189,6 @@ extern consvar_t cv_ps_thinkframe_page;
 extern consvar_t cv_ps_samplesize;
 extern consvar_t cv_ps_descriptor;
 
-extern consvar_t cv_lua_profile;
-
 extern consvar_t cv_director, cv_kartdebugdirector, cv_showdirectorhud;
 
 extern consvar_t cv_showtrackaddon;

src/dedicated/i_system.c

@@ -68,6 +68,12 @@ typedef LPVOID (WINAPI *p_MapViewOfFile) (HANDLE, DWORD, DWORD, DWORD, SIZE_T);
 #include <time.h>
 #if defined (__linux__)
 #include <sys/vfs.h>
+#elif defined(__APPLE__)
+#include <sys/param.h>
+#include <sys/mount.h>
+#include <sys/types.h>
+#include <sys/sysctl.h>
+#include <mach/mach.h>
 #else
 #include <sys/param.h>
 #include <sys/mount.h>
@@ -156,8 +162,7 @@ const char *wadSearchPaths[] = {
 
 /**	\brief WAD file to look for
 */
-#define WADKEYWORD1 "srb2.srb"
-#define WADKEYWORD2 "srb2.wad"
+#define WADKEYWORD "srb2.srb"
 /**	\brief holds wad path
 */
 static char returnWadPath[256];
@@ -520,16 +525,23 @@ void I_OutputMsg(const char *fmt, ...)
 {
 	size_t len;
 	char *txt;
-	va_list  argptr;
+	va_list argptr;
 
-	va_start(argptr,fmt);
+	if (!fmt)
+		return;
+
+	va_start(argptr, fmt);
 	len = vsnprintf(NULL, 0, fmt, argptr);
 	va_end(argptr);
 	if (len == 0)
 		return;
 
-	txt = malloc(len+1);
-	va_start(argptr,fmt);
+	txt = (char*)(malloc(len+1));
+
+	if (!txt)
+		I_Error("I_OutputMsg: Out of memory!\n");
+
+	va_start(argptr, fmt);
 	vsprintf(txt, fmt, argptr);
 	va_end(argptr);
 
@@ -1413,6 +1425,12 @@ static void I_Fork(void)
 }
 #endif/*NEWSIGNALHANDLER*/
 
+int I_OpenURL(const char *url)
+{
+	(void)url;
+	return -1;
+}
+
 INT32 I_StartupSystem(void)
 {
 	I_StartupConsole();
@@ -1802,20 +1820,12 @@ const char *I_ClipboardPaste(void)
 */
 static boolean isWadPathOk(const char *path)
 {
-	char *wad3path = malloc(256);
+	char *wad3path = (char*)(malloc(256));
 
 	if (!wad3path)
 		return false;
 
-	sprintf(wad3path, pandf, path, WADKEYWORD1);
-
-	if (FIL_ReadFileOK(wad3path))
-	{
-		free(wad3path);
-		return true;
-	}
-
-	sprintf(wad3path, pandf, path, WADKEYWORD2);
+	sprintf(wad3path, pandf, path, WADKEYWORD);
 
 	if (FIL_ReadFileOK(wad3path))
 	{
@@ -1832,12 +1842,17 @@ static void pathonly(char *s)
 	size_t j;
 
 	for (j = strlen(s); j != (size_t)-1; j--)
+	{
 		if ((s[j] == '\\') || (s[j] == ':') || (s[j] == '/'))
 		{
-			if (s[j] == ':') s[j+1] = 0;
-			else s[j] = 0;
+			if (s[j] == ':')
+				s[j+1] = 0;
+			else
+				s[j] = 0;
+
 			return;
 		}
+	}
 }
 
 /**	\brief	search for srb2.srb in the given path
@@ -1853,7 +1868,7 @@ static const char *searchWad(const char *searchDir)
 	static char tempsw[256] = "";
 	filestatus_t fstemp;
 
-	strcpy(tempsw, WADKEYWORD1);
+	strcpy(tempsw, WADKEYWORD);
 	fstemp = filesearch(tempsw, searchDir, NULL, true, 20);
 	if (fstemp == FS_FOUND)
 	{
@@ -1974,17 +1989,22 @@ const char *I_LocateWad(void)
 static long get_entry(const char* name, const char* buf)
 {
 	long val;
-	char* hit = strstr(buf, name);
-	if (hit == NULL) {
+	const char* hit = strstr(buf, name);
+
+	if (hit == NULL)
+	{
 		return -1;
 	}
 
 	errno = 0;
 	val = strtol(hit + strlen(name), NULL, 10);
-	if (errno != 0) {
+
+	if (errno != 0)
+	{
 		CONS_Alert(CONS_ERROR, M_GetText("get_entry: strtol() failed: %s\n"), strerror(errno));
 		return -1;
 	}
+
 	return val;
 }
 #endif
@@ -2009,13 +2029,13 @@ size_t I_GetFreeMem(size_t *total)
 		*total = 32 << 20;
 	return 32 << 20;
 #elif defined (_WIN32)
-	MEMORYSTATUS info;
+	MEMORYSTATUSEX info;
 
-	info.dwLength = sizeof (MEMORYSTATUS);
-	GlobalMemoryStatus( &info );
+	info.dwLength = sizeof (MEMORYSTATUSEX);
+	GlobalMemoryStatusEx( &info );
 	if (total)
-		*total = (size_t)info.dwTotalPhys;
-	return (size_t)info.dwAvailPhys;
+		*total = (size_t)info.ullTotalPhys;
+	return (size_t)info.ullAvailPhys;
 #elif defined (__OS2__)
 	UINT32 pr_arena;
 
@@ -2048,7 +2068,7 @@ size_t I_GetFreeMem(size_t *total)
 	{
 		// Error
 		if (total)
-			*total = 0L;
+			*total = 0;
 		return 0;
 	}
 
@@ -2057,12 +2077,12 @@ size_t I_GetFreeMem(size_t *total)
 	{
 		// Error
 		if (total)
-			*total = 0L;
+			*total = 0;
 		return 0;
 	}
 
 	memTag += sizeof (MEMTOTAL);
-	totalKBytes = (size_t)atoi(memTag);
+	totalKBytes = strtoul(memTag, NULL, 10);
 
 	if ((memTag = strstr(buf, MEMAVAILABLE)) == NULL)
 	{
@@ -2076,7 +2096,7 @@ size_t I_GetFreeMem(size_t *total)
 		{
 			// Error
 			if (total)
-				*total = 0L;
+				*total = 0;
 			return 0;
 		}
 		freeKBytes = MemAvailable;
@@ -2084,16 +2104,46 @@ size_t I_GetFreeMem(size_t *total)
 	else
 	{
 		memTag += sizeof (MEMAVAILABLE);
-		freeKBytes = atoi(memTag);
+		freeKBytes = strtoul(memTag, NULL, 10);
 	}
 
 	if (total)
 		*total = totalKBytes << 10;
 	return freeKBytes << 10;
+#elif defined(__APPLE__)
+	/* macOS */
+	mach_port_t host = mach_host_self();
+	kern_return_t kr;
+	mach_msg_type_number_t count;
+	vm_size_t v_page_size;
+	struct vm_statistics64 vm_stats;
+	uint64_t total_mem, free_mem;
+	size_t size;
+
+	size = sizeof(total_mem);
+	if (sysctlbyname("hw.memsize", &total_mem, &size, NULL, 0) < 0)
+		total_mem = 0;
+
+	kr = host_page_size(host, &v_page_size);
+	if (kr != KERN_SUCCESS)
+		v_page_size = 4096;
+
+	count = HOST_VM_INFO64_COUNT;
+	kr = host_statistics64(host, HOST_VM_INFO64, (host_info64_t)&vm_stats, &count);
+	if (kr == KERN_SUCCESS)
+		free_mem = (uint64_t)(vm_stats.free_count + vm_stats.inactive_count) * v_page_size;
+	else
+		free_mem = 0;
+
+	if (total)
+		*total = (size_t)total_mem;
+	return (size_t)free_mem;
 #else
 	// Guess 48 MB.
 	if (total)
+	{
 		*total = 48<<20;
+	}
 	return 48<<20;
 #endif
 }

src/g_demo.c

@@ -716,7 +716,7 @@ void G_WriteGhostTic(mobj_t *ghost, INT32 playernum)
 	if (!(demoflags & DF_GHOST))
 		return; // No ghost data to write.
 
-	if (ghost->player && ghost->player->pflags & PF_NIGHTSMODE && ghost->tracer)
+	if (ghost->player && nightsplayer(ghost->player) && ghost->tracer)
 	{
 		// We're talking about the NiGHTS thing, not the normal platforming thing!
 		ziptic |= GZT_NIGHTS;
@@ -934,7 +934,7 @@ void G_ConsAllGhostTics(void)
 void G_ConsGhostTic(INT32 playernum)
 {
 	UINT8 ziptic;
-	fixed_t px,py,pz,gx,gy,gz;
+	fixed_t px, py, pz, gx, gy, gz;
 	mobj_t *testmo;
 	fixed_t syncleeway;
 	boolean nightsfail = false;
@@ -979,7 +979,7 @@ void G_ConsGhostTic(INT32 playernum)
 
 	if (ziptic & GZT_NIGHTS)
 	{
-		if (!testmo || !testmo->player || !(testmo->player->pflags & PF_NIGHTSMODE) || !testmo->tracer)
+		if (!testmo || !testmo->player || !nightsplayer(testmo->player) || !testmo->tracer)
 			nightsfail = true;
 		else
 			testmo = testmo->tracer;

src/g_game.h

@@ -228,10 +228,11 @@ void G_SaveGameData(boolean force);
 
 void G_SaveGame(UINT32 slot);
 
-#define G_GametypeHasTeams() (G_IsGameType(GT_TEAMMATCH) || G_IsGameType(GT_CTF))
+#define G_RaceGametype()   (G_IsGameType(GT_RACE))
 #define G_BattleGametype() (G_IsGameType(GT_MATCH))
-#define G_RaceGametype() (G_IsGameType(GT_RACE))
-#define G_TagGametype() (G_IsGameType(GT_TAG) || G_IsGameType(GT_HIDEANDSEEK))
+
+#define G_GametypeHasTeams() (UNLIKELY(G_IsGameType(GT_TEAMMATCH) || G_IsGameType(GT_CTF)))
+#define G_TagGametype()      (UNLIKELY(G_IsGameType(GT_TAG) || G_IsGameType(GT_HIDEANDSEEK)))
 
 FUNCINLINE static ATTRINLINE boolean G_IsGameType(int type)
 {

src/g_input.c

@@ -66,13 +66,30 @@ consvar_t cv_rumble[MAXSPLITSCREENPLAYERS] = {
 
 static CV_PossibleValue_t rumblestrength_cons_t[] = {{FRACUNIT/4, "MIN"}, {FRACUNIT*4, "MAX"}, {0, NULL}};
 
-consvar_t cv_rumblestrength[MAXSPLITSCREENPLAYERS] = {
+consvar_t cv_rumble_strength[MAXSPLITSCREENPLAYERS] = {
 	{"rumblestrength",  "1.0", CV_SAVE|CV_FLOAT, rumblestrength_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"rumblestrength2", "1.0", CV_SAVE|CV_FLOAT, rumblestrength_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"rumblestrength3", "1.0", CV_SAVE|CV_FLOAT, rumblestrength_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL},
 	{"rumblestrength4", "1.0", CV_SAVE|CV_FLOAT, rumblestrength_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL}
 };
 
+#define IMPL_RUMBLE_TYPE(type)\
+consvar_t cv_rumble_##type [MAXSPLITSCREENPLAYERS] = {\
+	{"rumble_"  #type, "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},\
+	{"rumble2_" #type, "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},\
+	{"rumble3_" #type, "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL},\
+	{"rumble4_" #type, "On", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL}\
+};
+
+IMPL_RUMBLE_TYPE(spinout);
+IMPL_RUMBLE_TYPE(sneakerboost);
+IMPL_RUMBLE_TYPE(offroad);
+IMPL_RUMBLE_TYPE(bananadrag);
+IMPL_RUMBLE_TYPE(stairjank);
+IMPL_RUMBLE_TYPE(brakedrift);
+IMPL_RUMBLE_TYPE(driftcharge);
+
+
 static CV_PossibleValue_t gamepadled_cons_t[] = {{0, "Off"}, {1, "Skincolor"}, {2, "Mobjcolor"}, {0, NULL}};
 consvar_t cv_gamepadled[MAXSPLITSCREENPLAYERS] = {
 	{"gamepadled",  "Skincolor", CV_SAVE|CV_CALL|CV_NOINIT, gamepadled_cons_t, led_off_handle, 0, NULL, NULL, 0, 0, NULL},
@@ -1036,8 +1053,8 @@ void G_PlayerDeviceRumble(INT32 playernum, UINT16 low_strength, UINT16 high_stre
 	// doesent need to be super precise
 	// but ensure this is within range (0-65535)
 	// placed here so it applies to lua aswell
-	low_strength = (UINT16)min(FixedMul(low_strength, cv_rumblestrength[playernum].value), UINT16_MAX);
-	high_strength = (UINT16)min(FixedMul(high_strength, cv_rumblestrength[playernum].value), UINT16_MAX);
+	low_strength = (UINT16)min(FixedMul(low_strength, cv_rumble_strength[playernum].value), UINT16_MAX);
+	high_strength = (UINT16)min(FixedMul(high_strength, cv_rumble_strength[playernum].value), UINT16_MAX);
 
 	I_GamepadRumble(playernum, low_strength, high_strength, duration);
 }
@@ -1059,7 +1076,7 @@ void G_DeviceRumbleTick(void)
 {
 	UINT8 i;
 
-	if (dedicated || numcontrollers == 0 || gamestate != GS_LEVEL)
+	if (dedicated || numcontrollers == 0 || gamestate != GS_LEVEL || demo.playback)
 	{
 		return;
 	}
@@ -1090,6 +1107,11 @@ void G_DeviceRumbleTick(void)
 
 		const player_t *player = P_GetLocalPlayerForNum(i);
 
+		if (!player)
+		{
+			continue;
+		}
+
 		// allow lua to do some crap for spectators
 		if (player->spectator || !player->mo)
 		{
@@ -1105,17 +1127,20 @@ void G_DeviceRumbleTick(void)
 			continue;
 		}
 
-		if (player->kartstuff[k_spinouttimer])
+		if (cv_rumble_spinout[i].value
+			&& player->kartstuff[k_spinouttimer])
 		{
 			//low = high = FRACUNIT / 6;
 			low = high = FixedMul((RUMBLE_VERYSTRONG), (FixedDiv(player->kartstuff[k_spinouttimer], (3*TICRATE / 2)))); // try do some some kinda fadeout, 3*TICRATE / 2 is the "default" spinout time
 		}
-		else if (player->kartstuff[k_sneakertimer] > (sneakertime-(TICRATE/2)))
+		else if (cv_rumble_sneakerboost[i].value
+			&& (player->kartstuff[k_sneakertimer] > (sneakertime-(TICRATE/2))))
 		{
 			low = high = RUMBLE_STRONG;
 		}
-		else if ((player->kartstuff[k_offroad])
-			&& player->speed != 0
+		else if (cv_rumble_offroad[i].value
+			&& (player->kartstuff[k_offroad])
+			&& (player->speed != 0)
 			&& P_IsObjectOnGround(player->mo))
 		{
 			// weaken this depending on if you got hyu or invinc
@@ -1132,32 +1157,37 @@ void G_DeviceRumbleTick(void)
 				low = high = RUMBLE_MODERATE;
 			}
 		}
-		else if ((player->kartstuff[k_bananadrag] > TICRATE)
-			&& player->speed != 0
+		else if (cv_rumble_bananadrag[i].value
+			&& (player->kartstuff[k_bananadrag] > TICRATE)
+			&& (player->speed != 0)
 			&& P_IsObjectOnGround(player->mo))
 		{
 			if (leveltime & 1) // this is actually funny lel
 				high = RUMBLE_MODERATE;
 		}
-		/*else if ((player->stairjank > 8) // this is kinda cool but prob gets annoying after a while
-			&& player->speed != 0
+		else if (cv_rumble_stairjank[i].value
+			&& (player->stairjank > 8)
+			&& (player->speed != 0)
 			&& P_IsObjectOnGround(player->mo))
 		{
-			low = high = RUMBLE_WEAK;
-		}*/
+			low = high = RUMBLE_VERYWEAK;
+		}
 
-		if (player->kartstuff[k_brakedrift])
+		if (cv_rumble_brakedrift[i].value
+			&& player->kartstuff[k_brakedrift])
 		{
 			high = CLAMP((high + RUMBLE_VERYWEAK), 0, UINT16_MAX);
 		}
 
 		// pulse when gettin new driftlevel
 		// let this come last
-		if (player->kartstuff[k_driftcharge]
+		if (cv_rumble_driftcharge[i].value
+			&& player->kartstuff[k_driftcharge]
 			&& player->driftlevel)
 		{
 			high = CLAMP((high + RUMBLE_VERYWEAK), 0, UINT16_MAX);
 
+			// make it rumble slightly longer the higher your driftlevel!
 			if (player->driftlevel == 2)
 				lenght = 114;
 			else if (player->driftlevel == 3)

src/g_input.h

@@ -100,9 +100,10 @@ typedef enum
 	gc_custom2, // Lua scriptable
 	gc_custom3, // Lua scriptable
 	gc_director,
-	gc_freecam, // Toggle for freecam while ingame
-	gc_camfloat, // alternative button for raising cam
-	gc_camsink, // alternative button for sinking
+	// freecam specific controls
+	gc_freecam,  // Toggle for freecam while ingame
+	gc_camfloat, // alternative button for raising camera
+	gc_camsink,  // alternative button for sinking camera
 	gc_strafeleft,
 	gc_straferight,
 	num_gamecontrols
@@ -112,10 +113,19 @@ typedef enum
 extern consvar_t cv_mousexsens, cv_mouseysens;
 extern consvar_t cv_controlperkey;
 extern consvar_t cv_turnsmooth[MAXSPLITSCREENPLAYERS];
-extern consvar_t cv_rumble[MAXSPLITSCREENPLAYERS];
-extern consvar_t cv_rumblestrength[MAXSPLITSCREENPLAYERS];
+
 extern consvar_t cv_gamepadled[MAXSPLITSCREENPLAYERS];
 
+extern consvar_t cv_rumble[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_strength[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_spinout[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_sneakerboost[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_offroad[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_bananadrag[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_stairjank[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_brakedrift[MAXSPLITSCREENPLAYERS];
+extern consvar_t cv_rumble_driftcharge[MAXSPLITSCREENPLAYERS];
+
 extern consvar_t cv_gamepadifunfocused;
 extern consvar_t cv_gamepadledifunfocused;
 extern consvar_t cv_rumbleifunfocused;

src/hardware/hw_batching.c

@@ -183,6 +183,7 @@ static int comparePolygons(const void *p1, const void *p2)
 
 	UINT32 downloaded1 = poly1->texture ? poly1->texture->downloaded : 0; // there should be a opengl texture name here, usable for comparisons
 	UINT32 downloaded2 = poly2->texture ? poly2->texture->downloaded : 0;
+
 	diff64 = downloaded1 - downloaded2;
 	if (diff64 != 0) return diff64;
 

src/hardware/hw_bsp.c

@@ -12,20 +12,21 @@
 /// \brief convert SRB2 map
 
 #include "../doomdef.h"
-#include "../doomstat.h"
+
 #ifdef HWRENDER
+
 #include "hw_main.h"
 #include "hw_glob.h"
-#include "../r_local.h"
 #include "../z_zone.h"
+
+#ifdef HWR_LOADING_SCREEN
 #include "../console.h"
-#include "../v_video.h"
 #include "../m_menu.h"
-#include "../i_system.h"
-#include "../m_argv.h"
-#include "../i_video.h"
-#include "../w_wad.h"
 #include "../p_setup.h" // levelfadecol
+#include "../i_video.h"
+#endif
+
+//#define DEBUG_HWBSP
 
 // --------------------------------------------------------------------------
 // This is global data for planes rendering
@@ -33,19 +34,20 @@
 
 extrasubsector_t *extrasubsectors = NULL;
 
-// newsubsectors are subsectors without segs, added for the plane polygons
-#define NEWSUBSECTORS 50
-static size_t totsubsectors;
+// extra subsectors are subsectors without segs, added for the plane polygons
+#define NUM_EXTRA_SUBSECTORS 50
+static size_t num_alloc_extra_subsector;
 #ifdef PARANOIA
-size_t addsubsector;
+size_t num_extra_subsector;
 #else
-static size_t addsubsector;
+static size_t num_extra_subsector;
 #endif
 
-typedef struct
-{
+typedef struct {
 	float x, y;
 	float dx, dy;
+	polyvertex_t divpt;
+	float divfrac;
 } fdivline_t;
 
 // when loading the map, this is set to true if portals are found.
@@ -53,7 +55,7 @@ typedef struct
 boolean gl_maphasportals = false;
 
 // Determine on mapload if current map has any Horizonlines present
-// so we can avoid rather hot checks in HWR_Subsector
+// avoids doing a bunch of work during rendering
 boolean gl_maphashorizonlines = false;
 
 // ==========================================================================
@@ -80,26 +82,25 @@ static poly_t *HWR_AllocPoly(INT32 numpts)
 	return p;
 }
 
-/// \todo polygons should be freed in reverse order for efficiency,
+/// TODO: polygons should be freed in reverse order for efficiency,
 /// for now don't free because it doesn't free in reverse order
 static void HWR_FreePoly(poly_t *poly)
 {
 	Z_Free(poly);
 }
 
-// Return interception along bsp line,
+// Return interception along bsp line (partline),
 // with the polygon segment
-//
-static float bspfrac;
-static polyvertex_t *fracdivline(fdivline_t *bsp, polyvertex_t *v1,
-	polyvertex_t *v2)
+
+// Return the division in partline div fields.
+// divfrac = how far along partline vector is crossing pt
+static boolean fracdivline(fdivline_t *partline, polyvertex_t *v1, polyvertex_t *v2)
 {
-	static polyvertex_t pt;
-	double frac;
-	double num;
-	double den;
-	double v1x, v1y, v1dx, v1dy;
-	double v2x, v2y, v2dx, v2dy;
+	double frac1, frac2;
+	double num; // numerator
+	double den; // denominator
+	double v1x, v1y, v1dx, v1dy; // polygon side vector, v1->v2
+	double v3x, v3y, v3dx, v3dy; // partline vector
 
 	// a segment of a polygon
 	v1x  = v1->x;
@@ -108,111 +109,118 @@ static polyvertex_t *fracdivline(fdivline_t *bsp, polyvertex_t *v1,
 	v1dy = v2->y - v1->y;
 
 	// the bsp partition line
-	v2x  = bsp->x;
-	v2y  = bsp->y;
-	v2dx = bsp->dx;
-	v2dy = bsp->dy;
+	v3x  = partline->x;
+	v3y  = partline->y;
+	v3dx = partline->dx;
+	v3dy = partline->dy;
 
-	den = v2dy*v1dx - v2dx*v1dy;
+	den = v3dy*v1dx - v3dx*v1dy;
 
-	if (fabsf((float)den) < 1.0E-36f) // avoid checking exactly for 0.0
-		return NULL;       // parallel
+	if (fabs(den) < 1.0E-36) // avoid check of float for exact 0
+		return false;  // partline and polygon side are effectively parallel
 
 	// first check the frac along the polygon segment,
 	// (do not accept hit with the extensions)
-	num = (v2x - v1x)*v2dy + (v1y - v2y)*v2dx;
-	frac = num / den;
+	num = (v3x - v1x)*v3dy + (v1y - v3y)*v3dx;
+	frac1 = num / den;
 
-	if (frac < 0.0l || frac > 1.0l)
-		return NULL;
+	// 0= cross at v1, 1.0= cross at v2
+	if (frac1 < 0.0 || frac1 > 1.0)  // double
+		return false;  // not within the polygon side
 
 	// now get the frac along the BSP line
 	// which is useful to determine what is left, what is right
-	num = (v2x - v1x)*v1dy + (v1y - v2y)*v1dx;
-	frac = num / den;
-	bspfrac = (float)frac;
+	num = (v3x - v1x)*v1dy + (v1y - v3y)*v1dx;
+	frac2 = num / den;
 
-	// find the interception point along the partition line
-	pt.x = (float)(v2x + v2dx*frac);
-	pt.y = (float)(v2y + v2dy*frac);
+	partline->divfrac = frac2;  // how far along partline vector
 
-	return &pt;
+	// [WDJ] find the interception point along the segment.
+	// It should be slightly more accurate because it is always closer to the
+	// crossing point than arbitrary positions on the partition line.
+	partline->divpt.x = v1x + v1dx*frac1;
+	partline->divpt.y = v1y + v1dy*frac1;
+
+	return true;
 }
 
+// BOOMEDIT.WAD has a vertex error of .21
 #define DIVLINE_VERTEX_DIFF 0.45f
 
 // if two vertice coords have a x and/or y difference
 // of less or equal than 1 FRACUNIT, they are considered the same
 // point. Note: hardcoded value, 1.0f could be anything else.
-static boolean SameVertice (polyvertex_t *p1, polyvertex_t *p2)
+static boolean SameVertex(polyvertex_t *p1, polyvertex_t *p2)
 {
-	if (fabsf( p2->x - p1->x ) > DIVLINE_VERTEX_DIFF)
+	if (fabsf(p2->x - p1->x) > DIVLINE_VERTEX_DIFF)
 		return false;
-	if (fabsf( p2->y - p1->y ) > DIVLINE_VERTEX_DIFF)
+	if (fabsf(p2->y - p1->y) > DIVLINE_VERTEX_DIFF)
 		return false;
 
 	// p1 and p2 are considered the same vertex
 	return true;
 }
 
-
 // split a _CONVEX_ polygon in two convex polygons
 // outputs:
 //   frontpoly : polygon on right side of bsp line
 //   backpoly  : polygon on left side
 //
-static void SplitPoly (fdivline_t *bsp,         //splitting parametric line
-                       poly_t *poly,            //the convex poly we split
-                       poly_t **frontpoly,      //return one poly here
-                       poly_t **backpoly)       //return the other here
+// Called from: WalkBSPNode
+static void SplitPoly (fdivline_t *dlnp,        // splitting parametric line
+                       poly_t *poly,            // the convex poly we split
+                       poly_t **frontpoly,      // return one poly here
+                       poly_t **backpoly)       // return the other here
 {
 	INT32 i, j;
 	polyvertex_t *pv;
 
-	INT32 ps = -1, pe = -1;
-	INT32  nptfront, nptback;
+	INT32 ps, pe; // poly start, end
+	INT32 ps_online, pe_online;
+	INT32 nptfront, nptback;
 	polyvertex_t vs = {};
 	polyvertex_t ve = {};
 	polyvertex_t lastpv = {};
-	float fracs = 0.0f, frace = 0.0f;        //used to tell which poly is on
-	                                         // the front side of the bsp partition line
-	INT32 psonline = 0, peonline = 0;
+	float ps_frac = 0.0f, pe_frac = 0.0f;        // used to tell which poly is on
+	                                             // the front side of the bsp partition line
+	ps = pe = -1;
+    ps_online = pe_online = 0;
 
 	for (i = 0; i < poly->numpts; i++)
 	{
-		j = i + 1;
+		// i, j are one side of the poly
+		j = i+1;
 		if (j == poly->numpts)
-			j = 0;
+			j = 0;  // wrap poly
 
 		// start & end points
-		pv = fracdivline(bsp, &poly->pts[i], &poly->pts[j]);
-
-		if (pv == NULL)
+		if (!fracdivline(dlnp, &poly->pts[i], &poly->pts[j]))
 			continue;
 
+		// have dividing pt
 		if (ps < 0)
 		{
 			// first point
 			ps = i;
-			vs = *pv;
-			fracs = bspfrac;
+			vs = dlnp->divpt;
+			ps_frac = dlnp->divfrac;
 		}
 		else
 		{
-			//the partition line traverse a junction between two segments
+			// the partition line can traverse a junction between two segments
 			// or the two points are so close, they can be considered as one
 			// thus, don't accept, since split 2 must be another vertex
-			if (SameVertice(pv, &lastpv))
+			if (SameVertex(&dlnp->divpt, &lastpv))
 			{
 				if (pe < 0)
 				{
 					ps = i;
-					psonline = 1;
+					ps_online = 1;
 				}
 				else
 				{
 					pe = i;
-					peonline = 1;
+					pe_online = 1;
 				}
 			}
 			else
@@ -220,24 +228,25 @@ static void SplitPoly (fdivline_t *bsp,         //splitting parametric line
 				if (pe < 0)
 				{
 					pe = i;
-					ve = *pv;
-					frace = bspfrac;
+					ve = dlnp->divpt;
+					pe_frac = dlnp->divfrac;
 				}
 				else
 				{
-				// a frac, not same vertice as last one
-				// we already got pt2 so pt 2 is not on the line,
-				// so we probably got back to the start point
-				// which is on the line
-					if (SameVertice(pv, &vs))
-						psonline = 1;
+					// a frac, not same vertice as last one
+					// we already got pt2 so pt 2 is not on the line,
+					// so we probably got back to the start point
+					// which is on the line
+					if (SameVertex(&dlnp->divpt, &vs))
+						ps_online = 1;
+
 					break;
 				}
 			}
 		}
 
 		// remember last point intercept to detect identical points
-		lastpv = *pv;
+		lastpv = dlnp->divpt;
 	}
 
 	// no split: the partition line is either parallel and
@@ -254,28 +263,34 @@ static void SplitPoly (fdivline_t *bsp,         //splitting parametric line
 		// linedefs where each side point the same sector, that is:
 		// the deep water effect with the original Doom
 
-		/// \todo make sure front poly is to front of partition line?
+		//TODO: make sure front poly is to front of partition line?
 
 		*frontpoly = poly;
-		*backpoly = NULL;
+		*backpoly  = NULL;
 		return;
 	}
 
+	//if (ps >= 0 && pe < 0)
 	if (pe < 0)
 	{
 		//I_Error("SplitPoly: only one point for split line (%d %d)", ps, pe);
 		*frontpoly = poly;
-		*backpoly = NULL;
+		*backpoly  = NULL;
 		return;
 	}
 
-	if (UNLIKELY(pe <= ps))
-		I_Error("SplitPoly: invalid splitting line (%d %d)", ps, pe);
+	if (pe <= ps)
+	{
+		//I_Error("SplitPoly: invalid splitting line (%d %d)", ps, pe);
+		*frontpoly = poly;
+		*backpoly  = NULL;
+		return;
+	}
 
-	// number of points on each side, _not_ counting those
-	// that may lie just one the line
-	nptback  = pe - ps - peonline;
-	nptfront = poly->numpts - peonline - psonline - nptback;
+	// Number of points on each side, _not_ counting those
+	// that may lie just on the line.
+	nptback  = pe - ps - pe_online;
+	nptfront = poly->numpts - pe_online - ps_online - nptback;
 
 	if (nptback > 0)
 		*backpoly = HWR_AllocPoly(2 + nptback);
@@ -295,11 +310,9 @@ static void SplitPoly (fdivline_t *bsp,         //splitting parametric line
 		*pv++ = ve;
 		i = pe;
 
-		do
-		{
+		do {
 			if (++i == poly->numpts)
 				i = 0;
-
 			*pv++ = poly->pts[i];
 		} while (i != ps && --nptfront);
 	}
@@ -312,66 +325,79 @@ static void SplitPoly (fdivline_t *bsp,         //splitting parametric line
 		*pv++ = vs;
 		i = ps;
 
-		do
-		{
+		do {
 			if (++i == poly->numpts)
 				i = 0;
-
 			*pv++ = poly->pts[i];
 		} while (i != pe && --nptback);
 	}
 
 	// make sure frontpoly is the one on the 'right' side
 	// of the partition line
-	if (fracs > frace)
+	if (ps_frac > pe_frac)
 	{
-		poly_t *swappoly;
-		swappoly = *backpoly;
-		*backpoly = *frontpoly;
+		poly_t*      swappoly;
+		swappoly   = *backpoly;
+		*backpoly  = *frontpoly;
 		*frontpoly = swappoly;
 	}
 
-	HWR_FreePoly (poly);
+	HWR_FreePoly(poly);
 }
 
+// checks if any line is a portal or horizonline, for optimization
+static inline void CheckForPortalsAndHorizonLines(seg_t *lseg, const line_t *line)
+{
+	// portal check
+	if (!gl_maphasportals && lseg->side == 0 && line->special == PORTALSPECIAL)
+	{
+		// Find the other side!
+		INT32 line2 = P_FindSpecialLineFromTag(PORTALSPECIAL, line->tag, -1);
 
-// use each seg of the poly as a partition line, keep only the
+		if (line == &lines[line2])
+			line2 = P_FindSpecialLineFromTag(PORTALSPECIAL, line->tag, line2);
+
+		if (line2 >= 0) // found it!
+			gl_maphasportals = 1;
+	}
+
+	// horizonline check
+	if (!gl_maphashorizonlines && line->special == HORIZONSPECIAL)
+		gl_maphashorizonlines = true;
+}
+
+// Use each seg of the poly as a partition line, keep only the
 // part of the convex poly to the front of the seg (that is,
-// the part inside the sector), the part behind the seg, is
-// the void space and is cut out
+// the part inside the sector). The part behind the seg, is
+// the void space and is cut out.
 //
-static poly_t *CutOutSubsecPoly(seg_t *lseg, INT32 count, poly_t *poly)
+//  poly : surrounding convex polygon, non-destructive
+//  lseg : array of seg
+//  segcount : number of seg in the array
+// Return frontpoly, which may be new or ptr to poly.
+// Called from: HWR_SubsecPoly
+static poly_t *CutOutSubsecPoly(seg_t *lseg, INT32 segcount, poly_t *poly)
 {
 	INT32 i, j;
+	poly_t* frontpoly = poly;  // default, return same poly
 	polyvertex_t *pv;
-	INT32 nump = 0, ps, pe;
+	INT32 poly_num_pts = 0, ps, pe;
 	polyvertex_t vs = {}, ve = {},
 				 p1 = {}, p2 = {};
-	float fracs = 0.0f;
+	float ps_frac = 0.0f;
+	vertex_t *v1, *v2;
 	fdivline_t cutseg; // x, y, dx, dy as start of node_t struct
-	poly_t *temppoly;
 
 	// for each seg of the subsector
-	for (; count--; lseg++)
+	for (; segcount--; lseg++)
 	{
 		// x, y, dx, dy (like a divline)
 		const line_t *line = lseg->linedef;
 
-		// portal check
-		if (UNLIKELY(!gl_maphasportals && line->special == PORTALSPECIAL && lseg->side == 0))
-		{
-			// Find the other side!
-			INT32 line2 = P_FindSpecialLineFromTag(PORTALSPECIAL, line->tag, -1);
+		if (!line)
+			continue;
 
-			if (line == &lines[line2])
-				line2 = P_FindSpecialLineFromTag(PORTALSPECIAL, line->tag, line2);
-
-			if (line2 >= 0) // found it!
-				gl_maphasportals = 1;
-		}
-
-		if (!gl_maphashorizonlines && line->special == HORIZONSPECIAL)
-			gl_maphashorizonlines = true;
+		CheckForPortalsAndHorizonLines(lseg, line);
 
 		if (line->sidenum[1] != NO_INDEX)
 		{
@@ -385,10 +411,21 @@ static poly_t *CutOutSubsecPoly(seg_t *lseg, INT32 count, poly_t *poly)
 			}
 		}
 
-		p1.x = FIXED_TO_FLOAT(lseg->side ? line->v2->x : line->v1->x);
-		p1.y = FIXED_TO_FLOAT(lseg->side ? line->v2->y : line->v1->y);
-		p2.x = FIXED_TO_FLOAT(lseg->side ? line->v1->x : line->v2->x);
-		p2.y = FIXED_TO_FLOAT(lseg->side ? line->v1->y : line->v2->y);
+		if (lseg->side) // side 1
+		{
+			v1 = line->v2;
+			v2 = line->v1;
+		}
+		else // side 0
+		{
+			v1 = line->v1;
+			v2 = line->v2;
+		}
+
+		p1.x = FixedToFloat(v1->x);
+		p1.y = FixedToFloat(v1->y);
+		p2.x = FixedToFloat(v2->x);
+		p2.y = FixedToFloat(v2->y);
 
 		cutseg.x = p1.x;
 		cutseg.y = p1.y;
@@ -401,125 +438,130 @@ static poly_t *CutOutSubsecPoly(seg_t *lseg, INT32 count, poly_t *poly)
 
 		for (i = 0; i < poly->numpts; i++)
 		{
-			j = i + 1;
+			// i, j are one side of the poly
+			j = i+1;
 			if (j == poly->numpts)
 				j = 0;
 
-			pv = fracdivline(&cutseg, &poly->pts[i], &poly->pts[j]);
-
-			if (pv == NULL)
+			if (!fracdivline(&cutseg, &poly->pts[i], &poly->pts[j]))
 				continue;
 
+			// have dividing pt
 			if (ps < 0)
 			{
 				ps = i;
-				vs = *pv;
-				fracs = bspfrac;
+				vs = cutseg.divpt;
+				ps_frac = cutseg.divfrac;
+				continue;
+			}
+
+			// frac 1 on previous segment,
+			//     0 on the next,
+			// the split line goes through one of the convex poly
+			// vertices, happens quite often since the convex
+			// poly is already adjacent to the subsector segs
+			// on most borders
+			if (SameVertex(&cutseg.divpt, &vs))
+				continue;
+
+			if (ps_frac <= cutseg.divfrac)
+			{
+				poly_num_pts = 2 + poly->numpts - (i-ps);
+				pe = ps;
+				ps = i;
+				ve = cutseg.divpt;
 			}
 			else
 			{
-				//frac 1 on previous segment,
-				//     0 on the next,
-				//the split line goes through one of the convex poly
-				// vertices, happens quite often since the convex
-				// poly is already adjacent to the subsector segs
-				// on most borders
-				if (SameVertice(pv, &vs))
-					continue;
-
-				if (fracs <= bspfrac)
-				{
-					nump = 2 + poly->numpts - (i-ps);
-					pe = ps;
-					ps = i;
-					ve = *pv;
-				}
-				else
-				{
-					nump = 2 + (i-ps);
-					pe = i;
-					ve = vs;
-					vs = *pv;
-				}
-
-				//found 2nd point
-				break;
+				poly_num_pts = 2 + (i-ps);
+				pe = i;
+				ve = vs;
+				vs = cutseg.divpt;
 			}
+
+			// found 2nd point
+			break;
 		}
 
 		// there was a split
 		if (ps >= 0)
 		{
-			//need 2 points
+			// need 2 points
 			if (pe >= 0)
 			{
 				// generate FRONT poly
-				temppoly = HWR_AllocPoly(nump);
+				frontpoly = HWR_AllocPoly(poly_num_pts);
 
-				pv = temppoly->pts;
+				pv = frontpoly->pts;
 				*pv++ = vs;
 				*pv++ = ve;
 
-				do
-				{
-					if (++ps == poly->numpts)
+				do {
+					if (++ps == poly->numpts)  // poly wrap
 						ps = 0;
 					*pv++ = poly->pts[ps];
 				} while (ps != pe);
 
 				HWR_FreePoly(poly);
-				poly = temppoly;
+				poly = frontpoly;
 			}
 #ifdef DEBUG_HWBSP
-			// hmmm... maybe we should NOT accept this, but this happens
-			// only when the cut is not needed it seems (when the cut
-			// line is aligned to one of the borders of the poly, and
-			// only some times..)
 			else
 			{
+				// hmmm... maybe we should NOT accept this, but this happens
+				// only when the cut is not needed it seems (when the cut
+				// line is aligned to one of the borders of the poly, and
+				// only some times..)
+				// [WDJ] This happens often (27 times in Doom2 map01).
 				skipcut++;
-				I_Error("CutOutPoly: only one point for split line (%d %d) %d", ps, pe, debugpos);
+				//I_Error("CutOutPoly: only one point for split line (%d %d) %d", ps, pe, debugpos);
 			}
 #endif
 		}
 	}
-	return poly;
+
+	return frontpoly;
 }
 
 // At this point, the poly should be convex and the exact
-// layout of the subsector, it is not always the case,
+// layout of the subsector. It is not always the case,
 // so continue to cut off the poly into smaller parts with
 // each seg of the subsector.
 //
-static inline void HWR_SubsecPoly(INT32 num, poly_t *poly)
+//  ssindex : subsec index, 0..(numsubsectors-1)
+//  poly : surrounding convex polygon, non-destructive
+// Called from WalkBSPNode
+static inline void HWR_SubsecPoly(INT32 ssindex, poly_t *poly)
 {
-	INT16 count;
+	INT16 segcount;
 	subsector_t *sub;
 	seg_t *lseg;
 
-	sub = &subsectors[num];
-	count = sub->numlines;
+	sub = &subsectors[ssindex];
+	segcount = sub->numlines;
 	lseg = &segs[sub->firstline];
 
 	if (poly)
 	{
-		poly = CutOutSubsecPoly(lseg,count,poly);
+		poly = CutOutSubsecPoly(lseg, segcount, poly);
 #ifdef DEBUG_HWBSP
 		totalsubsecpolys++;
 #endif
 		//extra data for this subsector
-		extrasubsectors[num].planepoly = poly;
+		extrasubsectors[ssindex].planepoly = poly;
 	}
 }
 
-// the bsp divline have not enouth presition
-// search for the segs source of this divline
-static inline void SearchDivline(node_t *bsp, fdivline_t *divline)
+// The bsp divline does not have enough precision.
+// Search for the segs source of this divline.
+static inline void SetDivline(node_t *bsp, fdivline_t *divline)
 {
-	divline->x  = FIXED_TO_FLOAT(bsp->x);
-	divline->y  = FIXED_TO_FLOAT(bsp->y);
-	divline->dx = FIXED_TO_FLOAT(bsp->dx);
-	divline->dy = FIXED_TO_FLOAT(bsp->dy);
+	// MAR - If you don't use the same partition line that the BSP uses,
+	// the front/back polys won't match the subsectors in the BSP!
+	divline->x  = FixedToFloat(bsp->x);
+	divline->y  = FixedToFloat(bsp->y);
+	divline->dx = FixedToFloat(bsp->dx);
+	divline->dy = FixedToFloat(bsp->dy);
 }
 
 //Hurdler: implement a loading status
@@ -532,20 +574,25 @@ static void loading_status(void)
 	char s[16];
 	int x, y;
 
+	/*if (g_reloadinggamestate)
+	{
+		return;
+	}*/
+
 	I_OsPolling();
 	CON_Drawer();
 	sprintf(s, "%d%%", (++ls_percent)<<1);
 	x = BASEVIDWIDTH/2;
 	y = BASEVIDHEIGHT/2;
-	V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31); // Black background to match fade in effect
+	V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, levelfadecol); // Black background to match fade in effect
 	//V_DrawPatchFill(srb2back); // SRB2 background, ehhh too bright.
 	M_DrawTextBox(x-58, y-8, 13, 1);
 	V_DrawString(x-50, y, V_YELLOWMAP, "Loading...");
 	V_DrawRightAlignedString(x+50, y, V_YELLOWMAP, s);
 
 	// Is this really necessary at this point..?
-	V_DrawCenteredString(BASEVIDWIDTH/2, 40, V_YELLOWMAP, "OPENGL MODE IS INCOMPLETE AND MAY");
-	V_DrawCenteredString(BASEVIDWIDTH/2, 50, V_YELLOWMAP, "NOT DISPLAY SOME SURFACES.");
+	V_DrawCenteredString(BASEVIDWIDTH/2, 40, V_YELLOWMAP, "OPENGL MODE IS INCOMPLETE AND SOME");
+	V_DrawCenteredString(BASEVIDWIDTH/2, 50, V_YELLOWMAP, "VISUAL FEATURES ARE MISSING/BROKEN.");
 	V_DrawCenteredString(BASEVIDWIDTH/2, 70, V_YELLOWMAP, "USE AT SONIC'S RISK.");
 
 	I_UpdateNoVsync();
@@ -576,14 +623,14 @@ static void WalkBSPNode(INT32 bspnum, poly_t *poly, UINT16 *leafnode, fixed_t *b
 			{
 				CONS_Debug(DBG_RENDER, "Adding a new subsector\n");
 
-				if (UNLIKELY(addsubsector == numsubsectors + NEWSUBSECTORS))
-					I_Error("WalkBSPNode: not enough addsubsectors\n");
-				else if (UNLIKELY(addsubsector > 0x7fff))
-					I_Error("WalkBSPNode: addsubsector > 0x7fff\n");
+				if (num_extra_subsector == numsubsectors + NUM_EXTRA_SUBSECTORS)
+					I_Error("WalkBSPNode: not enough num_extra_subsectors\n");
+				else if (num_extra_subsector > 0x7fff)
+					I_Error("WalkBSPNode: num_extra_subsector > 0x7fff\n");
 
-				*leafnode = (UINT16)((UINT16)addsubsector | NF_SUBSECTOR);
-				extrasubsectors[addsubsector].planepoly = poly;
-				addsubsector++;
+				*leafnode = (UINT16)((UINT16)num_extra_subsector | NF_SUBSECTOR);
+				extrasubsectors[num_extra_subsector].planepoly = poly;
+				num_extra_subsector++;
 			}
 
 			//add subsectors without segs here?
@@ -593,8 +640,8 @@ static void WalkBSPNode(INT32 bspnum, poly_t *poly, UINT16 *leafnode, fixed_t *b
 		{
 			HWR_SubsecPoly(bspnum & ~NF_SUBSECTOR, poly);
 
-			//Hurdler: implement a loading status
 #ifdef HWR_LOADING_SCREEN
+			//Hurdler: implement a loading status
 			if (ls_count-- <= 0)
 			{
 				ls_count = numsubsectors/50;
@@ -613,7 +660,7 @@ static void WalkBSPNode(INT32 bspnum, poly_t *poly, UINT16 *leafnode, fixed_t *b
 	}
 
 	bsp = &nodes[bspnum];
-	SearchDivline(bsp, &fdivline);
+	SetDivline(bsp, &fdivline);
 	SplitPoly(&fdivline, poly, &frontpoly, &backpoly);
 	poly = NULL;
 
@@ -656,12 +703,12 @@ void HWR_FreeExtraSubsectors(void)
 	extrasubsectors = NULL;
 }
 
-#define MAXDIST 1.5f
+#define MAXDIST (1.5f)
 // BP: can't move vertex: DON'T change polygon geometry! (convex)
 //#define MOVEVERTEX
 
 // Is vertex va  within the seg v1, v2
-static boolean PointInSeg(polyvertex_t *va,polyvertex_t *v1,polyvertex_t *v2)
+static boolean PointInSeg(polyvertex_t *va, polyvertex_t *v1, polyvertex_t *v2)
 {
 	register float ax, ay, bx, by, cx, cy, d, norm;
 
@@ -736,8 +783,8 @@ static boolean PointInSeg(polyvertex_t *va,polyvertex_t *v1,polyvertex_t *v2)
 	if (cx*cx+cy*cy <= MAXDIST*MAXDIST)
 	{
 		// ajust a little the point position
-		a->x = ax*d+v1->x;
-		a->y = ay*d+v1->y;
+		va->x = ax*d+v1->x;
+		va->y = ay*d+v1->y;
 		// anyway the correction is not enouth
 		return true;
 	}
@@ -749,10 +796,10 @@ static boolean PointInSeg(polyvertex_t *va,polyvertex_t *v1,polyvertex_t *v2)
 
 static INT32 numsplitpoly;
 
-static void SearchSegInBSP(INT32 bspnum,polyvertex_t *p,poly_t *poly)
+static void SearchSegInBSP(INT32 bspnum, polyvertex_t *p, poly_t *poly)
 {
 	poly_t  *q;
-	INT32 j,k;
+	INT32 j, k;
 
 	if (bspnum & NF_SUBSECTOR)
 	{
@@ -772,12 +819,12 @@ static void SearchSegInBSP(INT32 bspnum,polyvertex_t *p,poly_t *poly)
 				if (k == numpts)
 					k = 0;
 
-				if (!SameVertice(p, &q->pts[j])
-					&& !SameVertice(p, &q->pts[k])
-					&& PointInSeg(p, &q->pts[j], &q->pts[k]))
+				if (!SameVertex(p, &q->pts[j]) &&
+					!SameVertex(p, &q->pts[k]) &&
+					 PointInSeg(p, &q->pts[j], &q->pts[k]))
 				{
-					poly_t *newpoly = HWR_AllocPoly(numpts+1);
 					INT32 n;
+					poly_t *newpoly = HWR_AllocPoly(numpts+1);
 
 					for (n = 0; n <= j; n++)
 						newpoly->pts[n] = q->pts[n];
@@ -798,16 +845,17 @@ static void SearchSegInBSP(INT32 bspnum,polyvertex_t *p,poly_t *poly)
 		return;
 	}
 
-	if ((FIXED_TO_FLOAT(nodes[bspnum].bbox[0][BOXBOTTOM])-MAXDIST <= p->y) &&
-		(FIXED_TO_FLOAT(nodes[bspnum].bbox[0][BOXTOP   ])+MAXDIST >= p->y) &&
-		(FIXED_TO_FLOAT(nodes[bspnum].bbox[0][BOXLEFT  ])-MAXDIST <= p->x) &&
-		(FIXED_TO_FLOAT(nodes[bspnum].bbox[0][BOXRIGHT ])+MAXDIST >= p->x))
+	// Not a subsector, visit left and right children.
+	if ((FixedToFloat(nodes[bspnum].bbox[0][BOXBOTTOM])-MAXDIST <= p->y) &&
+		(FixedToFloat(nodes[bspnum].bbox[0][BOXTOP   ])+MAXDIST >= p->y) &&
+		(FixedToFloat(nodes[bspnum].bbox[0][BOXLEFT  ])-MAXDIST <= p->x) &&
+		(FixedToFloat(nodes[bspnum].bbox[0][BOXRIGHT ])+MAXDIST >= p->x))
 		SearchSegInBSP(nodes[bspnum].children[0], p, poly);
 
-	if ((FIXED_TO_FLOAT(nodes[bspnum].bbox[1][BOXBOTTOM])-MAXDIST <= p->y) &&
-		(FIXED_TO_FLOAT(nodes[bspnum].bbox[1][BOXTOP   ])+MAXDIST >= p->y) &&
-		(FIXED_TO_FLOAT(nodes[bspnum].bbox[1][BOXLEFT  ])-MAXDIST <= p->x) &&
-		(FIXED_TO_FLOAT(nodes[bspnum].bbox[1][BOXRIGHT ])+MAXDIST >= p->x))
+	if ((FixedToFloat(nodes[bspnum].bbox[1][BOXBOTTOM])-MAXDIST <= p->y) &&
+		(FixedToFloat(nodes[bspnum].bbox[1][BOXTOP   ])+MAXDIST >= p->y) &&
+		(FixedToFloat(nodes[bspnum].bbox[1][BOXLEFT  ])-MAXDIST <= p->x) &&
+		(FixedToFloat(nodes[bspnum].bbox[1][BOXRIGHT ])+MAXDIST >= p->x))
 		SearchSegInBSP(nodes[bspnum].children[1], p, poly);
 }
 
@@ -816,38 +864,43 @@ static void SearchSegInBSP(INT32 bspnum,polyvertex_t *p,poly_t *poly)
 // but we must use a different structure : polygone pointing on segs
 // segs pointing on polygone and on vertex (too mush complicated, well not
 // realy but i am soo lasy), the methode discibed is also better for segs presition
-static INT32 SolveTProblem(void)
+static void SolveTProblem(void)
 {
 	poly_t *p;
-	INT32 i;
-	size_t l;
+	INT32 i, numpts;
+	size_t ssnum;
 
-	if (cv_glsolvetjoin.value == 0)
-		return 0;
+	if (!cv_glsolvetjoin.value)
+		return;
 
 	CONS_Debug(DBG_RENDER, "Solving T-joins. This may take a while. Please wait...\n");
 
+#ifdef HWR_LOADING_SCREEN
+	CON_Drawer(); //let the user know what we are doing
+	I_FinishUpdate(); // page flip or blit buffer
+#endif
+
 	numsplitpoly = 0;
 
-	for (l = 0; l < addsubsector; l++)
+	for (ssnum = 0; ssnum < num_extra_subsector; ssnum++)
 	{
-		p = extrasubsectors[l].planepoly;
+		p = extrasubsectors[ssnum].planepoly;
 
-		if (!p)
+		if (!p || p->numpts == 0)
 			continue;
 
-		for (i = 0; i < p->numpts; i++)
+		numpts = p->numpts;
+
+		for (i = 0; i < numpts; i++)
 			SearchSegInBSP((INT32)numnodes-1, &p->pts[i], p);
 	}
 
 #ifdef DEBUG_HWBSP
 	CONS_Debug(DBG_RENDER, "numsplitpoly %d\n", numsplitpoly);
+	CONS_Debug(DBG_RENDER, "%d point divides a polygon line\n", numsplitpoly);
 #endif
-
-	return numsplitpoly;
 }
 
-
 // call this routine after the BSP of a Doom wad file is loaded,
 // and it will generate all the convex polys for the hardware renderer
 void HWR_CreatePlanePolygons(INT32 bspnum)
@@ -865,7 +918,7 @@ void HWR_CreatePlanePolygons(INT32 bspnum)
 #endif
 
 	// reset the portal and horizonline flag
-	gl_maphasportals = gl_maphashorizonlines = 0;
+	gl_maphasportals = gl_maphashorizonlines = false;
 
 	// find min/max boundaries of map
 #ifdef DEBUG_HWBSP
@@ -882,39 +935,35 @@ void HWR_CreatePlanePolygons(INT32 bspnum)
 	HWR_FreeExtraSubsectors();
 
 	// allocate extra data for each subsector present in map
-	totsubsectors = numsubsectors + NEWSUBSECTORS;
-	extrasubsectors = calloc(totsubsectors, sizeof(*extrasubsectors));
+	num_alloc_extra_subsector = numsubsectors + NUM_EXTRA_SUBSECTORS;
+	extrasubsectors = (extrasubsector_t*)calloc(num_alloc_extra_subsector, sizeof(*extrasubsectors));
 	if (UNLIKELY(!extrasubsectors))
-		I_Error("couldn't malloc extrasubsectors totsubsectors %s\n", sizeu1(totsubsectors));
+		I_Error("couldn't malloc extrasubsectors num_alloc_extra_subsector %s\n", sizeu1(num_alloc_extra_subsector));
 
 	// number of the first new subsector that might be added
-	addsubsector = numsubsectors;
+	num_extra_subsector = numsubsectors;
 
 	// construct the initial convex poly that encloses the full map
 	rootp = HWR_AllocPoly(4);
 	rootpv = rootp->pts;
 
-	rootpv->x = FIXED_TO_FLOAT(rootbbox[BOXLEFT  ]);
-	rootpv->y = FIXED_TO_FLOAT(rootbbox[BOXBOTTOM]);  //lr
+	// clockwise polygon
+	rootpv->x = FixedToFloat(rootbbox[BOXLEFT  ]);
+	rootpv->y = FixedToFloat(rootbbox[BOXBOTTOM]);  //lr
 	rootpv++;
-	rootpv->x = FIXED_TO_FLOAT(rootbbox[BOXLEFT  ]);
-	rootpv->y = FIXED_TO_FLOAT(rootbbox[BOXTOP   ]);  //ur
+	rootpv->x = FixedToFloat(rootbbox[BOXLEFT  ]);
+	rootpv->y = FixedToFloat(rootbbox[BOXTOP   ]);  //ur
 	rootpv++;
-	rootpv->x = FIXED_TO_FLOAT(rootbbox[BOXRIGHT ]);
-	rootpv->y = FIXED_TO_FLOAT(rootbbox[BOXTOP   ]);  //ul
+	rootpv->x = FixedToFloat(rootbbox[BOXRIGHT ]);
+	rootpv->y = FixedToFloat(rootbbox[BOXTOP   ]);  //ul
 	rootpv++;
-	rootpv->x = FIXED_TO_FLOAT(rootbbox[BOXRIGHT ]);
-	rootpv->y = FIXED_TO_FLOAT(rootbbox[BOXBOTTOM]);  //ll
+	rootpv->x = FixedToFloat(rootbbox[BOXRIGHT ]);
+	rootpv->y = FixedToFloat(rootbbox[BOXBOTTOM]);  //ll
 	rootpv++;
 
 	WalkBSPNode(bspnum, rootp, NULL, rootbbox);
 
-#ifdef DEBUG_HWBSP
-	i = SolveTProblem();
-	CONS_Debug(DBG_RENDER, "%d point divides a polygon line\n",i);
-#else
 	SolveTProblem();
-#endif
 
 #ifdef DEBUG_HWBSP
 	//debug debug..

src/hardware/hw_defs.h

@@ -96,7 +96,6 @@ typedef struct
 typedef struct
 {
 	float x, y, z;
-	fixed_t x2, y2, z2;
 } polyvertex_t;
 
 // a convex 'plane' polygon, clockwise order

src/hardware/hw_glob.h

@@ -54,7 +54,7 @@ void HWR_ObjectLightLevelPost(gl_vissprite_t *spr, const sector_t *sector, INT32
 // --------
 extern extrasubsector_t *extrasubsectors;
 #ifdef PARANOIA
-extern size_t addsubsector;
+extern size_t num_extra_subsector;
 #endif
 
 void HWR_FreeExtraSubsectors(void);

src/hardware/hw_main.cpp

@@ -84,11 +84,6 @@ float gl_viewsin = 0.0f, gl_viewcos = 0.0f;
 static float gl_viewludsin, gl_viewludcos;
 static angle_t gl_aimingangle;
 
-static float yaw = 0.0f;
-static float inv_yaw = 0.0f;
-static float cos_inv_yaw = 0.0f;
-static float sin_inv_yaw = 0.0f;
-
 static constexpr float deg2radians = (M_PIf / 180.0f);
 
 seg_t    *gl_curline = NULL;
@@ -2784,9 +2779,9 @@ static void HWR_Subsector(size_t num)
 	ffloor_t *rover;
 
 #ifdef PARANOIA // no risk while developing, enough debugging nights!
-	if (num >= addsubsector)
+	if (num >= num_extra_subsector)
 		I_Error("HWR_Subsector: ss %s with numss = %s, addss = %s\n",
-			sizeu1(num), sizeu2(numsubsectors), sizeu3(addsubsector));
+			sizeu1(num), sizeu2(numsubsectors), sizeu3(num_extra_subsector));
 #endif
 
 	if (num < numsubsectors)
@@ -3488,6 +3483,8 @@ static void HWR_SplitSprite(gl_vissprite_t *spr, const boolean papersprite)
 	fixed_t v1x, v1y, v2x, v2y;
 	INT32 shader = SHADER_NONE;
 
+	const boolean billboarding = (cv_glspritebillboarding.value && !cv_glshearing.value && !papersprite);
+
 	gpatch = spr->gpatch;
 
 	// cache the patch in the graphics card memory
@@ -3685,7 +3682,7 @@ static void HWR_SplitSprite(gl_vissprite_t *spr, const boolean papersprite)
 		wallVerts[1].y = endbot;
 
 		// The x and y only need to be adjusted in the case that it's not a papersprite
-		if (cv_glspritebillboarding.value && !cv_glshearing.value && !papersprite)
+		if (billboarding)
 		{
 			// Get the x and z of the vertices so billboarding draws correctly
 			realheight = realbot - realtop;
@@ -3707,7 +3704,7 @@ static void HWR_SplitSprite(gl_vissprite_t *spr, const boolean papersprite)
 			wallVerts[1].z = baseWallVerts[2].z + (baseWallVerts[2].z - baseWallVerts[1].z) * heightmult;
 		}
 
-		HWR_Lighting(&Surf, lightlevel, colormap, P_SectorUsesDirectionalLighting(sector) && !(sprmo->frame & FF_FULLBRIGHT));
+		HWR_Lighting(&Surf, lightlevel, colormap, P_SectorUsesDirectionalLighting(sector) && !R_ThingIsFullBright(sprmo));
 
 		Surf.PolyColor.s.alpha = alpha;
 
@@ -3761,7 +3758,7 @@ static void HWR_DrawSprite(gl_vissprite_t *spr)
 	if (!sprmo->subsector)
 		return;
 
-	const boolean papersprite = (sprmo->frame & FF_PAPERSPRITE);
+	const boolean papersprite = R_ThingIsPaperSprite(sprmo);
 	const sector_t *sector = sprmo->subsector->sector;
 
 	if (sector->numlights)
@@ -3920,7 +3917,7 @@ static void HWR_DrawPrecipitationSprite(gl_vissprite_t *spr)
 
 	INT32 shader = SHADER_NONE;
 
-	const precipmobj_t *sprmo = spr->precip;
+	precipmobj_t *sprmo = spr->precip;
 
 	if (!sprmo->subsector)
 		return;
@@ -3966,11 +3963,10 @@ static void HWR_DrawPrecipitationSprite(gl_vissprite_t *spr)
 
 	if (sector->numlights)
 	{
-		INT32 light;
+		// Always use the light at the top instead of whatever I was doing before
+		INT32 light = R_GetPlaneLight(sector, sprmo->z, false); // sprmo->z + sprmo->height
 
-		light = R_GetPlaneLight(sector, sprmo->z, false); // Always use the light at the top instead of whatever I was doing before
-
-		if (!(sprmo->frame & FF_FULLBRIGHT))
+		if (!R_PrecipThingIsFullBright(sprmo))
 			lightlevel = static_cast<INT32>(*sector->lightlist[light].lightlevel);
 
 		if (sector->lightlist[light].extra_colormap)
@@ -3978,7 +3974,7 @@ static void HWR_DrawPrecipitationSprite(gl_vissprite_t *spr)
 	}
 	else
 	{
-		if (!(sprmo->frame & FF_FULLBRIGHT))
+		if (!R_PrecipThingIsFullBright(sprmo))
 			lightlevel = static_cast<INT32>(sector->lightlevel);
 
 		if (sector->extra_colormap)
@@ -4562,7 +4558,7 @@ static void HWR_ProjectSprite(mobj_t *thing)
 			return;
 	}
 
-	const boolean papersprite = (thing->frame & FF_PAPERSPRITE);
+	const boolean papersprite = R_ThingIsPaperSprite(thing);
 
 	// transform the origin point
 	tr_x = FixedToFloat(interp.x);
@@ -4576,8 +4572,8 @@ static void HWR_ProjectSprite(mobj_t *thing)
 		return;
 
 	const boolean mirrored = thing->mirrored;
-	const boolean vflip    = (thing->eflags & MFE_VERTICALFLIP);
-	const boolean hflip    = (!(thing->frame & FF_HORIZONTALFLIP) != !mirrored);
+	const boolean vflip    = R_ThingVerticallyFlipped(thing);
+	const boolean hflip    = (!R_ThingHorizontallyFlipped(thing) != !mirrored);
 
 	// decide which patch to use for sprite relative to player
 #ifdef RANGECHECK
@@ -4764,9 +4760,9 @@ static void HWR_ProjectSprite(mobj_t *thing)
 
 	// if the sprite is out of our view, dont need to draw it X)
 	if (!gld_SphereInFrustum(
-							(FixedToFloat(interp.x)) + cos_inv_yaw * (x1 + x2) / 2.0f,
+							(FixedToFloat(interp.x)) + gl_viewsin * (x1 + x2) / 2.0f,
 							 FixedToFloat(interp.z) + (y1 + y2) / 2.0f,
-							 FixedToFloat(interp.y) - sin_inv_yaw * (x1 + x2) / 2.0f,
+							 FixedToFloat(interp.y) - (-gl_viewcos) * (x1 + x2) / 2.0f,
 							 //1.5 == sqrt(2) + small delta for MF_FOREGROUND
 							 std::max<float>(FixedToFloat(spr_width)  * spritexscale,
 											 FixedToFloat(spr_height) * spriteyscale) / 2.0f * 1.5f))
@@ -4984,9 +4980,9 @@ static void HWR_ProjectPrecipitationSprite(precipmobj_t *thing)
 	y2 *= thing_scale;
 
 	if (!gld_SphereInFrustum(
-							(FixedToFloat(interp.x)) + cos_inv_yaw * (x1 + x2) / 2.0f,
+							(FixedToFloat(interp.x)) + gl_viewsin * (x1 + x2) / 2.0f,
 							 FixedToFloat(interp.z) + (y1 + y2) / 2.0f,
-							 FixedToFloat(interp.y) - sin_inv_yaw * (x1 + x2) / 2.0f,
+							 FixedToFloat(interp.y) - (-gl_viewcos) * (x1 + x2) / 2.0f,
 							 //1.5 == sqrt(2) + small delta for MF_FOREGROUND
 							 std::max<float>(FixedToFloat(spr_width)  * thing_scale,
 											 FixedToFloat(spr_height) * thing_scale) / 2.0f * 1.5f))
@@ -5116,24 +5112,22 @@ void HWR_BuildSkyDome(void)
 	int c, r;
 	signed char yflip;
 	static constexpr int row_count = 4;
-	int col_count = 4;
+	static constexpr int col_count = (4 * 16);
 	float delta;
 
 	gl_sky_t *sky = &gl_sky;
 	gl_skyvertex_t *vertex_p;
 	const texture_t *texture = textures[texturetranslation[skytexture]];
 
-	col_count *= 16;
-
 	if ((sky->columns != col_count) || (sky->rows != row_count))
 		HWR_ClearSkyDome();
 
 	sky->columns = col_count;
 	sky->rows = row_count;
-	sky->vertex_count = 2 * sky->rows * (sky->columns * 2 + 2) + sky->columns * 2;
+	sky->vertex_count = 2 * row_count * (col_count * 2 + 2) + col_count * 2;
 
 	if (!sky->loops)
-		sky->loops = static_cast<gl_skyloopdef_t*>(malloc((sky->rows * 2 + 2) * sizeof(sky->loops[0])));
+		sky->loops = static_cast<gl_skyloopdef_t*>(malloc((row_count * 2 + 2) * sizeof(sky->loops[0])));
 
 	// create vertex array
 	if (!sky->data)
@@ -5397,12 +5391,6 @@ void HWR_SetTransform(float fpov)
 	HWR_SetTransformAiming(&atransform);
 	atransform.angley = static_cast<float>(viewangle >> ANGLETOFINESHIFT)*(FINEDEGREE);
 
-	yaw = 270.0f - atransform.angley;
-	inv_yaw = 180.0f - yaw;
-	const float inv_yaw_radians = inv_yaw * deg2radians;
-	cos_inv_yaw = cosf(inv_yaw_radians);
-	sin_inv_yaw = sinf(inv_yaw_radians);
-
 	// only needed for sprite billboarding
 	if (cv_glspritebillboarding.value && !cv_glshearing.value)
 	{
@@ -5465,6 +5453,8 @@ static void HWR_RenderViewpoint(gl_portal_t *rootportal, int stencil_level, bool
 {
 	gl_portallist_t portallist;
 
+	const boolean wireframe = HWR_IsWireframeMode();
+
 	player_t *viewplayer = &players[displayplayers[viewssnum]];
 	const float fpov = FixedToFloat(R_GetPlayerFov(viewplayer));
 
@@ -5525,7 +5515,7 @@ static void HWR_RenderViewpoint(gl_portal_t *rootportal, int stencil_level, bool
 		}
 	}
 
-	if (HWR_IsWireframeMode())
+	if (wireframe)
 		GL_SetSpecialState(HWD_SET_WIREFRAME, 1);
 
 	// FIXME: perfstats does not account for portal rendering!
@@ -5540,7 +5530,8 @@ static void HWR_RenderViewpoint(gl_portal_t *rootportal, int stencil_level, bool
 
 	if constexpr (Type == RenderViewpointType::kPortal)
 	{
-		gl_collect_skywalls = (allow_portals && !rootportal && portallist.base && (!skyboxmo[0] || !cv_skybox.value)); // if portals have been drawn in the main view, then render skywalls differently
+		// if portals have been drawn in the main view, then render skywalls differently
+		gl_collect_skywalls = (allow_portals && !rootportal && portallist.base && (!skyboxmo[0] || !cv_skybox.value));
 
 		// HAYA: Save the old portal state, and turn portals off while normally rendering the BSP tree.
 		// This fixes specific effects not working, such as horizon lines.
@@ -5610,7 +5601,7 @@ static void HWR_RenderViewpoint(gl_portal_t *rootportal, int stencil_level, bool
 
 	HWR_RenderDrawNodes();
 
-	if (HWR_IsWireframeMode())
+	if (wireframe)
 		GL_SetSpecialState(HWD_SET_WIREFRAME, 0);
 
 	HWR_FreePortalList(portallist); // always call this just in case
@@ -5999,6 +5990,10 @@ static void HWR_RenderWall(FOutVector *wallVerts, FSurfaceInfo *pSurf, FBITFIELD
 
 static void HWR_DoPostProcessor(void)
 {
+	// no flashes or screen waving if we want less vfx!
+	if (cv_reducevfx.value)
+		return;
+
 	// Armageddon Blast Flash!
 	// Could this even be considered postprocessor?
 	if (!HWR_ShouldUsePaletteRendering())
@@ -6038,7 +6033,7 @@ static void HWR_DoPostProcessor(void)
 		return;
 
 	// Not supported in splitscreen - someone want to add support?
-	if (splitscreen || cv_reducevfx.value)
+	if (splitscreen)
 		return;
 
 	//UINT8 viewnum = R_GetViewNumber();
@@ -6096,44 +6091,60 @@ static void HWR_DoPostProcessor(void)
 	// Flipping of the screen isn't done here anymore
 }
 
-void HWR_DoWipe(UINT8 wipenum, UINT8 scrnnum)
+//
+// wipes
+//
+static lumpnum_t wipelumpnum;
+
+// puts wipe lumpname in wipename[9]
+static boolean HWR_WipeCheck(UINT8 wipenum, UINT8 scrnnum)
 {
 	static char lumpname[9] = "FADEmmss";
-	lumpnum_t lumpnum;
 	size_t lsize;
 
+	// screen textures disabled completely
 	if (cv_glscreentextures.value == 0)
 	{
-		V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31); // just draw a black screen instead of flashing and crap
-		return;
+		return false;
 	}
 
-	if (wipenum > 99 || scrnnum > 99) // not a valid wipe number
+	// not a valid wipe number
+	if (wipenum > 99 || scrnnum > 99)
 	{
-		V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31); // just draw a black screen instead of flashing and crap
-		return; // shouldn't end up here really, the loop should've stopped running beforehand
+		return false; // shouldn't end up here really, the loop should've stopped running beforehand
 	}
 
 	// puts the numbers into the lumpname
 	sprintf(&lumpname[4], "%.2hu%.2hu", (UINT16)wipenum, (UINT16)scrnnum);
-	lumpnum = W_CheckNumForName(lumpname);
+	wipelumpnum = W_CheckNumForName(lumpname);
 
-	if (lumpnum == LUMPERROR) // again, shouldn't be here really
+	// again, shouldn't be here really
+	if (wipelumpnum == LUMPERROR)
 	{
-		V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31); // just draw a black screen instead of flashing and crap
-		return;
+		return false;
 	}
 
-	lsize = W_LumpLength(lumpnum);
+	lsize = W_LumpLength(wipelumpnum);
 
 	if (!(lsize == 256000 || lsize == 64000 || lsize == 16000 || lsize == 4000))
 	{
 		CONS_Alert(CONS_WARNING, "Fade mask lump %s of incorrect size, ignored\n", lumpname);
-		V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31); // just draw a black screen instead of flashing and crap
-		return; // again, shouldn't get here if it is a bad size
+		return false; // again, shouldn't get here if it is a bad size
 	}
 
-	HWR_GetFadeMask(lumpnum);
+	return true;
+}
+
+void HWR_DoWipe(UINT8 wipenum, UINT8 scrnnum)
+{
+	if (!HWR_WipeCheck(wipenum, scrnnum))
+	{
+		// just draw a black screen instead of rapidly flashing a white screen
+		V_DrawFill(0, 0, BASEVIDWIDTH, BASEVIDHEIGHT, 31);
+		return;
+	}
+
+	HWR_GetFadeMask(wipelumpnum);
 	GL_DoScreenWipe(HWD_SCREENTEXTURE_WIPE_START, HWD_SCREENTEXTURE_WIPE_END);
 }
 

src/hardware/hw_md2.c

@@ -1153,8 +1153,11 @@ void HWR_DrawMD2(gl_vissprite_t *spr)
 		INT32 durs = spr->mobj->state->tics;
 		INT32 tics = spr->mobj->tics;
 		//mdlframe_t *next = NULL;
+
+		//const UINT8 flip = (UINT8)(!(spr->mobj->eflags & MFE_VERTICALFLIP) != !R_ThingVerticallyFlipped(spr->mobj)); // :chaosleep:
 		const UINT8 flip = (UINT8)((spr->mobj->eflags & MFE_VERTICALFLIP) == MFE_VERTICALFLIP);
-		const UINT8 hflip = (UINT8)(!(spr->mobj->mirrored) != !(spr->mobj->frame & FF_HORIZONTALFLIP));
+		const UINT8 hflip = (UINT8)(!(spr->mobj->mirrored) != !R_ThingHorizontallyFlipped(spr->mobj));
+
 		spritedef_t *sprdef;
 		spriteframe_t *sprframe;
 		spriteinfo_t *sprinfo;

src/hardware/r_opengl/ogl_win.c

@@ -1,549 +0,0 @@
-// Emacs style mode select   -*- C++ -*-
-//-----------------------------------------------------------------------------
-//
-// Copyright (C) 1998-2000 by DooM Legacy Team.
-//
-// This program is free software; you can redistribute it and/or
-// modify it under the terms of the GNU General Public License
-// as published by the Free Software Foundation; either version 2
-// of the License, or (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-//-----------------------------------------------------------------------------
-/// \file
-/// \brief Windows specific part of the OpenGL API for Doom Legacy
-///
-///	TODO:
-///	- check if windowed mode works
-///	- support different pixel formats
-
-
-#if defined (_WIN32)
-
-//#define WIN32_LEAN_AND_MEAN
-#define RPC_NO_WINDOWS_H
-#include <windows.h>
-#include <time.h>
-#include "r_opengl.h"
-
-
-// **************************************************************************
-//                                                                    GLOBALS
-// **************************************************************************
-
-#ifdef DEBUG_TO_FILE
-static unsigned long nb_frames = 0;
-static clock_t my_clock;
-FILE *gllogstream;
-#endif
-
-static  HDC     hDC           = NULL;       // the window's device context
-static  HGLRC   hGLRC         = NULL;       // the OpenGL rendering context
-static  HWND    hWnd          = NULL;
-static  BOOL    WasFullScreen = FALSE;
-static void UnSetRes(void);
-
-#ifdef USE_WGL_SWAP
-PFNWGLEXTSWAPCONTROLPROC wglSwapIntervalEXT = NULL;
-#endif
-
-PFNglClear pglClear;
-PFNglGetIntegerv pglGetIntegerv;
-PFNglGetString pglGetString;
-
-#define MAX_VIDEO_MODES   32
-static  vmode_t     video_modes[MAX_VIDEO_MODES];
-INT32     oglflags = 0;
-
-// **************************************************************************
-//                                                                  FUNCTIONS
-// **************************************************************************
-
-// -----------------+
-// APIENTRY DllMain : DLL Entry Point,
-//                  : open/close debug log
-// Returns          :
-// -----------------+
-BOOL WINAPI DllMain(HINSTANCE hinstDLL, // handle to DLL module
-                    DWORD fdwReason,    // reason for calling function
-                    LPVOID lpvReserved) // reserved
-{
-	// Perform actions based on the reason for calling.
-	UNREFERENCED_PARAMETER(lpvReserved);
-	switch (fdwReason)
-	{
-		case DLL_PROCESS_ATTACH:
-			// Initialize once for each new process.
-			// Return FALSE to fail DLL load.
-#ifdef DEBUG_TO_FILE
-			gllogstream = fopen("ogllog.txt", "wt");
-			if (gllogstream == NULL)
-				return FALSE;
-#endif
-			DisableThreadLibraryCalls(hinstDLL);
-			break;
-
-		case DLL_THREAD_ATTACH:
-			// Do thread-specific initialization.
-			break;
-
-		case DLL_THREAD_DETACH:
-			// Do thread-specific cleanup.
-			break;
-
-		case DLL_PROCESS_DETACH:
-			// Perform any necessary cleanup.
-#ifdef DEBUG_TO_FILE
-			if (gllogstream)
-			{
-				fclose(gllogstream);
-				gllogstream  = NULL;
-			}
-#endif
-			break;
-	}
-
-	return TRUE;  // Successful DLL_PROCESS_ATTACH.
-}
-
-#ifdef STATIC_OPENGL
-#define pwglGetProcAddress wglGetProcAddress;
-#define pwglCreateContext wglCreateContext;
-#define pwglDeleteContext wglDeleteContext;
-#define pwglMakeCurrent wglMakeCurrent;
-#else
-static HMODULE OGL32;
-typedef void *(WINAPI *PFNwglGetProcAddress) (const char *);
-static PFNwglGetProcAddress pwglGetProcAddress;
-typedef HGLRC (WINAPI *PFNwglCreateContext) (HDC hdc);
-static PFNwglCreateContext pwglCreateContext;
-typedef BOOL (WINAPI *PFNwglDeleteContext) (HGLRC hglrc);
-static PFNwglDeleteContext pwglDeleteContext;
-typedef BOOL (WINAPI *PFNwglMakeCurrent) (HDC hdc, HGLRC hglrc);
-static PFNwglMakeCurrent pwglMakeCurrent;
-#endif
-
-#ifndef STATIC_OPENGL
-void *GetGLFunc(const char *proc)
-{
-	void *func = NULL;
-	if (pwglGetProcAddress)
-		func = pwglGetProcAddress(proc);
-	if (!func)
-		func = GetProcAddress(OGL32, proc);
-	return func;
-}
-#endif
-
-boolean LoadGL(void)
-{
-#ifndef STATIC_OPENGL
-	OGL32 = LoadLibrary("OPENGL32.DLL");
-
-	if (!OGL32)
-		return 0;
-
-	pwglGetProcAddress = GetGLFunc("wglGetProcAddress");
-	pwglCreateContext = GetGLFunc("wglCreateContext");
-	pwglDeleteContext = GetGLFunc("wglDeleteContext");
-	pwglMakeCurrent = GetGLFunc("wglMakeCurrent");
-#endif
-	return SetupGLfunc();
-}
-
-// -----------------+
-// SetupPixelFormat : Set the device context's pixel format
-// Note             : Because we currently use only the desktop's BPP format, all the
-//                  : video modes in Doom Legacy OpenGL are of the same BPP, thus the
-//                  : PixelFormat is set only once.
-//                  : Setting the pixel format more than once on the same window
-//                  : doesn't work. (ultimately for different pixel formats, we
-//                  : should close the window, and re-create it)
-// -----------------+
-int SetupPixelFormat(INT32 WantColorBits, INT32 WantStencilBits, INT32 WantDepthBits)
-{
-	static DWORD iLastPFD = 0;
-	INT32 nPixelFormat;
-	PIXELFORMATDESCRIPTOR pfd =
-	{
-		sizeof (PIXELFORMATDESCRIPTOR),  // size
-		1,                              // version
-		PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL | PFD_DOUBLEBUFFER,
-		PFD_TYPE_RGBA,                  // color type
-		32 /*WantColorBits*/,           // cColorBits : prefered color depth
-		0, 0,                           // cRedBits, cRedShift
-		0, 0,                           // cGreenBits, cGreenShift
-		0, 0,                           // cBlueBits, cBlueShift
-		0, 0,                           // cAlphaBits, cAlphaShift
-		0,                              // cAccumBits
-		0, 0, 0, 0,                     // cAccum Red/Green/Blue/Alpha Bits
-		0,                              // cDepthBits (0,16,24,32)
-		0,                              // cStencilBits
-		0,                              // cAuxBuffers
-		PFD_MAIN_PLANE,                 // iLayerType
-		0,                              // reserved, must be zero
-		0, 0, 0,                        // dwLayerMask, dwVisibleMask, dwDamageMask
-	};
-
-	DWORD iPFD = (WantColorBits<<16) | (WantStencilBits<<8) | WantDepthBits;
-
-	pfd.cDepthBits = (BYTE)WantDepthBits;
-	pfd.cStencilBits = (BYTE)WantStencilBits;
-
-	if (iLastPFD)
-	{
-		DBG_Printf("WARNING : SetPixelFormat() called twise not supported by all drivers !\n");
-	}
-
-	// set the pixel format only if different than the current
-	if (iPFD == iLastPFD)
-		return 2;
-	else
-		iLastPFD = iPFD;
-
-	DBG_Printf("SetupPixelFormat() - %d ColorBits - %d StencilBits - %d DepthBits\n",
-	           WantColorBits, WantStencilBits, WantDepthBits);
-
-	nPixelFormat = ChoosePixelFormat(hDC, &pfd);
-
-	if (nPixelFormat == 0)
-		DBG_Printf("ChoosePixelFormat() FAILED\n");
-
-	if (SetPixelFormat(hDC, nPixelFormat, &pfd) == 0)
-	{
-		DBG_Printf("SetPixelFormat() FAILED\n");
-		return 0;
-	}
-
-	return 1;
-}
-
-
-// -----------------+
-// SetRes           : Set a display mode
-// Notes            : pcurrentmode is actually not used
-// -----------------+
-static INT32 WINAPI SetRes(viddef_t *lvid, vmode_t *pcurrentmode)
-{
-	LPCSTR renderer;
-	BOOL WantFullScreen = !(lvid->u.windowed);  //(lvid->u.windowed ? 0 : CDS_FULLSCREEN);
-
-	UNREFERENCED_PARAMETER(pcurrentmode);
-	DBG_Printf ("SetMode(): %dx%d %d bits (%s)\n",
-	            lvid->width, lvid->height, lvid->bpp*8,
-	            WantFullScreen ? "fullscreen" : "windowed");
-
-	hWnd = lvid->WndParent;
-
-	// BP : why flush texture ?
-	//      if important flush also the first one (white texture) and restore it !
-	Flush();    // Flush textures.
-
-// TODO: if not fullscreen, skip display stuff and just resize viewport stuff ...
-
-	// Exit previous mode
-	//if (hGLRC) //Hurdler: TODO: check if this is valid
-	//    UnSetRes();
-	if (WasFullScreen)
-		ChangeDisplaySettings(NULL, CDS_FULLSCREEN); //switch in and out of fullscreen
-
-		// Change display settings.
-	if (WantFullScreen)
-	{
-		DEVMODE dm;
-		ZeroMemory(&dm, sizeof (dm));
-		dm.dmSize       = sizeof (dm);
-		dm.dmPelsWidth  = lvid->width;
-		dm.dmPelsHeight = lvid->height;
-		dm.dmBitsPerPel = lvid->bpp*8;
-		dm.dmFields     = DM_PELSWIDTH | DM_PELSHEIGHT | DM_BITSPERPEL;
-		if (ChangeDisplaySettings(&dm, CDS_TEST) != DISP_CHANGE_SUCCESSFUL)
-			return -2;
-		if (ChangeDisplaySettings(&dm, CDS_FULLSCREEN) !=DISP_CHANGE_SUCCESSFUL)
-			return -3;
-
-		SetWindowLong(hWnd, GWL_STYLE, WS_POPUP|WS_VISIBLE);
-		// faB : book says to put these, surely for windowed mode
-		//WS_CLIPCHILDREN|WS_CLIPSIBLINGS);
-		SetWindowPos(hWnd, HWND_TOPMOST, 0, 0, lvid->width, lvid->height, SWP_NOACTIVATE|SWP_NOZORDER);
-	}
-	else
-	{
-		RECT bounds;
-		INT32 x, y;
-		INT32 w = lvid->width, h = lvid->height;
-		GetWindowRect(hWnd, &bounds);
-		bounds.right = bounds.left+w;
-		bounds.bottom = bounds.top+h;
-		AdjustWindowRectEx(&bounds, GetWindowLong(hWnd, GWL_STYLE), (GetMenu(hWnd) != NULL), 0);
-		w = bounds.right-bounds.left;
-		h = bounds.bottom-bounds.top;
-		x = (GetSystemMetrics(SM_CXSCREEN)-w)/2;
-		y = (GetSystemMetrics(SM_CYSCREEN)-h)/2;
-		SetWindowPos(hWnd, NULL, x, y, w, h, SWP_NOACTIVATE|SWP_NOZORDER);
-	}
-
-	if (!hDC)
-		hDC = GetDC(hWnd);
-	if (!hDC)
-	{
-		DBG_Printf("GetDC() FAILED\n");
-		return 0;
-	}
-
-	{
-		INT32 res;
-
-		// Set res.
-		res = SetupPixelFormat(lvid->bpp*8, 0, 16);
-
-		if (res == 0)
-			return 0;
-		else if (res == 1)
-		{
-			// Exit previous mode
-			if (hGLRC)
-				UnSetRes();
-			hGLRC = pwglCreateContext(hDC);
-			if (!hGLRC)
-			{
-				DBG_Printf("pwglCreateContext() FAILED\n");
-				return 0;
-			}
-			if (!pwglMakeCurrent(hDC, hGLRC))
-			{
-				DBG_Printf("wglMakeCurrent() FAILED\n");
-				return 0;
-			}
-		}
-	}
-
-	gl_extensions = pglGetString(GL_EXTENSIONS);
-	// Get info and extensions.
-	//BP: why don't we make it earlier ?
-	//Hurdler: we cannot do that before intialising gl context
-	renderer = (LPCSTR)pglGetString(GL_RENDERER);
-	DBG_Printf("Vendor     : %s\n", pglGetString(GL_VENDOR));
-	DBG_Printf("Renderer   : %s\n", renderer);
-	DBG_Printf("Version    : %s\n", pglGetString(GL_VERSION));
-	DBG_Printf("Extensions : %s\n", gl_extensions);
-
-	// BP: disable advenced feature that don't work on somes hardware
-	// Hurdler: Now works on G400 with bios 1.6 and certified drivers 6.04
-	if (strstr(renderer, "810"))   oglflags |= GLF_NOZBUFREAD;
-	DBG_Printf("oglflags   : 0x%X\n", oglflags);
-
-#ifdef USE_WGL_SWAP
-	if (isExtAvailable("WGL_EXT_swap_control",gl_extensions))
-		wglSwapIntervalEXT = GetGLFunc("wglSwapIntervalEXT");
-	else
-		wglSwapIntervalEXT = NULL;
-#endif
-
-	if (isExtAvailable("GL_EXT_texture_filter_anisotropic",gl_extensions))
-		pglGetIntegerv(GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT, &maximumAnisotropy);
-	else
-		maximumAnisotropy = 0;
-
-	SetupGLFunc13();
-
-	screen_depth = (GLbyte)(lvid->bpp*8);
-	if (screen_depth > 16)
-		textureformatGL = GL_RGBA;
-	else
-		textureformatGL = GL_RGB5_A1;
-
-	GL_SetModelView(lvid->width, lvid->height);
-	GL_SetStates();
-	// we need to clear the depth buffer. Very important!!!
-	pglClear(GL_COLOR_BUFFER_BIT|GL_DEPTH_BUFFER_BIT);
-
-	lvid->buffer = NULL;    // unless we use the software view
-	lvid->direct = NULL;    // direct access to video memory, old DOS crap
-
-	WasFullScreen = WantFullScreen;
-
-	return 1;               // on renvoie une valeur pour dire que cela s'est bien pass�
-}
-
-
-// -----------------+
-// UnSetRes         : Restore the original display mode
-// -----------------+
-static void UnSetRes(void)
-{
-	DBG_Printf("UnSetRes()\n");
-
-	pwglMakeCurrent(hDC, NULL);
-	pwglDeleteContext(hGLRC);
-	hGLRC = NULL;
-	if (WasFullScreen)
-		ChangeDisplaySettings(NULL, CDS_FULLSCREEN);
-}
-
-
-// -----------------+
-// GetModeList      : Return the list of available display modes.
-// Returns          : pvidmodes   - points to list of detected OpenGL video modes
-//                  : numvidmodes - number of detected OpenGL video modes
-// -----------------+
-EXPORT void HWRAPI(GetModeList) (vmode_t** pvidmodes, INT32 *numvidmodes)
-{
-	INT32  i;
-
-#if 1
-	INT32 iMode;
-/*
-	faB test code
-
-	Commented out because there might be a problem with combo (Voodoo2 + other card),
-	we need to get the 3D card's display modes only.
-*/
-	(*pvidmodes) = &video_modes[0];
-
-	// Get list of device modes
-	for (i = 0,iMode = 0; iMode < MAX_VIDEO_MODES; i++)
-	{
-		DEVMODE Tmp;
-		ZeroMemory(&Tmp, sizeof (Tmp));
-		Tmp.dmSize = sizeof (Tmp);
-		if (!EnumDisplaySettings(NULL, i, &Tmp))
-			break;
-
-		// add video mode
-		if (Tmp.dmBitsPerPel == 16 &&
-			 (iMode == 0 || !
-			  (Tmp.dmPelsWidth == video_modes[iMode-1].width &&
-			   Tmp.dmPelsHeight == video_modes[iMode-1].height)
-			 )
-			)
-		{
-			video_modes[iMode].pnext = &video_modes[iMode+1];
-			video_modes[iMode].windowed = 0;                    // fullscreen is the default
-			video_modes[iMode].misc = 0;
-			video_modes[iMode].name = malloc(12 * sizeof (CHAR));
-			sprintf(video_modes[iMode].name, "%dx%d", (INT32)Tmp.dmPelsWidth, (INT32)Tmp.dmPelsHeight);
-			DBG_Printf ("Mode: %s\n", video_modes[iMode].name);
-			video_modes[iMode].width = Tmp.dmPelsWidth;
-			video_modes[iMode].height = Tmp.dmPelsHeight;
-			video_modes[iMode].bytesperpixel = Tmp.dmBitsPerPel/8;
-			video_modes[iMode].rowbytes = Tmp.dmPelsWidth * video_modes[iMode].bytesperpixel;
-			video_modes[iMode].pextradata = NULL;
-			video_modes[iMode].setmode = SetRes;
-			iMode++;
-		}
-	}
-	(*numvidmodes) = iMode;
-#else
-
-	// classic video modes (fullscreen/windowed)
-	// Added some. Tails
-	INT32 res[][2] = {
-					{ 320, 200},
-					{ 320, 240},
-					{ 400, 300},
-					{ 512, 384},
-					{ 640, 400},
-					{ 640, 480},
-					{ 800, 600},
-					{ 960, 600},
-					{1024, 768},
-					{1152, 864},
-					{1280, 800},
-					{1280, 960},
-					{1280,1024},
-					{1600,1000},
-					{1680,1050},
-					{1920,1200},
-};
-
-	HDC bpphdc;
-	INT32 iBitsPerPel;
-
-	DBG_Printf ("HWRAPI GetModeList()\n");
-
-	bpphdc = GetDC(NULL); // on obtient le bpp actuel
-	iBitsPerPel = GetDeviceCaps(bpphdc, BITSPIXEL);
-
-	ReleaseDC(NULL, bpphdc);
-
-	(*pvidmodes) = &video_modes[0];
-	(*numvidmodes) = sizeof (res) / sizeof (res[0]);
-	for (i = 0; i < (*numvidmodes); i++)
-	{
-		video_modes[i].pnext = &video_modes[i+1];
-		video_modes[i].windowed = 0; // fullscreen is the default
-		video_modes[i].misc = 0;
-		video_modes[i].name = malloc(12 * sizeof (CHAR));
-		sprintf(video_modes[i].name, "%dx%d", res[i][0], res[i][1]);
-		DBG_Printf ("Mode: %s\n", video_modes[i].name);
-		video_modes[i].width = res[i][0];
-		video_modes[i].height = res[i][1];
-		video_modes[i].bytesperpixel = iBitsPerPel/8;
-		video_modes[i].rowbytes = res[i][0] * video_modes[i].bytesperpixel;
-		video_modes[i].pextradata = NULL;
-		video_modes[i].setmode = SetRes;
-	}
-#endif
-	video_modes[(*numvidmodes)-1].pnext = NULL;
-}
-
-
-// -----------------+
-// Shutdown         : Shutdown OpenGL, restore the display mode
-// -----------------+
-EXPORT void HWRAPI(Shutdown) (void)
-{
-#ifdef DEBUG_TO_FILE
-	long nb_centiemes;
-
-	DBG_Printf ("HWRAPI Shutdown()\n");
-	nb_centiemes = ((clock()-my_clock)*100)/CLOCKS_PER_SEC;
-	DBG_Printf("Nb frames: %li;  Nb sec: %2.2f  ->  %2.1f fps\n",
-					nb_frames, nb_centiemes/100.0f, (100*nb_frames)/(double)nb_centiemes);
-#endif
-
-	Flush();
-
-	// Exit previous mode
-	if (hGLRC)
-		UnSetRes();
-
-	if (hDC)
-	{
-		ReleaseDC(hWnd, hDC);
-		hDC = NULL;
-	}
-	FreeLibrary(OGL32);
-	DBG_Printf ("HWRAPI Shutdown(DONE)\n");
-}
-
-// -----------------+
-// FinishUpdate     : Swap front and back buffers
-// -----------------+
-void GL_FinishUpdate (INT32 waitvbl)
-{
-#ifdef USE_WGL_SWAP
-	static INT32 oldwaitvbl = 0;
-#else
-	UNREFERENCED_PARAMETER(waitvbl);
-#endif
-	// DBG_Printf ("FinishUpdate()\n");
-#ifdef DEBUG_TO_FILE
-	if ((++nb_frames)==2)  // on ne commence pas � la premi�re frame
-		my_clock = clock();
-#endif
-
-#ifdef USE_WGL_SWAP
-	if (oldwaitvbl != waitvbl && wglSwapIntervalEXT)
-		wglSwapIntervalEXT(waitvbl);
-	oldwaitvbl = waitvbl;
-#endif
-
-	SwapBuffers(hDC);
-}
-#endif

src/hardware/r_opengl/r_opengl.c

@@ -776,15 +776,15 @@ static int GLFramebuffer_CheckExt(void)
 	// gl versions from 2.1 may still support framebuffer objects
 
 	// maybe, just maybe, we support the standart extensions
-	if (GL_isExtAvailable("GL_ARB_framebuffer_no_attachments", gl_extensions)
-		&& GL_isExtAvailable("GL_ARB_framebuffer_object", gl_extensions)
-		&& GL_isExtAvailable("GL_ARB_framebuffer_sRGB", gl_extensions))
+	if (GL_isExtAvailable("GL_ARB_framebuffer_no_attachments", gl_extensions) &&
+		GL_isExtAvailable("GL_ARB_framebuffer_object", gl_extensions) &&
+		GL_isExtAvailable("GL_ARB_framebuffer_sRGB", gl_extensions))
 		return FBO_ARB;
 
 	// nope, try the older 2.1 extensions
-	if (GL_isExtAvailable("GL_EXT_framebuffer_no_attachments", gl_extensions)
-		&& GL_isExtAvailable("GL_EXT_framebuffer_object", gl_extensions)
-		&& GL_isExtAvailable("GL_EXT_framebuffer_sRGB", gl_extensions))
+	if (GL_isExtAvailable("GL_EXT_framebuffer_no_attachments", gl_extensions) &&
+		GL_isExtAvailable("GL_EXT_framebuffer_object", gl_extensions) &&
+		GL_isExtAvailable("GL_EXT_framebuffer_sRGB", gl_extensions))
 	{
 		// perhaps we may even support a stencil attachment
 		if (GL_isExtAvailable("GL_EXT_packed_depth_stencil", gl_extensions))
@@ -885,7 +885,7 @@ void SetupGLFunc4(void)
 	{ \
 		GL_MSG_Warning("failed to get OpenGL FBO function: %s\n", #func); \
 		GL_DBG_Printf("\nFBO: No framebuffer object support\n"); \
-		supportFBO = false; \
+		supportFBO = FBO_NONE; \
 		return; \
 	} \
 
@@ -1465,6 +1465,19 @@ void GL_ReadScreenTexture(int tex, UINT8 *restrict dest, INT32 scale)
 	if (tex != HWD_SCREENTEXTURE_GENERIC2)
 		GL_DrawScreenTexture(tex, NULL, 0);
 
+#ifdef USE_FBO_OGL
+	// FIXME: this is incredibly stupid
+	// but the final screen texture will NOT be drawn in the downsample fbo
+	if (tex == HWD_SCREENTEXTURE_GENERIC2 &&
+		UseScreenFBO() && HWR_ShouldUsePaletteRendering())
+	{
+		GL_SetShader(HWR_GetShaderFromTarget(SHADER_PALETTE_POSTPROCESS));
+		GL_EnableShader();
+		GL_DrawScreenTexture(HWD_SCREENTEXTURE_GENERIC2, NULL, 0);
+		GL_UnSetShader();
+	}
+#endif
+
 	image = malloc(screen_width*screen_height*3);
 	pglPixelStorei(GL_PACK_ALIGNMENT, 1);
 	pglReadPixels(0, 0, screen_width, screen_height, GL_RGB, GL_UNSIGNED_BYTE, image);
@@ -2490,7 +2503,7 @@ void GL_RenderSkyDome(gl_sky_t *sky)
 	GL_Shader_SetUniforms(NULL, NULL, NULL, NULL);
 
 	// Build the sky dome! Yes!
-	if (sky->rebuild)
+	if (sky->rebuild || !sky->vbo)
 	{
 		// delete VBO when already exists
 		if (sky->vbo)
@@ -3208,8 +3221,8 @@ void GL_SetTransform(FTransform *stransform)
 	{
 		float dy = stransform->viewaiming * 2;
 
-		if (stransform->fliptype == TRANSFORM_FLIP
-			|| stransform->fliptype == TRANSFORM_MIRRORFLIP)
+		if (stransform->fliptype == TRANSFORM_FLIP ||
+			stransform->fliptype == TRANSFORM_MIRRORFLIP)
 			dy *= -1.0f;
 
 		pglTranslatef(0.0f, -dy/BASEVIDHEIGHT, 0.0f);
@@ -3234,7 +3247,7 @@ void GL_SetTransform(FTransform *stransform)
 #ifdef USE_FBO_OGL
 static void GL_Framebuffer_DeleteAttachments(void)
 {
-	if (!supportFBO || !framebufferobject.init)
+	if (supportFBO == FBO_NONE || !framebufferobject.init)
 		return;
 
 	// Unbind the framebuffer
@@ -3254,7 +3267,7 @@ static void GL_Framebuffer_DeleteAttachments(void)
 
 static void GL_Framebuffer_Generate(void)
 {
-	if (!supportFBO || framebufferobject.init || !UseScreenFBO())
+	if (supportFBO == FBO_NONE || framebufferobject.init || !UseScreenFBO())
 		return;
 
 	// Generate the framebuffer
@@ -3274,10 +3287,10 @@ static void GL_Framebuffer_Generate(void)
 		pglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
 		Clamp2D(GL_TEXTURE_WRAP_S);
 		Clamp2D(GL_TEXTURE_WRAP_T);
-		pglBindTexture(GL_TEXTURE_2D, 0);
 
 		// Attach the framebuffer texture to the framebuffer
 		pglFramebufferTexture2D(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT, GL_TEXTURE_2D, framebufferobject.tex, 0);
+		pglBindTexture(GL_TEXTURE_2D, 0);
 	}
 
 	// Generate the renderbuffer
@@ -3319,7 +3332,7 @@ static void GL_Framebuffer_Generate(void)
 
 		// if this fails, dont retry it a gazillion times
 		// this wouldnt recover
-		supportFBO = false;
+		supportFBO = FBO_NONE;
 		pglBindFramebuffer(GL_FRAMEBUFFER_EXT, 0);
 		return;
 	}
@@ -3332,7 +3345,7 @@ static void GL_Framebuffer_Generate(void)
 
 void GL_Framebuffer_Unbind(void)
 {
-	if (!supportFBO || !framebufferobject.init)
+	if (supportFBO == FBO_NONE || !framebufferobject.init)
 		return;
 
 	pglBindFramebuffer(GL_FRAMEBUFFER_EXT, 0);
@@ -3341,13 +3354,13 @@ void GL_Framebuffer_Unbind(void)
 
 void GL_Framebuffer_Enable(void)
 {
-	if (!supportFBO || !UseScreenFBO())
+	if (supportFBO == FBO_NONE || !UseScreenFBO())
 		return;
 
 	GL_Framebuffer_Generate();
 
 	// failed
-	if (!supportFBO || !framebufferobject.init)
+	if (supportFBO == FBO_NONE || !framebufferobject.init)
 		return;
 
 	pglBindFramebuffer(GL_FRAMEBUFFER_EXT, framebufferobject.fboobj);
@@ -3356,7 +3369,7 @@ void GL_Framebuffer_Enable(void)
 
 void GL_Framebuffer_Disable(void)
 {
-	if (!supportFBO || !framebufferobject.init)
+	if (supportFBO == FBO_NONE || !framebufferobject.init)
 		return;
 
 	pglBindFramebuffer(GL_FRAMEBUFFER_EXT, 0);

src/hardware/r_opengl/r_opengl.dev

@@ -1,79 +0,0 @@
-[Project]
-FileName=r_opengl.dev
-Name=r_opengl
-Ver=1
-IsCpp=1
-Type=3
-Compiler=-D_M_IX86=500_@@_-Wall_@@_-D_WINDOWS_@@_-DUSE_WGL_SWAP_@@_-Os_@@_-fomit-frame-pointer_@@_
-CppCompiler=
-Includes=
-Linker=--def ../r_mingw.def_@@_-lgdi32_@@_
-Libs=
-UnitCount=3
-Folders=
-ObjFiles=
-PrivateResource=
-ResourceIncludes=
-MakeIncludes=
-Icon=
-ExeOutput=C:\srb2demo2
-ObjectOutput=..\..\..\objs\Mingw\r_opengl
-OverrideOutput=1
-OverrideOutputName=r_opengl.dll
-HostApplication=
-CommandLine=
-IncludeVersionInfo=0
-SupportXPThemes=0
-CompilerSet=0
-CompilerSettings=00000000000000000111d0
-UseCustomMakefile=0
-CustomMakefile=
-
-[Unit1]
-FileName=ogl_win.c
-Folder=
-Compile=1
-CompileCpp=0
-Link=1
-Priority=1000
-OverrideBuildCmd=0
-BuildCmd=
-
-[Unit2]
-FileName=r_opengl.c
-Folder=
-Compile=1
-CompileCpp=0
-Link=1
-Priority=1000
-OverrideBuildCmd=0
-BuildCmd=
-
-[Unit3]
-FileName=r_opengl.h
-Folder=
-Compile=1
-CompileCpp=1
-Link=1
-Priority=1000
-OverrideBuildCmd=0
-BuildCmd=
-
-[VersionInfo]
-Major=0
-Minor=1
-Release=1
-Build=1
-LanguageID=1033
-CharsetID=1252
-CompanyName=
-FileVersion=0.1
-FileDescription=Developed using the Dev-C++ IDE
-InternalName=
-LegalCopyright=
-LegalTrademarks=
-OriginalFilename=r_opengl.exe
-ProductName=r_opengl
-ProductVersion=0.1
-AutoIncBuildNr=0
-

src/hardware/r_opengl/r_opengl.dsp

@@ -1,105 +0,0 @@
-# Microsoft Developer Studio Project File - Name="r_opengl" - Package Owner=<4>
-# Microsoft Developer Studio Generated Build File, Format Version 6.00
-# ** DO NOT EDIT **
-
-# TARGTYPE "Win32 (x86) Dynamic-Link Library" 0x0102
-
-CFG=r_opengl - Win32 Debug
-!MESSAGE This is not a valid makefile. To build this project using NMAKE,
-!MESSAGE use the Export Makefile command and run
-!MESSAGE 
-!MESSAGE NMAKE /f "r_opengl.mak".
-!MESSAGE 
-!MESSAGE You can specify a configuration when running NMAKE
-!MESSAGE by defining the macro CFG on the command line. For example:
-!MESSAGE 
-!MESSAGE NMAKE /f "r_opengl.mak" CFG="r_opengl - Win32 Debug"
-!MESSAGE 
-!MESSAGE Possible choices for configuration are:
-!MESSAGE 
-!MESSAGE "r_opengl - Win32 Release" (based on "Win32 (x86) Dynamic-Link Library")
-!MESSAGE "r_opengl - Win32 Debug" (based on "Win32 (x86) Dynamic-Link Library")
-!MESSAGE 
-
-# Begin Project
-# PROP AllowPerConfigDependencies 0
-# PROP Scc_ProjName ""
-# PROP Scc_LocalPath ""
-CPP=cl.exe
-MTL=midl.exe
-RSC=rc.exe
-
-!IF  "$(CFG)" == "r_opengl - Win32 Release"
-
-# PROP BASE Use_MFC 0
-# PROP BASE Use_Debug_Libraries 0
-# PROP BASE Output_Dir "r_opengl___Win32_Release"
-# PROP BASE Intermediate_Dir "r_opengl___Win32_Release"
-# PROP BASE Target_Dir ""
-# PROP Use_MFC 0
-# PROP Use_Debug_Libraries 0
-# PROP Output_Dir "..\..\..\bin\VC\Release\r_opengl"
-# PROP Intermediate_Dir "..\..\..\objs\VC\Release\r_opengl"
-# PROP Ignore_Export_Lib 1
-# PROP Target_Dir ""
-# ADD BASE CPP /nologo /MT /W3 /GX /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "R_OPENGL_EXPORTS" /YX /FD /c
-# ADD CPP /nologo /G5 /W3 /GX /Zi /O2 /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /D "__WIN32__" /D "__MSC__" /D "USE_WGL_SWAP" /FR /FD /c
-# ADD BASE MTL /nologo /D "NDEBUG" /mktyplib203 /win32
-# ADD MTL /nologo /D "NDEBUG" /mktyplib203 /win32
-# ADD BASE RSC /l 0x80c /d "NDEBUG"
-# ADD RSC /l 0x409 /d "NDEBUG"
-BSC32=bscmake.exe
-# ADD BASE BSC32 /nologo
-# ADD BSC32 /nologo
-LINK32=link.exe
-# ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /dll /machine:I386
-# ADD LINK32 user32.lib gdi32.lib /nologo /dll /pdb:"..\..\..\bin\VC\Release\r_opengl.pdb" /machine:I386 /out:"C:\srb2demo2\r_opengl.dll"
-# SUBTRACT LINK32 /pdb:none /debug
-
-!ELSEIF  "$(CFG)" == "r_opengl - Win32 Debug"
-
-# PROP BASE Use_MFC 0
-# PROP BASE Use_Debug_Libraries 1
-# PROP BASE Output_Dir "..\..\..\objs\Debug"
-# PROP BASE Intermediate_Dir "..\..\..\objs\Debug"
-# PROP BASE Target_Dir ""
-# PROP Use_MFC 0
-# PROP Use_Debug_Libraries 1
-# PROP Output_Dir "..\..\..\bin\VC\Debug\r_opengl"
-# PROP Intermediate_Dir "..\..\..\objs\VC\Debug\r_opengl"
-# PROP Ignore_Export_Lib 1
-# PROP Target_Dir ""
-# ADD BASE CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /D "WIN32" /D "_DEBUG" /D "_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "R_OPENGL_EXPORTS" /YX /FD /GZ /c
-# ADD CPP /nologo /G6 /W4 /Gm /GX /ZI /Od /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /D "__WIN32__" /D "__MSC__" /D "USE_WGL_SWAP" /FR /FD /GZ /c
-# ADD BASE MTL /nologo /D "_DEBUG" /mktyplib203 /win32
-# ADD MTL /nologo /D "_DEBUG" /mktyplib203 /win32
-# ADD BASE RSC /l 0x80c /d "_DEBUG"
-# ADD RSC /l 0x409 /d "_DEBUG"
-BSC32=bscmake.exe
-# ADD BASE BSC32 /nologo
-# ADD BSC32 /nologo
-LINK32=link.exe
-# ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /dll /debug /machine:I386 /pdbtype:sept
-# ADD LINK32 user32.lib gdi32.lib /nologo /dll /pdb:"..\..\..\bin\VC\Debug\r_opengl.pdb" /debug /machine:I386 /out:"C:\srb2demo2\r_opengld.dll" /pdbtype:sept
-# SUBTRACT LINK32 /pdb:none
-
-!ENDIF 
-
-# Begin Target
-
-# Name "r_opengl - Win32 Release"
-# Name "r_opengl - Win32 Debug"
-# Begin Source File
-
-SOURCE=.\ogl_win.c
-# End Source File
-# Begin Source File
-
-SOURCE=.\r_opengl.c
-# End Source File
-# Begin Source File
-
-SOURCE=.\r_opengl.h
-# End Source File
-# End Target
-# End Project

src/hu_stuff.c

@@ -2259,12 +2259,13 @@ static void HU_DrawSongCreditsBox(void)
 		y = -BOXCREDITHEIGHT*dup + (FixedMul(BOXCREDITHEIGHT*FRACUNIT, FixedDiv(t*FRACUNIT, TICRATE*FRACUNIT/2))*dup - interpoffset)/FRACUNIT;
 	}
 
-	bgt = (NUMTRANSMAPS/2) + (cursongcredit.trans/2);
+	bgt = (NUMTRANSMAPS/2) + (cursongcredit.trans/2) - 2; // arbitrary value, looks a bit better
 
 	if (bgt < NUMTRANSMAPS)
 	{
-		V_DrawFill(x, y, strwidth*dup, BOXCREDITHEIGHT*dup, 28|flags|(bgt<<V_ALPHASHIFT));
-		V_DrawFill(x+dup, y+dup, (strwidth-2)*dup, (BOXCREDITHEIGHT-2)*dup, 30|flags|(bgt<<V_ALPHASHIFT));
+		const UINT8 accent = colortranslations[K_GetHudColor()][7];
+		V_DrawFill(x, y, strwidth*dup, BOXCREDITHEIGHT*dup, accent|flags|(bgt<<V_ALPHASHIFT));
+		V_DrawFill(x+dup, y+dup, (strwidth-2)*dup, (BOXCREDITHEIGHT-2)*dup, accent|flags|(bgt<<V_ALPHASHIFT));
 	}
 
 	if (cursongcredit.trans < NUMTRANSMAPS)

src/i_system.h

@@ -14,6 +14,9 @@
 #ifndef __I_SYSTEM__
 #define __I_SYSTEM__
 
+// page for Saturn issue reports
+#define SATURNISSUEPAGE "https://github.com/Indev450/SRB2Kart-Saturn/issues"
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -209,6 +212,10 @@ static inline void I_HandleInterrupt(void)
 		I_Quit();
 }
 
+/** \brief Open A URL
+ */
+int I_OpenURL(const char *url);
+
 /**	\brief	The I_GetDiskFreeSpace function
 
 	\param	freespace	a INT64 pointer to hold the free space amount

src/i_tcp.c

@@ -1694,6 +1694,7 @@ boolean I_InitTcpNetwork(void)
 			hardware_MAXPACKETLENGTH = MAXPACKETLENGTH;
 		}
 	}
+
 	if (M_CheckProtoParam("ip"))
 	{
 		COM_ImmedExecute(va("exec \"%s"PATHSEP"kartexec.cfg\" -noerror\n", srb2home));

src/k_hud.c

@@ -3941,10 +3941,23 @@ static void K_drawBattleFullscreen(void)
 
 	INT32 x = BASEVIDWIDTH/2;
 	INT32 y = (-64*FRACUNIT) + cardanim; // card animation goes from 0 to 164, 164 is the middle of the screen
-	INT32 splitflags = V_SNAPTOTOP; // I don't feel like properly supporting non-green resolutions, so you can have a misuse of SNAPTO instead
+	INT32 splitflags = splitscreen ? V_SNAPTOTOP : 0; // I don't feel like properly supporting non-green resolutions, so you can have a misuse of SNAPTO instead
 	fixed_t scale = FRACUNIT;
 	boolean drawcomebacktimer = true;	// lazy hack because it's cleaner in the long run.
 
+	// Small hack, if we're not in splitscreen we will not use V_SNAPTOTOP, instead we will just slightly offset
+	// y position so "attack or protect" doesn't slightly show before popping in
+	// We will also reduce this when is closer to finishing so when its at the bottom, the "hack offset" is 0
+	if (!splitscreen)
+	{
+		fixed_t offset = ((vid.height - vid.dup*BASEVIDHEIGHT)/vid.dup) * FRACUNIT/2;
+
+		// cardanim goes from 0 to 164, so when it is 164 offset will be multiplied by (1 - 164/164) = 0 :3
+		offset = FixedMul(offset, FRACUNIT - FixedDiv(cardanim, 164*FRACUNIT));
+
+		y -= offset;
+	}
+
 	if (!LUA_HudEnabled(hud_battlecomebacktimer))
 		drawcomebacktimer = false;
 
@@ -4032,12 +4045,12 @@ static void K_drawBattleFullscreen(void)
 			if (K_UseColorHud()) // Colourized hud
 			{
 				UINT8 *colormap = R_GetTranslationColormap(TC_DEFAULT, K_GetHudColor(), GTC_CACHE);
-				V_DrawFixedPatch(x<<FRACBITS, ty<<FRACBITS, scale, 0, kp_timeoutstickerclr, colormap);
+				V_DrawFixedPatch(x<<FRACBITS, ty<<FRACBITS, scale, splitflags, kp_timeoutstickerclr, colormap);
 			}
 			else
-				V_DrawFixedPatch(x<<FRACBITS, ty<<FRACBITS, scale, 0, kp_timeoutsticker, NULL);
+				V_DrawFixedPatch(x<<FRACBITS, ty<<FRACBITS, scale, splitflags, kp_timeoutsticker, NULL);
 
-			V_DrawKartString(x-txoff, ty, 0, va("%d", stplyr->kartstuff[k_comebacktimer]/TICRATE));
+			V_DrawKartString(x-txoff, ty, splitflags, va("%d", stplyr->kartstuff[k_comebacktimer]/TICRATE));
 		}
 	}
 
@@ -4576,7 +4589,11 @@ static void K_drawCheckpointDebugger(void)
 	else
 		V_DrawString(8, 184, 0, va("Checkpoint: %d / %d (Skip: %d)", stplyr->starpostnum, numstarposts, ((numstarposts/2) + stplyr->starpostnum)));
 
-	V_DrawString(8, 192, 0, va("Waypoint dist: Prev %d, Next %d", stplyr->kartstuff[k_prevcheck], stplyr->kartstuff[k_nextcheck]));
+	// really gnarly hack
+	const INT32 prevcheck = (stprevnextchecks[0] != INT32_MAX) ? stprevnextchecks[0]: stplyr->kartstuff[k_prevcheck];
+	const INT32 nextcheck = (stprevnextchecks[1] != INT32_MAX) ? stprevnextchecks[1]: stplyr->kartstuff[k_nextcheck];
+
+	V_DrawString(8, 192, 0, va("Waypoint dist: Prev %d, Next %d", prevcheck, nextcheck));
 }
 
 // determines if gametype info (laps/bumpers) should be hidden

src/k_kart.c

@@ -34,7 +34,7 @@
 
 
 // extra colourisation stuff
-static CV_PossibleValue_t colorspeedlines_cons_t[] = {{0, "Off"}, {1, "Normal"}, {2, "+Driftcharge"}, {3, "Drift only"}, {0, NULL}};
+static CV_PossibleValue_t colorspeedlines_cons_t[] = {{0, "Off"}, {1, "On"}, {0, NULL}};
 consvar_t cv_coloredspeedlines = {"colorizedspeedlines", "Off", CV_SAVE, colorspeedlines_cons_t, NULL, 0, NULL, NULL, 0, 0, NULL};
 
 consvar_t cv_coloredsneakertrail = {"sneakertrailcolor", "Off", CV_SAVE, CV_OnOff, NULL, 0, NULL, NULL, 0, 0, NULL};
@@ -3522,26 +3522,6 @@ static INT32 K_StairJankFlip(INT32 value)
 	return K_AltFlip(value, 2);
 }
 
-// reset banan and eggbox rollangle when they´re on the ground
-// if not cv_bananthrowroll option "+Onground"
-static void K_ResetBananaRollangle(mobj_t* mo)
-{
-	if (cv_bananthrowroll.value != 1)
-		return;
-
-	if (!mo->rollangle)
-		return;
-
-	if (mo->type != MT_BANANA && mo->type != MT_EGGMANITEM)
-		return;
-
-	// only reset if on ground
-	if (!P_IsObjectOnGround(mo))
-		return;
-
-	mo->rollangle = 0;
-}
-
 #define SLOPEROLL_DIV 3
 void K_RollMobjBySlopes(mobj_t* mo, pslope_t *slope)
 {
@@ -3555,9 +3535,6 @@ void K_RollMobjBySlopes(mobj_t* mo, pslope_t *slope)
 	I_Assert(mo->subsector != NULL);
 	I_Assert(mo->subsector->sector != NULL);
 
-	// kinda stupid but idk where else to put this
-	K_ResetBananaRollangle(mo);
-
 	if (!K_ShouldSlopeRoll(mo))
 	{
 		mo->pitch_sprite = mo->roll_sprite = 0;
@@ -4725,11 +4702,7 @@ void K_RepairOrbitChain(mobj_t *orbit)
 	}
 
 	// Then recount to make sure item amount is correct
-#ifndef COMPAT_VANILLA
-	if (!P_MobjWasRemoved(orbit->target) && orbit->target->player)
-#else
-	if (orbit->target && orbit->target->player)
-#endif
+	if (!P_MobjWasRemovedCompat(orbit->target) && orbit->target->player)
 	{
 		INT32 num = 0;
 
@@ -4746,11 +4719,7 @@ void K_RepairOrbitChain(mobj_t *orbit)
 				prev->movedir = num;
 		}
 
-#ifndef COMPAT_VANILLA
-		if (!P_MobjWasRemoved(orbit->target))
-#else
-		if (orbit->target)
-#endif
+		if (!P_MobjWasRemovedCompat(orbit->target))
 			orbit->target->player->kartstuff[k_itemamount] = num;
 	}
 }
@@ -4897,7 +4866,7 @@ static void K_CalculateBananaSlope(mobj_t *mobj, fixed_t x, fixed_t y, fixed_t z
 // Move the hnext chain!
 static void K_MoveHeldObjects(player_t *player)
 {
-	if (!player->mo)
+	if (P_MobjWasRemovedCompat(player->mo))
 		return;
 
 	if (!player->mo->hnext)
@@ -5493,59 +5462,15 @@ boolean K_PlayerEffectsShouldBlend(player_t *player)
 	return false;
 }
 
-static UINT8 K_GetSpeedLineColor(player_t *player, boolean colorSpeed)
+FUNCINLINE static ATTRINLINE void K_SpawnNormalSpeedLines(player_t *player)
 {
-	UINT8 speedcolor = SKINCOLOR_NONE;
-	const UINT8 playercolor = player->mo->color;
-
-	if (colorSpeed)
-	{
-		if (cv_coloredspeedlines.value != 3)
-			speedcolor = playercolor;
-
-		if (cv_coloredspeedlines.value >= 2 && player->kartstuff[k_driftboost])
-		{
-			if (player->kartstuff[k_driftboost] <= 20)
-				speedcolor = SKINCOLOR_SAPPHIRE;
-			else if (player->kartstuff[k_driftboost] <= 50)
-				speedcolor = SKINCOLOR_RASPBERRY;
-			else if (player->kartstuff[k_driftboost] <= 125)
-				speedcolor = K_RainbowColor();
-
-			if (cv_coloredspeedlines.value == 2)
-				speedcolor = (leveltime & 1) ? playercolor : speedcolor;
-		}
-	}
-
-	if (cv_coloredspeedlines.value != 3)
-	{
-		if (player->kartstuff[k_eggmanexplode])
-		{
-			// Make it red when you have the eggman speed boost
-			speedcolor = SKINCOLOR_RED;
-		}
-		else if (player->kartstuff[k_invincibilitytimer])
-		{
-			speedcolor = playercolor;
-		}
-	}
-
-	return speedcolor;
-}
-
-typedef INT32 (*randomFunc)(INT32 min, INT32 max);
-
-FUNCINLINE static ATTRINLINE void K_SpawnNormalSpeedLines(player_t *player, boolean synched)
-{
-	const randomFunc randomfunc = synched ? P_RandomRange : M_RandomRange;
-
 	fixed_t rand_x;
 	fixed_t rand_y;
 	fixed_t rand_z;
 
-	rand_z = player->mo->z + (player->mo->height/2) + (randomfunc(-20,20) * player->mo->scale);
-	rand_y = player->mo->y + (randomfunc(-36,36) * player->mo->scale);
-	rand_x = player->mo->x + (randomfunc(-36,36) * player->mo->scale);
+	rand_z = player->mo->z + (player->mo->height/2) + (P_RandomRange(-20, 20) * player->mo->scale);
+	rand_y = player->mo->y + (P_RandomRange(-36, 36) * player->mo->scale);
+	rand_x = player->mo->x + (P_RandomRange(-36, 36) * player->mo->scale);
 
 	mobj_t *fast = P_SpawnMobj(rand_x, rand_y, rand_z, MT_FASTLINE);
 
@@ -5553,7 +5478,7 @@ FUNCINLINE static ATTRINLINE void K_SpawnNormalSpeedLines(player_t *player, bool
 	fast->momx = 3*player->mo->momx/4;
 	fast->momy = 3*player->mo->momy/4;
 	fast->momz = 3*player->mo->momz/4;
-	fast->islocal = !synched;
+	//fast->islocal = false;
 	P_SetTarget(&fast->target, player->mo); // easier lua access
 
 	K_MatchGenericExtraFlags(fast, player->mo);
@@ -5564,8 +5489,11 @@ FUNCINLINE static ATTRINLINE void K_SpawnNormalSpeedLines(player_t *player, bool
 
 		if (cv_coloredspeedlines.value)
 		{
-			fast->color = K_GetSpeedLineColor(player, colorSpeed);
-			fast->colorized = true;
+			if (colorSpeed || player->kartstuff[k_invincibilitytimer]) // let invul color them even when players go rather slow
+			{
+				fast->color = player->mo->color;
+				fast->colorized = true;
+			}
 		}
 
 		if (colorSpeed && K_PlayerEffectsShouldBlend(player))
@@ -5594,11 +5522,7 @@ void K_KartPlayerThink(player_t *player, ticcmd_t *cmd)
 	// Speed lines
 	if ((player->kartstuff[k_sneakertimer] || player->kartstuff[k_driftboost] || player->kartstuff[k_startboost]) && player->speed > 0)
 	{
-		K_SpawnNormalSpeedLines(player, true);
-	}
-	else if ((cv_coloredspeedlines.value == 1 || cv_coloredspeedlines.value == 2) && player->kartstuff[k_eggmanexplode]) // gotta love the speedlines calling synched rng :chaosleep:
-	{
-		K_SpawnNormalSpeedLines(player, false);
+		K_SpawnNormalSpeedLines(player);
 	}
 
 	if (player->playerstate == PST_DEAD || player->kartstuff[k_respawn] > 1) // Ensure these are set correctly here
@@ -6220,6 +6144,64 @@ static void K_KartDrift(player_t *player, boolean onground)
 		player->kartstuff[k_brakedrift] = 0;
 }
 
+INT32 stprevnextchecks[2] = {INT32_MAX, INT32_MAX}; // there wont be any map this big, wont there?.....
+
+// K_KartUpdatePosition has a bug where whatever player comes last in the players array
+// gets its distance calculations applied twice
+// since we cannot fix this due to compat concerns (kartstuff is exposed after all)
+// we gotta do this shit hack to atleast fix the debugcheckpoint display
+static void K_KartUpdatePositionDebugHack(player_t *player, player_t *otherplayer)
+{
+	mobj_t *mo;
+	fixed_t pmo;
+	fixed_t ppcd, pncd;
+
+	// dont need this crap
+	if (!cv_kartdebugcheckpoint.value)
+		return;
+
+	// not checking against ourselves
+	if (player != otherplayer)
+		return;
+
+	// dont care if its not first displayplayer
+	// since this is only used for the debug display
+	if (player != &players[displayplayers[0]])
+		return;
+
+	ppcd = pncd = 0;
+	stprevnextchecks[0] = stprevnextchecks[1] = 0;
+
+	// This checks every thing on the map, and looks for MT_BOSS3WAYPOINT (the thing we're using for checkpoint wp's, for now)
+	for (mo = waypointcap; mo != NULL; mo = mo->tracer)
+	{
+		const boolean isprevcheckpointp = mo->health == player->starpostnum;
+		const boolean isnextcheckpointp = mo->health == (player->starpostnum + 1);
+
+		if ((isprevcheckpointp || isnextcheckpointp) && (!mo->movecount || mo->movecount == player->laps+1))
+		{
+			pmo = P_AproxDistance(P_AproxDistance(	mo->x - player->mo->x,
+													mo->y - player->mo->y),
+													mo->z - player->mo->z) / FRACUNIT;
+
+			if (isprevcheckpointp)
+			{
+				stprevnextchecks[0] += pmo;
+				ppcd++;
+			}
+
+			if (isnextcheckpointp)
+			{
+				stprevnextchecks[1] += pmo;
+				pncd++;
+			}
+		}
+	}
+
+	if (ppcd > 1) stprevnextchecks[0] /= ppcd;
+	if (pncd > 1) stprevnextchecks[1] /= pncd;
+}
+
 //
 // K_KartUpdatePosition
 //
@@ -6231,6 +6213,9 @@ void K_KartUpdatePosition(player_t *player)
 	fixed_t pmo, imo;
 	mobj_t *mo;
 
+	// always reset this
+	stprevnextchecks[0] = stprevnextchecks[1] = INT32_MAX;
+
 	if (player->spectator || !player->mo)
 		return;
 
@@ -6243,11 +6228,12 @@ void K_KartUpdatePosition(player_t *player)
 
 		if (G_RaceGametype())
 		{
-			if ((((players[i].starpostnum) + (numstarposts + 1) * players[i].laps) >
-				((player->starpostnum) + (numstarposts + 1) * player->laps)))
+			const INT32 iplayerlaps = (players[i].starpostnum + (numstarposts + 1) * players[i].laps);
+			const INT32 pplayerlaps = (player->starpostnum + (numstarposts + 1) * player->laps);
+
+			if (iplayerlaps > pplayerlaps)
 				position++;
-			else if (((players[i].starpostnum) + (numstarposts+1)*players[i].laps) ==
-				((player->starpostnum) + (numstarposts+1)*player->laps))
+			else if (iplayerlaps == pplayerlaps)
 			{
 				ppcd = pncd = ipcd = incd = 0;
 
@@ -6330,6 +6316,9 @@ void K_KartUpdatePosition(player_t *player)
 					if (players[i].starposttime < player->starposttime)
 						position++;
 				}
+
+				// stupid hack
+				K_KartUpdatePositionDebugHack(player, &players[i]);
 			}
 		}
 		else if (G_BattleGametype())
@@ -6599,7 +6588,7 @@ static void K_PlayerItemThink(player_t *player, boolean onground, boolean oldatt
 					{
 						mo = P_SpawnMobj(player->mo->x, player->mo->y, player->mo->z, MT_BANANA_SHIELD);
 
-						if (!mo)
+						if (P_MobjWasRemovedCompat(mo))
 						{
 							player->kartstuff[k_itemamount] = moloop;
 							break;
@@ -6660,7 +6649,7 @@ static void K_PlayerItemThink(player_t *player, boolean onground, boolean oldatt
 						newangle = (player->mo->angle + ANGLE_157h) + FixedAngle(((360 / player->kartstuff[k_itemamount]) * moloop) << FRACBITS) + ANGLE_90;
 						mo = P_SpawnMobj(player->mo->x, player->mo->y, player->mo->z, MT_ORBINAUT_SHIELD);
 
-						if (!mo)
+						if (P_MobjWasRemovedCompat(mo))
 						{
 							player->kartstuff[k_itemamount] = moloop;
 							break;
@@ -6703,7 +6692,7 @@ static void K_PlayerItemThink(player_t *player, boolean onground, boolean oldatt
 						newangle = (player->mo->angle + ANGLE_157h) + FixedAngle(((360 / player->kartstuff[k_itemamount]) * moloop) << FRACBITS) + ANGLE_90;
 						mo = P_SpawnMobj(player->mo->x, player->mo->y, player->mo->z, MT_JAWZ_SHIELD);
 
-						if (!mo)
+						if (P_MobjWasRemovedCompat(mo))
 						{
 							player->kartstuff[k_itemamount] = moloop;
 							break;
@@ -7066,6 +7055,28 @@ void K_MoveKartPlayer(player_t *player, boolean onground)
 	// "Stair jank" visuals akin to RR
 	if (cv_stairjank.value && player->stairjank > 0)
 	{
+		// only spawn em once
+		if (player->stairjank > 8)
+		{
+			// 90 degrees to direction you're facing
+			fixed_t dirx = -FINESINE(player->mo->angle>>ANGLETOFINESHIFT);
+			fixed_t diry = FINECOSINE(player->mo->angle>>ANGLETOFINESHIFT);
+			fixed_t offset = player->mo->radius;
+
+			dirx = K_AltFlip(-dirx, 4);
+			diry = K_AltFlip(-diry, 4);
+
+			mobj_t * spark = P_SpawnMobj(player->mo->x + FixedMul(dirx, offset), player->mo->y + FixedMul(diry, offset), player->mo->z, MT_DRIFTDUST);
+			spark->momx = FixedMul(dirx, FRACUNIT) + (6 + ((int)leveltime % 5))*(player->mo->momx)/10;
+			spark->momy = FixedMul(diry, FRACUNIT) + (6 + ((int)leveltime % 5))*(player->mo->momy)/10;
+			spark->momz = 5*FRACUNIT;
+			spark->scale = mapobjectscale/5;
+			spark->destscale = mapobjectscale/2;
+			spark->islocal = true;
+			spark->color = SKINCOLOR_WHITE;
+			P_SetTarget(&spark->target, player->mo);
+		}
+
 		player->mo->temprollangle += K_StairJankFlip(ANGLE_11hh / 2 / (17 / player->stairjank)); // TODO: make strength adjustable?
 	}
 

src/k_kart.h

@@ -32,6 +32,8 @@ extern consvar_t cv_bananajitter;
 extern consvar_t cv_bananthrowroll;
 extern consvar_t cv_airsparks;
 
+extern INT32 stprevnextchecks[2];
+
 boolean K_IsPlayerLosing(player_t *player);
 boolean K_IsPlayerWanted(player_t *player);
 INT32 K_KartGetItemOdds(UINT8 pos, SINT8 item, fixed_t mashed, boolean spbrush);

src/lua_baselib.c

@@ -3055,58 +3055,44 @@ static int lib_kSetHyuCountdown(lua_State *L)
 
 static int lib_gSetPlayerGamepadIndicatorColor(lua_State *L)
 {
-	INT32 player = -1;
-	player_t *plr = *((player_t **)luaL_checkudata(L, 1, META_PLAYER));    // retrieve player
+	INT32 pnum = -1;
+	player_t *player = *((player_t **)luaL_checkudata(L, 1, META_PLAYER));    // retrieve player
 	UINT8 color = (UINT8)luaL_checkinteger(L, 2); // skincolor
 
-	if (!plr)
+	if (!player)
 		return LUA_ErrInvalid(L, "player_t");
 
 	if (color >= MAXTRANSLATIONS)
 		return luaL_error(L, "color %d out of range (0 - %d).", color, MAXTRANSLATIONS-1);
 
-	for (int i = 0; i < MAXSPLITSCREENPLAYERS; ++i)
-	{
-		if (plr - players == displayplayers[i])
-		{
-			player = i;
-			break;
-		}
-	}
+	pnum = P_GetLocalPlayerNumForPlayer(player);
 
 	// Not a local player
-	if (player == -1) return 0;
+	if (pnum == -1) return 0;
 
 	// pls update with color 0 when youre done with changing led stuff so it can get player color again
-	G_SetPlayerGamepadIndicatorColor(player, color);
+	G_SetPlayerGamepadIndicatorColor(pnum, color);
 
 	return 0;
 }
 
 static int lib_gPlayerDeviceRumble(lua_State *L)
 {
-	INT32 player = -1;
-	player_t *plr = *((player_t **)luaL_checkudata(L, 1, META_PLAYER));    // retrieve player
+	INT32 pnum = -1;
+	player_t *player = *((player_t **)luaL_checkudata(L, 1, META_PLAYER));    // retrieve player
 	UINT16 low_strength = (UINT16)luaL_checkinteger(L, 2); // low frequency rumble motor strenght
 	UINT16 high_strength = (UINT16)luaL_checkinteger(L, 3); // high frequency rumble motor strenght
 	UINT32 duration = (UINT32)luaL_optinteger(L, 4, 84); // duration of rumble in ms
 
-	if (!plr)
+	if (!player)
 		return LUA_ErrInvalid(L, "player_t");
 
-	for (int i = 0; i < MAXSPLITSCREENPLAYERS; ++i)
-	{
-		if (plr - players == displayplayers[i])
-		{
-			player = i;
-			break;
-		}
-	}
+	pnum = P_GetLocalPlayerNumForPlayer(player);
 
 	// Not a local player
-	if (player == -1) return 0;
+	if (pnum == -1) return 0;
 
-	G_PlayerDeviceRumble(player, low_strength, high_strength, duration);
+	G_PlayerDeviceRumble(pnum, low_strength, high_strength, duration);
 
 	return 0;
 }

src/lua_hooklib.c

@@ -25,7 +25,6 @@
 #include "lua_libs.h"
 #include "lua_hook.h"
 #include "lua_hud.h" // hud_running errors
-#include "lua_profile.h"
 
 /* =========================================================================
                                   ABSTRACTION
@@ -446,54 +445,11 @@ FUNCINLINE static ATTRINLINE void get_hook_from_table(Hook_State *hook, int n)
 	lua_getref(gL, hookRefs[hook->id]);
 }
 
-static int pcall(Hook_State *hook)
-{
-	return lua_pcall(gL, hook->values, hook->results, EINDEX);
-}
-
-static const char *hook_name(Hook_State *hook)
-{
-	if (hud_running)
-	{
-		return hudHookNames[hook->hook_type];
-	}
-	else if (hook->string)
-	{
-		return stringHookNames[hook->hook_type];
-	}
-	//else if (hook->mobj_type > 0)
-	else if (hook->mobj_type != NONMOHOOK)
-	{
-		return mobjHookNames[hook->hook_type];
-	}
-	else
-	{
-		return hookNames[hook->hook_type];
-	}
-}
-
-static int pcall_timed_or_untimed(Hook_State *hook)
-{
-	if (!hud_running && cv_lua_profile.value > 0)
-	{
-		lua_timer_t *timer = LUA_BeginFunctionTimer(gL, -1 - hook->values, hook_name(hook));
-		int k = pcall(hook);
-		LUA_EndFunctionTimer(timer);
-
-		return k;
-	}
-	else
-	{
-		return pcall(hook);
-	}
-}
-
 static int call_single_hook_no_copy(Hook_State *hook)
 {
 	hook_important = hook->important;
 
-	//if (lua_pcall(gL, hook->values, hook->results, EINDEX) == 0)
-	if (pcall_timed_or_untimed(hook) == 0)
+	if (lua_pcall(gL, hook->values, hook->results, EINDEX) == 0)
 	{
 		if (hook->results > 0)
 		{
@@ -574,10 +530,48 @@ static int call_string_hooks(Hook_State *hook)
 	return calls;
 }
 
+FUNCINLINE static ATTRINLINE int call_mobj_type_hooks(Hook_State *hook, mobjtype_t mobj_type)
+{
+	static UINT8 seen = 0; // so we dont have to check all this shit constantly
+	int numCalls = call_mapped(hook, &mobjHookIds[mobj_type][hook->hook_type]);
+
+	if (!seen && numCalls > 0 && mobj_type == MT_NULL && (
+		   hook->hook_type == MOBJ_HOOK(MobjThinker    )
+		|| hook->hook_type == MOBJ_HOOK(MobjCollide    )
+		|| hook->hook_type == MOBJ_HOOK(MobjMoveCollide)
+		|| hook->hook_type == MOBJ_HOOK(MobjFuse       )
+		|| hook->hook_type == MOBJ_HOOK(MobjThinker    )
+		|| hook->hook_type == MOBJ_HOOK(BossThinker    )
+	))
+	{
+		seen = 1;
+		CONS_Alert(
+			CONS_WARNING, "%s\n", va(
+			"%s hooks not attached to a specific mobj type may cause performance issues!",
+			mobjHookNames[hook->hook_type])
+		);
+
+		// print which script triggered it, ty indev <3
+		for (int k = 0; k < mobjHookIds[mobj_type][hook->hook_type].numHooks; ++k)
+		{
+			lua_getref(gL, hookRefs[mobjHookIds[mobj_type][hook->hook_type].ids[k].id]);
+
+			lua_Debug ar;
+			lua_getinfo(gL, ">S", &ar);
+
+			CONS_Printf("%s:%d\n", ar.short_src, ar.linedefined);
+		}
+	}
+
+	return numCalls;
+}
+
+/*
 FUNCINLINE static ATTRINLINE int call_mobj_type_hooks(Hook_State *hook, mobjtype_t mobj_type)
 {
 	return call_mapped(hook, &mobjHookIds[mobj_type][hook->hook_type]);
 }
+*/
 
 static int call_hooks
 (

src/lua_infolib.c

@@ -22,8 +22,7 @@
 #include "lua_script.h"
 #include "lua_libs.h"
 #include "lua_hud.h" // hud_running errors
-#include "lua_hook.h" // hook_cmd_running errors
-#include "lua_profile.h"
+#include "lua_hook.h"	// cmd errors
 
 boolean LUA_CallAction(enum actionnum actionnum, mobj_t *actor);
 state_t *astate = NULL;
@@ -111,10 +110,7 @@ static void A_Lua(mobj_t *actor)
 	LUA_PushUserdata(gL, actor, META_MOBJ);
 	lua_pushinteger(gL, var1);
 	lua_pushinteger(gL, var2);
-
-	lua_timer_t *timer = LUA_BeginFunctionTimer(gL, -4, "A_Lua");
 	LUA_Call(gL, 3, 0, 1);
-	LUA_EndFunctionTimer(timer);
 
 	lua_pop(gL, 1); // pop error handler
 

src/lua_profile.cpp

@@ -1,264 +0,0 @@
-// DR. ROBOTNIK'S RING RACERS
-//-----------------------------------------------------------------------------
-// Copyright (C) 2025 by James Robert Roman
-// Copyright (C) 2025 by Kart Krew
-//
-// This program is free software distributed under the
-// terms of the GNU General Public License, version 2.
-// See the 'LICENSE' file for more details.
-//-----------------------------------------------------------------------------
-
-#include "screen.h"
-#include <algorithm>
-#include <cstddef>
-#include <unordered_map>
-#include <string>
-#include <string_view>
-#include <vector>
-
-extern "C" {
-#include "blua/lua.h"
-};
-
-#include "v_video.h"
-
-#include "command.h"
-#include "doomtype.h"
-#include "i_system.h"
-#include "lua_profile.h"
-#include "m_perfstats.h"
-
-extern "C" consvar_t cv_lua_profile;
-
-namespace
-{
-
-precise_t g_time_reference;
-int g_tics_counted;
-
-double g_running_tic_time;
-double g_avg_tic_time;
-
-bool g_invalid;
-
-}; // namespace
-
-struct lua_timer_t
-{
-	struct Stat
-	{
-		double calls = 0;
-		double time = 0.0;
-	};
-
-	Stat running, avg;
-};
-
-namespace
-{
-
-std::unordered_map<std::string, lua_timer_t> g_tic_timers;
-
-}; // namespace
-
-lua_timer_t* LUA_BeginFunctionTimer(lua_State* L, int fn_idx, const char* name)
-{
-	lua_Debug ar;
-
-	lua_pushvalue(L, fn_idx);
-	lua_getinfo(L, ">S", &ar);
-
-	auto label = [&]
-	{
-		using sv = std::string_view;
-		sv view{ar.source};
-
-		switch (view.front())
-		{
-		case '@': // file
-			if (std::size_t p = view.rfind('/'); p != sv::npos) // lump or base
-			{
-				return view.substr(p + 1);
-			}
-			break;
-
-		case '=': // ??
-			view.remove_prefix(1);
-			break;
-		}
-
-		return view;
-	};
-
-	// i sure hope this std::string mess is fine...
-	auto [it, ins] = g_tic_timers.try_emplace(std::string(va("%s:%d (%s)", std::string(label()).c_str(), ar.linedefined, name)));
-	auto& [key, timer] = *it;
-
-	g_time_reference = I_GetPreciseTime();
-
-	return &timer;
-}
-
-void LUA_EndFunctionTimer(lua_timer_t* timer)
-{
-	precise_t t = I_GetPreciseTime() - g_time_reference;
-	double precision = I_GetPrecisePrecision();
-
-	timer->running.time += t / precision;
-	timer->running.calls += 1.0;
-}
-
-void LUA_ResetTicTimers(void)
-{
-	if (cv_lua_profile.value <= 0)
-	{
-		return;
-	}
-
-	if (g_tics_counted < cv_lua_profile.value)
-	{
-		g_tics_counted++;
-
-		double precision = I_GetPrecisePrecision();
-		g_running_tic_time += ps_prevtictime.value.p / precision;
-	}
-	else
-	{
-		double counted = g_tics_counted;
-
-		for (auto& [key, timer] : g_tic_timers)
-		{
-			timer.avg = {timer.running.calls / counted, timer.running.time / counted};
-			timer.running = {};
-		}
-
-		g_avg_tic_time = g_running_tic_time / counted;
-		g_running_tic_time = 0.0;
-
-		g_tics_counted = 1;
-
-		g_invalid = false;
-	}
-}
-
-void LUA_RenderTimers(void)
-{
-	constexpr int kRowHeight = 4;
-	float row_y = kRowHeight;
-
-	// pretty much what the whole srb2::Draw does lol
-	auto draw_row = [](float x, float y, INT32 flags, const char *str)
-	{
-		V_DrawSmallStringAtFixed(
-			FloatToFixed(x),
-			FloatToFixed(y),
-			V_MONOSPACE|V_ALLOWLOWERCASE|flags,
-			str
-		);
-	};
-
-	draw_row(0.f, 0.f, 0, va("-- AVERAGES PER TIC (over %d tics) --", cv_lua_profile.value));
-
-	if (g_invalid)
-	{
-		draw_row(0.f, row_y, V_GRAYMAP, "  <Data pending>");
-		return;
-	}
-
-	std::vector<decltype(g_tic_timers)::iterator> view;
-	view.reserve(g_tic_timers.size());
-
-	auto color_flag = [](double t)
-	{
-		if (t < 10.0)
-		{
-			return V_GRAYMAP;
-		}
-		else if (t >= 100.0)
-		{
-			return V_YELLOWMAP;
-		}
-		else
-		{
-			return 0;
-		}
-	};
-
-	{
-		double cum = 0.0;
-
-		for (auto it = g_tic_timers.begin(); it != g_tic_timers.end(); ++it)
-		{
-			auto& [key, timer] = *it;
-
-			cum += timer.avg.time;
-
-			if (timer.avg.time > 0.0)
-			{
-				view.push_back(it);
-			}
-		}
-
-		{
-			const INT32 tally_flags = color_flag(cum * 1'000'000.0);
-
-			draw_row(0.f, row_y, tally_flags, va("%8.2f us - TOTAL", cum * 1'000'000.0));
-			draw_row(0.f, row_y + kRowHeight, tally_flags, va("%8.2f ms", cum * 1000.0));
-
-			// dont need to show this if we didnt capture over time
-			// this would just show nan or inf anyways
-			if (std::fpclassify(g_avg_tic_time) != FP_ZERO)
-			{
-				draw_row(0.f, row_y + kRowHeight * 2, tally_flags, va(
-				"%8.2f%% overhead (%.2f / %.2f) <-- not counting rendering time",
-																		(cum / g_avg_tic_time) * 100.0,
-																		(cum * (double)TICRATE),
-																		(g_avg_tic_time * (double)TICRATE)
-				));
-			}
-		}
-
-		row_y += kRowHeight * 4;
-	}
-
-	std::sort(
-		view.rbegin(),
-		view.rend(),
-		[](auto a, auto b)
-		{
-			auto& [k1, t1] = *a;
-			auto& [k2, t2] = *b;
-			return t1.avg.time < t2.avg.time;
-		}
-	);
-
-	for (auto it : view)
-	{
-		auto& [key, timer] = *it;
-
-		double t = timer.avg.time * 1'000'000.0;
-
-		draw_row(0.f, row_y, color_flag(t), va(
-			"%8.2f us %8.2f calls - %s",
-			t,
-			timer.avg.calls,
-			key.c_str()
-		));
-
-		row_y += kRowHeight;
-
-		// FIXME this is all ugly and sucks
-		if (row_y >= BASEVIDHEIGHT)
-			break;
-	}
-}
-
-extern "C" void lua_profile_OnChange(void)
-{
-	g_invalid = true;
-
-	if (cv_lua_profile.value == 0)
-	{
-		g_tic_timers = {};
-	}
-}

src/lua_profile.h

@@ -1,38 +0,0 @@
-// DR. ROBOTNIK'S RING RACERS
-//-----------------------------------------------------------------------------
-// Copyright (C) 2025 by James Robert Roman
-// Copyright (C) 2025 by Kart Krew
-//
-// This program is free software distributed under the
-// terms of the GNU General Public License, version 2.
-// See the 'LICENSE' file for more details.
-//-----------------------------------------------------------------------------
-
-#ifndef lua_profile_h
-#define lua_profile_h
-
-#include "blua/lua.h"
-#include "doomtype.h"
-//#include "typedef.h"
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-struct lua_timer_t;
-typedef struct lua_timer_t lua_timer_t;
-
-void LUA_ResetTicTimers(void);
-
-lua_timer_t *LUA_BeginFunctionTimer(lua_State *L, int fn_idx, const char *name);
-void LUA_EndFunctionTimer(lua_timer_t *timer);
-
-void LUA_RenderTimers(void);
-
-void lua_profile_OnChange(void);
-
-#ifdef __cplusplus
-} // extern "C"
-#endif
-
-#endif/*lua_profile_h*/

src/m_cheat.c

@@ -766,7 +766,7 @@ boolean OP_FreezeObjectplace(void)
 	if (!objectplacing)
 		return false;
 
-	if ((maptol & TOL_NIGHTS) && (players[consoleplayer].pflags & PF_NIGHTSMODE))
+	if (nightsmode && nightsplayer(&players[consoleplayer]))
 		return false;
 
 	return true;
@@ -1049,7 +1049,7 @@ void Command_ObjectPlace_f(void)
 	{
 		objectplacing = true;
 
-		if ((players[0].pflags & PF_NIGHTSMODE))
+		if (nightsplayer(&players[0]))
 			return;
 
 		if (!COM_CheckParm("-silent"))
@@ -1120,7 +1120,7 @@ void Command_ObjectPlace_f(void)
 
 		// Don't touch the NiGHTS Objectplace stuff.
 		// ... or if the mo mysteriously vanished.
-		if (!players[0].mo || (players[0].pflags & PF_NIGHTSMODE))
+		if (!players[0].mo || nightsplayer(&players[0]))
 			return;
 
 		// If still in dummy state, get out of it.

src/m_menu.c

@@ -25,6 +25,7 @@
 #include "d_netcmd.h"
 #include "d_clisrv.h"
 #include "i_net.h"
+#include "i_system.h"
 #include "console.h"
 #include "r_fps.h"
 #include "r_local.h"
@@ -276,6 +277,8 @@ static void M_ConfirmTeamChange(INT32 choice);
 static void M_ConfirmSpectateChange(INT32 choice);
 static void M_QuitSRB2(INT32 choice);
 
+static void M_SaturnReportIssue(INT32 choice);
+
 // Single Player
 static void M_TimeAttack(INT32 choice);
 static boolean M_QuitTimeAttackMenu(void);
@@ -4247,6 +4250,14 @@ static boolean M_HandleReplayHutQuery(INT32 choice)
 	char tmp[MAXREPLAYQUERY+1];
 	memcpy(tmp, replayqueryinput_buffer, MAXREPLAYQUERY+1);
 
+	Lock_search_state();
+	if (!replaynamesloaded)
+	{
+		Unlock_search_state();
+		return false;
+	}
+	Unlock_search_state();
+
 	if (M_TextInputHandle(&replayqueryinput, choice))
 	{
 		S_StartSound(NULL, sfx_menu1);
@@ -9037,15 +9048,15 @@ static boolean M_QuitMultiPlayerMenu(void)
 	if (!fastcmp(setupm_name, setupm_cvname->string))
 	{
 		// remove trailing whitespaces
-		for (l = strlen(setupm_name)-1;
-		    (signed)l >= 0 && setupm_name[l] ==' '; l--)
-			setupm_name[l] =0;
-		COM_BufAddText(va("%s \"%s\"\n",setupm_cvname->name,setupm_name));
+		l = strlen(setupm_name)-1;
+		for (;(signed)l >= 0 && setupm_name[l] ==' '; l--)
+			setupm_name[l] = 0;
+		COM_BufAddText(va("%s \"%s\"\n", setupm_cvname->name, setupm_name));
 	}
 
 	// you know what? always putting these in the buffer won't hurt anything.
-	COM_BufAddText(va("%s \"%s\"\n",setupm_cvskin->name,skins[setupm_fakeskin].name));
-	COM_BufAddText(va("%s %d\n",setupm_cvcolor->name,setupm_fakecolor));
+	COM_BufAddText(va("%s \"%s\"\n", setupm_cvskin->name, skins[setupm_fakeskin].name));
+	COM_BufAddText(va("%s %d\n", setupm_cvcolor->name, setupm_fakecolor));
 
 	return true;
 }
@@ -10581,6 +10592,20 @@ static void M_QuitSRB2(INT32 choice)
 	M_StartMessage(quitmsg[M_RandomKey(NUM_QUITMESSAGES)], M_QuitResponse, MM_YESNO);
 }
 
+// ===========
+// SATURN MENU
+// ===========
+
+static void M_SaturnReportIssue(INT32 choice)
+{
+	(void)choice;
+	int url = I_OpenURL(SATURNISSUEPAGE);
+
+	// SDL_OpenURL unsupported or failed
+	if (url == -1)
+		M_StartMessage(M_GetText("Failed to Open Web Page.\nPlease open the following page in your web browser:\n\n" SATURNISSUEPAGE "\n\n(Press a key)\n"), NULL, MM_NOTHING);
+}
+
 #ifdef HAVE_DISCORDRPC
 
 // =====================================================================

src/m_menudefs.c

@@ -36,6 +36,7 @@ static menu_t SP_TimeAttackDef, SP_ReplayDef, SP_GuestReplayDef, SP_GhostDef;
 menu_t OP_ControlsDef, OP_AllControlsDef;
 menu_t OP_MouseOptionsDef;
 menu_t OP_Joystick1Def, OP_Joystick2Def, OP_Joystick3Def, OP_Joystick4Def;
+menu_t OP_Joystick1RumbleDef, OP_Joystick2RumbleDef, OP_Joystick3RumbleDef, OP_Joystick4RumbleDef;
 
 // Custom cvar menu
 menu_t OP_CustomCvarMenuDef;
@@ -725,6 +726,14 @@ static const char* OP_AllControlsTooltips[sizeof(OP_AllControlsMenu)/sizeof(OP_A
 	// The rest is null, for now
 };
 
+// i really do not feel like messing with setup routines
+// and macro preprocessor cannot eval maths for string shit like this :chaosleep:
+#define RUMBDEF_0 OP_Joystick1RumbleDef
+#define RUMBDEF_1 OP_Joystick2RumbleDef
+#define RUMBDEF_2 OP_Joystick3RumbleDef
+#define RUMBDEF_3 OP_Joystick4RumbleDef
+#define RUMBDEF(x) RUMBDEF_##x
+
 #define OP_JOYMENU(pnum)                                                                         \
 	{IT_HEADER, NULL, "Gameplay Controls", NULL, 7},                                             \
 	{IT_STRING | IT_CVAR,  NULL, "Aim Forward/Back"           , &cv_aimaxis[pnum]        ,  15}, \
@@ -745,9 +754,8 @@ static const char* OP_AllControlsTooltips[sizeof(OP_AllControlsMenu)/sizeof(OP_A
 	{IT_STRING | IT_CVAR,  NULL, "X deadzone"                 , &cv_xdeadzone[pnum]      , 100}, \
 	{IT_STRING | IT_CVAR,  NULL, "Y deadzone"                 , &cv_ydeadzone[pnum]      , 105}, \
 	{IT_HEADER, NULL, "Miscellaneous", NULL, 112},                                               \
-	{IT_STRING | IT_CVAR,  NULL, "Controller Rumble"          , &cv_rumble[pnum]         , 120}, \
-	{IT_STRING | IT_CVAR,  NULL, "Controller Rumble Strength" , &cv_rumblestrength[pnum] , 125}, \
-	{IT_STRING | IT_CVAR,  NULL, "Set LED to Player color"    , &cv_gamepadled[pnum]     , 130},
+	{IT_SUBMENU|IT_STRING, NULL, "Rumble Options..."          , &RUMBDEF(pnum)           , 120}, \
+	{IT_STRING | IT_CVAR,  NULL, "Set LED to Player color"    , &cv_gamepadled[pnum]     , 125},
 
 static menuitem_t OP_Joystick1Menu[] =
 {
@@ -773,6 +781,46 @@ static menuitem_t OP_Joystick4Menu[] =
 	OP_JOYMENU(3)
 };
 
+#undef RUMBDEF
+#undef RUMBDEF_0
+#undef RUMBDEF_1
+#undef RUMBDEF_2
+#undef RUMBDEF_3
+
+// FIXME: stair jank rumble should be greyed out if its disabled, but menus suck butt!
+#define OP_JOYRUMBLEMENU(pnum)                                                                       \
+	{IT_HEADER, NULL, "Global", NULL, 7},                                                            \
+	{IT_STRING | IT_CVAR,  NULL, "Controller Rumble"          , &cv_rumble[pnum]              , 15}, \
+	{IT_STRING | IT_CVAR,  NULL, "Controller Rumble Strength" , &cv_rumble_strength[pnum]     , 20}, \
+	{IT_HEADER, NULL, "Rumble Types", NULL, 27},                                                     \
+	{IT_STRING | IT_CVAR,  NULL, "Spinout"                    , &cv_rumble_spinout[pnum]      , 35}, \
+	{IT_STRING | IT_CVAR,  NULL, "Sneaker Boost"              , &cv_rumble_sneakerboost[pnum] , 40}, \
+	{IT_STRING | IT_CVAR,  NULL, "Offroad"                    , &cv_rumble_offroad[pnum]      , 45}, \
+	{IT_STRING | IT_CVAR,  NULL, "Banana Dragging"            , &cv_rumble_bananadrag[pnum]   , 50}, \
+	{IT_STRING | IT_CVAR,  NULL, "Stair Jank"                 , &cv_rumble_stairjank[pnum]    , 55}, \
+	{IT_STRING | IT_CVAR,  NULL, "Brake Drift"                , &cv_rumble_brakedrift[pnum]   , 60}, \
+	{IT_STRING | IT_CVAR,  NULL, "Drift Charge"               , &cv_rumble_driftcharge[pnum]  , 65}, \
+
+static menuitem_t OP_Joystick1RumbleMenu[] =
+{
+	OP_JOYRUMBLEMENU(0)
+};
+
+static menuitem_t OP_Joystick2RumbleMenu[] =
+{
+	OP_JOYRUMBLEMENU(1)
+};
+
+static menuitem_t OP_Joystick3RumbleMenu[] =
+{
+	OP_JOYRUMBLEMENU(2)
+};
+
+static menuitem_t OP_Joystick4RumbleMenu[] =
+{
+	OP_JOYRUMBLEMENU(3)
+};
+
 static menuitem_t OP_JoystickSetMenu[] =
 {
 	{IT_CALL | IT_NOTHING, "None", NULL, M_AssignJoystick,  LINEHEIGHT+5},
@@ -1736,6 +1784,7 @@ static menuitem_t OP_SaturnMenu[] =
 	{IT_SUBMENU|IT_STRING,	NULL,	"Saturn Hud...", 					&OP_SaturnHudDef,		   	140},
 	{IT_SUBMENU|IT_STRING,	NULL,	"Sprite Distortion...", 			&OP_PlayerDistortDef,	   	145},
 	{IT_SUBMENU|IT_STRING,	NULL,	"Saturn Credits", 					&OP_SaturnCreditsDef,	   	150}, // uwu
+	{IT_STRING|IT_CALL,     NULL,   "Report an Issue",                   M_SaturnReportIssue,       155}
 };
 
 static const char* OP_SaturnTooltips[] =
@@ -1759,6 +1808,7 @@ static const char* OP_SaturnTooltips[] =
 	"Options for Saturn specific HUD things.",
 	"Options for sprite distortion effects.",
 	"See the people who helped make this project possible!",
+	"Noticed a bug, have a Suggestion or other Feedback?\nFeel free to tell us!",
 };
 
 enum
@@ -1780,6 +1830,7 @@ enum
 	sm_hud,
 	sm_distortionmenu,
 	sm_credits,
+	sm_issue,
 };
 
 static menuitem_t OP_PlayerDistortMenu[] =
@@ -2530,6 +2581,11 @@ menu_t OP_Joystick2Def    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick2Menu, &OP
 menu_t OP_Joystick3Def    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick3Menu, &OP_AllControlsDef, 30, 36, NULL);
 menu_t OP_Joystick4Def    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick4Menu, &OP_AllControlsDef, 30, 36, NULL);
 
+menu_t OP_Joystick1RumbleDef    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick1RumbleMenu, &OP_Joystick1Def, 30, 36, NULL);
+menu_t OP_Joystick2RumbleDef    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick2RumbleMenu, &OP_Joystick2Def, 30, 36, NULL);
+menu_t OP_Joystick3RumbleDef    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick3RumbleMenu, &OP_Joystick3Def, 30, 36, NULL);
+menu_t OP_Joystick4RumbleDef    = DEFAULTSCROLLSTYLE("M_CONTRO", OP_Joystick4RumbleMenu, &OP_Joystick4Def, 30, 36, NULL);
+
 menu_t OP_JoystickSetDef  =
 {
 	"M_CONTRO",

src/m_perfstats.c

@@ -47,7 +47,6 @@ struct perfstatrow {
 static ps_metric_t ps_frametime = {0};
 
 ps_metric_t ps_tictime = {0};
-ps_metric_t ps_prevtictime = {0};
 
 ps_metric_t ps_playerthink_time = {0};
 ps_metric_t ps_thinkertime = {0};

src/m_perfstats.h

@@ -36,7 +36,6 @@ typedef struct
 #define PS_STOP_TIMING(metric) metric.value.p = I_GetPreciseTime() - metric.value.p
 
 extern ps_metric_t ps_tictime;
-extern ps_metric_t ps_prevtictime;
 
 extern ps_metric_t ps_playerthink_time;
 extern ps_metric_t ps_thinkertime;

src/p_enemy.c

@@ -250,7 +250,8 @@ boolean P_Move(mobj_t *actor, fixed_t speed)
 	I_Assert(movedir < NUMDIRS);
 
 	tryx = actor->x + FixedMul(speed*xspeed[movedir], actor->scale);
-	if (UNLIKELY(twodlevel || actor->flags2 & MF2_TWOD))
+
+	if (twodmo(actor))
 		tryy = actor->y;
 	else
 		tryy = actor->y + FixedMul(speed*yspeed[movedir], actor->scale);
@@ -328,7 +329,7 @@ void P_NewChaseDir(mobj_t *actor)
 	else
 		d[1] = DI_NODIR;
 
-	if (UNLIKELY(twodlevel || actor->flags2 & MF2_TWOD))
+	if (twodmo(actor))
 		d[2] = DI_NODIR;
 	if (deltay < -FixedMul(10*FRACUNIT, actor->scale))
 		d[2] = DI_SOUTH;
@@ -2762,10 +2763,10 @@ void A_Invincibility(void *thing)
 	{
 		S_StopMusic();
 
-		if (UNLIKELY(mariomode))
+		if (mariomode)
 			G_GhostAddColor((INT32) (player - players), GHC_INVINCIBLE);
 
-		S_ChangeMusicInternal((UNLIKELY(mariomode)) ? "minvnc" : "invinc", false);
+		S_ChangeMusicInternal(mariomode ? "minvnc" : "invinc", false);
 	}
 }
 
@@ -4359,7 +4360,7 @@ void A_MouseThink(void *thing)
 		|| (actor->eflags & MFE_VERTICALFLIP && actor->z + actor->height == actor->ceilingz))
 		&& !actor->reactiontime)
 	{
-		if (UNLIKELY(twodlevel || actor->flags2 & MF2_TWOD))
+		if (twodmo(actor))
 		{
 			if (P_RandomChance(FRACUNIT/2))
 				actor->angle += ANGLE_180;
@@ -10878,10 +10879,7 @@ void A_BrakLobShot(void *thing)
 		return; // Don't even bother if we've got nothing to aim at.
 
 	// Look up actor's current gravity situation
-	if (actor->subsector->sector->gravity)
-		g = FixedMul(gravity,(FixedDiv(*actor->subsector->sector->gravity>>FRACBITS, 1000)));
-	else
-		g = gravity;
+	g =  P_GetSectorGravity(actor->subsector->sector);
 
 	// Look up distance between actor and its target
 	x = P_AproxDistance(actor->target->x - actor->x, actor->target->y - actor->y);
@@ -10996,10 +10994,7 @@ void A_NapalmScatter(void *thing)
 		airtime = 16<<FRACBITS;
 
 	// Look up actor's current gravity situation
-	if (actor->subsector->sector->gravity)
-		g = FixedMul(gravity,(FixedDiv(*actor->subsector->sector->gravity>>FRACBITS, 1000)));
-	else
-		g = gravity;
+	g = P_GetSectorGravity(actor->subsector->sector);
 
 	// vy = (g*(airtime-1))/2
 	vy = FixedMul(g,(airtime-(1<<FRACBITS)))>>1;

src/p_inter.c

@@ -589,7 +589,7 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
 			special->momx = special->momy = special->momz = 0;
 			P_GivePlayerRings(player, 1);
 
-			if (UNLIKELY((maptol & TOL_NIGHTS) && special->type != MT_FLINGRING))
+			if (nightsmode && special->type != MT_FLINGRING)
 				P_DoNightsScore(player);
 			break;
 
@@ -601,7 +601,7 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
 			special->momx = special->momy = 0;
 			P_GivePlayerRings(player, 1);
 
-			if (UNLIKELY((maptol & TOL_NIGHTS) && special->type != MT_FLINGCOIN))
+			if (nightsmode && special->type != MT_FLINGCOIN)
 				P_DoNightsScore(player);
 			break;
 		case MT_BLUEBALL:
@@ -617,7 +617,7 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
 			else
 				special->scalespeed = 4*FRACUNIT/5;
 
-			if (UNLIKELY(maptol & TOL_NIGHTS))
+			if (nightsmode)
 				P_DoNightsScore(player);
 			break;
 		case MT_AUTOPICKUP:
@@ -831,7 +831,7 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
 			{
 				S_StartSound(toucher, special->info->seesound);
 
-				if (UNLIKELY(player->pflags & PF_NIGHTSMODE))
+				if (nightsplayer(player))
 				{
 					player->bumpertime = TICRATE/2;
 					if (special->threshold > 0)
@@ -883,18 +883,20 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
 			break;
 		case MT_HOOPCOLLIDE:
 			// This produces a kind of 'domino effect' with the hoop's pieces.
-			for (; special->hprev != NULL; special = special->hprev); // Move to the first sprite in the hoop
-
+			for (; special != NULL && special->hprev != NULL; special = special->hprev); // Move to the first sprite in the hoop
 			i = 0;
-			for (; special->hnext != NULL && special->type == MT_HOOP; special = special->hnext)
+			for (; special != NULL && special->type == MT_HOOP; special = special->hnext)
 			{
-				if (!P_MobjWasRemoved(special->target))
+				if (!P_MobjWasRemoved(special))
 				{
 					special->fuse = 11;
 					special->movedir = i;
-					special->extravalue1 = special->target->extravalue1;
-					special->extravalue2 = special->target->extravalue2;
-					special->target->threshold = 4242;
+					if (!P_MobjWasRemoved(special->target))
+					{
+						special->extravalue1 = special->target->extravalue1;
+						special->extravalue2 = special->target->extravalue2;
+						special->target->threshold = 4242;
+					}
 				}
 				i++;
 			}
@@ -1131,7 +1133,7 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
 					S_StartSound(toucher, special->info->painsound);
 					return;
 				}
-				else if (UNLIKELY((player->pflags & PF_NIGHTSMODE) && (player->pflags & PF_DRILLING)) || (player->pflags & (PF_JUMPED|PF_SPINNING|PF_GLIDING))
+				else if ((nightsplayer(player) && (player->pflags & PF_DRILLING)) || (player->pflags & (PF_JUMPED|PF_SPINNING|PF_GLIDING))
 						|| player->powers[pw_invulnerability] || player->powers[pw_super]) // Do you possess the ability to subdue the object?
 				{
 					// Shatter the shield!
@@ -1466,11 +1468,7 @@ static void P_UpdateRemovedOrbital(mobj_t *target, mobj_t *inflictor, mobj_t *so
 {
 	// SRB2kart
 	// I wish I knew a better way to do this
-#ifndef COMPAT_VANILLA
-	if (!P_MobjWasRemoved(target->target) && target->target->player && !P_MobjWasRemoved(target->target->player->mo))
-#else
-	if (target->target && target->target->player && target->target->player->mo)
-#endif
+	if (!P_MobjWasRemovedCompat(target->target) && target->target->player && !P_MobjWasRemovedCompat(target->target->player->mo))
 	{
 		if (target->target->player->kartstuff[k_eggmanheld] && target->type == MT_EGGMANITEM_SHIELD)
 			target->target->player->kartstuff[k_eggmanheld] = 0;
@@ -1483,11 +1481,7 @@ static void P_UpdateRemovedOrbital(mobj_t *target, mobj_t *inflictor, mobj_t *so
 			{
 				if (target->movedir != 0 && target->movedir < (UINT16)target->target->player->kartstuff[k_itemamount])
 				{
-#ifndef COMPAT_VANILLA
-					if (!P_MobjWasRemoved(target->target->hnext))
-#else
-					if (target->target->hnext)
-#endif
+					if (!P_MobjWasRemovedCompat(target->target->hnext))
 						K_KillBananaChain(target->target->hnext, inflictor, source);
 
 					target->target->player->kartstuff[k_itemamount] = 0;
@@ -2245,11 +2239,7 @@ boolean P_DamageMobj(mobj_t *target, mobj_t *inflictor, mobj_t *source, INT32 da
 		return false;
 
 	// well no clue but this may happen ig
-#ifndef COMPAT_VANILLA
-	if (P_MobjWasRemoved(target))
-#else
-	if (!target)
-#endif
+	if (P_MobjWasRemovedCompat(target))
 		return false;
 
 	if (target->health <= 0)
@@ -2266,7 +2256,7 @@ boolean P_DamageMobj(mobj_t *target, mobj_t *inflictor, mobj_t *source, INT32 da
 				return false;
 		}
 
-		if (source && source->player && source->player->spectator)
+		if (!P_MobjWasRemovedCompat(source) && source->player && source->player->spectator)
 			return false;
 	}
 
@@ -2360,11 +2350,11 @@ boolean P_DamageMobj(mobj_t *target, mobj_t *inflictor, mobj_t *source, INT32 da
 			if (player->exiting)
 				return false;
 
-			if (UNLIKELY(!(target->player->pflags & (PF_NIGHTSMODE|PF_NIGHTSFALL)) && (maptol & TOL_NIGHTS)))
+			if (UNLIKELY(!(target->player->pflags & (PF_NIGHTSMODE|PF_NIGHTSFALL)) && nightsmode))
 				return false;
 		}
 
-		if (UNLIKELY(player->pflags & PF_NIGHTSMODE)) // NiGHTS damage handling
+		if (nightsplayer(player)) // NiGHTS damage handling
 		{
 			if (!force)
 			{
@@ -2609,7 +2599,7 @@ void P_PlayerRingBurst(player_t *player, INT32 num_rings)
 			ns = FixedMul(((i*FRACUNIT)/16)+2*FRACUNIT, mo->scale);
 			mo->momx = FixedMul(FINECOSINE(fa),ns);
 
-			if (LIKELY(!(twodlevel || (player->mo->flags2 & MF2_TWOD))))
+			if (!twodmo(player->mo))
 				mo->momy = FixedMul(FINESINE(fa),ns);
 
 			P_SetObjectMomZ(mo, 8*FRACUNIT, false);
@@ -2633,7 +2623,7 @@ void P_PlayerRingBurst(player_t *player, INT32 num_rings)
 			ns = FixedMul(momxy, mo->scale);
 			mo->momx = FixedMul(FINECOSINE(fa),ns);
 
-			if (LIKELY(!(twodlevel || (player->mo->flags2 & MF2_TWOD))))
+			if (!twodmo(player->mo))
 				mo->momy = FixedMul(FINESINE(fa),ns);
 
 			ns = momz;
@@ -2740,7 +2730,7 @@ void P_PlayerWeaponPanelBurst(player_t *player)
 		ns = FixedMul(3*FRACUNIT, mo->scale);
 		mo->momx = FixedMul(FINECOSINE(fa),ns);
 
-		if (LIKELY(!(twodlevel || (player->mo->flags2 & MF2_TWOD))))
+		if (!twodmo(player->mo))
 			mo->momy = FixedMul(FINESINE(fa),ns);
 
 		P_SetObjectMomZ(mo, 4*FRACUNIT, false);
@@ -2824,7 +2814,7 @@ void P_PlayerWeaponAmmoBurst(player_t *player)
 		ns = FixedMul(2*FRACUNIT, mo->scale);
 		mo->momx = FixedMul(FINECOSINE(fa), ns);
 
-		if (LIKELY(!(twodlevel || (player->mo->flags2 & MF2_TWOD))))
+		if (!twodmo(player->mo))
 			mo->momy = FixedMul(FINESINE(fa),ns);
 
 		P_SetObjectMomZ(mo, 3*FRACUNIT, false);
@@ -2940,7 +2930,7 @@ void P_PlayerEmeraldBurst(player_t *player, boolean toss)
 
 			momx = FixedMul(FINECOSINE(fa), ns);
 
-			if (LIKELY(!(twodlevel || (player->mo->flags2 & MF2_TWOD))))
+			if (!twodmo(player->mo))
 				momy = FixedMul(FINESINE(fa),ns);
 			else
 				momy = 0;
@@ -2997,7 +2987,7 @@ void P_PlayerFlagBurst(player_t *player, boolean toss)
 	{
 		angle_t fa = P_RandomByte()*FINEANGLES/256;
 		flag->momx = FixedMul(FINECOSINE(fa), FixedMul(6*FRACUNIT, player->mo->scale));
-		if (LIKELY(!(twodlevel || (player->mo->flags2 & MF2_TWOD))))
+		if (!twodmo(player->mo))
 			flag->momy = FixedMul(FINESINE(fa), FixedMul(6*FRACUNIT, player->mo->scale));
 	}
 

src/p_local.h

@@ -59,8 +59,12 @@ extern "C" {
 
 #define AIMINGTOSLOPE(aiming) FINESINE((aiming>>ANGLETOFINESHIFT) & FINEMASK)
 
-#define mariomode (maptol & TOL_MARIO)
-#define twodlevel (maptol & TOL_2D)
+// unused modes, kept for compat
+#define nightsmode           (UNLIKELY(maptol & TOL_NIGHTS))
+#define nightsplayer(player) (UNLIKELY((player)->pflags & PF_NIGHTSMODE))
+#define mariomode            (UNLIKELY(maptol & TOL_MARIO))
+#define twodlevel            (UNLIKELY(maptol & TOL_2D))
+#define twodmo(mobj)         (UNLIKELY(twodlevel || ((mobj)->flags2 & MF2_TWOD)))
 
 //
 // P_TICK
@@ -287,6 +291,17 @@ FUNCINLINE static ATTRINLINE boolean P_MobjWasRemoved(const mobj_t *mobj)
 	return (!mobj || mobj->thinker.function != (actionf_p1)P_MobjThinker);
 }
 
+// stupid, but kart allows mobjs that are marked to be removed to be accessed and modified in many cases
+// so can only check if its not NULL in vanilla compat mode
+FUNCINLINE static ATTRINLINE boolean P_MobjWasRemovedCompat(const mobj_t *mobj)
+{
+#ifdef COMPAT_VANILLA
+	return (!mobj);
+#else
+	return P_MobjWasRemoved(mobj);
+#endif
+}
+
 fixed_t P_MobjFloorZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed_t x, fixed_t y, line_t *line, boolean lowest, boolean perfect);
 fixed_t P_MobjCeilingZ(mobj_t *mobj, sector_t *sector, sector_t *boundsec, fixed_t x, fixed_t y, line_t *line, boolean lowest, boolean perfect);
 #define P_GetFloorZ(mobj, sector, x, y, line) P_MobjFloorZ(mobj, sector, NULL, x, y, line, false, false)

src/p_map.c

@@ -136,14 +136,17 @@ boolean P_DoSpring(mobj_t *spring, mobj_t *object)
 	if (object->eflags & MFE_SPRUNG) // Object was already sprung this tic
 		return false;
 
-	// Spectators don't trigger springs.
-	if (object->player && object->player->spectator)
-		return false;
-
-	if (UNLIKELY(object->player && (object->player->pflags & PF_NIGHTSMODE)))
+	if (object->player)
 	{
-		/*Someone want to make these work like bumpers?*/
-		return false;
+		// Spectators don't trigger springs.
+		if (object->player->spectator)
+			return false;
+
+		if (nightsplayer(object->player))
+		{
+			/*Someone want to make these work like bumpers?*/
+			return false;
+		}
 	}
 
 	object->standingslope = NULL; // Okay, now we can't return - no launching off at silly angles for you.
@@ -160,10 +163,15 @@ boolean P_DoSpring(mobj_t *spring, mobj_t *object)
 	if (spring->eflags & MFE_VERTICALFLIP)
 		vertispeed *= -1;
 
+	// Vertical springs teleport you on TOP of them.
 	if (vertispeed > 0)
+	{
 		object->z = spring->z + spring->height + 1;
+	}
 	else if (vertispeed < 0)
+	{
 		object->z = spring->z - object->height - 1;
+	}
 	else
 	{
 		// Horizontal springs teleport you in FRONT of them.
@@ -215,7 +223,9 @@ boolean P_DoSpring(mobj_t *spring, mobj_t *object)
 	if (object->player)
 	{
 		if (spring->flags & MF_ENEMY) // Spring shells
+		{
 			P_SetTarget(&spring->target, object);
+		}
 
 		if (horizspeed && object->player->cmd.forwardmove == 0 && object->player->cmd.sidemove == 0)
 		{
@@ -312,13 +322,13 @@ static boolean PIT_CheckThing(mobj_t *thing)
 	if (thing == tmthing)
 		return true;
 
-	// Ignore... things.
-	if (!tmthing || P_MobjWasRemoved(thing))
-		return true;
-
 	I_Assert(!P_MobjWasRemoved(tmthing));
 	I_Assert(!P_MobjWasRemoved(thing));
 
+	// Ignore... things.
+	if (P_MobjWasRemovedCompat(tmthing) || P_MobjWasRemoved(thing))
+		return true;
+
 	// Ignore spectators
 	if ((tmthing->player && tmthing->player->spectator)
 	 || (thing->player && thing->player->spectator))
@@ -350,12 +360,13 @@ static boolean PIT_CheckThing(mobj_t *thing)
 	}
 #endif
 
-	if (!(thing->flags & (MF_SOLID|MF_SPECIAL|MF_PAIN|MF_SHOOTABLE)) || (thing->flags & MF_NOCLIPTHING))
+	if ((thing->flags & MF_NOCLIPTHING) || !(thing->flags & (MF_SOLID|MF_SPECIAL|MF_PAIN|MF_SHOOTABLE)))
 		return true;
 
 	// Don't collide with your buddies while NiGHTS-flying.
-	if (UNLIKELY(tmthing->player && thing->player && (maptol & TOL_NIGHTS)
-		&& ((tmthing->player->pflags & PF_NIGHTSMODE) || (thing->player->pflags & PF_NIGHTSMODE))))
+	if (nightsmode &&
+		tmthing->player && thing->player &&
+		(nightsplayer(tmthing->player) || nightsplayer(thing->player)))
 		return true;
 
 	blockdist = thing->radius + tmthing->radius;
@@ -1817,14 +1828,14 @@ boolean P_CheckPosition(mobj_t *thing, fixed_t x, fixed_t y)
 			delta1 = abs(thing->z - midheight);
 			delta2 = abs(thingtop - midheight);
 
-			if (topheight > tmfloorz && delta1 < delta2
+			if ((topheight > tmfloorz) && (delta1 < delta2)
 				&& !(rover->flags & FF_REVERSEPLATFORM))
 			{
 				tmfloorz = tmdropoffz = topheight;
 				tmfloorslope = *rover->t_slope;
 			}
 
-			if (bottomheight < tmceilingz && delta1 >= delta2
+			if ((bottomheight < tmceilingz) && (delta1 >= delta2)
 				&& !(rover->flags & FF_PLATFORM)
 				&& !(thing->type == MT_SKIM && (rover->flags & FF_SWIMMABLE)))
 			{
@@ -1879,8 +1890,7 @@ boolean P_CheckPosition(mobj_t *thing, fixed_t x, fixed_t y)
 
 						po->validcount = validcount;
 
-						if (!P_BBoxInsidePolyobj(po, tmbbox)
-							|| !(po->flags & POF_SOLID))
+						if (!(po->flags & POF_SOLID) || !P_BBoxInsidePolyobj(po, tmbbox))
 						{
 							plink = (polymaplink_t *)(plink->link.next);
 							continue;
@@ -2125,7 +2135,7 @@ static boolean P_CheckCameraPosition(fixed_t x, fixed_t y, camera_t *thiscam)
 
 						po->validcount = validcount;
 
-						if (!P_PointInsidePolyobj(po, x, y) || !(po->flags & POF_SOLID))
+						if (!(po->flags & POF_SOLID) || !P_PointInsidePolyobj(po, x, y))
 						{
 							plink = (polymaplink_t *)(plink->link.next);
 							continue;
@@ -2599,36 +2609,10 @@ boolean P_TryMove(mobj_t *thing, fixed_t x, fixed_t y, boolean allowdropoff)
 		// sound does not work out all that well for kart maps
 
 		// best i can do...
-		if (cv_stairjanksfx.value)
+		if (cv_stairjank.value && cv_stairjanksfx.value)
 			S_StartSoundAtVolume(thing, (thing->player->stairjank >= 8 ? sfx_s23b : sfx_s268), 192); // dont blast this at full volume lul
 
-		//if (!thing->player->stairjank)
-		{
-			// 90 degrees to direction you're facing
-			fixed_t dirx = -FINESINE(thing->angle>>ANGLETOFINESHIFT);
-			fixed_t diry = FINECOSINE(thing->angle>>ANGLETOFINESHIFT);
-			fixed_t offset = thing->radius;
-
-			if (leveltime % 8 < 4)
-			{
-				dirx = -dirx;
-				diry = -diry;
-			}
-
-			mobj_t * spark = P_SpawnMobj(thing->x + FixedMul(dirx, offset), thing->y + FixedMul(diry, offset), thing->z, MT_DRIFTDUST);
-			spark->momx = FixedMul(dirx, FRACUNIT) + (6 + ((int)leveltime % 5))*(thing->momx)/10;
-			spark->momy = FixedMul(diry, FRACUNIT) + (6 + ((int)leveltime % 5))*(thing->momy)/10;
-			spark->momz = 5*FRACUNIT;
-			spark->scale = mapobjectscale/5;
-			spark->destscale = mapobjectscale/2;
-			spark->islocal = true;
-			//spark->fuse = 9;
-			spark->color = SKINCOLOR_WHITE;
-			//spark->cusval = K_StairJankFlip(ANGLE_90);
-			P_SetTarget(&spark->target, thing);
-			//P_SetTarget(&spark->owner, thing);
-			//spark->renderflags |= RF_REDUCEVFX;
-		}
+		// Can't spawn things during P_TryMove, because global variables :)
 
 		thing->player->stairjank = 9;
 		//thing->player->stairjank = 17;
@@ -2684,7 +2668,7 @@ boolean P_SceneryTryMove(mobj_t *thing, fixed_t x, fixed_t y)
 			if (tmfloorz - thing->z > maxstep)
 				return false; // too big a step up
 		}
-	} while(tryx != x || tryy != y);
+	} while (tryx != x || tryy != y);
 
 	// the move is ok,
 	// so link the thing into its new position
@@ -3179,6 +3163,9 @@ void P_SlideMove(mobj_t *mo, boolean forceslide)
 	INT16 hitcount = 0;
 	boolean success = false;
 
+	if (P_MobjWasRemovedCompat(mo))
+		return;
+
 	if (tmhitthing && mo->z + mo->height > tmhitthing->z && mo->z < tmhitthing->z + tmhitthing->height)
 	{
 		// Don't mess with your momentum if it's a pushable object. Pushables do their own crazy things already.
@@ -3215,6 +3202,9 @@ void P_SlideMove(mobj_t *mo, boolean forceslide)
 	bestslideline = NULL;
 
 retry:
+	if (P_MobjWasRemovedCompat(mo))
+		return;
+
 	if (++hitcount == 3)
 		goto stairstep; // don't loop forever
 
@@ -3263,7 +3253,13 @@ retry:
 		// the move must have hit the middle, so stairstep
 stairstep:
 		if (!P_TryMove(mo, mo->x, mo->y + mo->momy, true)) //Allow things to drop off.
+		{
+			if (P_MobjWasRemovedCompat(mo))
+				return;
+
 			P_TryMove(mo, mo->x + mo->momx, mo->y, true);
+		}
+
 		return;
 	}
 
@@ -3275,7 +3271,12 @@ stairstep:
 		newy = FixedMul(mo->momy, bestslidefrac);
 
 		if (!P_TryMove(mo, mo->x + newx, mo->y + newy, true))
+		{
 			goto stairstep;
+		}
+
+		if (P_MobjWasRemovedCompat(mo))
+			return;
 	}
 
 	// Now continue along the wall.
@@ -3294,7 +3295,7 @@ stairstep:
 	if (bestslideline != NULL)
 		P_HitSlideLine(bestslideline); // clip the moves
 
-	if (UNLIKELY((twodlevel || (mo->flags2 & MF2_TWOD)) && mo->player))
+	if (twodmo(mo) && mo->player)
 	{
 		mo->momx = tmxmove;
 		tmymove = 0;
@@ -3346,8 +3347,11 @@ stairstep:
 				goto retry;
 		}
 
+		if (P_MobjWasRemovedCompat(mo))
+			return;
+
 		success = true;
-	} while(tmxmove || tmymove);
+	} while (tmxmove || tmymove);
 }
 
 //
@@ -3360,12 +3364,18 @@ void P_BouncePlayerMove(mobj_t *mo)
 {
 	fixed_t leadx, leady;
 	fixed_t trailx, traily;
-	fixed_t mmomx = 0, mmomy = 0;
-	fixed_t oldmomx = mo->momx, oldmomy = mo->momy;
+	fixed_t mmomx, mmomy;
+	fixed_t oldmomx, oldmomy;
 
-	if (!mo->player)
+	if (P_MobjWasRemovedCompat(mo))
 		return;
 
+	if (mo->player == NULL)
+		return;
+
+	oldmomx = mo->momx;
+	oldmomy = mo->momy;
+
 	if (mo->player->spectator)
 	{
 		P_SlideMove(mo, true);
@@ -3454,6 +3464,9 @@ void P_BouncePlayerMove(mobj_t *mo)
 
 	if (!P_TryMove(mo, mo->x + tmxmove, mo->y + tmymove, true))
 	{
+		if (P_MobjWasRemovedCompat(mo))
+			return;
+
 		P_TryMove(mo, mo->x - oldmomx, mo->y - oldmomy, true);
 	}
 }
@@ -3471,6 +3484,9 @@ void P_BounceMove(mobj_t *mo)
 	INT32 hitcount;
 	fixed_t mmomx = 0, mmomy = 0;
 
+	if (P_MobjWasRemovedCompat(mo))
+		return;
+
 	if (mo->player)
 	{
 		P_BouncePlayerMove(mo);
@@ -3487,6 +3503,9 @@ void P_BounceMove(mobj_t *mo)
 	hitcount = 0;
 
 retry:
+	if (P_MobjWasRemovedCompat(mo))
+		return;
+
 	if (++hitcount == 3)
 		goto bounceback; // don't loop forever
 
@@ -3545,7 +3564,12 @@ bounceback:
 		newy = FixedMul(mmomy, bestslidefrac);
 
 		if (!P_TryMove(mo, mo->x + newx, mo->y + newy, true))
+		{
+			if (P_MobjWasRemovedCompat(mo))
+				return;
+
 			goto bounceback;
+		}
 	}
 
 	// Now continue along the wall.
@@ -3742,7 +3766,7 @@ static boolean PIT_ChangeSector(mobj_t *thing, boolean realcrush)
 				delta1 = abs(thing->z - midheight);
 				delta2 = abs(thingtop - midheight);
 
-				if (bottomheight <= thing->ceilingz && delta1 >= delta2)
+				if ((bottomheight <= thing->ceilingz) && (delta1 >= delta2))
 				{
 					if (thing->flags & MF_PUSHABLE)
 					{
@@ -4200,7 +4224,7 @@ void P_CreateSecNodeList(mobj_t *thing, fixed_t x, fixed_t y)
  * Must clear tmthing at tic end, as it might contain a pointer to a removed thinker, or the level might have ended/been ended and we clear the objects it was pointing too. Hopefully we don't need to carry this between tics for sync. */
 void P_MapStart(void)
 {
-	if (UNLIKELY(tmthing))
+	if (tmthing)
 		I_Error("P_MapStart: tmthing set!");
 }
 
@@ -4252,7 +4276,7 @@ fixed_t P_FloorzAtPos(fixed_t x, fixed_t y, fixed_t z, fixed_t height)
 			delta1 = abs(z - midheight);
 			delta2 = abs(thingtop - midheight);
 
-			if (topheight > floorz && delta1 < delta2)
+			if ((topheight > floorz) && (delta1 < delta2))
 				floorz = topheight;
 		}
 	}

src/p_maputl.cpp

@@ -326,7 +326,7 @@ void P_CameraLineOpening(line_t *linedef)
 		{
 			for (rover = front->ffloors; rover; rover = rover->next)
 			{
-				fixed_t topheight, bottomheight;
+				fixed_t topheight, bottomheight, midheight;
 
 				if (!(rover->flags & FF_BLOCKOTHERS) || !(rover->flags & FF_RENDERALL) || !(rover->flags & FF_EXISTS) || UNLIKELY(GETSECSPECIAL(rover->master->frontsector->special, 4) == 12))
 					continue;
@@ -334,8 +334,10 @@ void P_CameraLineOpening(line_t *linedef)
 				topheight = P_CameraGetFOFTopZ(mapcampointer, front, rover, tmx, tmy, linedef);
 				bottomheight = P_CameraGetFOFBottomZ(mapcampointer, front, rover, tmx, tmy, linedef);
 
-				delta1 = abs(mapcampointer->z - (bottomheight + ((topheight - bottomheight)/2)));
-				delta2 = abs(thingtop - (bottomheight + ((topheight - bottomheight)/2)));
+				midheight = (bottomheight + ((topheight - bottomheight) / 2));
+
+				delta1 = abs(mapcampointer->z - midheight);
+				delta2 = abs(thingtop - midheight);
 
 				if (bottomheight < lowestceiling && delta1 >= delta2)
 					lowestceiling = bottomheight;
@@ -354,7 +356,7 @@ void P_CameraLineOpening(line_t *linedef)
 		{
 			for (rover = back->ffloors; rover; rover = rover->next)
 			{
-				fixed_t topheight, bottomheight;
+				fixed_t topheight, bottomheight, midheight;
 
 				if (!(rover->flags & FF_BLOCKOTHERS) || !(rover->flags & FF_RENDERALL) || !(rover->flags & FF_EXISTS) || UNLIKELY(GETSECSPECIAL(rover->master->frontsector->special, 4) == 12))
 					continue;
@@ -362,8 +364,10 @@ void P_CameraLineOpening(line_t *linedef)
 				topheight = P_CameraGetFOFTopZ(mapcampointer, back, rover, tmx, tmy, linedef);
 				bottomheight = P_CameraGetFOFBottomZ(mapcampointer, back, rover, tmx, tmy, linedef);
 
-				delta1 = abs(mapcampointer->z - (bottomheight + ((topheight - bottomheight)/2)));
-				delta2 = abs(thingtop - (bottomheight + ((topheight - bottomheight)/2)));
+				midheight = (bottomheight + ((topheight - bottomheight) / 2));
+
+				delta1 = abs(mapcampointer->z - midheight);
+				delta2 = abs(thingtop - midheight);
 
 				if (bottomheight < lowestceiling && delta1 >= delta2)
 					lowestceiling = bottomheight;
@@ -524,7 +528,7 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 			// Check for frontsector's fake floors
 			for (rover = front->ffloors; rover; rover = rover->next)
 			{
-				fixed_t topheight, bottomheight;
+				fixed_t topheight, bottomheight, midheight;
 
 				if (!(rover->flags & FF_EXISTS))
 					continue;
@@ -538,8 +542,10 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 				topheight = P_GetFOFTopZ(mobj, front, rover, tmx, tmy, linedef);
 				bottomheight = P_GetFOFBottomZ(mobj, front, rover, tmx, tmy, linedef);
 
-				delta1 = abs(mobj->z - (bottomheight + ((topheight - bottomheight)/2)));
-				delta2 = abs(thingtop - (bottomheight + ((topheight - bottomheight)/2)));
+				midheight = (bottomheight + ((topheight - bottomheight) / 2));
+
+				delta1 = abs(mobj->z - midheight);
+				delta2 = abs(thingtop - midheight);
 
 				if (delta1 >= delta2 && !(rover->flags & FF_PLATFORM)) // thing is below FOF
 				{
@@ -567,7 +573,7 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 			// Check for backsectors fake floors
 			for (rover = back->ffloors; rover; rover = rover->next)
 			{
-				fixed_t topheight, bottomheight;
+				fixed_t topheight, bottomheight, midheight;
 				if (!(rover->flags & FF_EXISTS))
 					continue;
 
@@ -580,8 +586,10 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 				topheight = P_GetFOFTopZ(mobj, back, rover, tmx, tmy, linedef);
 				bottomheight = P_GetFOFBottomZ(mobj, back, rover, tmx, tmy, linedef);
 
-				delta1 = abs(mobj->z - (bottomheight + ((topheight - bottomheight)/2)));
-				delta2 = abs(thingtop - (bottomheight + ((topheight - bottomheight)/2)));
+				midheight = (bottomheight + ((topheight - bottomheight) / 2));
+
+				delta1 = abs(mobj->z - midheight);
+				delta2 = abs(thingtop - midheight);
 
 				if (delta1 >= delta2 && !(rover->flags & FF_PLATFORM)) // thing is below FOF
 				{
@@ -611,8 +619,10 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 			{
 				const sector_t *polysec = linedef->backsector;
 
-				delta1 = abs(mobj->z - (polysec->floorheight + ((polysec->ceilingheight - polysec->floorheight)/2)));
-				delta2 = abs(thingtop - (polysec->floorheight + ((polysec->ceilingheight - polysec->floorheight)/2)));
+				const fixed_t polymid = (polysec->floorheight + ((polysec->ceilingheight - polysec->floorheight) / 2));
+
+				delta1 = abs(mobj->z - polymid);
+				delta2 = abs(thingtop - polymid);
 
 				if (polysec->floorheight < lowestceiling && delta1 >= delta2)
 				{
@@ -620,7 +630,9 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 					ceilingslope = NULL;
 				}
 				else if (polysec->floorheight < highestceiling && delta1 >= delta2)
+				{
 					highestceiling = polysec->floorheight;
+				}
 
 				if (polysec->ceilingheight > highestfloor && delta1 < delta2)
 				{
@@ -628,7 +640,9 @@ void P_LineOpening(line_t *linedef, mobj_t *mobj)
 					floorslope = NULL;
 				}
 				else if (polysec->ceilingheight > lowestfloor && delta1 < delta2)
+				{
 					lowestfloor = polysec->ceilingheight;
+				}
 			}
 
 			if (highestceiling < highceiling)
@@ -842,7 +856,7 @@ void P_SetThingPosition(mobj_t *thing)
 		// at sector_t->touching_thinglist) are broken. When a node is
 		// added, new sector links are created.
 
-		P_CreateSecNodeList(thing,thing->x,thing->y);
+		P_CreateSecNodeList(thing, thing->x, thing->y);
 		thing->touching_sectorlist = sector_list; // Attach to Thing's mobj_t
 		sector_list = NULL; // clear for next time
 	}

src/p_setup.c

@@ -117,6 +117,7 @@ line_t *spawnlines = NULL;
 side_t *spawnsides = NULL;
 INT32 numstarposts = 0;
 boolean levelloading = false;
+UINT8 levelfadecol = 120;
 
 virtres_t *curmapvirt = NULL;
 
@@ -920,7 +921,48 @@ static void P_LoadThings(UINT8 *data)
 	}
 }
 
-static void P_SpawnMapThings(void)
+static void P_SpawnEmeraldHunt(void)
+{
+	INT32 i;
+	INT32 emer[3] = {0, 0, 0};
+	INT32 timeout = 0; // keeps from getting stuck
+	fixed_t x, y, z;
+
+	// increment spawn numbers because zero is valid.
+	emer[0] = (P_RandomKey(numhuntemeralds)) + 1;
+	while (timeout++ < 100)
+	{
+		emer[1] = (P_RandomKey(numhuntemeralds)) + 1;
+
+		if (emer[1] != emer[0])
+			break;
+	}
+
+	timeout = 0;
+	while (timeout++ < 100)
+	{
+		emer[2] = (P_RandomKey(numhuntemeralds)) + 1;
+
+		if (emer[2] != emer[1] && emer[2] != emer[0])
+			break;
+	}
+
+	for (i = 0; i < 3; i++)
+	{
+		if (!emer[i])
+			continue;
+
+		// decrement spawn values to the actual number because zero is valid.
+		x = huntemeralds[emer[i] - 1]->x<<FRACBITS;
+		y = huntemeralds[emer[i] - 1]->y<<FRACBITS;
+		z = huntemeralds[emer[i] - 1]->z<<FRACBITS;
+
+		// spawn emerald
+		P_SpawnMobj(x, y, z, MT_EMERHUNT);
+	}
+}
+
+static void P_SpawnMapThings(boolean spawnhoops)
 {
 	size_t i;
 	mapthing_t *mt;
@@ -930,97 +972,68 @@ static void P_SpawnMapThings(void)
 	// Spawn axis points first so they are at the front of the list for fast searching.
 	for (i = 0, mt = mapthings; i < nummapthings; i++, mt++)
 	{
-		switch (mt->type)
+		if (mt->type == 1700 || // MT_AXIS
+			mt->type == 1701 || // MT_AXISTRANSFER
+			mt->type == 1702)   // MT_AXISTRANSFERLINE
 		{
-			case 1700: // MT_AXIS
-			case 1701: // MT_AXISTRANSFER
-			case 1702: // MT_AXISTRANSFERLINE
-				mt->mobj = NULL;
-				P_SpawnMapThing(mt);
-				break;
-			default:
-				break;
+			mt->mobj = NULL;
+			P_SpawnMapThing(mt);
 		}
 	}
 
 	for (i = 0, mt = mapthings; i < nummapthings; i++, mt++)
 	{
-		sector_t *mtsector = R_PointInSubsector((mt->x << FRACBITS), (mt->y << FRACBITS))->sector;
+		sector_t *mtsector;
+
+		// srb2kart - ignore rings, coins and item patterns!
+		if (mt->type == 300  || mt->type == 308  || mt->type == 309 ||
+		   (mt->type >= 600  && mt->type <= 609) ||
+		    mt->type == 1706 || mt->type == 1800)
+		{
+			mt->mobj = NULL;
+			continue;
+		}
+
+		mtsector = R_PointInSubsector((mt->x << FRACBITS), (mt->y << FRACBITS))->sector;
 
 		// Z for objects
 		mt->z = (INT16)(P_GetSectorFloorZAt(mtsector, (mt->x << FRACBITS), (mt->y << FRACBITS))) >> FRACBITS;
 
-		if (mt->type == 1700 // MT_AXIS
-			|| mt->type == 1701 // MT_AXISTRANSFER
-			|| mt->type == 1702) // MT_AXISTRANSFERLINE
+		if (mt->type == 1700 || // MT_AXIS
+			mt->type == 1701 || // MT_AXISTRANSFER
+			mt->type == 1702)   // MT_AXISTRANSFERLINE
+		{
 			continue; // These were already spawned
+		}
+
+		mt->mobj = NULL;
+
+		// spawn hoops
+		if (mt->type == 1705 || mt->type == 1713)
+		{
+			// Check for spawnhoops here so the hoops don't spawn ghost variants for players joining a netgame mid-level
+			// ...It's a long story.
+			if (spawnhoops)
+			{
+				// Z for objects Tails 05-26-2002
+				mt->z = (INT16)(mtsector->floorheight >> FRACBITS);
+
+				P_SpawnHoops(mt);
+			}
+
+			continue;
+		}
 
 		if (mt->type == mobjinfo[MT_RANDOMITEM].doomednum)
 			nummapboxes++;
 
-		mt->mobj = NULL;
+		// Everything else
 		P_SpawnMapThing(mt);
 	}
 
 	// random emeralds for hunt
 	if (numhuntemeralds)
-	{
-		INT32 emer1, emer2, emer3;
-		INT32 timeout = 0; // keeps from getting stuck
-
-		emer1 = emer2 = emer3 = 0;
-
-		//increment spawn numbers because zero is valid.
-		emer1 = (P_RandomKey(numhuntemeralds)) + 1;
-		while (timeout++ < 100)
-		{
-			emer2 = (P_RandomKey(numhuntemeralds)) + 1;
-
-			if (emer2 != emer1)
-				break;
-		}
-
-		timeout = 0;
-		while (timeout++ < 100)
-		{
-			emer3 = (P_RandomKey(numhuntemeralds)) + 1;
-
-			if (emer3 != emer2 && emer3 != emer1)
-				break;
-		}
-
-		//decrement spawn values to the actual number because zero is valid.
-		if (emer1)
-			P_SpawnMobj(huntemeralds[emer1 - 1]->x<<FRACBITS,
-				huntemeralds[emer1 - 1]->y<<FRACBITS,
-				huntemeralds[emer1 - 1]->z<<FRACBITS, MT_EMERHUNT);
-
-		if (emer2)
-			P_SpawnMobj(huntemeralds[emer2 - 1]->x<<FRACBITS,
-				huntemeralds[emer2 - 1]->y<<FRACBITS,
-				huntemeralds[emer2 - 1]->z<<FRACBITS, MT_EMERHUNT);
-
-		if (emer3)
-			P_SpawnMobj(huntemeralds[emer3 - 1]->x<<FRACBITS,
-				huntemeralds[emer3 - 1]->y<<FRACBITS,
-				huntemeralds[emer3 - 1]->z<<FRACBITS, MT_EMERHUNT);
-	}
-
-	// Run through the list of mapthings again to spawn hoops and rings
-	for (i = 0, mt = mapthings; i < nummapthings; i++, mt++)
-	{
-		if (mt->type == 300 || mt->type == 308 || mt->type == 309
-		 || mt->type == 1706 || (mt->type >= 600 && mt->type <= 609)
-		 || mt->type == 1705 || mt->type == 1713 || mt->type == 1800)
-		{
-			mt->mobj = NULL;
-
-			// Z for objects Tails 05-26-2002
-			mt->z = (INT16)(R_PointInSubsector(mt->x << FRACBITS, mt->y << FRACBITS)->sector->floorheight>>FRACBITS);
-
-			P_SpawnHoops(mt);
-		}
-	}
+		P_SpawnEmeraldHunt();
 }
 
 static void P_SpawnEmblems(boolean loademblems)
@@ -1034,22 +1047,22 @@ static void P_SpawnEmblems(boolean loademblems)
 
 	for (i = 0; i < numemblems; i++)
 	{
-		if (emblemlocations[i].level != gamemap || emblemlocations[i].type > ET_SKIN)
+		const emblem_t *emblemlocation = &emblemlocations[i];
+
+		if (emblemlocation->level != gamemap || emblemlocation->type > ET_SKIN)
 			continue;
 
-		emblemmobj = P_SpawnMobj(emblemlocations[i].x<<FRACBITS, emblemlocations[i].y<<FRACBITS,
-			emblemlocations[i].z<<FRACBITS, MT_EMBLEM);
+		emblemmobj = P_SpawnMobj(emblemlocation->x<<FRACBITS, emblemlocation->y<<FRACBITS, emblemlocation->z<<FRACBITS, MT_EMBLEM);
 
-		I_Assert(emblemlocations[i].sprite >= 'A' && emblemlocations[i].sprite <= 'Z');
-		P_SetMobjStateNF(emblemmobj, emblemmobj->info->spawnstate + (emblemlocations[i].sprite - 'A'));
+		I_Assert(emblemlocation->sprite >= 'A' && emblemlocation->sprite <= 'Z');
+		P_SetMobjStateNF(emblemmobj, emblemmobj->info->spawnstate + (emblemlocation->sprite - 'A'));
 
 		emblemmobj->health = i+1;
 		color = M_GetEmblemColor(&emblemlocations[i]);
 
 		emblemmobj->color = (UINT8)color;
 
-		if (emblemlocations[i].collected
-			|| (emblemlocations[i].type == ET_SKIN && emblemlocations[i].var != players[0].skin))
+		if (emblemlocation->collected || (emblemlocation->type == ET_SKIN && emblemlocation->var != players[0].skin))
 		{
 			P_UnsetThingPosition(emblemmobj);
 			emblemmobj->flags |= MF_NOCLIP;
@@ -2956,7 +2969,6 @@ boolean P_SetupLevel(boolean fromnetsave, boolean reloadinggamestate)
 	// 99% of the things already did, so.
 	// Map header should always be in place at this point
 	INT32 i;
-	UINT8 levelfadecol;
 	boolean ranspecialwipe = false;
 	lumpnum_t encoreLump = LUMPERROR;
 	const mapheader_t *mapheader = mapheaderinfo[gamemap - 1];
@@ -3079,7 +3091,7 @@ boolean P_SetupLevel(boolean fromnetsave, boolean reloadinggamestate)
 	// a shit ton of time loading mobj thinkers.
 	CalculateDoomednumToMobjtype();
 
-	P_SpawnMapThings();
+	P_SpawnMapThings(!fromnetsave);
 
 	P_SpawnEmblems(!fromnetsave);
 

src/p_setup.h

@@ -35,6 +35,7 @@ extern mapthing_t *deathmatchstarts[MAX_DM_STARTS];
 extern INT32 numdmstarts, numcoopstarts, numredctfstarts, numbluectfstarts;
 
 extern boolean levelloading;
+extern UINT8 levelfadecol;
 
 extern lumpnum_t lastloadedmaplumpnum; // for comparative savegame
 extern virtres_t *curmapvirt;

src/p_spec.c

@@ -3880,7 +3880,7 @@ DoneSection2:
 
 					player->kartstuff[k_lapanimation] = 80;
 
-					if (UNLIKELY(player->pflags & PF_NIGHTSMODE))
+					if (nightsplayer(player))
 						player->drillmeter += 48*20;
 
 					if (netgame && player->laps >= (UINT8)cv_numlaps.value)
@@ -5302,6 +5302,18 @@ static void P_RunLevelLoadExecutors(void)
 	}
 }
 
+static fixed_t P_GetSectorGravityFactor(sector_t *sec)
+{
+	return FixedDiv(*sec->gravity >> FRACBITS, 1000);
+}
+
+fixed_t P_GetSectorGravity(sector_t *sec)
+{
+	if (sec && sec->gravity)
+		return FixedMul(gravity, P_GetSectorGravityFactor(sec));
+	return gravity;
+}
+
 /** After the map has loaded, scans for specials that spawn 3Dfloors and
   * thinkers.
   *
@@ -7126,7 +7138,7 @@ static inline boolean PIT_PushThing(mobj_t *thing)
 		return false;
 
 	// Allow this to affect pushable objects at some point?
-	if (thing->player && (!(thing->flags & (MF_NOGRAVITY | MF_NOCLIP)) || UNLIKELY(thing->player->pflags & PF_NIGHTSMODE)))
+	if (thing->player && (!(thing->flags & (MF_NOGRAVITY | MF_NOCLIP)) || nightsplayer(thing->player)))
 	{
 		INT32 dist;
 		INT32 speed;
@@ -7156,7 +7168,7 @@ static inline boolean PIT_PushThing(mobj_t *thing)
 		// Written with bits and pieces of P_HomingAttack
 		if ((speed > 0) && (P_CheckSight(thing, tmpusher->source)))
 		{
-			if (LIKELY(!(thing->player->pflags & PF_NIGHTSMODE)))
+			if (!nightsplayer(thing->player))
 			{
 				// only push wrt Z if health & 1 (mapthing has ambush flag)
 				if (tmpusher->source->health & 1)

src/p_spec.h

@@ -56,6 +56,8 @@ sector_t *P_PlayerTouchingSectorSpecial(player_t *player, INT32 section, INT32 n
 void P_PlayerInSpecialSector(player_t *player);
 void P_ProcessSpecialSector(player_t *player, sector_t *sector, sector_t *roversector);
 
+fixed_t P_GetSectorGravity(sector_t *sec);
+
 fixed_t P_FindLowestFloorSurrounding(sector_t *sec);
 fixed_t P_FindHighestFloorSurrounding(sector_t *sec);
 

src/p_tick.c

@@ -38,8 +38,6 @@
 #include "i_video.h" // rendermode
 #include "m_perfstats.h"
 
-#include "lua_profile.h"
-
 // Object place
 #include "m_cheat.h"
 
@@ -624,8 +622,6 @@ void P_Ticker(boolean run)
 			}
 		}
 
-		LUA_ResetTicTimers();
-
 		ps_lua_mobjhooks.value.i = 0;
 		ps_checkposition_calls.value.i = 0;
 
@@ -633,7 +629,6 @@ void P_Ticker(boolean run)
 		LUA_HookPreThinkFrame();
 		PS_STOP_TIMING(ps_lua_prethinkframe_time);
 
-		// OK! Now that we got all of that sorted, players can think!
 		PS_START_TIMING(ps_playerthink_time);
 		for (i = 0; i < MAXPLAYERS; i++)
 		{
@@ -680,7 +675,6 @@ void P_Ticker(boolean run)
 		PS_STOP_TIMING(ps_lua_thinkframe_time);
 	}
 
-	// Run shield positioning
 	P_RunOverlays();
 	P_RunShadows();
 
@@ -802,7 +796,7 @@ void P_Ticker(boolean run)
 				if (!player->mo)
 					continue;
 
-				const boolean skybox = (skyboxmo[0] && cv_skybox.value); // True if there's a skybox object and skyboxes are on
+				const boolean skybox = (skyboxmo[0] && cv_skybox.value);
 
 				if (skyVisiblePerPlayer[i] && skybox)
 				{

src/p_user.c

@@ -74,7 +74,7 @@ void P_Thrust(mobj_t *mo, angle_t angle, fixed_t move)
 
 	mo->momx += FixedMul(move, FINECOSINE(angle));
 
-	if (LIKELY(!(twodlevel || (mo->flags2 & MF2_TWOD))))
+	if (!twodmo(mo))
 		mo->momy += FixedMul(move, FINESINE(angle));
 }
 
@@ -90,7 +90,7 @@ void P_InstaThrust(mobj_t *mo, angle_t angle, fixed_t move)
 
 	mo->momx = FixedMul(move, FINECOSINE(angle));
 
-	if (LIKELY(!(twodlevel || (mo->flags2 & MF2_TWOD))))
+	if (!twodmo(mo))
 		mo->momy = FixedMul(move,FINESINE(angle));
 }
 
@@ -475,7 +475,7 @@ void P_PlayLivesJingle(player_t *player)
 
 	if (UNLIKELY(use1upSound))
 		S_StartSound(NULL, sfx_oneup);
-	else if (UNLIKELY(mariomode))
+	else if (mariomode)
 		S_StartSound(NULL, sfx_marioa);
 	else
 	{
@@ -503,7 +503,7 @@ void P_PlayRinglossSound(mobj_t *source, mobj_t *damager)
 			S_StartSound(NULL, sfx);
 		}
 		else
-			S_StartSound(source, UNLIKELY(mariomode) ? sfx_mario8 : sfx_khurt1 + key);
+			S_StartSound(source, mariomode ? sfx_mario8 : sfx_khurt1 + key);
 	}
 	else
 		S_StartSound(source, sfx_slip);
@@ -1725,7 +1725,7 @@ static void P_DoBubbleBreath(player_t *player)
 	else
 		zh = player->mo->z + FixedDiv(player->mo->height,5*(FRACUNIT/4));
 
-	if (!(player->mo->eflags & MFE_UNDERWATER) || player->spectator || ((player->powers[pw_shield] & SH_NOSTACK) == SH_ELEMENTAL && !(player->pflags & PF_NIGHTSMODE)))
+	if (!(player->mo->eflags & MFE_UNDERWATER) || player->spectator || ((player->powers[pw_shield] & SH_NOSTACK) == SH_ELEMENTAL && !nightsplayer(player)))
 		return;
 
 	if (P_RandomChance(FRACUNIT/16))
@@ -2298,7 +2298,7 @@ static void P_MovePlayer(player_t *player)
 		P_3dMovement(player);
 	}
 
-	if (UNLIKELY(maptol & TOL_2D)) // psure this doesent even work at all
+	if (twodlevel) // psure this doesent even work at all
 		runspd = FixedMul(runspd, 2*FRACUNIT/3);
 
 	/////////////////////////
@@ -2748,8 +2748,8 @@ boolean P_LookForEnemies(player_t *player)
 		if (modist > FixedMul(RING_DIST, player->mo->scale))
 			continue; // out of range
 
-		if (UNLIKELY((twodlevel || player->mo->flags2 & MF2_TWOD)
-		&& abs(player->mo->y-mo->y) > player->mo->radius))
+
+		if (twodmo(player->mo) && abs(player->mo->y-mo->y) > player->mo->radius)
 			continue; // not in your 2d plane
 
 		if (closestmo && modist > P_AproxDistance(P_AproxDistance(player->mo->x-closestmo->x,
@@ -3508,7 +3508,7 @@ static boolean P_CheckNoclipCameraPosition(player_t *player, camera_t *thiscam,
 	boolean cameranoclip;
 	mobj_t *mo = player->mo;
 
-	cameranoclip = ((player->pflags & (PF_NOCLIP|PF_NIGHTSMODE))
+	cameranoclip = (nightsplayer(player)
 	|| (mo->flags & (MF_NOCLIP|MF_NOCLIPHEIGHT)) // Noclipping player camera noclips too!!
 	|| (leveltime < introtime)); // Kart intro cam
 
@@ -4097,7 +4097,7 @@ boolean P_MoveChaseCamera(player_t *player, camera_t *thiscam, boolean resetcall
 			angle -= (angle - thiscam->pitch)/2;
 	}
 
-	if (player->playerstate != PST_DEAD && LIKELY(!((player->pflags & PF_NIGHTSMODE) && player->exiting)))
+	if (player->playerstate != PST_DEAD && !(nightsplayer(player) && player->exiting))
 		angle += (focusaiming < ANGLE_180 ? focusaiming/2 : InvAngle(InvAngle(focusaiming)/2)); // overcomplicated version of '((signed)focusaiming)/2;'
 
 	if (!camstill && !timeover) // Keep the view still...
@@ -4174,7 +4174,7 @@ boolean P_SpectatorJoinGame(player_t *player)
 	// Team changing in Team Match and CTF
 	// Pressing fire assigns you to a team that needs players if allowed.
 	// Partial code reproduction from p_tick.c autobalance code.
-	else if (UNLIKELY(G_GametypeHasTeams()))
+	else if (G_GametypeHasTeams())
 	{
 		INT32 changeto = 0;
 		INT32 z, numplayersred = 0, numplayersblue = 0;
@@ -4871,7 +4871,7 @@ void P_PlayerThink(player_t *player)
 
 	// Even if not NiGHTS, pull in nearby objects when walking around as John Q. Elliot.
 	if (UNLIKELY(!objectplacing && !((netgame || multiplayer) && player->spectator)
-	&& maptol & TOL_NIGHTS && (!(player->pflags & PF_NIGHTSMODE) || player->powers[pw_nights_helper])))
+	&& nightsmode && (!nightsplayer(player) || player->powers[pw_nights_helper])))
 	{
 		thinker_t *th;
 		mobj_t *mo2;
@@ -4973,7 +4973,7 @@ void P_PlayerThink(player_t *player)
 #endif
 
 	// check for use
-	if (LIKELY(!(player->pflags & PF_NIGHTSMODE)))
+	if (!nightsplayer(player))
 	{
 		if (cmd->buttons & BT_BRAKE)
 			player->pflags |= PF_USEDOWN;
@@ -5164,7 +5164,7 @@ void P_PlayerAfterThink(player_t *player)
 		}
 	}
 
-	if (UNLIKELY(player->pflags & PF_NIGHTSMODE))
+	if (nightsplayer(player))
 	{
 		player->powers[pw_gravityboots] = 0;
 	}

src/r_fps.cpp

@@ -340,14 +340,18 @@ void R_InterpolateMobjState(mobj_t *mobj, fixed_t frac, interpmobjstate_t *out)
 		return;
 	}
 
-	out->x = R_LerpFixed(mobj->old_x, mobj->x, frac);
-	out->y = R_LerpFixed(mobj->old_y, mobj->y, frac);
-	out->z = R_LerpFixed(mobj->old_z, mobj->z, frac);
+	const boolean doreset = mobj->resetinterp && (mobj->type != MT_GHOST) && (mobj->type != MT_PLAYERRETICULE) && (mobj->type != MT_SHADOW);
+
+	out->x = doreset ? mobj->x : R_LerpFixed(mobj->old_x, mobj->x, frac);
+	out->y = doreset ? mobj->y : R_LerpFixed(mobj->old_y, mobj->y, frac);
+	out->z = doreset ? mobj->z : R_LerpFixed(mobj->old_z, mobj->z, frac);
+
+	out->scale = mobj->resetinterp ? mobj->scale : R_LerpFixed(mobj->old_scale, mobj->scale, frac);
 	out->spritexscale = mobj->resetinterp ? mobj->spritexscale : R_LerpFixed(mobj->old_spritexscale, mobj->spritexscale, frac);
 	out->spriteyscale = mobj->resetinterp ? mobj->spriteyscale : R_LerpFixed(mobj->old_spriteyscale, mobj->spriteyscale, frac);
 	out->spritexoffset = mobj->resetinterp ? mobj->spritexoffset : R_LerpFixed(mobj->old_spritexoffset, mobj->spritexoffset, frac);
 	out->spriteyoffset = mobj->resetinterp ? mobj->spriteyoffset : R_LerpFixed(mobj->old_spriteyoffset, mobj->spriteyoffset, frac);
-	out->scale = mobj->resetinterp ? mobj->scale : R_LerpFixed(mobj->old_scale, mobj->scale, frac);
+
 	//out->subsector = R_PointInSubsector(out->x, out->y); // this is unused
 
 	if (mobj->player)
@@ -757,6 +761,45 @@ void R_UpdateMobjInterpolators(void)
 	}
 }
 
+// reset banan and eggbox rollangle when they´re on the ground
+// if not cv_bananthrowroll option "+Onground"
+static void R_ResetBananaRollangle(mobj_t* mobj)
+{
+	if (!mobj->rollangle)
+		return;
+
+	if (mobj->type != MT_BANANA && mobj->type != MT_EGGMANITEM) // always reset eggboxes
+		return;
+
+	// keep banans "rotated" if we want them to
+	if (mobj->type == MT_BANANA && cv_bananthrowroll.value == 2)
+		return;
+
+	// only reset if on ground
+	if (!P_IsObjectOnGround(mobj))
+		return;
+
+	mobj->rollangle = 0;
+}
+
+// Reset our Sprite scales and offsets
+// at the start of the tic
+// this is just to make things simpler
+// as we dont have to reset it ourselves after use
+// done at the start so lua can still overwrite everything
+static void R_ResetMobjSpriteStuff(mobj_t *mobj)
+{
+	mobj->spritexscale  = mobj->realxscale;
+	mobj->spriteyscale  = mobj->realyscale;
+	mobj->spritexoffset = mobj->realxoffset;
+	mobj->spriteyoffset = mobj->realyoffset;
+
+	mobj->temprollangle = 0;
+
+	// kinda stupid but idk where else to put this
+	R_ResetBananaRollangle(mobj);
+}
+
 //
 // P_ResetMobjInterpolationState
 //
@@ -795,19 +838,9 @@ void R_ResetMobjInterpolationState(mobj_t *mobj)
 		mobj->player->old_frameangle = mobj->player->frameangle;
 	}
 
-	// Reset our Sprite scales and offsets
-	// at the start of the tic
-	// this is just to make things simpler
-	// as we dont have to reset it ourselves after use
-	// done at the start so lua can still overwrite everything
-
 	// technically not interpolation related
 	// but this saves us another thinkerloop and multiple checks lel
-	mobj->spritexscale  = mobj->realxscale;
-	mobj->spriteyscale  = mobj->realyscale;
-	mobj->spritexoffset = mobj->realxoffset;
-	mobj->spriteyoffset = mobj->realyoffset;
-	mobj->temprollangle = 0;
+	R_ResetMobjSpriteStuff(mobj);
 
 	mobj->resetinterp = false;
 }

src/r_main.cpp

@@ -411,7 +411,7 @@ angle_t R_PlayerSliptideAngle(player_t *player)
 	if (!sprframe)
 		return 0;
 
-	if (sprframe->rotate != SRF_SINGLE || (mo->frame & FF_PAPERSPRITE))
+	if (sprframe->rotate != SRF_SINGLE || R_ThingIsPaperSprite(mo))
 		ang = R_PointToAngle(mo->x, mo->y) - mo->angle;
 
 	return FixedMul(FINECOSINE((ang) >> ANGLETOFINESHIFT), mo->player->sliproll * mo->player->kartstuff[k_aizdriftstrat]);
@@ -1389,6 +1389,21 @@ void R_RenderPlayerView(player_t *player)
 	maskcount_t*    masks    = static_cast<maskcount_t*>(malloc(sizeof(maskcount_t)));
 	const boolean   skybox   = (skyboxmo[0] && cv_skybox.value);
 
+	// Only do it if it's the first screen being rendered
+	if (cv_homremoval.value && viewssnum == 0)
+	{
+		if (cv_homremoval.value == 1)
+		{
+			// Clear the software screen buffer to remove HOM
+			memset(vid.screens[0], 31, vid.width * vid.height);
+		}
+		else if (cv_homremoval.value == 2)
+		{
+			//'development' HOM removal -- makes it blindingly obvious if HOM is spotted.
+			memset(vid.screens[0], 32+(timeinmap&15), vid.width * vid.height);
+		}
+	}
+
 	// load previous saved value of skyVisible for the player
 	skyVisible = skyVisiblePerPlayer[viewssnum];
 
@@ -1455,10 +1470,12 @@ void R_RenderPlayerView(player_t *player)
 	NetUpdate();
 
 	R_SetColumnContext(COLUMNCONTEXT_FLUSH);
+
 	ps_numbspcalls.value.i = ps_numpolyobjects.value.i = ps_numdrawnodes.value.i = 0;
 	PS_START_TIMING(ps_bsptime);
 	R_RenderViewpoint(&masks[nummasks - 1], true);
 	PS_STOP_TIMING(ps_bsptime);
+
 	PS_START_TIMING(ps_sw_spritecliptime);
 	R_ClipSprites(drawsegs, NULL);
 	PS_STOP_TIMING(ps_sw_spritecliptime);
@@ -1466,8 +1483,8 @@ void R_RenderPlayerView(player_t *player)
 
 	ps_numsprites.value.i = numvisiblesprites;
 
-	PS_START_TIMING(ps_sw_portaltime);
 	// Portal rendering. Hijacks the BSP traversal.
+	PS_START_TIMING(ps_sw_portaltime);
 	if (portal_base)
 	{
 		portal_t *portal;
@@ -1508,8 +1525,7 @@ void R_RenderPlayerView(player_t *player)
 
 	R_SetColumnContext(COLUMNCONTEXT_DIRECT);
 	PS_START_TIMING(ps_sw_planetime);
-	if (!skybox)
-		R_DrawSkyPlanes();
+	R_DrawSkyPlanes();
 	R_DrawPlanes();
 	PS_STOP_TIMING(ps_sw_planetime);
 	// draw mid texture and sprite
@@ -1517,6 +1533,7 @@ void R_RenderPlayerView(player_t *player)
 	PS_START_TIMING(ps_sw_maskedtime);
 	R_DrawMasked(masks, nummasks);
 	PS_STOP_TIMING(ps_sw_maskedtime);
+
 	free(masks);
 
 	// Check for new console commands.

src/r_portal.c

@@ -272,7 +272,7 @@ static boolean TrimVisplaneBounds(const visplane_t* plane, INT16* start, INT16*
  * Applies the necessary offsets and rotation to give
  * a depth illusion to the skybox.
  */
-void Portal_AddSkybox(const visplane_t* plane)
+static void Portal_AddSkybox(const visplane_t* plane)
 {
 	INT16 start, end;
 	mapheader_t *mh;
@@ -333,10 +333,13 @@ void Portal_AddSkyboxPortals(void)
 	INT32 i;
 	UINT16 count = 0;
 
-	for (i = 0; i < MAXVISPLANES; i++, pl++)
+	for (i = 0; i < MAXVISPLANES; i++)
 	{
 		for (pl = visplanes[i]; pl; pl = pl->next)
 		{
+			if (pl->minx >= pl->maxx)
+				continue;
+
 			if (pl->picnum == skyflatnum)
 			{
 				Portal_AddSkybox(pl);

src/r_portal.h

@@ -58,7 +58,6 @@ void Portal_Add2Lines	(const INT32 line1, const INT32 line2, const INT32 x1, con
 
 void Portal_ClipApply (const portal_t* portal);
 
-void Portal_AddSkybox(const visplane_t* plane);
 void Portal_AddSkyboxPortals(void);
 
 #ifdef __cplusplus

src/r_segs.cpp

@@ -713,16 +713,11 @@ void R_RenderThickSideRange(drawseg_t *drawseg, INT32 x1, INT32 x2, ffloor_t *pf
 	rw_scalestep = drawseg->scalestep;
 	spryscale = drawseg->scale1 + (x1 - drawseg->x1)*rw_scalestep;
 
-#define CLAMPMAX INT32_MAX
-#define CLAMPMIN (-INT32_MAX) // This is not INT32_MIN on purpose! INT32_MIN makes the drawers freak out.
 	auto overflow_clamp = [&](INT64 overflow_test)
 	{
-		return (overflow_test > (INT64)CLAMPMAX) ? CLAMPMAX :
-		(overflow_test > (INT64)CLAMPMIN) ? (fixed_t)overflow_test :
-		CLAMPMIN;
+		// This is not INT32_MIN on purpose! INT32_MIN makes the drawers freak out.
+		return (fixed_t)std::clamp<INT64>(overflow_test, (-INT32_MAX), INT32_MAX);
 	};
-#undef CLAMPMAX
-#undef CLAMPMIN
 
 	dc->numlights = 0;
 	if (frontsector->numlights)
@@ -2604,71 +2599,91 @@ void R_StoreWallRange(INT32 start, INT32 stop)
 	if (linedef->special == HORIZONSPECIAL) // HORIZON LINES
 	{
 		topstep = bottomstep = 0;
-		topfrac = bottomfrac = (centeryfrac>>4);
+		topfrac = bottomfrac = (centeryfrac >> 4);
 		topfrac++; // Prevent 1px HOM
 	}
 	else
 	{
+		topstep = -FixedMul(rw_scalestep, worldtop);
+		topfrac = (centeryfrac >> 4) - FixedMul(worldtop, rw_scale);
+
 		// for anyone that sees this
 		// dont.
 		// this is absolute shit-tier hacks
 		// but i just cant determine this in any sane way
 		// but this checks a shitton of things to make software handle skies better
 
-		auto set_topstep_normal = [&]
-		{
-			topstep = -FixedMul(rw_scalestep, worldtop);
-			topfrac = (centeryfrac>>4) - FixedMul(worldtop, rw_scale);
-		};
-
 		// untextured seg
-		if (!segtextured && !curline->polyseg)
+		if (!segtextured && !curline->polyseg) // not for polyobjects.....
 		{
-			const bool tophigh = (worldhigh <= worldtop && worldhighslope <= worldtopslope);
+			const boolean nofrontsky = (frontsector->floorpic != skyflatnum && frontsector->ceilingpic != skyflatnum);
+			const boolean inskybox = (skyboxmo[0] && cv_skybox.value && newview->sky); // dont mess with skyVisible within skybox rendering!
 
-			// if we cant see the goddamn skyplane, well there wont be any skybox
-			// we could kill skyVisible instead, but i want to keep the performance improvements it yields
-			// so we do this absolute trash
-			if ((tophigh
-				&& (frontsector->floorpic != skyflatnum && frontsector->ceilingpic != skyflatnum)) // try to guess if its a "window"
-				&& ((!backsector) // single sided
-				|| ((backsector && (worldhigh != worldtop || worldhighslope != worldtopslope))
-				&& (backsector->floorheight >= frontsector->ceilingheight || backsector->ceilingheight <= frontsector->floorheight)))) // check if there is a "thok" sector behind it
-				skyVisible = true;
-
-			// this is an attempt to fix issues with textureless single sided lines drawing nothing where they should just draw sky instead
-			if (tophigh && !backsector && frontsector->ceilingpic == skyflatnum)
+			// single sided line
+			if (!backsector)
 			{
-				// account for slopes to try and get rid of sharp edges from the black void
-				if (frontsector->f_slope || (backsector && backsector->f_slope))
+				// this is an attempt to fix issues with textureless single sided lines drawing nothing where they should just draw sky instead
+
+				// there is a sky flat on the ceiling
+				// so we can assume this is supposed to draw the sky
+				if (frontsector->ceilingpic == skyflatnum)
 				{
-					topstep = -FixedMul(rw_scalestep, worldbottomslope);
-					topfrac = (centeryfrac>>4) - FixedMul(worldbottomslope, rw_scale);
+					// just draw sky from top to bottom!
+					if (frontsector->f_slope)
+					{
+						topstep = -FixedMul(rw_scalestep, worldbottomslope);
+						topfrac = (centeryfrac >> 4) - FixedMul(worldbottomslope, rw_scale);
+					}
+					else
+					{
+						topstep = -FixedMul(rw_scalestep, worldbottom);
+						topfrac = (centeryfrac >> 4) - FixedMul(worldbottom, rw_scale);
+					}
 				}
-				else
+				else if (nofrontsky && !inskybox)
 				{
-					topstep = -FixedMul(rw_scalestep, worldbottom);
-					topfrac = (centeryfrac>>4) - FixedMul(worldbottom, rw_scale);
+					// completely empty wall without sky flats, just assume skybox is visible then
+					skyVisible = true;
 				}
 			}
-			else
-				set_topstep_normal();
+			else if (nofrontsky && !inskybox) // if there was a skyflat, drawplane would already set skyvisible
+			{
+				// "thok walls" are double sided
+				// so we need to check a few things here
+				// to be rather conservative
+				// as skyrendering is pretty costly!
+
+				// ideally we´d just dont care and always draw the skytexture
+				// or skybox at any time, like gl does
+				// wonder if there would be a fast way to draw atleast just the texture?
+
+				// gotta shift those here for proper comparisons
+				const INT32 whigh = worldhigh >> 4;
+				const INT32 whslope = worldhighslope >> 4;
+
+				// check if there is a window to force skybox to draw
+				if ((whigh <= worldtop && whslope <= worldtopslope) && (backsector->ceilingpic == skyflatnum)) // backsector has a skyflat?
+					skyVisible = true;
+				// otherwise check for thokwalls
+				else if ((whigh != worldtop || whslope != worldtopslope) &&   // FIXME: i forgor what this was for lol
+					(backsector->floorheight >= frontsector->ceilingheight || // thok walls usually are set up like that...
+					frontsector->floorheight >= backsector->ceilingheight))   // floor higher than the other sides ceiling
+					skyVisible = true;
+			}
 		}
-		else
-			set_topstep_normal();
 
 		bottomstep = -FixedMul(rw_scalestep, worldbottom);
-		bottomfrac = (centeryfrac>>4) - FixedMul(worldbottom, rw_scale);
+		bottomfrac = (centeryfrac >> 4) - FixedMul(worldbottom, rw_scale);
 
 		if (frontsector->c_slope)
 		{
-			fixed_t topfracend = (centeryfrac>>4) - FixedMul(worldtopslope, ds_p->scale2);
+			fixed_t topfracend = (centeryfrac >> 4) - FixedMul(worldtopslope, ds_p->scale2);
 			topstep = (topfracend-topfrac)/(range);
 		}
 
 		if (frontsector->f_slope)
 		{
-			fixed_t bottomfracend = (centeryfrac>>4) - FixedMul(worldbottomslope, ds_p->scale2);
+			fixed_t bottomfracend = (centeryfrac >> 4) - FixedMul(worldbottomslope, ds_p->scale2);
 			bottomstep = (bottomfracend-bottomfrac)/(range);
 		}
 	}
@@ -2706,12 +2721,13 @@ void R_StoreWallRange(INT32 start, INT32 stop)
 				if (leftheight < worldbottom && rightheight < worldbottomslope)
 					continue;
 
-				if (leftheight > worldtop && rightheight > worldtopslope && i+1 < dc.numlights && frontsector->lightlist[i+1].height > frontsector->ceilingheight)
+				if ((leftheight > worldtop) && (rightheight > worldtopslope) &&
+					(i+1 < dc.numlights) && (frontsector->lightlist[i+1].height > frontsector->ceilingheight))
 					continue;
 			}
 
-			rlight->height = (centeryfrac>>4) - FixedMul(leftheight, rw_scale);
-			rlight->heightstep = (centeryfrac>>4) - FixedMul(rightheight, ds_p->scale2);
+			rlight->height = (centeryfrac >> 4) - FixedMul(leftheight, rw_scale);
+			rlight->heightstep = (centeryfrac >> 4) - FixedMul(rightheight, ds_p->scale2);
 			rlight->heightstep = (rlight->heightstep-rlight->height)/(range);
 			rlight->flags = static_cast<ffloortype_e>(light->flags);
 
@@ -2730,10 +2746,9 @@ void R_StoreWallRange(INT32 start, INT32 stop)
 				leftheight >>= 4;
 				rightheight >>= 4;
 
-				rlight->botheight = (centeryfrac>>4) - FixedMul(leftheight, rw_scale);
-				rlight->botheightstep = (centeryfrac>>4) - FixedMul(rightheight, ds_p->scale2);
+				rlight->botheight = (centeryfrac >> 4) - FixedMul(leftheight, rw_scale);
+				rlight->botheightstep = (centeryfrac >> 4) - FixedMul(rightheight, ds_p->scale2);
 				rlight->botheightstep = (rlight->botheightstep-rlight->botheight)/(range);
-
 			}
 
 			rlight->lightlevel = *light->lightlevel;
@@ -2754,13 +2769,14 @@ void R_StoreWallRange(INT32 start, INT32 stop)
 			if (linedef->special == HORIZONSPECIAL) // Horizon lines extend FOFs in contact with them too.
 			{
 				visffloor[i].f_step = 0;
-				visffloor[i].f_frac = (centeryfrac>>4);
+				visffloor[i].f_frac = (centeryfrac >> 4);
 				topfrac++; // Prevent 1px HOM
 			}
 			else
 			{
-				visffloor[i].f_frac = (centeryfrac>>4) - FixedMul(visffloor[i].f_pos, rw_scale);
-				visffloor[i].f_step = ((centeryfrac>>4) - FixedMul(visffloor[i].f_pos_slope, ds_p->scale2) - visffloor[i].f_frac)/(range);
+				visffloor[i].f_frac = (centeryfrac >> 4) - FixedMul(visffloor[i].f_pos, rw_scale);
+				visffloor[i].f_step = (centeryfrac >> 4) - FixedMul(visffloor[i].f_pos_slope, ds_p->scale2);
+				visffloor[i].f_step = (visffloor[i].f_step - visffloor[i].f_frac)/(range);
 			}
 		}
 	}
@@ -2774,9 +2790,8 @@ void R_StoreWallRange(INT32 start, INT32 stop)
 
 		if (toptexture)
 		{
-			fixed_t topfracend = (centeryfrac>>4) - FixedMul(worldhighslope, ds_p->scale2);
-
-			pixhigh = (centeryfrac>>4) - FixedMul (worldhigh, rw_scale);
+			fixed_t topfracend = (centeryfrac >> 4) - FixedMul(worldhighslope, ds_p->scale2);
+			pixhigh = (centeryfrac >> 4) - FixedMul(worldhigh, rw_scale);
 			pixhighstep = (topfracend-pixhigh)/(range);
 
 			// If the lowest part of a ceiling stretching down covers the entire screen
@@ -2786,9 +2801,8 @@ void R_StoreWallRange(INT32 start, INT32 stop)
 
 		if (bottomtexture)
 		{
-			fixed_t bottomfracend = (centeryfrac>>4) - FixedMul(worldlowslope, ds_p->scale2);
-
-			pixlow = (centeryfrac>>4) - FixedMul (worldlow, rw_scale);
+			fixed_t bottomfracend = (centeryfrac >> 4) - FixedMul(worldlowslope, ds_p->scale2);
+			pixlow = (centeryfrac >> 4) - FixedMul(worldlow, rw_scale);
 			pixlowstep = (bottomfracend-pixlow)/(range);
 
 			// If the highest part of a floor stretching up covers the entire screen

src/r_skins.c

@@ -817,7 +817,6 @@ void R_AddSkins(UINT16 wadnum, boolean local)
 	}
 
 #undef lnumskins
-	//sortSkinGrid();
 
 	return;
 }

src/r_state.h

@@ -90,7 +90,7 @@ extern side_t *sides;
 extern fixed_t viewx, viewy, viewz;
 extern angle_t viewangle, aimingangle, viewroll;
 extern UINT8 viewssnum; // splitscreen view number
-extern boolean viewsky, skyVisible;
+extern boolean skyVisible;
 extern boolean skyVisiblePerPlayer[MAXSPLITSCREENPLAYERS]; // saved values of skyVisible of each splitscreen player
 extern sector_t *viewsector;
 extern player_t *viewplayer;

src/r_things.cpp

@@ -87,6 +87,8 @@ static drawseg_xrange_item_t *drawsegs_xrange;
 static size_t drawsegs_xrange_size = 0;
 static INT32 drawsegs_xrange_count = 0;
 
+#define CLIP_UNDEF -2
+
 //
 // Sprite rotation 0 is facing the viewer,
 //  rotation 1 is one angle turn CLOCKWISE around the axis.
@@ -1241,9 +1243,9 @@ static void R_ProjectSprite(mobj_t *thing)
 		return;
 
 	const boolean mirrored = thing->mirrored;
-	const boolean vflip = (thing->eflags & MFE_VERTICALFLIP);
-	const boolean hflip = (!(thing->frame & FF_HORIZONTALFLIP) != !mirrored);
-	const boolean papersprite = (thing->frame & FF_PAPERSPRITE);
+	const boolean vflip    = R_ThingVerticallyFlipped(thing);
+	const boolean hflip    = (!R_ThingHorizontallyFlipped(thing) != !mirrored);
+	const boolean papersprite = R_ThingIsPaperSprite(thing);
 
 	// transform the origin point
 	tr_x = interp.x - viewx;
@@ -2221,6 +2223,7 @@ static void R_SortVisSprites(vissprite_t* vsprsortedhead, UINT32 start, UINT32 e
 				best = ds;
 			}
 		}
+
 		if (best)
 		{
 			best->next->prev = best->prev;
@@ -2629,7 +2632,7 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 
 	for (x = x1; x <= x2; x++)
 	{
-		spr->clipbot[x] = spr->cliptop[x] = -2;
+		spr->clipbot[x] = spr->cliptop[x] = CLIP_UNDEF;
 	}
 
 	// Scan drawsegs from end to start for obscuring segs.
@@ -2658,29 +2661,26 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 
 			ds = curr->user;
 
-			if (ds->portalpass != 66) // unused?
+			if (ds->portalpass > 0 && ds->portalpass <= portalrender)
+				continue; // is a portal
+
+			if (ds->scale1 > ds->scale2)
 			{
-				if (ds->portalpass > 0 && ds->portalpass <= portalrender)
-					continue; // is a portal
+				lowscale = ds->scale2;
+				scale = ds->scale1;
+			}
+			else
+			{
+				lowscale = ds->scale1;
+				scale = ds->scale2;
+			}
 
-				if (ds->scale1 > ds->scale2)
-				{
-					lowscale = ds->scale2;
-					scale = ds->scale1;
-				}
-				else
-				{
-					lowscale = ds->scale1;
-					scale = ds->scale2;
-				}
-
-				if (scale < spr->sortscale ||
-					(lowscale < spr->sortscale &&
-					!R_PointOnSegSide(spr->gx, spr->gy, ds->curline)))
-				{
-					// seg is behind sprite
-					continue;
-				}
+			if (scale < spr->sortscale ||
+				(lowscale < spr->sortscale &&
+				!R_PointOnSegSide(spr->gx, spr->gy, ds->curline)))
+			{
+				// seg is behind sprite
+				continue;
 			}
 
 			r1 = ds->x1 < x1 ? x1 : ds->x1;
@@ -2699,14 +2699,14 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 			{
 				// bottom sil
 				for (x = r1; x <= r2; x++)
-					if (spr->clipbot[x] == -2)
+					if (spr->clipbot[x] == CLIP_UNDEF)
 						spr->clipbot[x] = ds->sprbottomclip[x];
 			}
 			else if (silhouette == SIL_TOP)
 			{
 				// top sil
 				for (x = r1; x <= r2; x++)
-					if (spr->cliptop[x] == -2)
+					if (spr->cliptop[x] == CLIP_UNDEF)
 						spr->cliptop[x] = ds->sprtopclip[x];
 			}
 			else if (silhouette == (SIL_TOP|SIL_BOTTOM))
@@ -2714,9 +2714,9 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 				// both
 				for (x = r1; x <= r2; x++)
 				{
-					if (spr->clipbot[x] == -2)
+					if (spr->clipbot[x] == CLIP_UNDEF)
 						spr->clipbot[x] = ds->sprbottomclip[x];
-					if (spr->cliptop[x] == -2)
+					if (spr->cliptop[x] == CLIP_UNDEF)
 						spr->cliptop[x] = ds->sprtopclip[x];
 				}
 			}
@@ -2735,13 +2735,13 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 			if (mh <= 0 || (phs != -1 && viewz > sectors[phs].floorheight))
 			{                          // clip bottom
 				for (x = x1; x <= x2; x++)
-					if (spr->clipbot[x] == -2 || h < spr->clipbot[x])
+					if (spr->clipbot[x] == CLIP_UNDEF || h < spr->clipbot[x])
 						spr->clipbot[x] = (INT16)h;
 			}
 			else						// clip top
 			{
 				for (x = x1; x <= x2; x++)
-					if (spr->cliptop[x] == -2 || h > spr->cliptop[x])
+					if (spr->cliptop[x] == CLIP_UNDEF || h > spr->cliptop[x])
 						spr->cliptop[x] = (INT16)h;
 			}
 		}
@@ -2753,13 +2753,13 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 			if (phs != -1 && viewz >= sectors[phs].ceilingheight)
 			{                         // clip bottom
 				for (x = x1; x <= x2; x++)
-					if (spr->clipbot[x] == -2 || h < spr->clipbot[x])
+					if (spr->clipbot[x] == CLIP_UNDEF || h < spr->clipbot[x])
 						spr->clipbot[x] = (INT16)h;
 			}
 			else                       // clip top
 			{
 				for (x = x1; x <= x2; x++)
-					if (spr->cliptop[x] == -2 || h > spr->cliptop[x])
+					if (spr->cliptop[x] == CLIP_UNDEF || h > spr->cliptop[x])
 						spr->cliptop[x] = (INT16)h;
 			}
 		}
@@ -2769,10 +2769,10 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 	{
 		for (x = x1; x <= x2; x++)
 		{
-			if (spr->cliptop[x] == -2 || spr->szt > spr->cliptop[x])
+			if (spr->cliptop[x] == CLIP_UNDEF || spr->szt > spr->cliptop[x])
 				spr->cliptop[x] = spr->szt;
 
-			if (spr->clipbot[x] == -2 || spr->sz < spr->clipbot[x])
+			if (spr->clipbot[x] == CLIP_UNDEF || spr->sz < spr->clipbot[x])
 				spr->clipbot[x] = spr->sz;
 		}
 	}
@@ -2780,7 +2780,7 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 	{
 		for (x = x1; x <= x2; x++)
 		{
-			if (spr->cliptop[x] == -2 || spr->szt > spr->cliptop[x])
+			if (spr->cliptop[x] == CLIP_UNDEF || spr->szt > spr->cliptop[x])
 				spr->cliptop[x] = spr->szt;
 		}
 	}
@@ -2788,7 +2788,7 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 	{
 		for (x = x1; x <= x2; x++)
 		{
-			if (spr->clipbot[x] == -2 || spr->sz < spr->clipbot[x])
+			if (spr->clipbot[x] == CLIP_UNDEF || spr->sz < spr->clipbot[x])
 				spr->clipbot[x] = spr->sz;
 		}
 	}
@@ -2798,21 +2798,13 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 	// check for unclipped columns
 	for (x = x1; x <= x2; x++)
 	{
-		if (spr->clipbot[x] == -2)
+		if (spr->clipbot[x] == CLIP_UNDEF)
 			spr->clipbot[x] = (INT16)viewheight;
 
-		if (spr->cliptop[x] == -2)
+		if (spr->cliptop[x] == CLIP_UNDEF)
 			spr->cliptop[x] = -1;
 	}
 
-	// Check if it'll be visible
-	// Not done for floorsprites.
-	if (cv_spriteclip.value)
-	{
-		if (!R_CheckSpriteVisible(spr, x1, x2))
-			spr->cut = static_cast<spritecut_e>(spr->cut | SC_NOTVISIBLE);
-	}
-
 	if (portal)
 	{
 		INT32 start_index = std::max(portal->start, x1);
@@ -2823,6 +2815,7 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 			spr->clipbot[x] = -1;
 			spr->cliptop[x] = -1;
 		}
+
 		for (x = start_index; x <= end_index; x++)
 		{
 			if (spr->clipbot[x] > portal->floorclip[x - portal->start])
@@ -2830,12 +2823,21 @@ static void R_ClipVisSprite(vissprite_t *spr, INT32 x1, INT32 x2, portal_t* port
 			if (spr->cliptop[x] < portal->ceilingclip[x - portal->start])
 				spr->cliptop[x] = portal->ceilingclip[x - portal->start];
 		}
+
 		for (x = end_index + 1; x <= x2; x++)
 		{
 			spr->clipbot[x] = -1;
 			spr->cliptop[x] = -1;
 		}
 	}
+
+	// Check if it'll be visible
+	// Not done for floorsprites.
+	if (cv_spriteclip.value)
+	{
+		if (!R_CheckSpriteVisible(spr, x1, x2))
+			spr->cut = static_cast<spritecut_e>(spr->cut | SC_NOTVISIBLE);
+	}
 }
 
 void R_ClipSprites(drawseg_t* dsstart, portal_t* portal)
@@ -2908,8 +2910,9 @@ void R_ClipSprites(drawseg_t* dsstart, portal_t* portal)
 	{
 		vissprite_t *spr = R_GetVisSprite(clippedvissprites);
 
-		if (cv_spriteclip.value
-		&& (spr->szt > vid.height || spr->sz < 0))
+		if (cv_spriteclip.value &&
+			(spr->szt > vid.height || spr->sz < 0) &&
+			!spr->scalestep)
 		{
 			spr->cut = static_cast<spritecut_e>(spr->cut | SC_NOTVISIBLE);
 			continue;
@@ -2941,16 +2944,16 @@ void R_ClipSprites(drawseg_t* dsstart, portal_t* portal)
 /* Check if thing may be drawn from our current view. */
 boolean R_ThingVisible(mobj_t *thing)
 {
-	if (UNLIKELY((thing->sprite == SPR_NULL) || (thing->flags2 & MF2_DONTDRAW)))
+	if ((thing->sprite == SPR_NULL) || (thing->flags2 & MF2_DONTDRAW))
 		return false;
 
-	if (UNLIKELY(splitscreen))
+	if (splitscreen)
 	{
-		if    ((viewssnum == 0 && (thing->eflags & MFE_DRAWONLYFORP1))
-			|| (viewssnum == 1 && (thing->eflags & MFE_DRAWONLYFORP2))
-			|| (viewssnum == 2 && (thing->eflags & MFE_DRAWONLYFORP2))
-			|| (viewssnum == 3 && (thing->eflags & MFE_DRAWONLYFORP4)))
-			return true;
+		if    (((thing->eflags & MFE_DRAWONLYFORP1) && viewssnum != 0)
+			|| ((thing->eflags & MFE_DRAWONLYFORP2) && viewssnum != 1)
+			|| ((thing->eflags & MFE_DRAWONLYFORP3) && viewssnum != 2)
+			|| ((thing->eflags & MFE_DRAWONLYFORP4) && viewssnum != 3))
+			return false;
 	}
 
 	return true;
@@ -3022,11 +3025,37 @@ boolean R_CheckMobjInterpDist(mobj_t *thing)
 	return R_CheckInterpDist(thing);
 }
 
-boolean R_ThingIsFullBright(mobj_t *thing)
+boolean R_ThingHorizontallyFlipped(mobj_t *thing)
+{
+	return (thing->frame & FF_HORIZONTALFLIP);
+}
+
+boolean R_ThingVerticallyFlipped(mobj_t *thing)
+{
+	return (thing->eflags & MFE_VERTICALFLIP); //(thing->frame & FF_VERTICALFLIP);
+}
+
+boolean R_ThingIsPaperSprite(mobj_t *thing)
+{
+	return (thing->frame & FF_PAPERSPRITE);
+}
+
+template<typename T>
+static boolean R_ThingIsFullBrightT(T *thing)
 {
 	return ((thing->frame & FF_BRIGHTMASK) == FF_FULLBRIGHT);
 }
 
+boolean R_PrecipThingIsFullBright(precipmobj_t *thing)
+{
+	return R_ThingIsFullBrightT(thing);
+}
+
+boolean R_ThingIsFullBright(mobj_t *thing)
+{
+	return R_ThingIsFullBrightT(thing);
+}
+
 boolean R_ThingIsSemiBright(mobj_t *thing)
 {
 	return ((thing->frame & FF_BRIGHTMASK) == FF_SEMIBRIGHT);

src/r_things.h

@@ -88,6 +88,11 @@ boolean R_CheckPrecipMobjInterpDist(precipmobj_t *thing);
 boolean R_CheckMobjInterpDist(mobj_t *thing);
 fixed_t R_DoPlayerFade(mobj_t *thing);
 
+boolean R_ThingHorizontallyFlipped(mobj_t *thing);
+boolean R_ThingVerticallyFlipped(mobj_t *thing);
+boolean R_ThingIsPaperSprite(mobj_t *thing);
+
+boolean R_PrecipThingIsFullBright(precipmobj_t *thing);
 boolean R_ThingIsFullBright(mobj_t *thing);
 boolean R_ThingIsSemiBright(mobj_t *thing);
 boolean R_ThingIsFullDark(mobj_t *thing);

src/s_sound.c

@@ -1297,9 +1297,7 @@ static boolean ReadMusicDefFields(UINT16 wadnum, int line, char *stoken, musicde
 
 		if (!value)
 		{
-			CONS_Alert(CONS_WARNING,
-					"MUSICDEF: Field '%s' is missing name. (file %s, line %d)\n",
-					stoken, wadfiles[wadnum]->filename, line);
+			CONS_Alert(CONS_WARNING, "MUSICDEF: Field '%s' is missing name. (file %s, line %d)\n", stoken, wadfiles[wadnum]->filename, line);
 			(void)strtok(NULL, " ");
 			return true;
 		}
@@ -1332,9 +1330,7 @@ static boolean ReadMusicDefFields(UINT16 wadnum, int line, char *stoken, musicde
 
 		if (!value)
 		{
-			CONS_Alert(CONS_WARNING,
-					"MUSICDEF: Field '%s' is missing value. (file %s, line %d)\n",
-					stoken, wadfiles[wadnum]->filename, line);
+			CONS_Alert(CONS_WARNING, "MUSICDEF: Field '%s' is missing value. (file %s, line %d)\n", stoken, wadfiles[wadnum]->filename, line);
 			(void)strtok(NULL, " ");
 			return true;
 		}
@@ -1344,9 +1340,7 @@ static boolean ReadMusicDefFields(UINT16 wadnum, int line, char *stoken, musicde
 
 			if (!def)
 			{
-				CONS_Alert(CONS_ERROR,
-						"MUSICDEF: No music definition before field '%s'. (file %s, line %d)\n",
-						stoken, wadfiles[wadnum]->filename, line);
+				CONS_Alert(CONS_ERROR, "MUSICDEF: No music definition before field '%s'. (file %s, line %d)\n", stoken, wadfiles[wadnum]->filename, line);
 				return false;
 			}
 
@@ -1358,11 +1352,19 @@ static boolean ReadMusicDefFields(UINT16 wadnum, int line, char *stoken, musicde
 
 			textline = value;
 
-// turn _ into spaces.
-#define ADDDEF(field)\
-	STRBUFCPY(def->field, textline);\
-	for (textline = def->field; *textline; textline++)\
-		if (*textline == '_') *textline = ' ';
+// turn _ into spaces while also removing trailing whitespaces.
+#define ADDDEF(field) \
+	int err = 0; \
+	STRBUFCPY(def->field, textline); \
+	size_t len = strlen(def->field); \
+	while (len > 0 && (def->field[len-1] == ' ')) { \
+		def->field[len-1] = 0; \
+		len--; \
+	} \
+	for (textline = def->field; *textline; textline++) { \
+		if (err == 0 && *textline == ' ') {err = 1; CONS_Alert(CONS_WARNING, "MUSICDEF: Erroneous whitespace detected in field '%s': '%s'.\n(file %s, line %d) Musicdef might not work correctly!\n", stoken, value, wadfiles[wadnum]->filename, line);} \
+		if (*textline == '_') *textline = ' '; \
+	}
 
 			if (fasticmp(stoken, "usage"))
 			{
@@ -1374,7 +1376,6 @@ static boolean ReadMusicDefFields(UINT16 wadnum, int line, char *stoken, musicde
 			}
 			else if (fasticmp(stoken, "title"))
 			{
-				def->use_info = true;
 				ADDDEF(title);
 			}
 			else if (fasticmp(stoken, "alttitle"))

src/s_sound.h

@@ -186,7 +186,6 @@ typedef struct musicdef_s
 	char title[256];
 	char alttitle[256];
 	char authors[256];
-	boolean use_info;
 	size_t num;
 } musicdef_t;
 

src/sdl/SDL_main/SDL_openxdk_main.c

@@ -1,7 +0,0 @@
-/* Include the SDL main definition header */
-#include "SDL_main.h"
-
-void XBoxStartup()
-{
-	SDL_main(0, NULL); /// \todo ?
-}

src/sdl/SRB2Pandora/Makefile.cfg

@@ -1,39 +0,0 @@
-# Quick Pandora target to make a compliant SRB2 PND file.
-
-PNDNAME=SRB2.pnd
-PNDDIR=$(BIN)/pnd
-ICON=sdl/SRB2Pandora/icon.png
-PXML=sdl/SRB2Pandora/PXML.xml
-
-SED=sed
-CAT=cat
-CP=cp
-XARGS=xargs
-FOR=for
-WGET=wget -P $(PNDDIR) -c -nc
-
-SHXARGS:=$(XARGS)
-SHSED:=$(SED)
-
-ifndef ECHO
-	CP:=@$(CP)
-	CAT:=@$(CAT)
-	SED:=@$(SED)
-	XARGS:=@$(XARGS)
-	FOR:=@(FOR)
-endif
-
-$(BIN)/$(PNDNAME): $(BIN)/$(EXENAME)
-	@echo Linking $(PNDNAME)...
-	$(MKDIR) $(PNDDIR)
-	$(CP) $(BIN)/$(EXENAME) $(PNDDIR)
-	$(CP) $(ICON) $(PNDDIR)
-	$(CP) $(PXML) $(PNDDIR)
-ifdef WITHDATA
-	$(FOR) datafile in $(shell echo $(D_FILES) | $(SHSED) 's/\.srb/\.wad/' | $(SHXARGS) -n 1 basename); do \
-		$(WGET) http://alam.srb2.org/SRB2/2.0.6-Final/Resources/$$datafile; \
-	done
-endif
-	$(MKISOFS) -l -r -o $@ $(PNDDIR)
-	$(CAT) $(PXML) >> $@
-	$(REMOVE) -r $(PNDDIR)

src/sdl/SRB2Pandora/PXML.xml

@@ -1,17 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
-<PXML xmlns="http://openpandora.org/namespaces/PXML">
-  <application id="srb2.pandora.v20" appdata="srb2">
-  <title lang="en_US">Sonic Robo Blast 2</title>
-  <title lang="ja_JA">ソニック・ロボ・ブラスト・２</title>
-  <description lang="en_US">A 3D Sonic fangame with a huge fanbase developing custom content, including characters, levels, and even large-scale modifications</description>
-  <version major="2" minor="0" release="6" build="1" />
-  <exec command="lsdlsrb2" background="true" standalone="true" x11="ignore"/>
-  <author name="Sonic Team Junior" website="http://www.srb2.org/" email="stjr@srb2.org"/>
-  <icon src="icon.png"/>
-  <categories>
-  <category name="Game">
-  <subcategory name="ActionGame" />
-  </category>
-  </categories>
-  </application>
-</PXML>

src/sdl/Srb2SDL.dsw

@@ -1,62 +0,0 @@
-Microsoft Developer Studio Workspace File, Format Version 6.00
-# WARNING: DO NOT EDIT OR DELETE THIS WORKSPACE FILE!
-
-###############################################################################
-
-Project: "Srb2SDL"=.\Srb2SDL.dsp - Package Owner=<4>
-
-Package=<5>
-{{{
-}}}
-
-Package=<4>
-{{{
-    Begin Project Dependency
-    Project_Dep_Name libpng
-    End Project Dependency
-    Begin Project Dependency
-    Project_Dep_Name zlib
-    End Project Dependency
-}}}
-
-###############################################################################
-
-Project: "libpng"="..\..\libs\libpng-src\projects\visualc6\libpng.dsp" - Package Owner=<4>
-
-Package=<5>
-{{{
-}}}
-
-Package=<4>
-{{{
-    Begin Project Dependency
-    Project_Dep_Name zlib
-    End Project Dependency
-}}}
-
-###############################################################################
-
-Project: "zlib"=..\..\libs\zlib\projects\visualc6\zlib.dsp - Package Owner=<4>
-
-Package=<5>
-{{{
-}}}
-
-Package=<4>
-{{{
-}}}
-
-###############################################################################
-
-Global:
-
-Package=<5>
-{{{
-}}}
-
-Package=<3>
-{{{
-}}}
-
-###############################################################################
-

src/sdl/Srb2SDL.props

@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <ImportGroup Label="PropertySheets" />
-  <PropertyGroup Label="UserMacros" />
-  <PropertyGroup />
-  <ItemDefinitionGroup>
-    <ClCompile>
-      <!-- x86/x64 defines: has specific libraries that ARM does not -->
-      <PreprocessorDefinitions Condition="'$(Platform)' == 'Win32' OR '$(Platform)' == 'x64'">HAVE_ZLIB;HAVE_LIBGME;USE_WGL_SWAP;HAVE_SDL;HWRENDER;HAVE_FILTER;HAVE_MIXER;SDLMAIN;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <!-- ARM defines -->
-      <PreprocessorDefinitions Condition="'$(Platform)' != 'Win32' AND '$(Platform)' != 'x64'">USE_WGL_SWAP;HAVE_SDL;HWRENDER;HAVE_FILTER;HAVE_MIXER;SDLMAIN;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-    </ClCompile>
-  </ItemDefinitionGroup>
-  <ItemGroup />
-</Project>

src/sdl/i_system.cpp

@@ -83,6 +83,12 @@ typedef LPVOID (WINAPI *p_MapViewOfFile) (HANDLE, DWORD, DWORD, DWORD, SIZE_T);
 #if defined (__unix__) || defined(__APPLE__) || (defined (UNIXCOMMON) && !defined (__HAIKU__))
 #if defined (__linux__)
 #include <sys/vfs.h>
+#elif defined(__APPLE__)
+#include <sys/param.h>
+#include <sys/mount.h>
+#include <sys/types.h>
+#include <sys/sysctl.h>
+#include <mach/mach.h>
 #else
 #include <sys/param.h>
 #include <sys/mount.h>
@@ -172,8 +178,7 @@ const char *wadSearchPaths[] = {
 
 /**	\brief WAD file to look for
 */
-#define WADKEYWORD1 "srb2.srb"
-#define WADKEYWORD2 "srb2.wad"
+#define WADKEYWORD "srb2.srb"
 /**	\brief holds wad path
 */
 static char returnWadPath[256];
@@ -555,12 +560,12 @@ void I_OutputMsg(const char *fmt, ...)
 {
 	size_t len;
 	char *txt;
-	va_list  argptr;
+	va_list argptr;
 
 	if (!fmt)
 		return;
 
-	va_start(argptr,fmt);
+	va_start(argptr, fmt);
 	len = vsnprintf(NULL, 0, fmt, argptr);
 	va_end(argptr);
 	if (len == 0)
@@ -571,7 +576,7 @@ void I_OutputMsg(const char *fmt, ...)
 	if (!txt)
 		I_Error("I_OutputMsg: Out of memory!\n");
 
-	va_start(argptr,fmt);
+	va_start(argptr, fmt);
 	vsprintf(txt, fmt, argptr);
 	va_end(argptr);
 
@@ -691,7 +696,7 @@ void I_OutputMsg(const char *fmt, ...)
 //
 // I_GetKey
 //
-INT32 I_GetKey (void)
+INT32 I_GetKey(void)
 {
 	// Warning: I_GetKey empties the event queue till next keypress
 	event_t *ev;
@@ -1700,7 +1705,7 @@ static void I_PrintSignal(INT32 signal_num, boolean core_dumped, char *signal_ms
 	sprintf(signal_name, "%s", signame);
 }
 
-static int I_OpenURL(const char *url)
+int I_OpenURL(const char *url)
 {
 #if SDL_VERSION_ATLEAST(2,0,14)
 	return SDL_OpenURL(va("%s", url));
@@ -1736,7 +1741,13 @@ static void I_ShowErrorBox(const char *title, const char *msg)
 	SDL_ShowMessageBox(&messageboxdata, &buttonid);
 
 	if (buttonid == 1)
-		I_OpenURL("https://github.com/Indev450/SRB2Kart-Saturn/issues");
+	{
+		int url = I_OpenURL(SATURNISSUEPAGE);
+
+		// SDL_OpenURL unsupported or failed
+		if (url == -1)
+			SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "Failed to Open Web Page", "Please open the following page in your web browser:\n" SATURNISSUEPAGE, NULL);
+	}
 }
 
 static void I_ShowSimpleErrorBox(const char *title, char *msg)
@@ -2253,7 +2264,6 @@ void I_ShutdownSystem(void)
 		logstream = NULL;
 	}
 #endif
-
 }
 
 void I_GetDiskFreeSpace(INT64 *freespace)
@@ -2425,7 +2435,7 @@ static boolean isWadPathOk(const char *path)
 	if (!wad3path)
 		return false;
 
-	sprintf(wad3path, pandf, path, WADKEYWORD1);
+	sprintf(wad3path, pandf, path, WADKEYWORD);
 
 	if (FIL_ReadFileOK(wad3path))
 	{
@@ -2465,10 +2475,10 @@ static void pathonly(char *s)
 */
 static const char *searchWad(const char *searchDir)
 {
-	static char tempsw[255] = "";
+	static char tempsw[256] = "";
 	filestatus_t fstemp;
 
-	strcpy(tempsw, WADKEYWORD1);
+	strcpy(tempsw, WADKEYWORD);
 	fstemp = filesearch(tempsw, searchDir, NULL, true, 20);
 	if (fstemp == FS_FOUND)
 	{
@@ -2629,13 +2639,13 @@ size_t I_GetFreeMem(size_t *total)
 		*total = 32 << 20;
 	return 32 << 20;
 #elif defined (_WIN32)
-	MEMORYSTATUS info;
+	MEMORYSTATUSEX info;
 
-	info.dwLength = sizeof (MEMORYSTATUS);
-	GlobalMemoryStatus( &info );
+	info.dwLength = sizeof (MEMORYSTATUSEX);
+	GlobalMemoryStatusEx( &info );
 	if (total)
-		*total = (size_t)info.dwTotalPhys;
-	return (size_t)info.dwAvailPhys;
+		*total = (size_t)info.ullTotalPhys;
+	return (size_t)info.ullAvailPhys;
 #elif defined (__OS2__)
 	UINT32 pr_arena;
 
@@ -2668,7 +2678,7 @@ size_t I_GetFreeMem(size_t *total)
 	{
 		// Error
 		if (total)
-			*total = 0L;
+			*total = 0;
 		return 0;
 	}
 
@@ -2677,12 +2687,12 @@ size_t I_GetFreeMem(size_t *total)
 	{
 		// Error
 		if (total)
-			*total = 0L;
+			*total = 0;
 		return 0;
 	}
 
 	memTag += sizeof (MEMTOTAL);
-	totalKBytes = (size_t)atoi(memTag);
+	totalKBytes = strtoul(memTag, NULL, 10);
 
 	if ((memTag = strstr(buf, MEMAVAILABLE)) == NULL)
 	{
@@ -2696,7 +2706,7 @@ size_t I_GetFreeMem(size_t *total)
 		{
 			// Error
 			if (total)
-				*total = 0L;
+				*total = 0;
 			return 0;
 		}
 		freeKBytes = MemAvailable;
@@ -2704,12 +2714,40 @@ size_t I_GetFreeMem(size_t *total)
 	else
 	{
 		memTag += sizeof (MEMAVAILABLE);
-		freeKBytes = atoi(memTag);
+		freeKBytes = strtoul(memTag, NULL, 10);
 	}
 
 	if (total)
 		*total = totalKBytes << 10;
 	return freeKBytes << 10;
+#elif defined(__APPLE__)
+	/* macOS */
+	mach_port_t host = mach_host_self();
+	kern_return_t kr;
+	mach_msg_type_number_t count;
+	vm_size_t v_page_size;
+	struct vm_statistics64 vm_stats;
+	uint64_t total_mem, free_mem;
+	size_t size;
+
+	size = sizeof(total_mem);
+	if (sysctlbyname("hw.memsize", &total_mem, &size, NULL, 0) < 0)
+		total_mem = 0;
+
+	kr = host_page_size(host, &v_page_size);
+	if (kr != KERN_SUCCESS)
+		v_page_size = 4096;
+
+	count = HOST_VM_INFO64_COUNT;
+	kr = host_statistics64(host, HOST_VM_INFO64, (host_info64_t)&vm_stats, &count);
+	if (kr == KERN_SUCCESS)
+		free_mem = (uint64_t)(vm_stats.free_count + vm_stats.inactive_count) * v_page_size;
+	else
+		free_mem = 0;
+
+	if (total)
+		*total = (size_t)total_mem;
+	return (size_t)free_mem;
 #else
 	// Guess 48 MB.
 	if (total)

src/sdl/i_video.c

@@ -1816,15 +1816,18 @@ void I_StartupGraphics(void)
 			framebuffer = SDL_TRUE;
 	}
 
+	// Choose Software renderer
 	if (M_CheckParm("-software"))
 		rendermode = render_soft;
 #ifdef HWRENDER
+	// Choose OpenGL renderer
 	else if (M_CheckParm("-opengl"))
 		rendermode = render_opengl;
 
 	msaa = 0; boolean msaa_set = false;
 	a2c = false; boolean a2c_set = false;
 
+	// MSAA antialiasing
 	if (M_CheckParm("-msaa") && M_IsNextParm())
 	{
 		const char* str = M_GetNextParm();

src/sounds.h

@@ -59,6 +59,8 @@ typedef enum
 #define NUMSFXFREESLOTS 1600 // Matches SOC Editor.
 #define NUMSKINSFXSLOTS (MAXSKINS*NUMSKINSOUNDS)
 
+#define MAXSOUNDNAME 7
+
 //
 // SoundFX struct.
 //

src/st_stuff.c

@@ -14,6 +14,7 @@
 ///        Does palette indicators as well (red pain/berserk, bright pickup)
 
 #include "doomdef.h"
+#include "d_main.h"
 #include "g_game.h"
 #include "g_input.h"
 #include "k_director.h"
@@ -172,7 +173,8 @@ INT32 st_palette = 0;
 void ST_ResetPaletteStuff(void)
 {
 	st_palette = 0;
-	V_SetPalette(0);
+	if (loaded_config)
+		V_SetPalette(0);
 }
 
 static void ST_doPaletteStuff(void)

src/v_video.c

@@ -676,6 +676,7 @@ static void CV_palette_OnChange(void)
 {
 	if (!loaded_config)
 		return;
+
 	// reload palette
 	// recalculate Color Cube
 	V_ReloadPalette();
@@ -1563,8 +1564,8 @@ void V_DrawFillConsoleMap(INT32 x, INT32 y, INT32 w, INT32 h, INT32 c)
 	{ // mpc 12-04-2018
 		const UINT8 *fadetable = ((UINT8 *)transtables + ((alphalevel-1)<<FF_TRANSSHIFT) + (c*256));
 #define clip(x,y) (x>y) ? y : x
-		w = clip(w,vid.width);
-		h = clip(h,vid.height);
+		w = clip(w, vid.width);
+		h = clip(h, vid.height);
 #undef clip
 		for (v = 0; v < h; v++, dest += vid.width)
 		{

src/w_wad.c

@@ -2733,7 +2733,7 @@ virtres_t* vres_GetMap(lumpnum_t lumpnum)
 			const char *name = (fileinfo + realentry)->name;
 			I_Assert(name != NULL);
 
-			if (CHECKMAPMARKER(name))
+			if (!name || CHECKMAPMARKER(name))
 			{
 				numlumps--; // We skip map marker, so 1 of entries becomes empty
 				continue; // This will skip i++ so we will write to same entry
@@ -2764,7 +2764,8 @@ virtres_t* vres_GetMap(lumpnum_t lumpnum)
 			const char *name = W_CheckNameForNum(lumppos);
 			I_Assert(name != NULL);
 
-			if (CHECKMAPMARKER(name))
+			// if no name then theres no lump
+			if (!name || CHECKMAPMARKER(name))
 			{
 				break;
 			}
@@ -2781,7 +2782,7 @@ virtres_t* vres_GetMap(lumpnum_t lumpnum)
 			const char *name = W_CheckNameForNum(lumpnum);
 			I_Assert(name != NULL);
 
-			if (CHECKMAPMARKER(name))
+			if (!name || CHECKMAPMARKER(name))
 			{
 				--i; // Decrement so on next iteration we write on same i, so we don't leave corrupted vlumps entry
 				numlumps--; // Just so we don't try to access the leftover vlumps entry

src/z_zone.cpp

@@ -114,6 +114,7 @@ void Z_Init(void)
 	head.next = head.prev = &head;
 
 	memfree = I_GetFreeMem(&total)>>20;
+
 	CONS_Printf("System memory: %sMB - Free: %sMB\n", sizeu1(total>>20), sizeu2(memfree));
 
 	// Note: This allocates memory. Watch out.
@@ -745,6 +746,7 @@ static void Command_Memfree_f(void)
 	CONS_Printf(M_GetText("HUD graphics           : %7s KB\n"), sizeu1(Z_TagUsage(PU_HUDGFX)>>10));
 	CONS_Printf(M_GetText("Locked cache           : %7s KB\n"), sizeu1(Z_TagUsage(PU_CACHE)>>10));
 	CONS_Printf(M_GetText("Level                  : %7s KB\n"), sizeu1(Z_TagUsage(PU_LEVEL)>>10));
+	CONS_Printf(M_GetText("Level (pooled)         : %7s KB\n"), sizeu1(Z_LevelPoolUsage()>>10));
 	CONS_Printf(M_GetText("Special thinker        : %7s KB\n"), sizeu1(Z_TagUsage(PU_LEVSPEC)>>10));
 	CONS_Printf(M_GetText("All purgable           : %7s KB\n"),
 		sizeu1(Z_TagsUsage(PU_PURGELEVEL, INT32_MAX)>>10));
@@ -804,6 +806,14 @@ char *Z_StrDup(const char *s)
 	return strcpy((char*)ZZ_Alloc(strlen(s) + 1), s);
 }
 
+size_t Z_LevelPoolUsage(void)
+{
+	return g_level_large_pool.allocated_bytes()
+		+ g_level_med_pool.allocated_bytes()
+		+ g_level_small_pool.allocated_bytes()
+		+ g_level_tiny_pool.allocated_bytes();
+}
+
 void* Z_LevelPoolMalloc(size_t size)
 {
 	void* p = nullptr;

src/z_zone.h

@@ -167,6 +167,7 @@ char *Z_StrDup(const char *in);
 //
 // Specialty allocation functions
 //
+size_t Z_LevelPoolUsage(void);
 void *Z_LevelPoolMalloc(size_t size);
 void *Z_LevelPoolCalloc(size_t size);
 void Z_LevelPoolFree(void *p, size_t size);