Avoid branch prediction slowdowns in bla bla but better

i hope
This commit is contained in:
alufolie91 committed 2023-10-19 09:39:35 +02:00
1 parent cd4482dd97
commit cd682e3961
1 file changed
+11 -9
+11 -9
View File
@@ -333,7 +333,7 @@ static void FlipCam4_OnChange(void)
//
// killough 5/2/98: reformatted
//
INT32 R_PointOnSide(fixed_t x, fixed_t y, node_t *node)
INT32 R_PointOnSide(fixed_t x, fixed_t y, node_t *restrict node)
{
if (!node->dx)
return x <= node->x ? node->dy > 0 : node->dy < 0;
@@ -344,14 +344,15 @@ INT32 R_PointOnSide(fixed_t x, fixed_t y, node_t *node)
x -= node->x;
y -= node->y;
// Try to quickly decide by looking at sign bits.
if ((node->dy ^ node->dx ^ x ^ y) < 0)
return (node->dy ^ x) < 0; // (left is negative)
return FixedMul(y, node->dx>>FRACBITS) >= FixedMul(node->dy>>FRACBITS, x);
// Try to quickly decide by looking at sign bits.
// also use a mask to avoid branch prediction
INT32 mask = (node->dy ^ node->dx ^ x ^ y) >> 31;
return (mask & ((node->dy ^ x) < 0)) | // (left is negative)
(~mask & (FixedMul(y, node->dx>>FRACBITS) >= FixedMul(node->dy>>FRACBITS, x)));
}
// killough 5/2/98: reformatted
INT32 R_PointOnSegSide(fixed_t x, fixed_t y, seg_t *line)
INT32 R_PointOnSegSide(fixed_t x, fixed_t y, seg_t *restrict line)
{
fixed_t lx = line->v1->x;
fixed_t ly = line->v1->y;
@@ -368,9 +369,10 @@ INT32 R_PointOnSegSide(fixed_t x, fixed_t y, seg_t *line)
y -= ly;
// Try to quickly decide by looking at sign bits.
if ((ldy ^ ldx ^ x ^ y) < 0)
return (ldy ^ x) < 0; // (left is negative)
return FixedMul(y, ldx>>FRACBITS) >= FixedMul(ldy>>FRACBITS, x);
// also use a mask to avoid branch prediction
INT32 mask = (ldy ^ ldx ^ x ^ y) >> 31;
return (mask & ((ldy ^ x) < 0)) | // (left is negative)
(~mask & (FixedMul(y, ldx>>FRACBITS) >= FixedMul(ldy>>FRACBITS, x)));
}
//