From cd682e3961757f1c1fd3cd496834896189dedf4e Mon Sep 17 00:00:00 2001 From: alufolie91 Date: Thu, 19 Oct 2023 09:39:35 +0200 Subject: [PATCH] Avoid branch prediction slowdowns in bla bla but better i hope --- src/r_main.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/r_main.c b/src/r_main.c index a4a353276..1d3a6968c 100644 --- a/src/r_main.c +++ b/src/r_main.c @@ -333,7 +333,7 @@ static void FlipCam4_OnChange(void) // // killough 5/2/98: reformatted // -INT32 R_PointOnSide(fixed_t x, fixed_t y, node_t *node) +INT32 R_PointOnSide(fixed_t x, fixed_t y, node_t *restrict node) { if (!node->dx) return x <= node->x ? node->dy > 0 : node->dy < 0; @@ -344,14 +344,15 @@ INT32 R_PointOnSide(fixed_t x, fixed_t y, node_t *node) x -= node->x; y -= node->y; - // Try to quickly decide by looking at sign bits. - if ((node->dy ^ node->dx ^ x ^ y) < 0) - return (node->dy ^ x) < 0; // (left is negative) - return FixedMul(y, node->dx>>FRACBITS) >= FixedMul(node->dy>>FRACBITS, x); + // Try to quickly decide by looking at sign bits. + // also use a mask to avoid branch prediction + INT32 mask = (node->dy ^ node->dx ^ x ^ y) >> 31; + return (mask & ((node->dy ^ x) < 0)) | // (left is negative) + (~mask & (FixedMul(y, node->dx>>FRACBITS) >= FixedMul(node->dy>>FRACBITS, x))); } // killough 5/2/98: reformatted -INT32 R_PointOnSegSide(fixed_t x, fixed_t y, seg_t *line) +INT32 R_PointOnSegSide(fixed_t x, fixed_t y, seg_t *restrict line) { fixed_t lx = line->v1->x; fixed_t ly = line->v1->y; @@ -368,9 +369,10 @@ INT32 R_PointOnSegSide(fixed_t x, fixed_t y, seg_t *line) y -= ly; // Try to quickly decide by looking at sign bits. - if ((ldy ^ ldx ^ x ^ y) < 0) - return (ldy ^ x) < 0; // (left is negative) - return FixedMul(y, ldx>>FRACBITS) >= FixedMul(ldy>>FRACBITS, x); + // also use a mask to avoid branch prediction + INT32 mask = (ldy ^ ldx ^ x ^ y) >> 31; + return (mask & ((ldy ^ x) < 0)) | // (left is negative) + (~mask & (FixedMul(y, ldx>>FRACBITS) >= FixedMul(ldy>>FRACBITS, x))); } //