saturn/SRB2Kart-Saturn
2
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 23 Wiki Activity

Fixup CMake, but simpler #220

Merged
alufolie91 merged 8 commits from fixcmake2 into Saturn-Next 2026-01-21 20:45:24 +01:00
Conversation 3 Commits 8 Files Changed 24
+241 -205
alufolie91 commented 2026-01-21 19:39:22 +01:00 (Migrated from github.com)
Copy link
Copy source

Based on parts of https://github.com/Indev450/SRB2Kart-Saturn/pull/216 and the CMake patch from https://github.com/Bijman/srb2bld
This does not completely replace everything like https://github.com/Indev450/SRB2Kart-Saturn/pull/216 does, but fixes the current CMake build system instead, reducing the risk of breaking stuff
Works fine on linux, but needs testing on MacOS, Windows is untested but i assume it does not work and i dont intend to support it at this time

Based on parts of https://github.com/Indev450/SRB2Kart-Saturn/pull/216 and the CMake patch from https://github.com/Bijman/srb2bld This does not completely replace everything like https://github.com/Indev450/SRB2Kart-Saturn/pull/216 does, but fixes the current CMake build system instead, reducing the risk of breaking stuff Works fine on linux, but needs testing on MacOS, Windows is untested but i assume it does not work and i dont intend to support it at this time
🎉 1
alufolie91 commented 2026-01-21 19:42:01 +01:00 (Migrated from github.com)
Copy link
Copy source

@P-AS if you could test this with mac would be much appreciated, since i have not set up anything on my mac not sure if it even would work with how old it is eitherways

@P-AS if you could test this with mac would be much appreciated, since i have not set up anything on my mac ~~not sure if it even would work with how old it is eitherways~~
P-AS (Migrated from github.com) reviewed 2026-01-21 19:54:56 +01:00
src/CMakeLists.txt
@@ -40,19 +46,25 @@ set(SRB2_CORE_SOURCES
mserv.c
P-AS (Migrated from github.com) commented 2026-01-21 19:54:56 +01:00
Copy link
Copy source

Why comment this out? Can successfully build this on macOS after I uncomment this.

Why comment this out? Can successfully build this on macOS after I uncomment this.
alufolie91 (Migrated from github.com) reviewed 2026-01-21 20:05:17 +01:00
src/CMakeLists.txt
@@ -40,19 +46,25 @@ set(SRB2_CORE_SOURCES
mserv.c
alufolie91 (Migrated from github.com) commented 2026-01-21 20:05:17 +01:00
Copy link
Copy source

Whoops, got confused by the string.c inclusion after, which is not needed
Fixed that now, good to hear it builds on mac!

Whoops, got confused by the string.c inclusion after, which is not needed Fixed that now, good to hear it builds on mac!
Sign in to join this conversation.
Reviewers
No Reviewers
P-AS
alufolie91
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
alufolie91 indev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saturn/SRB2Kart-Saturn#220