saturn/SRB2Kart-Saturn
2
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 23 Wiki Activity

Some interpolation related fixes #141

Merged
alufolie91 merged 16 commits from interpfixes into Saturn-Next 2024-11-17 21:25:42 +01:00
Conversation 9 Commits 16 Files Changed 9
+48 -25
alufolie91 commented 2024-11-09 17:09:58 +01:00 (Migrated from github.com)
Copy link
Copy source

Most are from RR
we had some of this in saturn before tho this time its minus moving R_UpdateViewInterpolation into G_Ticker as that caused issues in netgames
This def needs a bit of testing esp in netgames and under poor netconditions, as the stuff we had before sometimes caused jitter on mobjs
but this would fix some underlying issues with how view interpolation works
The code in p_telpt.c was supposed to use P_SetOrigin but that may not be netsafe so i set the interp values manually
also fixes https://github.com/Indev450/SRB2Kart-Saturn/issues/140

Most are from RR we had some of this in saturn before tho this time its minus moving R_UpdateViewInterpolation into G_Ticker as that caused issues in netgames This def needs a bit of testing esp in netgames and under poor netconditions, as the stuff we had before sometimes caused jitter on mobjs but this would fix some underlying issues with how view interpolation works The code in p_telpt.c was supposed to use P_SetOrigin but that may not be netsafe so i set the interp values manually also fixes https://github.com/Indev450/SRB2Kart-Saturn/issues/140
alufolie91 commented 2024-11-09 17:17:07 +01:00 (Migrated from github.com)
Copy link
Copy source

im a bit unsure actually about the stuff in y_inter mainly cause i dont really understand whats even going on there lol, would be cool if you would look at that @Indev450 X)

im a bit unsure actually about the stuff in y_inter mainly cause i dont really understand whats even going on there lol, would be cool if you would look at that @Indev450 X)
Indev450 commented 2024-11-10 11:59:19 +01:00 (Migrated from github.com)
Copy link
Copy source

I don't know what's going on in y_inter either x)
I dunno what that jitter does but i think changing it like that will change behaviour, since it will not be reset like it used to. Which is probably fine but dunno if that's intended

I don't know what's going on in y_inter either x) I dunno what that jitter does but i think changing it like that will change behaviour, since it will not be reset like it used to. Which is probably fine but dunno if that's intended
Indev450 (Migrated from github.com) reviewed 2024-11-10 12:01:27 +01:00
src/r_fps.c
@@ -207,21 +209,27 @@ void R_UpdateViewInterpolation(void)
Indev450 (Migrated from github.com) commented 2024-11-10 12:01:27 +01:00
Copy link
Copy source

This probably should have parentheses around == ((last_view_update == I_GetTime()) ? 1 : 2;). Not sure about order of operations here but just to be safe

This probably should have parentheses around == (`(last_view_update == I_GetTime()) ? 1 : 2;`). Not sure about order of operations here but just to be safe
Indev450 (Migrated from github.com) reviewed 2024-11-10 12:02:08 +01:00
src/r_fps.c
@@ -240,5 +240,5 @@
pview_old[p].z += zdiff;
pview_old[p].angle += angdiff;
}
void R_SetViewContext(enum viewcontext_e _viewcontext)
Indev450 (Migrated from github.com) commented 2024-11-10 12:02:07 +01:00
Copy link
Copy source

Shouldn't that be += instead of =?

Shouldn't that be `+=` instead of `=`?
Indev450 (Migrated from github.com) reviewed 2024-11-10 12:02:26 +01:00
src/r_fps.c
@@ -246,5 +246,5 @@
UINT8 i = 0;
I_Assert(_viewcontext >= VIEWCONTEXT_PLAYER1
&& _viewcontext <= VIEWCONTEXT_SKY4);
viewcontext = _viewcontext;
Indev450 (Migrated from github.com) commented 2024-11-10 12:02:26 +01:00
Copy link
Copy source

Same as above x)

Same as above x)
alufolie91 (Migrated from github.com) reviewed 2024-11-10 20:01:58 +01:00
src/r_fps.c
@@ -240,5 +240,5 @@
pview_old[p].z += zdiff;
pview_old[p].angle += angdiff;
}
void R_SetViewContext(enum viewcontext_e _viewcontext)
alufolie91 (Migrated from github.com) commented 2024-11-10 20:01:58 +01:00
Copy link
Copy source

well lol https://github.com/KartKrewDev/RingRacers/blob/dd45f3cd61a6afa83cac876a0ae7d43fa2d1ab43/src/r_fps.c#L175

well lol https://github.com/KartKrewDev/RingRacers/blob/dd45f3cd61a6afa83cac876a0ae7d43fa2d1ab43/src/r_fps.c#L175
alufolie91 (Migrated from github.com) reviewed 2024-11-12 16:15:02 +01:00
src/r_fps.c
@@ -207,21 +209,27 @@ void R_UpdateViewInterpolation(void)
alufolie91 (Migrated from github.com) commented 2024-11-12 16:15:02 +01:00
Copy link
Copy source

added some there

added some there
alufolie91 (Migrated from github.com) reviewed 2024-11-12 16:16:27 +01:00
src/r_fps.c
@@ -240,5 +240,5 @@
pview_old[p].z += zdiff;
pview_old[p].angle += angdiff;
}
void R_SetViewContext(enum viewcontext_e _viewcontext)
alufolie91 (Migrated from github.com) commented 2024-11-12 16:16:27 +01:00
Copy link
Copy source

actually testing with += currently

actually testing with += currently
alufolie91 (Migrated from github.com) reviewed 2024-11-12 16:37:19 +01:00
src/r_fps.c
@@ -240,5 +240,5 @@
pview_old[p].z += zdiff;
pview_old[p].angle += angdiff;
}
void R_SetViewContext(enum viewcontext_e _viewcontext)
alufolie91 (Migrated from github.com) commented 2024-11-12 16:37:19 +01:00
Copy link
Copy source

ye uh lmao its intentional so "do not add extra time for subsequent calls"

ye uh lmao its intentional so `"do not add extra time for subsequent calls"`
Sign in to join this conversation.
Reviewers
No Reviewers
Indev450
alufolie91
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
alufolie91 indev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saturn/SRB2Kart-Saturn#141