saturn/SRB2Kart-Saturn
2
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 23 Wiki Activity

Uncap hardcode HUD #120

Merged
GenericHeroGuy merged 13 commits from hud-uncap into Saturn-Next 2024-03-21 22:40:46 +01:00
Conversation 4 Commits 13 Files Changed 10
+169 -173
GenericHeroGuy commented 2024-03-19 00:08:22 +01:00 (Migrated from github.com)
Copy link
Copy source

As the title suggests, this PR uncaps... uh... everything!

Here's the full list:

  • FINISH and LAP animations
  • Level title (intro)
  • Intermission scoreboard
  • Minimap icons
  • The title screen
  • Input display
  • Bottom-right logo in title screen demos
  • Battle full-screen animations
  • VHS effect misunderstood

Besides that, the other notable changes are:

  • LAP animation no longer segfaults on laps greater than 99
  • Added k_oldcardanimation; the battle animations are tied to the ticrate in a non-trivial way, so I had to interpolate them rather than uncapping 😅 (maybe there's a better way?) nope, breaks save games
  • Fixed nametags in splitscreen

TODO: K_getScreenCoords still needs uncapping done!

As the title suggests, this PR uncaps... uh... everything! Here's the full list: * FINISH and LAP animations * Level title (intro) * Intermission scoreboard * Minimap icons * The title screen * Input display * Bottom-right logo in title screen demos * Battle full-screen animations * ~~VHS effect~~ misunderstood Besides that, the other notable changes are: * LAP animation no longer segfaults on laps greater than 99 * ~~Added `k_oldcardanimation`; the battle animations are tied to the ticrate in a non-trivial way, so I had to interpolate them rather than uncapping 😅 (maybe there's a better way?)~~ nope, breaks [save games](https://github.com/Indev450/SRB2Kart-Saturn/blob/9b7eff1a33e57a2589173d3a8c4f3d2a2d0bd0ae/src/p_saveg.c#L138) * Fixed nametags in splitscreen ~~TODO: `K_getScreenCoords` still needs uncapping~~ done!
Indev450 (Migrated from github.com) reviewed 2024-03-19 10:40:20 +01:00
src/d_player.h
@@ -246,5 +246,5 @@
k_respawn, // Timer for the DEZ laser respawn effect
k_dropdash, // Charge up for respawn Drop Dash
k_throwdir, // Held dir of controls; 1 = forward, 0 = none, -1 = backward (was "player->heldDir")
k_lapanimation, // Used to show the lap start wing logo animation
Indev450 (Migrated from github.com) commented 2024-03-19 10:40:20 +01:00
Copy link
Copy source

This can probably cause desynch with vanilla clients since kartstuff is synched so fields after k_oldcardanimations will be synched wrong

This can probably cause desynch with vanilla clients since kartstuff is synched so fields after k_oldcardanimations will be synched wrong
alufolie91 (Migrated from github.com) reviewed 2024-03-19 11:21:21 +01:00
src/d_player.h
@@ -246,5 +246,5 @@
k_respawn, // Timer for the DEZ laser respawn effect
k_dropdash, // Charge up for respawn Drop Dash
k_throwdir, // Held dir of controls; 1 = forward, 0 = none, -1 = backward (was "player->heldDir")
k_lapanimation, // Used to show the lap start wing logo animation
alufolie91 (Migrated from github.com) commented 2024-03-19 11:21:21 +01:00
Copy link
Copy source

This breaks netcompability with vanilla hard. Joining a server hosted with this results in the game throwing an I_Error
Screenshot (136)

This breaks netcompability with vanilla hard. Joining a server hosted with this results in the game throwing an I_Error ![Screenshot (136)](https://github.com/Indev450/SRB2Kart-Saturn/assets/136046486/162025d9-476c-461c-8f35-60d2ff8091ff)
alufolie91 commented 2024-03-19 16:11:44 +01:00 (Migrated from github.com)
Copy link
Copy source

One other thing, it does change how the game looks and feels visually quite drastically.
Dont know how much extra work it would be, but id prefer if this could be toggable
(sounds kinda redundant ik, but i already see ppl or atleast a certain people complaining about this change)

One other thing, it does change how the game looks and feels visually quite drastically. Dont know how much extra work it would be, but id prefer if this could be toggable (sounds kinda redundant ik, but i already see ppl or atleast a certain people complaining about this change)
👍 1
GenericHeroGuy (Migrated from github.com) reviewed 2024-03-19 16:46:47 +01:00
src/d_player.h
@@ -246,5 +246,5 @@
k_respawn, // Timer for the DEZ laser respawn effect
k_dropdash, // Charge up for respawn Drop Dash
k_throwdir, // Held dir of controls; 1 = forward, 0 = none, -1 = backward (was "player->heldDir")
k_lapanimation, // Used to show the lap start wing logo animation
GenericHeroGuy (Migrated from github.com) commented 2024-03-19 16:46:47 +01:00
Copy link
Copy source

Shouldn't have rushed that one...
Turns out there was a better way after all!

Shouldn't have rushed that one... Turns out there *was* a better way after all!
Sign in to join this conversation.
Reviewers
No Reviewers
Indev450
alufolie91
GenericHeroGuy
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
alufolie91 indev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saturn/SRB2Kart-Saturn#120