ReFuel/ReFuel.Gltf
4
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix extension loading and add image stream open #1

Merged
themixedupstuff merged 6 commits from JoeTwizzle/ReFuel.Gltf:master into master 2026-10-24 15:05:09 +02:00
Conversation 1 Commits 6 Files Changed 12
+359 -195
JoeTwizzle commented 2026-10-24 14:48:03 +02:00
Contributor
Copy Link
Copy Source

This PR makes extensions visible by checking for the right Json key and marking the respective GltfCollection as an extension collection.
It also adds stream open functionality for images without a URI such as when embedded in a .glb file.
In order to support this I had to make changes to the StreamWrapper class.
Updated to net10.0
Added KhrMaterialsEmissiveStrength in new extensions folder. (Not enabled by default)
Lastly the IExtensionProvider interface was changed in order to provide context about the parent type being parsed to the provider. This is needed for e.g. the KhrLightsPunctual extension.

This PR makes extensions visible by checking for the right Json key and marking the respective GltfCollection as an extension collection. It also adds stream open functionality for images without a URI such as when embedded in a .glb file. In order to support this I had to make changes to the StreamWrapper class. Updated to net10.0 Added KhrMaterialsEmissiveStrength in new extensions folder. (Not enabled by default) Lastly the IExtensionProvider interface was changed in order to provide context about the parent type being parsed to the provider. This is needed for e.g. the KhrLightsPunctual extension.
JoeTwizzle added 6 commits 2026-10-24 14:48:03 +02:00
Update to dotnet 10 129341ff6a
Rewrite streamwrapper to fix bugs (I forgot which) b93df6e769
Fix extension loading 71a8912635
Add Extension parent context fe9d87155c
Add stream open to bufferview & image f10973aed6
Remove BS comments e4e29a1907
themixedupstuff commented 2026-10-24 15:04:26 +02:00
Owner
Copy Link
Copy Source

Thank you for taking the time to work on parts of the project I had not had the chance to test/debug. I'm merging this as is. I will be writing unit tests to diagnose things further. Also, since I have no LICENCE.md, I think we can agree on the terms of the MIT license. I will create it very soon.

Thank you for taking the time to work on parts of the project I had not had the chance to test/debug. I'm merging this as is. I will be writing unit tests to diagnose things further. Also, since I have no LICENCE.md, I think we can agree on the terms of the MIT license. I will create it very soon.
themixedupstuff merged commit e4e29a1907 into master 2026-10-24 15:05:09 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AlphaChrome713 (AlphaChrome713) BoyBaykiller dweno themixedupstuff
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ReFuel/ReFuel.Gltf#1
Delete Branch "JoeTwizzle/ReFuel.Gltf:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?