From ec5afd3caf669fd4c97b17c565e75be23d723fc1 Mon Sep 17 00:00:00 2001 From: Alug Date: Tue, 2 Dec 2025 22:04:18 +0100 Subject: [PATCH] readd check for node before SV_SendSaveGame Apparently in some cases the server will connect to itself, in this case the server tries to send itself the savegame, leading to a crash in some cases. oops --- src/d_clisrv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/d_clisrv.c b/src/d_clisrv.c index cd2104080..3ce59761a 100644 --- a/src/d_clisrv.c +++ b/src/d_clisrv.c @@ -4783,7 +4783,7 @@ static size_t TotalTextCmdPerTic(tic_t tic) static void PT_ClientJoin(SINT8 node) { // Ignore duplicate packets - if (client || nodeingame[node]|| levelloading) + if (client || nodeingame[node] || levelloading) return; doomdata_t *netbuffer = DOOMCOM_DATA(doomcom); @@ -4920,8 +4920,11 @@ static void PT_ClientJoin(SINT8 node) if (nodewaiting[node]) { - SV_SendSaveGame(node, false); // send a complete game state - DEBFILE("send savegame\n"); + if (node) + { + SV_SendSaveGame(node, false); // send a complete game state + DEBFILE("send savegame\n"); + } SV_AddWaitingPlayers(node); }