From eb4eef52601e187ce81a426f0faaf6d126d5060e Mon Sep 17 00:00:00 2001 From: Alug Date: Tue, 1 Oct 2024 17:56:15 +0200 Subject: [PATCH] fix G_BuildMapTitle leaks --- src/d_netcmd.c | 5 ++++- src/hu_stuff.c | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/d_netcmd.c b/src/d_netcmd.c index 1322c4c5b..2b747a408 100644 --- a/src/d_netcmd.c +++ b/src/d_netcmd.c @@ -3141,7 +3141,10 @@ static void Command_ReplayMarker(void) demo.savemode = DSM_WILLAUTOSAVE; if (adjustedleveltime < 0) adjustedleveltime = 0; - snprintf(demo.titlename, 64, "%s [%i:%02d/%.5s]", G_BuildMapTitle(gamemap), G_TicsToMinutes(adjustedleveltime, false), G_TicsToSeconds(adjustedleveltime), modeattacking ? "Record Attack" : connectedservername); + char *title = G_BuildMapTitle(gamemap); + snprintf(demo.titlename, 64, "%s [%i:%02d/%.5s]", title, G_TicsToMinutes(adjustedleveltime, false), G_TicsToSeconds(adjustedleveltime), modeattacking ? "Record Attack" : connectedservername); + if (title) + Z_Free(title); CONS_Printf("Replay will be saved!\n"); } } diff --git a/src/hu_stuff.c b/src/hu_stuff.c index 9f96e31c1..9da5f4752 100644 --- a/src/hu_stuff.c +++ b/src/hu_stuff.c @@ -2630,10 +2630,14 @@ static void HU_DrawRankings(void) //V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, gametype_cons_t[gametype].strvalue); // draw the current map in the lower right if theres none just say its unknown - if (!G_BuildMapTitle(gamemap)) + char *maptitle = G_BuildMapTitle(gamemap); + if (!maptitle) V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, "UNKNOWN"); else - V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, G_BuildMapTitle(gamemap)); + { + V_DrawString(4, 188, hilicol|V_SNAPTOBOTTOM|V_SNAPTOLEFT, maptitle); + Z_Free(maptitle); + } if (!G_RaceGametype()) {