From ed9d520b4e698cc10a00fa9493573bd50143e569 Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 19:52:45 -0700 Subject: [PATCH 1/7] Retry contacting servers in the server browser every second until nettimeout --- src/d_clisrv.c | 59 +++++++++++++++++++++++++++++++++++++++----------- src/d_clisrv.h | 1 + src/m_menu.c | 2 ++ 3 files changed, 49 insertions(+), 13 deletions(-) diff --git a/src/d_clisrv.c b/src/d_clisrv.c index a14801203..e76b79284 100644 --- a/src/d_clisrv.c +++ b/src/d_clisrv.c @@ -1954,6 +1954,10 @@ static void SendAskInfo(INT32 node) serverelem_t serverlist[MAXSERVERLIST]; UINT32 serverlistcount = 0; +static boolean resendserverlistnode[MAXNETNODES]; +static boolean resendserverlist; +static tic_t serverlistepoch; + static void SL_ClearServerList(INT32 connectedserver) { UINT32 i; @@ -1965,6 +1969,8 @@ static void SL_ClearServerList(INT32 connectedserver) serverlist[i].node = 0; } serverlistcount = 0; + + memset(resendserverlistnode, 0, sizeof resendserverlistnode); } static UINT32 SL_SearchServer(INT32 node) @@ -1981,6 +1987,8 @@ static void SL_InsertServer(serverinfo_pak* info, SINT8 node) { UINT32 i; + resendserverlistnode[node] = false; + // search if not already on it i = SL_SearchServer(node); if (i == UINT32_MAX) @@ -2038,6 +2046,8 @@ void CL_QueryServerList (msg_server_t *server_list) CL_UpdateServerList(); + serverlistepoch = I_GetTime(); + for (i = 0; server_list[i].header.buffer[0]; i++) { // Make sure MS version matches our own, to @@ -2050,19 +2060,42 @@ void CL_QueryServerList (msg_server_t *server_list) if (node == -1) break; // no more node free SendAskInfo(node); - // Force close the connection so that servers can't eat - // up nodes forever if we never get a reply back from them - // (usually when they've not forwarded their ports). - // - // Don't worry, we'll get in contact with the working - // servers again when they send SERVERINFO to us later! - // - // (Note: as a side effect this probably means every - // server in the list will probably be using the same node (e.g. node 1), - // not that it matters which nodes they use when - // the connections are closed afterwards anyway) - // -- Monster Iestyn 12/11/18 - Net_CloseConnection(node|FORCECLOSE); + resendserverlistnode[node] = true; + // Leave this node open. It'll be closed if the + // request times out (CL_TimeoutServerList). + } + } + + resendserverlist = true; +} + +#define SERVERLISTRESENDRATE NEWTICRATE + +void CL_TimeoutServerList(void) +{ + if (netgame && resendserverlist) + { + const tic_t timediff = I_GetTime() - serverlistepoch; + const tic_t timetoresend = timediff % SERVERLISTRESENDRATE; + const boolean timedout = timediff > connectiontimeout; + + if (timedout || (timediff > 0 && timetoresend == 0)) + { + INT32 node; + + for (node = 1; node < MAXNETNODES; ++node) + { + if (resendserverlistnode[node]) + { + if (timedout) + Net_CloseConnection(node|FORCECLOSE); + else + SendAskInfo(node); + } + } + + if (timedout) + resendserverlist = false; } } } diff --git a/src/d_clisrv.h b/src/d_clisrv.h index ee0576156..7c6582383 100644 --- a/src/d_clisrv.h +++ b/src/d_clisrv.h @@ -594,6 +594,7 @@ void CL_ClearPlayer(INT32 playernum); void CL_RemovePlayer(INT32 playernum, INT32 reason); void CL_QueryServerList(msg_server_t *list); void CL_UpdateServerList(void); +void CL_TimeoutServerList(void); // Is there a game running boolean Playing(void); diff --git a/src/m_menu.c b/src/m_menu.c index b657d1c9b..ede65a32a 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -3447,6 +3447,8 @@ void M_Ticker(void) } I_unlock_mutex(ms_ServerList_mutex); #endif + + CL_TimeoutServerList(); } // From 53ee6524b48896a934fa54f90b2a1beaef8692a9 Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 22:08:04 -0700 Subject: [PATCH 2/7] Display the current status of server querying in the server browser While trying to contact servers: display how many servers are left. Once done: display the total number of servers available in game. --- src/d_clisrv.c | 8 ++++---- src/d_clisrv.h | 1 + src/m_menu.c | 31 ++++++++++++++++++++++++++++--- 3 files changed, 33 insertions(+), 7 deletions(-) diff --git a/src/d_clisrv.c b/src/d_clisrv.c index e76b79284..a3cb52562 100644 --- a/src/d_clisrv.c +++ b/src/d_clisrv.c @@ -1953,9 +1953,9 @@ static void SendAskInfo(INT32 node) serverelem_t serverlist[MAXSERVERLIST]; UINT32 serverlistcount = 0; +UINT32 serverlistultimatecount = 0; static boolean resendserverlistnode[MAXNETNODES]; -static boolean resendserverlist; static tic_t serverlistepoch; static void SL_ClearServerList(INT32 connectedserver) @@ -2066,14 +2066,14 @@ void CL_QueryServerList (msg_server_t *server_list) } } - resendserverlist = true; + serverlistultimatecount = i; } #define SERVERLISTRESENDRATE NEWTICRATE void CL_TimeoutServerList(void) { - if (netgame && resendserverlist) + if (netgame && serverlistultimatecount > serverlistcount) { const tic_t timediff = I_GetTime() - serverlistepoch; const tic_t timetoresend = timediff % SERVERLISTRESENDRATE; @@ -2095,7 +2095,7 @@ void CL_TimeoutServerList(void) } if (timedout) - resendserverlist = false; + serverlistultimatecount = serverlistcount; } } } diff --git a/src/d_clisrv.h b/src/d_clisrv.h index 7c6582383..4f8d098e3 100644 --- a/src/d_clisrv.h +++ b/src/d_clisrv.h @@ -502,6 +502,7 @@ typedef struct extern serverelem_t serverlist[MAXSERVERLIST]; extern UINT32 serverlistcount; +extern UINT32 serverlistultimatecount; extern INT32 mapchangepending; // Points inside doomcom diff --git a/src/m_menu.c b/src/m_menu.c index ede65a32a..8e35eee0a 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -8594,6 +8594,32 @@ static void M_Refresh(INT32 choice) #endif/*MASTERSERVER*/ } +static void M_DrawServerCountAndHorizontalBar(void) +{ + const char *text; + INT32 radius; + INT32 center = BASEVIDWIDTH/2; + + if (serverlistultimatecount > serverlistcount) + { + text = va("Pinging %d servers%.*s", + serverlistultimatecount - serverlistcount, + I_GetTime() / NEWTICRATE % 4, "..."); + } + else + { + text = va("%d servers found", serverlistcount); + } + + radius = V_StringWidth(text, 0) / 2; + + V_DrawCenteredString(center, currentMenu->y+28, 0, text); + + // Horizontal line! + V_DrawFill(1, currentMenu->y+32, center - radius - 2, 1, 0); + V_DrawFill(center + radius + 2, currentMenu->y+32, BASEVIDWIDTH - 1, 1, 0); +} + static void M_DrawConnectMenu(void) { UINT16 i; @@ -8618,11 +8644,10 @@ static void M_DrawConnectMenu(void) mservflags = mservflags|highlightflags|V_30TRANS; else mservflags = mservflags|warningflags; - V_DrawRightAlignedSmallString(BASEVIDWIDTH - currentMenu->x, currentMenu->y+14 + MP_ConnectMenu[mp_connect_page].alphaKey, + V_DrawRightAlignedSmallString(BASEVIDWIDTH - currentMenu->x, currentMenu->y+3 + MP_ConnectMenu[mp_connect_refresh].alphaKey, mservflags, va("MS: %s", cv_masterserver.string)); - // Horizontal line! - V_DrawFill(1, currentMenu->y+32, 318, 1, 0); + M_DrawServerCountAndHorizontalBar(); if (serverlistcount <= 0) V_DrawString(currentMenu->x,currentMenu->y+SERVERHEADERHEIGHT, 0, "No servers found"); From ca71fb02f386047bc4d93a6277c90f8539fd984c Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 22:10:27 -0700 Subject: [PATCH 3/7] Merge blue "checking for updates" pop up with server browser status line --- src/m_menu.c | 57 +++++++++++++++++++--------------------------------- 1 file changed, 21 insertions(+), 36 deletions(-) diff --git a/src/m_menu.c b/src/m_menu.c index 8e35eee0a..a1bd68a89 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -8571,15 +8571,6 @@ static void M_Refresh(INT32 choice) { (void)choice; - // Display a little "please wait" message. - M_DrawTextBox(52, BASEVIDHEIGHT/2-10, 25, 3); - V_DrawCenteredString(BASEVIDWIDTH/2, BASEVIDHEIGHT/2, 0, "Searching for servers..."); - V_DrawCenteredString(BASEVIDWIDTH/2, (BASEVIDHEIGHT/2)+12, 0, "Please wait."); - I_OsPolling(); - I_UpdateNoBlit(); - if (rendermode == render_soft) - I_FinishUpdate(); // page flip or blit buffer - // first page of servers serverlistpage = 0; @@ -8600,15 +8591,27 @@ static void M_DrawServerCountAndHorizontalBar(void) INT32 radius; INT32 center = BASEVIDWIDTH/2; - if (serverlistultimatecount > serverlistcount) + switch (M_GetWaitingMode()) { - text = va("Pinging %d servers%.*s", - serverlistultimatecount - serverlistcount, - I_GetTime() / NEWTICRATE % 4, "..."); - } - else - { - text = va("%d servers found", serverlistcount); + case M_WAITING_VERSION: + text = "Checking for updates"; + break; + + case M_WAITING_SERVERS: + text = "Loading server list"; + break; + + default: + if (serverlistultimatecount > serverlistcount) + { + text = va("Pinging %d servers%.*s", + serverlistultimatecount - serverlistcount, + I_GetTime() / NEWTICRATE % 4, "..."); + } + else + { + text = va("%d servers found", serverlistcount); + } } radius = V_StringWidth(text, 0) / 2; @@ -8626,8 +8629,7 @@ static void M_DrawConnectMenu(void) const char *gt = "Unknown"; const char *spd = ""; INT32 numPages = (serverlistcount+(SERVERS_PER_PAGE-1))/SERVERS_PER_PAGE; - int waiting; - int mservflags = V_ALLOWLOWERCASE; + INT32 mservflags = V_ALLOWLOWERCASE; for (i = FIRSTSERVERLINE; i < min(localservercount, SERVERS_PER_PAGE)+FIRSTSERVERLINE; i++) MP_ConnectMenu[i].status = IT_STRING | IT_SPACE; @@ -8692,23 +8694,6 @@ static void M_DrawConnectMenu(void) localservercount = serverlistcount; M_DrawGenericMenu(); - - waiting = M_GetWaitingMode(); - - if (waiting) - { - const char *message; - - if (waiting == M_WAITING_VERSION) - message = "Checking for updates..."; - else - message = "Searching for servers..."; - - // Display a little "please wait" message. - M_DrawTextBox(52, BASEVIDHEIGHT/2-10, 25, 3); - V_DrawCenteredString(BASEVIDWIDTH/2, BASEVIDHEIGHT/2, 0, message); - V_DrawCenteredString(BASEVIDWIDTH/2, (BASEVIDHEIGHT/2)+12, 0, "Please wait."); - } } static boolean M_CancelConnect(void) From 00c9abd6526f6784897238b6fcead46e8fb178f5 Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 22:20:24 -0700 Subject: [PATCH 4/7] Clear the server list when entering or refreshing the server browser --- src/m_menu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/m_menu.c b/src/m_menu.c index a1bd68a89..00c3f6d43 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -8574,14 +8574,14 @@ static void M_Refresh(INT32 choice) // first page of servers serverlistpage = 0; + CL_UpdateServerList(); + #ifdef MASTERSERVER #ifdef HAVE_THREADS Spawn_masterserver_thread("fetch-servers", Fetch_servers_thread); #else/*HAVE_THREADS*/ Fetch_servers_thread(NULL); #endif/*HAVE_THREADS*/ -#else/*MASTERSERVER*/ - CL_UpdateServerList(); #endif/*MASTERSERVER*/ } @@ -8820,6 +8820,9 @@ static void M_ConnectMenu(INT32 choice) // first page of servers serverlistpage = 0; + + CL_UpdateServerList(); + M_SetupNextMenu(&MP_ConnectDef); itemOn = 0; From 41d82d9baf148e6410236cb84126ab64f4f934a9 Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 22:26:23 -0700 Subject: [PATCH 5/7] Merge "No servers found" with server browser status line --- src/m_menu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/m_menu.c b/src/m_menu.c index 00c3f6d43..e0ad0db72 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -8608,10 +8608,14 @@ static void M_DrawServerCountAndHorizontalBar(void) serverlistultimatecount - serverlistcount, I_GetTime() / NEWTICRATE % 4, "..."); } - else + else if (serverlistcount > 0) { text = va("%d servers found", serverlistcount); } + else + { + text = "No servers found"; + } } radius = V_StringWidth(text, 0) / 2; @@ -8651,9 +8655,6 @@ static void M_DrawConnectMenu(void) M_DrawServerCountAndHorizontalBar(); - if (serverlistcount <= 0) - V_DrawString(currentMenu->x,currentMenu->y+SERVERHEADERHEIGHT, 0, "No servers found"); - else for (i = 0; i < min(serverlistcount - serverlistpage * SERVERS_PER_PAGE, SERVERS_PER_PAGE); i++) { INT32 slindex = i + serverlistpage * SERVERS_PER_PAGE; From def84a2cc0d37d26acafc3092563db4e56f8fae5 Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 21:08:13 -0700 Subject: [PATCH 6/7] Slide server browser pages left and right --- src/m_menu.c | 101 +++++++++++++++++++++++++++++++++++---------------- 1 file changed, 69 insertions(+), 32 deletions(-) diff --git a/src/m_menu.c b/src/m_menu.c index e0ad0db72..8b980174a 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -157,6 +157,8 @@ UINT8 maplistoption = 0; static char joystickInfo[8][29]; #ifndef NONET static UINT32 serverlistpage; +static UINT32 oldserverlistpage; +static float serverlistslidex; #endif //static saveinfo_t savegameinfo[MAXSAVEGAMES]; // Extra info about the save games. @@ -8539,12 +8541,18 @@ static void M_HandleServerPage(INT32 choice) case KEY_RIGHTARROW: S_StartSound(NULL, sfx_menu1); if ((serverlistpage + 1) * SERVERS_PER_PAGE < serverlistcount) - serverlistpage++; + { + oldserverlistpage = serverlistpage++; + serverlistslidex = BASEVIDWIDTH; + } break; case KEY_LEFTARROW: S_StartSound(NULL, sfx_menu1); if (serverlistpage > 0) - serverlistpage--; + { + oldserverlistpage = serverlistpage--; + serverlistslidex = -(BASEVIDWIDTH); + } break; default: @@ -8627,11 +8635,53 @@ static void M_DrawServerCountAndHorizontalBar(void) V_DrawFill(center + radius + 2, currentMenu->y+32, BASEVIDWIDTH - 1, 1, 0); } -static void M_DrawConnectMenu(void) +static void M_DrawServerLines(INT32 x, INT32 page) { UINT16 i; const char *gt = "Unknown"; const char *spd = ""; + + for (i = 0; i < min(serverlistcount - page * SERVERS_PER_PAGE, SERVERS_PER_PAGE); i++) + { + INT32 slindex = i + page * SERVERS_PER_PAGE; + UINT32 globalflags = ((serverlist[slindex].info.numberofplayer >= serverlist[slindex].info.maxplayer) ? V_TRANSLUCENT : 0) + |((itemOn == FIRSTSERVERLINE+i) ? highlightflags : 0)|V_ALLOWLOWERCASE; + + V_DrawString(x, S_LINEY(i), globalflags, serverlist[slindex].info.servername); + + // Don't use color flags intentionally, the global yellow color will auto override the text color code + if (serverlist[slindex].info.modifiedgame) + V_DrawSmallString(x+202, S_LINEY(i)+8, globalflags, "\x85" "Mod"); + if (serverlist[slindex].info.cheatsenabled) + V_DrawSmallString(x+222, S_LINEY(i)+8, globalflags, "\x83" "Cheats"); + + V_DrawSmallString(x, S_LINEY(i)+8, globalflags, + va("Ping: %u", (UINT32)LONG(serverlist[slindex].info.time))); + + gt = "Unknown"; + if (serverlist[slindex].info.gametype < NUMGAMETYPES) + gt = Gametype_Names[serverlist[slindex].info.gametype]; + + V_DrawSmallString(x+46,S_LINEY(i)+8, globalflags, + va("Players: %02d/%02d", serverlist[slindex].info.numberofplayer, serverlist[slindex].info.maxplayer)); + + V_DrawSmallString(x+112, S_LINEY(i)+8, globalflags, gt); + + // display game speed for race gametypes + if (serverlist[slindex].info.gametype == GT_RACE) + { + spd = kartspeed_cons_t[serverlist[slindex].info.kartvars & SV_SPEEDMASK].strvalue; + + V_DrawSmallString(x+132, S_LINEY(i)+8, globalflags, va("(%s Speed)", spd)); + } + + MP_ConnectMenu[i+FIRSTSERVERLINE].status = IT_STRING | IT_CALL; + } +} + +static void M_DrawConnectMenu(void) +{ + UINT16 i; INT32 numPages = (serverlistcount+(SERVERS_PER_PAGE-1))/SERVERS_PER_PAGE; INT32 mservflags = V_ALLOWLOWERCASE; @@ -8655,41 +8705,28 @@ static void M_DrawConnectMenu(void) M_DrawServerCountAndHorizontalBar(); - for (i = 0; i < min(serverlistcount - serverlistpage * SERVERS_PER_PAGE, SERVERS_PER_PAGE); i++) + // When switching pages, slide the old page and the + // new page across the screen + if (oldserverlistpage != serverlistpage) { - INT32 slindex = i + serverlistpage * SERVERS_PER_PAGE; - UINT32 globalflags = ((serverlist[slindex].info.numberofplayer >= serverlist[slindex].info.maxplayer) ? V_TRANSLUCENT : 0) - |((itemOn == FIRSTSERVERLINE+i) ? highlightflags : 0)|V_ALLOWLOWERCASE; + const float ease = serverlistslidex / 2.f; + const INT32 offx = serverlistslidex > 0 ? BASEVIDWIDTH : -(BASEVIDWIDTH); + const INT32 x = (FLOAT_TO_FIXED(serverlistslidex) + ease * rendertimefrac) / FRACUNIT; - V_DrawString(currentMenu->x, S_LINEY(i), globalflags, serverlist[slindex].info.servername); + M_DrawServerLines(currentMenu->x + x - offx, oldserverlistpage); + M_DrawServerLines(currentMenu->x + x, serverlistpage); - // Don't use color flags intentionally, the global yellow color will auto override the text color code - if (serverlist[slindex].info.modifiedgame) - V_DrawSmallString(currentMenu->x+202, S_LINEY(i)+8, globalflags, "\x85" "Mod"); - if (serverlist[slindex].info.cheatsenabled) - V_DrawSmallString(currentMenu->x+222, S_LINEY(i)+8, globalflags, "\x83" "Cheats"); - - V_DrawSmallString(currentMenu->x, S_LINEY(i)+8, globalflags, - va("Ping: %u", (UINT32)LONG(serverlist[slindex].info.time))); - - gt = "Unknown"; - if (serverlist[slindex].info.gametype < NUMGAMETYPES) - gt = Gametype_Names[serverlist[slindex].info.gametype]; - - V_DrawSmallString(currentMenu->x+46,S_LINEY(i)+8, globalflags, - va("Players: %02d/%02d", serverlist[slindex].info.numberofplayer, serverlist[slindex].info.maxplayer)); - - V_DrawSmallString(currentMenu->x+112, S_LINEY(i)+8, globalflags, gt); - - // display game speed for race gametypes - if (serverlist[slindex].info.gametype == GT_RACE) + if (interpTimerHackAllow) { - spd = kartspeed_cons_t[serverlist[slindex].info.kartvars & SV_SPEEDMASK].strvalue; + serverlistslidex -= ease; - V_DrawSmallString(currentMenu->x+132, S_LINEY(i)+8, globalflags, va("(%s Speed)", spd)); + if ((INT32)serverlistslidex == 0) + oldserverlistpage = serverlistpage; } - - MP_ConnectMenu[i+FIRSTSERVERLINE].status = IT_STRING | IT_CALL; + } + else + { + M_DrawServerLines(currentMenu->x, serverlistpage); } localservercount = serverlistcount; From 07452bc8fb15260f705d91430988146f119e8e6b Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 4 Sep 2022 22:45:39 -0700 Subject: [PATCH 7/7] Server browser: always display the number of servers found so far --- src/m_menu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/m_menu.c b/src/m_menu.c index 8b980174a..13511addb 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -8612,8 +8612,9 @@ static void M_DrawServerCountAndHorizontalBar(void) default: if (serverlistultimatecount > serverlistcount) { - text = va("Pinging %d servers%.*s", - serverlistultimatecount - serverlistcount, + text = va("%d/%d servers found%.*s", + serverlistcount, + serverlistultimatecount, I_GetTime() / NEWTICRATE % 4, "..."); } else if (serverlistcount > 0)