From a6bebb2d911243f60b27cfcdb1868c7e4d01a012 Mon Sep 17 00:00:00 2001 From: Alug Date: Tue, 15 Apr 2025 04:57:00 +0200 Subject: [PATCH] noooo dont free our lumppat for some reason this occasioncally causes an use after free?? our memory management honestly is a fucking mess ngl --- src/r_patch.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/r_patch.c b/src/r_patch.c index 968898bd1..36d550d3f 100644 --- a/src/r_patch.c +++ b/src/r_patch.c @@ -554,7 +554,7 @@ patch_t *Patch_GetRotatedSprite(spriteframe_t *sprite, size_t frame, size_t spri if (lump == LUMPERROR) return NULL; - patch = (patch_t *)W_CacheLumpNum(lump, PU_STATIC); + patch = (patch_t *)W_CachePatchNum(lump, PU_CACHE); // PU_LEVEL if (sprinfo->available) { @@ -568,9 +568,6 @@ patch_t *Patch_GetRotatedSprite(spriteframe_t *sprite, size_t frame, size_t spri } RotatedPatch_DoRotation(rotsprite, patch, rotationangle, xpivot, ypivot, flip); - - // free image data - Z_Free(patch); } return rotsprite->patches[idx];