From a5bf7719e78ee72f4b8ea4404cccb906733126af Mon Sep 17 00:00:00 2001 From: James R Date: Wed, 13 Nov 2019 14:31:44 -0800 Subject: [PATCH] Warn if the gametype is not valid at all! (cherry picked from commit 7776c59cddaa4cc09dfdb2f15192a194fda36eb7) --- src/d_netcmd.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/d_netcmd.c b/src/d_netcmd.c index c46fdc475..a758256d9 100644 --- a/src/d_netcmd.c +++ b/src/d_netcmd.c @@ -2671,15 +2671,21 @@ static void Command_Map_f(void) if (!gametype_cons_t[i].strvalue) // reached end of the list with no match { - d = atoi(gametypename); - // assume they gave us a gametype number, which is okay too - for (i = 0; gametype_cons_t[i].strvalue != NULL; i++) + /* Did they give us a gametype number? That's okay too! */ + if (isdigit(gametypename[0])) { - if (d == gametype_cons_t[i].value) - { - newgametype = gametype_cons_t[i].value; - break; - } + d = atoi(gametypename); + if (d >= 0 && d < NUMGAMETYPES) + newgametype = d; + } + else + { + CONS_Alert(CONS_ERROR, + "'%s' is not a gametype.\n", + gametypename); + Z_Free(realmapname); + Z_Free(mapname); + return; } } }