From 9b53a4e87f53f76e77aaee903d69b0e0c3e21267 Mon Sep 17 00:00:00 2001 From: Alug Date: Sun, 1 Mar 2026 21:32:25 +0100 Subject: [PATCH] w_wad: use strnlen to check lump length for map marker lump name may not be null terminated here, so strlen may read out of bounds garbo using strnlen ensures we read max 8 characters which is the name buffer size --- src/w_wad.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/w_wad.c b/src/w_wad.c index 8015a30da..32870945d 100644 --- a/src/w_wad.c +++ b/src/w_wad.c @@ -2671,11 +2671,12 @@ virtres_t* vres_GetMap(lumpnum_t lumpnum) { if (vsizecache[realentry] == 0) continue; + vlumps[i].size = vsizecache[realentry]; const char *name = (fileinfo + realentry)->name; - if (strlen(name) == 5 && memcmp(name, "MAP", 3) == 0) + if (strnlen(name, 8) == 5 && memcmp(name, "MAP", 3) == 0) { numlumps--; // We skip map marker, so 1 of entries becomes empty continue; // This will skip i++ so we will write to same entry