From 878c8fbacc975dfce2dd4bdf20136f17f4743b14 Mon Sep 17 00:00:00 2001 From: Alug Date: Tue, 3 Mar 2026 02:19:29 +0100 Subject: [PATCH] fix openmpt versions strings leaking from https://lib.openmpt.org/doc/libopenmpt_c_overview.html "All strings returned from libopenmpt are dynamically allocated and must be freed with openmpt_free_string()." didnt knew this tbh lol --- src/sdl/mixer_sound.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/sdl/mixer_sound.c b/src/sdl/mixer_sound.c index 7dccd9673..f177412e7 100644 --- a/src/sdl/mixer_sound.c +++ b/src/sdl/mixer_sound.c @@ -216,8 +216,13 @@ void I_StartupSound(void) SDLmixlinked->major, SDLmixlinked->minor, SDLmixlinked->patch); #ifdef HAVE_OPENMPT - I_OutputMsg("libopenmpt version: %s\n", openmpt_get_string("library_version")); - I_OutputMsg("libopenmpt build date: %s\n", openmpt_get_string("build")); + const char *openmptstr; + openmptstr = openmpt_get_string("library_version"); + I_OutputMsg("libopenmpt version: %s\n", openmptstr); + openmpt_free_string(openmptstr); + openmptstr = openmpt_get_string("build"); + I_OutputMsg("libopenmpt build date: %s\n", openmptstr); + openmpt_free_string(openmptstr); #endif sound_started = true;