From 7d58887138a02486489e8c8bb7ef2b1a79733bd9 Mon Sep 17 00:00:00 2001 From: Alug Date: Sat, 15 Mar 2025 16:30:52 +0100 Subject: [PATCH] replace magic number --- src/w_wad.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/w_wad.c b/src/w_wad.c index 8760fc8de..37c992d29 100644 --- a/src/w_wad.c +++ b/src/w_wad.c @@ -88,10 +88,11 @@ typedef struct // Must be a power of two #define LUMPNUMCACHESIZE 64 +#define LUMPNUMCACHENAME 32 typedef struct lumpnum_cache_s { - char lumpname[32]; + char lumpname[LUMPNUMCACHENAME]; lumpnum_t lumpnum; } lumpnum_cache_t; @@ -1183,12 +1184,12 @@ lumpnum_t W_CheckNumForLongName(const char *name) } else { - if (strlen(name) < 32) + if (strlen(name) < LUMPNUMCACHENAME) { // Update the cache. lumpnumcacheindex = (lumpnumcacheindex + 1) & (LUMPNUMCACHESIZE - 1); - memset(lumpnumcache[lumpnumcacheindex].lumpname, '\0', 32); - strlcpy(lumpnumcache[lumpnumcacheindex].lumpname, name, 32); + memset(lumpnumcache[lumpnumcacheindex].lumpname, '\0', LUMPNUMCACHENAME); + strlcpy(lumpnumcache[lumpnumcacheindex].lumpname, name, LUMPNUMCACHENAME); lumpnumcache[lumpnumcacheindex].lumpnum = (i << 16) + check; }