From 5f2a8acfa22e628d5e2dfdd3b26e407f7254dacc Mon Sep 17 00:00:00 2001 From: Alug Date: Sun, 6 Apr 2025 08:43:40 +0200 Subject: [PATCH] Optimze horizonline check noticed during profiling due to how it was checked R_PointOnSegSide was called extremely often even if the less expensive check returned false --- src/hardware/hw_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/hardware/hw_main.c b/src/hardware/hw_main.c index 03ca72f74..7515ef493 100644 --- a/src/hardware/hw_main.c +++ b/src/hardware/hw_main.c @@ -734,7 +734,10 @@ static void HWR_RenderPlane(subsector_t *subsector, extrasubsector_t *xsub, bool for (i = 0; i < subsector->numlines; i++, line++) { - if (!(line->linedef->special == HORIZONSPECIAL && R_PointOnSegSide(viewx, viewy, line) == 0)) + if (line->linedef->special != HORIZONSPECIAL) + continue; + + if (R_PointOnSegSide(viewx, viewy, line) != 0) continue; P_ClosestPointOnLine(viewx, viewy, line->linedef, &v);