From 4f07372e0fe6190ab547ec29bed03fd74b8672da Mon Sep 17 00:00:00 2001 From: Alug Date: Wed, 17 Jan 2024 12:11:32 +0100 Subject: [PATCH] (hopefully) fix overflow in R_DrawRepeatMaskedColumn MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit well this fixes the game hanging in software renderer on Marsh´s Marble Zone --- src/r_segs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/r_segs.c b/src/r_segs.c index 33e8f41c9..5cd377b75 100644 --- a/src/r_segs.c +++ b/src/r_segs.c @@ -690,7 +690,7 @@ static void R_DrawRepeatMaskedColumn(column_t *col) { while (sprtopscreen < sprbotscreen) { R_DrawMaskedColumn(col); - if ((INT64)sprtopscreen + dc_texheight*spryscale > (INT64)INT32_MAX) // prevent overflow + if (sprtopscreen + (INT64)dc_texheight*spryscale > (INT64)INT32_MAX) // prevent overflow sprtopscreen = INT32_MAX; else sprtopscreen += dc_texheight*spryscale;