From 4d5d9cae68445ce60bfa8b439920aefcc4bdd29a Mon Sep 17 00:00:00 2001 From: SteelT Date: Thu, 8 Feb 2024 01:26:07 -0500 Subject: [PATCH] discord.c: Fix joinSecret memory leak --- src/discord.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/discord.c b/src/discord.c index 9e297eea7..823900622 100644 --- a/src/discord.c +++ b/src/discord.c @@ -474,6 +474,7 @@ void DRPC_UpdatePresence(void) char charname[11+SKINNAMESIZE+1]; boolean joinSecretSet = false; + char *clientJoinSecret = NULL; DiscordRichPresence discordPresence; memset(&discordPresence, 0, sizeof(discordPresence)); @@ -530,7 +531,8 @@ void DRPC_UpdatePresence(void) // Grab the host's IP for joining. if ((join = DRPC_GetServerIP()) != NULL) { - discordPresence.joinSecret = DRPC_XORIPString(join); + clientJoinSecret = DRPC_XORIPString(join); + discordPresence.joinSecret = clientJoinSecret; joinSecretSet = true; } } @@ -712,6 +714,7 @@ void DRPC_UpdatePresence(void) } Discord_UpdatePresence(&discordPresence); + free(clientJoinSecret); } #endif // HAVE_DISCORDRPC