From 378eb28ad18da381fa96dd0d8f4f040cce28afda Mon Sep 17 00:00:00 2001 From: Indev Date: Fri, 8 Aug 2025 17:53:46 +0300 Subject: [PATCH] Fix potential buffer overflow in DEH_LoadDehackedFile --- src/dehacked.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/dehacked.c b/src/dehacked.c index ebe1c2098..401ef4c9e 100644 --- a/src/dehacked.c +++ b/src/dehacked.c @@ -2862,7 +2862,7 @@ static void DEH_LoadDehackedFile(MYFILE *f, UINT16 wad) dbg_line = -1; // start at -1 so the first line is 0. while (!myfeof(f)) { - char origpos[128]; + char origpos[256]; INT32 size = 0; char *traverse; @@ -2878,6 +2878,12 @@ static void DEH_LoadDehackedFile(MYFILE *f, UINT16 wad) size++; } + if (size > (int)sizeof(origpos)) + { + deh_warning("Line is too long"); + size = sizeof(origpos)-1; + } + strncpy(origpos, s, size); origpos[size] = '\0';