From 2eca62db79495f167bbe198a582f2d3090c832b5 Mon Sep 17 00:00:00 2001 From: Alug Date: Thu, 16 Oct 2025 13:54:42 +0200 Subject: [PATCH] G_SaveDemo: fix oob reads/writes for replay names demo.titlename has a size of 65! not 128! also handles memory failure and checks bounds for the remaining lenght in the demo slug --- src/g_demo.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/g_demo.c b/src/g_demo.c index e93ba712a..2018d8a8d 100644 --- a/src/g_demo.c +++ b/src/g_demo.c @@ -3569,7 +3569,8 @@ void G_SaveDemo(void) size_t i, strindex = 0; boolean dash = true; - for (i = 0; demo.titlename[i] && i < 127; i++) + //for (i = 0; demo.titlename[i] && i < 127; i++) ????? + for (i = 0; i < 64 && demo.titlename[i]; i++) { if ((demo.titlename[i] >= 'a' && demo.titlename[i] <= 'z') || (demo.titlename[i] >= '0' && demo.titlename[i] <= '9')) @@ -3601,9 +3602,18 @@ void G_SaveDemo(void) if (demo_slug[0] != '\0') { // Slug is valid, write the chosen filename. - writepoint = strstr(demoname, "-") + 1; - demo_slug[128 - (writepoint - demoname) - 4] = 0; - sprintf(writepoint, "%s.lmp", demo_slug); + writepoint = strstr(demoname, "-"); + if (!writepoint) + return; + + writepoint++; + + size_t flen = 128 - (writepoint - demoname) - 4; + if (flen > 0 && flen < 128) + { + demo_slug[flen] = '\0'; + sprintf(writepoint, "%s.lmp", demo_slug); + } } }