From 1d0fedddfd6e280db0a2f4f1de7ecbceffee41be Mon Sep 17 00:00:00 2001 From: Alug Date: Sun, 5 Oct 2025 04:05:45 +0200 Subject: [PATCH] add bounds check to R_GetLinedefTransTable --- src/r_segs.cpp | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/r_segs.cpp b/src/r_segs.cpp index bedec68ab..e5a542c72 100644 --- a/src/r_segs.cpp +++ b/src/r_segs.cpp @@ -152,7 +152,18 @@ static void R_Render2sidedMultiPatchColumn(drawcolumndata_t* dc, column_t *colum transnum_t R_GetLinedefTransTable(fixed_t alpha) { - return static_cast((20*(FRACUNIT - alpha - 1) + FRACUNIT) >> (FRACBITS+1)); + if (alpha >= FRACUNIT) + { + return static_cast(0); + } + else if (alpha <= 0) + { + return NUMTRANSMAPS; + } + else + { + return static_cast((20*(FRACUNIT - alpha - 1) + FRACUNIT) >> (FRACBITS+1)); + } } static inline boolean R_OverflowTest(drawcolumndata_t* dc) @@ -1916,8 +1927,7 @@ void R_StoreWallRange(INT32 start, INT32 stop) numbackffloors = 0; - for (i = 0; i < MAXFFLOORS; i++) - ds_p->thicksides[i] = NULL; + memset(ds_p->thicksides, 0, MAXFFLOORS * sizeof(*ds_p->thicksides)); if (numffloors) {