From 52cd614613e504dfb16768d2626ebbaa0b5f04bc Mon Sep 17 00:00:00 2001 From: Alug Date: Mon, 16 Dec 2024 16:37:38 +0100 Subject: [PATCH] prevent potential crash if viewmobj was removed --- src/r_main.c | 19 +++++++++++++++---- src/r_things.c | 2 +- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/r_main.c b/src/r_main.c index ccf872bba..9541fef41 100644 --- a/src/r_main.c +++ b/src/r_main.c @@ -1117,6 +1117,7 @@ void R_SkyboxFrame(int s) { player_t *player = &players[displayplayers[s]]; camera_t *thiscam = &camera[s]; + subsector_t * subsector = NULL; R_SetViewContext(VIEWCONTEXT_SKY1 + s); @@ -1124,7 +1125,7 @@ void R_SkyboxFrame(int s) newview->sky = true; viewmobj = skyboxmo[0]; #ifdef PARANOIA - if (!viewmobj) + if (P_MobjWasRemoved(viewmobj)) { const size_t playeri = (size_t)(player - players); I_Error("R_SkyboxFrame: viewmobj null (player %s)", sizeu1(playeri)); @@ -1203,7 +1204,10 @@ void R_SkyboxFrame(int s) } #undef SETUPSKYVIEW - R_SetupCommonFrame(player, viewmobj->subsector); + if (!P_MobjWasRemoved(viewmobj)) + subsector = viewmobj->subsector; + + R_SetupCommonFrame(player, subsector); } void R_SetupFrame(int s, boolean skybox) @@ -1211,6 +1215,7 @@ void R_SetupFrame(int s, boolean skybox) player_t *player = &players[displayplayers[s]]; camera_t *thiscam = &camera[s]; boolean chasecam = (cv_chasecam[s].value != 0); + subsector_t * subsector = NULL; R_SetViewContext(VIEWCONTEXT_PLAYER1 + s); if (thiscam->reset) @@ -1245,7 +1250,10 @@ void R_SetupFrame(int s, boolean skybox) newview->y = viewmobj->y; newview->z = viewmobj->z + 20*FRACUNIT; - R_SetupCommonFrame(player, viewmobj->subsector); + if (!P_MobjWasRemoved(viewmobj)) + subsector = viewmobj->subsector; + + R_SetupCommonFrame(player, subsector); } else if (!player->spectator && (thiscam && chasecam)) // use outside cam view { @@ -1266,7 +1274,10 @@ void R_SetupFrame(int s, boolean skybox) newview->y = viewmobj->y; newview->z = player->viewz; - R_SetupCommonFrame(player, viewmobj->subsector); + if (!P_MobjWasRemoved(viewmobj)) + subsector = viewmobj->subsector; + + R_SetupCommonFrame(player, subsector); } } diff --git a/src/r_things.c b/src/r_things.c index 0c3e13a1b..60d5bfe97 100644 --- a/src/r_things.c +++ b/src/r_things.c @@ -2764,7 +2764,7 @@ boolean R_ThingVisible (mobj_t *thing) if (thing->sprite == SPR_NULL || thing->flags2 & MF2_DONTDRAW) return false; - if (viewmobj && (thing == viewmobj)) + if (!P_MobjWasRemoved(viewmobj) && (thing == viewmobj)) return false; if (splitscreen)