From 0d4db5eb33ac9aed2c08c49e8f3782ab9adf1b9d Mon Sep 17 00:00:00 2001 From: Alug Date: Thu, 5 Jun 2025 14:45:37 +0200 Subject: [PATCH] kill static buffer for tiltlighting, again kinda ugly but gets the job done lel --- src/r_draw_span.c | 40 ++++++++++++++++++++++++++++++++++++---- src/r_main.c | 1 - 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/src/r_draw_span.c b/src/r_draw_span.c index 5d1a08631..fb332d252 100644 --- a/src/r_draw_span.c +++ b/src/r_draw_span.c @@ -371,7 +371,15 @@ void R_DrawTiltedSpan(drawspandata_t* ds) float endz, endu, endv; UINT32 stepu, stepv; register UINT32 bit; - INT32 tiltlighting[MAXVIDWIDTH]; // TODO: get rid of static buffer + static INT32 *tiltlighting = NULL; + static INT32 oldviewwidth = 0; + + // dont realloc every frame pls thx + if (tiltlighting == NULL || oldviewwidth != viewwidth) + { + tiltlighting = Z_Realloc(tiltlighting, sizeof(*tiltlighting) * viewwidth, PU_STATIC, NULL); + oldviewwidth = viewwidth; + } iz = ds->szp.z + ds->szp.y*(centery-ds->y) + ds->szp.x*(ds->x1-centerx); @@ -510,7 +518,15 @@ void R_DrawTiltedTranslucentSpan(drawspandata_t* ds) float endz, endu, endv; UINT32 stepu, stepv; register UINT32 bit; - INT32 tiltlighting[MAXVIDWIDTH]; + static INT32 *tiltlighting = NULL; + static INT32 oldviewwidth = 0; + + // dont realloc every frame pls thx + if (tiltlighting == NULL || oldviewwidth != viewwidth) + { + tiltlighting = Z_Realloc(tiltlighting, sizeof(*tiltlighting) * viewwidth, PU_STATIC, NULL); + oldviewwidth = viewwidth; + } iz = ds->szp.z + ds->szp.y*(centery-ds->y) + ds->szp.x*(ds->x1-centerx); @@ -650,7 +666,15 @@ void R_DrawTiltedTranslucentWaterSpan(drawspandata_t* ds) float endz, endu, endv; UINT32 stepu, stepv; register UINT32 bit; - INT32 tiltlighting[MAXVIDWIDTH]; + static INT32 *tiltlighting = NULL; + static INT32 oldviewwidth = 0; + + // dont realloc every frame pls thx + if (tiltlighting == NULL || oldviewwidth != viewwidth) + { + tiltlighting = Z_Realloc(tiltlighting, sizeof(*tiltlighting) * viewwidth, PU_STATIC, NULL); + oldviewwidth = viewwidth; + } iz = ds->szp.z + ds->szp.y*(centery-ds->y) + ds->szp.x*(ds->x1-centerx); @@ -790,7 +814,15 @@ void R_DrawTiltedSplat(drawspandata_t* ds) float endz, endu, endv; UINT32 stepu, stepv; register UINT32 bit; - INT32 tiltlighting[MAXVIDWIDTH]; + static INT32 *tiltlighting = NULL; + static INT32 oldviewwidth = 0; + + // dont realloc every frame pls thx + if (tiltlighting == NULL || oldviewwidth != viewwidth) + { + tiltlighting = Z_Realloc(tiltlighting, sizeof(*tiltlighting) * viewwidth, PU_STATIC, NULL); + oldviewwidth = viewwidth; + } iz = ds->szp.z + ds->szp.y*(centery-ds->y) + ds->szp.x*(ds->x1-centerx); diff --git a/src/r_main.c b/src/r_main.c index c9e2cc6cd..dcfa5809e 100644 --- a/src/r_main.c +++ b/src/r_main.c @@ -1447,7 +1447,6 @@ void R_RenderPlayerView(player_t *player) PS_START_TIMING(ps_bsptime); R_RenderViewpoint(&masks[nummasks - 1]); PS_STOP_TIMING(ps_bsptime); - PS_START_TIMING(ps_sw_spritecliptime); R_ClipSprites(); PS_STOP_TIMING(ps_sw_spritecliptime);