diff --git a/libs/libbacktrace/LICENSE.txt b/libs/libbacktrace/LICENSE.txt index 495411538..e9e256244 100644 --- a/libs/libbacktrace/LICENSE.txt +++ b/libs/libbacktrace/LICENSE.txt @@ -5,13 +5,13 @@ # met: # (1) Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. +# notice, this list of conditions and the following disclaimer. # (2) Redistributions in binary form must reproduce the above copyright # notice, this list of conditions and the following disclaimer in # the documentation and/or other materials provided with the -# distribution. - +# distribution. + # (3) The name of the author may not be used to # endorse or promote products derived from this software without # specific prior written permission. @@ -26,4 +26,4 @@ # HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, # STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -# POSSIBILITY OF SUCH DAMAGE. \ No newline at end of file +# POSSIBILITY OF SUCH DAMAGE. diff --git a/libs/libbacktrace/README.md b/libs/libbacktrace/README.md index c82834d17..1a7a04568 100644 --- a/libs/libbacktrace/README.md +++ b/libs/libbacktrace/README.md @@ -10,8 +10,18 @@ The libbacktrace library may be linked into a program or library and used to produce symbolic backtraces. Sample uses would be to print a detailed backtrace when an error occurs or to gather detailed profiling information. + In general the functions provided by this library are async-signal-safe, meaning that they may be safely called from a signal handler. +That said, on systems that use `dl_iterate_phdr`, such as GNU/Linux, +the first call to a libbacktrace function will call `dl_iterate_phdr`, +which is not in general async-signal-safe. Therefore, programs +that call libbacktrace from a signal handler should ensure that they +make an initial call from outside of a signal handler. +Similar considerations apply when arranging to call libbacktrace +from within malloc; `dl_iterate_phdr` can also call malloc, +so make an initial call to a libbacktrace function outside of +malloc before trying to call libbacktrace functions within malloc. The libbacktrace library is provided under a BSD license. See the source files for the exact license text. @@ -25,7 +35,7 @@ will work. See the source file backtrace-supported.h.in for the macros that it defines. -As of October 2020, libbacktrace supports ELF, PE/COFF, Mach-O, and +As of July 2024, libbacktrace supports ELF, PE/COFF, Mach-O, and XCOFF executables with DWARF debugging information. In other words, it supports GNU/Linux, *BSD, macOS, Windows, and AIX. The library is written to make it straightforward to add support for diff --git a/libs/libbacktrace/lib/x86_64/libbacktrace.a b/libs/libbacktrace/lib/x86_64/libbacktrace.a index 4b4447b58..e0d1c4e9d 100644 Binary files a/libs/libbacktrace/lib/x86_64/libbacktrace.a and b/libs/libbacktrace/lib/x86_64/libbacktrace.a differ diff --git a/libs/libbacktrace/lib/x86_64/libbacktrace.la b/libs/libbacktrace/lib/x86_64/libbacktrace.la new file mode 100644 index 000000000..65545c71e --- /dev/null +++ b/libs/libbacktrace/lib/x86_64/libbacktrace.la @@ -0,0 +1,41 @@ +# libbacktrace.la - a libtool library file +# Generated by libtool (GNU libtool 1.3134 2009-11-29) 2.2.7a +# +# Please DO NOT delete this file! +# It is necessary for linking the library. + +# The name that we can dlopen(3). +dlname='' + +# Names of this library. +library_names='' + +# The name of the static archive. +old_library='libbacktrace.a' + +# Linker flags that can not go in dependency_libs. +inherited_linker_flags='' + +# Libraries that this one depends upon. +dependency_libs='' + +# Names of additional weak libraries provided by this library +weak_library_names='' + +# Version information for libbacktrace. +current=0 +age=0 +revision=0 + +# Is this an already installed library? +installed=no + +# Should we warn about portability when linking against -modules? +shouldnotlink=no + +# Files to dlopen/dlpreopen +dlopen='' +dlpreopen='' + +# Directory that this library needs to be installed in: +libdir='/mingw64/lib' diff --git a/libs/libbacktrace/lib/x86_64/libbacktrace.lai b/libs/libbacktrace/lib/x86_64/libbacktrace.lai new file mode 100644 index 000000000..594559c43 --- /dev/null +++ b/libs/libbacktrace/lib/x86_64/libbacktrace.lai @@ -0,0 +1,41 @@ +# libbacktrace.la - a libtool library file +# Generated by libtool (GNU libtool 1.3134 2009-11-29) 2.2.7a +# +# Please DO NOT delete this file! +# It is necessary for linking the library. + +# The name that we can dlopen(3). +dlname='' + +# Names of this library. +library_names='' + +# The name of the static archive. +old_library='libbacktrace.a' + +# Linker flags that can not go in dependency_libs. +inherited_linker_flags='' + +# Libraries that this one depends upon. +dependency_libs='' + +# Names of additional weak libraries provided by this library +weak_library_names='' + +# Version information for libbacktrace. +current=0 +age=0 +revision=0 + +# Is this an already installed library? +installed=yes + +# Should we warn about portability when linking against -modules? +shouldnotlink=no + +# Files to dlopen/dlpreopen +dlopen='' +dlpreopen='' + +# Directory that this library needs to be installed in: +libdir='/mingw64/lib' diff --git a/src/doomdef.h b/src/doomdef.h index eba5ed5b1..30419978b 100644 --- a/src/doomdef.h +++ b/src/doomdef.h @@ -92,7 +92,7 @@ extern char logfilename[1024]; // not sure if this belongs here lul // TODO: figure out whats preventing 32bit windows from working with libbacktrace -#if defined(_WIN32) && !defined(MINGW64) +#if defined(_WIN32) && !defined(__MINGW64__) #define HAVE_DRMINGW #endif diff --git a/src/qs22j.c b/src/qs22j.c index bc94d6648..3b0b6151a 100644 --- a/src/qs22j.c +++ b/src/qs22j.c @@ -18,7 +18,6 @@ #include #include "qs22j.h" -#include "doomdef.h" #define INSORTTHRESH 5 // if n < this use insertion sort // MUST be >= 2 @@ -89,7 +88,7 @@ static inline char *med3(char *a, char *b, char *c, int (*compar)(const void *, void qs22j(void *base, size_t nmemb, size_t size, int (*compar)(const void *, const void *)) { // we have nothing to sort - if (UNLIKELY(nmemb <= 1)) + if (__builtin_expect(!!(nmemb <= 1), 0) ) //UNLIKELY - thx windoze { return; } diff --git a/src/sdl/i_system.cpp b/src/sdl/i_system.cpp index 97d9b27b4..7314995e8 100644 --- a/src/sdl/i_system.cpp +++ b/src/sdl/i_system.cpp @@ -1453,122 +1453,7 @@ void I_SleepDuration(precise_t duration) #endif } -#ifdef HAVE_THREADS -#include "../core/thread_pool.h" -static std::thread::id g_main_thread_id; -#endif - -boolean g_in_exiting_signal_handler = false; - -static void I_PrintSignal(INT32 signal_num, boolean core_dumped, char *signal_msg) -{ - const char *sigmsg; - - switch (signal_num) - { -#ifdef SIGINT - case SIGINT: - sigmsg = ("SIGINT - SRB2Kart-Saturn was interrupted prematurely by the user."); - break; -#endif - case SIGILL: // illegal instruction - invalid function image - sigmsg = ("SIGILL - SRB2Kart-Saturn has attempted to execute an illegal instruction and needs to close."); - break; - case SIGFPE: // mathematical exception - sigmsg = ("SIGFPE - SRB2Kart-Saturn has encountered a mathematical exception and needs to close."); - break; - case SIGSEGV: // segment violation - sigmsg = ("SIGSEGV - SRB2Kart-Saturn has attempted to access a memory location that it shouldn't and needs to close."); - break; -#ifdef SIGTERM - case SIGTERM: // Software termination signal from kill - sigmsg = ("SIGTERM - SRB2Kart-Saturn was terminated by a kill signal."); - break; -#endif -#ifdef SIGBREAK - case SIGBREAK: // Ctrl-Break sequence - sigmsg =("SIGBREAK - SRB2Kart-Saturn was terminated by a Ctrl-Break sequence.") - break; -#endif - case SIGABRT: // abnormal termination triggered by abort call - sigmsg = ("SIGABRT - SRB2Kart-Saturn was terminated by an abort signal."); - break; - default: - sprintf(signal_msg, "Signal number %d", signal_num); - sigmsg = (core_dumped ? "Unknown signal" : signal_msg); - break; - } - - if (core_dumped) - { - if (sigmsg) - sprintf(signal_msg, "%s (core dumped)", sigmsg); - else - strcat(signal_msg, " (core dumped)"); - } - else - { - sprintf(signal_msg, "%s", sigmsg); - } -} - -static void I_ReportSignal(int num, int coredumped) -{ - char sigmsg[512]; - - I_PrintSignal(num, coredumped, sigmsg); - - size_t len = strlen(sigmsg); - snprintf(sigmsg + len, sizeof(sigmsg) - len, "\n\nCrash report has been saved into %s", CRASH_LOGFILE_NAME); - I_OutputMsg("\nProcess killed by signal: %s\n\n", sigmsg); - SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "Process killed by signal", sigmsg, NULL); -} - -#ifndef NEWSIGNALHANDLER -FUNCNORETURN static ATTRNORETURN void signal_handler(INT32 num) -{ - g_in_exiting_signal_handler = true; - -#ifdef HAVE_THREADS - if (g_main_thread_id != std::this_thread::get_id()) - { - // Do not attempt any sort of recovery if this signal triggers off the main thread - signal(num, SIG_DFL); - raise(num); - exit(-2); - } -#endif - - D_QuitNetGame(); // Fix server freezes - -#ifdef HAVE_LIBBACKTRACE - write_backtrace(BT_CRASH_REASON_SIGNAL(num)); -#endif - - I_ReportSignal(num, 0); - I_ShutdownSystem(); - signal(num, SIG_DFL); //default signal action - raise(num); - I_Quit(); -} -#endif - -FUNCNORETURN static ATTRNORETURN void quit_handler(int num) -{ -#ifdef HAVE_THREADS - if (g_main_thread_id != std::this_thread::get_id()) - { - // Do not attempt any sort of recovery if this signal triggers off the main thread - signal(num, SIG_DFL); - raise(num); - exit(-2); - } -#endif - - signal(num, SIG_DFL); //default signal action - raise(num); - I_Quit(); -} +static void I_PrintSignal(INT32 signal_num, boolean core_dumped, char *signal_msg); #ifdef HAVE_LIBBACKTRACE #include @@ -1750,6 +1635,123 @@ static void write_backtrace(bt_crash_reason_t reason) } #endif +#ifdef HAVE_THREADS +#include "../core/thread_pool.h" +static std::thread::id g_main_thread_id; +#endif + +boolean g_in_exiting_signal_handler = false; + +static void I_PrintSignal(INT32 signal_num, boolean core_dumped, char *signal_msg) +{ + const char *sigmsg; + + switch (signal_num) + { +#ifdef SIGINT + case SIGINT: + sigmsg = ("SIGINT - SRB2Kart-Saturn was interrupted prematurely by the user."); + break; +#endif + case SIGILL: // illegal instruction - invalid function image + sigmsg = ("SIGILL - SRB2Kart-Saturn has attempted to execute an illegal instruction and needs to close."); + break; + case SIGFPE: // mathematical exception + sigmsg = ("SIGFPE - SRB2Kart-Saturn has encountered a mathematical exception and needs to close."); + break; + case SIGSEGV: // segment violation + sigmsg = ("SIGSEGV - SRB2Kart-Saturn has attempted to access a memory location that it shouldn't and needs to close."); + break; +#ifdef SIGTERM + case SIGTERM: // Software termination signal from kill + sigmsg = ("SIGTERM - SRB2Kart-Saturn was terminated by a kill signal."); + break; +#endif +#ifdef SIGBREAK + case SIGBREAK: // Ctrl-Break sequence + sigmsg =("SIGBREAK - SRB2Kart-Saturn was terminated by a Ctrl-Break sequence."); + break; +#endif + case SIGABRT: // abnormal termination triggered by abort call + sigmsg = ("SIGABRT - SRB2Kart-Saturn was terminated by an abort signal."); + break; + default: + sprintf(signal_msg, "Signal number %d", signal_num); + sigmsg = (core_dumped ? "Unknown signal" : signal_msg); + break; + } + + if (core_dumped) + { + if (sigmsg) + sprintf(signal_msg, "%s (core dumped)", sigmsg); + else + strcat(signal_msg, " (core dumped)"); + } + else + { + sprintf(signal_msg, "%s", sigmsg); + } +} + +static void I_ReportSignal(int num, int coredumped) +{ + char sigmsg[512]; + + I_PrintSignal(num, coredumped, sigmsg); + + size_t len = strlen(sigmsg); + snprintf(sigmsg + len, sizeof(sigmsg) - len, "\n\nCrash report has been saved into %s", CRASH_LOGFILE_NAME); + I_OutputMsg("\nProcess killed by signal: %s\n\n", sigmsg); + SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "Process killed by signal", sigmsg, NULL); +} + +#ifndef NEWSIGNALHANDLER +FUNCNORETURN static ATTRNORETURN void signal_handler(INT32 num) +{ + g_in_exiting_signal_handler = true; + +#ifdef HAVE_THREADS + if (g_main_thread_id != std::this_thread::get_id()) + { + // Do not attempt any sort of recovery if this signal triggers off the main thread + signal(num, SIG_DFL); + raise(num); + exit(-2); + } +#endif + + D_QuitNetGame(); // Fix server freezes + +#ifdef HAVE_LIBBACKTRACE + write_backtrace(BT_CRASH_REASON_SIGNAL(num)); +#endif + + I_ReportSignal(num, 0); + I_ShutdownSystem(); + signal(num, SIG_DFL); //default signal action + raise(num); + I_Quit(); +} +#endif + +FUNCNORETURN static ATTRNORETURN void quit_handler(int num) +{ +#ifdef HAVE_THREADS + if (g_main_thread_id != std::this_thread::get_id()) + { + // Do not attempt any sort of recovery if this signal triggers off the main thread + signal(num, SIG_DFL); + raise(num); + exit(-2); + } +#endif + + signal(num, SIG_DFL); //default signal action + raise(num); + I_Quit(); +} + static void I_RegisterSignals(void) { #ifdef HAVE_THREADS