From 0ad326236607df0802dc72c4f13b3f35484b7672 Mon Sep 17 00:00:00 2001 From: Werner Lemberg Date: Thu, 1 Jun 2017 17:00:37 +0200 Subject: [PATCH] * src/base/ftglyph.c (FT_Get_Glyph): Check `slot->advance'. --- ChangeLog | 4 ++++ src/base/ftglyph.c | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/ChangeLog b/ChangeLog index 57753f2cc..35b18c12d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2017-06-01 Werner Lemberg + + * src/base/ftglyph.c (FT_Get_Glyph): Check `slot->advance'. + 2017-06-01 Werner Lemberg [psaux] 32bit integer overflow tun-time errors (#46149). diff --git a/src/base/ftglyph.c b/src/base/ftglyph.c index 9bfb33050..62d94cbd3 100644 --- a/src/base/ftglyph.c +++ b/src/base/ftglyph.c @@ -408,6 +408,19 @@ goto Exit; /* copy advance while converting 26.6 to 16.16 format */ + if ( slot->advance.x >= 0x8000L * 64 || + slot->advance.x <= -0x8000L * 64 ) + { + FT_ERROR(( "FT_Get_Glyph: advance width too large\n" )); + return FT_THROW( Invalid_Argument ); + } + if ( slot->advance.y >= 0x8000L * 64 || + slot->advance.y <= -0x8000L * 64 ) + { + FT_ERROR(( "FT_Get_Glyph: advance height too large\n" )); + return FT_THROW( Invalid_Argument ); + } + glyph->advance.x = slot->advance.x * 1024; glyph->advance.y = slot->advance.y * 1024;